| 08:37 |
mmorgan |
Stompro++ |
| 08:48 |
Stompro |
In the last hour I see 900 cover art requests with a 200 status, and 7 with a 500 status. So a few errors but it seems ok. |
| 08:50 |
Stompro |
I should learn how to monitor that with our zabbix system. |
| 08:56 |
jeff |
several options there. first and easiest (though not quite a "real" check) is to add an http item on an existing (or new) host where you're using the zabbix agent (or agent 2). |
| 08:57 |
jeff |
(another option is to monitor the actual log file.) |
| 08:58 |
jeff |
in the first, you're testing the content cafe endpoint directly, which could miss problems (in some scenarios), but is probably good enough for the kind of problem you've been describing of late. |
| 08:59 |
JBoyer |
I hear OpenSRF 3.2.3 just dropped. Seems like pretty neat stuff. |
| 08:59 |
JBoyer |
kmlussier++ |
| 09:00 |
jeff |
kmlussier++ JBoyer++ |
| 07:10 |
|
kworstell_isl joined #evergreen |
| 07:29 |
gmcharlt |
I have pushed the bootstrap 5 + angular15 branch that berick, sleary, and sandbergja have been working on to master |
| 07:30 |
gmcharlt |
the BS5 upgrade in particular introduces a number of changes to how Bootstrap CSS classes work, so if you run into trouble when reviewing Angular changes that predate this morning, please be aware (and don't hesitate to ask for help, especially if you have an opportunity to bug berick and sleary in person at the conference) |
| 07:46 |
pinesol |
News from commits: LP#2000482: add a brief release notes entry <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=09b001a2dbc5dd8877b5f61d9f4ecb5a68d9403f> |
| 07:46 |
pinesol |
News from commits: LP#2000482: (follow-up) couple more layout tweaks <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=635370da24e9b2ed7da887e48045688a1e9443cb> |
| 07:46 |
pinesol |
News from commits: LP#2000482: (follow-up) update Angular cheat sheet <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c37328795ac368f4a0b4f5f7514a5b31a25abb27> |
| 07:46 |
pinesol |
News from commits: LP2000482: Get tests passing <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c1fcbda53d2d2a7858464fb8ca808e814cb7bcdf> |
| 07:46 |
pinesol |
News from commits: LP2000482: update tsconfig options to satisfy compiler warning <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7d8923e075a83318acf01a3236587c802278f4bc> |
| 07:46 |
pinesol |
News from commits: LP2000482 Bootstrap 5 continued <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3b747e6fd12089c22dfac928ad6b692f69279a52> |
| 07:46 |
pinesol |
News from commits: LP2000482 Angular 15 and Bootstrap 5 upgrade <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c76e4ad6c2aba1a918992659686bb6b50bfea79c> |
| 08:07 |
csharp_ |
notes for Sys Admin IG: https://docs.google.com/document/d/1EUa9oIvmp5s9mbCRYIwG6dKMEcuirOEKcqbs90OjjWc/edit?usp=sharing |
| 08:19 |
|
mmorgan joined #evergreen |
| 08:53 |
|
mmorgan left #evergreen |
| 14:36 |
pinesol |
abneiman is going out with degraafk to see Blighted Tormenter Contours tonight. |
| 14:43 |
gmcharlt |
there's now an updated branch for bug 1997485 |
| 14:43 |
pinesol |
Launchpad bug 1997485 in Evergreen "wishlist: Did you mean? Multi word, single class search suggestions" [Wishlist,Confirmed] https://launchpad.net/bugs/1997485 - Assigned to Galen Charlton (gmc) |
| 14:43 |
gmcharlt |
I think this is ready to go, and I intend to push it tonight, but if anybody intends to test it today, please speak up |
| 14:52 |
|
jvwoolf joined #evergreen |
| 14:54 |
|
kworstell-isl joined #evergreen |
| 15:11 |
|
jihpringle joined #evergreen |
| 16:39 |
jihpringle |
that is outside of my expertise - if you don't get a response from anyone else I'd recommend emailing the general list next week (when people are back from the conference) |
| 16:39 |
jihpringle |
https://evergreen-ils.org/communicate/mailing-lists/ |
| 16:40 |
derekz |
Sounds good. If you're at the conference, I hope you're enjoying it and I appreciate you taking the time to respond |
| 16:47 |
jeffdavis |
derekz: I'm pretty sure the structure of email templates is (1) headers including To, From, and any custom headers, (2) a blank line, (3) the body of the message |
| 16:48 |
jeffdavis |
If you put custom headers with To and From etc *before* the blank line, I think that should work |
| 16:48 |
jeffdavis |
(please test first though, don't take my word for it :) |
| 16:51 |
derekz |
The structural outline is helpful. I'll give it try. Thank you! |
| 17:09 |
derekz |
Does line 83 indicate that only From, To, Bcc, Cc, Reply-To, Sender are being extracted for further processing by the email perl module? |
| 17:09 |
derekz |
https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Trigger/Reactor/SendEmail.pm;h=71354e6b6506ac8584af470fb51f04040ac49ab7;hb=09b001a2dbc5dd8877b5f61d9f4ecb5a68d9403f |
| 17:16 |
|
jvwoolf joined #evergreen |
| 17:19 |
jeffdavis |
derekz: I believe you're not restricted to those headers - our templates add a Message-ID header using the method I described, for example, and it appears to work |
| 17:19 |
jeffdavis |
it may be that other headers are not MIME-encoded |
| 17:23 |
derekz |
(y) I'll do some testing and see how it goes. Headed out for the evening. Thanks for the help! |
| 17:44 |
|
abowling1 joined #evergreen |
| 16:26 |
kmlussier |
git shortlog --group=trailer:signed-off-by --after="03 Apr 2023" --before="20 Apr 2023" -s -- ":(exclude)./docs/" |
| 16:26 |
kmlussier |
Does anyone know if there is a way to count the signoffs where the person signing off is not the author? I'm thinking the answer is no, but maybe somebody smarter than me when it comes to git knows of a way. |
| 16:27 |
Bmagic |
abowling: Try dividing the file that you're submitting in half, and then half again and again until it imports correctly. |
| 16:29 |
abowling |
Bmagic: Thanks, but it's one record (a test) ;) |
| 16:29 |
Bmagic |
kmlussier: I'm wish I knew the right answer for that. After you mentioned it the other day, I spent some time on getting sign-offs out of git with counts like you were talking about. I'm sure someone, ahem gmcharlt, might know it. Since he publishes these numbers sometimes |
| 16:29 |
Bmagic |
abowling: hmmm, do you get this error for any* record? |
| 16:29 |
abowling |
seemingly, yes |
| 10:02 |
Dyrcona |
hrm... This is going to be an interesting rebase... I want to drop a bunch of commits, split one commit up into several smaller commits, and then squash some other commits into the new commits. I wonder if I can get away with doing it once, or will I have to do two rebases.... |
| 10:04 |
Dyrcona |
Now that I think about it, maybe I should rebase a different branch and then recreate the branch that I was planning to rebase from scratch.... |
| 10:19 |
Dyrcona |
I suppose that I could just make a new branch without rebasing either.... |
| 10:25 |
Dyrcona |
hm... wonder if I really need the changes to these two images. I'll make them their own commit so I can remove them later for testing. |
| 10:34 |
|
stephengwills joined #evergreen |
| 10:39 |
Dyrcona |
a) Does anyone use KPAC? b) Do you use override directories with KPAC? |
| 10:52 |
Dyrcona |
Still working on this rebase, and I think I want to reorganize things even more. |
| 08:47 |
|
dguarrac joined #evergreen |
| 08:52 |
|
rfrasur joined #evergreen |
| 09:02 |
|
mantis1 joined #evergreen |
| 10:08 |
Stompro |
jmurray-isl, Re: Content Cafe, they are serving up old images, but only to evergreen libraries because we seem to be the only customers that make use of the XMLPost request method. And they seem to have no way to test request to that service. |
| 10:13 |
Dyrcona |
Stompro: So, someone should open a bug on Lp for us to switch to the REST interface or whatever it is that Koha uses? |
| 10:14 |
Stompro |
Dyrcona, they have a specific method for grabbing just cover art, but we also get author notes and reviews from them. I think the XMLPost method is the only method for grabbing that info. |
| 10:15 |
Dyrcona |
I see... |
| 10:15 |
csharp_ |
Dyrcona++ |
| 10:16 |
csharp_ |
Dyrcona: you used /me, so we all understood that to be internal monologue |
| 10:18 |
Dyrcona |
Yeah, but it is still on the record. |
| 10:18 |
Stompro |
I'm getting really frustrated with them not being able to test their own service. |
| 10:20 |
Dyrcona |
I was just thinking of how I should word this in an email to other CW MARS staff, but I think I'll skip it since no one has opened a ticket, yet. |
| 10:21 |
Dyrcona |
Could we grab images via GET and still get the other information via POST? |
| 10:27 |
Stompro |
Dyrcona, yes, I'm sure that would work, just added complexity. If I remember correctly, it does try and combine different types of content into one request... but I don't think that happens in reality because of how clients request the data. |
| 10:28 |
csharp_ |
most vendors don't really take testing that seriously |
| 10:28 |
csharp_ |
(that could probably provide to all developers everywhere :-)) |
| 10:28 |
* Dyrcona |
thinks we are included in "most vendors." |
| 10:28 |
csharp_ |
s/provide/apply/ |
| 10:28 |
Dyrcona |
csharp_++ |
| 10:58 |
Dyrcona |
There are only 2 hard problems in computer science: naming things, cache invalidation, and off-by-one errors. :) |
| 11:01 |
Stompro |
They asked me what our memcache TTL is... and I'm like, "24 hours, now lets talk about what yours it set to?, it has been serving old data for 5 weeks now??" |
| 11:05 |
Dyrcona |
-1? |
| 11:27 |
jmurray-isl |
Stompro: To test ContentCafe images, I go to the OPAC record and look through the sources for contentcafe. There, I can find something with the following format: https://contentcafe2.btol.com/ContentCafe/jacket.aspx?UserID=<UserID>&Password=<Password>&Return=T&Type=S&Value=<ISBN-Number> |
| 11:27 |
jmurray-isl |
Type equates to S, M, or L. |
| 11:29 |
jmurray-isl |
I mean, it is a bit concerning that just anyone can view our ContentCafe credentials this way... |
| 11:31 |
Bmagic |
jmurray-isl: I had the same thought whilst looking through this code. Syndetics works the same way. The "authentication" is simply our ID string embedded in the query string. If they charged based on number of requests, then I would be a bit more concerned :) |
| 11:36 |
Stompro |
jmurray-isl, our Evergreen setup doesn't expose the username and pw, I did notice that Evergreen Indiana does have two different sets of cover art links. The problem is that the jacket.aspx method is returning fresh data, but the XMLpost method that evergreen uses is serving old data. let me grab an example. |
| 11:37 |
Stompro |
Compare https://evergreen.lib.in.us/opac/extras/ac/jacket/medium/9781608095377 and https://evergreen.lib.in.us/eg/opac/record/22903128 |
| 12:51 |
Dyrcona |
jvwoolf: I seem to recall encountering this before, and I think the only way to fix metarecord maps is to update bib.record_entry. pingest doesn't handle it for sure. |
| 12:52 |
Dyrcona |
It's bug worthy as a feature requrest. |
| 12:52 |
Dyrcona |
request, even. |
| 12:58 |
jvwoolf |
Dyrcona: I updated biblio.record_entry in order to generate the new fingerprints. Do I have to do it again for the metarecords? |
| 12:59 |
jvwoolf |
I think you, JBoyer and I had this conversation before, and what I came away with seemed to work in my first test, but not the most recent few |
| 13:03 |
Dyrcona |
jvwoolf: There's a flag... let me look it up. |
| 13:04 |
Dyrcona |
ingest.reingest.force_on_same_marc <- Needs to be true in config.internal_flag if the MARC didn't change, I think. |
| 13:13 |
jvwoolf |
Dyrcona: This is a global flag? |
| 12:27 |
mantis34 |
this was after running an npm install in the Angular folder |
| 12:40 |
jvwoolf |
We tracked the errors down to this file introduced with the fix for LP 2002435: Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.spec.ts |
| 12:41 |
pinesol |
Launchpad bug 2002435 in Evergreen 3.9 "Can Still Delete Shelving Locations with Items Attached" [Medium,Fix released] https://launchpad.net/bugs/2002435 |
| 13:09 |
JBoyer |
mantis34, jvwoolf, if that's a test failure related to the defaultNewRecord test that's harmless. Because of the timing for the security release we let that through but I can fix it soon. (The "fix" is to just remove that test, because the patch being tested isn't in 3.9) |
| 13:10 |
JBoyer |
But the spec file was added in the conflict resolution of another patch that came after. |
| 13:11 |
|
mmorgan1 joined #evergreen |
| 13:14 |
jvwoolf |
JBoyer++ |
| 13:20 |
|
mmorgan joined #evergreen |
| 13:21 |
|
mantis41 joined #evergreen |
| 13:22 |
|
mmorgan2 joined #evergreen |
| 13:30 |
Dyrcona |
Speaking of tests: Does anyone know the magic sauce to the get cover uploader live test to pass with 3.10 on Debian Bullseye? |
| 13:32 |
Dyrcona |
Apparently, it is getting a 404 response, but the configuration appears to be in place. I'll check that again. |
| 13:34 |
|
mantis25 joined #evergreen |
| 13:35 |
Dyrcona |
I also changed the /tmp directory having some vague memory of that being a problem in the past. |
| 13:39 |
JBoyer |
The failing test on rel_3_9 has been fixed. That doesn't change the 3.9.2 tarball or branch, but we're good going forward/ |
| 13:42 |
JBoyer |
Dyrcona, I think that test depends on /openils/var/web/opac/extras/ac is writable by the apache user. Is apache running as opensrf on your test system? To my knowledge this is the first test that actually uses the local web server. |
| 13:44 |
Dyrcona |
JBoyer: Thanks for the suggestion. It looks like running autogen.sh fixed my issue. |
| 13:44 |
Dyrcona |
I guess I forgot to do it the first time... |
| 13:45 |
gmcharlt |
does anybody happen to have examples of using authorities with 148 fields in production? |
| 13:45 |
Dyrcona |
JBoyer++ |
| 13:45 |
JBoyer |
Probably the first test that depends on that too. :) (I wasn't real fond of adding that to autogen.sh, but it was more expedient than teaching the build system to create the necessary directories) |
| 13:45 |
Dyrcona |
Yeah. I agree. |
| 14:32 |
|
dtmoore joined #evergreen |
| 14:53 |
csharp_ |
gmcharlt: how would we know? |
| 10:31 |
Dyrcona |
When I hash just the relpath "ahr" I get "35b605f929209fc6cba65789d1f6b61c" with Python and with Emacs. |
| 10:33 |
Dyrcona |
With the Python, I went through the steps of split and join, etc., as well just to see if that made a difference. It didn't. |
| 10:36 |
|
mmorgan joined #evergreen |
| 10:42 |
Dyrcona |
I love that this is the only test for the hex_md5 function in our library: return hex_md5("abc") == "900150983cd24fb0d6963f7d28e17f72"; |
| 10:43 |
Dyrcona |
Python, Emacs, and our JS library all agree on that one, just not on other strings. |
| 10:44 |
Dyrcona |
Oops. Spoke too soon. They don't agree. The beginning and ends are the same. |
| 10:44 |
Dyrcona |
So, I suspect a bug in md5.js.... |
| 12:18 |
gmcharlt |
(though 99% of the time it would, since there's little reason to have not done a configure/make in your Git checkout) |
| 12:18 |
gmcharlt |
more likelike to bite one is making changes to Cronscript.pm and forgeting that Cronscript.pm.in is the file that's acdtually under version control |
| 12:18 |
gmcharlt |
*likely |
| 12:20 |
Bmagic |
I see. So in almost all of the Perl file cases, you can edit the *.pm files in the repository, and with the symlink, they would be "live" (after a service restart) - whereas, Cronscript.pm.in is not "live" and I would need to copy my changes from Cronscript.pm -> Cronscript.pm.in once tested |
| 12:21 |
gmcharlt |
yep |
| 12:21 |
Bmagic |
gmcharlt++ |
| 12:21 |
gmcharlt |
(though in practice, that file does not get touched all that often) |
| 12:29 |
Dyrcona |
All of the *.in files bet mangled during installation. Most of them are modified with sed. There's a better way to do it with make targets to have AC_SUBST run on them. |
| 12:29 |
Dyrcona |
s/bet/get/ |
| 12:30 |
Dyrcona |
Well, I guess we'd add them to a list in configure.ac. |
| 12:33 |
Dyrcona |
You can copy the files from lib over to the installation location after you've modified them, then restart services. That's what I do if I'm testing a change in one or two files. |
| 12:34 |
|
collum joined #evergreen |
| 12:38 |
Dyrcona |
So, when I load the report utils functions and the md5 functions in jsc, I do NOT get the same relation values that I'm seeing in this one reports template. I'm going to check another template with the same tables. |
| 12:44 |
* Dyrcona |
must be missing something in the composition of path, but I'm using the path that appears in the report template itself, which is what the JS code appears to use. |
| 09:08 |
pinesol |
News from commits: LP2002435: Add optional undelete action to basic admin page <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=be72a596d18fac13f35ffc14e9c62d559a3a3f10> |
| 09:08 |
pinesol |
News from commits: LP2002435: Don't allow shelving location fm-editor to change delete flag <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3bd72a7782696ff03c8823c03459fee3be435d89> |
| 09:26 |
Bmagic |
Dyrcona: It's probably a missing/malformed environment or template making use of something that doesn't exist |
| 09:52 |
Dyrcona |
Bmagic: Maybe. I've noticed that the standard filters have not been renamed on the utility server. I'm testing that hypothesis first. |
| 09:56 |
Dyrcona |
Yeah. Renaming action_trigger_filters.json.example to action_trigger_filters.json fixed one of the two events on my test vm. (I found another that had not run since October 9.) |
| 09:57 |
Dyrcona |
Well, let's say it appeared to fix the event. |
| 09:58 |
Dyrcona |
Since one of the events has hourly granularity, I'll change it in production and see what happens in 10 to 15 minutes or so. |
| 10:03 |
Dyrcona |
Yeah, that was it. I got events for the hourly granularity event had not had an event created since 2022-10-09. Funny that no one noticed. Maybe we don't need to send out reminders that items are about to expire on the hold shelf? |
| 10:18 |
* mmorgan |
was going to suggest inserting Autorenew notify events directly into the table, but that's not necessary in your case. |
| 10:31 |
Dyrcona |
Well, if I had to do that, I was going to use Perl with DBI to figure out the user data for the autorenew notify events, and then use open-ils.trigger.event.autocreate to make the notify events. |
| 10:31 |
|
ahazaril joined #evergreen |
| 10:32 |
ahazaril |
I'm having difficulty to import MARC Records. Evergreen version that I used are 3.9.1. I follow the manual exactly. I tried on test server (https://bugsquash.mobiusconsortium.org/eg/staff) seems successfully, but when I tried using our Library Server, its shown error. |
| 10:32 |
ahazaril |
Any advice regarding this problems? |
| 10:32 |
ahazaril |
Here the osrfsys.log file |
| 10:32 |
ahazaril |
[2023-03-10 20:30:14] open-ils.vandelay [INFO:6795:CStoreEditor.pm:155:1678451399712214] editor[1|1] request en-US open-ils.cstore.json_query.atomic {"select":{"au":[{"column":"id","transform":"permission.usr_has_object_perm","params":["CREATE_BIB_IMPORT_QUEUE","vbq",4,"1"],"alias":"has_perm"}]},"where":{"id":"1"},"from":"au"} |
| 10:32 |
ahazaril |
open-ils.cstore 2023-03-10 20:30:14 [INFO:6996:osrf_application.c:1075:1678451399712214] CALL: open-ils.cstore open-ils.cstore.json_query.atomic {"from":"au","where":{"id":"1"},"select":{"au":[{"transform":"permission.usr_has_object_perm","column":"id","alias":"has_perm","params":["CREATE_BIB_IMPORT_QUEUE","vbq",4,"1"]}]}} |
| 10:32 |
ahazaril |
open-ils.cstore 2023-03-10 20:30:14 [INFO:6996:osrf_app_session.c:1181:1678451399712214] [open-ils.cstore] sent 385 bytes of data to opensrf private.localhost/open-ils.vandelay_drone_at_localhost_6795 |
| 10:32 |
ahazaril |
open-ils.cstore 2023-03-10 20:30:14 [INFO:6996:osrf_stack.c:163:1678451399712214] Message processing duration 0.006715 |
| 10:32 |
ahazaril |
[2023-03-10 20:30:14] open-ils.vandelay [INFO:6795:CStoreEditor.pm:155:1678451399712214] editor[1|1] json_query : returned 1 result(s) |
| 10:32 |
ahazaril |
[2023-03-10 20:30:14] open-ils.vandelay [ERR :6795:Vandelay.pm:272:1678451399712214] unable to read MARC file /tmp/bc98fed09b3081514035f98464280b7c.mrc |
| 10:32 |
ahazaril |
[2023-03-10 12:30:14] open-ils.vandelay [INFO:6795:Transport.pm:163:1678451399712214] Message processing duration: 0.137 |
| 10:32 |
ahazaril |
open-ils.cstore 2023-03-10 20:30:14 [INFO:6996:osrf_stack.c:163:1678451399712214] Message processing duration 0.000004 |
| 10:33 |
berick |
ahazaril: see this https://bugs.launchpad.net/evergreen/+bug/1855199 |
| 10:33 |
pinesol |
Launchpad bug 1855199 in Evergreen "Vandelay record queuing can fail if spool directory is /tmp" [Medium,Confirmed] |
| 10:34 |
ahazaril |
tq berick & pinesol! |
| 12:13 |
Dyrcona |
I don't imagine it would be that hard to add it to Angular. |
| 12:30 |
Stompro |
mmorgan, works for me now also. |
| 12:31 |
|
collum joined #evergreen |
| 13:37 |
Stompro |
First live perl test created!!! I want a badge. |
| 13:38 |
Dyrcona |
Heh. |
| 13:38 |
Stompro |
It took me an embarrassing long time to get it right. |
| 13:39 |
Dyrcona |
Stompro++ |
| 13:40 |
Dyrcona |
Was getting the number of tests correct at the top of the file one of those issues? |
| 13:45 |
Stompro |
No, I just ran it and updated that number once things seemed to be working. |
| 13:46 |
Stompro |
But maybe I misunderstood it. |
| 13:47 |
Stompro |
Dyrcona, I'll put my ncip changes into the ncip working repo, thanks for the feedback. I was being careless with our new repo, I'll get it fixed up. |
| 13:51 |
Dyrcona |
Stompro coll on both fronts. |
| 13:52 |
Dyrcona |
For tests, there's a trick to have it calculate them for you. |
| 13:56 |
Dyrcona |
Stompro: https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/live_t/lp1883171-copy-inventory.t;h=a745939ba04e166d8981942bedad3e2e5f0bc514;hb=HEAD uses done_testing() at the end because it runs a variable number of tests depending on circumstances. |
| 13:58 |
Dyrcona |
!-3:s/coll/cool/ |
| 14:03 |
mmorgan |
Stompro++ |
| 14:14 |
Dyrcona |
We need more tests and they need to be more complete, but time..... |
| 14:14 |
csharp_ |
@decide coll or cool |
| 14:14 |
pinesol |
csharp_: go with cool |
| 14:15 |
csharp_ |
test writing sounds like a decent thing for the newdev group to consider |
| 14:16 |
Dyrcona |
In some ways writing tests is harder than writing regular code. |
| 14:17 |
Dyrcona |
Or, I think it ought to be harder. |
| 14:38 |
jeffdavis |
This query has been running in our database for over a week: SELECT * FROM action.emergency_closing_stage_2_circ( '390528' ) |
| 14:38 |
jeffdavis |
The circ in question has an hourly loan duration. |
| 11:46 |
Dyrcona |
query.. |
| 11:48 |
Dyrcona |
hmm.. this is already too big... |
| 11:48 |
Dyrcona |
And, I should use a non-replica db: pg_dump: detail: Error message from server: ERROR: canceling statement due to conflict with recovery |
| 11:50 |
Dyrcona |
I'll just see about pulling the data that I need. I've been asked to delete some data from acquisitions and I think I need to modify the function that I wrote for that, so I want to pull the data into a test database to try it out there first. |
| 12:05 |
|
jihpringle joined #evergreen |
| 12:11 |
pinesol |
News from commits: LP1989284 Input labels for Manage Authorities <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=582ba4e9761461606db7459360376ac01ca97a91> |
| 12:11 |
pinesol |
News from commits: LP1997098 Stamping DB Upgrade: PG 15 <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=cce04dcc77309d86ee6a241e8487750e0ef43c60> |
| 12:16 |
berick |
Stompro: all expire times for frozen holds are null for us |
| 12:18 |
Dyrcona |
What berick said goes for us too. |
| 12:18 |
jeffdavis |
192 frozen holds with non-null expire_time here |
| 12:19 |
Dyrcona |
berick: I think I'll just use copy with queries to dump only the rows that I need to do my test. |
| 12:19 |
Stompro |
Great, it probably isn't an issue then, just some strange data in our system. |
| 12:20 |
Dyrcona |
It might not hurt to add something to the db upgrade to null the expire_time on frozen holds. |
| 12:20 |
Dyrcona |
jeffdavis just reported having some. |
| 13:23 |
Dyrcona |
csharp_: I fix that one and I get more. |
| 13:27 |
Dyrcona |
csharp_: I have a patch, but I want to make sure it is correct. |
| 13:32 |
Dyrcona |
I think we might want to fix some of the other changes from 06dd3972f5b |
| 13:47 |
csharp_ |
Dyrcona: thanks - happy to test when you're ready |
| 13:47 |
Dyrcona |
csharp_: No usable branch yet, but I did open a Lp 2008925 |
| 13:47 |
pinesol |
Launchpad bug 2008925 in Evergreen "Template Toolkit Syntax Errors Introduced by Aria Label Fix" [Undecided,New] https://launchpad.net/bugs/2008925 |
| 13:53 |
csharp_ |
Dyrcona++ |
| 16:47 |
kmlussier |
Oh! Of course. This must've been a post-Kathy thing then, because I don't remember seeing it before. |
| 16:48 |
* Bmagic |
says Good to see you kmlussier! |
| 16:48 |
mmorgan |
JBoyer: You need to do a sweetdumpling next. |
| 16:49 |
JBoyer |
Yeah, it's a post-2019 thing, I didn't regularly run a testing server this week until I started at EOLI. (We did do some local testing on prod-ish data at the ISL) |
| 16:49 |
kmlussier |
butternut is my favorite squash |
| 16:49 |
berick |
if it's in GA, sweetdumplin' |
| 16:49 |
JBoyer |
I apparently have to look this up. |
| 07:47 |
|
BDorsey joined #evergreen |
| 08:30 |
|
mmorgan joined #evergreen |
| 08:31 |
|
kworstell-isl joined #evergreen |
| 08:33 |
Stompro |
mmorgan, I didn't see your question on Friday, B&T did say it was on their end. It is still broken this morning when I test it. |
| 08:35 |
mmorgan |
Stompro: Thanks! I got a similar reply from B&T late Friday. Tested it first thing myself, too.:) Still broken.:-( |
| 08:57 |
|
kworstell-isl joined #evergreen |
| 09:24 |
|
kworstell-isl joined #evergreen |
| 09:37 |
|
dguarrac joined #evergreen |
| 10:22 |
ahazaril |
when i'm doing check-out, it shows error: no_matchpoint |
| 10:22 |
csharp_ |
ahazaril: for all items or just some? |
| 10:23 |
csharp_ |
ahazaril: that error means that the conditions of the circulation didn't match any of the rules you've configured |
| 10:23 |
jeff |
It sounds like you have created some policies (based on your post to the mailing list, "Unable to Create Circulation Policies"), but it's possible that the policies you have now created are too specific, and aren't matching the item + library + user that you're testing with. Sometimes a "catch-all" policy helps, other times you *want* to know that things are amiss -- like the current "no matchpoint" error |
| 10:23 |
ahazaril |
actually i just installed back Evergreen and i'm not fully skilful enough to set up Evergreen |
| 10:23 |
jeff |
you're getting. |
| 10:24 |
ahazaril |
i see |
| 12:11 |
Stompro |
Full "<Error>Database 'Jacket' does not exist. Make sure that the name is entered correctly.</Error>" |
| 12:17 |
Dyrcona |
The flipped the case sensitivity flag in their database and didn't tell anyone? |
| 12:18 |
* Dyrcona |
should shut up for now and concentrate on lunch. |
| 12:19 |
Stompro |
Maybe it has to do with requesting multiple keys at once. I'll test if it works with just one search key. |
| 12:22 |
Stompro |
I'll see if my postman account still works and try the case sensitivity thing. |
| 12:27 |
Stompro |
Same result with just one search key. |
| 12:28 |
Stompro |
B&T support says they are reviewing the info now. |
| 12:30 |
Dyrcona |
Bmagic: What you said to me privately about PG15 search performance yesterday appears to be true. I have a Pg15 instance using default settings that's returning search results just about as fast as Pg10 that is optimized on the same hardware. That is, Pg15 and Pg10 are running on the same server. |
| 12:31 |
|
Guest397 joined #evergreen |
| 12:32 |
Bmagic |
awesome! I like faster |
| 12:36 |
Stompro |
Dyrcona, using jacketdetail or jacketDetail doesn't fix the issue in a test request. So it must be something else. Evergreen must be one of the only products that uses the XmlPost method to grab added content from them. |
| 12:56 |
Dyrcona |
Stompro++ |
| 12:57 |
Dyrcona |
Do you know if they have another method we could try? |
| 12:58 |
* Dyrcona |
looks around for where he left his glass of tea.... |
| 12:17 |
Bmagic |
that's it, yep |
| 12:18 |
Bmagic |
Evergreen also has "Examples" of interacting with it's own API's. Mostly in Javascript |
| 12:18 |
Bmagic |
I grepped the code for "open-ils.actor.patron.update" |
| 12:19 |
Bmagic |
There's a pretty straightforward example in Perl inside one of the perl tests. I'm looking at 30-barcode-completion.t |
| 12:20 |
Bmagic |
but in that case, you'd have to run your code on the Evergreen server. I assume you're developing something that would interact with the API over the internet |
| 12:21 |
ACSpike |
Right, I want to interact in JSON over HTTP. |
| 12:22 |
Bmagic |
so, you're going to be interested in the javascript implementation. That we have written for our own staff client |
| 14:42 |
Dyrcona |
OK. I should have actually looked at the repo instead of glancing at my github feed. :) |
| 14:44 |
berick |
the gateway is pretty easy to code for, though, and works fine for most tasks, so it's a decent option |
| 14:45 |
Dyrcona |
berick: On patron edit, I want to change all default visibility of 2 to 1. |
| 14:46 |
Dyrcona |
Yeah, the gateway isn't too bad. I wrote something once to log in and logout as a test. I did the same with XML RPC, then a bug was fixed and it broke. :_ |
| 14:48 |
berick |
Dyrcona: modifying default visibility in patron editor (2 to 1) should be pretty simple |
| 14:49 |
berick |
angjs editor has a default_field_visibility map |
| 14:49 |
Dyrcona |
My reasoning is 2 is show which always shows up. One is suggested which can be easily hidden. This obviates the need for so many settings. |
| 08:48 |
|
kworstell-isl joined #evergreen |
| 09:03 |
|
Dyrcona joined #evergreen |
| 09:09 |
pinesol |
News from commits: LP1999282 Less intense badges for staff interface <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=39c44d2c0a6f5eab4d93b564b079be1cf75d85f2> |
| 09:56 |
Dyrcona |
BTW, if anyone wants to try development and testing on Pg 15 before Lp 1997098 and Lp 1999274 go in, I pushed user/dyrcona/pg15-master-for-dev to the working repo that combines both of those branches into master. I'm using it on my local development VMs with concerto. |
| 09:56 |
pinesol |
Launchpad bug 1997098 in Evergreen "Add Support for PostgreSQL 15" [Medium,Confirmed] https://launchpad.net/bugs/1997098 |
| 09:56 |
pinesol |
Launchpad bug 1999274 in Evergreen 3.10 "Performance of Search on PostgreSQL Versions 12+" [Medium,Confirmed] https://launchpad.net/bugs/1999274 |
| 09:57 |
Bmagic |
Dyrcona++ |
| 10:03 |
Dyrcona |
I don't know of any site running greater than Pg 10 in production. |
| 10:03 |
Bmagic |
right |
| 10:13 |
|
kworstell-isl joined #evergreen |
| 10:20 |
Dyrcona |
Couple of database live tests failed. I'd better have a look. |
| 10:36 |
|
Stompro joined #evergreen |
| 10:41 |
|
BDorsey joined #evergreen |
| 10:46 |
|
Christineb joined #evergreen |
| 11:09 |
Dyrcona |
Pro tip: Try to remember which port is which version of PostgreSQL, or you could waste an hour and a half trying to figure out whey pgtap live tests are failing on 1 server but not the others. |
| 11:09 |
Dyrcona |
s/whey/why/ |
| 11:09 |
pinesol |
News from commits: LP#1999274: Add Release Note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=31e2d9a565a603f0044ce52ff1719e9eaa151dbd> |
| 11:09 |
pinesol |
News from commits: LP#1999274: Improve Search Performance on Pg 12+ <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=aa30c7e7b23a6dc4f10f5f1e7382cba13d787cf5> |
| 11:18 |
csharp_ |
ah |
| 11:18 |
Dyrcona |
So, tarball is busted. |
| 11:18 |
abowling |
Dyrcona: yes, that's our operating theory |
| 11:18 |
* Dyrcona |
doesn't use the tarballs, except for testing a release before release. |
| 11:18 |
abowling |
Git build likely works |
| 11:18 |
abowling |
tarball doesn't |
| 11:19 |
Dyrcona |
So that's bug worthy: broken tarball. |
| 11:19 |
abowling |
and i'm not 100% sure of this, but like i said, I wasn't the only one to witness ;) |
| 11:19 |
Dyrcona |
That's all supposed to be automated, but something likely went wrong with one of the npm steps. |
| 11:20 |
abowling |
Dyrcona: agreed; I'm hoping someone can test and disprove my theory...or confirm it |
| 11:20 |
csharp_ |
confirmed: no eg2 directory in the 3.10.0 tarball |
| 11:20 |
Dyrcona |
csharp_++ |
| 11:20 |
abowling |
csharp_: there's a ton missing...seemingly |
| 11:22 |
csharp_ |
or maybe I'm getting punchy - fasting today for Ash Wednesday |
| 11:23 |
Dyrcona |
:) |
| 11:23 |
abowling |
installing 3.9.1 THEN 3.10.0 seemed to take care of a lot of it |
| 11:23 |
Dyrcona |
I solved my issues with ports and testing by doing apt purge postgresql-14. :) |
| 11:23 |
abowling |
we jumped from 3.7.1 to 3.10.0 |
| 11:24 |
Dyrcona |
abowling: We were going to do the same, but decided to wait until more 3.10 bugs are fixed. |
| 11:24 |
abowling |
Dyrcona: you decided to wait because you're smarter than I am |
| 12:22 |
Dyrcona |
I've referred to the documentation quite a lot, so I have it bookmarked. |
| 12:34 |
|
collum joined #evergreen |
| 12:40 |
|
collum joined #evergreen |
| 13:03 |
* Dyrcona |
ponders implementing a GUI to send SIP messages for testing purposes. Might be nice to test if check out works, etc. |
| 13:05 |
Dyrcona |
Not today, though. |
| 14:23 |
Dyrcona |
My dog is funny. I got some cashews for a snack. She likes them, too, so I gave her some. She won't eat them if I put them in a bowl or on a plate. I have to hand them to her or drop them on the floor. |
| 14:36 |
pinesol |
News from commits: LP#2007880: fix open-ils.actor.ou_setting.ancestor_default <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=13adaa938b5621f28ee1e30d200d9cb9787f23a3> |
| 16:21 |
abowling |
Dyrcona: yep. nothing. |
| 16:22 |
Dyrcona |
Did you install this clean or on top of a previous installation? If the latter you might want to rm -rf /openils/* and reinstall both OpenSRF and Evergreen. |
| 16:23 |
Dyrcona |
If it was a git checkout, I find that git clean -xfd and then a complete rebuild with autoreconf sometimes helps. Assuming that the problem could be mismatched versions of files... |
| 16:36 |
pinesol |
News from commits: LP1841871: Add a test for creating authority record from bib field <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=35338601f56e3961672e44b1c6001469be9d05c9> |
| 16:38 |
csharp_ |
unfortunately our fixes for the view_perm thing for the Library Settings Editor broke holds pull lists and probably other things |
| 16:38 |
csharp_ |
there's another bug in one of the subs - I'll file it as soon as I get a chance, but it is not this day |
| 16:39 |
csharp_ |
another use case for better test coverage |
| 16:43 |
Dyrcona |
csharp_: Have you tested that with Galen's latest patch for Lp 2007880 that I pushed this afternoon? |
| 16:43 |
pinesol |
Launchpad bug 2007880 in Evergreen " open-ils.actor.ou_setting.ancestor_default broken" [High,Fix committed] https://launchpad.net/bugs/2007880 |
| 16:43 |
Bmagic |
sorry abowling, I stepped away. But everyone else's suggestions are perfect! |
| 16:44 |
csharp_ |
lawd - I chased my tail for about an hour on that without realizing gmcharlt had already found it |
| 16:45 |
csharp_ |
Dyrcona++ # will test on another day |
| 16:45 |
csharp_ |
today has accomplished its apparent mission of kicking my ass |
| 16:45 |
Dyrcona |
heh.... |
| 16:58 |
* Dyrcona |
calls it a day. |
| 18:41 |
|
jihpringle joined #evergreen |
| 15:11 |
JBoyer |
The main event! |
| 15:11 |
JBoyer |
#topic New Business |
| 15:11 |
JBoyer |
#info scottangel: Request for testers / feedback: LP1977554 - Add Password visibility toggle on login screens |
| 15:12 |
scottangel |
Yes! Test away |
| 15:12 |
JBoyer |
Always good to call attention to accessibility and internationalization fixes. |
| 15:12 |
JBoyer |
scottangel++ |
| 15:12 |
JBoyer |
#info mantis/gmonti: Procedure for updating terminology in Evergreen |
| 15:15 |
JBoyer |
They don't necessarily have to be individual, but reports should probably be small, limited to a single section of the client or opac. |
| 15:16 |
rhamby |
I think if we have a consensus to make such a change there should be a good faith effort to list logically grouped ones into just a few tickets |
| 15:16 |
mantis2 |
JBoyer++ |
| 15:16 |
JBoyer |
Smaller patches like that are easier to test and apply, without making them too tiny or so large that we end up with a "# items" printing option sneaking through. :) |
| 15:16 |
JBoyer |
(again?) |
| 15:16 |
JBoyer |
mantis2++ |
| 15:17 |
JBoyer |
Any other comments before we move on? |
| 11:59 |
|
kworstell_isl joined #evergreen |
| 12:00 |
|
kworstell_isl joined #evergreen |
| 12:00 |
Dyrcona |
I hope csharp_ comes back to the channel before spending a lot of time on it. |
| 12:01 |
Dyrcona |
I'll ask jamundson to have a look at this on our training/test server. |
| 12:08 |
|
rfrasur joined #evergreen |
| 12:26 |
|
jihpringle joined #evergreen |
| 12:47 |
* Dyrcona |
has been having weird things happen lately. Yesterday, it was the strange ghost cursor on an Ubuntu 22.04 laptop. Today it is man dumping core on Ubuntu 20.04. |
| 13:33 |
* Dyrcona |
is updating VMs today. |
| 13:41 |
Dyrcona |
That ou_ancestor_setting_log subroutine still looks a bit off to me. It doesn't do anything without an $auth argument, unlike the other. |
| 13:42 |
Dyrcona |
csharp_: Have your tried that second one in a case where you don't have the permission? Does it fail gracefully? |
| 13:48 |
csharp_ |
not yet - lemme check |
| 14:01 |
|
jihpringle joined #evergreen |
| 14:19 |
|
kworstell_isl_ joined #evergreen |
| 14:31 |
csharp_ |
Dyrcona: got waylaid - I'll do some testing when I can |
| 14:32 |
|
sleary joined #evergreen |
| 14:34 |
Dyrcona |
OK. That function looks like it is missing some pieces, and they were missing before you touched it. I could be wrong, though. I often am wrong. |
| 14:52 |
|
kworstell-isl joined #evergreen |
| 11:05 |
pinesol |
csharp_: Band 'Surly Bassey' added to list |
| 11:09 |
|
Christineb joined #evergreen |
| 11:11 |
Dyrcona |
Oof. My egdev branch is kind of a mess. I should fix it. I wasn't going to use override directories, but somehow there they are. |
| 11:16 |
Dyrcona |
Spot checking a few files, it looks the files in the override directories are the same as the one in the regular directories, so I wonder when/how/why I did that? I don't remember doing it deliberately, but maybe it was a test of something that i didn't undo or an accident. |
| 11:17 |
Dyrcona |
I do recall having trouble getting the commands right to copy them to another repo, so perhaps it happened then and I committed the change? |
| 11:25 |
Dyrcona |
Related to Lp 1979348, I'm trying to find where preferred language gets set in patron registration/edit and I'm either blind or having a bad day because I don't see it. Does anyone have any pointers for the code? |
| 11:25 |
pinesol |
Launchpad bug 1979348 in Evergreen "Need ability to pick what displays for Preferred Language" [Undecided,Confirmed] https://launchpad.net/bugs/1979348 |
| 10:22 |
|
sleary joined #evergreen |
| 10:23 |
Dyrcona |
xmllint and namespaces..... :( |
| 10:25 |
Dyrcona |
Remove the namespace and I still get XPath set is empty.... |
| 10:27 |
Dyrcona |
Can I pick records to test, or what? <datafield tag="024" ind1=" " ind2=" "><subfield code="">660355362927</subfield></datafield> |
| 10:27 |
Dyrcona |
No subfield code..... |
| 10:27 |
Dyrcona |
How's that even possible? |
| 10:30 |
Dyrcona |
And, another one with a blank subfield code. |
| 12:51 |
Dyrcona |
OK. I got back to messing with my UPCs and I've verified that the XPath should work. Guess I'll have to wait for the full ingest to finish. One of the options that I used yesterday must have prevented the identifiers from being handled. |
| 12:55 |
Dyrcona |
Oof! |
| 12:55 |
Dyrcona |
I see I still have a problem and the XPath that I updated won't work.... |
| 12:58 |
Dyrcona |
I had to modify it slightly for the test script, and I assumed it was equivalent to what was in the database. It was not. |
| 12:59 |
Dyrcona |
OK! Now, it works with the same syntax. |
| 13:00 |
Dyrcona |
Too many different domain specific languages to try and keep straight.... "Says you..." "Says who?" "Says you, the Lisp guy." |
| 13:00 |
Dyrcona |
There's a joke in there. I promise. :) |
| 13:22 |
Dyrcona |
And, here come the "closing early" emails on the directors' list... :) |
| 13:54 |
jeff |
just perpetually overcast and gray skies here: https://youtu.be/FDvImJ_6HYw |
| 15:12 |
Dyrcona |
Looks like I finally fixed the XPath. I've got 106 entries in identifier_field_entry and they all look like UPCs. The ingest hasn't finished, yet. |
| 15:44 |
jeffdavis |
I've got a 3.9.1 test server where I've generated search suggestions (ran the sideloader steps and populated search.symspell_dictionary with >6M rows) and have the org settings/internal flags set to default values, the but I'm not seeing any suggestions on my test searches. Are there other steps I need to take to make this work? |
| 15:58 |
Dyrcona |
jeffdavis: Are you doing single word searches? |
| 16:00 |
jeffdavis |
good question - I am, I'll double check with other testers |
| 16:05 |
jihpringle |
jeffdavis: I just tried a single word and then a multiple word search on our testing server and I don't see anything new whether I get results or not |
| 16:49 |
Dyrcona |
Sorry, got distracted by some work. :) |
| 16:50 |
Dyrcona |
It has been a while since I looked at it. I'll have to do some code diving tomorrow. |
| 16:50 |
Dyrcona |
Cheers! |
| 14:31 |
jeff |
can you explain what you mean by "do not look like UPCs"? also, depending on a number of things, you might have a lot of outliers in that LIMIT 100... |
| 14:31 |
Dyrcona |
Yeah, when I do field = 18 they look like ISBNs, and 18 is ISBN. |
| 14:32 |
Dyrcona |
jeff: No problem: 192326039 | 4144895 | 20 | 1. Selected Economic Indicators, 2014-212. Financial Soundness Indicators, 2010-16; ANNEXES; I. Risk Assessment Matrix; II. Report on the Observance of Standards and Codes (ROSCs)-Summary Assessments of BCP; III. Report on the Observance of Standards and Codes (ROSCs)-Summary Assessments of ICP; IV. Report on the Observance of Standards and Codes (ROSCs)-Summary Assessments of C |
| 14:32 |
Dyrcona |
PFMI; V. Previous FSAP Recommendations; VI. Banking Stress Testing Matrix; VII. Corporate Stress Testing Matrix. 1. The FSCFIGURES; 1. The Macro Context; 2. A Bank Dominated Financial Sector; 3. Banking Sector Profile; 4. Bank Business Model Convergence; 5. Bank Measures of Systemic Risk and Spillover Networks; 6. Banks' FX and Liquidity Risks; 7. Banks' Returns, Asset Quality, and Solvency; 8. Corporate Sector Risks and Vul |
| 14:32 |
Dyrcona |
ies; 9. Summary Results of Solvency Stress Tests of Major Banks; 10. Results of the Liquidity Stress Tests of Major Banks; 11. Funding Liquidity-Solvency Feedback in Solvency Stress Tests; 12. Corporate Sector Stress Test Analysis; TABLES. |
| 14:32 |
Dyrcona |
That's definitely NOT a UPC. |
| 14:32 |
jeff |
ah, yes. |
| 14:32 |
Dyrcona |
That's the first result row. I must have a conflicting definition somewhere. |
| 14:36 |
Dyrcona |
So, we've got 505 and 246 possibly showing up. |
| 14:37 |
Dyrcona |
I used to know this part of Evergreen better than I do now. |
| 14:38 |
Dyrcona |
jeff++ mmorgan++ |
| 14:39 |
Dyrcona |
This is on a development/test system. I guess I'll double check production, too. Maybe it was something in this upgrade script.... |
| 14:39 |
jeff |
nothing stock references 505, but in mods that's tableOfContents, which is matched by the xpath for the keyword field "toc". |
| 14:40 |
jeff |
also, that specific record is deleted in your live system, which may or may not mean that its being skipped on reingests/etc. |
| 14:40 |
jeff |
s/its/it's/ |
| 15:05 |
Dyrcona |
pinesol: That's not helpful. |
| 15:05 |
pinesol |
Dyrcona: Sorry, that command is only available to Evergreen Premium™ Subscribers. Please upgrade your subscription ASAP! |
| 15:05 |
Dyrcona |
:) |
| 15:07 |
Dyrcona |
Hrm. This worked when I tested it yesterday. I must be missing an option. |
| 15:11 |
Dyrcona |
Ok. Forgot to use the --directory option because the hierarchy changes from one repo to the other. |
| 15:24 |
Dyrcona |
So, I'm going to test that format-patch | am trick to manage template customization. It just might work. |
| 15:44 |
jeffdavis |
sorry about the tree and the chainsaw, hope the cars really are ok :( |
| 15:54 |
Dyrcona |
jeffdavis: Thanks! There's no visible damage, not even the moon roof on mine. |
| 16:00 |
Dyrcona |
https://drive.google.com/file/d/118z2rQoAvw45kCiwdDjqykrLDBF6lfKP/view?usp=share_link |
| 12:49 |
|
jvwoolf joined #evergreen |
| 13:08 |
|
mantis1 joined #evergreen |
| 13:27 |
|
rfrasur joined #evergreen |
| 13:42 |
JBoyer |
Dyrcona++ # an off-hand comment lead to a test case fix so 3.8.2 can proceed as planned! |
| 13:43 |
Dyrcona |
JBoyer++ # For realizing the issue was in the concerto data load for Pg 10+ |
| 14:11 |
miker |
Bmagic: from yesterday, re asset.copy vs serial.unit, if you're gathering data for future loading as part of an expanded data set, you def want to use "SELECT ... FROM ONLY asset.copy ..." because of the inheritance. but, in normal operation, yes, you'll definitely see serial.unit rows "through" the asset.copy table -- that's 100% intended. |
| 14:14 |
Bmagic |
yep, I did come to the same conclusion, and edited my code with "ONLY" - that seems to have fixed the bug |
| 14:02 |
mmorgan |
's in the working repo: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmonti/lp1853630_carousel_shelving_location_desc |
| 14:02 |
mantis1 |
ah thank you |
| 14:02 |
mmorgan |
did you do a git fetch working? |
| 14:02 |
mantis1 |
I did sorry I was looking in the wrong repo |
| 14:02 |
mantis1 |
Thank you! |
| 14:03 |
mantis1 |
Do we add a sign off tag to the LP ticket? |
| 14:04 |
mantis1 |
or is that just after testing? |
| 14:05 |
Dyrcona |
mantis1: If you signoff the branch, all you have to do on the ticket is say that you pushed a signoff branch and where the branch is. |
| 14:05 |
Dyrcona |
It's probably best to wait until after you've tested it. I don't add my signoff if I can't get it to work. |
| 14:05 |
mmorgan |
mantis1: It needs a pullrequest tag, the signoff tag gets added by the tester |
| 14:05 |
Dyrcona |
Oh, yeah. You can add the signoff tag if you tested it. |
| 14:06 |
Dyrcona |
I may have misunderstood the situation. |
| 14:06 |
Dyrcona |
The original author doesn't add the signoff tag for their signoff. |
| 14:06 |
mantis1 |
mmorgan++ Dyrcona++ |
