| 10:21 |
|
dguarrac joined #evergreen |
| 11:42 |
Dyrcona |
Libraries need to clear their hold shelves. |
| 11:43 |
mmorgan |
:) |
| 11:48 |
Dyrcona |
I'm not having any luck with the patches for Lp 1971745. I guess my local test system's database is just too slow. Neither patch seems to make a difference for me on an "optimized" database or a default configured database with production data. |
| 11:48 |
pinesol |
Launchpad bug 1971745 in Evergreen 3.9 "Holds shelf list can fail to retrieve results" [Undecided,Confirmed] https://launchpad.net/bugs/1971745 |
| 12:02 |
|
jihpringle joined #evergreen |
| 12:02 |
|
Christineb joined #evergreen |
| 12:33 |
Dyrcona |
The patches are working for me on another development system running 3.7.3.... |
| 12:38 |
Dyrcona |
I wonder if the problem is the other db server, or if something went wrong with the upgrade from 3.7.3 to master? |
| 12:38 |
* Dyrcona |
will test on a 3.7.3 vm with the other db server. |
| 12:49 |
Dyrcona |
Hmm... That system with the "bad" db server won't load a hold shelf with about 9 copies. |
| 12:49 |
Dyrcona |
OK. It loaded on the second try. |
| 13:01 |
Dyrcona |
With or without the patches this other test system can't grab a hold shelf with 100 items. |
| 13:01 |
Dyrcona |
@blame the db server |
| 13:01 |
pinesol |
Dyrcona: the db server is the SPY! |
| 13:28 |
Dyrcona |
This is the server that took 5 minutes to connect cstore, prcrud, and storage last week, so.... |
| 15:25 |
Stompro |
Dyrcona, "there's a reason we setup the offline directory twice in our Apache configuration? It's done in eg.conf and again in eg_vhost.conf" I noticed this also, it seemed to be needed when I tried to add a new cgi script, I don't understand why though. |
| 15:25 |
Stompro |
Dyrcona++ thanks for looking at the hold shelf display bug. |
| 15:29 |
Dyrcona |
Stompro: That's interesting about the configuration and the cgi script. I might investigate that. |
| 15:30 |
Dyrcona |
I really wanted to test the hold shelf fixes on Pg 15, but that was on the server that has issues.... |
| 15:38 |
|
jvwoolf left #evergreen |
| 15:41 |
Dyrcona |
Hrm... What version of PostgreSQL should I recommend in the branch that removes Pg 10? I'm inclined to go with Pg 14. |
| 15:41 |
Dyrcona |
Maybe I'll put this branch off until we can have some developer discussion around it. |
| 15:45 |
Stompro |
I don't have any input on that, but I'm looking forward to having a recommendation to follow :-) |
| 15:49 |
Dyrcona |
Well, I'm not sure anyone else will have much to say about that at the next dev. meeting. I'm still inclined to recommend Pg 14, since I've been testing new development on Concerto with that. My latest 2 vms for concerto will use Pg 15 because I used them to develop/test the Pg 15 branch. |
| 15:50 |
berick |
i'm looking at 14 as our next upgrade target fwiw |
| 15:50 |
berick |
and have been using it for dev, etc. |
| 15:50 |
Dyrcona |
I also wonder if we should come up with recommendations for upgrading Pg versions. There are often extra steps required with Evergreen. |
| 12:34 |
Dyrcona |
:) |
| 13:00 |
csharp_ |
@dessert [someone] |
| 13:00 |
* pinesol |
grabs some Key Lime Pie for dluch |
| 13:15 |
Dyrcona |
So, for anyone who cares, I'm setting up two local test VMs with PostgreSQL 15. I'll run the tests later today to see what (if anything) breaks. |
| 13:23 |
Dyrcona |
Has anyone ever left a server/vm set to UTC, and if so, did you encounter any noticeable issues? |
| 13:49 |
|
kmlussier joined #evergreen |
| 13:51 |
jeff |
I recall having issues with that recently on 3.7. I think it was the database server being left at UTC, and I don't recall of the top of my head how far I looked into if that was an issue with lib.timezone not being set somewhere, etc. |
| 14:08 |
Dyrcona |
jeffdavis++ |
| 14:09 |
Dyrcona |
I know we fixed a bunch of issues in the past. I might set one of these vms back to UTC to try it out. |
| 14:14 |
Dyrcona |
I've not really noticed before, but I wonder if there's a reason we setup the offline directory twice in our Apache configuration? It's done in eg.conf and again in eg_vhost.conf. I wonder if we do that for other directories? |
| 14:33 |
Dyrcona |
So, first complete installations of Evergreen with Pg 15 completed. OPAC and staff client seem to work. Now to run the tests. |
| 14:38 |
Dyrcona |
pgtap tests all pass. |
| 14:49 |
Dyrcona |
Perl tests also pass. |
| 14:58 |
Dyrcona |
Every now and then, I think the action.hold_request.phone_notify field should be changed to a Boolean, particularly when we get tickets asking why the patron's "real" phone number doesn't print on the hold slip. |
| 16:06 |
Dyrcona |
Oof... |
| 16:07 |
Dyrcona |
Just missed ..... |
| 15:05 |
JBoyer |
#info sandbegja and others are looking into AngularJS node module security updates |
| 15:05 |
JBoyer |
#link https://bugs.launchpad.net/evergreen/+bug/1992529 |
| 15:05 |
pinesol |
Launchpad bug 1992529 in Evergreen "Upgrade insecure npm dependencies for angularjs staff client" [Medium,New] |
| 15:06 |
JBoyer |
It looks like things are going alright, terranm was able to successfully do some testing but no one involved seems to be here to expand on it. |
| 15:06 |
JBoyer |
There is a branch available that anyone comfortable poking at Angular should take a look at, if it made it in before 3.10 that would be great. |
| 15:07 |
JBoyer |
#topic Evergreen Release Updates |
| 15:07 |
JBoyer |
Any updates from the 3.10 relteam? |
| 15:21 |
gmcharlt |
or "go through all of the TODO and FIXME comments in the code" |
| 15:21 |
berick |
agreed a list of common issues could be helpful |
| 15:21 |
gmcharlt |
or "go through the release notes for the past few years and note any deprecation announcements" |
| 15:24 |
jeffdavis |
Given our code, is it possible to automate something like testing that a shelving location selector can be scoped by org unit? |
| 15:26 |
gmcharlt |
generally speaking, yes - more unit tests for the Angular components is certainly possible |
| 15:26 |
JBoyer |
sandbergja demo'd some "e2e" testing during the hackaway that could potentially do things like that; they're Angular tests that drive the browser and verify its results. |
| 15:26 |
gmcharlt |
but that's a very concrete way of answering the question |
| 15:26 |
gmcharlt |
jeffdavis: is the question more about how to enumerate and document standing expectations for behavior? |
| 15:27 |
jeff |
If we start with a list that is suitable for use as a checklist, then we could use the start with using the checklist and potentially craft some automated lint-like checks of common issues like unscoped selectors. |
| 15:29 |
gmcharlt |
commit message templates embedding a (brief) checklist might also be a way - https://thoughtbot.com/blog/better-commit-messages-with-a-gitmessage-template |
| 15:30 |
jeffdavis |
sorry, I keep typing and deleting responses :) |
| 15:30 |
|
shulabear joined #evergreen |
| 15:30 |
jeffdavis |
a checklist is one example of a way to improve the QA part of our test/commit process, I think we're interested in any kind of solution that improves QA to avoid these kind of recurring problems |
| 15:31 |
jeffdavis |
(it is a very broad problem set for sure, and I agree that formulating a more specific list would be a great next step) |
| 15:32 |
jeffdavis |
I can do some more work with our local support folks to gather more specific examples and flesh out a list for next meeting. |
| 15:33 |
JBoyer |
jeffdavis++ |
| 15:33 |
JBoyer |
Care to #action that for the notes? |
| 15:33 |
shulabear |
jeffdavis++ |
| 16:00 |
JBoyer |
#link https://bugs.launchpad.net/evergreen/+bug/1948693 |
| 16:00 |
pinesol |
Launchpad bug 1948693 in Evergreen "Migrate from NgbTabset to NgbNav (from ng-bootstrap)" [Medium,Confirmed] - Assigned to Stephanie Leary (stephanieleary) |
| 16:01 |
JBoyer |
berick, sorry for the lateness, but if there's anything you'd like to add it's all yours |
| 16:01 |
berick |
thanks |
| 16:01 |
berick |
a couple quick things |
| 16:01 |
berick |
I'm planning to start down the path of updating to Angular 14, Bootstrap 5, etc. |
| 16:02 |
berick |
first part is review/test/merge of bug 1948693, which now has a patch |
| 16:02 |
pinesol |
Launchpad bug 1948693 in Evergreen "Migrate from NgbTabset to NgbNav (from ng-bootstrap)" [Medium,Confirmed] https://launchpad.net/bugs/1948693 - Assigned to Stephanie Leary (stephanieleary) |
| 16:02 |
berick |
it touches lot of UI's, so my question is if I post it on a public VM somewhere can someone help me bounce through and test the UIs? |
| 16:02 |
berick |
basically making sure they load OK and tabs work OK |
| 16:03 |
berick |
i'll post a link to the LP when it's testable |
| 16:03 |
berick |
i don't need a committment, just putting that out there. |
| 16:03 |
sleary |
I would appreciate a lot of eyes on this one. Obviously I ran through them before committing, but there are a few areas where I didn't have adequate test data |
| 16:03 |
JBoyer |
I'm sure pinging the dev lists would help get some people to poke at it too. |
| 16:04 |
berick |
more generally, the Angular etc update is going to affect probably every angular dependency. |
| 16:04 |
berick |
it's not something we'll want to let linger once it's ready |
| 16:12 |
JBoyer |
Also, scottangel feel free to ask any questions you might have now, it's basically a free-for-all when meetings aren't going on. :) |
| 16:12 |
scottangel |
Well then... One question I have is... can I help with the Bootstrap 5 conversion? I love me some bootstraps. |
| 16:13 |
* jeff |
pokes at Google Calendar a bit more... |
| 16:13 |
berick |
miker: if your patch involves updating nodejs or adding new deps, then I'd say yes to committing it |
| 16:14 |
berick |
scottangel++ # we will need lots of manual testing |
| 16:14 |
miker |
well, it /shouldn't/ require that. just a consequence of installing a new version of the node.js binaries |
| 16:14 |
miker |
and rebuilding node_modules |
| 16:14 |
scottangel |
I can help with that as well. |
| 09:18 |
|
stephengwills joined #evergreen |
| 09:18 |
Dyrcona |
miker: Since it would take a day pretty much to restore and "re-upgrade" the database, I'll stick with what I've got checked out. I'll see about pulling the top commits from your other branch. |
| 09:57 |
Dyrcona |
miker: Everything is failing with the changes to metabib.reingest_metabib_field_entries. I'm going to back it out. |
| 09:59 |
miker |
awesome. if you have more info than that, that'd be great. I'm not seeing everything fail... |
| 09:59 |
miker |
thanks for testing, regardless |
| 10:02 |
miker |
Dyrcona: that function has changes that depend on the deadlock branch, fwiw |
| 10:03 |
Dyrcona |
Yeah, I have those. I did the DYM deadlock upgrade, too. |
| 10:03 |
Dyrcona |
miker: Here's a PostgreSQL log entry, https://pastebin.com/SsECj4QB |
| 10:13 |
Dyrcona |
I stopped the coordinator, replaced the function, and it seems to be working again. |
| 11:15 |
|
mantis1 joined #evergreen |
| 11:27 |
Dyrcona |
miker: By "replaced the function," I mean that I went back to the version from the base schema. |
| 11:33 |
miker |
ah, ok. well, I confess that the error message in the log doesn't make much sense to me, it's complaining about a different table... but I'll see if I can sus out what's up there |
| 11:34 |
Dyrcona |
I'll try the new implementation again tomorrow or next week. I'm also trying to test a load of records that say they're MARC8, but I have my suspicions. |
| 11:35 |
Dyrcona |
I have some smaller batches that I'll use with the new implementation. |
| 11:36 |
Dyrcona |
Yeah, I wasn't really sure about the error message, either. I've got a couple of thousand more if you want to extract another. |
| 11:36 |
Dyrcona |
Something like 2,500 failed by the time that I noticed. |
| 11:40 |
Dyrcona |
Let me make sure it does the new thing for the password. |
| 11:41 |
Dyrcona |
It does! How about that! |
| 11:41 |
* Dyrcona |
cranks up the Iron Maiden... |
| 11:46 |
miker |
Dyrcona: so, I found the issue. the problem is in the details of PG's fkey checks. the cause is updating the id (which the named table points to as "entry"), even with the original value. we can replace sort_value, since it's the same and (basically) a key as well with the same effect and not bonk into that issue. I'm testing that change now (no explosions after 5min+), but it comes down to this if you want to use "\ef metabib. |
| 11:46 |
miker |
reingest_metabib_field_entries" to adjust the new version in situ: https://pastebin.com/PKDrhfSX |
| 11:46 |
|
jihpringle joined #evergreen |
| 11:48 |
Dyrcona |
miker: Cool, I'll give that a shot after I play with my new SIP accounts. |
| 11:48 |
miker |
+1 |
| 12:15 |
Dyrcona |
I suppose that I could just replace the function while it's running and see what happens. |
| 12:39 |
Dyrcona |
miker++ I swapped ou the function definition and it's still working. |
| 12:39 |
miker |
huzzah! |
| 12:49 |
Dyrcona |
My SIP test is not going so well. I can't tell if I'm failing to log in or if my test script is just blowing up. I'm getting a socket error. |
| 13:04 |
Dyrcona |
hmm. I get no response from server when I try to login with a newly created account, but pre-existing ones work. I even tried running actor.change_password() with the password that I'm using. |
| 13:09 |
Dyrcona |
There's a bug, I think. I was trying to use the location to add a workstation for the new users. When I removed the location, it worked. |
| 13:09 |
|
mrtnnbr joined #evergreen |
| 14:12 |
|
sleary joined #evergreen |
| 14:13 |
Dyrcona |
The other 3 are also deadlocks. |
| 15:29 |
Dyrcona |
So, I am now getting sharelock violations. That's it. I'll have to reload everything next week and start over with a clean upgrade to master, etc., to make sure I have everything, but I am pretty sure that everything is up to date. |
| 15:37 |
jeffdavis |
Do we have a way to flag bugs that need discussion rather than testing for bug squashing week? There's a fix for bug 1863387 that I'd like to commit as-is, but it would be good to know if end users think it needs more work. |
| 15:37 |
pinesol |
Launchpad bug 1863387 in Evergreen "Carousels: shelving location selector should limit initial set of choices" [Medium,Confirmed] https://launchpad.net/bugs/1863387 |
| 15:37 |
Dyrcona |
jeffdavis: needsdiscussion tag. |
| 15:40 |
jeffdavis |
oh, are needsdiscussion bugs already included in bug squashing? that would be great! |
| 15:49 |
sleary |
I forgot about that tag |
| 15:50 |
Dyrcona |
On the plus side, the ingest coordinator has stayed up and running. |
| 15:51 |
|
jvwoolf left #evergreen |
| 16:16 |
mmorgan |
jeffdavis: I am pretty sure the main focus of bug squashing week is bugs with pullrequests, terranm does a masterful job of organizing them on test servers with signoffs as a goal. |
| 16:17 |
mmorgan |
But I would think BSW is a great opportunity to look at needsdiscussion bugs, too. |
| 16:50 |
|
stephengwills left #evergreen |
| 17:06 |
|
mmorgan left #evergreen |
| 18:25 |
|
sandbergja joined #evergreen |
| 18:57 |
pinesol |
News from commits: LP1952931 release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b33f1170050401a0c6066452a09d391fd97a7cd2> |
| 18:57 |
pinesol |
News from commits: LP1952931 stamp upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=25f23ca394d5759f685f6b54933e9d0db18423cd> |
| 18:57 |
pinesol |
News from commits: LP1952931 Support ACQ Advanced Shipment Notices (DESADV -- Dispatch Advice Messages) <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=eae6c7e0eacc9ebf4bfd2014d9c6485a61de8a0c> |
| 19:28 |
gmcharlt |
testing, then pusing fix to 1344 |
| 19:38 |
|
sandbergja joined #evergreen |
| 19:38 |
sandbergja |
gmcharlt++ |
| 19:57 |
pinesol |
News from commits: LP#1724032: add release note entry <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2cad20e67af7d630b18834313960e00414dd758e> |
| 20:28 |
pinesol |
News from commits: LP1904036 Mark Damaged always handles checkin <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=55941c65290a23c682746c230b96fff12d38efc4> |
| 20:28 |
pinesol |
News from commits: LP1904036 Checkin grid routeTo visible by default <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5bc6f2816ba2124198c9763f0d17c9aac88b05c4> |
| 20:44 |
* gmcharlt |
claims 1347 |
| 20:57 |
pinesol |
News from commits: LP#1934162: stamp DB update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=00d6528742c31a7b04aa876e6e4a471fec8c6bfc> |
| 20:57 |
pinesol |
News from commits: LP#1934162: add release note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1ea534594a176b72b404f12f8071faf870e96c8f> |
| 20:57 |
pinesol |
News from commits: LP1934162: (follow-up) sync whitespace <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5ec73fa03414a59bd8516e571da6070b45e3b3ce> |
| 20:57 |
pinesol |
News from commits: LP1934162: add pgtap test, refreshing upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a51d2366a735903adf04cfe7a32af1565313b334> |
| 20:57 |
pinesol |
News from commits: LP#1934162: delete user messages and curbside notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d24c4dbe1e9b3b4dc924647c4c29082242b37622> |
| 21:07 |
* gmcharlt |
claims 1348 |
| 21:16 |
* gmcharlt |
claims 1349 |
| 21:27 |
pinesol |
News from commits: LP#1982031: add release note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=244f0c732b9358e8c272364047e03f1b92406d06> |
| 00:21 |
pinesol |
News from commits: LP1411819 stamp upgrade script and add release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8da533ecb4126fdaa6cd6386a4468fe11550e4da> |
| 00:21 |
pinesol |
News from commits: LP1411819 follow-up: add a pgtap test <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=fd0a11c18fbac315b81d04da359ba062d002d916> |
| 00:21 |
pinesol |
News from commits: LP#1411819: org setting to override PATRON_EXCEEDS_FINES penalty on renewals <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=98ce2c013c295509d530df40bed947279dc3b9f5> |
| 00:51 |
pinesol |
News from commits: LP1953692: release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=18c15f0957fdea5d1213ed137d80f879b9aa7ade> |
| 00:51 |
pinesol |
News from commits: LP1953692 follow-up: missing character <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6b9a7d9bdf64144b8138025713575d9f79c61650> |
| 00:51 |
pinesol |
News from commits: LP1953692 Angular Catalog Record Summary links should open in new tab <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=781f399afa75a6f9fae4ef164c797f1231821f22> |
| 02:18 |
|
tsadok joined #evergreen |
| 07:42 |
|
collum joined #evergreen |
| 08:07 |
|
BDorsey joined #evergreen |
| 09:28 |
|
Dyrcona joined #evergreen |
| 09:45 |
|
dguarrac joined #evergreen |
| 09:46 |
|
jvwoolf joined #evergreen |
| 09:57 |
mmorgan |
Asked this in the hackaway, but I'll try here, too. |
| 09:57 |
mmorgan |
Trying to build a test vm using ansible and I'm getting this: "Open-ILS/src/extras/Makefile.install:156: recipe for target 'ubuntu-bionic-developer' failed" |
| 09:57 |
mmorgan |
What am I missing? |
| 10:00 |
|
sleary joined #evergreen |
| 10:03 |
Dyrcona |
miker: Getting different behavior with ingest_ctl today after the patch from yesterday. I'm loading the same records that I used last week after a database reload. Updating 378 records worked fine. Inserting 314 has produced 7 errors and after that, it seems to have really slowed down. |
| 10:05 |
Dyrcona |
And, of course, after I mention it here, it picks back up again. |
| 10:14 |
Dyrcona |
I have all of the patches from DYM and queued ingest. |
| 10:17 |
Dyrcona |
The rest are all pretty much the same. |
| 10:24 |
Dyrcona |
I processed 1 by hand and it worked. I update fail_time to null and the rest of them worked in parallel. |
| 10:28 |
JBoyer |
mmorgan, regardless of the specific error you'll want to update your testing VM to a later version of Ubuntu; building Evergreen on Bionic from a fresh git checkout is likely to start failing within days. |
| 10:28 |
JBoyer |
see lp 1990969 |
| 10:28 |
pinesol |
Launchpad bug 1990969 in Evergreen "Discontinue Support for Ubuntu 18.04 "Bionic Beaver"" [Wishlist,Confirmed] https://launchpad.net/bugs/1990969 |
| 10:29 |
JBoyer |
OR, if you're running a later version of Ubuntu on your VM it's entirely possible that some package name has changed since bionic and that's what's failing. |
| 11:59 |
Dyrcona |
miker: I noticed two entries for the same author name back to back, so there's some evidence of that. |
| 12:02 |
mmorgan |
Bmagic: Right. Will look at that when I find some time. |
| 12:14 |
|
Dyrcona joined #evergreen |
| 12:23 |
miker |
Dyrcona: https://pastebin.com/csTYASPu is what I'm proposing. commit coming in a moment |
| 12:45 |
miker |
Dyrcona: 2 new commits on the QI branch now, though just the first is strictly required for the browse ingest conflict. the second is about a long-standing oversight that removes too much data in a "just update this one field" reingest request |
| 12:47 |
miker |
(IOW, you may want to pick and test just the first new commit, but I think the second is needed generally) |
| 12:49 |
|
collum joined #evergreen |
| 12:55 |
|
kworstell-isl joined #evergreen |
| 12:59 |
Dyrcona |
miker: I'll try them both in a bit. |
| 10:02 |
miker |
Dyrcona: AFAICT, the QI coordinator is always dying when trying to gather orphaned entries. is that right? |
| 10:02 |
miker |
that's based on the log snippets |
| 10:02 |
Dyrcona |
Yes. |
| 10:03 |
Dyrcona |
BTW, I've dropped that database and I'm testing something else at the moment. I could reload it. |
| 10:16 |
|
sleary joined #evergreen |
| 11:15 |
|
jihpringle joined #evergreen |
| 11:31 |
|
Christineb joined #evergreen |
| 11:31 |
miker |
Dyrcona: if/when you get back to QI, there's a small change on the current branch that should at least let us get past the "can't use undef as ARRAY ref" death. |
| 11:41 |
|
sleary joined #evergreen |
| 11:44 |
miker |
grabbing upgrade stamps 1340 and 1341 |
| 11:45 |
Dyrcona |
All right. I'll stop what I'm doing and reload the database that I was using to test queued ingest. I can rerun my tests on a different database. |
| 11:49 |
Dyrcona |
Well, crap. I can't reload it from the dump. Pg version mismatches, etc. |
| 11:49 |
Dyrcona |
I'll have to do it differently and rerun the db upgrade scripts. |
| 11:56 |
Dyrcona |
I probably won't be able to do anything with it until tomorrow. I'd really like for someone else to look at queued ingest. |
| 08:53 |
|
Dyrcona joined #evergreen |
| 08:57 |
|
stephengwills joined #evergreen |
| 09:23 |
|
dguarrac joined #evergreen |
| 10:22 |
csharp_ |
Dyrcona: are you targeting PG 14 in your testing? looking at moving past PG 11 since we're back in the same boat soon |
| 10:22 |
csharp_ |
(on PG 10 now, just looking at an upgrade target) |
| 10:23 |
Dyrcona |
If you're referring to queued ingest, I've only been testing it on Pg 10. |
| 10:23 |
csharp_ |
upgrading my staging server and thinking about what version to move towards |
| 10:23 |
csharp_ |
no, just generally |
| 10:23 |
Dyrcona |
Pg 14 should work. |
| 10:24 |
csharp_ |
ok - I'll give it a go |
| 10:24 |
Dyrcona |
I've done light testing on Pg 11 - 13. I use Pg 14 on all of my local VMs where I run concerto. (By local I mean on my laptop.) |
| 10:24 |
Dyrcona |
I might have 1 or 2 older ones (bionic, maybe?) on Pg 10. |
| 10:25 |
Dyrcona |
Does anyone know how to get of screen prompting for a password? I tried closing a window using Ctrl-a x because Ctrl-b x closes a window in tmux. Didn't remember is was the lock command and screen just keeps asking for a password. |
| 10:26 |
Dyrcona |
None of the Ctrl-a commands work with the password prompt. |
| 08:37 |
|
mmorgan joined #evergreen |
| 08:58 |
|
Dyrcona joined #evergreen |
| 09:05 |
|
dguarrac joined #evergreen |
| 09:15 |
Dyrcona |
miker: Well, ingest_ctl survived the other 157, 000 records yesterday with nothing much going on. I'm deleting a few more URIs and then going to load some as another test. |
| 09:16 |
* mmorgan |
added an additional commit to abneiman, jweston and jihpringle's release notes: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/docs-releasenotes-2022-10-18 |
| 09:19 |
Dyrcona |
mmorgan++ |
| 09:20 |
miker |
Dyrcona: that's good news |
| 10:05 |
Dyrcona |
Checking the database real quick looks like it actually worked for at least one of the failed records when I processed it manually. |
| 10:06 |
* Dyrcona |
keeps looking. |
| 10:12 |
Dyrcona |
My 502 is probably because I'm running an out of date Apache configuration. |
| 10:50 |
Dyrcona |
OK. Another batch of about 28,000 records to use for a stress test. |
| 10:55 |
|
stephengwills joined #evergreen |
| 10:55 |
Dyrcona |
Ugh. Forced to use screen because tmux is not installed.... |
| 10:56 |
stephengwills |
morning. if I RAISE some text in a postgresql function should I see that message in postgresql-10-main.log? or does it channel it somehwere else? |
| 14:04 |
Dyrcona |
I'm going to work on Pg 15 during the hack-a-way if it happens. |
| 14:17 |
berick |
pg10 here |
| 15:15 |
|
jihpringle joined #evergreen |
| 15:45 |
csharp_ |
trying to test bug 1898775 - how do I enable the traditional catalog? I've set the Library Setting GUI: Enable Traditional Staff Catalog to True for CONS but not seeing a difference |
| 15:45 |
pinesol |
Launchpad bug 1898775 in Evergreen "Bootstrap OPAC: Add to bucket broken" [Medium,Confirmed] https://launchpad.net/bugs/1898775 |
| 15:48 |
mmorgan |
csharp_: You need to change /etc/apache2/eg_vhost.conf Look for this line: |
| 15:48 |
mmorgan |
PerlAddVar OILSWebTemplatePath "@localstatedir@/templates-bootstrap" # Comment this line out to use the legacy TPAC |
| 16:10 |
csharp_ |
jeez, we're supporting too many things, huh? |
| 16:11 |
csharp_ |
mmorgan++ # was able to trigger the bug |
| 16:11 |
mmorgan |
csharp_++ |
| 16:11 |
jihpringle |
csharp_ I see it in the menu on our test server when I set the setting to True - but I have to log out and back if before it appears |
| 16:11 |
csharp_ |
jihpringle: ah |
| 16:14 |
csharp_ |
fix works! |
| 16:14 |
Dyrcona |
#worksforme |
| 16:38 |
Dyrcona |
Right... Processes that change their name after they start.... |
| 16:41 |
Dyrcona |
Wow! |
| 16:42 |
Dyrcona |
The updates immediately started going "faster." |
| 16:44 |
Dyrcona |
Testing two things at the same time. :) |
| 16:46 |
mmorgan |
Dyrcona: What else are you testing? |
| 16:46 |
Dyrcona |
Seems to be working. Some of the records have been ingested. Others haven't been ingested, yet. |
| 16:47 |
Dyrcona |
I was just making sure that a script to remove URIs for a vendor by library is still working. |
| 16:47 |
Dyrcona |
No failures, either. |
| 16:48 |
mmorgan |
Sounds promising! |
| 16:48 |
Dyrcona |
One of our members wants to refresh their Ebrary records. |
| 16:48 |
Dyrcona |
Yeahp. |
| 16:48 |
Dyrcona |
I was sitting here with that process going and thinking how can I test queued ingest, and well, it worked out perferctly. |
| 16:49 |
Dyrcona |
Well, better than my spelling anyway. :) |
| 16:50 |
mmorgan |
Dyrcona++ |
| 16:51 |
Dyrcona |
miker++ |
| 15:20 |
gmcharlt |
for obvious reasons, I'm kinda hoping that it does turn into "let's try Angular 14 for the back branches" |
| 15:20 |
gmcharlt |
er, does *not* |
| 15:20 |
|
lew54 joined #evergreen |
| 15:21 |
sandbergja |
I could throw together a branch with npm audit --fix, but it would be nice to have some help testing the results |
| 15:22 |
gmcharlt |
happy to help (and I am actually pretty concerned about the potential for breakage) |
| 15:22 |
berick |
sandbergja: is your focus at the moment just on angjs? |
| 15:23 |
gmcharlt |
but I may be unduly distrustful of the state of backwards compatibiliy in the NPM ecosystem |
| 15:24 |
sandbergja |
I definitely share the concerns about regressions... |
| 15:24 |
Dyrcona |
I've run npm update in the past without ill effects, but not sure if that does what's needed. I've also not done it in a while. |
| 15:24 |
gmcharlt |
sandbergja: certain a gold star to any of use who figures out that we can _remove_ dependencies during the process :) |
| 15:24 |
sandbergja |
If you'll allow me a soapbox for a minute, it sure would be nice if we had more test coverage, so we could just run any automated dependabot PRs against the test suite and get a quick yes/no |
| 15:25 |
sandbergja |
about whether it introduces regressions |
| 15:26 |
|
tlittle joined #evergreen |
| 15:27 |
JBoyer |
sandbergja++ gmcharlt++ |
| 15:27 |
|
terranm joined #evergreen |
| 15:28 |
JBoyer |
csharp_++ |
| 15:28 |
gmcharlt |
just wanted to mention something that had come up in a meeting with a few of you recently - if we step back a bit... we've done a LOT towards migrating to Angular |
| 15:28 |
gmcharlt |
so I do think that warrants an IRC collective back-patting |
| 15:28 |
csharp_ |
sandbergja: I'll do some experimentation and will test your branch if you push one |
| 15:29 |
shulabear |
sandbergja++ |
| 15:29 |
sandbergja |
angular++ |
| 15:29 |
terranm |
backpatting++ |
| 16:13 |
* Dyrcona |
is considering taking over SpamAssassing on FreeBSD. It's currently looking for a maintainer. |
| 16:13 |
Dyrcona |
It's late in the day, and my typing skills are on the fritz.... |
| 16:15 |
Dyrcona |
Autotools doesn't really cover installing HTML files for a website, beyond maybe using localstatedir. I s'pose inventing a new option is not out of the question, but.... |
| 16:15 |
mrtnnbr |
anyway, it looks like there's some interest/curiosity here, so how about I finish configuring my test system and put it online for review. I'll send a a link to -dev |
| 16:17 |
Dyrcona |
OK. I'd like git branches, too. :) |
| 16:28 |
mrtnnbr |
Dyrcona: A quick survey of existing ports shows somewhat even usage of --htmldir, --datadir, and --datarootdir. one of the latter two might be reasonable. |
| 16:30 |
Dyrcona |
Yeah. We have an option to not install the web files, but not one for where. |
| 11:31 |
|
sleary joined #evergreen |
| 12:12 |
|
jihpringle joined #evergreen |
| 12:26 |
|
Christineb joined #evergreen |
| 13:45 |
mantis1 |
Doing some 3.9 testing. Can anyone explain the Org selector now supports entry styling a bit further than what's in the release notes? |
| 13:45 |
mantis1 |
"The Org Selector now supports the ability to pass in an object composed of an array of Org Unit IDs and a function returning a CSS key value pair." |
| 13:49 |
jeff |
more information may be in bug 1739277 |
| 13:49 |
pinesol |
Launchpad bug 1739277 in Evergreen 3.8 "web client: holdings view owning libraries not marked in drop down menu" [Medium,Fix released] https://launchpad.net/bugs/1739277 |
| 13:50 |
jeff |
commit d51454b and commit 625c862 have an example and the first (only?) implementation |
| 13:55 |
jeff |
and i guess in actuality, the function just returns a string that's interpreted as a css class name. |
| 13:56 |
jeff |
so, the "CSS key value pair" in the release notes seems off, or I'm looking at the wrong feature/code. :-) |
| 14:05 |
|
tlittle joined #evergreen |
| 14:11 |
tlittle |
I updated my test server now that the Acq purchase order work is in master, and when opening PO's I get this console error: "open-ils.acq.lineitem.retrieve.batch failed! stat=404 msg=Method [open-ils.acq.lineitem.retrieve.batch] not found for OpenILS::Application::Acq". I can see that API/method is in Lineitem.pm, so why would it be telling me it |
| 14:11 |
tlittle |
can't see it? I don't know if this is just something I've done incorrectly or if there's something actually missing. I never saw this message on the EOLI test server, so idk what's up |
| 14:14 |
Dyrcona |
tlittle: You did a "make install"? |
| 14:17 |
tlittle |
Yes, I think so. I have a script that csharp_made for Terran and I so that probably obfuscates troubleshooting a bit, but it looks like that's what it did |
| 14:18 |
Dyrcona |
Did the script or you stop and restart services? |
| 14:47 |
Dyrcona |
I don't recall what my first album on CD was, but I definitely got Dark Side of the Moon before The Wall. |
| 14:49 |
csharp_ |
Dark Side of the Moon followed quickly |
| 14:54 |
Dyrcona |
Matter of fact, it's all dark.... |
| 14:55 |
Dyrcona |
I should probably have edited a commit message, too. I could have fixed a typo and/or removed the paragraph about tests failing... I should maybe look at that qatester bug that I removed myself from, but I though JBoyer was going to have a look. |
| 14:56 |
* Dyrcona |
has some things on Lp that he should get in digital format. |
| 14:56 |
Dyrcona |
Hah... Lp Lauchpad. LP long playing disc. :) |
| 14:56 |
JBoyer |
Well, that bug depends on the state of the "remove Stretch" bug; 2/3 of the changes are Stretch-only |
| 15:34 |
Dyrcona |
I think they finally found Part I. |
| 15:34 |
|
Stompro joined #evergreen |
| 15:53 |
Stompro |
Ah Shoot, missed feedback fest... I need to put them on my calendar. |
| 15:53 |
terranm |
There are still plenty of things loaded that can be tested :D |
| 15:55 |
Stompro |
terranm, I'm checking out the list now. |
| 16:36 |
|
jvwoolf left #evergreen |
| 16:41 |
JBoyer |
I spoke too soon about figuring out that SSO BPAC integration. My initial plan was a bust, but I |
| 11:22 |
* csharp_ |
weeps a single tear thinking about placing third in the fourth grade spelling bee |
| 11:23 |
Dyrcona |
Well, that's interesting: -bash vi: command not found # Tramp mode to the rescue! |
| 11:24 |
Dyrcona |
csharp_++ |
| 11:32 |
jeff |
csharp_: oh, I didn't actually notice your typo... but now that you pointed it out, that's probably why my brain went where it did. |
| 11:54 |
|
collum joined #evergreen |
| 11:56 |
jeff |
Drat. It was not the template. |
| 11:57 |
jeff |
test prints with this printer print okay. multiple templates have "extra space" at the bottom. |
| 12:24 |
|
mmorgan joined #evergreen |
| 13:06 |
|
collum joined #evergreen |
| 13:45 |
jeff |
Ah. It was both! |
| 17:08 |
|
mmorgan left #evergreen |
| 19:37 |
jeffdavis |
the unapi.bre db function has suddenly become very slow, but only for one specific bib record (AFAIK) - it takes ~30s for the bad record, but <1s for others that I've tried |
| 19:38 |
jeffdavis |
can't find anything weird about the bad record, and the sudden slowness wasn't triggered by edits to it or holdings changes or anything AFAICT |
| 21:03 |
jeff |
do you have data that suggests that this particular record was taking less time before now? |
| 21:09 |
jeff |
and it sounds like you've narrowed it down to the db function call itself? are you calling it directly from psql as a test? |
| 15:03 |
JBoyer |
#topic Action Items from Last Meeting |
| 15:03 |
JBoyer |
#info Dyrcona will take a look at LP 1979357 |
| 15:03 |
pinesol |
Launchpad bug 1979357 in Evergreen "fixes for qatester failures" [Undecided,New] https://launchpad.net/bugs/1979357 - Assigned to Jason Stephenson (jstephenson) |
| 15:03 |
JBoyer |
I should probably have signed off on that already, I've already tested and verified most of it anyway. |
| 15:04 |
jeffdavis |
just as long as some Jason looks at it |
| 15:04 |
Dyrcona |
I have not had time to really look at it, so maybe I should remove myself from the bug? |
| 15:04 |
JBoyer |
Dyrcona, do you have time to investigate or should I grab that one |
| 15:22 |
gmcharlt |
the two biggest pieces I'm aware that are pending are the Angular patron/circ app and the Angular acquisitions blob |
| 15:22 |
gmcharlt |
(yes, that's right, Acquisitions Blob is the new official title) |
| 15:22 |
mmorgan |
:) |
| 15:23 |
gmcharlt |
I'm curious (terranm? berick?) how testing of the patron/circ app is going |
| 15:23 |
terranm |
There were a lot of small issues found during BSW that were tracked on a big ole spreadsheet. I'm not sure if any of those have been addressed yet. |
| 15:23 |
gmcharlt |
(and where I'm leading up to is the question about whether Angular patron/circ is a 3.10 thing, 3.10 "experimental" thing, or a 3.11 thing) |
| 15:24 |
gmcharlt |
(I'm partial, but I'm feeling generally pretty comfortable about Angular Acq Blob being suitable for 3.10) |
| 15:26 |
gmcharlt |
sandbergja: yeah, I recall there was a discussion a few meetings back |
| 15:27 |
|
mdriscoll joined #evergreen |
| 15:27 |
gmcharlt |
FWIW, I'm in the camp that some sort of overlap period is going to be a necessary evil, but I have significant concerns if such a period is allowed to go on too long |
| 15:29 |
mrussell |
I think it would be best if we had an overlap period so that people can test functionality/ workflow and give feedback on what features work best |
| 15:29 |
JBoyer |
I wonder how many of us are reading the last meeting's notes... :D |
| 15:30 |
gmcharlt |
so to spin a tale: maor testing in 3.10, possibly a non-default alt mode available in 3.10 (although I think I remember from berick that he doesn't think it would be easy to do that/) |
| 15:30 |
|
Guest4 joined #evergreen |
| 15:30 |
gmcharlt |
3.11 - fully relased; new interface is default but can switch back as needed |
| 15:30 |
gmcharlt |
3.12 - new interface only, the old one is actively removed |
| 15:31 |
gmcharlt |
(and I acknowledge that that is probably an aggressive timeline) |
| 15:31 |
terranm |
I seem to recall him saying that the code could be in there so that certain new elements could be available to other interfaces without the new patron interfaces being visible |
| 15:31 |
Bmagic |
That sounds pretty good to me |
| 15:31 |
JBoyer |
The first step proposed last time was non-ui stuff first since so many components have been updated, that could be 3.10 even if the alt-mode isn't available yet |
