09:29 |
* mmorgan |
tries to grab any of kmlussier's tuit cookies that remain |
09:29 |
Dyrcona |
Huh.... websocketd-osrf.service got disabled somehow. I've seen systemd disable user services after an update, but not system services.... |
09:30 |
Dyrcona |
systemd-- |
09:35 |
Dyrcona |
Nooooo! All that work and the test system still looks different from production. I even remade a new test branch in exactly the same way as production. |
09:35 |
Dyrcona |
i wonder if there's a template change in production that doesn't appear in the override folders? That has to be it. |
09:39 |
Dyrcona |
Nope. I just copied the production templates to my custom branch and `git diff` does nothing. |
09:47 |
Dyrcona |
git status say everything up to date. |
10:10 |
|
jvwoolf joined #evergreen |
10:10 |
|
mmorgan joined #evergreen |
10:11 |
Dyrcona |
This sort of thing drives me nuts. |
10:29 |
Dyrcona |
OK, so it looks like the difference is that templates/bootstrap/opac/parts/cart_nav.tt2 is displaying on the test system but not in production, even though it looks like it ought to display on both given what the templates all look like..... |
10:32 |
|
Christineb joined #evergreen |
10:36 |
csharp_ |
templates-bootstrap, you mean? |
10:36 |
csharp_ |
(wondering if the path is wrong) |
10:37 |
Dyrcona |
csharp_: You're correct. I can't type in chat. |
10:38 |
csharp_ |
btw, I'll state for the record that I don't like having templates and templates-bootstrap - seems like the bootstrap versions could be an option to symlink to or something and just have "templates", but it's ok |
10:38 |
Dyrcona |
What it looks like is production is rendering templates-bootstrap/opac/parts/topnav_subnav.tt2 differently than the test machine. |
10:38 |
csharp_ |
gotcha |
10:39 |
csharp_ |
@who is in charge of writing things down in The Record? |
10:39 |
pinesol |
eeevil is in charge of writing things down in The Record. |
10:42 |
JBoyer |
Dyrcona, any chance apache config stuff is an issue? |
10:43 |
Dyrcona |
JBoyer: The overrides are in different paths, but the Apache stuff is pretty much the same. |
10:44 |
Dyrcona |
I've eyeballed the eg_vhost.confs, but I'll diff them. |
10:47 |
Dyrcona |
OK. i difference: templates_cons (the override) comes before templates-bootstrap in production. On my test system both of the overrides come after the stock directories. I'll swap those and see what happens. |
10:47 |
Dyrcona |
s/i/1/ |
10:48 |
Dyrcona |
JBoyer++ That was it! |
10:49 |
Dyrcona |
csharp_++ too. |
11:03 |
|
kenstir joined #evergreen |
11:04 |
terranm |
As long as we close more bugs than we open |
11:19 |
|
mantis joined #evergreen |
11:19 |
mantis |
getting a 500 internal error when signing into the OPAC on MOBIUS test server 1 |
11:24 |
pinesol |
News from commits: LP#2052567: allow Reports to load when BitWarden plugin is active <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d3c203d3a1875f74a0ffe2db4431b49eb4564d3c> |
11:27 |
|
jvwoolf1 joined #evergreen |
11:34 |
Bmagic |
mantis: I might have been restarting apache at that moment (updating it for Czech language) - it's working for me at the moment |
11:36 |
mantis |
got it! thanks! |
11:37 |
csharp_ |
working on testing bug 1525394 and I have verified that part-holds now work, but we don't use serials and I'm not sure how to test issuance holds :-/ |
11:37 |
pinesol |
Launchpad bug 1525394 in Evergreen "SIP patron part level holds respond blank" [Undecided,Confirmed] https://launchpad.net/bugs/1525394 - Assigned to Chris Sharp (chrissharp123) |
11:38 |
csharp_ |
Bmagic: do you know if issuance holds are possible on your testbox with that fix on it? |
11:39 |
Bmagic |
I'm fuzzy on "issuance holds" but I don't see why the system wouldn't be able to do it. It's mostly stock Evergreen main |
11:47 |
Bmagic |
I spelled a couple of those wrong, lol |
11:49 |
Bmagic |
terranm: https://bugsquash2.mobiusconsortium.org/eg2/en-US/staff/catalog/search?org=1&limit=10&query=a&fieldClass=keyword&joinOp=&matchOp=contains&format=serial&dateOp=is&ridx=0 |
11:56 |
jeffdavis |
I'm a little disappointed to learn that Cat Fancy magazine has rebranded as Catster |
11:58 |
csharp_ |
Bmagic: actually I've been testing on our own server, but thanks for the connection info - I'll give yours a shot |
11:59 |
csharp_ |
jeffdavis++ |
12:00 |
terranm |
Bmagic++ jeffdavis++ |
12:01 |
collum |
Bmagic: in the url change query=a to query=* |
12:01 |
collum |
There's a few more. |
15:20 |
|
kmlussier joined #evergreen |
15:22 |
|
smayo joined #evergreen |
15:31 |
|
mantis left #evergreen |
15:45 |
csharp_ |
ok, next time anyone asks why the bugs aren't getting signed off on, please remember that it can take a lot of time and effort just to set up a test case! |
15:46 |
csharp_ |
I've spent 2+ hours today just trying to figure out enough serials to create an issuance hold to test the "no part holds showing up in SIP2" bug :-/ |
15:46 |
csharp_ |
(still not there) |
15:47 |
csharp_ |
and it might be sunk cost fallacy at this point, but I'll be damned if I don't figure this out and commit the fix |
15:48 |
|
kworstell-isl joined #evergreen |
15:50 |
Dyrcona |
csharp_++ |
15:51 |
Dyrcona |
I'm in a similar boat with the SFTP EDI stuff. I'm trying to figure out enough acq to set up test orders and pregenerated responses. |
15:59 |
Bmagic |
try hitting it from another VM to confirm? |
16:04 |
csharp_ |
Bmagic: looks ok now - thanks for checking |
16:04 |
Bmagic |
ok great |
16:17 |
csharp_ |
Bmagic: on bugsquash2, when I try to place a hold on Catster magazine after creating a holdable copy, I'm getting an empty red error box and this in the console: "ERROR TypeError: t.lastRequest.result.evt is null" - can you confirm? |
16:17 |
csharp_ |
I'm able to place the hold on my own test server running main-ish |
16:17 |
Bmagic |
checking |
16:17 |
csharp_ |
placing the hold for Sarah Smith |
16:18 |
csharp_ |
holdable copy barcode is "chrisistesting" |
16:19 |
csharp_ |
(my own server doesn't have the SIP2 port open on the ITS-administered firewall, so I can't test there) |
16:20 |
csharp_ |
however, I guess I'm now wondering if the item I attached is in fact an "issuance" |
16:20 |
Bmagic |
hold rule matrix is in the way I think |
16:20 |
csharp_ |
ah |
16:20 |
Bmagic |
result: Object { success: false, evt: null } |
16:46 |
Bmagic |
bugsquash3 will end up being a tomorrow thing if you'll still be around? |
16:47 |
csharp_ |
yeah, I'll be here - no biggie |
16:47 |
Bmagic |
I'm excited about sqaushing this one! |
16:47 |
csharp_ |
and I have a PINES-ish server to test - but it probably needs even more serials setup than enhanced concerto since we've never used it |
17:09 |
|
mmorgan left #evergreen |
17:15 |
|
sleary joined #evergreen |
18:59 |
|
jihpringle joined #evergreen |
12:39 |
|
kworstell_isl joined #evergreen |
12:52 |
Dyrcona |
And, now, there's a BIOS update. Might as well install that, too. |
13:00 |
|
Dyrcona joined #evergreen |
13:17 |
Dyrcona |
I'm looking at Lp 2040514. Does anyone have any tips for testing SFTP for EDI? I'm planning to set up one of my VMx to be the SFTP server. I'm wondering where I can look for actual messages to send back and forth. I'm pretty sure the actual EDI gets stored in the database somewhere. |
13:17 |
pinesol |
Launchpad bug 2040514 in Evergreen "EDI SFTP doesn't work" [High,In progress] https://launchpad.net/bugs/2040514 - Assigned to Jason Stephenson (jstephenson) |
13:18 |
|
kworstell_isl_ joined #evergreen |
13:29 |
|
jvwoolf joined #evergreen |
15:01 |
Bmagic |
#info mmorgan will explore moving LP stats to community site and automating same |
15:01 |
mmorgan |
Please carry forward. Wanted to also note that some of today's stats came from the Launchpad API. |
15:02 |
Bmagic |
#action mmorgan will explore moving LP stats to community site and automating same |
15:02 |
Bmagic |
#info sandbergja will see if gh actions can run the pgtap tests |
15:02 |
sandbergja |
I have a pullrequest for that, bug 2055796 |
15:02 |
pinesol |
Launchpad bug 2055796 in Evergreen "Have github actions run pgtap tests for us" [Undecided,New] https://launchpad.net/bugs/2055796 |
15:02 |
Bmagic |
sandbergja++ |
15:02 |
smayo |
sandbergja++ |
15:02 |
dluch |
sandbergja++ |
15:05 |
|
collum joined #evergreen |
15:05 |
Bmagic |
#action gmcharlt - create a Git commit message type and update bug 2051946 |
15:05 |
pinesol |
Launchpad bug 2051946 in Evergreen "institute a Git commit message template" [Wishlist,New] https://launchpad.net/bugs/2051946 - Assigned to Galen Charlton (gmc) |
15:05 |
Dyrcona |
Looks like it is in progress. I tested the other branch that makes release notes entries. |
15:05 |
eeevil |
gmcharlt_ is traveling today, aiui. |
15:05 |
Bmagic |
ah, cool |
15:05 |
Bmagic |
#info Stompro will formalize the tense usage in the release-note message |
15:13 |
sandbergja |
Dyrcona++ |
15:13 |
eeevil |
re the first part, I think that's smart (and then the release can get the squashed bugs) |
15:13 |
Bmagic |
+1 (and I can help with the building(s)) |
15:13 |
abneiman |
+1 to 27th, I can test & eval the release-notes script as part of point releases |
15:13 |
mmorgan |
+1 to March 27, I can help also. |
15:14 |
sandbergja |
Bmagic++ |
15:14 |
sandbergja |
abneiman++ |
15:23 |
Bmagic |
#topic New Business - Barriers to getting things committed |
15:23 |
jeffdavis |
I can start this off |
15:23 |
Bmagic |
please do |
15:23 |
jeffdavis |
I want to commit more pullrequests, but when I try, I often run into the same barriers: |
15:23 |
jeffdavis |
(1) no test environment available, (2) no test plan, (3) test plan is difficult to set up, (4) merge conflicts, esp with code that has sat uncommitted for months, (5) extra overhead required to backport and/or unsure whether to backport, (6) unresolved questions about the fix. |
15:23 |
jeffdavis |
I wonder if there are things we can be doing to mitigate some of those barriers? |
15:23 |
jeffdavis |
For example, would more community dev VMs be helpful? |
15:24 |
Dyrcona |
For 5 we can backport fewer fixes, particularly those that touch the database. |
15:24 |
Bmagic |
I think the answer is: yes |
15:24 |
Bmagic |
do we need a system for people to "checkout" a VM so it's their's for a time? |
15:25 |
sandbergja |
It seems that if we address some of the others, 4 might take care of itself (i.e. if we have a quicker commit cadence, branches won't sit for as long) |
15:25 |
abneiman |
4 is a problem, but especially a chicken-and-egg thing since the longer things sit without review the more conflicts they accumulate. For 2, I can commit to sharing test plans for Equinox-developed features. |
15:25 |
Bmagic |
we could use Evergreen to manage the checkouts |
15:25 |
abneiman |
sandbergja: great minds, lol |
15:25 |
Dyrcona |
i also think it is perfectly fair to comment on the bug that there is no test plan provided, and it's not obvious how to test the bug. |
15:26 |
Dyrcona |
For 4, it's also perfectly fine to ask the original developer to rebase it, or at least comment that it needs a rebase if you're not comfortable doing it yourself. |
15:26 |
sleary |
If you are the person rebasing it, and the merge conflicts have to do with CSS or ARIA, please ping me here and I'll be happy to help. |
15:27 |
abneiman |
+1, asking for dev rebases is totally fair game |
15:27 |
abneiman |
sleary++ |
15:27 |
jeffdavis |
I've also shared pullrequests and had to rebase them multiple times, which gets frustrating, so asking the dev to rebase is fair but only goes so far IMO. |
15:28 |
abneiman |
so it sounds like we really have 4 communications problems, 1 technical problem (test environments), and 1 practice problem (when do we backport?) |
15:28 |
Dyrcona |
jeffdavis: I do try to handle the rebases myself, but sometimes, its not obvious how to resolve it. |
15:29 |
mmorgan |
abneiman++ |
15:29 |
jeffdavis |
abneiman: great point |
15:29 |
kmlussier |
Often, when somebody asks for a rebase, it's during a rare moment when the tester has time to look at the code. If the person doesn't rebase it quickly, that person may no longer be available to test. Not so much a communications problem, but a tuits problem. |
15:30 |
Dyrcona |
I think that's more of a time problem. Most of us have "other jobs" or at least our job has more requirements than working on Evergreen code. |
15:30 |
dluch |
abneiman++ |
15:31 |
abneiman |
perhaps if a tester and a dev had a quick conversation, though, everyone's time could be used more valuably - "hey I'm planning to test this in $timeframe, do you mind looking at a rebase?" "I can do rebase within $possibleothertimeframe and let you know when it's done" etc etc |
15:32 |
mmorgan |
I think the code review sessions have been great for getting folks together to tackle individual bugs, whatever their issues. |
15:32 |
abneiman |
code review is GREAT for this |
15:32 |
abneiman |
sandbergja++ |
15:32 |
sleary |
sandbergja floated the idea of a rebasing party during the code review meeting on Monday. If people would like to do that this Friday, I can be available to help out with all the UI stuff that changed in the last couple of versions. |
15:33 |
dluch |
redavis: that's a good thought! |
15:33 |
redavis |
sandbergja++ sleary++ |
15:33 |
abneiman |
don't want to lose terranm 's point about devs / committers being engaged with BSW |
15:33 |
abneiman |
that's a time when a critical mass of people are testing, etc. |
15:33 |
sleary |
terranm++ |
15:33 |
Bmagic |
agreed |
15:33 |
redavis |
agreed |
15:39 |
Bmagic |
:), nevermind on the winding down |
15:39 |
kmlussier |
Oh, my. That's an old bug. I even have comments on it. |
15:39 |
abneiman |
Dyrcona: curious if you have an alternate suggestion? |
15:40 |
mmorgan |
Regarding test environments - community ones that can be checked out exclusively would be great |
15:40 |
terranm |
Maybe we need to have a needsdiscussion cleanup party, too |
15:40 |
redavis |
Bmagic++ mmorgan++ |
15:40 |
sleary |
terranm++ |
15:45 |
dluch |
We might be able to help with VMs...have to discuss internally, though |
15:45 |
abneiman |
Monthly half-day open code reviews or the like, with rotating responsibilty for hosting / VMs? |
15:45 |
csharp_ |
Bmagic: for me/us, the networking piece is an issue - PINES/GPLS machines are behind a finicky firewall :-/ |
15:45 |
Dyrcona |
We're supposed to be requiring test plans and release notes, so enforce that. (I've been adding them for my recent branches.) |
15:45 |
csharp_ |
but we can talk logistics at that level later |
15:45 |
abneiman |
and a committment from each senior committer to attend 1 per year or something |
15:46 |
kmlussier |
abneiman: I think a middle way is desireable. Smaller and more consistent contributions is a better approach than a mass of contributions / review happening at the same time. |
15:49 |
csharp_ |
it's not just a matter of time/tuits - I just need to develop better habits |
15:49 |
abneiman |
I'm just trying to think about ways to spread the load - if more people are doing things, we're relying less on the community unicorns (you know who you are lol) to shoulder so much |
15:50 |
dluch |
++ |
15:50 |
Dyrcona |
I've also been burned by not testing some big things thoroughly enough, so I like to set aside at least a day to test even small things. |
15:50 |
redavis |
(if you're in this meeting, you're a community unicorn) |
15:50 |
Bmagic |
redavis++ |
15:50 |
sleary |
kmlussier gmcharlt_ went over things with me, but I don't think there is much written down in the wiki on going from contributor to committer |
15:51 |
csharp_ |
🦄🦄🦄 |
15:51 |
kmlussier |
redavis: No, I'm just here because I like talking to all of you. |
15:51 |
Bmagic |
we're coming up on our hour yall |
15:51 |
sandbergja |
Dyrcona made me think of something that would be helpful for me: if there is a way we could run the tests against each pull request automatically. |
15:51 |
Dyrcona |
kmlussier: If you do want the commit bit back, just let me know. I can do it without a vote. :) |
15:51 |
sandbergja |
That green checkbox in Github saying "your tests passed" really helps me in other open source projects |
15:52 |
kmlussier |
redavis brought up earlier the idea of talkng about this at the hackfest. I've been thinking it might be worthwhile to have a monthly meeting where we could focus on one problem we want to solve. Because we could talk about this all day. |
15:52 |
Bmagic |
sandbergja: yes! a container that lauches with a branch and runs the test and dumps the results |
15:52 |
* csharp_ |
feels us teetering on the edge of the "move Git" discussion - keep his mouth shut |
15:52 |
sandbergja |
it wouldn't catch everything for sure, but it would provide a bit of a confidence boost |
15:52 |
kmlussier |
Dyrcona: I won't ask for it back unless I know I have the time to contribute. |
15:55 |
Bmagic |
https://wiki.evergreen-ils.org/doku.php?id=versioning |
15:55 |
jeff |
Are we talking about freshening up the examples and the OpenSRF / PostgreSQL deps? |
15:55 |
Bmagic |
ok, good idea, mailling list |
15:55 |
abneiman |
OTOH I think more automated testing is always going to be a good thing but I will not teeter us into "move git" today |
15:55 |
sleary |
move Git tomorrow ;) |
15:55 |
Bmagic |
#topic New Business - Possible hackfest (or other date) discussion on Evergreen releases - see email (Kathy) |
15:55 |
Bmagic |
#link http://list.evergreen-ils.org/pipermail/evergreen-dev/2024-February/000740.html |
13:48 |
jeffdavis |
Maybe that is a conference/hackfest discussion though. |
13:50 |
jeffdavis |
And maybe the recent work on improving our release process has exhausted our appetite for other process discussions. :) |
13:50 |
Dyrcona |
jeffdavis: Time... I need a clone. |
13:50 |
* sleary |
is always here for process discussions |
13:51 |
sleary |
At the last New Devs meeting, a lot of people said they had trouble just setting up test systems to work on. Docker helps, but it requires a ton of resources. |
13:52 |
sandbergja |
Bmagic: is node --version 16 or above on that box? |
13:56 |
Bmagic |
sandbergja, nope, 12.16.3 |
13:56 |
sandbergja |
I noticed that the new antora wants 16 or more: https://www.npmjs.com/package/antora/v/3.1.7?activeTab=code |
14:46 |
jeffdavis |
:) |
14:47 |
Dyrcona |
What do we mean "barriers to committing?" I assume it was about committers not reviewing code for main. |
14:47 |
Dyrcona |
My number 1 barrier is time. |
14:48 |
sandbergja |
For me, lack of time and access to a system for qa are big. But I'd also say that merge conflicts and semantic conflicts (e.g. an upgrade script changes a stored procedure, but that stored procedure has changed in the meantime, so committing it would cause a regression) also make things harder than they need to be |
14:49 |
sandbergja |
Also, I'd add that it takes a while to re-load concerto, or to manually run the automated tests |
14:50 |
Dyrcona |
For merge conflicts and semantic issues, just throw back at the original developer and ask for a rebase if you're not comfortable fixing the conflicts yourself. |
14:51 |
jeffdavis |
My other big ones are (1) no test plan, and/or tests are complicated to set up; (2) unresolved questions about the fix; (3) extra work to backport and uncertainty about whether to do so. |
14:51 |
jeffdavis |
Time is the big one, but the others all make the process even more time-consuming. |
14:52 |
Dyrcona |
yeah, testing is often difficult for me. I usually avoid staff client stuff because I never use it, so I often have trouble testing staff client changes. |
14:55 |
jeffdavis |
I wonder if some kind-hearted organization would be able to make a limited number of VMs available to committers to help mitigate the lack of access to test environments. |
14:56 |
jeffdavis |
(not thinking of any particular organization tbh, actually wondering if this is something my org could help with) |
14:59 |
Dyrcona |
My org is trying to get away from being in the hosting business. |
15:00 |
jeffdavis |
I know some wonderful folks do already set up test environments pre-loaded with branches for bug squashing weeks, I'm wondering about something a bit more flexible as a supplement. |
15:05 |
Dyrcona |
yeah, that's what I thought you meant. |
15:43 |
|
jihpringle joined #evergreen |
16:49 |
|
jvwoolf joined #evergreen |
10:25 |
Dyrcona |
Also, I get the buzzing noises, too. I've got 4 different conversations going on right now, including this one. :) |
10:29 |
|
kworstell-isl joined #evergreen |
10:30 |
|
redavis_reboot joined #evergreen |
10:34 |
pinesol |
News from commits: LP#2053245: fix Angular staff client test failure <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9aa81e3a89ff8631f5e026081a069e033a719d9e> |
10:51 |
|
stephengwills joined #evergreen |
10:56 |
|
collum joined #evergreen |
11:07 |
Dyrcona |
One thing that has come up in internal CW MARS discussion is that we need different intervals to clean data from different auditor tables. We keep 13 months on the biblio record entry history because we use it for a report. We keep 6 months on most tables. Then there's the hold request history where we need to keep 3 months or less because we purge certain holds at 3 months for privacy reasons. (NB: 6 months for most things was consi |
13:50 |
Dyrcona |
kmlussier++ tuits++ |
13:51 |
* Dyrcona |
should open a Lp bug to eliminate the acq auditor functions. |
13:53 |
Dyrcona |
csharp_: I could adapt fix_columns to a do block that hits these two tables. That might work for my purposes. |
13:59 |
Dyrcona |
Well, my test database is now a mess. |
14:01 |
Dyrcona |
Grr. It's not that simple.... Of course it's not that simple...... |
14:05 |
Dyrcona |
Well, that did not fix anything. |
14:06 |
Dyrcona |
because columns are still in different orders...... |
14:19 |
Dyrcona |
ugh... I'm going to have to do this again on a different schema version. |
14:20 |
|
_collum joined #evergreen |
14:23 |
Dyrcona |
So, the insert ... select takes longer when you don't truncate the source table first. |
14:29 |
Dyrcona |
Looks like the schema hasn't really changed between the two releases that I have test data for. |
14:33 |
csharp_ |
gmcharlt_: Rogan: in the Zoom waiting room for board meeting in case you can see this |
14:33 |
csharp_ |
or kmlussier or redavis |
14:33 |
Rogan |
csharp_: I'll mention it |
14:33 |
csharp_ |
Rogan: thank you |
14:41 |
|
collum joined #evergreen |
14:49 |
|
collum joined #evergreen |
15:03 |
Dyrcona |
heh. Test it on a database that hasn't had a refresh in over 6 months and all the rows disappear! That's a 100% space savings on that 1 table alone. :) |
15:17 |
Bmagic |
space good; cougar bad |
15:20 |
jeff |
space good. |
15:20 |
jeff |
sadly, this update wasn't nearly as exciting as it could have been: Introducing new Space Manager capabilities in Google Chat |
15:49 |
Dyrcona |
s/thought/though/ |
15:51 |
Bmagic |
Dyrcona: https://imgur.com/a/05CngrU |
15:51 |
Dyrcona |
heh. |
15:52 |
Dyrcona |
Well, it's tested as far as it works.... I'm just not sure if the streaming replication is gong to like it. |
15:52 |
Dyrcona |
I mean, I ran it on 4 databases..... :) |
15:53 |
Bmagic |
alright, I retract my link |
15:54 |
|
mantis left #evergreen |
09:47 |
|
redavis joined #evergreen |
09:47 |
Dyrcona |
Bmagic: Looks like offline-blocklist finished and the output is 18MB. |
09:49 |
Dyrcona |
Maybe the AND EXISTS will work if I remove the rule from the constraint... |
09:51 |
Dyrcona |
Nope. Do update requires inference specification or constraint name. Guess I can't really test the update, though it "worked" for the ones that existed, so it's good. Hopefully all of the users exist in production. |
10:01 |
berick |
hey, Ubuntu, how about I pay you *not* to advertise Ubuntu Pro at me? bleh. |
10:01 |
berick |
maybe time to mix up the ol' desktop OS |
10:02 |
Dyrcona |
berick: Have you considered Arch? I use it on my personal laptop. |
12:38 |
pinesol |
Launchpad bug 1901726 in Evergreen "Required Fields Based on Hold Notification Preferences Too Strict" [Medium,Confirmed] https://launchpad.net/bugs/1901726 |
13:01 |
abneiman |
sandbergja++ redavis++ mmorgan++ Bmagic++ # rmaking point releases happen |
13:02 |
mmorgan |
abneiman++ |
13:32 |
sandbergja |
The 3.12.1 tarball finished building. I'm going to try installing it and running the tests |
13:40 |
|
jihpringle joined #evergreen |
13:44 |
sandbergja |
So far, the perl unit tests, perl live tests, pgtap, and angularjs unit tests have passed. Waiting on angular unit and e2e tests, OPAC js tests, and C tests. |
13:47 |
sandbergja |
I <3 tests, but dang, that is a lot of testing frameworks |
13:47 |
sandbergja |
I think two of them are my fault hahaha |
13:47 |
Dyrcona |
sandbergja++ |
13:48 |
Dyrcona |
Well, we need more tests, and maybe fewer frameworks. |
13:48 |
sandbergja |
+1 |
13:49 |
Dyrcona |
I suppose we can drop 1 of the frameworks, or at least 1 set of tests, when AngularJS is finally gone. |
13:49 |
sandbergja |
Oh, one test question that I've been meaning to ask forever. What is the distinction between pgtap regression tests and just regular pgtap tests? |
13:51 |
Dyrcona |
The regression tests are, I think, meant to check that certain database changes have not been undone. |
13:52 |
Dyrcona |
I added a regression test to my branch for Lp 1835953 to make sure that the columns have the not null constraint. |
13:52 |
pinesol |
Launchpad bug 1835953 in Evergreen "Circulation auto renewal remaining should not be nullable" [Medium,In progress] https://launchpad.net/bugs/1835953 |
13:53 |
sandbergja |
Dyrcona++ |
13:54 |
sandbergja |
I like that example! |
13:58 |
Dyrcona |
That branch makes a few updates to the pgtap tests and the sample data load. |
14:08 |
sandbergja |
3.12.1 tarball tested and it passed! |
14:09 |
sandbergja |
I've uploaded the release directory here: https://drive.google.com/drive/folders/1PVlPVhJ8UtUUH7Yu1JRSsJkr1TOo0Fgv?usp=drive_link -- gmcharlt: could you please upload it to lupin? |
14:21 |
sandbergja |
I pushed my working branch to tags/rel_3_12_1. I also added the upgrade script to the rel_3_12 and main branches. Does that seem as it should be? |
14:21 |
Dyrcona |
Yes, that sounds right. Let me have a look. |
14:22 |
sandbergja |
Dyrcona++ |
14:22 |
Dyrcona |
Looks good to me. I can copy the files to Lupin if gmcharlt hasn't gotten to it, yet. |
16:00 |
Bmagic |
I've not done any release work today |
16:01 |
Dyrcona |
Bmagic: I'm talking about last time. |
16:02 |
Bmagic |
on point releases, I believe we skip down to Translations, Part 2: update_pofiles steps. new pot would be applied to the main branch of the evergreen release series. AKA rel_3_12. And not* against tags/rel_3_12_1. At least that's the way I understand it. Please feel free to correct me! |
16:03 |
Dyrcona |
Don't know if I'll finish testing this today. We'll see. |
16:03 |
Dyrcona |
Bmagic: newpot was done the previous two times on 3.11, so I did it again. |
16:03 |
Dyrcona |
The commits are there anyway. |
16:04 |
Bmagic |
ok, that's fine. It's ok if it's done against the point release tags branch, though I believe the design intension was to have new pot run ahead of time, at some frequency, independent of the point release cycle |
16:04 |
Dyrcona |
Should I test with OpenSRF main or 3.2.4? |
16:05 |
Bmagic |
I'm not sure it matters today if you use main opensrf or 3.2.4. Is there a commit difference between them? |
16:06 |
Dyrcona |
Yeah, I'm going with main because I already installed the prerequisites. |
16:06 |
Dyrcona |
I did that reflexively before I started working on release building. |
16:16 |
Dyrcona |
I fixed the syntax and regenerated the HTML. I'll have to update the tarball. |
16:16 |
Dyrcona |
No, you don't have a point release assigned to you. I don't think we're using the spreadsheet this time. |
16:18 |
Dyrcona |
oof. I just realized that I've been using markdown link syntax when I've been writing release notes lately. I'll have to fix those, I think. |
16:22 |
Dyrcona |
I'm not going to be able to test this today. |
16:25 |
pinesol |
News from commits: Fix syntax in 3.11 release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=2d50b18103dcf0480467bfcab5b3ce2f173a7f38> |
16:27 |
Dyrcona |
i can probably test the db upgrade scripts without too much setup. |
16:29 |
Dyrcona |
nah, I'll have to test this later. |
16:30 |
Dyrcona |
I pushed the tag branch and copied the files to lupin where I can get them later to test. |
16:30 |
Dyrcona |
I'll have to see if I can test this tomorrow some time, but I've got stuff to do. |
16:34 |
Dyrcona |
I've put the release files here: https://drive.google.com/drive/folders/1Eys7BQV4TdDcgs8QtXy6XJ46QC8CMbyK?usp=sharing |
16:35 |
Dyrcona |
If anyone else wants to test. Also, let me know if you can't access that or the contents. It should be shared with anyone who has the link. |
16:35 |
sandbergja |
Dyrcona++ |
16:35 |
sandbergja |
I can run the automated tests on that tarball this afternoon |
16:36 |
Dyrcona |
sandbergja++ |
16:53 |
sandbergja |
It would be nice if we could make the perl live tests and nightwatch e2e tests faster too. I suspect that's a barrier to people running them regularly. |
17:06 |
|
jihpringle joined #evergreen |
17:09 |
|
mmorgan left #evergreen |
17:16 |
sandbergja |
all tests are passing for that 3.11.3 tarball, except for 3 of the nightwatch tests (for vandelay, holdings view, and acq providers). I didn't see anything obviously amiss with those screens, fwiw. It is not specific to the tarball. I get the same failures after installing rel_3_11 from source. |
17:16 |
sandbergja |
I think we should investigate them, but I don't think they need to block the release or anything. |
17:17 |
sandbergja |
abneiman++ redavis++ Bmagic++ Dyrcona++ mmorgan++ # thanks for helping with these releases! |
17:38 |
|
book` joined #evergreen |
19:27 |
|
jihpringle joined #evergreen |