Time |
Nick |
Message |
02:35 |
|
StomproJ joined #evergreen |
03:24 |
|
ahazaril joined #evergreen |
03:24 |
|
ahazaril joined #evergreen |
04:35 |
|
stompro__ joined #evergreen |
07:24 |
|
stompro joined #evergreen |
07:49 |
|
BDorsey joined #evergreen |
07:56 |
|
mantis1 joined #evergreen |
08:26 |
|
collum joined #evergreen |
08:32 |
|
mmorgan joined #evergreen |
08:36 |
|
Christineb joined #evergreen |
08:41 |
Stompro |
mmorgan, No word yet from B&T about content cafe. I'm still seeing the same error and no cover art. |
08:46 |
mmorgan |
Stompro: Same here. I just asked for an update. |
08:46 |
|
dguarrac joined #evergreen |
09:08 |
|
Dyrcona joined #evergreen |
09:09 |
Stompro |
Dyrcona, I didn't see your question yesterday, I'll send you what I have for Content Cafe. I have an integration guide from 2010. |
09:19 |
|
montgoc1 joined #evergreen |
09:21 |
|
Stompro joined #evergreen |
09:21 |
Stompro |
mmorgan, I just tested it again with Postman, and the request worked!!! |
09:21 |
Dyrcona |
Stompro++ |
09:23 |
mmorgan |
Woo! Just cleared added content cache for a record and got a cover image! |
09:23 |
mmorgan |
Stompro++ |
09:26 |
Stompro |
I'm clearing all nocontent jacket art from memcached to see if a bunch more show up. |
09:26 |
Dyrcona |
Stompro: If you could past that command somewhere, it would be useful to others. |
09:26 |
Dyrcona |
paste, that is. |
09:27 |
Stompro |
Sure, one sec, want to see if it actually works. |
09:27 |
* mmorgan |
is seeing the images returning in catalog searches :) |
09:32 |
Dyrcona |
Yes. I see images for some records. I guess we need to clear memcached, too. |
09:36 |
Stompro |
Here are my bash scripts for clearing nocontent cover art. https://gist.github.com/stompro/909380a82a08463087433b58ea15d75e |
09:38 |
Stompro |
I checked on something that still wasn't showing up, and got this error. <Error>Database 'Jacket' cannot be opened. It is in the middle of a restore.</Error> |
09:39 |
Stompro |
So they must still be actively working on the fix. |
09:39 |
mmorgan |
Interesting! |
09:39 |
mmorgan |
Stompro++ |
09:39 |
Dyrcona |
Indeed. |
09:40 |
Dyrcona |
I had a look at how Koha retrieves data from Content Cafe yesterday afternoon, and I may do an experiment later to see if that would work for Evergreen. If it does, I'll probably open a Lp bug and submit a branch for consideration. |
09:41 |
mmorgan |
Dyrcona++ |
09:42 |
Stompro |
Dyrcona, what do they do differently? |
09:43 |
Dyrcona |
They use GET for starters. |
09:43 |
Dyrcona |
Oh, and https. |
09:45 |
Stompro |
The request that failed 5 minutes ago with that error now works. |
10:08 |
|
sleary joined #evergreen |
10:10 |
|
terranm joined #evergreen |
10:33 |
pinesol |
News from commits: LP#1916403 Staff catalog search form labels <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=10758c49008acd80dc70575534e0b1c954a91594> |
10:37 |
|
jvwoolf joined #evergreen |
11:00 |
|
kworstell_isl joined #evergreen |
11:02 |
|
sleary joined #evergreen |
11:03 |
pinesol |
News from commits: LP1999270: add release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=19aabb492d1dcc0742a9e88729758582ca2d1d12> |
11:03 |
pinesol |
News from commits: LP1999270: Bold the Paid indicator on line items <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6fbe63c97eab8c06dc18864adcbd7f43f7b22e5a> |
11:23 |
|
kworstell_isl joined #evergreen |
11:33 |
Stompro |
Are there some gotchas related to showing the keyboard shortcuts modal? I thought it was supposed to come up by pressing the ? key. Not working for me on https://bugsquash.mobiusconsortium.org/eg2/en-US/staff/splash |
11:34 |
Stompro |
Hmm, works in the check-in interface. |
11:35 |
|
rfrasur joined #evergreen |
11:35 |
sleary |
I thought it was just control-H |
11:37 |
|
Christineb joined #evergreen |
11:37 |
|
collum joined #evergreen |
11:37 |
|
rhamby joined #evergreen |
11:37 |
|
jonadab joined #evergreen |
11:37 |
|
scottangel joined #evergreen |
11:37 |
|
Bmagic joined #evergreen |
11:37 |
Stompro |
sleary, thank you. Strange that there are two different screens. Ctrl-H brings up a different screen than ? |
11:38 |
berick |
Stompro: angular vs angularjs |
11:38 |
berick |
depends on the page |
11:39 |
Stompro |
Ah, thanks. |
11:42 |
Bmagic |
Does Evergreen still use an iframe for some of the staff client interfaces? |
11:43 |
Bmagic |
I know it did. For the catalog search interface. I can't remember if Evergreen has other interfaces that make use of an iframe or not |
11:44 |
berick |
Bmagic: a few old interfaces. acq invoice page, for example |
11:44 |
Bmagic |
oh yeah! The dojo interfaces are iframes? |
11:44 |
berick |
yep |
11:44 |
Bmagic |
berick++ |
11:44 |
Bmagic |
I thought there were still some |
11:48 |
Bmagic |
I'm reading this: https://owasp.org/www-community/attacks/Clickjacking |
12:05 |
|
jihpringle joined #evergreen |
12:18 |
|
BDorsey joined #evergreen |
12:37 |
|
dtmoore joined #evergreen |
13:13 |
|
stompro_home joined #evergreen |
13:47 |
|
dtmoore joined #evergreen |
13:53 |
|
montgoc01 joined #evergreen |
13:55 |
|
Stompro joined #evergreen |
13:56 |
Stompro |
mmorgan++ for listing out the keyboard shortcuts for the help modals. |
14:04 |
pinesol |
News from commits: LP1999955 release note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8c9dc8e04ed9933509ccff68412f3220f9adf8ab> |
14:04 |
pinesol |
News from commits: LP1999955 AccessKeys info style updates <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e5771b849b5bf729501f036ee8e7b6f0f2f1c5e9> |
14:08 |
Stompro |
I'm looking at bug 1940662, and my already installed version of marc_export has a --strip option... which doesn't seem to be in master... I have no idea were it came from. |
14:08 |
pinesol |
Launchpad bug 1940662 in Evergreen "marc_export should have a --pipe option to force acceptance of a list of ids on standard input" [Wishlist,New] https://launchpad.net/bugs/1940662 - Assigned to Josh Stompro (u-launchpad-stompro-org) |
14:14 |
jeff |
bug squashing week is really not the time to set a draft comment aside until you have time to organize your thoughts better. TOO LATE! COMMITTED! |
14:15 |
Stompro |
Ohh, there it is, bug 1754455 |
14:15 |
pinesol |
Launchpad bug 1754455 in Evergreen "marc_export: want to delete fields/subfields" [Wishlist,Fix committed] https://launchpad.net/bugs/1754455 |
14:23 |
Dyrcona |
jeff: Is your draft comment about the --strip option? |
14:24 |
Dyrcona |
Stompro: Do you want me to rebase the --pipe option branch? It probably has a conflict now. |
14:24 |
Dyrcona |
FWIW, I've been using the --pipe option in production for a couple of years. |
14:24 |
Stompro |
No, it has no conflicts so far. |
14:25 |
Dyrcona |
Oh! That's good and ... surprising. |
14:25 |
Stompro |
I was just confused by which version I was looking at when I made my comment above. |
14:26 |
Dyrcona |
Yeah. Too many branches.... |
14:27 |
csharp_ |
@praise jeff |
14:27 |
* pinesol |
I come to praise jeff, not to bury them. |
14:29 |
jeff |
Dyrcona: no, but thanks for checking :-) |
14:29 |
Dyrcona |
:) |
14:30 |
jeff |
csharp_: not sure why I'm receiving praise, but thanks! |
14:31 |
|
dtmoore joined #evergreen |
14:32 |
csharp_ |
jeff: oh, just commiserating about making public mistakes :-) |
15:04 |
jeff |
csharp_: ah! :-) |
15:10 |
Dyrcona |
Ooh. This'll be fun. Add a change to a file that was deleted in the latest commit. |
15:12 |
|
dtmoore joined #evergreen |
15:39 |
|
stompro_home joined #evergreen |
15:55 |
Dyrcona |
Heh. Cool. You can cherry-pick commits from other branches during interactive rebase. |
15:57 |
Stompro |
Dyrcona, For bug 1940662 I don't think --since works with --pipe. I'm not sure if it should, or if it was just added to the commit message by mistake. |
15:57 |
pinesol |
Launchpad bug 1940662 in Evergreen "marc_export should have a --pipe option to force acceptance of a list of ids on standard input" [Wishlist,New] https://launchpad.net/bugs/1940662 - Assigned to Josh Stompro (u-launchpad-stompro-org) |
16:03 |
csharp_ |
Dyrcona: never thought of that, but it makes sense |
16:03 |
csharp_ |
Git is truly amazing software |
16:24 |
|
sleary joined #evergreen |
16:26 |
Dyrcona |
Stompro: I commented on the bug. I can change the code if you think it is necessary, just add a comment to the bug. |
16:31 |
Stompro |
Dyrcona, I'll just take that out. I cannot think of why it would make sense. Thanks for looking at it. |
16:35 |
Dyrcona |
Stompro: It should probably return an error in the way that --pipe and --all do. I really don't remember why I thought --since and --pipe should work together. |
16:38 |
* Dyrcona |
thinks we should not be using pcrud so much in the client, but that's just my opinion. Take it for what it is or isn't worth. Re Lp 2002693 |
16:38 |
pinesol |
Launchpad bug 2002693 in Evergreen "Logging out on a page with a pcrud call floods browser with errors" [High,Confirmed] https://launchpad.net/bugs/2002693 |
16:39 |
Dyrcona |
It's not worth much seeing as I have contributed next to no code to the client. |
17:13 |
|
mmorgan left #evergreen |
17:14 |
|
stompro_home joined #evergreen |
20:15 |
|
kworstell-isl joined #evergreen |
20:17 |
|
dtmoore joined #evergreen |
20:52 |
|
kworstell-isl joined #evergreen |
21:05 |
pinesol |
News from commits: LP1998969 Make disabled <option>s more obvious <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a0f08fd8cbb38a80ae497f2cac4c9df3204a3887> |