Evergreen ILS Website

Search in #evergreen

Channels | #evergreen index




Results

Result pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139

Results for 2017-06-25

03:07 RBecker joined #evergreen
04:31 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
06:14 rlefaive joined #evergreen
07:50 jvwoolf joined #evergreen
10:43 jvwoolf joined #evergreen
13:09 apst left #evergreen
13:19 koa joined #evergreen
14:58 Jillianne joined #evergreen
16:30 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
17:43 rlefaive joined #evergreen

Results for 2017-06-24

04:31 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
08:48 _adb joined #evergreen
16:31 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
19:12 jvwoolf joined #evergreen
20:10 jvwoolf joined #evergreen

Results for 2017-06-23

04:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:14 rjackson_isl joined #evergreen
07:31 agoben joined #evergreen
07:38 Dyrcona joined #evergreen
09:35 yboston joined #evergreen
09:59 Dyrcona Yeap, grunt all blows up on me again on a fresh install on Ubuntu Xenial. This time I'm installing rel_2_12 with no customizations.
10:02 Dyrcona I can try again with a fresh Debian 8.
10:02 JBoyer Dyrcona, Not that I think this is a good thing to do full time, but if you just do a grunt build does it work? (i.e. skipping the test)
10:02 Dyrcona I am installing the developer prereqs and not building node from source.
10:02 Dyrcona JBoyer: I'll try that. It does look like a test that's failing.
10:03 csharp npm feels fragile to me - kinda like ruby gems
10:03 Dyrcona The build "succeeds" with this message from cssmin:combine :
10:03 Dyrcona >> Destination not written because minified CSS was empty.
10:04 csharp or even CPAN, though that's been more consistently stable than I've seen the other two be
10:04 Dyrcona csharp: Node feels fragile to me, not just npm, worse than ruby gems.
10:04 JBoyer I think the last time I was having issues with grunt test it was something of ours, but it's been a minute.
10:05 Dyrcona I get that same reference error from yesterday.
10:08 Dyrcona Hmm... Something isn't getting loaded in the tests, I assum.
10:08 Dyrcona Assume, even.
10:09 JBoyer It's ok, dropping the e in Assumr would be hipster, but dropping the e from Assum is tres Unix.
10:09 Dyrcona It's complaining about the angular.module() line at the top of services/core.js.
11:03 Dyrcona It might. I don't remember.
11:04 berick Bmagic: a copy does not have to pass action.hold_request_permit_test to appear in the hold_copy_map.
11:04 Bmagic i see
11:05 berick only directly targeted (or op-captured) copies have to pass the test
11:06 Bmagic I think we are getting warm
11:06 Bmagic mmorgan: no penalties
11:11 pinesol_green [evergreen|Jason Etheridge] lp1653998 webstaff redirect to login page - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=518023b>
15:33 jeffdavis If you have older records with old-style Overdrive URIs you don't need the 037.
15:33 hbrennan We have the option of importing the MARC Express records to get caught up, and I haven't looked closely at them yet
15:43 jihpringle joined #evergreen
16:31 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
16:40 Dyrcona And, just like that: 92,811 lines of code written...
16:40 Dyrcona emacs++
16:41 * berick chuckles
16:42 * Dyrcona just mangled a spreadsheet into a ridiculous number of SQL inserts. :)
16:43 Dyrcona About 5 lines for each insert.
16:45 dbwells joined #evergreen
16:50 jeff live test failure does not at first glance appear to be a transient one, nor does it seem to be what Dyrcona ran into recently. commit 518023b might need some followup.
16:50 pinesol_green jeff: [evergreen|Jason Etheridge] lp1653998 webstaff redirect to login page - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=518023b>
16:50 jeff "Unknown provider: $routeProvider"
16:56 Dyrcona Ah.. this just went in this afternoon.

Results for 2017-06-22

01:57 * bshum will look at it more tomorrow
02:01 jeffdavis bshum++
03:12 RBecker joined #evergreen
04:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:06 rjackson_isl joined #evergreen
07:28 csharp ~~
07:28 csharp 
09:19 jvwoolf joined #evergreen
09:23 yboston joined #evergreen
09:30 maryj joined #evergreen
10:26 bshum So it looks like there are three PO templates that are failing to import
10:26 bshum Two of them appear to be tests
10:27 bshum build/i18n/tests/data/sql2pot.pot
10:27 bshum and build/i18n/tests/data/testidl.pot
10:27 bshum Both of them are dying cause of a missing end qoute on line 6 where the timestamp should be, I guess.
10:28 bshum I'm not really sure we should worry about these, given that they appear to be really ancient test files for PO Templates, but maybe we should either fix the line, or get rid of the file altogether if they no longer serve a purpose.
10:29 bshum The other one that appears to be broken is build/i18n/po/multiclass_search_help.​html/multiclass_search_help.html.pot
10:29 bshum Which seems to be pulling the entire HTML in, instead of finding any specific strings
10:29 bshum And it's choking cause it's expecting a PO template, not raw HTML
10:31 bshum Since multiclass_search_help.html is part of the XUL server files, I'm not sure if we shouldn't also deprecate that and remove the offending POT and POs that can't be translated anyways
10:35 Dyrcona I'm still working on setting up Syrup on an alternate host, and I really have no idea what I'm doing. The README is really short on details and seems to assume that you know Django and otherwise know what you're doing.
10:35 Dyrcona Do I just have to change the settings in localsettings.py and it will just work? For some reason, I doubt that.
10:36 jeff yep! my experience was similar, though possibly with an AM/PM inversion!
10:42 Dyrcona So, I have to run the manage.py script in each instance... OK.
10:43 Dyrcona The vm has a non-routing IP address. It's only visible at central site or via vpn.
10:44 jeff assuming you're starting with Django 1.4.x, all of the top-level DATABASE_* settings in local_settings.py.example should be commented out, and you should use the example DATABASES= hash to set the various settings.
10:44 dbs bshum: I think the POT tests are still useful. Looks like there is a small delta required for one or two of the tests to still pass.
10:44 bshum dbs: Yeah I was just wondering if we run them as part of the nightly test
10:44 jeff under DATABASES[default], i set ENGINE, NAME, USER, PASSWORD, HOST, and PORT
10:45 Dyrcona jeff: Yes. I've copied everything from production and just modified the values.
10:45 bshum dbs: Well, daily I guess.
10:45 jeff for postgres, i used 'ENGINE': 'django.db.backends.postgresql_psycopg2'
10:45 Dyrcona jeff: ditto. :)
10:45 bshum I kind of wish there was a way of excluding the tests from going to LP translations though.
10:45 jeff Dyrcona: ah! then you're at least starting from a working install, which is possibly better off than starting from scratch!
10:45 Dyrcona Could be. :)
10:46 Dyrcona I'm changing the db and the evergreen instance that it talks to.
10:48 dbs bshum: might have been under buildbot? doubt it for the live reporter though
10:48 bshum dbs: That's kind of what I figured
10:49 dbs bshum: if launchpad is purely filename-based, we could do a workaround like having the setup / teardown rename a file from blah.pot.example to blah.pot for the test, then rename it back
10:49 bshum dbs: Yeah it seems to be targeting only things with .po or .pot
10:50 dbs testIDL and testSQL just need a single space removed from their POT test file to make their tests pass
10:51 bshum Alternatively, we could create a different repo for translations right?  And only sync that stuff against master or whatnot for the files we specify to target for translation efforts
10:51 bshum Or do we want to keep everything as bound together as we can
10:51 bshum (thinking ahead to when we replace LP translations)
10:56 * bshum reads about Koha's thoughts on that in https://wiki.koha-community.org/​wiki/Git_Splitting_and_Shrinking
10:58 bshum I guess they keep their POs as part of their main code still
10:58 * bshum ponders that further
10:58 dbs user/dbs/tiny_i18n_test_fix working branch has fixes for two of the i18n tests that were failing on my Fedora 25 machine
10:58 dbs to test: cd build/i18n; python tests/testIDL.py; python tests/testSQL.py
10:59 * dbs returns to prepping for Senate meeting
11:00 bshum dbs++ # thanks
11:26 Dyrcona jeff: Should I do manage.py syncdb or manage.py migrate?
11:27 jeff syncdb in this case.
15:03 eeevil but, best to get rid of shapers on safe networks in any case
15:03 berick right, ok, bundling gets us back to multiple osrf blobs per message for tightly packed stuff
15:03 eeevil right
15:03 berick yes, agreed, i'm testing no-shapers now
15:11 Dyrcona That grunt all error didn't happen on a Debian 7 server with a similar, but not identical branch.
15:12 Dyrcona One big difference: The Debian 7 server had the staff client installed before, the Ubuntu vm is fresh.
15:17 Dyrcona Happens with rel_2_12 on that same vm. I'll build a fresh one.
15:54 berick get all the bits into the shelter!
16:08 mmorgan joined #evergreen
16:57 jihpringle joined #evergreen
17:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:04 jwoodard joined #evergreen
17:04 jihpringle joined #evergreen
17:05 jvwoolf left #evergreen
17:32 jihpringle_ joined #evergreen
18:19 eeevil csharp: if you're using pgdump output (rather than pgdumpall) then I think you need to create the extensions (and set the search path, etc) before restoring.  pgdump/restore is so much more finicky than pgupgrade...
18:20 jihpringle joined #evergreen
18:23 csharp eeevil: ah - thanks - in this case I'm dumping from our 9.4 prod db into a 9.5 test db - looks from stack exchange posts that the problem is that the extension isn't created in the right order
18:24 csharp also doing parallel restore, so maybe that's a factor too
18:42 jamesrf joined #evergreen
19:29 jeff csharp: you've run into bug 1671150 which i should probably actually take a moment to work on.
19:29 pinesol_green Launchpad bug 1671150 in Evergreen "Unqualified references in evergreen.unaccent_and_squash lead to index creation failures with pg_restore" [Undecided,In progress] https://launchpad.net/bugs/1671150 - Assigned to Jeff Godin (jgodin)

Results for 2017-06-21

02:09 Jillianne2 joined #evergreen
05:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:11 rjackson_isl joined #evergreen
07:35 agoben joined #evergreen
08:16 annagoben joined #evergreen
10:56 pinesol_green Launchpad bug 1677000 in Evergreen "There is no visual indicator that a patron record has notes in the Web client" [Medium,In progress] https://launchpad.net/bugs/1677000 - Assigned to Jason Etheridge (phasefx)
10:58 kmlussier Actually, that's not really my question. From what I can tell, some of the commits from collab/phasefx/webstaff-bugs have been merged, but not all of them. Is that right?
10:59 * kmlussier isn't quite sure what the purpose of the collab branch is
11:07 cesardv kmlussier: phasefx can correct me if I'm wrong, but basically it's a way to make sure everyone's commits play nicely with each other, avoid merge conflicts, and for testing changes that depend on other changes, or just general testing
11:09 kmlussier Yeah, I guess I just don't understand why we do things differently for the web client than we do for other parts of the software, particularly when it comes to bug fixes. They could just be merged and backported once tested IMO.
11:10 Dyrcona The only advantage of collab branches is multiple people can commit to them.
11:10 Dyrcona That may be why it is being used.
11:11 phasefx kmlussier: feel free to remove me.  I'm not 100% on that branch either
11:15 phasefx I think the notion is that folks could cherry-pick commits into master as needed but it made things simpler to batch up changes to test over here
11:20 * gmcharlt notes that given the past practice of doing merges of big webstaff branches where there was relatively little review, at least at the individual patch level, with the bug fixes we've been moving back into a more "normal" workflow
11:22 * csharp wishes his day job gave him more bandwidth for EG dev :-/
11:22 gmcharlt the bugfix collab branch is, at root, more of an artifact of how that particular bugfixing sprint is organized on Equinox's end
14:18 Dyrcona @clone
14:18 pinesol_green Dyrcona: I see nothing, I know nothing!
14:18 Dyrcona :)
15:19 pinesol_green [evergreen|Ben Shum] i18n: fix syntax for Spanish lang.dtd - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=ed7ae7c>
15:37 collum joined #evergreen
16:24 kmlussier joined #evergreen
16:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:52 kmlussier joined #evergreen
16:52 bshum @dessert
16:52 * pinesol_green grabs some Chocolate Eclairs for bshum

Results for 2017-06-20

00:37 jeffdavis joined #evergreen
04:18 RBecker joined #evergreen
05:00 pinesol_green` News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:05 JBoyer joined #evergreen
07:06 agoben joined #evergreen
08:31 kmlussier joined #evergreen
12:28 Newziky joined #evergreen
12:31 kmlussier gmcharlt: Thanks! It's been on my radar.
12:36 * Dyrcona is planning to install 2.12.3 on training and update a development vm after its released.
12:36 Dyrcona I was going to try and test something today, but I think I just hosed the vm I was gonna use.
12:46 Bmagic ::whisper:: docker
12:46 csharp heh
12:48 Dyrcona ::retort:: learning curve
14:17 _adb (j/k)
14:17 _adb yes, they're delightful.
14:17 Freddy_Enrique Jajajaja
14:53 pinesol_green [evergreen|Galen Charlton] LP#1694696: add some unit tests for A/T helpers - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a7e3147>
14:53 pinesol_green [evergreen|Chris Sharp] LP#1694696 - Check for blank SMS Carriers in A/T reactor - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=697d260>
15:02 Freddy_Enrique joined #evergreen
15:07 cesardv_ hi guys, random question, has anyone considered JIRA as a possible replacement for Launchpad?
15:07 pinesol_green [evergreen|Bill Erickson] LP#1691473 Internal Apache HTTP port configuration - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c6b3d45>
16:10 Dyrcona distraction--
16:29 JBoyer joined #evergreen
16:34 mmorgan joined #evergreen
17:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:07 mmorgan left #evergreen
17:23 b_bonner left #evergreen
18:14 barbara joined #evergreen

Results for 2017-06-19

04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
06:27 gsams joined #evergreen
07:12 rjackson_isl joined #evergreen
07:53 littlet joined #evergreen
10:05 Freddy_Enrique hello guys :)
10:05 bshum Freddy_Enrique: Howdy :)
10:20 csharp Dyrcona: lacked outright as far as I can tell
10:22 bshum In the article I linked, it suggested that one could add it back by installing net-tools package, which worked when I did that on my Stretch test VM
10:22 bshum But I guess I should learn the future
10:24 pinesol_green [evergreen|Jason Etheridge] LP#1616980 webstaff: protect "magic statuses" when editing copies - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=05dcc80>
10:33 remingtron joined #evergreen
10:37 mmorgan joined #evergreen
15:04 berick kmlussier: i'm familiar w/ the mighty Rolo, though it's been years
15:04 berick Dyrcona: i'm removing you as assignee for bug 1373690 unless you say otherwise
15:04 pinesol_green Launchpad bug 1373690 in Evergreen "Direct EDI generation for ACQ orders -- AKA kill ruby webrick" [Wishlist,New] https://launchpad.net/bugs/1373690 - Assigned to Jason Stephenson (jstephenson)
15:05 Dyrcona OK. I was going to test it in the last few weeks, but something else came up.
15:05 * berick nods
16:04 jihpringle_ joined #evergreen
16:09 maryj joined #evergreen
16:12 Jillianne joined #evergreen
16:12 jihpringle_ joined #evergreen
16:31 mmorgan joined #evergreen
17:01 pinesol_green News from qatests: Test Failure <http://testing.evergreen-ils.org/~live>
17:04 kmlussier pinesol_green: Well that's not a nice way to end the day.
17:04 pinesol_green kmlussier: What we have here is a failure to communicate.
17:06 mmorgan left #evergreen
17:10 berick hm, looks like a bit of syntax chrome is OK with but the test runner isn't
17:10 berick trailing comma
17:11 jvwoolf left #evergreen
17:13 berick fix -> http://git.evergreen-ils.org/?p=worki​ng/Evergreen.git;a=commitdiff;h=6b5d3​5c8da1a819df6ff74f17e7a3f94ff8f8219
17:18 * gmcharlt grabs it
17:19 gmcharlt berick++
17:21 pinesol_green [evergreen|Bill Erickson] Remove testrunner-breaking trailing JS comma - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=f91286e>

Results for 2017-06-18

04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
06:39 RBecker joined #evergreen
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:55 Jillianne joined #evergreen
23:17 bshum o.O
23:18 bshum "The ifconfig command has been deprecated and thus missing by default on Debian Linux, starting from Debian stretch."
23:18 * bshum rolls his eyes
23:18 bshum https://linuxconfig.org/how-to-install-m​issing-ifconfig-command-on-debian-linux
23:19 bshum Just in case anyone ends up testing Debian 9 now that it's been released :)

Results for 2017-06-17

02:55 Jillianne joined #evergreen
03:06 RBecker joined #evergreen
04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
08:09 _adb joined #evergreen
14:32 jvwoolf joined #evergreen
14:49 egbuilder joined #evergreen
14:49 wsmoak joined #evergreen
15:50 Jillianne joined #evergreen
16:19 Bmagic joined #evergreen
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
18:50 dbs joined #evergreen
20:27 RBecker joined #evergreen

Results for 2017-06-16

01:30 Jillianne joined #evergreen
02:09 bshum And found it
02:09 bshum Freddy's problem with the closed date editor is an issue with the Spanish translation file for lang.dtd and the closed date editor.
02:10 bshum staff.server.admin.closed_dat​es.editor.allmultiday.format in lang.dtd
02:10 bshum There's a special note saying: Translators: do not translate "<b>YYYY-MM-DD</b>" or "<b>HH:MM</b>"
02:11 bshum And the Spanish translation there is
02:12 bshum "Nota: Todas las fechas deben tener el formato <b> AAAA-MM-DD </ b>. Los "
02:12 bshum "tiempos deben tener la forma <b> HH: MM </ b>"
02:12 bshum Changing that back to the right variables, things worked
02:12 bshum So, bleh
02:13 bshum Changing that AAAA back to YYYY and made things look closer to the original and things worked out
02:15 bshum And making it AAAA is fine too.
02:16 bshum It's probably more of a syntax issue with the code itself, hmm
02:18 bshum And there is it...
02:18 bshum The problem is that </ b> is used in the translation.  There's an extra space between the / and b in those ending tags
02:18 bshum Removing the space fixes the problem
02:19 bshum For installed version; it'll be the entry for that string in /openils/var/web/opac/locale/es-ES/lang.dtd
02:19 bshum Editing it to remove that space fixes the syntax error in my testing
02:24 * bshum goes to sleep happier knowing the answer to the problem :)
03:12 remingtron_ joined #evergreen
03:12 dbwells_ joined #evergreen
03:23 Jillianne2 joined #evergreen
04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:03 csharp bshum++
07:14 rjackson_isl joined #evergreen
07:32 agoben joined #evergreen
09:07 jvwoolf left #evergreen
09:09 _adb joined #evergreen
09:10 maryj joined #evergreen
09:11 * Dyrcona contemplates making /etc/hosts entries for some of his test vms.
09:15 * csharp does that
09:21 * Dyrcona actually does it, too. :)
09:22 Dyrcona Maybe now, I can copy and paste URLs from my gitlab test vm and they'll actually work. :)
09:32 Freddy_Enrique joined #evergreen
09:34 Dyrcona acquisitions--
09:35 Dyrcona Freddy_Enrique: Have a look at this http://irc.evergreen-ils.org/​evergreen/2017-06-16#i_310838
12:02 Stompro bshum, That is what I mean.  Admin -> Server Admin -> Z39.50 Servers
12:02 bshum Stompro: Then yeah, adding a new server works that way. Did you also define attributes for that new server for search purposes?
12:03 * bshum never really ever used the GUI for it, and just poked directly at the DB tables
12:05 Stompro bshum, Yes, I just added one attribute for title to test.  Works fine from the yaz-client... but no results when tried from the EG client for the same search.
12:10 mmorgan joined #evergreen
12:17 bshum maybe someone else will have more ideas to try.  I only remember that those code/format/truncation settings for z39.50 attributes can get weird depending on the z39.50 server you're trying to talk to
12:18 bshum Not all servers are configured the same way, so copying "title" attribute from one to another doesn't guarantee success.
16:16 mmorgan I'm going to conclude that the status was edited by the audit_user at the audit_time.
16:16 mmorgan And not puzzle about it any longer.
16:16 Dyrcona :)
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:07 mmorgan left #evergreen
17:09 Bmagic Anyone using pgpool with Evergreen?
17:18 jvwoolf joined #evergreen

Results for 2017-06-15

01:37 Jillianne joined #evergreen
04:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:24 agoben joined #evergreen
08:36 _adb joined #evergreen
08:59 mmorgan joined #evergreen
10:58 Dyrcona Maybe that's more than you wanted to know.
10:59 Freddy_Enrique yep, I have a better picture of what is going to happen
10:59 Freddy_Enrique just a couple of months
10:59 Freddy_Enrique meanwhile I would like to continue testing the software
11:01 Dyrcona Freddy_Enrique: I recommend setting up the web client if/when you build your own test system.
11:01 Dyrcona It is listed as optional at the moment.
11:03 Freddy_Enrique about the web interface, I consider it a big change. Not so sure if I should call it improvement thought. Why this decision?
11:04 Freddy_Enrique Personally I found it more convenient
11:30 kmlussier Is there any particular reason you would find it useful?
11:32 Freddy_Enrique Well, at least... That approached really worked for koha. People got interested in that ILS cause they more or less knew what the could actually do
11:32 Freddy_Enrique approach*
11:33 kmlussier Sure, but I'm not seeing how wiping the data helps with the testing.
11:33 kmlussier In some cases, I think people are trying out the system over multiple days and find it useful to have the same data there when they return to the server/
11:34 Freddy_Enrique Your are right
11:34 * kmlussier isn't objecting to the idea, but just trying to see the pros and cons.
11:37 Freddy_Enrique I think call it: try it yourself! . We could enter, experiment with it. and...if by any chance I mess it up. Everything comes back to normal
16:03 hbrennan joined #evergreen
16:05 tspindler left #evergreen
16:08 jvwoolf1 joined #evergreen
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:31 mmorgan1 joined #evergreen
18:39 csharp @band add Highest Karma
18:39 pinesol_green csharp: Band 'Highest Karma' added to list

Results for 2017-06-14

03:21 Jillianne joined #evergreen
05:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:16 rjackson_isl joined #evergreen
07:22 agoben joined #evergreen
08:08 kmlussier joined #evergreen
10:34 Freddy_Enrique Great! and finally, is there any recommendation which Library should be in charge of the server where the EG software is implemented?
10:34 csharp we may keep our DBs on 14.04/PG 9.4 though
10:35 jeff csharp: The Carrollton Contingency itself would probably make a good band name.
10:35 bshum In the past, what I ended up doing was keeping our utility server and such on older Ubuntu distros since the upkeep tended to require more thorough testing
10:35 csharp @band add The Carrollton Contingency
10:35 pinesol_green csharp: Band 'The Carrollton Contingency' added to list
10:35 dbs Well, for the first test upgrade I'll give Xenial a run and see what happens
10:35 csharp jeff++
10:35 bshum But move the app servers and DB servers ahead to the latest Ubuntus
10:35 dbs you people and your multiple app/utility servers :)
10:38 dbs Bmagic++
10:39 kmlussier Freddy_Enrique: Also, following up on what I said earlier about size of the consortium, I'll refer back to what dbs just said about multiple app/utility servers. In our consortium we have Evergreen running on several bricks.
10:39 Bmagic dbs: It's been working just fine for us. The EDI stuff works too :)
10:39 Dyrcona dbs: A/T seems to work fine, I've run them on test databases copied from production.
10:39 dbs excellent!
10:39 kmlussier Once you need to move to multiple servers, I think it increases the complexity of maintaining the system. But I'm not a systems person - that's just what I've observed.
10:39 Dyrcona I use Xenial for my test and development vms, mostly.
10:39 cfarley I'm trying to have evergreen start automatically after a reboot, but having an issue.
10:40 cfarley When run from a cron job autogen.sh stalls out, but if I run the script manually, it doesn't have any issues.
10:40 cfarley Anyone played with this before?
13:48 Dyrcona JBoyer: Staff can access deleted bibs, so if you remove the metabib info, they will not turn up in searches for staff.
13:48 JBoyer (I hope this DELETE doesn't come back 2 hours after I leave with a "nope, you have to delete this table at the same time, etc.)
13:49 Dyrcona JBoyer: It might. :)
13:49 JBoyer Maybe I'll just cancel it and go for 1 bibid to test. I'd like to be able to test things this week. :p
13:50 kmlussier Staff searches bring up deleted records? That doesn't sound right.
13:50 JBoyer kmlussier, if you know to type #deleted into a search box.
13:50 kmlussier Oh, yes. Ignore me.
16:04 kmlussier miker: Yeah, that proposal is something that's been sitting on our backburner for a while. I need to get focusing on that at some point.
16:22 jihpringle joined #evergreen
16:37 cfarley joined #evergreen
17:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:06 mmorgan left #evergreen
17:20 jvwoolf left #evergreen
18:32 jihpringle joined #evergreen

Results for 2017-06-13

04:32 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
05:19 Sinkme joined #evergreen
07:12 rjackson_isl joined #evergreen
07:16 agoben joined #evergreen
10:39 Freddy_Enrique So I can get to that page in order to adopt any additional tools for the evergreen, and also fix some bugs.
10:44 kmlussier Freddy_Enrique: Yes, absolutely. We also have some bugs with a 'bitesize' tag that should be smaller bugs to help new contributors get started. https://bugs.launchpad.net/ever​green/+bugs?field.tag=bitesize
10:47 * Dyrcona is bepuzzled.
10:47 kmlussier Speaking of photos for patron records, I wonder if they display in the web client. We don't use them, so I never thought of testing them.
10:52 * Dyrcona thinks I may not have actually loaded the db modification that I thought I was testing.
10:54 mmorgan joined #evergreen
10:55 maryj joined #evergreen
10:55 Dyrcona No, I did,  and it seem to make things worse from one point of view, but more digging is required.
10:56 * Dyrcona is being cryptic....
10:59 mllewellyn joined #evergreen
11:00 * kmlussier runs a quick test and sees no patron record images displaying in the web client.
11:01 * kmlussier 's dog looks very cute in the xul client.
11:04 Dyrcona heh.
11:52 Freddy_Enrique joined #evergreen
11:53 _adb joined #evergreen
16:49 mmorgan We had a number of auto-updates fail during our last upgrade.
16:50 jeffdavis mmorgan: Auto-update worked well for us in our 2.10->2.12 upgrade (also for 2.8->2.10). As a rule, partial update fails but full update works.
16:57 * mmorgan is not sure what is meant by partial vs. full.
17:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:00 gmcharlt mmorgan: partial tries to install only the files that have changed since the previous build; full just does a full overwrite
17:02 mmorgan Is that an option when building the self-updating client?
17:13 kmlussier mmorgan: I don't know the answer to your question, but I know when a partial update has failed for me in the past, I'm presented with the option to do the full update.

Results for 2017-06-12

02:06 Bmagic joined #evergreen
02:51 jvwoolf joined #evergreen
04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
06:50 JBoyer joined #evergreen
07:09 rjackson_isl joined #evergreen
07:18 agoben joined #evergreen
16:18 JBoyer Yeah, the fork is fine and the child is returned because it's a higher demand period (i.e. not on the inactive list), for some reason it can't auth, boom, open-ils.search blows up. :/
16:19 JBoyer erlang.log is useless, ejabberd.log shows several connections, but they all appear to have the expected "Accepted legacy authentication for opensrf@..." lines with them.
16:20 * JBoyer is planning to put together a big 'ol text document for the LP bug)
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:31 jeffdavis JBoyer: I'm not seeing errors like that in our logs
16:32 Dyrcona JBoyer: I've only ever seen messages like that when ejabberd has crashed or hit some limit, that I recall.
16:33 Dyrcona And, I haven't seen them in a while, except once recently, when I missed one of the settings on a test vm.
16:33 Dyrcona You still may have encountered something new.
16:34 berick so, i was testing hold targeter here recently and each parallel process was fetching 100k+ hold ids in "substream" mode (1 jabber message per id).  this caused ejabberd to lock up for severl seconds while it routed all the messages.  I wonder if the new bundling/chunking osrf 2.5 changes are having a simimlar effect.  messages that used to be large, are now a blast of smaller messages, adding load to
16:34 berick ejabberd.
16:34 Dyrcona That would make a lot of sense.
16:34 Dyrcona Or does make a lot of sense.
16:35 miker berick: have you removed all shapers?

Results for 2017-06-11

01:13 Jillianne joined #evergreen
01:50 Freddy_Enrique joined #evergreen
04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
15:23 Jillianne joined #evergreen
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
18:23 Freddy_Enrique joined #evergreen
21:41 csharp Inkscape moves to gitlab from Launchpad: https://inkscape.org/en/news/20​17/06/10/inkscape-moves-gitlab/
22:20 genpaku joined #evergreen

Results for 2017-06-10

04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:15 Jillianne joined #evergreen
17:21 Jillianne joined #evergreen
18:37 remingtron joined #evergreen

Results for 2017-06-09

03:12 book` joined #evergreen
04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
06:40 rlefaive joined #evergreen
07:04 rjackson_isl joined #evergreen
07:28 graced Happy Friday, #evergreen!
11:59 jvwoolf joined #evergreen
11:59 berick Dyrcona: the api uses new_salt when changing the password.  get_salt() is more about handling an existing password (e.g. during login)
12:00 berick i mean you could re-use the salt, but that seems non-good.
12:00 Dyrcona OK. In my case, I'm reusing the salt, but this is just to test something not related. :)
12:01 Dyrcona I wanted to change the password for a user on my test database to try downloading their circ history.
12:01 Dyrcona I think I will write myself a custom function doing it correctly for future situations like this.
12:02 Dyrcona I just pulled the salt, etc., from the db tables this time.
12:03 berick Dyrcona: fyi, Actor::modify_migrated_user_password() shows the typical steps for moding a passowrd.  translating that to a DB func would be trivial.
12:04 Dyrcona OK.
12:04 Dyrcona I think my test db/vm are too slow.
12:04 Dyrcona Oh. nice. internal server error.
12:06 Dyrcona [Fri Jun 09 12:05:20.331897 2017] [perl:error] [pid 20167] [client 192.168.100.100:43488] Apache2::RequestIO::print: (32) Broken pipe at /usr/lib/x86_64-linux-gnu/perl5/5.22/Template.pm line 180, referer: https://10.250.150.80/eg/opac/myopac/circ_history
12:07 pinesol_green [evergreen|Terran McCanna] LP#1681943 Improve Responsive Design in My Lists - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=d786c57>
15:28 pinesol_green [evergreen|Galen Charlton] LP#1533326: follow-up to remove extra logging statement - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c1ecb35>
15:33 Bmagic It looks like it's solved in 2.12.x
15:41 kmlussier joined #evergreen
15:41 * kmlussier shakes her fist at Comcast
15:45 kmlussier Of course, now that I think about it, I probably could have continued testing offline circ while Comcast was down.
15:45 berick Comcast is your mirror cat
15:47 kmlussier It all comes back to the mirror cat, doesn't it?
15:49 mmorgan Pay no attention to the cat in the mirror...
16:06 * Dyrcona makes that one a bit more than he'd like to admit.
16:13 miker not copy-paste, typo's mine in here :)
16:14 miker no, it's just that you can't say "no, make that other radio button selected via change to a scope var"
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:51 Jillianne joined #evergreen
16:55 jvwoolf left #evergreen
17:02 mmorgan left #evergreen

Results for 2017-06-08

04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
06:42 rlefaive joined #evergreen
07:11 rjackson_isl joined #evergreen
07:20 agoben joined #evergreen
11:03 mmorgan Malikythe: Lost item?
11:05 Malikythe gsams: Gah, I'm dumb. I hit "Display alert and messages" and it told me there were none, so I didn't check the messages tab itself. Apparently something about the non-blocking messages my staff had been adding resulted in the orange color.
11:05 gsams PINES also has a page on this: https://pines.georgialibrari​es.org/patron-border-colors
11:06 Malikythe It's weird, though. I removed all the messages and added a new one to test it, and it turned the border cyan (which is what I'm used to for non-blocking messages)
11:06 gsams Malikythe++ #It's happened to me a few times
11:06 Malikythe Dunno where the orange came from
11:06 gsams According to the PINES page, it means multiple penalties are in place
11:22 dbs Also penalties show up under the patron's name, such as "Patron exceeds fine threshold"
11:22 micro_ joined #evergreen
11:22 mmorgan The patron name shows in red in the web client if they are blocked.
11:22 micro_ why is the demo test client not work
11:22 dbs mmorgan: Yeah that's the high-level "problem!" highlight and the details are often also highlighted below
11:22 kmlussier Guest72111: Which demo test client?
11:22 Guest81886 I cant connect to either the server
11:22 JBoyer I need to pull up more patrons with issues, I didn't realize there were colors or penalties listed either.
11:22 kmlussier Guest72111: There are a few
11:28 Guest81886 That is for the demo.evergreencatalog.com
11:28 kmlussier Guest72111: Is anything listed in the Organization dropdown underneath the WS name box?
11:28 Dyrcona That means your client is not getting the settings from the server. I don't know why.
11:29 Guest81886 but when i enter mlnc2.noblenet.org it says "There was an error testing this hostname"
11:29 kmlussier Guest81886: Sorry, I can't help you with demo.evergreencatalog.com.
11:29 kmlussier Guest81886: Yes, that's what I mentioned above, about the SSL exception.
11:29 dbs Guest81886: maybe try https://webby.evergreencatalog.com ?
13:08 JBoyer -u
13:43 Dyrcona _bott_: While you're around, would you mind branchifying your patches on Lp 1195428?
13:43 pinesol_green Launchpad bug 1195428 in Evergreen "TPAC reports hold "ready for pickup" before hold_shelf_status_delay expires" [Medium,Confirmed] https://launchpad.net/bugs/1195428
13:43 Dyrcona We just got a report of it, and I would like to test your code.
13:55 _bott_ Let me see if I can track that down!
14:19 Jillianne joined #evergreen
14:41 _bott_ Dyrcona: http://git.evergreen-ils.org/?p=wor​king/Evergreen.git;a=commit;h=c16cf​d0f680c7d28b8d201ec79618e2aeac6ff72
14:57 Jillianne joined #evergreen
14:59 kmlussier joined #evergreen
15:58 Dyrcona joined #evergreen
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:11 mmorgan left #evergreen
17:17 jvwoolf left #evergreen
17:25 rsulejmani joined #evergreen

Results for 2017-06-07

01:27 rlefaive joined #evergreen
04:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
06:40 rlefaive joined #evergreen
07:11 agoben joined #evergreen
07:15 rjackson_isl joined #evergreen
15:24 dbs I'll add it to the wiki page and organize a new "translation tools" section
15:24 gmcharlt dbs++
15:25 Dyrcona I've not had much time to experiment, but we appear to lose some of the fine-grained control over repositories, so we may need to revisit how we manage branches at the moment.
15:28 gmcharlt ok
15:29 gmcharlt are we at a point where it would make sense to stand up a VM on the community's server, put gitlab there, and open up for more testing?
15:30 miker I don't see a reason not to mirror our current git setup over to gitlab, if that can be done
15:31 gmcharlt indeed
15:31 Dyrcona It's more like reflected in a pond than mirrored.
15:44 phasefx csharp: need a random bug dispenser for pinesol :)
15:44 * berick was mostly distracted from meeting, will reread notes
16:12 rlefaive joined #evergreen
16:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:54 kmlussier joined #evergreen
17:01 rlefaive joined #evergreen
17:05 mmorgan left #evergreen

Results for 2017-06-06

04:02 umarzuki hi, evergreen docker image unable to be pulled
04:02 umarzuki https://hub.docker.com/r/m​obiusoffice/evergreen-ils/
04:02 umarzuki Error response from daemon: manifest for mobiusoffice/evergreen-ils:latest not found
05:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
05:29 umarzuki joined #evergreen
06:40 rlefaive joined #evergreen
07:11 agoben joined #evergreen
07:50 Dyrcona joined #evergreen
08:04 collum joined #evergreen
08:08 rlefaive joined #evergreen
08:38 JBoyer umarzuki, If you plan to use the web client (a good idea, especially for testing) you don't need to worry about it. Also, if you don't set it to anything you can still use the XUL client, you just have to download it directly from your server instead of evergreen-ils.org.
08:39 JBoyer it would be at (your-server)/updates/manualupdate.html
08:48 tsbere joined #evergreen
08:48 bos20k joined #evergreen
16:01 gsams jeffdavis++
16:02 gsams I believe the issue may have been resolved.  I'm going to remain vigilant in any case.
16:24 maryj joined #evergreen
16:31 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:53 mmorgan left #evergreen
17:00 bpmcneilly left #evergreen
17:04 jvwoolf joined #evergreen

Results for 2017-06-05

02:50 genpaku_ joined #evergreen
04:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:07 rjackson_isl joined #evergreen
07:12 JBoyer joined #evergreen
07:31 agoben joined #evergreen
08:48 bos20k joined #evergreen
08:53 kmlussier joined #evergreen
08:55 umarzuki joined #evergreen
08:56 umarzuki i got "Received no data from server" when testing srfsh request opensrf.math add 2,2
08:57 umarzuki shell output > https://pastebin.com/id9VWfrf
09:00 umarzuki srfsh.log https://pastebin.com/ppnbtLfR
09:23 Bmagic umarzuki: Trying to get the Evergreen server setup for the first time?
09:25 Bmagic umarzuki: You might be interested in the "one command to install it all" solution https://hub.docker.com/r/m​obiusoffice/evergreen-ils/
09:28 Dyrcona joined #evergreen
09:53 umarzuki I'm installing this on vmware workstation
09:56 bshum With Xenial, another issue that's cropped up lately has been problems where the firewall blocks ejabberd from communicating
09:57 bshum I thought berick found a workaround for the ansible installer, not sure if that'll help
09:58 umarzuki bshum: firewalld service not enabled and iptables -L shows no rules
09:58 umarzuki I'm just using zaq12wsx for password, testing purposes only
10:00 bshum That doesn't seem too overly complex and should have worked then
10:00 bshum Hmm
10:01 Dyrcona umarzuki: Did you change the auth_passwrd_format to plain in ejabberd.yml?
10:52 collum joined #evergreen
10:52 bshum JBoyer: cesardv: I'll be curious to see what you guys find with those settings carrying over between retrieved users in the last comments on https://bugs.launchpad.net/evergreen/+bug/1642035 ; I think I saw a similar issue occurring with the patron stat cats where the last entry made on one user was also showing up when retrieving the next user (who didn't have an entry yet)
10:52 pinesol_green Launchpad bug 1642035 in Evergreen "Web Staff Client - Problems saving notification preferences" [Undecided,Confirmed]
10:59 cesardv bshum: yeah I noticed that while doing some testing... I'm still pretty new to Evergreen, but yea seems like (according to a comment on regctl.js)  there's caching of data unless explicitly click out of the patron tabs
11:02 kmlussier JBoyer / agoben: Can you remind me what the hack-a-way date is?
11:06 agoben The EOB day is November 6; the Hack-away is November 7-9.  (I've run into an issue with our location from last year, so am working on alternate options for the venue.  Will announce as soon as possible.)
11:07 berick thanks agoben , was wondering myself
15:25 berick JBoyer: oh, right
15:46 collum joined #evergreen
15:55 Jillianne joined #evergreen
16:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:14 mmorgan left #evergreen
19:33 jihpringle_ joined #evergreen
22:20 genpaku joined #evergreen

Results for 2017-06-04

04:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:27 jonadab joined #evergreen
12:48 rlefaive joined #evergreen
16:20 Jillianne joined #evergreen
16:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
16:39 rhamby_ joined #evergreen
16:48 drigney joined #evergreen
22:16 Jillianne joined #evergreen

Results for 2017-06-03

02:06 StomproJ joined #evergreen
04:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
08:42 _adb joined #evergreen
09:08 littlet joined #evergreen
12:08 littlet_ joined #evergreen
13:22 sandbergja joined #evergreen
15:10 Jillianne joined #evergreen
16:30 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
20:39 littlet joined #evergreen
22:20 genpaku joined #evergreen

Results for 2017-06-02

05:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
07:11 rjackson_isl joined #evergreen
07:21 Callender joined #evergreen
07:27 agoben joined #evergreen
13:43 Dyrcona Also, 84MB of swap used, but I don't worry about such a low number. :)
13:43 Dyrcona JBoywer: Thanks!
13:43 Dyrcona JBoyer, even. :)
13:44 Dyrcona Well, guess I'll do my fourth or fifth code installation on my test vm this week, and I haven't even really started testing it.
13:44 Dyrcona Looks like that won't happen until next week.
13:45 * Dyrcona is getting tired of looking at server specs and selecting options.
13:45 JBoyer Though when I've seen that in the past it was just a controller setting that could be changed whenever, are there really different disks for these types? (I've not dealt with NVMe yet)
13:58 Dyrcona Did anyone else get an email from HackerEarth to participate in some hackathon?
13:59 JBoyer I guess the rest of us just have to click on the pi symbol on Mozart's Ghost like it's the 90's.
14:00 Dyrcona Well, it looked legit, and I was just curious if anyone else got it, i.e. why did I get one?
14:02 Dyrcona gmcharlt: We had a ticket about the download history just this morning, so I'll use that patron to test.
14:05 StomproJosh joined #evergreen
14:05 dbwells_ joined #evergreen
14:11 abneiman JBoyer++ # investigations :)
15:56 jvwoolf Dyrcona: Thanks for the feedback. :)
16:37 berick aww, concerto has a patron street address "Cheerful Animal Valley"
16:37 berick so much better than "Spotty Chemical Stravenue"
17:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:03 jvwoolf left #evergreen
17:08 csharp @band add Cheerful Animal Valley
17:08 pinesol_green csharp: Band 'Cheerful Animal Valley' added to list

Results for 2017-06-01

11:55 pinesol_green Launchpad bug 821640 in Evergreen master "Define a macro for grand total of all bills listed" [Undecided,Fix released]
11:56 bshum grand_total_owed ?
11:57 bshum Yeah that patch in that bug added three new macros:  grand_total_owed, grand_total_billed, grand_total_paid
11:58 mmorgan Just tested, bshum is correct, %grand_total_owed% print the total outstanding for the patron
11:58 mmorgan er, prints
12:00 bshum mmorgan++ # thanks for checking out my theory
12:01 * bshum misses having a real Evergreen server at his fingertips
12:01 bshum Well, kinda misses.  :)
15:58 berick oddly appropriate, pinesol_green
15:58 bshum I thought I enabled that one
15:58 * kaffenkj wishes we could do away with resumes and look at character stat sheets when evaluating new hires
15:58 bshum Guess not
15:59 bshum @ana This is a test
15:59 pinesol_green bshum: Its hastiest
15:59 berick bshum++
15:59 berick @ana Smirnoff Ice Watermelon
16:01 Dyrcona @quote randome
16:01 pinesol_green Dyrcona: http://xkcd.com/1739/
16:01 Dyrcona @quote
16:01 pinesol_green Dyrcona: We're going to need a bigger boat.
16:04 mmorgan1 joined #evergreen
16:27 jvwoolf left #evergreen
16:55 khuckins_ joined #evergreen
17:00 pinesol_green News from qatests: Test Success <http://testing.evergreen-ils.org/~live>
17:06 mmorgan left #evergreen
17:35 Jillianne joined #evergreen
19:17 jeff 3

Result pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139