| 10:11 |
|
berick joined #evergreen |
| 10:15 |
|
remingtron joined #evergreen |
| 10:51 |
|
tspindler joined #evergreen |
| 11:39 |
remingtron |
bshum: I'm testing a fresh 2.7 beta db and getting "ERROR: function evergreen.rank_cp(bigint) does not exist" |
| 11:39 |
remingtron |
is rank_cp a normal Evergreen function, or is it likely to be something custom on my end? |
| 11:39 |
remingtron |
we have done some postgres hacking on this server |
| 11:43 |
tsbere |
I think rank_cp is normal, but apparently missing |
| 11:43 |
kmlussier |
I'm guessing it's something that might have been impacted by bug 1234845? |
| 11:43 |
pinesol_green |
Launchpad bug 1234845 in Evergreen "possible optimization for evergreen.ranked_volumes database function" (affected: 2, heat: 12) [Medium,Fix committed] https://launchpad.net/bugs/1234845 |
| 13:03 |
mmorgan |
ok, i see that function. So all the data in the opac comes via those functions? |
| 13:03 |
* mmorgan |
is still trying to learn how the data gets from one place to the other ... |
| 13:05 |
|
RoganH joined #evergreen |
| 13:05 |
tsbere |
mmorgan: I believe a large percentage of the information in the opac comes from there. I haven't actually traced everything. Adding to the XMLATTRIBUTES list and the GROUP BY (at opposite ends of the functions) should hopefully let you add new fields like active_date. I would test in a dev system first though. |
| 13:07 |
mmorgan |
ok, thanks. We'll take a look at that. |
| 13:07 |
mmorgan |
tsbere++ |
| 13:08 |
berick |
beware the record details page is different. See Record::mk_copy_query, which calls AppUtils::basic_opac_copy_query |
| 13:08 |
berick |
which uses a json_query instead of unapi |
| 13:12 |
mmorgan |
berick: ok, thanks. We will proceed with caution - on our test server. |
| 13:15 |
|
hbrennan joined #evergreen |
| 13:17 |
|
mtate joined #evergreen |
| 13:35 |
dbs |
Some day maybe those two will be reconciled :/ |
| 13:42 |
eeevil |
bug 1355319 |
| 13:42 |
pinesol_green |
Launchpad bug 1355319 in Evergreen "Missing Dependency: Parse::RecDescent" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1355319 |
| 13:43 |
Dyrcona |
I thought it worked with lp and the number. |
| 13:44 |
Dyrcona |
Anyway.... about to test the Makefile.install fix on Ubuntu Trusty. |
| 13:44 |
Dyrcona |
If someone could test Fedora, that would be great. |
| 13:49 |
dbs |
If only we had a live build tester for Fedora |
| 13:50 |
Dyrcona |
dbs: I can't tell if you're being sarcastic or not. ;) |
| 13:51 |
bshum |
Dyrcona: I think the lp didn't work for pinesol_green without the space between LP and # |
| 13:51 |
Dyrcona |
I thought there was a space. |
| 13:51 |
dbs |
Not sarcastic. The live build tester started failing a day or two ago because of the Parse::RecDescent missing problem |
| 13:52 |
Dyrcona |
Whatever....Machines don't like me, and I don't like them either. ;) |
| 13:52 |
dbs |
05:16 < pinesol_green> Incoming from qatests: Test Failure - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 13:52 |
dbs |
I noticed it over the weekend, and it does a very good job of highlighting the problem |
| 13:52 |
Dyrcona |
Yep. I noticed it Friday, and had forgotten about it when I built my latest VMs, until they didn't work of course. |
| 13:53 |
bshum |
I didn't get to build anything new yet, but that makes me feel a little better that I haven't actually rolled the beta1 tarball yet then. |
| 13:53 |
bshum |
Dyrcona++ for following up on that dependency issue |
| 14:15 |
Dyrcona |
bshum: You want me to target the bug at beta1? |
| 14:15 |
bshum |
Dyrcona: Yeah we should put it in |
| 14:15 |
Dyrcona |
I did originally and then waffled. |
| 14:21 |
Dyrcona |
I have tested it on Ubuntu Trusty, and I presume the Debian and Ubuntu Precise targets will work, since they all name the package the same way. |
| 14:22 |
Dyrcona |
I put in the name of the package as I found it for Fedora 20, so hope Fedora works. ;) |
| 14:48 |
|
csharp joined #evergreen |
| 14:57 |
bshum |
Dyrcona++ |
| 16:50 |
eeevil |
right |
| 17:08 |
|
mmorgan left #evergreen |
| 17:09 |
|
mdriscoll left #evergreen |
| 17:11 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:23 |
phasefx |
Dyrcona++ bshum++ |
| 09:10 |
|
kmlussier joined #evergreen |
| 09:12 |
berick |
remingtron: working/user/berick/lp1332138-lp1329503-reports-combined |
| 09:12 |
berick |
i'll add a note to the LP's too |
| 09:12 |
remingtron |
berick++ #helping me test |
| 09:14 |
|
jwoodard joined #evergreen |
| 09:19 |
kmlussier |
Happy beta day! |
| 09:21 |
kmlussier |
Just a reminder that the following features need release notes - http://bit.ly/X4fGFH. I'll take care of the top one when it's ready to go. |
| 09:22 |
kmlussier |
And another reminder to fill out the bug squashing day poll. I hope to close it today. http://doodle.com/2dx9h3cccwbp84v4 |
| 09:22 |
* kmlussier |
is done issuing reminders. For now. |
| 09:24 |
kmlussier |
berick: On the reports branches, I was close to ready to sign off on the documentation one (just wanted to do some last-minute testing this morning), but was still finding issues on the other. I see you've merged them Any problem with me still signing off on the one? |
| 09:25 |
|
tater joined #evergreen |
| 09:28 |
berick |
kmlussier: no, that's fine. I can re-merge w/ signoff's (FYI remingtron) |
| 09:28 |
remingtron |
got it. thanks |
| 09:43 |
remingtron |
I think that's all |
| 09:46 |
yboston |
I will work on these |
| 09:47 |
remingtron |
yboston: thanks! |
| 09:47 |
dbs |
Sounds like we need a docs test build server maybe... |
| 09:48 |
yboston |
I have considered setting a test docs build server at Berklee, set to run its scripts mid day |
| 09:48 |
remingtron |
dbs: yes, that would be great. Robert is out of country all summer, any idea how/where else to set one up? |
| 09:48 |
yboston |
that way we can get a heads up on what will go wrong |
| 09:48 |
|
Dyrcona joined #evergreen |
| 09:52 |
dbs |
that wouldn't give us the whole enchilada that rsouilliere has going on but at least we could see build errors immediately |
| 09:52 |
remingtron |
dbs: definitely a good start |
| 09:53 |
remingtron |
yboston: did Robert give you the build scripts and all? |
| 09:53 |
yboston |
he has a github repository for them |
| 09:53 |
yboston |
looking it up now |
| 09:53 |
yboston |
https://github.com/rsoulliere/Evergreen_Documentation_Tools |
| 09:54 |
yboston |
I beleive these scripts are a little behind of what he uses right now, becuase I think he has to update the script to tell it the new release numbers |
| 09:55 |
yboston |
I have some other notes that he sent me a while ago that are missing from that repo (now that I am re-reading his notes) |
| 09:56 |
yboston |
Who should DIG collabrate with to set up a test docs build? |
| 10:00 |
yboston |
Dan I just sent you and remingtron a copy of the one email that Robert described a lot of his process |
| 10:03 |
dbs |
yboston: might make sense to put this out on the list, with some different possibilities (buildbot for basic builds; make targets for the docs in regular source; makefile.install target for doc build prereqs; a whole separate doc build server...)( |
| 10:03 |
dbs |
And see if anyone objects and/or is willing to tackle any of those pieces |
| 10:04 |
dbs |
yboston++ # thanks for forwarding |
| 11:45 |
bshum |
berick: In that case, with apache 2.4 in the mix, we may need to add some variant of e61a8085f9edabd97600b072c1a3ea41cd14265b for Jessie as well. |
| 11:45 |
pinesol_green |
[evergreen|Ben Shum] LP#1341013: Load apache mod CGI - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e61a808> |
| 11:46 |
gmcharlt |
bshum: note that the branch that eeevil pointed to is a no-op for the non-multiplex SIPServer (IOW, pushing it to EG now shouldn't break anything) |
| 11:47 |
eeevil |
bshum: They're transparent and (hopefully) non-controversial -- they don't change behavior, and they existed and been tested for nigh on a year. how would you like those pushed to your attention |
| 11:48 |
berick |
bshum: thanks for pointing that out. i wonder if that explains why apache segfaults for me on jessie ;) |
| 11:49 |
bshum |
eeevil: gmcharlt: Since it has both your sign-offs on it and has passed a week in wait, I'm fine with seeing it pushed to master on your review. I can do it after I send this email, but feel free to proceed as you need if nobody else steps up. |
| 11:50 |
bshum |
It looks fine to me. |
| 12:30 |
pinesol_green |
Launchpad bug 868653 in Evergreen "secondary permission groups (permission.usr_grp_map)" (affected: 3, heat: 20) [Wishlist,Triaged] |
| 12:31 |
bshum |
I was just reading it again and thinking to myself that if the feature is ready but the release note is pending, we could still move it in and add a note next week. |
| 12:31 |
bshum |
But that gets into slippery slope |
| 12:31 |
dbs |
bshum: yeah, testing + release note |
| 12:31 |
dbs |
that's what I was thinking |
| 12:34 |
jeff |
dbs++ |
| 12:34 |
bshum |
dbs++ |
| 12:55 |
bshum |
Interesting |
| 12:55 |
pinesol_green |
Launchpad bug 1292705 in Evergreen "IDL2js delivers lots of unneeded information, adding bulk." (affected: 1, heat: 6) [Wishlist,New] |
| 12:56 |
bshum |
What I'm doing right now is reading through stuff in 2.next that's marked "wishlist" and have pullrequest on them to see if they can be moved into review. |
| 12:56 |
bshum |
All the stuff already marked for beta1 that aren't fix committed look ready to review. |
| 12:59 |
berick |
bshum: thanks. the IDL2js stuff would be nice to have. |
| 13:00 |
berick |
i think it mostly just needs a few UIs from each general type (xul, old-school html, etc.) tested to ensure no breakage |
| 13:01 |
bshum |
Okay, I'll do some poking on one of my test servers later today. |
| 13:01 |
berick |
bshum++ |
| 13:04 |
dbs |
None of the junk is translation junk is it? (#alwaysparanoid) |
| 13:05 |
* jeff |
reads the "dangers of streaming across versions of glibc" thread on pgsql-general -- I like a good "why is this corrupt?" hunt. http://www.postgresql.org/message-id/BA6132ED-1F6B-4A0B-AC22-81278F5AB81E@tripadvisor.com |
| 13:06 |
berick |
dbs: IDL2js changes? no i18n "junk" removed |
| 13:21 |
remingtron |
berick: sorry, getting nowhere on the report features branch. System issues. |
| 13:22 |
berick |
remingtron: no worries. kmlussier is testing as well. may have another fix or two to push. |
| 13:22 |
berick |
i suggest testing elsewhere when yr system comes back |
| 13:22 |
berick |
at least for now |
| 13:23 |
|
vlewis joined #evergreen |
| 13:24 |
remingtron |
berick: when my system comes back? I'm not quite understanding. |
| 13:25 |
berick |
remingtron: i'm just refering your "system issues" comment. whenever that's resolved |
| 13:25 |
berick |
or did I misunderstand "system issues"? |
| 13:25 |
remingtron |
maybe, let me try again |
| 13:26 |
|
jihpringle joined #evergreen |
| 13:26 |
remingtron |
berick: my system is having strange issues, which has delayed my progress testing your bug |
| 13:27 |
remingtron |
berick: my main point is, I'll keep trying, but wanted to let you know not to count on my input |
| 13:27 |
berick |
gotcha, thanks. |
| 13:28 |
berick |
jfyi, i just pushed one fix and will probably push another soon |
| 13:29 |
remingtron |
berick: cool, thanks for update |
| 13:41 |
berick |
the same style is *cough* used elsewhere, though, w/ no sign of complaint that I see. |
| 13:41 |
berick |
maybe a different invocation |
| 13:42 |
pinesol_green |
[evergreen|Yamil Suarez] Docs: Improved AsciiDoc formating for tpac_meta_record_holds.txt - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=31dfcab> |
| 13:44 |
jeff |
jcamins: regarding xz and bzip2 from earlier: bzip2 -v9 compressed the file in 6m7.762s -- so, significant speed difference to save that additional space. |
| 13:45 |
jeff |
2.9G -> 700M in ~6 minutes or to 533M in ~1 hour. |
| 13:46 |
jeff |
of course, other things might have been happening at that time that might have skewed those numbers. not a scientific test, etc. |
| 13:47 |
* jeff |
times decompression |
| 13:49 |
jeff |
bzcat to /dev/null: 2m18.181s |
| 13:50 |
yboston |
Heads up, the DIG monthly meeting will start at 2 Pm EST |
| 13:52 |
|
RoganH joined #evergreen |
| 13:52 |
jcamins |
jeff: yeah, that matches my recollection. |
| 14:32 |
remingtron |
that's my message to the DIG email list |
| 14:33 |
yboston |
this could be a great way for DIG newcomers to help out, or at least get some practive |
| 14:33 |
yboston |
since you can just use a web browser, and not need to install software |
| 14:33 |
remingtron |
I agree! I'm looking for a volunteer to poke around Bill's test version of the web client and try editing a current doc to reflect the new web interface. |
| 14:34 |
remingtron |
https://bill-dev2.esilibrary.com/eg/staff/login?route_to=%2Feg%2Fstaff%2Fcirc%2Fpatron%2Fsearch |
| 14:34 |
yboston |
do we want to email folks on the general list to get them interested in helping? |
| 14:34 |
remingtron |
sure, I can do that |
| 14:34 |
yboston |
are there any folks right now watching this meeting that would like to help out? |
| 14:53 |
bshum |
Fwiw, this year, I voted towards making the Hack-A-Way after the expected release date for 2.7.0 so that we would avoid having developer interests affect 2.7's final outcome. |
| 14:53 |
bshum |
If you want docs ready for 2.7, then doing it earlier, like late August / early September seems like a better date range to me. |
| 14:53 |
remingtron |
+1 |
| 14:53 |
bshum |
Late August will give more time to stablize everything in 2.7 and get more test servers going for doc purposes too, I would assume. |
| 14:53 |
RoganH |
fwiw, as well, that was part of my goal for the scheduling the hack-a-way as well based on discussion at the conference |
| 14:54 |
|
Shae_ joined #evergreen |
| 14:54 |
kmlussier |
Sorry, it looks like I dropped out for a second. I prefer to keep dev and doc hack-a-ways separate. |
| 15:43 |
kmlussier |
berick: Is the latest reports code in your working branch? |
| 15:44 |
berick |
kmlussier: in the combined branch, yes |
| 15:44 |
berick |
user/berick/lp1332138-lp1329503-reports-combined |
| 15:46 |
remingtron |
berick: not sure if you spotted this bug yet |
| 15:46 |
remingtron |
Reload the page, edit any report, both "Run as soon as possible" and time selector checkboxes are checked |
| 15:46 |
remingtron |
after some usage, that problem goes away, but seems try on a fresh reload of that screen |
| 15:46 |
remingtron |
seems *true* |
| 15:47 |
remingtron |
that's all I've done for testing, now have to leave early. sorry can't sign off today. |
| 15:47 |
berick |
remingtron: hm, thanks, i'll look at that |
| 15:48 |
* remingtron |
heads out |
| 15:49 |
kmlussier |
berick: Yeah, I can confirm that behavior too. |
| 16:40 |
yboston |
apparebtly |
| 16:40 |
yboston |
*apparently |
| 16:54 |
kmlussier |
I can't recall how I've used those characters in the past. I use Notepad++ (when I'm not using VIM) and had to enable a setting to not add those character. I can't remember if I was able to delete them there. |
| 17:00 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:01 |
|
kmlussier left #evergreen |
| 17:03 |
bshum |
So as far as 2.7 beta freeze goes, I think anything that is signed off tonight will get committed later this evening or tomorrow morning. |
| 17:03 |
bshum |
I'll give at least till midnight for our west coast friends. ;) |
| 17:13 |
jeff |
closes with " If you still need special configuration then please reply to this email saying so and the ticket will automatically reopened. If you could form an orderly queue sorted by urgency it would be appreciated." |
| 17:14 |
|
mmorgan left #evergreen |
| 17:15 |
bshum |
dbs: If you have time tonight while you're playing with 264, yboston added six more RDA bibs to his branch on LP 1308768 |
| 17:15 |
pinesol_green |
Launchpad bug 1308768 in Evergreen "add sample RDA records to test data set" (affected: 1, heat: 6) [Wishlist,Confirmed] https://launchpad.net/bugs/1308768 |
| 17:16 |
bshum |
You did some magic on his first offering but my regular expression fu is weak :( |
| 17:16 |
bshum |
If you can convert those over and add them to also be loadable, I think it'd be great to push that all up to master so that the test dataset has good 264 sample data. |
| 17:18 |
bshum |
Oh you know, I just realized he has them as marcxml too |
| 17:18 |
* bshum |
will play with it if he gets more time later. |
| 17:18 |
bshum |
yboston++ |
| 17:20 |
bshum |
dbs: Actually looking at your marcxml I'm not sure the < and > are all in the right places. |
| 17:22 |
bshum |
<record>leader> ... etc. I think it's missing the leading < for much of the tagging. |
| 17:38 |
dbs |
bshum: my marcxml? |
| 17:39 |
dbs |
oh, http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=42578aef2117e917cccc67432cde855cc915c97e |
| 17:39 |
dbs |
yeah, that looks broken. |
| 17:48 |
yboston |
I am finally getting this stuff :) |
| 17:49 |
yboston |
my deadlien is to see if the PDF for 2.6 get built tonight, ebcuase it was not last night because of errors I hoped I fixed |
| 17:49 |
pinesol_green |
[evergreen|Yamil Suarez] Docs: various AsciiDoc formatting fixes for docs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=07e00d0> |
| 18:15 |
bshum |
dbs++ |
| 18:35 |
bshum |
tsbere: Tested https://bugs.launchpad.net/evergreen/+bug/1347805 using some of the sample contentcafe codes we talked about and I got errors trying to save stuff to memcache. |
| 18:35 |
pinesol_green |
Launchpad bug 1347805 in Evergreen "Content Cafe module should use an XML lookup method" (affected: 2, heat: 10) [Wishlist,Confirmed] |
| 18:35 |
bshum |
Could not store in memcache server repeated a bunch of times |
| 18:35 |
bshum |
And then the facets didn't show up, etc. |
| 18:36 |
bshum |
Marking as incomplete pending further tests |
| 18:43 |
pinesol_green |
[evergreen|Bill Erickson] LP#1351317 ACQ fund selector filters cont. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=71241c7> |
| 18:43 |
pinesol_green |
[evergreen|Thomas Berezansky] LP#1246745: Remove OK message from SIP2 messages - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=916c095> |
| 18:43 |
pinesol_green |
[evergreen|Thomas Berezansky] LP#1347793: Teach TPac to load AC by Bib ID - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=331983c> |
| 18:45 |
dbs |
bshum: per https://bugs.launchpad.net/evergreen/+bug/1304462/comments/24 RDA264 stuff just needs one signoff (on my fixed-up commit for the RDA record load) |
| 18:45 |
pinesol_green |
Launchpad bug 1304462 in Evergreen "Add 264 tag values to Record Summary" (affected: 3, heat: 20) [Wishlist,Confirmed] |
| 18:45 |
bshum |
dbs: Excellent! I'll try that out right after dinner. |
| 18:45 |
* dbs |
needs to scoot, might not be able to test the user group editor UI sadly |
| 18:46 |
dbs |
"arias for bass" is a good record to test with. Also a good argument for making the "added contributor entries" only show the first 3 or so with a little CSS "click to show 'em all" thingy |
| 18:46 |
bshum |
Cool, I'll look at that one. |
| 18:46 |
bshum |
Thanks dbs! Appreciate your looking at it. |
| 18:47 |
dbs |
I appreciate your many contributions to the branch and to the 2.7 release! |
| 20:37 |
bshum |
If you'd like to push it up, that'd be fine too. You hae kmlussier's signoff |
| 20:38 |
berick |
bshum: no, this is brand new |
| 20:38 |
berick |
no sign off |
| 20:38 |
bshum |
I was about to go test the TPAC view/edit copy links stuff |
| 20:38 |
bshum |
Ah, alright, let me know when to grab and where |
| 20:44 |
* bshum |
twiddles his thumbs waiting for staff clients to build. |
| 20:44 |
berick |
bshum: pushed to the tip of user/berick/lp1332138-lp1329503-reports-combined |
| 20:45 |
bshum |
berick: Cool, I'll grab that too when I put together the next test server build. |
| 20:45 |
berick |
bshum:++ |
| 20:45 |
berick |
er, bshum++ |
| 20:45 |
bshum |
berick++ |
| 20:46 |
eeevil |
there's a bit in there |
| 21:50 |
* jeff |
gets home and looks in |
| 21:50 |
jeff |
good evening. |
| 21:50 |
bshum |
About to push a bunch more things through |
| 21:50 |
bshum |
My internet is slowly dying it seems |
| 21:50 |
bshum |
But my test server lives! |
| 21:51 |
* bshum |
waves at jeff |
| 21:54 |
pinesol_green |
Showing latest 5 of 16 commits to Evergreen... |
| 21:54 |
pinesol_green |
[evergreen|Bill Erickson] LP#1329503 report editing additional repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8ad52e5> |
| 21:54 |
pinesol_green |
[evergreen|Bill Erickson] LP#1329503 propagate 'in list' values for editing - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2f2859c> |
| 22:08 |
bshum |
Could make a good early candidate for 2.8 cycle |
| 22:08 |
bshum |
Something to work on during the hackaway |
| 22:31 |
* dbs |
starts to dig into user/group ui |
| 22:31 |
bshum |
dbs: I pushed it by accident, sort of |
| 22:31 |
bshum |
dbs: It got stuck at the tail end of a big branch I was testing on a test server |
| 22:32 |
bshum |
But I didn't realize that there may have been an issue with it. |
| 22:32 |
bshum |
I'm getting an error when trying to access the patron editor |
| 22:32 |
bshum |
TypeError: patron.isnew is not a function |
| 22:32 |
bshum |
Comes up different places |
| 22:32 |
bshum |
But basically it stalls out the editor |
| 22:32 |
bshum |
I was about to try undoing or fixing it |
| 22:32 |
bshum |
But my internet is being uncooperative with me. |
| 22:33 |
* dbs |
will dig |
| 22:37 |
dbs |
huh. lots of uses of patron.isnew() before jeffdavis' last commit |
| 22:37 |
bshum |
Yeah it's not related |
| 22:39 |
bshum |
No, that was delayed |
| 22:39 |
* dbs |
goes back to focusing on Dojo 1.3 |
| 22:40 |
jeff |
if you're getting patron.isnew() failures, you probably don't have a valid patron object. |
| 22:41 |
* bshum |
supposes the quick way to know for sure it was the secondary perm group is to revert it and go back a step on his test server. |
| 22:41 |
* dbs |
still needs to get his test server running latest EG master to reproduce said error... working on it |
| 22:44 |
dbs |
bshum: did you run the ever-popular autogen? :) |
| 22:45 |
bshum |
dbs: Yes I did. |
| 22:46 |
bshum |
But I'll try it again right after I open up my client to test reverting it |
| 22:47 |
bshum |
If my internet cooperates... |
| 22:47 |
bshum |
Hmm, interesting |
| 22:48 |
bshum |
revert did nothing |
| 22:49 |
bshum |
I think it was the IDL2JS thing now. |
| 22:49 |
* bshum |
pokes at that next. |
| 22:55 |
bshum |
Yep |
| 22:55 |
bshum |
reverting the IDL2JS changes fixes it |
| 22:55 |
dbs |
bshum: yeah, I suspect so too. Because that patron.isnew(1) line immediately follows "patron = new au();" |
| 22:55 |
dbs |
aha |
| 22:56 |
bshum |
http://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/xsl/fm_IDL2js.xsl;h=ecc374fad54c1dcd0d0884cde1068d88af143e53;hp=1a857bf1bae13246710a78e88fb39593aec51f19;hb=4f1074aec9e57b0df2cfd6b371e2517929cda090;hpb=5f0433a9c68164377c262f65ed67a7a538b28585 |
| 22:58 |
bshum |
:D |
| 22:58 |
dbs |
wild and crazy thought was that maybe "patron = new au();" now needs to be "patron = new fieldmapper.au();" |
| 22:58 |
bshum |
Hmm |
| 22:58 |
* dbs |
goes to test |
| 22:59 |
dbs |
nope, patron.isnew(1) still fails. |
| 23:02 |
dbs |
wow I hate the million-character-long lines in fm_IDL2js.xsl, they make it really hard to see the changes in the diff :( |
| 23:02 |
bshum |
They are a bit rough. |
| 23:15 |
dbs |
oh hey, p no longer gets incremented. |
| 23:17 |
dbs |
BINGO. |
| 23:23 |
dbs |
tacked a branch onto https://bugs.launchpad.net/evergreen/+bug/1292705/comments/4 |
| 23:23 |
pinesol_green |
Launchpad bug 1292705 in Evergreen "IDL2js delivers lots of unneeded information, adding bulk." (affected: 1, heat: 6) [Wishlist,Fix committed] |
| 23:27 |
dbs |
jeffdavis++ # Nice, simple UI. Sweet. |
| 23:27 |
* bshum |
tests |
| 23:28 |
bshum |
It lives! |
| 23:28 |
dbs |
And I got to add a set of braces to a for loop, which always makes me happy :) |
| 23:29 |
dbs |
No more evergreen hacking for me tonight. bshum++ |
| 23:29 |
bshum |
I think this is a good place to rest. |
| 03:55 |
|
remingtron_ joined #evergreen |
| 04:53 |
|
pastebot0 joined #evergreen |
| 04:53 |
|
ningalls joined #evergreen |
| 05:03 |
pinesol_green |
Incoming from qatests: Test Failure - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 06:42 |
|
ningalls joined #evergreen |
| 07:41 |
|
Callender joined #evergreen |
| 07:41 |
|
eeevil joined #evergreen |
| 08:44 |
|
mmorgan joined #evergreen |
| 08:47 |
|
mrpeters left #evergreen |
| 09:22 |
|
krvmga joined #evergreen |
| 09:23 |
krvmga |
a patron sent me a note that she couldn't see the dropdown for placing a hold in My Lists when she was on her mobile. |
| 09:24 |
krvmga |
this seems to be the case on our server as well. |
| 09:24 |
krvmga |
is this just a spot that the responsive catalog design didn't get to? |
| 09:28 |
krvmga |
i've tested this on a vanilla version of 2.5 and it seems to be the case. |
| 09:30 |
Dyrcona |
krvmga: It seems bug worthy to me. I haven't really tried using the catalog much from my phone. |
| 09:30 |
pinesol_green |
[evergreen|Jason Stephenson] Fix 030.schema.metabib.sql breakage. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b0c4299> |
| 09:34 |
|
yboston joined #evergreen |
| 09:35 |
Dyrcona |
tsbere++ # for testing and pushing |
| 09:47 |
jeff |
Dyrcona++ tsbere++ |
| 09:48 |
Dyrcona |
You should thank tsbere. He noticed the break and I didn't, 'cause he tried to build a fresh database yesterday. |
| 09:48 |
krvmga |
https://bugs.launchpad.net/evergreen/+bug/1353509 |
| 09:48 |
pinesol_green |
Launchpad bug 1353509 in Evergreen "responsive catalog design fail in my lists" (affected: 1, heat: 6) [Undecided,New] |
| 09:48 |
Dyrcona |
I'll have to test these things with a fresh database, too, from now on. |
| 09:49 |
Dyrcona |
The automated build bot caught it, too. |
| 09:51 |
dbs |
krvmga: please include your specific mobile device and mobile browser in the bug report, just in case it's limited to a specific combination |
| 09:52 |
dbs |
And a bug report title of "Unable to place hold in My Lists from a mobile device" would be both a more useful description and less negative than "responsive catalog design fail" |
| 09:54 |
dbs |
Maybe it's the case that it's just a limitation of the hover vs. touch event model on mobile devices, and not due to the responsive catalog design, in which case you might have insulted those who worked on the responsive design for no good reason... |
| 10:06 |
krvmga |
dbs: the condition can be tested in a web browser by resizing the browser to the mobile device size you'd like |
| 10:09 |
krvmga |
dbs: i changed the title as you suggested and added the reported device and os as well as the browser info |
| 10:09 |
krvmga |
https://bugs.launchpad.net/evergreen/+bug/1353509 |
| 10:09 |
pinesol_green |
Launchpad bug 1353509 in Evergreen "Unable to place holds in My Lists from mobile device" (affected: 1, heat: 8) [Undecided,New] |
| 10:18 |
bshum |
krvmga: Well I think I agree with dbs that any specific information about how the bug was originally discovered can be helpful information to others who test the issues noted in bugs. |
| 10:18 |
krvmga |
bshum: i added it. |
| 10:30 |
krvmga |
in eg 2.6, openils/var/opac/parts/base.tt2, semiauto.css and style.css are linked. are these links obsolete? |
| 10:32 |
bshum |
krvmga: I think I see the issue for mobile view of my lists. |
| 11:07 |
dbs |
Hey Dyrcona, re: #1304462 I signed off on your commit but haven't pushed anything, so ysuarez probably shouldn't add the release note to the docs until the commits get pushed :) |
| 11:08 |
dbs |
bug 1304462 that is (zoia) |
| 11:08 |
pinesol_green |
Launchpad bug 1304462 in Evergreen "Add 264 tag values to Record Summary" (affected: 3, heat: 20) [Wishlist,In progress] https://launchpad.net/bugs/1304462 - Assigned to Ben Shum (bshum) |
| 11:09 |
csharp |
krvmga: (late to conversation, but) I would add to what bshum and Dyrcona said that it helps to run the master branch on a test machine and assist with testing bugfixes and new features |
| 11:09 |
yboston |
dbs: thaks for the heads up. Would it help if I did a collab branch and cherry picked Dyrcona's commit and add the release notes there? |
| 11:09 |
csharp |
that way it's not just a matter of hearing about features, but actually using them in their raw state |
| 11:10 |
dbs |
yboston: well of course I would like my commit to be signed off too :) |
| 11:12 |
csharp |
bshum: or taste the soup before it's served ;-) |
| 11:12 |
bshum |
csharp: Ahh, I like that one better :) |
| 11:12 |
krvmga |
csharp: i like that one, too :) |
| 11:14 |
yboston |
dbs: I forgot about the schema.org changes. I probably won't have time to test the schema.org changes in a test VM this week, I can wait for soemone else to sign off on those changes |
| 11:14 |
yboston |
before making the collab branch |
| 11:14 |
yboston |
or I can just wait until both sets of changes are pulled in |
| 11:15 |
csharp |
oh btw, I volunteered last week to test web sockets - unfortunately, I got bogged down trying to get that running (mostly confusion about apache vs apache-websockets and whether both should be running and whether there needs to be separate config? etc.) |
| 11:24 |
bshum |
@later tell jeffdavis Not sure if you had more work on https://bugs.launchpad.net/evergreen/+bug/1046420 to do (the bug comments lead me to believe there is some more to be done), let us know later. |
| 11:24 |
pinesol_green |
bshum: The operation succeeded. |
| 11:24 |
pinesol_green |
Launchpad bug 1046420 in Evergreen "Wishlist: Cut off due dates so they don't extend past card expiration date" (affected: 3, heat: 26) [Wishlist,Triaged] |
| 12:00 |
|
mllewellyn joined #evergreen |
| 14:06 |
|
collum joined #evergreen |
| 14:25 |
pinesol_green |
[evergreen|Bill Erickson] LP#1319519 Add to PO limits to new/pending PO's - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=101d652> |
| 14:34 |
bshum |
dbs: Dyrcona: yboston: I finally found my old branch that I put together to switch out the publisher, etc. for 264 display in search results branch. |
| 14:34 |
bshum |
Would it make sense for me to start a collab branch with everything in it? |
| 14:35 |
bshum |
I'll start by pulling Dyrcona and dbs stuff and signing off on them |
| 14:35 |
bshum |
And then add in my commits and yboston's notes |
| 14:35 |
bshum |
If it looks good, we can push the whole thing on up |
| 14:35 |
* bshum |
tests |
| 14:39 |
|
hbrennan joined #evergreen |
| 14:42 |
dbs |
bshum++ |
| 14:42 |
* dbs |
will need to look at bug 1046420 too |
| 14:51 |
hbrennan |
(Holly strikes again by grossly simplifying the process and enraging the brilliant dev minds!) |
| 14:52 |
bshum |
dbs: yboston: Dyrcona: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/bshum/lp1304462_rda_264 |
| 14:52 |
yboston |
I have a git workflow question, I am preparing some documentation commits from a DIG member to inlude in master & 2.6 |
| 14:53 |
bshum |
That's the collab I started rolling with. I have to test it again on a server to make sure my commits don't break anything new. |
| 14:53 |
bshum |
It's been awhile. |
| 14:53 |
csharp |
in a FIFO setup, that sounds reasonable, but in the "default" setup that was built for contant transits across systems, no that wouldn't work |
| 14:53 |
csharp |
s/contant/constant/ |
| 14:54 |
hbrennan |
csharp: Sounds like it would be something we'd have to take on ourselves. Thanks! |
| 15:26 |
pinesol_green |
[evergreen|Bill Erickson] LP#1279998 marc_stream_importer option no-match import; delete repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d0399c9> |
| 15:26 |
pinesol_green |
[evergreen|Bill Erickson] LP#1279998 marc stream importer release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aa3bed5> |
| 15:28 |
Dyrcona |
On the commit thing: I've done it a couple of times with patches to give the patch author credit, not me. |
| 15:38 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: MARC Record Attribute Definitions, Multi Valued Fields, Composite Record Attributes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1f8b86d> |
| 16:00 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: How to perform metarecord search and hold - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ae82e4d> |
| 16:00 |
|
vlewis joined #evergreen |
| 16:04 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: How to use MARC Fixed Field Editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c901231> |
| 16:12 |
pinesol_green |
[evergreen|Erica Rohlfs] Docs: How to create routing list and shows address on routing list - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b69c63b> |
| 16:46 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 16:46 |
phasefx |
yay |
| 17:15 |
|
mmorgan left #evergreen |
| 17:19 |
|
kmlussier left #evergreen |
| 17:23 |
remingtron |
berick: FYI, I plan to test bug 1329503 tomorrow morning |
| 17:23 |
pinesol_green |
Launchpad bug 1329503 in Evergreen "View / Edit Existing Reports" (affected: 5, heat: 30) [Wishlist,New] https://launchpad.net/bugs/1329503 |
| 17:24 |
remingtron |
unless you have enough eyes on that already, then I'll test something else |
| 17:25 |
berick |
remingtron++ # that would be much appreciated |
| 17:25 |
remingtron |
great, will do |
| 17:25 |
berick |
beware it relies on another LP / branch mentioned in the ticket |
| 02:46 |
|
mtcarlson joined #evergreen |
| 04:58 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 05:42 |
|
berick_ joined #evergreen |
| 05:44 |
|
jeffdavi1 joined #evergreen |
| 05:44 |
|
jcamins_ joined #evergreen |
| 14:47 |
bshum |
Generally I don't agree to support anything less than 1024x768 in my consortium. But that's just our practices here. |
| 14:48 |
jeff |
"responsive XUL" isn't really a thing. |
| 14:49 |
Dyrcona |
It's not really usable at less than 1920x1080, cause some wider screens don't get horizontal scroll bars when they should. |
| 14:49 |
csharp |
trying to install/test the web client, but it looks like I'm missing something |
| 14:49 |
bshum |
@quote add <jeff> "responsive XUL" isn't really a thing. |
| 14:49 |
pinesol_green |
bshum: The operation succeeded. Quote #87 added. |
| 14:49 |
Dyrcona |
I'm looking at you Item Status. |
| 14:53 |
Dyrcona |
csharp: It's often a lack of eyesight, not funds. |
| 14:53 |
bshum |
kmlussier: I think idle starting footprint for the Evergreen client is more like 900 MB or so |
| 14:53 |
Dyrcona |
At 800x600 on a larger monitor stuff looks bigger. |
| 14:53 |
bshum |
I'd have to refer back to all the testing notes that was done during the memory leak. |
| 14:53 |
csharp |
whew - that's bad |
| 14:53 |
kmlussier |
But we also have options for increasing font size. |
| 14:54 |
csharp |
it's a bad workaround |
| 15:31 |
kmlussier |
I don't know. tspindler said he got rid of all of his unnecessary stat cats, but it didn't make a huge difference. |
| 15:31 |
csharp |
that seemed to be the factor when krmvga and I were comparing a couple weeks back |
| 15:31 |
csharp |
it loads fine for us, but we barely use patron stat cats |
| 15:33 |
eeevil |
kmlussier: another thing to remember is that, while anecdotal, /everything/ seems to run faster (dojo included) in chrome than in xulrunner, because of the different js engine. again, anecdotal, but something that folks should also look into testing |
| 15:33 |
berick |
eeevil: good point |
| 15:33 |
csharp |
yeah - we tested chrome and firefox |
| 15:33 |
tsbere |
I think another issue was number of permission groups that the permission to edit had to be checked for |
| 15:33 |
csharp |
both were *way* faster, especially chrome |
| 15:34 |
|
tspindler joined #evergreen |
| 15:40 |
jeff |
heh |
| 15:40 |
jeff |
old habit |
| 15:40 |
tsbere |
berick: That is the workflow of the javascript in register.js file. As in client-side. |
| 15:40 |
berick |
kmlussier: and that's different data, too, so not a wholly accurate test. |
| 15:41 |
berick |
tsbere: gotcha. do you think that API call takes too long or processing the results? |
| 15:42 |
kmlussier |
berick: Sure, not that the code is in LP, I think we'll look at loading it with some production data. But it still won't be the same data, so it may not be the best test either. |
| 15:42 |
kmlussier |
That is, now that the code is in LP. |
| 15:42 |
tsbere |
berick: Unless the has_work_perm_at.batch function filters dupes I imagine we are getting a backend dance for each permission group with a perm attached, instead of for each permission (I haven't checked the actor code to see though). Other than that massive playing with the tree of permissions may slow down things when there are a lot of them. |
| 15:43 |
phasefx |
semi-related aside, the xul side of things used to share data with the patron editor to save some network requests, but I don't think that is any longer the case |
| 15:43 |
berick |
kmlussier: another test.. you can go to .. https://YOUR-DOMAIN/eg/actor/user/register |
| 15:44 |
berick |
tsbere: gotcha, yeah, not sure about the api |
| 15:44 |
tsbere |
berick: Actually, now having looked at Actor.pm, it doesn't look like it filters dupes. So if you have 50 groups that use the same permission I think we verify that permission 50 times, instead of just once. Not sure which end we should be filtering it on, though. |
| 15:44 |
|
Shae joined #evergreen |
| 15:44 |
* tsbere |
suspects the backend is a good place though |
| 16:33 |
berick |
s/the/they/ |
| 16:33 |
berick |
they flow on my phone OK, but this freakin' nexus is 1280x768 |
| 16:38 |
eeevil |
fwiw, the overlap there is not dojo's fault, it's simply suboptimal layout |
| 16:38 |
kmlussier |
Sorry, I just walked away to test on my son's phone. It's overlapping there. The phone is a few years old, but it's there. |
| 16:39 |
kmlussier |
berick: No, I haven't looked at much at that level. I try to stay away from 800x600 when I can. :) |
| 16:39 |
berick |
eeevil: yeah, dojo is def. not to blame for a lot of stuff we're throwing around. at this point, I think "dojo" really just means "those interfaces" |
| 16:39 |
berick |
kmlussier: i hear ya |
| 16:41 |
eeevil |
berick: I understand. I want to make sure it's clear that making the pages flow better is not necessarily dependent upon completely replacing them with alternate implementations. and could be done by anyone, not just you, without harming the browser-client target, as long things like element ids and classes don't get blown away |
| 16:42 |
eeevil |
(more or less) |
| 16:42 |
berick |
eeevil: absolutely. that's good to reiterate |
| 16:42 |
|
tspindler left #evergreen |
| 16:43 |
eeevil |
if someone feels like removing floats and tables and moving the /containers/ to divs and whatnot, that should not have an impact on the logic (ideally ... testing would tell, obv) |
| 16:48 |
kmlussier |
eeevil: Sure, I understand that. I was just trying to make the point that it might not be a bad idea to keep that specific bug open. |
| 16:49 |
kmlussier |
If anyone's interested, this is what the patron registration screen looked like on my son's phone. http://www.screencast.com/t/GaEAqcYw |
| 16:49 |
eeevil |
kmlussier: I agree with keeping it open |
