02:41 |
|
fsamareanu10 joined #evergreen |
04:26 |
|
obserd joined #evergreen |
06:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:03 |
|
agoben joined #evergreen |
07:26 |
|
rjackson_isl joined #evergreen |
07:35 |
|
bdljohn joined #evergreen |
09:05 |
* csharp |
starts looking for signed off bugfixes himself |
09:06 |
* Dyrcona |
was thinking of doing that very thing before you mentioned the cutoff. |
09:08 |
|
lsach joined #evergreen |
09:10 |
csharp |
hmm - I'm interested in getting berick's fix for bug 1774448 in, but I have no idea how to test it without just throwing it into production :-/ |
09:10 |
pinesol |
Launchpad bug 1774448 in Evergreen 3.0 "web staff client can spam open-ils.auth.session.retrieve requests" [Undecided,Confirmed] https://launchpad.net/bugs/1774448 |
09:12 |
JBoyer |
speaking of testing things, bug 1733590 just got a fresh branch. (people have Strong Feelings about only printing what they've selected from Items Out) |
09:12 |
pinesol |
Launchpad bug 1733590 in Evergreen "Web Client: Print Item Receipt not selective" [Medium,Confirmed] https://launchpad.net/bugs/1733590 |
09:13 |
* Dyrcona |
tests Lp 1743801 |
09:13 |
pinesol |
Launchpad bug 1743801 in Evergreen 3.0 "web client: item status list view display issues" [High,Confirmed] https://launchpad.net/bugs/1743801 - Assigned to Jason Stephenson (jstephenson) |
09:13 |
csharp |
JBoyer: oooh - I'll see if we have time to test it today |
09:15 |
JBoyer |
csharp, and I think for the one you're looking at, I think it can be tested by setting an absurd value for the login timeout pre-patch, watch the browser just flood your system with session retrieve calls, and then apply the patch and see if the number drops to a reasonable level. (and that you can still do things, etc. |
09:15 |
JBoyer |
I'll try to poke at that one. |
09:16 |
Dyrcona |
JBoyer: By "absurd value" you mean an absurdly low value, right? |
09:16 |
Dyrcona |
Like 5 seconds or something dumb like that? |
09:18 |
JBoyer |
Actually I think it would be best to test it 2 ways, something like 500ms and then (32 bit) INT_MAX + 500. Those should both call it excessively, and post-patch both should be set to the new minimum of 60000ms |
09:18 |
Dyrcona |
A'ight..... |
09:18 |
JBoyer |
I don't know who is just typing 20 digit numbers into the LSE for their auth timeouts, but it sounds like it must have happened at least once. |
09:19 |
Dyrcona |
Well, if time permits, I can give that one a whirl unless someone else beats me to it. |
09:37 |
csharp |
bug 1772053, even |
09:37 |
pinesol |
Launchpad bug 1772053 in Evergreen 3.0 "Web Client: Print Templates - Missing/Problem Fields" [Undecided,Confirmed] https://launchpad.net/bugs/1772053 |
09:37 |
csharp |
librarians like grouping things together, I get it, but that bug will likely be open for years :-/ |
09:38 |
JBoyer |
Ah, I misunderstood the point of the 32 bit overflow. A better test would be to set it to , 4500ms short of the overflow at 2,147,483,647 so it's valid for about 25 days but session retrieve is called every half-second. (The minimum if you choose a small value is 5 seconds + the small value.) |
09:38 |
* Dyrcona |
doesn't like "omnibus" bugs/branches much either. |
09:38 |
csharp |
Dyrcona: same |
09:39 |
Dyrcona |
So, on Lp 1743801, I'm not actually seeing the problem. |
09:39 |
JBoyer |
2147479147ms, that is. |
09:39 |
pinesol |
Launchpad bug 1743801 in Evergreen 3.0 "web client: item status list view display issues" [High,Confirmed] https://launchpad.net/bugs/1743801 - Assigned to Jason Stephenson (jstephenson) |
09:39 |
Dyrcona |
Loan Durations and Fine Level already show up as words in my item status display on a test VM with 3.0 installed. |
09:39 |
JBoyer |
I had a hard time following what the remaining issue with that one was also. (aside from the t/f - y/n that was explicitly called out) |
09:40 |
JBoyer |
And I know fine level and circ duration should have been fixed at some point because I remember doing it. (One of those angular str-to-int things) |
09:40 |
|
jvwoolf joined #evergreen |
10:00 |
csharp |
aabbee: bug 1788417 |
10:00 |
pinesol |
Launchpad bug 1788417 in Evergreen "Web client: Boolean fields say "true"/"false" when XUL client used "Yes"/"No"" [Undecided,New] https://launchpad.net/bugs/1788417 |
10:06 |
Dyrcona |
Hm... Fine level isn't working for me. Maybe I broke it with the conflict resolution? |
10:12 |
berick |
csharp: I'll add a test note for bug 1774448 |
10:12 |
pinesol |
Launchpad bug 1774448 in Evergreen 3.0 "web staff client can spam open-ils.auth.session.retrieve requests" [Undecided,Confirmed] https://launchpad.net/bugs/1774448 |
10:12 |
Dyrcona |
Weird.... |
10:13 |
aabbee |
1788417: dunzo. |
10:15 |
csharp |
aabbee++ #will test |
10:16 |
aabbee |
csharp: i hope it works. instead of testing it myself, i discovered some ssl errors on my testing VM and got distracted. lemme know! :-) |
10:16 |
csharp |
also, I can confirm that https://bugs.launchpad.net/evergreen/+bug/1743801/comments/15 is because the fix was not applied correctly to the servers - my bad |
10:16 |
pinesol |
Launchpad bug 1743801 in Evergreen 3.0 "web client: item status list view display issues" [High,Confirmed] - Assigned to Jason Stephenson (jstephenson) |
10:17 |
csharp |
we're testing multiple branches on that server - probably overwrote it at some point |
10:22 |
Dyrcona |
I don't even understand that comment, tbh. |
10:22 |
JBoyer |
csharp++ # Bug 1788417; Readability is important, t/f? |
10:22 |
pinesol |
Launchpad bug 1788417 in Evergreen "Web client: Boolean fields say "true"/"false" when XUL client used "Yes"/"No"" [Undecided,New] https://launchpad.net/bugs/1788417 |
10:26 |
aabbee |
Dyrcona: weird. fine level and loan duration were fixed in the same commit (not just the same branch). does age protect show up correctly? |
10:27 |
|
bos20k_ joined #evergreen |
10:28 |
Dyrcona |
One thing I've noticed is there are two </eg-grid> at the bottom of the file. |
10:28 |
csharp |
aabbee: I see it working on my test |
10:28 |
aabbee |
csharp++ \o/ whoo! |
10:35 |
Dyrcona |
Now, it's working. |
10:37 |
JBoyer |
berick++ # Clarification |
10:37 |
JBoyer |
I have *definitely* verified that the spamming is for real. Just now applying the patch to verify it's out. |
10:40 |
|
khuckins joined #evergreen |
10:42 |
* JBoyer |
would have better luck testing if he applied the correct branch. :-/ |
10:42 |
Dyrcona |
:P |
10:51 |
csharp |
yeah, looks like we need the fixes from bug 1738249 applied to see the list stuff completely fixed (another omnibus fix) |
10:51 |
pinesol |
Launchpad bug 1738249 in Evergreen 3.0 "Circulation Library in Item Status" [Low,Fix released] https://launchpad.net/bugs/1738249 |
10:52 |
csharp |
my "lock into a release and cherry-pick selected fixes" approach is pretty painful ATM |
10:53 |
Dyrcona |
csharp: Do you want help with the cherry-picks? |
10:53 |
* Dyrcona |
is in the process of picking another branch with conflicts, ATM. |
10:54 |
csharp |
nah, it's okay - honestly it's really just trying to test too many fixes on the same server at once |
10:56 |
Dyrcona |
OK. I'm 'bout to push the branch I tested this morning. |
10:56 |
csharp |
Dyrcona++ |
10:59 |
|
Christineb joined #evergreen |
11:01 |
pinesol |
[evergreen|a. bellenir] LP#1743801: Item Status List View Display Issues - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3710c28> |
11:01 |
pinesol |
[evergreen|a. bellenir] LP#1743801: Item Status List Display Issues - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a1cbed7> |
11:01 |
csharp |
aabbee++ |
11:10 |
csharp |
aabbee: I've applied the t/f y/n fix to my test server and it's displaying " |
11:10 |
csharp |
{{itemFieldValue(item, col) | egGridValueFilter:col:item}}" |
11:11 |
pinesol |
[evergreen|Bill Erickson] LP#1724029 Patron search API returns correct order - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6e32bb5> |
11:11 |
csharp |
not sure whether that's a "me" problem or a code problem |
11:11 |
csharp |
I've verified that both files are changed ok |
11:27 |
pinesol |
Launchpad bug 1684970 in OpenSRF "Proxy setup masks client IP needed by osrf-http-translator" [Medium,Confirmed] https://launchpad.net/bugs/1684970 |
11:27 |
Dyrcona |
Hm. Nope, no conflict. |
11:28 |
aabbee |
i'mma just nuke the branch and try again (including *all* of the patch this time.) |
11:28 |
Dyrcona |
I'll push to a collab branch and test it since I tried the rebase, myself. |
11:29 |
|
rlefaive joined #evergreen |
11:30 |
Dyrcona |
aabbee: It would be well worth the practice to try it again, just the same. |
11:32 |
JBoyer |
bug 1774448 : the tin accurately describes the functioning of its contents. |
11:34 |
Dyrcona |
And, I busted my backport to my local 3.0 branch. :) |
11:39 |
aabbee |
branch is fixed. (recreated.) i think i got it right this time. |
11:42 |
Dyrcona |
aabbee++ |
11:42 |
Dyrcona |
I've tested it and it works for me. I'm going to push a signoff branch in case csharp still wants to look at it. |
11:43 |
Dyrcona |
I'm going to make a separate branch for rel_3_0 becasue there is a conflict there. |
11:43 |
aabbee |
Dyrcona++ csharp++ berick++ # \o/ |
11:44 |
|
bos20k joined #evergreen |
13:47 |
jeff_ |
print it out and keep it with you at all times. you may be challenged at any time to present it. |
13:47 |
Dyrcona |
heh. |
13:48 |
* csharp |
prints wallet-sized copy |
14:21 |
JBoyer |
If anyone has time for another easy UI test, bug 1735816 has been updated to address some UI feedback and looks ready to go. :) |
14:21 |
pinesol |
Launchpad bug 1735816 in Evergreen "Cannot Delete Existing Copy Notes" [Medium,Confirmed] https://launchpad.net/bugs/1735816 |
14:32 |
* csharp |
volunterrs |
14:33 |
csharp |
er.. volunteers |
14:36 |
csharp |
berick: done that many many times |
14:43 |
jeffdavis |
I would like bug 1715767 to get into 3.2. It's on the roadmap and targeted for the beta release, is there anything else I should be doing? |
14:43 |
pinesol |
Launchpad bug 1715767 in Evergreen "Allow others to use my account (privacy waiver)" [Wishlist,New] https://launchpad.net/bugs/1715767 |
14:44 |
csharp |
ooh ooh - that looks cool |
14:44 |
* csharp |
is in the middle of 50 things today, but I'll help test |
14:45 |
Dyrcona |
But, it's past the deadline.... :) |
14:46 |
Dyrcona |
Oh, wait, never mind. |
14:46 |
* csharp |
forgets when the deadline is |
14:53 |
csharp |
(bug 1735816) |
14:53 |
pinesol |
Launchpad bug 1735816 in Evergreen "Cannot Delete Existing Copy Notes" [Medium,Confirmed] https://launchpad.net/bugs/1735816 |
14:53 |
Dyrcona |
berick: Experience a tremor? |
14:54 |
csharp |
JBoyer: this was on PINES 3.0.2-ish test server, FYI |
14:54 |
JBoyer |
You're going to need to Clear Cache and Hard Reload, because that's what it does pre-patch. |
14:54 |
csharp |
ah - ok |
14:55 |
Dyrcona |
@band add Clear Cache and Hard Reload |
16:49 |
kmlussier |
@sortinghat |
16:49 |
pinesol |
Hmm... kmlussier... Let me see now... GRYFFINDOR! |
16:59 |
csharp |
@librarian |
16:59 |
pinesol |
csharp: Management:5, Cataloging:13, Acquisitions:11, Reference:18, Circulation:11, Systems:15, Research:13, Custodial:9 |
17:02 |
|
jvwoolf left #evergreen |
17:02 |
pinesol |
[evergreen|Jane Sandberg] Docs: finalizing 3.0.11 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b2f630a> |
17:02 |
pinesol |
[evergreen|Jane Sandberg] Docs: finalizing 3.1.5 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f051ccd> |
17:07 |
|
mmorgan left #evergreen |
17:22 |
|
justanotheruser2 joined #evergreen |
17:22 |
|
beanjammin joined #evergreen |
18:01 |
|
Pidgeotto joined #evergreen |
18:21 |
|
Dyrcona joined #evergreen |
18:23 |
|
asjoyner left #evergreen |
18:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
19:49 |
|
alphor23 joined #evergreen |
19:56 |
|
f13 joined #evergreen |
20:10 |
|
ManyRaptors joined #evergreen |
02:26 |
|
JBoyer_alt joined #evergreen |
02:26 |
|
remingtron_ joined #evergreen |
04:43 |
|
ReimuHakurei11 joined #evergreen |
06:30 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:07 |
|
rjackson_isl joined #evergreen |
07:10 |
|
JBoyer joined #evergreen |
07:24 |
|
armyriad24 joined #evergreen |
11:53 |
Dyrcona |
I see. |
11:55 |
dbs |
It might scale to 5 or 10 or 50 bricks, I dunno. I was more looking at it as an easier way of people getting up and running with Evergreen, as it separates out PostgreSQL & ejabberd into their own containers (potentially with different OS levels where beneficial say in the case of ejabberd), etc |
11:55 |
|
beanjammin joined #evergreen |
11:58 |
Dyrcona |
Yes. I can see it might be useful for testing/development, maybe less so for production. |
12:12 |
|
sandbergja joined #evergreen |
12:24 |
|
Redfoxmoon9 joined #evergreen |
12:33 |
|
jvwoolf joined #evergreen |
14:25 |
* jeff |
sighs and picks up an extra slash from the pile |
14:27 |
DaleZeut_ |
If I shutdown nginx I can see the site - with nginx running I get the Bad Gateway error and nginx log shows - connect() failed (111: Connection refused) while connecting to upstream, client: 127.0.0.1, server: , request: "GET /eg/opac/home HTTP/1.1", upstream: "https://127.0.0.1:7443/eg/opac/home", host: "ilsserver" |
14:32 |
jeff |
DaleZeut_: Your nginx error log entry implies that you have nginx set to connect to Apache (the non-websockets instance) on port 7443, listening on localhost/127.0.0.1. Is Apache configured that way? |
14:39 |
csharp |
DaleZeut_: example from a test server I administer: https://pastebin.com/QqkZitMD - set in eg.conf |
14:42 |
|
rashma_away joined #evergreen |
14:58 |
DaleZeut_ |
I have changed the apache conf and port file and now appear to be working. Bless you all who have helped me fumble finger my to this point. Thank you all |
15:01 |
jeff |
DaleZeut_: congratulations! you're welcome! |
17:33 |
sandbergja |
jeff: I agree that a stock event wouldn't really make much sense. |
17:34 |
sandbergja |
Thanks for grabbing the bug! |
17:52 |
sandbergja |
One more question: is there any way to create a copy alert type that shows for *all* states? It's pretty frustrating to have to forecast every single state an item will ever be in and add an alert for each of them |
18:30 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
18:43 |
|
DaleZeut joined #evergreen |
18:50 |
|
adam_montgomery joined #evergreen |
18:54 |
DaleZeut |
Back again - Thanks in advance - When I goto Admin → Local Administration → Library Settings Editor - I am getting Source map error: request failed with status 404 Resource URL: https://ilsserver.school.ffcs.org/upup.min.js Source Map URL: upup.min.js.map |
03:10 |
|
dpearl joined #evergreen |
04:24 |
|
matthiaskrgr27 joined #evergreen |
04:40 |
|
Xenthys0 joined #evergreen |
06:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:01 |
|
trqx10 joined #evergreen |
07:04 |
|
agoben joined #evergreen |
07:06 |
|
rjackson_isl joined #evergreen |
08:44 |
rhamby_ |
kmlussier: you don't happen to have notes about what failed for you on bug 1722827 do you? |
08:44 |
pinesol |
Launchpad bug 1722827 in Evergreen "Trailing spaces cause located URIs to be invalid" [Undecided,New] https://launchpad.net/bugs/1722827 |
08:46 |
|
pwillard26 joined #evergreen |
08:54 |
kmlussier |
rhamby_: It's what I put in the LP bug. After the first test where I finally got it to work, when I tried on a subsequent day, every attempt failed. I tried the space before the OU, after an OU, it didn't matter. |
08:54 |
kmlussier |
I can look at it again. |
08:55 |
|
bos20k joined #evergreen |
08:55 |
rhamby_ |
kmlussier: so weird, I tried over and over last night and I couldn't get it to not work with spaces before and after on different records. |
08:56 |
rhamby_ |
kmlussier: I did direct by db. Did you use the staff client for editing, wondering if that could somehow make a difference.... I can't see how though. |
08:58 |
kmlussier |
rhamby_: Yes, I used the client. The others testing that patch would have used the client too because they were on my VM, and they don't have db access. |
09:24 |
|
ChasedSpade joined #evergreen |
09:29 |
|
yboston joined #evergreen |
09:34 |
|
bos20k joined #evergreen |
09:42 |
|
jvwoolf joined #evergreen |
10:04 |
|
khuckins_ joined #evergreen |
10:12 |
|
idjit joined #evergreen |
10:15 |
kmlussier |
berick / khuckins_ : Just wanted to let you know that the problem I had with perm group tree entries was related to not applying the branch correctly. Working for me now. |
10:15 |
idjit |
kmlussier++ # friendly guidance RE 1775216 and upgrade script naming. i got you a cat https://i.imgur.com/oamgCcg.gif |
10:15 |
khuckins_ |
kmlussier: That's good to hear :) |
10:17 |
kmlussier |
idjit: So cute! I wish my dog and cat got along that well. |
14:02 |
berick |
kmlussier: for bug 1721575, can I assume "Sort cart items by:" should be "Sort basket items by:" ? if so, I can make that change before merging |
14:02 |
pinesol |
Launchpad bug 1721575 in Evergreen "Batch Actions from Search Results" [Wishlist,Confirmed] https://launchpad.net/bugs/1721575 - Assigned to Bill Erickson (berick) |
14:03 |
hbrennan |
It works! Thanks y'all! |
14:03 |
kmlussier |
berick: Yes. It was still a cart in initial testing. |
14:03 |
hbrennan |
idjit++ |
14:06 |
collum |
hbrennan++ |
14:06 |
collum |
Sorry. Someone came into the office right when you started typing. |
15:17 |
|
khuckins_ joined #evergreen |
15:33 |
JBoyer |
kmlussier, was example.reporter-extension.sql run on mlnc1.noblenet.org ? That's where reporter.classic_item_list (from the error text) is defined. |
15:34 |
JBoyer |
As long as they're in the default IDL they're not exactly "examples," but "missing" :/ |
15:35 |
kmlussier |
JBoyer: Nope. I just created another report that didn't use classic item list to complete my test rather than figure out how to add it. |
15:35 |
* kmlussier |
is lazy that way. |
15:35 |
JBoyer |
kmlussier++ |
15:35 |
JBoyer |
So long as you know. Maybe I'll toss the busted report so no one else makes the same mistake I did. :) |
15:36 |
kmlussier |
Reports is my weak spot, and any time I need to test something there, I end up floundering. |
15:36 |
kmlussier |
JBoyer: Oops. Sorry! |
15:47 |
csharp |
kmlussier: I'm curious - I'm missing what JBoyer is talking about in the scrollback - what's going on? |
15:49 |
JBoyer |
running reports on the inventory date test server. :) |
15:49 |
kmlussier |
csharp: Oh, I had just tried using Classic Item List for a report on a test system, but I hadn't first run example.reporter-extension.sql. |
15:50 |
csharp |
oh, I understand |
15:50 |
csharp |
yeah :-/ the age-old dilemma of whether we remove those from the UI or add them to the default DB |
15:51 |
csharp |
or remove stat_cats from the view |
17:09 |
|
mmorgan left #evergreen |
17:23 |
|
khuckins__ joined #evergreen |
18:06 |
kmlussier |
Calling 1119 |
18:15 |
pinesol |
[evergreen|a. bellenir] LP#1775216: inconsistent availability counts between staff client and opac - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9b4591e> |
18:15 |
pinesol |
[evergreen|a. bellenir] LP#1775216: adding a pgtap test for inconsistent availability counts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=fe47420> |
18:15 |
pinesol |
[evergreen|a. bellenir] LP#1775216: inconsistent copy counts between opac and staff client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aa1d560> |
18:15 |
pinesol |
[evergreen|a. bellenir] LP#1587620: inconsistent copy counts between opac and staff client for peer bibs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=327daf4> |
18:15 |
pinesol |
[evergreen|Kathy Lussier] LP#1775216: Stamping upgrade script for inconsistent copy counts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d967aac> |
18:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
19:38 |
|
sulvone2 joined #evergreen |
21:20 |
|
Cronus20 joined #evergreen |
22:05 |
|
Guest43996 joined #evergreen |
05:04 |
|
Usurp21 joined #evergreen |
05:27 |
|
ZLSA24 joined #evergreen |
05:36 |
|
luisoliv joined #evergreen |
06:30 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
06:43 |
|
Dyrcona joined #evergreen |
06:46 |
csharp |
more data from 18.04 OpenSRF math/dbmath not starting: https://pastebin.com/bm3iNJNY |
06:49 |
Dyrcona |
This is a case where encryption is forced on us, but not necessary. |
09:59 |
berick |
fyi, there's a fix to last night's build errors in bug 1775719 |
09:59 |
pinesol |
Launchpad bug 1775719 in Evergreen 3.0 "Multiple IndexedDB connections (via tabs) can result in data inconsistency" [High,Confirmed] https://launchpad.net/bugs/1775719 - Assigned to Kathy Lussier (klussier) |
10:00 |
bos20k |
Regarding the voicing issue. I am finally registered and verified at Freenode (had to use different e-mail address). Once we are registered and verified are we supposed to automatically be voiced in #evergreen? |
10:00 |
bshum |
bos20k: No, it doesn't automatically voice you, but I think you'd just be able to speak without being voiced if you were registered, etc. |
10:00 |
|
Milos19 joined #evergreen |
10:00 |
bshum |
I could unvoice you to test that :) |
10:01 |
bos20k |
Sure |
10:02 |
bshum |
Try it :) |
10:02 |
bos20k |
Testing, testing, 123... |
10:02 |
bshum |
Huzzah |
10:02 |
kmlussier |
Woo hoo! |
10:02 |
bos20k |
My voice is my password, verify me. |
14:19 |
Dyrcona |
But, I have a log entry to prove it's possible from the client, 'cause there's a cstore call to actor.usr_merge with the same id for src and dest usr. |
14:19 |
Dyrcona |
The result isn't good. |
14:28 |
dbwells |
Dyrcona: but can we contain it? |
14:28 |
Dyrcona |
dbwells: Sure, the fix is relatively simple (at least in the database), I'm going to do a test before opening a Lp bug. |
14:29 |
Dyrcona |
The fix is to add a check at the top of actor.usr_merge to bail if the user ids are the same. |
14:29 |
dbwells |
Dyrcona: sorry, just a poor attempt at humor. Next time, more exclamations points, maybe. |
14:29 |
Dyrcona |
Ah ha! |
16:00 |
|
stephengwills left #evergreen |
16:20 |
|
jvwoolf left #evergreen |
16:34 |
kmlussier |
@quote random |
16:34 |
pinesol |
kmlussier: Quote #112: "<RoganH> My most remembered contributions to IRC will involve coffee and deep frying." (added by csharp at 12:43 PM, April 15, 2015) |
16:37 |
|
Xenthys8 joined #evergreen |
16:41 |
|
Mikaela28 joined #evergreen |
16:49 |
|
bdljohn joined #evergreen |
16:54 |
|
Fuchs14 joined #evergreen |
16:58 |
|
mmorgan left #evergreen |
17:11 |
pinesol |
[evergreen|Garry Collum] LP#1752891 Crowded text on Print Item Labels page fix. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ecdcfb2> |
17:18 |
|
luisoliv joined #evergreen |
18:18 |
|
rorx21 joined #evergreen |
18:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
19:32 |
|
theaetetus joined #evergreen |
19:41 |
|
basic`26 joined #evergreen |
20:25 |
|
Sharker joined #evergreen |
03:15 |
|
majestic6 joined #evergreen |
05:48 |
|
infina4 joined #evergreen |
06:22 |
|
cncr04s20 joined #evergreen |
06:32 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
06:45 |
|
Numline123 joined #evergreen |
06:58 |
|
lorimer15 joined #evergreen |
07:07 |
|
agoben joined #evergreen |
07:38 |
|
dwgreen joined #evergreen |
07:38 |
|
bdljohn joined #evergreen |
08:06 |
|
collum joined #evergreen |
08:16 |
pinesol |
[evergreen|a. bellenir] LP#1785305: Item Status 'Edited By' shows id instead of username. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aae6a29> |
08:36 |
|
dpearl joined #evergreen |
08:40 |
|
badpixel27 joined #evergreen |
08:41 |
|
mmorgan joined #evergreen |
10:01 |
csharp |
comcast-- |
10:05 |
* Dyrcona |
just asked if bug 1702978 should be backported and targeted at earlier series. |
10:05 |
pinesol |
Launchpad bug 1702978 in OpenSRF "memcache keys containing % fail" [High,Confirmed] https://launchpad.net/bugs/1702978 - Assigned to Jason Stephenson (jstephenson) |
10:09 |
kmlussier |
kmlussier-- # Not noticing test failures when testing bug 1775719. |
10:09 |
pinesol |
Launchpad bug 1775719 in Evergreen 3.0 "Multiple IndexedDB connections (via tabs) can result in data inconsistency" [High,Confirmed] https://launchpad.net/bugs/1775719 - Assigned to Kathy Lussier (klussier) |
10:09 |
* berick |
was just verifying |
10:09 |
berick |
waiting for npm |
10:13 |
pinesol |
Launchpad bug 1746566 in Evergreen 3.1 "wishlist: increase row limits available in specific grids" [Undecided,New] https://launchpad.net/bugs/1746566 |
10:14 |
kmlussier |
Dyrcona: Sounds reasonable. |
10:17 |
miker |
Dyrcona: re 1702978, the EG-only part can be backported, IIRC. I believe we're using that in production without the opensrf part |
10:18 |
Dyrcona |
Adding a % to my username would be a decent test, yes? |
10:18 |
berick |
kmlussier: fix en route |
10:18 |
berick |
bitten again by phantomjs lagging in support for features |
10:18 |
berick |
[].includes(..) in this case |
10:20 |
miker |
Dyrcona: yes |
10:21 |
Dyrcona |
miker: Thanks, that's what I thought. |
10:21 |
Dyrcona |
"Just makin' sure...." |
10:23 |
Dyrcona |
I'll test it with OpenSRF and Evergreen 3.0 first. |
10:24 |
|
yboston joined #evergreen |
10:40 |
|
yboston joined #evergreen |
10:41 |
jeff |
quick news: as of me setting +z on the channel the other day, unidentified users can now just send a @voice command to channel to have pinesol voice them. |
10:42 |
jeff |
(+z makes it so that channel operators like pinesol can see messages from users who wouldn't normally be able to send to channel (includig spammers). |
10:43 |
jeff |
this also conveniently works around the issue where such users can't message pinesol directly because of pinesol automatically getting the +R usermode |
10:43 |
berick |
can anyone else running rel_3_0 confirm 'grunt test' won't build? wondering if my node version (v8) is incompatible. |
10:44 |
berick |
s/won't build/exits immediately/ |
10:44 |
berick |
with: TypeError: Cannot read property 'prototype' of undefined |
10:44 |
Dyrcona |
with or without the fix for offline mode? |
10:44 |
bshum |
berick: From what I remember, node 8 didn't work for me when I was testing it awhile back, but I can try again later. |
10:45 |
berick |
Dyrcona: stock rel_3_0 |
10:45 |
Dyrcona |
I'm using node 6. |
10:46 |
Dyrcona |
Last time I tried node 8 nothing worked, but I got a botched Node upgrade because I didn't do it with the proper method of the week. |
10:47 |
Dyrcona |
FWIW, grunt test is working with Node 6.11.3. |
10:48 |
berick |
Dyrcona++ |
10:48 |
* berick |
continues his monologue on 1775719 |
10:51 |
Dyrcona |
yeah. |
10:51 |
Dyrcona |
bshum ^^ :) |
10:51 |
Dyrcona |
harmless wrong tab. :) |
10:52 |
Dyrcona |
And, since I just restarted apache on my test vm I have a question: |
10:53 |
Dyrcona |
Has anyone noticed that you have to restart/reload apache after restarting the opensrf.settings service lately? |
10:54 |
Dyrcona |
Since 3.0 or possibly the web client, if I restart opensrf.settings and open-ils.cat to pickup new MARC templates, for instance, neither the web client nor XUL will let me login until I restart apache2. |
10:54 |
Dyrcona |
That didn't used to happen, IIRC. |
13:06 |
|
bdljohn joined #evergreen |
13:07 |
Dyrcona |
Too late for the Monty Python reference.... |
13:11 |
rhamby_ |
Dyrcona: it's never too late for a monty python reference |
13:15 |
csharp |
berick: replying late to your request to comment on bug 1775466 - I'm happy to, but I broke something when assigning a public IP to my test server and workstation registration stopped working - reinstalling the ang6 stuff in hopes that it Just Works™ |
13:15 |
pinesol |
Launchpad bug 1775466 in Evergreen "Angular6 Base Application" [Undecided,New] https://launchpad.net/bugs/1775466 - Assigned to Bill Erickson (berick) |
13:16 |
csharp |
so I'd like to see it working again before I comment :-) |
13:19 |
|
rlefaive joined #evergreen |
14:12 |
csharp |
ok, whew :-) |
14:12 |
berick |
it should send you to the angjs version |
14:12 |
csharp |
ok |
14:12 |
berick |
the ang6 version works (or it did), but had limited testing |
14:13 |
|
khuckins_ joined #evergreen |
14:13 |
csharp |
I saw it working yesterday |
14:13 |
berick |
csharp: i suggest goign to the angjs version to registring there |
16:36 |
|
annieslmaos joined #evergreen |
16:38 |
|
Connection joined #evergreen |
16:42 |
|
mmorgan1 joined #evergreen |
16:56 |
csharp |
ok - progress on Ubuntu 18.04/newer ejabberd - the problem revealed after enabling debug logging in ejabberd showed "<<"<stream:error><policy-violation xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Use of STARTTLS required</text></stream:error>">>" |
16:57 |
|
jvwoolf left #evergreen |
16:57 |
csharp |
so then as a test I set "starttls_required: false" in ejabberd.yml and it let opensrf start |
16:58 |
berick |
csharp: i assume you've seen bug # 1703411 |
16:58 |
berick |
er bug 1703411 |
16:58 |
pinesol |
Launchpad bug 1703411 in OpenSRF "OpenSRF: XMPP Non-SASL auth is being phased out" [Medium,Confirmed] https://launchpad.net/bugs/1703411 |
17:03 |
berick |
will take some coding to get the sasl stuff going |
17:04 |
berick |
the other Perl jabber libs have code we can steal |
17:04 |
berick |
i'm sure there's C stuff out there somewhere |
17:06 |
csharp |
I guess for a test server running on a laptop or just not exposed to the WWW it would probably be fine to disable starttls? |
17:07 |
csharp |
I don't want the install instructions to recommend anything foolhardy |
17:07 |
|
Guest95742 joined #evergreen |
17:08 |
berick |
csharp: well, it's the same as what we're doing now |
17:10 |
berick |
whether or not we want to do that is a question we have to decide, of course, but the 2 changes you made are identical to how ejabberd has always been used by EG. |
17:16 |
|
mmorgan1 left #evergreen |
17:27 |
|
nikow2 joined #evergreen |
17:40 |
bshum |
csharp: It let OpenSRF start with starttls_required: false ? Interesting... did you actually get math to start though? |
17:41 |
bshum |
I got as far as seeing most of OpenSRF start up, but math still failed to start |
17:41 |
bshum |
So I couldn't complete a proper test run |
17:41 |
bshum |
I'll retest it on my new 18.04 VM later |
17:42 |
|
DLange2 joined #evergreen |
17:44 |
|
abian0 joined #evergreen |
17:48 |
bshum |
Right, dbmath and math fail to start, even with the options set for me the way you describe. That matches my current experiences so far with 18.04 |
17:50 |
|
Tourist12 joined #evergreen |
17:52 |
berick |
bshum: what about perl services? |
17:53 |
bshum |
berick: Those seem to be alive. I haven't installed the rest of Evergreen cause there's some dependency issues I think |
18:06 |
bshum |
Maybe |
18:06 |
bshum |
But the osrfsys.log does give me a bunch of ejabberd error noise |
18:06 |
bshum |
So I don't know if it's really respecting the options we asked it to use when switching to legacy auth |
18:10 |
pastebot |
"bshum" at 64.57.241.14 pasted "startup logs from 18.04 test server" (321 lines) at http://paste.evergreen-ils.org/13899 |
18:11 |
* bshum |
wanders off to dinner, will compare notes with csharp and folks later |
18:32 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
18:56 |
|
lutoma11 joined #evergreen |
19:18 |
csharp |
bshum: yeah math and dbmath aren't running :-/ |
19:43 |
|
annieslmaos joined #evergreen |
13:02 |
|
dpearl joined #evergreen |
13:04 |
|
Carlos061113 joined #evergreen |
13:05 |
|
and0 joined #evergreen |
13:08 |
csharp |
berick: ok, finally in, but basically everywhere I go is pointing back to angularJS pages - is there something I should test? |
13:10 |
csharp |
nm - I see your response to idjit earlier... |
13:12 |
|
nfburton joined #evergreen |
13:12 |
csharp |
so far so goo |
13:12 |
csharp |
d |
13:12 |
berick |
csharp: awesome. the ang6 stuff is the experimental catalog and admin -> server admin |
13:13 |
berick |
and change operator |
13:13 |
csharp |
berick: so how do I get to those? (might be missing something obvious) |
13:19 |
berick |
huh, that's not an error I recall seeing |
13:20 |
pastebot |
"idjit" at 64.57.241.14 pasted "ERROR TypeError: Cannot read p" (11 lines) at http://paste.evergreen-ils.org/13885 |
13:22 |
berick |
thanks idjit |
13:22 |
idjit |
if it only happens on my test install, i'm willing to bet i goofed it up, rather than anything actually being broken. |
13:22 |
berick |
related to newest code... idjit what's your URL path? |
13:22 |
idjit |
https://egdev1.grpl.org/eg2/staff/splash |
13:23 |
berick |
idjit: try https://egdev1.grpl.org/eg2/en-US/staff/splash |
14:04 |
|
collum joined #evergreen |
14:04 |
* Dyrcona |
shrugs. |
14:05 |
|
collum joined #evergreen |
14:06 |
csharp |
berick: I'm really keen on this making it into 3.2... what sort of testing rigor do you think is needed for that? So far, everything I'm doing works without trouble - not testing super deeply, but UIs are loading fine, etc. |
14:08 |
berick |
csharp: great, i've been giving it a good workout too, so I'm also pretty confident merge-safe. I probably need to roll back a few changes to be absolutely safe, though. |
14:08 |
csharp |
legacy angular UIs work fine too |
14:08 |
csharp |
ok |
14:08 |
berick |
e.g. the server admin page needs a ton of testing if we're going to use it now. I turned it on for testing/review, but we probably don't want to replace that UI wholesale |
14:08 |
csharp |
right, I think having it available with a fallback is ideal |
14:09 |
berick |
i could roll that switch back, then re-deploy to master after 3.2 |
14:09 |
berick |
I suspect we'll want to hide the experimental catalog for 3.2 as well |
14:14 |
berick |
Dyrcona: you read my mind |
14:14 |
csharp |
ugh - I'm gonna miss most of the dev meeting - my daughter's school pickup collides with that timeslot |
14:14 |
berick |
heh, found a bug I just created in the admin UI's. /me fixes |
14:15 |
Dyrcona |
Speaking of finding bugs...Tests I wrote for a new feature actually found a bug in my code. |
14:15 |
Dyrcona |
I thought about signing into IRC on Sunday just to say, "Yay, tests!" |
14:16 |
kmlussier |
tests++ |
14:28 |
* JBoyer |
won't be here for the meeting either. |
14:29 |
JBoyer |
Though I'm +1 for including ang6 in 3.2. The more dojo admin interfaces removed, the better. |
14:30 |
|
collum joined #evergreen |
14:32 |
|
nfburton joined #evergreen |
14:33 |
nfburton |
Quick Q - Trying to find the setting for default OPAC OU. It defaults to Consortium instead of System right now. I changed it on my test server but can't seem to find the setting again |
14:35 |
Dyrcona |
nfburton: Do you mean for a user or for a domain? |
14:36 |
nfburton |
When not signed in, the default for the opac. |
14:38 |
csharp |
nfburton: do you mean having the OPAC default to a particular library? |
15:18 |
kmlussier |
+1 |
15:18 |
berick |
it's about 2/3 of the server->admin pages and acq admin pages |
15:18 |
berick |
i can propose a list of pages to thumbs up/down if that helps |
15:18 |
Dyrcona |
I can probably arrange some testing of those soon, even though I'll be out most of next week. |
15:18 |
berick |
then we can test them |
15:19 |
berick |
ok, so I'll get the ang6 branch into final merge-able state and.. |
15:20 |
berick |
put together a list of admin UI's that should be suitable for using in 3.2 as replacements for the dojo versions. |
15:20 |
berick |
that will also mean modifying the links in the angjs app to point to the same new UI's |
15:21 |
berick |
otherwise, re: 3.2, we've closed a few more blockers in the past ~week |
15:21 |
Dyrcona |
berick++ |
15:22 |
berick |
and of course, those are not bound by the feature slush, but sooner the better, obviously |
15:22 |
berick |
any questions for me? |
15:29 |
Dyrcona |
It also does no good to keep XUL if much of it is broken. |
15:30 |
miker |
the biggest "breakage" AFAIK is copy alert msg vs alert matrix |
15:30 |
miker |
but that's a known quantity |
15:30 |
kmlussier |
In any case, I would be willing to take an action item to test any webstaffblockers with a pullrequest. |
15:31 |
kmlussier |
There are a couple of bugs there without pullrequest tags that I know are big concerns for our libraries. |
15:32 |
berick |
if anyone can describe a way to reproduce bug 1724029, i'll happily fix that one. |
15:32 |
pinesol |
Launchpad bug 1724029 in Evergreen "Web Client: Patron Search sorted by last name not working as expected" [High,Confirmed] https://launchpad.net/bugs/1724029 |
15:32 |
berick |
or give me SSH access to their prod servers! |
15:38 |
kmlussier |
berick: Of course! :) |
15:40 |
gmcharlt |
so... I think it's fair to say that we have an open question - but one that maybe we can punt until closer to release? |
15:40 |
|
rlefaive joined #evergreen |
15:41 |
berick |
my only request is the XUL removal code be merged by beta cutting day (1 month from today) so it can get some real testing |
15:41 |
berick |
so ideally decide then-ish |
15:41 |
gmcharlt |
sounds like a plan, or a guideline, anyway |
15:42 |
gmcharlt |
any other questions regarding 3.2? |
15:42 |
gmcharlt |
or any questions or updates regarding maintenance releases? |
15:46 |
gmcharlt |
#info Dyrcona would like eyes on the patch for bug 1780660 |
15:46 |
pinesol |
Launchpad bug 1780660 in Evergreen "Add More Workstation Functions to OpenILS::Utils::TestUtils" [Wishlist,Confirmed] https://launchpad.net/bugs/1780660 |
15:46 |
gmcharlt |
Dyrcona: any comments to add? |
15:46 |
Dyrcona |
Just a bit of me being selfish and cleaning up some test code. |
15:47 |
Dyrcona |
When writing Perl tests recently, I noticed we had at least 3 different implementations of code to add workstations for testing. |
15:47 |
Dyrcona |
So, thought I'd come up with a single version of the necessary functions and add them to TestUtils. |
15:47 |
gmcharlt |
Dyrcona++ |
15:48 |
miker |
+1 |
15:48 |
Dyrcona |
I'm also using the changes in the tests in my working branch, so I'd like the changes to go in before I rebase. |
15:48 |
Dyrcona |
Should be simple to test. Just check out the branch cd to perlmods and run make livecheck |
15:49 |
Dyrcona |
I rebased the branch after someone updated a test this week, too. |
15:49 |
kmlussier |
Dyrcona++ |
15:50 |
* miker |
is willling to simply push it having read the commit |
15:50 |
Dyrcona |
So, that's my shameless plug. :) |
15:57 |
miker |
it would keep someone from accidentally implementing a similar bug |
15:57 |
gmcharlt |
but that part can be reserved for OpenSRF 3.1 IMO |
15:57 |
miker |
but requires tighter coordination between EG and OSRF |
15:58 |
abneiman |
regarding things in need of testing, several cataloging bugs have PRs -- bug 1732761 bug 1675882 bug 1739460 bug 1739286 -- a couple of which are flagged as blockers |
15:58 |
Dyrcona |
OK. I'll see about having a look at it. |
15:58 |
pinesol |
Launchpad bug 1732761 in Evergreen "Web Client - When adding vols/copies to multiple branches, circ library does not populate" [High,Confirmed] https://launchpad.net/bugs/1732761 |
15:58 |
pinesol |
Launchpad bug 1675882 in Evergreen "webclient: adding individual copies defaults circ OU to workstation OU" [Medium,Confirmed] https://launchpad.net/bugs/1675882 |
16:01 |
berick |
awesome |
16:01 |
kmlussier |
miker++ |
16:01 |
Dyrcona |
Speaking of the omnibus, should that be backported to 3.0? |
16:01 |
Dyrcona |
We've tested it here with 3.0.10 and it works. There's a conflict, but I know how to resolve it. |
16:02 |
miker |
berick: checking the other ... Dyrcona: I'm for it |
16:02 |
abneiman |
+1 to backporting omnibus |
16:02 |
berick |
miker: bug 1739460 too please, unclear what to merge |
16:05 |
miker |
so... maybe it doesn't hurt to merge? |
16:06 |
berick |
that would be user/miker/lp-1739460-all-relevant-locations ? |
16:06 |
miker |
berick: yessir |
16:06 |
berick |
OK, i can merge that, I've already tested it once |
16:06 |
* berick |
grabs |
16:07 |
gmcharlt |
and.. that takes us past the hour |
16:07 |
gmcharlt |
thanks, folks! |
16:07 |
gmcharlt |
#endmeeting |
17:46 |
berick |
yeah, all renewals were used up. possibly staff didin't have perm to extend renewal count, but did have perm to change due date. *shrug*. |
17:47 |
berick |
in any event, i think it's reasonable to assume max fines is a hard limit on a circ |
18:03 |
miker |
seems fair |
18:31 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
18:37 |
|
Levex joined #evergreen |
18:56 |
|
BigRig joined #evergreen |
18:56 |
|
foobarrel joined #evergreen |