| 05:54 |
* kmlussier |
yawns |
| 06:16 |
kmlussier |
Looks like bug 1350371 has had a signoff for a while if anyone feels inclined to merge it. :) |
| 06:16 |
pinesol_green |
Launchpad bug 1350371 in Evergreen "ACQ improved duplicate order detection" (affected: 1, heat: 8) [Wishlist,New] https://launchpad.net/bugs/1350371 |
| 06:20 |
kmlussier |
Ooh! I missed bug 1379815 when it was first added. I'll have to add it to my testing list for today. |
| 06:20 |
pinesol_green |
Launchpad bug 1379815 in Evergreen "Assign stat cats during Vandelay import/overlay of items" (affected: 1, heat: 8) [Wishlist,New] https://launchpad.net/bugs/1379815 |
| 06:48 |
|
berick joined #evergreen |
| 07:31 |
|
graced joined #evergreen |
| 08:53 |
|
maryj joined #evergreen |
| 08:55 |
eeevil |
kmlussier / Dyrcona: working/user/miker/lp1251394-metabib-display-fields updated |
| 08:55 |
kmlussier |
eeevil++ |
| 08:56 |
eeevil |
either rebasing shifted the code around and I missed it ... or, the baseline schema was never tested -- only the upgrade version was |
| 09:02 |
|
maryj joined #evergreen |
| 09:23 |
|
julialima_ joined #evergreen |
| 09:25 |
kmlussier |
eeevil: Still getting the schema does not exist messages, but the initial error is a bit different this time: |
| 10:54 |
Dyrcona |
dbwells: Good suggestion. I'll do that for now until we decide what to do about point release notes. |
| 10:54 |
kmlussier |
It could just be a matter of prettying up the change logs for each point release. |
| 10:54 |
Dyrcona |
Well, I think security fixes should get extra attention. |
| 10:57 |
kmlussier |
eeevil: Still no luck on the metabib display fields branch. Also, I don't know if the person who was planning to test it will be able to do it for tomorrow. Just wanted to let you know in case there are other things you need to do. |
| 10:57 |
kmlussier |
Latest error is: psql:002.schema.config.sql:188: ERROR: function config.metabib_representative_field_is_valid(integer, text) does not exist |
| 10:57 |
kmlussier |
HINT: No function matches the given name and argument types. You might need to add explicit type casts. |
| 10:58 |
|
dreuther_ joined #evergreen |
| 10:59 |
eeevil |
kmlussier: ah... yeah, there's more to move around. Thanks for looking at it. I won't have tuits to get back to it today, sorry. if there's a way to use the upgrade script on an existing master db, that should get you there, but I don't know if that's easy in your setup |
| 10:59 |
|
sandbergja joined #evergreen |
| 11:00 |
kmlussier |
eeevil: OK, I'll just add that error to the LP bug then so it doesn't get lost. |
| 11:00 |
eeevil |
thanks much! |
| 11:00 |
dbwells |
I am also going to make time to test the metabib display fields before the cutoff, since I'm at least partially responsible that it's been delayed this long. Must make amends! |
| 11:03 |
pinesol_green |
[evergreen|Steven Chan] LP#1418772: Avoid internal server error on viewing full record when copy create_date is null - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=55aaea8> |
| 11:03 |
pinesol_green |
[evergreen|Galen Charlton] LP#1418772: (follow-up) tweak undef-edness check - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=fcaf1cc> |
| 11:12 |
|
jwoodard joined #evergreen |
| 13:30 |
krvmga |
in the hen story, the animals who come later don't get to eat the cake; only the hen and her chicks :) |
| 13:30 |
yboston |
BTW, at some point we shuold ask opinions fromt he whole community |
| 13:31 |
yboston |
but for example that can be done after we have had a secodn meeting to talk about re-orgs |
| 13:31 |
krvmga |
yboston: in that same line, i think, at some point, we should "play test" the docs with our expected end users. |
| 13:31 |
remingtron |
yboston: might be good to have a proposed outline to get feedback on |
| 13:31 |
sandbergja |
yboston: I like the sound of that -- I think we would get more feedback if we send out something concrete |
| 13:32 |
yboston |
I prefer to first have a clear list of things that we want to adress in the re-org and the minimun requirements for the re-org. Though both can be revised with time |
| 05:14 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 07:31 |
|
graced joined #evergreen |
| 07:39 |
|
rjackson_isl joined #evergreen |
| 07:55 |
|
graced joined #evergreen |
| 09:13 |
bshum |
They're just deprecation warnings. Not errors. |
| 09:14 |
bshum |
krvmga: With autoreconf -i you only do that on git installs, from a tarball OpenSRF, it's not a necessary step. |
| 09:15 |
bshum |
Might be why you never noticed before? Cause it's been doing those little warnings for years now. |
| 09:18 |
StomproJ |
Has anyone tested/used one of the new intel DDR4 memory based servers for postgresql? Does the increased memory bandwidth give a big boost in performance? |
| 09:18 |
bshum |
There's DDR4? :\ |
| 09:18 |
* bshum |
goes back to living under his rocks |
| 09:19 |
bshum |
StomproJ: Might be an interesting question to ask over in the #postgresql channel too :) |
| 10:17 |
pinesol_green |
[evergreen|Remington Steed] LP#957466: Update editor/edit_date/source on overlay - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=62510da> |
| 10:18 |
pinesol_green |
[evergreen|Jason Stephenson] LP#957466 Vandelay set the 905$u on imported bib records to current user. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=522b6ff> |
| 10:18 |
pinesol_green |
[evergreen|Jason Stephenson] LP#957466: Stamping Upgrade Script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=fe07338> |
| 10:43 |
jeff |
I've noticed an odd (to me) difference between xulrunner and webstaff, and I think it comes down to pcrud permissions vs open-ils.circ api permissions: |
| 10:47 |
jeff |
given a patron with open circulations at the CONS level (i can't recall offhand if those were generated by concerto or if that was me manually checking things out without having a workstation set), users without the EVERYTHING permission can't see the circs in the web client. |
| 10:47 |
jeff |
but they can in the xulrunner client. |
| 10:47 |
jeff |
I haven't yet given it a more realistic test (usually you wouldn't have circs at CONS, etc) |
| 10:48 |
berick |
jeff: does your login have global VIEW_CIRCULATIONS permissions? |
| 10:48 |
jeff |
And I'm going to take the opportunity to refresh/enhance my understanding of permissions in general, but I wasn't able to make the circs show in the web client even when making someone global admin and assigning them working locations across the org tree. |
| 10:49 |
jeff |
berick: i'll verify that specifically. one set. |
| 13:32 |
kmlussier |
yboston: I'm here now |
| 13:32 |
collum |
Just got it buzzy |
| 13:32 |
csharp |
buzzy: I got it at 1:29 p.m. |
| 13:34 |
yboston |
kmlussier: I sent you an email a little earlier. just letting you know I am building a Vm to test auth overlay. Also that, I if you had time/VM, that I have some auth code needing a sign-off bug 1403967 |
| 13:34 |
pinesol_green |
Launchpad bug 1403967 in Evergreen "Display 'subject heading thesaurus' value in Manage Authorities results" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1403967 |
| 13:35 |
buzzy |
great, thanks. i just did, too. for some reason, it didn't go through the first time |
| 13:37 |
|
mmorgan joined #evergreen |
| 13:41 |
|
maryj_ joined #evergreen |
| 13:42 |
kmlussier |
yboston: OK, good. I'm a little behind in my testing this week. |
| 13:43 |
kmlussier |
yboston: I can take a look at your code. |
| 13:44 |
|
maryj joined #evergreen |
| 13:53 |
jeffdavis |
jonadab: you are correct - passwords stored in the db are hashed but not salted |
| 13:55 |
Dyrcona |
Salt is applied when a user authenticates, but if someone grabs your database, you may have bigger problems than worrying about the user's password hashes. |
| 15:15 |
* phasefx |
found a wish for this earlier when trying to use Consortium as a pickup lib.. wasn't obvious to me at first what was happening |
| 15:16 |
jonadab |
Having the page return a partly-filled form with an informative error about the missing required field(s) is what is what I would probably do, _possibly_ with optional Javascript designed to pre-empt the submit if Javascript is working ok, letting the server-side stuff catch it if not. |
| 15:18 |
kmlussier |
phasefx: You can select the consortium as a pickup library? |
| 15:19 |
phasefx |
kmlussier: I'm sure it was an admin user on a test system, maybe with the consortium as a the workstation lib. Once deselected, you can't reselect it |
| 15:19 |
kmlussier |
jonadab: The problem with the optional Javascript is that we've tried to keep it out of the catalog unless it's aboslutely necessary. |
| 15:19 |
phasefx |
but the user had no sane default for whatever reason |
| 15:19 |
kmlussier |
phasefx: Ah, ok. |
| 15:39 |
pinesol_green |
Launchpad bug 1366026 in Evergreen "Add Copy Active Date to Staff Client Display" (affected: 4, heat: 24) [Wishlist,Incomplete] https://launchpad.net/bugs/1366026 |
| 15:39 |
jboyer-isl |
lp 1210541 |
| 15:40 |
jboyer-isl |
Drop the comma or add the space, who knows where things went off. |
| 15:47 |
yboston |
berick: am I wrong, or did your authority overlay code get signed off and merged to master? Should I still test off of master or should I test from your rebased branch? |
| 15:48 |
kmlussier |
jboyer-isl: Hmmm...I was just discussing it with mmorgan. I think there's a fine line between bug fix and enhancement, but if it isn't mentioned in the release notes, then all the people who gave up on deleting copy locations won't know they can delete them now. |
| 15:49 |
dbs |
Bug fixes should have release notes entries too! |
| 15:49 |
goood |
yboston: it got pushed today, you are not wrong. testing on master is best now |
| 15:49 |
jboyer-isl |
Sigh. I suppose that is true. (dbs's point includeD) |
| 15:49 |
dbs |
lots of bug fixes listed in http://www.postgresql.org/docs/9.4/static/release-9-4-1.html :) |
| 15:50 |
* dbs |
promises to start writing now overdue release notes for TPAC features |
| 16:45 |
hopkinsju |
Right. One favors readability, the other writeablilty I suppose |
| 16:56 |
dbs |
bshum: aw yeah, that's how I roll. I'll fix it |
| 16:56 |
bshum |
dbs++ |
| 16:57 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:04 |
|
vlewis joined #evergreen |
| 17:05 |
|
vlewis joined #evergreen |
| 17:09 |
|
mdriscoll left #evergreen |
| 17:11 |
|
mmorgan left #evergreen |
| 17:13 |
pinesol_green |
[evergreen|Dan Scott] Fix typo in release notes for TPAC discoverability - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c0fabd0> |
| 17:15 |
|
wlayton joined #evergreen |
| 17:17 |
* bshum |
waves at wlayton :) |
| 17:24 |
|
mrpeters left #evergreen |
| 18:00 |
dbs |
berick: fantastic! |
| 18:03 |
berick |
certainly adds pressure to angular-ize (i.e. websocket-ize) legacy UI's |
| 18:03 |
ldw |
MrBaggins: I sent a reports howto to the mailing list in 2011, so some of it may not be applicable now, you can find it here: http://georgialibraries.markmail.org/message/ptlz36kle63spqqb?q=Liam+report+date:201109+ |
| 18:04 |
berick |
hm, patron reg throws the same warning, but still renders OK |
| 18:04 |
berick |
perhaps it's only deprecated, but not yet prevented, and vandelay is just broken for some other reason |
| 18:05 |
berick |
oh well, more testing later |
| 18:06 |
dbs |
all I've been seeing is deprecation notices, but I thought maybe you were on canary or some such advance build |
| 18:12 |
MrBaggins |
Thanks for that ldw, every bit helps |
| 18:23 |
jonadab |
As far as asciidoc and people wanting .txt files so they can double click, it should be straightforward to make the build process turn the former into the latter. |
| 00:03 |
|
mrpeters joined #evergreen |
| 00:07 |
|
mrpeters left #evergreen |
| 04:59 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 07:16 |
|
graced joined #evergreen |
| 07:27 |
kmlussier |
@coffee |
| 07:27 |
* pinesol_green |
brews and pours a cup of Ka'u Coffee Natural Dried, and sends it sliding down the bar to kmlussier |
| 15:01 |
dbwells |
#info dbwells = Dan Wells, Hekman Library (Calvin College) |
| 15:01 |
remingtron |
#info remingtron = Remington Steed, Hekman Library (Calvin College) |
| 15:01 |
phasefx |
#info phasefx = Jason Etheridge, ESI |
| 15:02 |
bshum |
Alrighty, well, as others come along, feel free to add yourselves. We'll move on for now. |
| 15:03 |
bshum |
#topic Action items from last meeting |
| 15:03 |
bshum |
#info dbwells will separate the cstore billing code into a separate bug; jeff and berick will help with testing |
| 15:03 |
kmlussier |
#info kmlussier is Kathy Lussier - MassLNC |
| 15:03 |
bshum |
Any report on that? |
| 15:03 |
berick |
#info dbwells posted collab/dbwells/1198465_cstore_fines_gen -- I have not done any testing yet |
| 15:04 |
jeff |
i can confirm that dbwells has a working branch with said separation and that i'm still planning to test -- sooner than later. |
| 15:04 |
eeevil |
#info eeevil = Mike Rylander, ESI |
| 15:04 |
Bmagic |
#info bmagic is Blake GH - MOBIUS |
| 15:04 |
dbwells |
I did split it, but I also did a bad job at bothering people about it. |
| 15:04 |
eeevil |
(I added a couple things to the agenda at the last moment ... sorry) |
| 15:04 |
bshum |
Alrighty, I think we can leave it off the meeting action items. Hopefully you guys can test it out before the beta cutoff? :) |
| 15:04 |
kmlussier |
We have it loaded on a test server at MassLNC, but I've only looked at it quickly. I'm planning to take a closer look this week. |
| 15:05 |
bshum |
#info Testing to continue. |
| 15:05 |
berick |
one sec... |
| 15:05 |
dbwells |
kmlussier: I did push an update earlier today to fix penalty generation. Just FYI. |
| 15:05 |
kmlussier |
dbwells: OK, thanks. I' |
| 15:13 |
gmcharlt |
but I want to ask others: any other pending stuff that folks would want to target for a March release? |
| 15:13 |
* bshum |
assumes the pound proxy example config is in reference to getting websockets happier with standard ports? |
| 15:13 |
gmcharlt |
yep |
| 15:14 |
bshum |
Sweet, gmcharlt++ # looking forward to testing those things out. |
| 15:15 |
bshum |
#info gmcharlt with new WIP for improving osrf_control --diagnostic and pound proxy example config for websockets in upcoming OpenSRF release. |
| 15:16 |
bshum |
... anything else on OpenSRF? |
| 15:16 |
bshum |
Do we want to assign an action for 2.4.1 cutting? |
| 15:17 |
|
bibliophylum joined #evergreen |
| 15:17 |
gmcharlt |
bshum: go for it |
| 15:17 |
gmcharlt |
you have... THE POWER |
| 15:38 |
gmcharlt |
berick: well, a quick review to be clear |
| 15:38 |
Bmagic |
Im sure no one looked at this one https://bugs.launchpad.net/evergreen/+bug/1174498 |
| 15:38 |
pinesol_green |
Launchpad bug 1174498 in Evergreen "Payment by billing type breakdown" (affected: 7, heat: 38) [Wishlist,In progress] - Assigned to Jeff Godin (jgodin) |
| 15:38 |
bshum |
jeffdavis: I actually got my Overdrive API test key last week. So I might look more closely soon, but not sure if it'll be in time for Friday :\ |
| 15:38 |
gmcharlt |
jeffdavis: I'd look at it when you mentioend it (last month? how time flies); have you made any tweaks since then? |
| 15:39 |
jeff |
Bmagic: i have concerns about payment by billing type interaction with some other billing changes -- it currently can be wrong about things with regard to future-dated overdues. |
| 15:39 |
jeffdavis |
gmcharlt: no, no changes since then |
| 15:42 |
gmcharlt |
jeffdavis: I think some concerns about work-for-hire were expessed -- but I think that's OK for it living as a contrib |
| 15:42 |
kmlussier |
We also have some people lined up here to look at 1410369. |
| 15:42 |
bshum |
In the interests of finishing up this meeting, I'm going to ask us to delay discussions on specific features / requests for 2.8 post-meeting. I'll give it a moment to wrap up last typing. |
| 15:42 |
gmcharlt |
berick: you've got a deal; I'll start testing that tomorrow |
| 15:43 |
berick |
gmcharlt++ # point me at the branch when it's published |
| 15:43 |
bshum |
berick: Anything else about 2.8 beta before we move on? |
| 15:43 |
gmcharlt |
berick: will do |
| 15:43 |
berick |
and kmlussier's testing is welcome :) |
| 15:43 |
berick |
bshum: one last thing. |
| 15:43 |
kmlussier |
berick: The more the merrier. :) |
| 15:44 |
berick |
i want to reiterate that any testing we can do with master between Friday and next Wednesday (beta release) is greatly apprecaited |
| 15:44 |
berick |
to reduce the amount of beta bugs |
| 15:44 |
berick |
or bug fix merges, for that matter |
| 15:45 |
berick |
i'll try to finalize the DB upgrade script well before wednesday, too, for eyes |
| 15:45 |
jeff |
berick++ |
| 15:45 |
bshum |
#info Beta release cut on Wednesday, February 25 |
| 15:45 |
bshum |
#help Please help test between beta deadline and cut to minimize bugs in beta. And also help with bug fixes in general. |
| 15:46 |
bshum |
berick++ |
| 15:46 |
bshum |
Alrighty. |
| 15:46 |
bshum |
#topic OPW Progress Report |
| 15:46 |
dbwells |
The OPW group would like to update the community on the progress of the Evergreen Style Guide project. Our intern julialima_ has joined us today to give the update. |
| 15:47 |
julialima_ |
We have been working very hard and we have made a lot of progress. |
| 15:47 |
julialima_ |
We are focused mainly in ensuring consistency and providing the best user experience we can. Of course it is a working progress, we are still testing some ideas and thinking new solutions for different situations. We still have 3 weeks until my internship is finished so we have a lot of time to try new things. |
| 15:48 |
julialima_ |
You can find the UI style guide in https://github.com/JuliaLima/Evergreen/tree/patch-1/docs/style_guide, remember that we are working on it, and also you can check in my blog for updates about our progress: http://lima-julia.tumblr.com/EG-style-guide. |
| 15:48 |
julialima_ |
Feel free to contact us and give your opinion, we need your feedback in order to improve our work, it is very important for us. |
| 15:49 |
kmlussier |
julialima_ / dbwells: I can't remember. Have the links to the blog and github repo been posted to the mailing list yet? |
| 15:49 |
bshum |
#link Style guide: https://github.com/JuliaLima/Evergreen/tree/patch-1/docs/style_guide |
| 15:49 |
bshum |
#link Blog: http://lima-julia.tumblr.com/EG-style-guide |
| 16:29 |
yboston |
berick: got a minute |
| 16:36 |
jeffdavis |
1/away afk |
| 16:46 |
|
julialima_ left #evergreen |
| 16:48 |
mdriscoll |
Dyrcona: I have been testing your code for LP#957466 today. Are you still here for a question? |
| 16:50 |
Dyrcona |
Yes. I'm here. |
| 16:50 |
mdriscoll |
If a record has a user in a 905 $u, an update to an existing record will use the 905 $u as the editor, but for a new record, the 905 $u is ignored. |
| 16:51 |
mdriscoll |
I'm not sure if it's important for update and create to work the same way. |
| 10:58 |
* jeff |
nods |
| 10:59 |
jeff |
down-then-over vs over-then-down |
| 10:59 |
jeff |
consistency is important there |
| 10:59 |
mdriscoll |
Dyrcona: I would be happy to test your branch when you get it done |
| 11:01 |
dbwells |
Okay, feel free to keep talking about layout, but we have more questions! :) |
| 11:01 |
jeff |
do the single row and grid examples allow presenting more information when you're looking at the "form" not because you're editing, but because you're reviewing / seeking information? item status single-row display vs item attribute editor single-row display being one example -- would we consider moving the item status display move to single column? |
| 11:03 |
dbwells |
jeff: That's a good point. I don't have a good answer, but I do think the concept of dual purpose display/edit screens should be carefully considered. |
| 12:36 |
|
maryj joined #evergreen |
| 12:38 |
goood |
dbs: or they could just consider the "collab" branch as the "master" to target, and submit branches against that. not seeing the difference, really |
| 12:41 |
dbs |
Right. So why aren't bug fixes and small features being merged to master on a regular basis again? |
| 12:42 |
goood |
dbs: because folks don't test (save kmlussier) or merge, and I get smacked whenever I merge my own code, and get the side eye when I merge my coworkers' code without further review |
| 12:44 |
goood |
s/further review/non-esi review, for whatever personal reasons various folks may have/ |
| 12:49 |
|
nhilton joined #evergreen |
| 12:57 |
|
bmills joined #evergreen |
| 13:09 |
mrpeters |
Alrighty guys -- I'm in Action/Trigger hell and have come to beg for mercy! See http://pastie.org/9945103 -- an event_def to mark an item lost 3 hours after it goes overdue. Nothing fancy, pretty similiar to the stock 90 Day Lost notice. Each time the event runs, it ends with a state 'error' but I'm struggling to find more information about what caused the error. Pertinent osrfsys logs are at http://pastie.org/private/l62y4g3wodwvxhw2iwrdg -- Eve |
| 14:13 |
dbwells |
My sense when he mentioned it last week was that he felt obligated to work on it since he had already done some work on it. My guess is he'll be very happy to see you've completed it. |
| 14:15 |
Dyrcona |
I felt obligated to work on it when a Backstage import busted up someone's work. :) |
| 14:15 |
Dyrcona |
That's cool. Collaboration is nice. |
| 14:24 |
Dyrcona |
While testing that change, I noticed something unusual. |
| 14:25 |
Dyrcona |
Any time I typed a key in the marc editor, regular or flat text, while editing a record to import, a JavaScript error window would pop up. |
| 14:26 |
Dyrcona |
TypeError: tab is undefined |
| 14:26 |
Dyrcona |
Still doing it, actually. |
| 14:26 |
Dyrcona |
MARC edit works fine on regular bibs. |
| 14:27 |
Dyrcona |
Guess I'll do a git clean and see what happens. |
| 14:27 |
kmlussier |
dbs: Thanks for letting me know about mlnc4. I'll fix it up now. |
| 14:28 |
dbwells |
Dyrcona: I saw that too, when testing master with a 2.7 client. I know it stems from some changes ldw wrote a while back, and I thought it might be related to me needing a new client. |
| 14:28 |
dbwells |
Are you seeing it with a master client? |
| 14:28 |
Dyrcona |
Yes. |
| 14:29 |
Dyrcona |
My script builds a fresh client when I build all of Evergreen. |
| 14:29 |
Dyrcona |
Guess that's a bug. |
| 14:45 |
|
Tony__ left #evergreen |
| 14:46 |
|
akilsdonk joined #evergreen |
| 14:50 |
Dyrcona |
Hmmm. I have that commit, so something about it must still be wrong. |
| 14:53 |
kmlussier |
dbs / eeevil: Would it be worthwhile to discuss the web client merging at the next dev meeting? I don't know what the answer is, but I personally would love to see the code make it into master faster. |
| 14:54 |
kmlussier |
One thing I'm up against is that I have a few people on hand to help test the circ changes, but we aren't geared up to test cataloging yet. However, I don't really know if the other circ code in that collab branch is dependent on some of the cataloging features that come before it. |
| 14:55 |
kmlussier |
So signoffs there may not be helpful. |
| 14:56 |
kmlussier |
And mlnc4.mvlcstaff.org is up and running again. |
| 14:57 |
* kmlussier |
should add something to her calendar to update it monthly. |
| 15:03 |
Dyrcona |
Well, the diff isn't telling me much, and neither is JavaScript console. |
| 15:03 |
Dyrcona |
I may have to call on Venkman. |
| 15:04 |
Dyrcona |
If he's still around somewhere. |
| 16:22 |
kmlussier |
berick: Have you set a meeting date yet? |
| 16:37 |
kmlussier |
@quote random |
| 16:37 |
pinesol_green |
kmlussier: Quote #94: "<bshum> we should do something about those cupcakes - they're going to go to waste" (added by csharp at 05:57 PM, September 25, 2014) |
| 16:38 |
kmlussier |
bshum does love his cupcakes |
| 17:04 |
|
nhilton joined #evergreen |
| 17:09 |
|
artunit joined #evergreen |
| 17:10 |
kmlussier |
Must be Friday afternoon. I had two client windows open, and I tried testing the new feature on the system that did not have the code loaded. Explains why it didn't work. |
| 17:13 |
|
mmorgan left #evergreen |
| 18:13 |
|
mrpeters left #evergreen |
| 18:20 |
|
dreuther joined #evergreen |
| 11:11 |
csharp |
berick: ewww |
| 11:11 |
kmlussier |
berick++ |
| 11:18 |
Dyrcona |
heh |
| 11:22 |
berick |
eeevil: kmlussier: going to merge working/user/kmlussier/web-client-sprint1-bug-fixing-signoff1 (plus 9804b5c54d12e6f2d1ae7b907a0de80d84ff978f) after light testing. any issues/concerns before I do that? |
| 11:24 |
kmlussier |
I have no concerns |
| 11:25 |
berick |
note for later, we should make the grid less chatty in the console. |
| 11:25 |
berick |
kmlussier: thanks |
| 11:25 |
goood |
berick: just concerns over rebasing the remainder... but that can be a tomorrow problem, I suppose |
| 11:29 |
jeff |
oh and of course the lovely thing about running services on high ephemeral ports... |
| 11:29 |
jeff |
(well, ONE of the things)... sometimes someone else gets there first. :P |
| 11:29 |
berick |
goood: rebasing collab/miker/web-client-sprint1-bug-fixing-rebased-collab ? |
| 11:33 |
berick |
just tried an expirement, rebasing that ^-- to my about-to-merge master branch. i haven't tested it, but it rebased without conflict. |
| 11:33 |
berick |
so there's that |
| 11:42 |
hopkinsju |
Does Evergreen actually use the quality field in biblio.record_entry? I can't think of anything, and we were thinking about reusing that column. |
| 11:44 |
jeff |
hopkinsju: have you considered biblio.record_note? |
| 11:44 |
|
sandbergja joined #evergreen |
| 11:55 |
bshum |
mmorgan: Now you're getting it! :) |
| 11:55 |
kmlussier |
Yeah, probably. I don't think it matters much. I guess I've just been looking at them far too much over the past year. |
| 11:55 |
berick |
bshum: git filter-branch -f --msg-filter "sed '0,/^/s//LP\#1402797 /1'" origin/master.. |
| 11:56 |
bshum |
If you come up with better categories for things, I'm happy to help test/push that along. One of the things I always wish I had more time to do would be to go back and actually add meaningful descriptions to all YAOUS entries. |
| 11:56 |
berick |
(then had to clean up a few double-tagged commits) |
| 11:56 |
bshum |
berick: Ooooh, fancy! |
| 11:56 |
kmlussier |
bshum: Yeah, adding better descriptions has crossed my mind too. |
| 11:56 |
* berick |
credits gmcharlt with the original suggestion way back when |
| 11:59 |
yboston |
Hello, I can't remember what the rules are for the deadlines we use for having a code change make it to the next release. I see the calendar says that next Friday is the "2.8 Beta Cut-Off" I can't remember what that one is for, I think it is meant for testing and signing off bug fixes? I beleive that the previous "2.8 Feature LP Target Deadline" is for havign signed off changes make it to the beta? |
| 11:59 |
bshum |
kmlussier: "Charge lost on zero" confused me for years. Still does sometime... |
| 12:00 |
berick |
yboston: the 2.8 cut off is for new features only. we *always* accept bug fixes |
| 12:00 |
bshum |
bug_fixes++ |
| 12:00 |
bshum |
:) |
| 12:00 |
yboston |
berick: sorry, that was the one rule I did remember, that bug fixes are always accepted :( |
| 12:00 |
kmlussier |
Is it difficult to update records that are provided in the Concerto set? I keep thinking it would be nice to add prices for all of the copies in there. |
| 12:01 |
kmlussier |
So that when you mark them lost in testing, a bill is added to the patron record. |
| 12:01 |
berick |
yboston: no worries, did I answer your question, though? |
| 12:01 |
bshum |
kmlussier: I'm sure it's not hard to do that. |
| 12:01 |
yboston |
so is there still time to submit (signed off) changes for 2.8? |
| 12:04 |
berick |
yboston: documenting / targeting new features in launchpad. the absence of such documention does not prevent new features getting into 2.8, though |
| 12:04 |
berick |
the purpose was to get as much info out as early as possible |
| 12:04 |
yboston |
berick: thank you very much, I had assumed I missed the boat on a new feature |
| 12:06 |
berick |
yboston: speaking of, do you still have any expectation of testing bug #1171984 ? |
| 12:06 |
pinesol_green |
Launchpad bug 1171984 in Evergreen "add support in Vandelay for overlaying authorities during import using match sets" (affected: 5, heat: 22) [Wishlist,Confirmed] https://launchpad.net/bugs/1171984 |
| 12:06 |
yboston |
berick: so sorry |
| 12:07 |
pinesol_green |
Showing latest 5 of 45 commits to Evergreen... |
| 12:08 |
berick |
and I thought we were immune down here ;) |
| 12:08 |
berick |
yboston++ |
| 12:09 |
|
bmills joined #evergreen |
| 12:10 |
kmlussier |
berick: If yboston doesn't get to that one, I might be able to. I was just looking at it today. |
| 12:10 |
kmlussier |
Or, I should say, eyeing it as a possible thing to test. |
| 12:11 |
berick |
kmlussier: awesome |
| 12:11 |
* berick |
pushed a rebased-to-master branch |
| 12:11 |
yboston |
kmlussier: I will let you know if I start testing it so you don't have to, then again maybe the more tsts the better |
| 12:13 |
|
sandbergja joined #evergreen |
| 12:13 |
* berick |
needs to come up w/ a conference proposal |
| 12:13 |
|
akilsdonk joined #evergreen |
| 12:37 |
geoffsams |
Of Course I haven't looked at the specific pages that have been brought up either |
| 12:41 |
|
maryj joined #evergreen |
| 12:47 |
kmlussier |
gsams: 98/100 sounds pretty good |
| 12:48 |
gsams |
kmlussier: That's for the advanced search page at least |
| 12:49 |
gsams |
Since I'm 4 days after an upgrade I haven't had time to do more testing |
| 12:49 |
kmlussier |
I'm interepreting that as 98 out of 100. |
| 12:49 |
gsams |
that is correct |
| 12:49 |
gsams |
The only usability changes it suggested were related to tap targets spacing and size |
| 12:52 |
gsams |
basically, Basic Search and Browse the Catalog are too close, The search input boxes are too close, and we have a link at the bottom that is too close to other things |
| 12:56 |
goood |
hopkinsju: quality is use for lead metarecord selection. can you give some context to your "scoring algorithm"? what are you scoring, how do you interpret a score value, and what questions are answered by the score |
| 13:00 |
|
krvmga joined #evergreen |
| 13:01 |
bshum |
Hmm, c4l lightning talk about "keyboard accessibility" makes me think about how much testing we're doing on the catalog / web client. |
| 13:01 |
bshum |
So much stuff to test. |
| 13:03 |
|
sandbergja left #evergreen |
| 13:05 |
kmlussier |
bshum: Well, there currently isn't much to test in the web client in terms of keyboard accessibility. I don't think the keyboard shortcuts have been included yet. |
| 13:06 |
kmlussier |
yboston: Are you still around? |
| 13:07 |
|
afterl joined #evergreen |
| 13:33 |
yboston |
kmlussier: I am back at my desk |
| 13:34 |
goood |
berick: the removal of dropdown-toggle on the actions in the grid (commit d37e4d0bba) means, for ng 1.2.22 (on webby), that the menu stays open after the launching the action. Is that just an "old ng" problem? |
| 14:11 |
kmlussier |
yboston++ |
| 14:11 |
yboston |
bug #1171984 |
| 14:11 |
pinesol_green |
Launchpad bug 1171984 in Evergreen "add support in Vandelay for overlaying authorities during import using match sets" (affected: 5, heat: 22) [Wishlist,Confirmed] https://launchpad.net/bugs/1171984 |
| 14:12 |
yboston |
this is a feature that needs to be tested out for inclusion in EG 2.8. Again there is one week left to have someone test it and "sign off" on it |
| 14:12 |
yboston |
Kathy or I will try to do the signing off |
| 14:13 |
yboston |
I am bringing this up partially to showcase how improvements are made to EG |
| 14:13 |
yboston |
that is all for me on authoritites. I can move to the nexr past meeting's action item |
| 14:13 |
|
Cybrarian joined #evergreen |
| 14:14 |
yboston |
moving on |
| 14:14 |
yboston |
3) jeffdavis to put out a call for current patron loading scripts that are already in use. |
| 14:14 |
yboston |
I am not sure if jeffdavis is available now, will wait a bit before defring |
| 14:15 |
yboston |
moving on |
| 14:15 |
yboston |
#action jeffdavis to put out a call for current patron loading scripts that are already in use. |
| 14:15 |
yboston |
at this point there are now more outstanding past meetign action items |
| 14:15 |
yboston |
we can now shift to talk about other issues |
| 14:16 |
yboston |
for example, thoughts on the earlier discussion on call number search |
| 14:16 |
yboston |
or something completely different |
| 14:16 |
Cybrarian |
PAC flavors? |
| 14:16 |
DonB__ |
I sent out a couple of emails to the list regarding call numbers |
| 14:17 |
DonB__ |
It seems there is broad consensus in two areas |
| 16:52 |
* Dyrcona |
typoed Integer as Interger last night. |
| 16:52 |
Dyrcona |
That'll do it. |
| 16:52 |
RoganH |
I did it once before which is why I suddenly thought of it. |
| 16:53 |
RoganH |
I discovered that one before testing though. Ug. |
| 16:57 |
RoganH |
That did it. Thanks for the ideas all. |
| 16:57 |
RoganH |
Dyrcona++ |
| 16:57 |
RoganH |
kmlussier++ |
| 17:04 |
gsams |
kmlussier++ |
| 17:04 |
kmlussier |
gsams: Awesome! |
| 17:04 |
RoganH |
Good night! |
| 17:07 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:07 |
|
mdriscoll left #evergreen |
| 18:02 |
|
bbqben joined #evergreen |
| 18:12 |
|
mrpeters left #evergreen |
| 05:09 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 07:32 |
|
graced joined #evergreen |
| 07:53 |
|
rjackson_isl joined #evergreen |
| 07:55 |
|
akilsdonk joined #evergreen |
| 10:59 |
berick |
with subsequent calls, it compares the previous value to the new value |
| 10:59 |
berick |
if they are different, it calls the $watch function |
| 10:59 |
berick |
that was provided by us |
| 10:59 |
phasefx |
rock |
| 10:59 |
phasefx |
berick: do you mind if I pick those into the sprint1 collab branch? |
| 11:00 |
phasefx |
(after testing) |
| 11:00 |
berick |
phasefx: no, i don't mind |
| 11:00 |
phasefx |
rock |
| 11:00 |
berick |
also, re: $watch, that's one reason you want to avoid using $watch unless necessary, because it causes extra copies of objects to have to persist. |
| 14:06 |
eeevil |
(sorry if that seems overly blunt ... just meant to convey my thoughts succinctly ;) ) |
| 14:06 |
|
DPearl joined #evergreen |
| 14:09 |
eeevil |
kmlussier: unrelated to the web client, I pushed a change for the don't-change-0-balance-lost-xact branch, per the situation you identified ... not sure if you saw that |
| 14:10 |
kmlussier |
eeevil: Sure, I'm okay with pushing them in as is because, as far as I know, nobody is using the web client yet. I'm just having a hard time managing my own testing of the new code. |
| 14:10 |
kmlussier |
eeevil: I did see that. Thanks! :) |
| 14:11 |
* bshum |
has been likewise confused by the status of that collab branch |
| 14:11 |
bshum |
Is there a specific block of commits we should focus on getting into master first? Or are we just expecting to push the whole thing enmasse? |
| 14:11 |
kmlussier |
Also, all the code I've reviewed so far has improved the web client, so +1 to getting it in. |
| 14:12 |
* bshum |
also assumes none of it is being backported to rel_2_7 then. |
| 14:12 |
bshum |
Though, they are "bug fixes"? Meh |
| 14:14 |
eeevil |
kmlussier: right. IIRC, the consensus was folks should wait until they can do OneBigSwitch(tm) to the web client. now, whether folks will... :) |
| 14:14 |
* kmlussier |
doesn't remember that consensus |
| 14:15 |
kmlussier |
Would it help if I signed off on the commits I already tested? |
| 14:15 |
kmlussier |
I know I had further feedback on some of those commits, but I only saw improvements in what I tested. |
| 14:15 |
DPearl |
I'm attempting to build a Concerto database; it worked some time ago, but there was a concerto.sql file to read in. Things have changed and concerto.sql is no longer there. The eg_db_config.pl is gone and replaced by an .in file, so current instructions to build the db don't work! Where should I look for the new doc? |
| 14:15 |
eeevil |
kmlussier: I imagine it would, or at least note them. I'm not sure how berick wants to handle that merge |
| 14:18 |
bshum |
eeevil: Can sprint1 fixes be un-entangled from the collab from sprint2 stuff? Or do we have to test all the things before the branch can be moved forward in any way? |
| 14:18 |
kmlussier |
OK, I'll do some sign-offs. But I still would like to advocate for putting the new cataloging code into a different branch from the circulation fixes. |
| 14:19 |
kmlussier |
Ha ha. What bshum said. |
| 14:19 |
* bshum |
is just trying to help, not trying to be difficult. I just work better in more concrete blocks of things to look at. |
| 14:42 |
eeevil |
the cataloging changes really need everything else (or, substantially), and since nobody has jumped in to help with coding things they find broken, I chose to reduce the overhead of making progress. I can start a new branch called "sprint2" if that would help, but it'll just be a clone of the sprint1 branch. will it provide a lot of help to remove any sprint2 code in another copy of the collab branch? (I'll personally |
| 14:42 |
eeevil |
consider that branch a dead end, fwiw, because I don't see much point in shuffling commits all over the place when there's really only going to be just a couple developers working in tight coordination) |
| 14:44 |
eeevil |
now, if folks started to show an interest in getting involved in either initial coding of features beyond the current plan, or bug fixing (to learn angularjs, or just because), then the multi-branch-parallel-to-master world would make sense |
| 14:52 |
kmlussier |
Heh, I don't think anyone wants me diving into angularjs, but I'll do what I can to sign off on stuff as soon as I test it, which might make things more manageable. |
| 14:54 |
Dyrcona |
My bosses have other ideas how I should spend my time right now. |
| 14:54 |
dbs |
Having small branches is probably the best way for people to learn how to start digging in. |
| 15:11 |
eeevil |
dbs: that's probably true when the small branches are tracking a canonical master branch, but in this case we're talking about (at least) two branches tracking both master and another "fix" branch, which has to track master, too, leading to periodic manual, cascading rebases ... AFAICT. I can do that or write code :). if folks think of the collab branch as the "master for web client -- for now", then they can branch from |
| 16:00 |
kmlussier |
Yikes! beta cutoff is 1 1/2 weeks away? |
| 16:13 |
gmcharlt |
kmlussier: time flies when we're having fun |
| 16:13 |
kmlussier |
gmcharlt: Fun? |
| 16:13 |
gmcharlt |
yes! |
| 16:13 |
gmcharlt |
docs! \o/ |
| 16:13 |
gmcharlt |
patches! \o/ |
| 16:14 |
gmcharlt |
regression tests \o/ |
| 16:14 |
gmcharlt |
too much coffee! \o/ |
| 16:16 |
dbwells |
I was still thinking the cutoff was the 18th, but I now see it got pushed to the 20th. Two extra days! \o/ |
| 16:51 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:04 |
|
eeevil joined #evergreen |
| 17:05 |
|
sarabee joined #evergreen |
| 17:11 |
|
mmorgan left #evergreen |
| 00:22 |
|
abowling joined #evergreen |
| 04:53 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 07:18 |
|
jboyer-isl joined #evergreen |
| 07:45 |
|
graced joined #evergreen |
| 07:48 |
|
akilsdonk joined #evergreen |
| 10:37 |
|
maryj joined #evergreen |
| 10:46 |
|
sarabee joined #evergreen |
| 11:13 |
|
TaraC joined #evergreen |
| 11:44 |
* kmlussier |
is learning more than she ever wanted to know about QA. |
| 11:45 |
kmlussier |
I know we are doing build tests and some unit testing, especially after we put some of berick's guidelines from http://evergreen-ils.org/dokuwiki/doku.php?id=dev:contributing:qa into place. |
| 11:45 |
kmlussier |
But are we doing any kind of functional testing in an automated fashion? |
| 11:47 |
phasefx |
kmlussier: are you thinking UI testing? |
| 11:47 |
phasefx |
we do have the "live" tests against a running system |
| 11:48 |
kmlussier |
phasefx: No. I'm thinking, given this input the system should be returning this. |
| 11:48 |
kmlussier |
I saw the "live" tests, but wasn't exactly sure what they did. |
| 11:49 |
tsbere |
kmlussier: I think the live tests are "Given this input and a known DB state, the system should be returning this" |
| 11:50 |
kmlussier |
OK, so that's what I was looking for. I think. :) |
| 11:50 |
tsbere |
(which doesn't mean that any UI elements work, in that case, but would cover backend calls) |
| 11:50 |
phasefx |
and the unit tests are "given this input, this code chunk should always return this" |
| 11:53 |
kmlussier |
Hontestly, the way you describe it, I don't see a difference between the unit and live tests. |
| 11:55 |
tsbere |
kmlussier: The unit tests are for things that don't require the network to be up. "This utility function should always do the same thing given the same input and doesn't talk to anyone else while doing so" |
| 11:55 |
phasefx |
kmlussier: the unit tests are testing pieces of code that are very self-contained.. the live tests require a larger environment in a known state (a running system with stock test database) |
| 11:56 |
phasefx |
kmlussier: so you end up testing some interaction between multiple moving parts |
| 11:59 |
kmlussier |
phasefx: So is that the same as integration testing? |
| 11:59 |
phasefx |
kmlussier: I think so |
| 12:02 |
|
mmorgan joined #evergreen |
| 12:12 |
gsams |
Just upgraded from 2.3.5 to 2.7.3 and we are noticing problems with Overdrive authentication. The logs are showing successful attempt to access but Overdrive appears to be blocking anyway. |
| 12:17 |
|
bmills joined #evergreen |
| 12:19 |
kmlussier |
Agreed! Let it be resolved that csharp should get rest. :) |
| 12:20 |
jeff |
gsams: likely OverDrive was relying on the patron screen message field in the SIP response being "OK" -- that is no longer sent. |
| 12:21 |
kmlussier |
gsams: Congrats on your upgrade! Unfortunately, I now no longer have a go-to place to test an early release of Evergreen to verify whether a bug is new or not. ;) |
| 12:21 |
jeff |
...and I always encourage folk to NOT use SIP2 for external vendor auth, but I realize it's hard to change because inertia. |
| 12:23 |
kmlussier |
phasefx: OK, so here's my follow-up question. How do we know that we're testing all the right things with the live tests? Would it be helpful for an end user like myself to supply a set of common scenarios that should be part of the live tests? |
| 12:23 |
gsams |
kmlussier: Hehe, I wish I could still be there for that, but alas we needed these fresh new features and to actually stay up to date. |
| 12:23 |
jeff |
kmlussier: ideally, those scenarios are the input to the kinds of tests you speak of. |
| 12:24 |
kmlussier |
I just happen to have a set of test cases around overdue fines and billing that I use quite frequently. |
| 12:24 |
* jeff |
chuckles |
| 12:24 |
gsams |
jeff: now I'm curious, what would you suggest. I've always thought SIP2 was odd, but I'm not really sure why I've felt that way. I don't know enough about it to begin with. |
| 12:25 |
* jeff |
just threw a dozen or so people at the rel_2_7 (plus some cherry-picked fixes) web staff client with only a few things that broke (mostly due to permission-related quirks) |
| 12:32 |
gsams |
Though, I like to do things the difficult way, so I wouldn't be opposed to conversion |
| 12:33 |
tsbere |
jeff: Given some of the alternatives (or lack thereof) some vendors provide to SIP2 I am not sure there is a good way to avoid starting. >_> |
| 12:34 |
jeff |
tsbere: i'm trying to gather some information on those choices -- especially for those we don't have a relationship with. i'd be interested in what you have, if you don't mind sharing. |
| 12:34 |
berick |
jeff++ # browser client testing |
| 12:35 |
tsbere |
jeff: Most of the ones I know of off the top of my head (AKA, people I actually dealt with, rather than non-technical people dealing with them first and deciding on SIP2 without ever finding out about other options) were "SIP2, don't actually validate against your system, or provide us with a URL that spits out custom specific-to-us output that we aren't willing to negotiate much on" |
| 12:35 |
tsbere |
jeff: Oh, and for half of them the URL couldn't be https. <_< |
| 12:45 |
|
sandbergja joined #evergreen |
| 12:46 |
|
sandbergja joined #evergreen |
| 12:46 |
|
sandbergja left #evergreen |
| 12:50 |
jeff |
berick: thanks! I'm immediately being pulled into something else today, but I've a handful of things to follow up on, and we're planning to give all staff test accounts and have them start kicking the tires later this week. |
| 12:50 |
jeff |
(just with concerto as a dataset, to start) |
| 12:52 |
jeff |
is anyone here having staff use the web staff client on a production system yet? |
| 12:52 |
bshum |
jeff: We aren't planning to use any web client bits in active production until more modules are complete. |
| 12:52 |
bshum |
By more I mean specifically cataloging and perhaps even acquisitions :\ |
| 12:53 |
jeff |
so no general usage at service desks for patron account management, placing holds, etc. |
| 12:54 |
bshum |
Not for us anyways. |
| 12:54 |
bshum |
At least not yet. |
| 12:54 |
* bshum |
imagines everyone will brave this stuff differently. |
| 12:57 |
kmlussier |
jeff: Nobody is using it here yet. Based on our preliminary testing, I think there is more work to be done before front-line staff will be ready to use it. eeevil and berick have been making good progress on bug fixes recently, so maybe soon. :) |
| 12:58 |
jeff |
i've applied some of those fixes to this test system :-) |
| 12:58 |
* bshum |
might also wait to see if there's anything that can be done as far as running websockets on different ports. |
| 12:58 |
bshum |
Or rather, not running it on separate ports |
| 12:58 |
kmlussier |
However, I think we'll need keyboard shortcuts before our circ staff is ready to use it. They heavily rely on the keyboard. |
| 13:00 |
bshum |
And they don't always consult us when they change their equipment either. |
| 13:00 |
bshum |
And suddenly the ILS stops working. |
| 13:00 |
bshum |
brb, c4l break time :) |
| 13:00 |
* tsbere |
should try and get websockets working again for testing |
| 13:01 |
kmlussier |
tsbere: That would be great. I would love to try it out on a non-Concerto database. |
| 13:02 |
tsbere |
kmlussier: And the system(s) I was going to see about getting it to work on.......run on Concerto databases. |
| 13:02 |
kmlussier |
tsbere: But it's a first step, right? :) |
| 12:37 |
csharp |
damn - I can't find the problem |
| 12:37 |
csharp |
fieldmapper looks right, rocit.age_protect <-> crahp.id |
| 12:44 |
csharp |
@hates |
| 12:44 |
pinesol_green |
csharp hates dojo_hold_policies_interface; SIP; when libraries purchase third party products without testing and blame Evergreen for it not working; reports; the fact that the Base Filters is unnecessarily greyed out when applying an Aggregate Filter and vice versa; evil; reports more; reports even moar; details; reports even more; the fact that the Base Filters is unnecessarily greyed out (1 more message) |
| 12:45 |
csharp |
@more |
| 12:45 |
pinesol_green |
csharp: when applying an Aggregate Filter and vice versa even more; having to teach SIP2 client vendors about the SIP2 specification; troubleshooting reports; money reports; and marc |
| 12:45 |
|
mmorgan1 joined #evergreen |
| 15:12 |
|
julialima_ left #evergreen |
| 15:19 |
|
mmorgan1 joined #evergreen |
| 15:34 |
|
kmlussier joined #evergreen |
| 16:04 |
* jeff |
is seeing "grunt test" fail in rel_2_7 and master at present |
| 16:04 |
jeff |
since I haven't run these tests before, I'm not sure if I'm doing something wrong. |
| 16:06 |
berick |
got a paste? |
| 16:06 |
jeff |
output is here: https://gist.github.com/jeff/45f872e1899ba6217cd0 -- it obviously can't find/load angular, but i'm not sure where to start |
| 16:08 |
jeff |
oh hey, and now it works. |
| 17:06 |
mrpeters1 |
sorry, i got distracted and didn't finish my thought there -- should a 1 hour overdue have a 1 hour processing delay? |
| 17:06 |
mrpeters1 |
wouldn't that cause a notice not to be sent until it was actually 2 hours overdue? also, the Max Event Validity -- its set to 2 hours -- if a cron job failed to run to "run pending" within that 2 hour window, would that cause the notice to fail to be sent? |
| 17:10 |
|
mrpeters1 left #evergreen |
| 17:11 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:16 |
|
mmorgan1 joined #evergreen |
| 17:20 |
|
abowling joined #evergreen |
| 17:22 |
|
mmorgan1 joined #evergreen |
| 12:48 |
gmcharlt |
goood: http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/collab/gmcharlt/better_osrf_control_diagnostic |
| 13:02 |
kmlussier |
Woo hoo! Booked my hotel room for the conference. :) |
| 13:08 |
|
nhilton joined #evergreen |
| 13:13 |
phasefx |
berick: I was trying a variant of the script in bug#1268619 to test websockets prior to installing anything EG (including dojo). And I found I had to include opensrf_ws.js manually, and after calling .send(), I also had to call .session.send_ws() on the request object. Does that sound crazy? |
| 13:16 |
phasefx |
http://paste.lisp.org/display/145683 |
| 13:19 |
phasefx |
the manual part doesn't sound crazy, the path is hard-coded in opensrf.js |
| 13:21 |
phasefx |
okay <rubber ducking>, so if I change the transport from OSRF_TRANSPORT_TYPE_WS_SHARED to OSRF_TRANSPORT_TYPE_WS, I can just do req.send() and it works |
| 13:24 |
berick |
phasefx: OSRF_TRANSPORT_TYPE_WS_SHARED is currently disabled. send_ws() is the underyling handler for OSRF_TRANSPORT_TYPE_WS. |
| 13:24 |
berick |
so even though it was set to OSRF_TRANSPORT_TYPE_WS_SHARED, you were forcing it to run as non-shared by calling send_ws() directly |
| 13:25 |
berick |
when you changed to OSRF_TRANSPORT_TYPE_WS, the send_ws() was no longer needed |
| 16:28 |
|
nhilton_ joined #evergreen |
| 16:41 |
csharp |
amazing... with dbwells's fix with jboyer-isl's modifications, my nearly two-hour query dropped to 4 seconds |
| 16:45 |
|
nhilton joined #evergreen |
| 16:48 |
dbwells |
csharp: Sorry for being lazy on the COALESCE, I only did a quick test on lower ids which had a legacy_circ_count entry (which should be, I think, the only number needing a COALESCE). |
| 16:56 |
dbwells |
This should work: http://pastie.org/9893249 |
| 17:01 |
dbwells |
I also kept COUNT(*) over COUNT(distinct id) because 1) there are no joins involved, so DISTINCT doesn't do anything for us here, and 2) COUNT(*) is generally recommended when simply counting rows, as it lets the planner pick whatever it thinks is best (which will probably be 'id', but anyway... at least that's what I've been told). |
| 17:05 |
dbwells |
In any case, the changes I'm advocating will not affect performance in any measurable way, I think it just helps readability. |
| 17:06 |
|
vlewis_ joined #evergreen |
| 17:09 |
|
mmorgan left #evergreen |
| 17:16 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:30 |
csharp |
dbwells: excellent - thank you |
| 17:31 |
csharp |
I'll file a bug on this just to get it on the record |
| 17:32 |
dbwells |
sounds like a plan |
| 09:09 |
bshum |
jeff: How did those slip past? |
| 09:11 |
jeff |
bshum: staff-side patron editor has no checks for duplicate holdshelf alias. We didn't put effort into closing that loophole. |
| 09:11 |
bshum |
Ahh. |
| 09:11 |
jeff |
bshum: So at least one of each group is staff or asked staff to set their alias to that value. |
| 09:11 |
|
sarabee joined #evergreen |
| 09:12 |
jeff |
looking, the duplicate catwoman is a test/training account's alias. |
| 09:12 |
|
eeevil joined #evergreen |
| 09:18 |
mmorgan |
jeff: speaking of popular - what are you looking at to get the "most popular" titles on your stats page? Circs? Holds? A combination? |
| 09:36 |
jeff |
mmorgan: i think i owe you an email regarding that, too! |
| 10:04 |
eeevil |
pcrud.js is completely unchanged (now... I was messing with it last night) |
| 10:11 |
berick |
eeevil: ok, was able to reproduce locally |
| 10:11 |
* berick |
pokes |
| 10:12 |
eeevil |
berick: I suspect, but haven't tested, that it happens with every pcrud CUD call |
| 10:31 |
|
dreuther joined #evergreen |
| 10:34 |
|
dMiller_ joined #evergreen |
| 10:36 |
berick |
eeevil: found it. good stuff |
| 10:36 |
berick |
http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=commitdiff;h=1b25f487c0acdfa000becbccac6943e24bc0ca77 |
| 10:36 |
berick |
i'll open an LP |
| 10:37 |
berick |
this code path (per-tab connections) got much less testing than the global WS connection code, which had to be disabled, because chrome started acting funky with global connections |
| 10:37 |
berick |
will have to revisit that.. |
| 10:42 |
|
mrpeters joined #evergreen |
| 10:46 |
berick |
https://bugs.launchpad.net/opensrf/+bug/1418613 |
| 10:46 |
pinesol_green |
Launchpad bug 1418613 in OpenSRF "Per-tab websocket JS connections can re-send messages" (affected: 1, heat: 6) [Undecided,New] |
| 11:01 |
bshum |
berick: I'm adjusting that entry if I can so that it points at OpenSRF 2.4.1 |
| 11:01 |
bshum |
Since 2.4.0 was already released last month |
| 12:09 |
bshum |
gmcharlt: Sorry I'll fix up 2.7.3 too and create a 2.7.4 for everyone. |
| 12:09 |
bshum |
Old, old bug. Back from my 2.0 days :( |
| 12:10 |
gmcharlt |
bshum: ah, great - thanks for catching that! |
| 12:11 |
bshum |
gmcharlt: I'm not sure if dbwells has cut 2.6.6. He might not have yet and it could still get tested and applied there. But more than likely I expect we'll keep that lock-step on bug fixes in general. |
| 12:11 |
bshum |
gmcharlt++ # poking at ancient bugs |
| 12:12 |
gmcharlt |
bshum: that's fine - that bug gets hit rarely enough, I think, that testing doesn't need to be super-rushed |
| 12:12 |
gmcharlt |
our_customers++ # running into ancient bugs and KEEPING THEM ALIVE |
| 12:13 |
bshum |
Reported by Ben Shum on 2011-12-15, zomg :( |
| 12:13 |
* bshum |
can't believe how long it's been :\ |
| 12:14 |
bshum |
Stompro++ # helping to announce new release on list with helpful notes and links! |
| 14:41 |
remingtron |
I think I did, but probably asked bshum first |
| 14:41 |
remingtron |
basically, he wrote the instructions draft, and he wants some feedback |
| 14:42 |
remingtron |
maybe he/we should ask the general and dev lists for help on that |
| 14:42 |
yboston |
ats ome point I need to build a new test server to try out the web client, I can give him some feedback at that point |
| 14:43 |
yboston |
I can put an action item to reach out to him to see if this has been included in master, and if others have been able to run his intructions |
| 14:43 |
yboston |
they look fine to me, bu I have nos tested them yet |
| 14:43 |
bshum |
It has not been added up to master yet. |
| 14:43 |
bshum |
Sorry, stepped away a sec there. |
| 14:44 |
bshum |
I'll work on it with more devs in the coming weeks. |
| 14:44 |
yboston |
I can reach out to you when I am ready to build a new VM to test the web client, to make sure I use the latest version |
| 14:45 |
yboston |
is there a git branch that has these instructions? |
| 14:45 |
bshum |
yboston: I haven't put all the changes into a git branch yet. That's also on my to-do list I think. |
| 14:45 |
yboston |
no worries |
| 14:46 |
yboston |
I can move on, but want suggestions on what action item if any we should leave for next meeting for this? |
| 15:02 |
remingtron |
kmlussier: are you able to make the wiki page for 2.8 features again? |
| 15:03 |
kmlussier |
Yes, I can. |
| 15:03 |
kmlussier |
Sorry, I was pulled into another discussion. |
| 15:03 |
* gmcharlt |
jumps in to mention that I intend to provision the doc testing server next week |
| 15:03 |
gmcharlt |
sorry for hte delay |
| 15:03 |
kmlussier |
gmcharlt++ |
| 15:04 |
yboston |
no problem, you have a lot on your olate |
| 15:04 |
yboston |
*plate |
| 15:23 |
bshum |
And it doesn't handle things like links. |
| 15:23 |
bshum |
At least, it didn't work for the text block where the other stuff lives now. |
| 15:23 |
|
Dyrcona1 joined #evergreen |
| 15:40 |
kmlussier |
eeevil / goood: I may have asked this question before, but I don't recall the answer. Is bug 1251394 ready for testing or does it still need work? |
| 15:40 |
pinesol_green |
Launchpad bug 1251394 in Evergreen "Metabib Display Fields" (affected: 3, heat: 16) [Wishlist,Triaged] https://launchpad.net/bugs/1251394 - Assigned to Mike Rylander (mrylander) |
| 15:45 |
eeevil |
kmlussier: it's just the backend components, but I think they work. nothing knows how to use them yet, though |
| 15:46 |
kmlussier |
eeevil: Ah, ok. So if we wanted something to be able to use them, it still needs work. |
| 16:27 |
|
rjackson_isl_ joined #evergreen |
| 16:39 |
|
julialima_ left #evergreen |
| 16:59 |
|
mrpeters left #evergreen |
| 17:01 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 17:31 |
|
chick joined #evergreen |
| 18:07 |
|
ningalls joined #evergreen |
| 19:19 |
|
graced joined #evergreen |
