| 02:54 |
|
JBoyer joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:13 |
|
rjackson_isl joined #evergreen |
| 07:29 |
|
rfrasur joined #evergreen |
| 07:34 |
|
Dyrcona joined #evergreen |
| 10:25 |
pinesol |
[evergreen|Jason Boyer] LP1895737: Add Curbside Appointments to Bootstrap OPAC - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=5cd1d52> |
| 10:26 |
* gmcharlt |
claims 1269 |
| 10:28 |
|
jonadab joined #evergreen |
| 10:29 |
pinesol |
[evergreen|Jane Sandberg] LP1910891: Add new booking perms to appropriate groups - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0c414a2> |
| 10:29 |
pinesol |
[evergreen|Galen Charlton] LP#1910891: stamp DB update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9d4aec8> |
| 10:37 |
pinesol |
[evergreen|Jane Sandberg] LP1857060: Tests for ISBNs with 979 prefix - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3831d36> |
| 10:40 |
rjackson_isl |
looking at a request for a site specific self check receipt and looking at others notice a 5 second Processing Delay being set. Is there a reason this could not be 0 or 1? |
| 10:44 |
jeff |
is it 5 seconds or 5 minutes? stock selfcheck receipt doesn't specify a delay, so it would probably default to '00:05:00'::interval |
| 10:44 |
jeff |
either way, I don't think the value of the delay column is used for print-on-demand. |
| 10:44 |
rjackson_isl |
we were just discussing that locally after I hit enter :( jeff++ |
| 10:45 |
mmorgan |
rjackson_isl was just testing us :) |
| 10:45 |
rjackson_isl |
and it does appear to default to 5 minutes not seconds which would be one heck of a wait! |
| 10:46 |
rjackson_isl |
rjackson_isl is trying to engage brain transmission... |
| 10:48 |
Dyrcona |
Yeah, what jeff said. I think it just executes immediately. |
| 13:56 |
|
jihpringle joined #evergreen |
| 13:57 |
|
pastebot joined #evergreen |
| 14:00 |
|
pastebot joined #evergreen |
| 14:01 |
pastebot |
"jeff" at 168.25.130.30 pasted "testing" (1 line) at http://paste.evergreen-ils.org/10000 |
| 14:28 |
mantis |
jeff++ |
| 14:29 |
mantis |
jeff: I was looking around the fields for ILS User and wasn't finding anything. The explanation is very helpful! |
| 14:30 |
JBoyer |
Dev meeting in 30 |
| 14:36 |
|
mantis1 joined #evergreen |
| 14:37 |
|
cabreedl joined #evergreen |
| 14:40 |
|
pastebot joined #evergreen |
| 14:41 |
pastebot |
"jeff" at 168.25.130.30 pasted "testing 14402" (1 line) at http://paste.evergreen-ils.org/14402 |
| 14:52 |
Dyrcona |
jeff++ |
| 14:57 |
|
terranm joined #evergreen |
| 14:58 |
bshum |
jeff++ |
| 15:11 |
|
jvwoolf joined #evergreen |
| 15:11 |
JBoyer |
I use it to talk to Evergreen also, though Hatch support is likely 1) missing, and 2), not that difficult to add. |
| 15:12 |
|
jvwoolf left #evergreen |
| 15:12 |
gmcharlt |
Microsoft actually publishes .debs of Edge, so assuming that it has a headless mode, theoretically it could be folded into the Angular tests if somebody were sufficiently eager |
| 15:12 |
berick |
gmcharlt: huh, didn't know they made debs |
| 15:13 |
berick |
that simplifies some things |
| 15:13 |
JBoyer |
For Hatch I suspect they learned their lesson with old Edge's ridiculous extension mechanism and won't likely stray far from Chromium, though if we want Hatch on the Edge Extension store that's one more place to publish it. |
| 15:16 |
berick |
maybe we could limit this some and say just the Angular bits? maybe that's implied.. |
| 15:16 |
gmcharlt |
having the starting point be support-but-not-Hatch-yet seems like it would be OK |
| 15:16 |
JBoyer |
I don't mind trying to add Edge support to the Angular testing setup, though it will likely be optional so running <os>-<distro>-developer doesn't end up installing 4, 5, or 6 browsers in future. |
| 15:17 |
gmcharlt |
berick: that is, if I'm understanding your question correctly. If Edge somehow breaks on the Dojo or AngularJS stuff, fixing that may be more than we awnt to tackle |
| 15:17 |
JBoyer |
berick, do you mean no Hatch yet, or even more limited than that somehow? |
| 15:18 |
berick |
i mean what gmcharlt said. fixing stuff that's being actively replaced is not best use of time |
| 15:24 |
gmcharlt |
(all of that said, not particularly expecting any Dojo or AngularJS issues) |
| 15:24 |
* jeff |
nods |
| 15:24 |
jeffdavis |
I'd be hesitant to tell a library they can use Edge under those conditions tbh. |
| 15:25 |
jeff |
it sounds like there has been some light testing of the current code in Edge. |
| 15:25 |
gmcharlt |
yeah, and production use |
| 15:25 |
alynn26 |
The staff that use Edge know we do not support it. but use it anyway. Have not found any issues with Edge with the AngularJS or Dojo parts. |
| 15:25 |
JBoyer |
I understand the desire not to allow it to cause us any additional support burden, but as I understand it, neither Google or MS make many changes to the core rendering bits of Chromium, it's mostly the (pardon), chrome and syncing backends that are different. I don't see a situation where we have a compatibililty problem with Edge that we wouldn't have with Chrome within days. |
| 15:25 |
gmcharlt |
if Edge weren't Chromium-plus-stuff, I think it would be a bigger lift |
| 15:26 |
jeff |
I think the hesitency in this discussion to claim full support is mostly stemming from the fact that very few here have tested the staff interfaces in Edge. |
| 15:26 |
* mmorgan |
would be interested to know why Edge is preferred by those who are currently using it. |
| 15:27 |
JBoyer |
It's already there. |
| 15:27 |
JBoyer |
And if you're an IT department, it's more easily controlled with group policy. |
| 15:34 |
JBoyer |
(Since I'm on a Mac right now, anyway) |
| 15:35 |
gmcharlt |
alynn26: do you know if anybody has successfully used offline circ with Edge? |
| 15:35 |
JBoyer |
Since berick knocked out #2 already, is anyone interested in taking an action item on exercising the staff client in Edge? Hatch is not necessary, but offline would be. |
| 15:36 |
alynn26 |
No, not offline circ on edge. Testing edge on Windows 10 now. |
| 15:37 |
JBoyer |
To be clear, I don't mean anyone needs to try to knock out a client test right now, I know personally that it works fine for everything I've done in it, but there are a lot of things I don't touch. |
| 15:38 |
JBoyer |
Or I will poke at it. |
| 15:39 |
JBoyer |
#action JBoyer will exercise the staff client in a current release of Edge and report back in August |
| 15:39 |
mmorgan |
JBoyer++ |
| 15:43 |
JBoyer |
gmcharlt, I assume your 3.8 question is about bug 1904036? |
| 15:43 |
pinesol |
Launchpad bug 1904036 in Evergreen "Port patron interfaces to Angular (search, checkout, etc.)" [Wishlist,New] https://launchpad.net/bugs/1904036 |
| 15:43 |
berick |
i added that one |
| 15:44 |
gmcharlt |
JBoyer: yeah, mine was more of a general heads up about a bunch of big features for which we need testing |
| 15:44 |
JBoyer |
:( |
| 15:44 |
berick |
seeking feedback on trying to add it to 3.8 as experimental |
| 15:44 |
gmcharlt |
1904036 is definitely one of them, but there's also |
| 16:05 |
JBoyer |
berick++ |
| 16:06 |
berick |
mmorgan: if you hear anything of note, let me know! |
| 16:06 |
berick |
not sure I can make tomorrow's acq meeting |
| 16:06 |
JBoyer |
Ok, if there are no other questions or comments we can go about the rest of our days (and start testing Angular branches! ;) ) |
| 16:06 |
gmcharlt |
berick: I'll be demoing the acq admin interfaces there tomorrow, and would be happy to relay any questions you care to feed me |
| 16:07 |
mmorgan |
berick: Will share this with my colleague who will be attending that meeting. |
| 16:07 |
berick |
is it 2pm eastern? |
| 16:55 |
|
jvwoolf joined #evergreen |
| 17:18 |
|
mmorgan left #evergreen |
| 17:28 |
|
jvwoolf left #evergreen |
| 18:01 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live//archive/2021-07/2021-07-13_16:00:02/test.42.html> |
| 22:27 |
|
mmorgan1 joined #evergreen |
| 22:27 |
|
mmorgan1 left #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:12 |
|
rjackson_isl joined #evergreen |
| 07:38 |
|
mantis joined #evergreen |
| 08:14 |
|
mmorgan joined #evergreen |
| 08:45 |
|
dguarrac joined #evergreen |
| 08:54 |
|
tlittle joined #evergreen |
| 09:26 |
|
mmorgan joined #evergreen |
| 09:26 |
Dyrcona |
Kind of hard to test lost notices when your test data only gets 7 with filters, and the validator then sets them all to invalid. |
| 09:32 |
Dyrcona |
But, when I run "the query," I get hundreds of circulations that should be picked and create events. I must be doing something wrong with the date math. |
| 09:32 |
mmorgan |
Dyrcona: Sounds like your test patrons need to be more irresponsible :) |
| 09:35 |
Dyrcona |
mmorgan: Yeah, but auto-renewals are also an issue. |
| 09:36 |
Dyrcona |
I figured out what I was doing wrong. I was using between when I should have used > and <. |
| 09:36 |
Dyrcona |
I get 7 with the latter. |
| 10:14 |
mmorgan |
:) |
| 10:18 |
Dyrcona |
mmorgan++ rhamby++ |
| 10:18 |
mmorgan |
Dyrcona++ |
| 10:35 |
Dyrcona |
Think I'll adjust the delay and max_delay on the lost event for another test in a bit. |
| 10:45 |
Dyrcona |
Hm... I think I'm going to have to restart services. I changed the delay and tried running the a/t runner but I don't get any new events. |
| 10:47 |
Dyrcona |
Ah. Ok. Had to specify the filters, and they're all still invalid...... :( |
| 10:47 |
mmorgan |
Action triggers are complicated. |
| 12:06 |
|
seusszeusmoose joined #evergreen |
| 12:07 |
|
jihpringle joined #evergreen |
| 13:06 |
rhamby |
in the spirit of its complicated - an overly complicated squirrel feeding machine https://www.youtube.com/watch?v=U3-doqeWHPM&ab_channel=Creezy |
| 13:07 |
Dyrcona |
OK. So, I know I was messing with action triggers on a test vm, so why has production decided to have issues with action triggers today, too? |
| 13:11 |
alynn26 |
rhamby, https://www.youtube.com/watch?v=hFZFjoX2cGg |
| 13:12 |
Dyrcona |
And, so far, nothing appears to be wrong other than a/t runners going for a long time. |
| 13:17 |
Dyrcona |
@blame curbside |
| 14:08 |
Dyrcona |
I only blamed curbside because of the sheer number of events related to that process. |
| 14:11 |
Dyrcona |
There are currently 4,888 curbside offer events with a state of invalid for today. |
| 17:19 |
|
mmorgan left #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 21:07 |
|
stephengwills joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:11 |
|
rjackson_isl joined #evergreen |
| 07:30 |
|
Dyrcona joined #evergreen |
| 07:42 |
|
mantis joined #evergreen |
| 08:42 |
|
dguarrac joined #evergreen |
| 09:15 |
|
rfrasur joined #evergreen |
| 10:02 |
|
jihpringle joined #evergreen |
| 11:29 |
Dyrcona |
JBoyer: While running my modified Clark in testing, I did get a logged error message from the main process that it failed to connect to the db server. Crazy thing is it says 'no route to host' as if the network went down. |
| 11:29 |
Dyrcona |
Lp 1933984 |
| 11:30 |
pinesol |
Launchpad bug 1933984 in OpenSRF "Reporter Logging Improvements" [Undecided,Confirmed] https://launchpad.net/bugs/1933984 |
| 11:30 |
Dyrcona |
Services on the test VM are all still connected. |
| 11:35 |
Dyrcona |
Our Internet was up and down at the time, but I'm not sure how that would affect the LAN. Anyway, messages are going to syslog as I intended. |
| 12:10 |
JBoyer |
Dyrcona, that's interesting. And it kept working? (maybe failed a dns lookup or something) |
| 12:55 |
Dyrcona |
No, it crashed. |
| 17:23 |
jeff |
yeah, I'm pretty sure I can do a search that combines two search_format entries, but there's no UI that constructs such queries that I'm aware of. |
| 17:27 |
jeff |
a reingest of these types is not too much trouble. |
| 17:36 |
|
jihpringle joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 01:56 |
|
eady joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:11 |
|
rjackson_isl joined #evergreen |
| 07:56 |
|
mantis joined #evergreen |
| 08:38 |
|
rfrasur joined #evergreen |
| 11:42 |
jeff |
but this appears to be in IO::Select (is that part of IO::Socket?) |
| 11:42 |
jeff |
(no, not part of IO::Socket) |
| 11:56 |
|
jihpringle joined #evergreen |
| 11:59 |
csharp_ |
working on bug 1932051 ... I have set up a similar test to what berick describes in https://bugs.launchpad.net/evergreen/+bug/1896285/comments/6 |
| 11:59 |
pinesol |
Launchpad bug 1896285 in Evergreen 3.5 "Use batch methods for multi-row grid actions" [Medium,Fix released] |
| 11:59 |
pinesol |
Launchpad bug 1932051 in Evergreen "AngularJS Add to Item Bucket Generating too many simultaneous requests" [High,New] https://launchpad.net/bugs/1932051 - Assigned to Chris Sharp (chrissharp123) |
| 11:59 |
csharp_ |
still maxxing out the 5/5 open-ils.actor drones when I add 100 items to a new bucket |
| 14:40 |
Dyrcona |
It makes the output files world writable, which isn't what we'd normally want, and I suspected that it would do this because default permissions when writing files with Perl. |
| 14:51 |
JBoyer |
Anytime umask is 0 you should end up with 777 or 666 perms. Looking at that section it looks like you should set it to 0 to be absolutely certain you don't inherit an unknown value. So we can either specify the mode every single time open is called (not great) or we can specifically set it to a known-good value for our purposes, I imagine 022 is fine for that. |
| 14:53 |
Dyrcona |
JBoyer: Yes. The logic for a program written in C is set umask to 0, then use your own permission mask when creating files from a daemon process. umask is typically 022 so setting it to that may not be a bad idea. |
| 14:54 |
Dyrcona |
I've reverted that commit for my current test. I wasn't seeing anything in syslog, but now, I'm not seeing anything to stderr, either, so maybe there were no log messages, yet. |
| 14:56 |
Dyrcona |
In production, there are almost always some messages about not being able to draw some figure or another. |
| 14:57 |
Dyrcona |
Ha! Timing: Jul 2 14:57:08 jasontest Clark Kent reporting: ** daily LOST ITEMS PAYMENTS: [WARN:7388:clark-kent.pl:40:] Reporter warning: Couldn't draw /openils/var/web/reporter/6236/72235/204102/report-data.html.bar.gif : No attribute 'shading'#012No data sets or points at /openils/bin/clark-kent.pl line 835. |
| 14:58 |
JBoyer |
I forgot that perl's open doesn't accept that kind of mode, we should definitely just set the umask to what we want rather than trying to swap to sysopen. |
| 14:58 |
Dyrcona |
JBoyer: Yeah. I think we'll have to use 022. |
| 14:59 |
Dyrcona |
Something like that, but the good thing is that message went to syslog. |
| 15:00 |
JBoyer |
Maybe that can be cleaned up when pie charts are either finished or throw out. ;) |
| 15:04 |
Dyrcona |
So, now, I'm testing with my daemonize changes back in place to see if that unintentionally closes the connection to syslog. |
| 15:05 |
Dyrcona |
I'll change the umask from 0 to 022 before I update the bug. |
| 15:07 |
Dyrcona |
I'm not so sure that the individual reporter processes need to daemonize themselves. |
| 15:11 |
Dyrcona |
Ah, but the fact that they daemonize themselves means that they keep running even if the parent process dies, no? |
| 16:33 |
alynn26 |
Dyrcona ++ |
| 16:50 |
|
jvwoolf left #evergreen |
| 17:23 |
|
mmorgan left #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:22 |
|
mantis joined #evergreen |
| 07:33 |
|
collum joined #evergreen |
| 07:43 |
JBoyer |
For any that followed the CentOS drama a while back, it looks like there are more options to choose from: https://arstechnica.com/gadgets/2021/06/centos-replacement-distro-rocky-linuxs-first-general-release-is-out/ |
| 08:59 |
|
Dyrcona joined #evergreen |
| 09:08 |
|
dguarrac joined #evergreen |
| 09:25 |
|
Keith-isl joined #evergreen |
| 09:27 |
Dyrcona |
@later tell Bmagic I've finally gotten back to looking at your issue with symspell and parallel ingest. I'm testing with Pg 12 and setting up Pg 9.6. |
| 09:27 |
pinesol |
Dyrcona: The operation succeeded. |
| 09:35 |
|
Keith_isl joined #evergreen |
| 10:06 |
mantis |
What format does Evergreen use for email notifications? I'm looking to format hyperlinks. |
| 10:27 |
gmcharlt |
Dyrcona: thanks for checking! |
| 10:28 |
berick |
gmcharlt: no data in acq.debit_attribution here |
| 10:29 |
gmcharlt |
berick: thanks as well! |
| 10:30 |
mantis |
Dyrcona: Yes. Though I have noticed with my testing that linking to a library's opac doesn't bring it up however outside links are fine. |
| 11:20 |
|
Keith_isl joined #evergreen |
| 12:03 |
|
Keith-isl joined #evergreen |
| 12:18 |
jeffdavis |
acq.debit_attribution is empty here too |
| 13:17 |
jeff |
but no, while not impossible it's probably not someone who left a few hundred tabs open. |
| 15:01 |
|
jihpringle joined #evergreen |
| 16:36 |
|
alynn26 joined #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:05 |
gmcharlt |
noting a big pull request I just filed for the Angular rewrite of various acquisitions adminsitration interfaces: https://bugs.launchpad.net/evergreen/+bug/1904244 |
| 18:05 |
pinesol |
Launchpad bug 1904244 in Evergreen "Angular Acquisitions: Administration" [Wishlist,Confirmed] |
| 20:23 |
|
jonadab joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:11 |
|
Dyrcona joined #evergreen |
| 07:20 |
|
rjackson_isl_hom joined #evergreen |
| 07:27 |
|
mantis joined #evergreen |
| 09:32 |
|
Keith-isl joined #evergreen |
| 09:37 |
|
dickreckard joined #evergreen |
| 09:39 |
|
ShulaBee joined #evergreen |
| 09:46 |
mantis |
I was following mmorgan's slides for creating a test environment via VB using Ansibile but when trying to fire it up, there is an ejabberd error. |
| 09:47 |
mantis |
"Unable to restart service ejabberd: Job for ejabberd.service failed because the control process exited with error code" |
| 09:48 |
mantis |
The network option has been changed to "Bridged Adapter" in the VB settings if that helps |
| 09:49 |
Dyrcona |
mantis: It's probably a misconfiguration of ejabberd. There should be an ejabberd error log on the VM that will tell you more. |
| 09:50 |
mmorgan |
mantis: Which Ubuntu .iso did you use to build the VM? |
| 09:54 |
berick |
miker: there are limitations to the facet display. i just copied the logic from the tpac's config.tt2 |
| 10:54 |
Dyrcona |
I suppose I could try this against a stock branch to see if it is a problem with our customization, which I highly suspect. |
| 10:54 |
berick |
Dyrcona: i seem to recall it tells you the file that has issues, even if it's an INCLUDEd file. i would expect form.tt2 to be the location of the issue |
| 10:57 |
|
jvwoolf joined #evergreen |
| 10:59 |
Dyrcona |
berick: It doesn't look like it to me. The error does go away if I add and extra END at the bottom, though. I'm going to test with stock to see what happens. |
| 10:59 |
berick |
k, i could be misremembering |
| 10:59 |
Dyrcona |
I could be wrong, too. |
| 11:00 |
Dyrcona |
I'll paste my template if I get really stumped. Maybe it's something obvious that I'm too blind to see. |
| 11:47 |
|
Stareagle80 joined #evergreen |
| 11:47 |
|
Stareagle80 left #evergreen |
| 11:47 |
|
Stareagle joined #evergreen |
| 11:49 |
Stareagle |
Test post to see if |
| 11:49 |
Stareagle |
I got things right |
| 11:49 |
miker |
berick: you are a gentleman and a scholar, sir! that does seem simple and I plan to steal it. (and also LP it, and point to your branch. so, not steal so much as thank you) |
| 11:49 |
Dyrcona |
I see your test. Welcome aboard, Stareagle. |
| 11:53 |
berick |
miker++ # LP |
| 11:58 |
mmorgan |
mantis: miker: Regarding change operator, we've thought about making the order of Temporary, Staff, and Persistent oposite, making Peristent the default. Haven't done it yet, though. |
| 12:00 |
Dyrcona |
mmorgan: Is that because you have a lot of staff with individual logins? |
| 15:58 |
pinesol |
Launchpad bug 1932363 in Evergreen "Angular: eg-org-family-select with limitPerms set can include ancestors that the user doesn't have access to" [Medium,New] https://launchpad.net/bugs/1932363 |
| 15:59 |
gmcharlt |
@later tell sandbergja interested in your opinion on bug 1932363 |
| 15:59 |
pinesol |
gmcharlt: The operation succeeded. |
| 16:13 |
jeffdavis |
jvwoolf: I don't have a way to monitor API calls in real time, but we do monitor # of drones for each service, so I get alerts when we hit max_children. I also have a cronjob that looks for "no children available" warnings in the logs. |
| 16:13 |
jeffdavis |
When that happens I manually review the logs looking for clusters of similar-looking calls to that service leading up to the alert. |
| 16:14 |
jeffdavis |
Then I look at the staff client to see where that particular call happens, and see if I can reproduce on a test server. |
| 16:14 |
jvwoolf |
jeffdavis++ |
| 16:14 |
jvwoolf |
Thanks for the info |
| 16:40 |
mmorgan |
We've had a few reports over the past week of white screens and the screen just refreshing when attempting to login. Anyone else heard similar? |
| 16:55 |
mmorgan |
Shula_L: Interesting, that doesn't seem to be our issue, though. I always want to blame updates, Windows updates have been going around. |
| 16:56 |
Shula_L |
mmorgan: I wouldn't be surprised at all if it's a case of the updates. |
| 17:44 |
mmorgan |
berick: fyi, bug 1932369 |
| 17:44 |
pinesol |
Launchpad bug 1932369 in Evergreen "Angular: Change Operator behavior differs from AngularJS" [Undecided,New] https://launchpad.net/bugs/1932369 |
| 17:45 |
|
mmorgan left #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 20:01 |
|
kco joined #evergreen |
| 20:21 |
|
jihpringle joined #evergreen |
| 20:24 |
|
cmalm joined #evergreen |
| 11:42 |
|
troy joined #evergreen |
| 11:44 |
|
Dawn joined #evergreen |
| 11:48 |
Dyrcona |
gmcharlt: You're basically undoing the previous patch on the title fields. |
| 11:50 |
gmcharlt |
Dyrcona: correct, but unless I missed something during testing, that part of c31d052576 seems to have not been necessary |
| 11:50 |
pinesol |
gmcharlt: [evergreen|Jeff Davis] LP#1902965: HTML filter on Bootstrap OPAC search results and record display - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c31d052> |
| 11:52 |
gmcharlt |
(and if I _am_ missing something, arguably the normalization belongs inside html_text_attr() rather than outside it anyway |
| 11:53 |
|
Dawn joined #evergreen |
| 12:00 |
jeffdavis |
"><script>alert('uh oh');</script> |
| 12:01 |
jeffdavis |
^ that was the vulnerability that the html filter was fixing per 1902965 |
| 12:09 |
|
jihpringle joined #evergreen |
| 12:10 |
gmcharlt |
which no longer seems to be an issue even with my latest patch in place, but yeah, more eyes on testing will reveal all |
| 12:18 |
jeffdavis |
Just setting up a test environment for it now. |
| 12:21 |
|
rlefaive joined #evergreen |
| 12:22 |
|
plux joined #evergreen |
| 12:26 |
plux |
any reports of issues building 3.7 on Ubuntu 20.04 with Angular building? on my third attempt and /openils/var/web/eg2 doesn't build/get created using the tarball |
| 12:28 |
Dyrcona |
heh. "Ubunut." |
| 12:31 |
plux |
I had tried the git build as dev as well - hit different issues but many warnings and errors when I got to building Angular - was wondering if my Ubuntu vm is missing some dependency that stopped something from building - but I don't see errors on the install |
| 12:32 |
plux |
this is just the default code base on new Ubuntu 20 server - using concerto db - everything builds fine but staff client Administration links are broken |
| 12:46 |
Dyrcona |
plux: I haven't tried administration, yet, but everything else seems to be working so far. I've been editing concerto records to test gmcharlt's branch that was mentioned earlier. |
| 12:46 |
Dyrcona |
I'm using a default install as well of the latest master code from git. |
| 12:47 |
|
collum joined #evergreen |
| 12:48 |
jeff |
pinesol++ |
| 13:19 |
jeffdavis |
Dyrcona: I'll still have a look, but definitely don't wait on my input |
| 13:30 |
|
eady joined #evergreen |
| 13:33 |
|
jvwoolf joined #evergreen |
| 13:37 |
Dyrcona |
jeffdavis: I pushed a signoff branch and mentioned what I did for testing. |
| 14:21 |
|
rhamby joined #evergreen |
| 14:23 |
|
jvwoolf joined #evergreen |
| 14:28 |
|
gmonti left #evergreen |
| 17:13 |
|
mmorgan left #evergreen |
| 17:20 |
|
plux joined #evergreen |
| 17:28 |
|
jihpringle joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:01 |
|
jonadab joined #evergreen |
| 19:24 |
|
kmlussier joined #evergreen |
