06:35 |
jeff |
commit a5d2ba32 |
06:36 |
jeff |
maybe a working repo commit? i don't recall if pinesol_green reacts to those. |
06:40 |
|
rlefaive joined #evergreen |
06:44 |
kmlussier |
hmmmm |
06:46 |
kmlussier |
chreeus: On bug 1541801, we noticed the same issue in the web client when we were testing Z39.50. |
06:46 |
pinesol_green |
Launchpad bug 1541801 in Evergreen "search fields in z39.50 sort in random order" [Undecided,New] https://launchpad.net/bugs/1541801 |
06:47 |
kmlussier |
chreeus: I wonder if work on the web client caused the change in the xul client interface |
07:02 |
chreeus |
kmlussier: that's our theory |
07:03 |
bshum |
chreeus, jeff: right pinesol doesn't track working |
07:04 |
bshum |
I think it was mostly a matter of avoiding double reporting since it would likely spit back master changes in both repos |
07:05 |
bshum |
Never quite tested beyond that. |
07:06 |
kmlussier |
Using working to look up commits would be useful. Getting an announcment every time somebody pushes a branch to working? Not so much. |
07:06 |
bshum |
Hmm |
07:10 |
bshum |
kmlussier: Well what would happen is that it would only announce master changes |
07:18 |
pinesol_green |
bshum: evg-working (Evergreen-Working, branch: master) |
07:18 |
pinesol_green |
bshum: opensrf (OpenSRF, branch: master) |
07:18 |
pinesol_green |
bshum: sipserver (SIPServer, branch: master) |
07:18 |
bshum |
I'm going to test an idea |
07:18 |
bshum |
and try asking it to track another branch for announce |
07:18 |
bshum |
if it works anyways |
07:19 |
bshum |
@git repolist |
07:19 |
pinesol_green |
bshum: evergreen (Evergreen, branch: master) |
07:19 |
pinesol_green |
bshum: evg-working (Evergreen-Working, branch: master) |
07:19 |
pinesol_green |
bshum: opensrf (OpenSRF, branch: master) |
09:33 |
|
yboston joined #evergreen |
09:35 |
|
maryj joined #evergreen |
09:44 |
JBoyer |
Dyrcona++ |
09:45 |
JBoyer |
Thanks for the help yesterday re: deadlocks, we were able to load 100K+ records in an hour or so in our test, migrations here are going to look at a lot different in the future. |
09:45 |
JBoyer |
look a lot. I try not to look directly into the operational end of a migration in progress.. |
09:46 |
jeff |
JBoyer: ``Do not look into laser with remaining good eye.'' |
09:47 |
JBoyer |
I feel like I should know that, but it's not coming to me. |
10:25 |
JBoyer |
Completely unrelated news: This morning I tracked down the application guide for a temp/humidity sensor I've been looking for and I haven't been this excited to play around with code since I was playing with OpenGL in my college dorm room. |
10:32 |
|
collum joined #evergreen |
11:28 |
|
sandbergja joined #evergreen |
11:30 |
pinesol_green |
[opensrf|Mike Rylander] LP#1494486: Limit damage caused by dropped drone XMPP sockets - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=5580724> |
11:36 |
pinesol_green |
[opensrf|Jason Etheridge] LP#1474507: fix interval_to_seconds for weeks and seconds - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=69cbe80> |
11:36 |
pinesol_green |
[opensrf|Jason Etheridge] LP#1474507: tests for interval_to_seconds - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=7a714ae> |
11:40 |
|
mllewellyn joined #evergreen |
11:59 |
|
bmills joined #evergreen |
12:01 |
kmlussier |
@coffee |
12:40 |
|
mllewellyn joined #evergreen |
12:40 |
|
Bmagic joined #evergreen |
12:51 |
JBoyer |
Ah, makes sense. |
13:12 |
pinesol_green |
[opensrf|Galen Charlton] LP#1350457: add test case for perl2JSONObject change - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=b6cf3eb> |
13:12 |
pinesol_green |
[opensrf|Mike Rylander] LP#1350457: Pass caller's session to subrequests called via method_lookup - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=e1581d4> |
13:36 |
* chreeus |
wonders if the addition of UPC to the fields in commit 2038e93a caused weird sorting in bug 1541801 |
13:36 |
pinesol_green |
Launchpad bug 1541801 in Evergreen "search fields in z39.50 sort in random order" [Medium,Confirmed] https://launchpad.net/bugs/1541801 |
13:36 |
pinesol_green |
[evergreen|Josh Stompro] LP#1519925 - Allow MARC Federated Search to search UPC index of local catalog. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2038e93> |
14:35 |
yboston |
shoudl we make it an action item to have a DIG member check with the devs about what is productionr eady for 2.10? |
14:36 |
remingtron |
I can't remember what gmcharlt (the release manager) said his goals were |
14:36 |
remingtron |
but I think it was only circ desk use. |
14:36 |
jihpringle |
will there be a web client test server for 2.10? We're not planning to release the web client to our libraries until we make the final switch so it won't be part of our test server |
14:36 |
jihpringle |
^^ community web client test server for 2.10 |
14:38 |
remingtron |
Here's gmcharlt's "plan for 2.10": |
14:38 |
remingtron |
#link http://georgialibraries.markmail.org/thread/wlnvqe53umjjevae |
14:38 |
yboston |
we can hope that the "webby" server would get updated for us to use |
10:58 |
kmlussier |
Dyrcona: Nope |
10:58 |
|
ericar_ joined #evergreen |
11:00 |
Dyrcona |
OK. I plan to start up my precise vm to update the software, then maybe make a new vm for concerto. |
11:00 |
Dyrcona |
I use the latter to test tarballs and run the perl and db tests. |
11:03 |
Dyrcona |
BTW, I plan to finally release 2.9.2 on the 17th. |
11:16 |
JBoyer |
I wonder how many users actually make use of wildcard searching, vs those that think that you really do have to search for M*A*S*H to find the DVD you want... |
11:16 |
Dyrcona |
JBoyer: I'm going to build just master on my concerto vm to see if the grunt all command still fails. |
11:31 |
kmlussier |
JBoyer: Does it work if you surround it in quotes? |
11:32 |
Dyrcona |
I don't think I would enter MASH that way, and I usually search in lowercase, 'cause the shift key is hard. :) |
11:32 |
kmlussier |
Actually, it works with and without quotes |
11:33 |
JBoyer |
It's quicker with the quotes, but neither of my tests took 90+ seconds like the search that was in my log analyzer... |
11:34 |
JBoyer |
I'm with Dyrcona, it just seems like such a tedious thing to type. What do these people say out loud? "What are you looking for?" "Emm, star, aye, star, ess, star, aich." |
11:34 |
kmlussier |
JBoyer: Yeah, I tried it on C/W MARS. The unquoted one was longer, but it wasn't terrible. |
11:35 |
JBoyer |
My test was fine too, there must have been something else about when they searched, or the phase of the moon, etc. |
11:36 |
JBoyer |
The person that searched for the entire copy/pasted contents of a Google Play book search page must have had some interesting ideas. |
11:36 |
* Dyrcona |
should automate the prerequisite installation for OpensRF and Evergreen on his VMs. It will save time without typos. |
11:37 |
* JBoyer |
knows a guy... |
11:54 |
tsbere |
Stompro: Fair note, that is (obviously) a little dated, and doesn't take into account details like parts being flagged as deleted. |
11:54 |
tsbere |
So if you have that code loaded there are adjustments that need to be made |
11:55 |
Stompro |
I don |
11:55 |
Dyrcona |
I think grunt test failed, but I'll try it manually in a bit. |
11:56 |
Dyrcona |
It scrolls by so fast. |
11:56 |
Stompro |
tsbere, I don't think that 2.8.4 has the parts deletion bits, no deleted field in biblio.monograph_parts here. |
11:57 |
tsbere |
Stompro: Specifically, the "SELECT INTO existing_part id FROM... line would need to have "AND NOT deleted" added to the where clause when you do have the flag. |
12:10 |
Dyrcona |
It stats with couldn't load egCoreWeb because of the above. |
12:11 |
Dyrcona |
gmcharlt: Fresh checkout of master. |
12:11 |
Dyrcona |
Fresh vm. |
12:11 |
Dyrcona |
That happens with grunt test. |
12:12 |
Dyrcona |
The test output is "this should parse the IDL" |
12:14 |
gmcharlt |
Dyrcona: OK, I think I see what the problem is, one moment |
12:14 |
berick |
if it's a new dependency, it may need to be added to the test manifest |
12:15 |
gmcharlt |
ayup |
12:17 |
gmcharlt |
Dyrcona: check the tip of collab/gmcharlt/webstaff-sprint2-sprint3-round2 |
12:19 |
|
bmills joined #evergreen |
12:21 |
Dyrcona |
gmcharlt++ that resolves it. |
12:21 |
Dyrcona |
Should I just cherry-pick that into master since it is a fix for a test? |
12:21 |
|
_bott_ joined #evergreen |
12:28 |
berick |
Dyrcona: +1 to cherry-pick |
12:28 |
gmcharlt |
+1 |
12:29 |
gmcharlt |
Dyrcona++ |
12:29 |
Dyrcona |
breick++ |
12:29 |
Dyrcona |
berick++ |
12:31 |
pinesol_green |
[evergreen|Galen Charlton] webstaff: add angular-file-saver to test manifest - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e32a1d4> |
12:35 |
csharp |
@karma breick |
12:35 |
pinesol_green |
csharp: Karma for "breick" has been increased 1 time and decreased 0 times for a total karma of 1. |
12:35 |
csharp |
@karma chreeus |
13:28 |
pinesol_green |
Launchpad bug 1499086 in Evergreen 2.9 "Slowness/timeout on loading bookbags in OPAC" [Medium,Triaged] https://launchpad.net/bugs/1499086 |
13:36 |
|
jihpringle joined #evergreen |
13:46 |
csharp |
new_glasses++ |
13:48 |
bshum |
jeffdavis: If as you're working through and see stuff that will be signed off or tested as part of 2.10 I would go ahead and update the bug |
13:49 |
bshum |
Otherwise, it's just extra churn to update the milestone for work that may go unfinished and end up back on 2.next or later |
13:51 |
* Dyrcona |
agrees with bshum. |
13:51 |
jeffdavis |
Makes sense, thanks. |
14:12 |
JBoyer |
Is anyone using the migration tools to load bibs in parallel? We're working on a local method because a single process isn't getting it done, but we're hitting deadlocks on occasion. I know there's src/extras/import/parallel_pg_loader.pl but I don't think it's ready to use as-is for the output of the migration tools. |
17:14 |
gsams |
mmorgan: I appreciate it, I'd still be interested because it might be relevant for another library if nothing else |
17:16 |
mmorgan |
ok will dig up the info tomorrow. Good night all! |
17:16 |
|
mmorgan left #evergreen |
17:58 |
jeffdavis |
So I'm in the middle of writing a Perl live test for the opt-in feature. |
17:58 |
jeffdavis |
One of the test steps is to opt in a patron with open-ils.actor.user.org_unit_opt_in.create. |
17:59 |
jeffdavis |
I want to return to a "clean" state when the testing is done, so I need to delete the opt-in during my test. |
18:00 |
jeffdavis |
But there's no method for deleting opt-ins, and I can't delete arbitrary records with something like json_query (it only does SELECT statments, IIRC). |
18:00 |
jeffdavis |
So I'm thinking the easiest solution is just to add a new open-ils.actor.user.org_unit_opt_in.method to EG. |
18:00 |
jeffdavis |
Which we ought to have anyway. |
18:00 |
jeffdavis |
Here ends a case study in why tests are a Good Thing. |
18:01 |
jeffdavis |
(a new open-ils.actor.user.org_unit_opt_in.delete method, that is) |
18:08 |
dbwells |
jeffdavis: or pcrud? (not familiar with the feature, just throwing it out there) |
18:09 |
* dbwells |
is not familiar with opt-in. He knows about pcrud :) |
18:10 |
jeffdavis |
dbwells: pcrud ought to work, unless there's some reason live tests can't use it. |
18:10 |
jeffdavis |
I just like the idea of tests giving me an excuse to add a new feature. :) |
18:16 |
miker |
jeffdavis: pcrud or cstore should work fine in live tests |
18:16 |
miker |
fwiw |
18:16 |
dbwells |
Well, live tests can do about whatever they want, so even cstore's an option. |
18:16 |
dbwells |
right :) |
18:17 |
jeffdavis |
good to know |
18:20 |
dbwells |
We've got plenty of CRUD methods hanging around in EG, so not a big deal, but if simple client access is something desirable, think of pcrud as a good way to _not_ add a new feature :) |
18:21 |
* dbwells |
disappears |
08:22 |
Dyrcona |
pinesol_green: Got any laters for me? |
08:22 |
pinesol_green |
Dyrcona: Have you confirmed your ISBN SPIDs with your service provider? |
08:22 |
pinesol_green |
Dyrcona: I am only a bot, please don't think I'm intelligent :) |
08:25 |
kmlussier |
Dyrcona: No laters, but gmcharlt mentioned last night that collab/gmcharlt/webstaff-sprint2-sprint3-round2 is ready for testing. |
08:36 |
Dyrcona |
OK. Looks like i use the round2 branch. |
08:37 |
|
mrpeters joined #evergreen |
08:38 |
jeff |
and we have reached the point in the morning where i wish i had a rolling packet capture on all SIP2 traffic. |
14:37 |
tsbere |
May need some adjusting for you as I hardcoded a bib source or two in the bibs sans call numbers query |
14:38 |
* tsbere |
has that (and some other things) running nightly for MVLC, though I think we have upped the period variable to 90 days instead of 30 |
14:39 |
kmlussier |
gsams: I just checked. Transferring items to volumes will delete the volume too if it's left empty. |
14:40 |
gsams |
kmlussier++ #I appreciate the quick test! |
14:40 |
|
jlitrell joined #evergreen |
14:40 |
kmlussier |
gsams: I just happened to be in holdings maintenance when you asked the question. :) |
14:41 |
tsbere |
I know empty volumes still crop up for us. Probably from failed creates and other things. |
14:43 |
* jeff |
tries to sort out his feelings for call numbers like "DVD AVE RATED PG-13" |
14:43 |
Bmagic_ |
yeah, lol |
14:44 |
|
RoganH_ joined #evergreen |
14:46 |
kmlussier |
OK, everything looks okay on Dyrcona's test system. I think I'm ready to merge the sprint2/sprint 3 branch |
14:47 |
kmlussier |
Thank you, cat, for hitting the Enter key before I was done. |
14:47 |
tsbere |
kmlussier: The cat apparently thought it was a good place to stop. |
14:47 |
kmlussier |
Does the branch need an LP bug before I merge it? |
14:48 |
kmlussier |
tsbere: Yeah, he then hit All Caps afterwards, which is why it took me a while to pose my next question. |
15:30 |
csharp |
and that's obviously not what the feature was built to accommodate |
15:31 |
csharp |
yeah, I'll play with that in the short term |
15:31 |
tsbere |
csharp: If you want standing penalties to generally be at the top level then set the depths to 0. I think that will generally work across the board. |
15:31 |
csharp |
tsbere: cool - I'll do some testing |
15:31 |
tsbere |
We set many of them that way, if you want to poke me on some of that |
15:31 |
csharp |
thanks! |
15:32 |
tsbere |
We also have some "System-level" versions that staff can set for more local issues (blocking another library's patron from their library, for example) |
09:26 |
|
maryj joined #evergreen |
09:42 |
|
bwicksall joined #evergreen |
09:44 |
kmlussier |
Dyrcona++ gmcharlt++ |
09:47 |
Dyrcona |
kmlusser: I might have to build a new branch after the rebase if you want to continue testing on my development system. |
09:48 |
Dyrcona |
If that's the case, do you want to just load the sprint2-sprint3 branch, and maybe the patron editor branch? |
09:53 |
kmlussier |
Dyrcona: Yes, that's fine. That's all I'm focusing on ATM |
09:55 |
Dyrcona |
I could reload the database in the meantime, and probably should. |
10:02 |
|
mmorgan left #evergreen |
10:16 |
Dyrcona |
kmlussier: Would want the hotkeys branch? |
10:16 |
Dyrcona |
Should be a "you" in there somewhere. |
10:17 |
kmlussier |
Dyrcona: I'll probably be testing that soon after the sprint2 branch goes in, so yes. |
10:17 |
* kmlussier |
checks to see if there is even a pullrequest tag on that one. |
10:18 |
kmlussier |
gmcharlt: Do you want a pullrequest on bug 1508477? |
10:18 |
pinesol_green |
Launchpad bug 1508477 in Evergreen "browser client: hotkeys don't work if an input element has focus" [Wishlist,New] https://launchpad.net/bugs/1508477 |
10:18 |
kmlussier |
It's worked very well in my testing on webby. Even if there is still work left to be done, it would be nice to have it in before 2.10 |
10:20 |
Dyrcona |
I can always add it again later. |
10:21 |
gmcharlt |
kmlussier: sure |
10:23 |
Dyrcona |
I just figured that I put the branch together with what's ready so I could run upgrade scripts before hand. |
10:05 |
Dyrcona |
Bmagic: When I need to tune a Pg installation, I usually spend days pouring over wiki pages and conference slides, and then twiddle things until it is "fast enough." |
10:05 |
csharp |
Bmagic: do you have more than one RAID controller? |
10:05 |
csharp |
Dyrcona: that's my current method too ;-) |
10:05 |
Bmagic |
Dyrcona: what method do you use to test speed? |
10:06 |
tsbere |
JBoyer: For reference, I found that "search in their system" and "login to their system" didn't play nice together in the same link. So I skipped the "search" part. |
10:06 |
csharp |
Bmagic: http://www.postgresql.org/docs/9.3/static/runtime-config-connection.html and following explain every setting in pretty good detail |
10:06 |
Dyrcona |
Bmagic: None that's worth mentioning. |
10:07 |
Bmagic |
csharp: ty |
10:07 |
Dyrcona |
I might time some scripts, etc. |
10:08 |
JBoyer |
I'd like to someday pull an entire day's worth of queries from the logs, keep the dump from that day; clean up any that don't play nice, then see how long it takes to replay that day on a fresh reload. It would be easy to see how big an impact settings changes make across that level of activity. It's more difficult to improve everything when you can only really test this or that slow query. |
10:08 |
csharp |
Bmagic: check 'top' for high wait when things are slow - it might mean you need to reevaluate your disk setup - we're on SSDs now, but when we were on spinning disks, adding a second RAID controller solved all our problems |
10:08 |
Bmagic |
csharp: changing hardware isn't in the cards right now. The fact is, 9.2 was faster |
10:08 |
Bmagic |
on the same hardware |
12:22 |
|
geoffsams joined #evergreen |
12:31 |
|
bmills joined #evergreen |
12:34 |
|
jihpringle joined #evergreen |
12:51 |
Dyrcona |
@decide make new test accounts or crack passwords on existing test accounts? |
12:51 |
pinesol_green |
Dyrcona: go with crack passwords on existing test accounts? |
12:56 |
RoganH |
Clearly that would take less time. Or at least be less tedious. One of those. |
12:58 |
Dyrcona |
Assuming that the majority of the test accounts have four digits for the password, yes. |
12:58 |
Dyrcona |
And by test account, I mean "not real patrons used for testing purposes." |
13:02 |
Dyrcona |
And now, I apparently don't have to.... |
13:03 |
Dyrcona |
We apparently already sent this information, and I was just given the spread sheet that was sent previously. |
13:03 |
Dyrcona |
Oh well, it could have been a "fun" way to spend the afternoon. |
13:09 |
* tsbere |
cracked the passwords on a few thousand accounts just to test some code he provided to Dyrcona for possibly cracking existing accounts >_> |
13:09 |
jeff |
yeah. it takes about 27ms to generate hashes for four digit pins. |
13:09 |
jeff |
and that's with storing them in a temp table for reuse. |
13:10 |
jeff |
for one, it's actually faster to skip the temp table. |
07:49 |
|
Stompro joined #evergreen |
08:07 |
|
ericar joined #evergreen |
08:09 |
|
JBoyer joined #evergreen |
08:25 |
csharp |
Bmagic: regarding DB differences between 2.8.2/2.9.1 and autosuggest, what's more likely (from our experience with moving to 9.3 and 9.4) is that the query planner in postgres is working differently than before - if you have (or can assemble) a test server with the old version of EG/PG, you might be able to track the difference in the queries created - then it's a matter of DB and EG query tuning |
08:43 |
|
mmorgan joined #evergreen |
08:46 |
|
mrpeters joined #evergreen |
09:05 |
|
Dyrcona joined #evergreen |
09:38 |
Dyrcona |
Wonder if it did that yesterday and I missed it. |
09:38 |
Dyrcona |
kmlussier: Thanks! |
09:40 |
Dyrcona |
I don't really have time to sort this right now. I'd have to do a clean install. It could be something going on with running the scripts twice. |
09:47 |
JBoyer |
Dyrcona: Does it have that problem with just grunt build, or only grunt all? Skipping the tests may not be ideal, but if it gets things moving on your test server it could always be investigated later. |
09:48 |
Dyrcona |
JBoyer: Good question, and if I knew enough about it, I would have tried that before blowing out the VM and building a fresh one. :) |
09:48 |
Dyrcona |
JBoyer: Don't think I'm intelligent. I am only a bot following a script. :) |
09:49 |
* Dyrcona |
is a total newb when it comes to Node.js and friends. |
11:31 |
pinesol_green |
kmlussier: I am only a bot, please don't think I'm intelligent :) |
11:48 |
berick |
dbwells: fix pushed. I'm working on a follow up patch to make some things more efficient. specifically, reduce the number of times we have to look up the root unit unit ID from the database and use cstore instead of storage for perm checks. |
11:48 |
berick |
the API call will get (intentionally) slower w/ bcrypt, so may as well make some other parts faster/leaner |
11:49 |
Dyrcona |
JBoyer: grunt build works. Guess it is a test that fails. |
11:55 |
JBoyer |
That's good. (for certain values of good...) The specific test that I had fail on me was somehow related to our fmIDL.xml file and either permissions or paths, so I wasn't too worried about it at the time, |
11:55 |
JBoyer |
. |
11:56 |
Dyrcona |
kmlussier: FWIW, my dev vm is running with the branches we discussed. |
11:56 |
kmlussier |
Dyrcona: Great, thank you! |
10:18 |
* csharp |
just turned 42 - so far everything is just as mysterious as before |
10:20 |
* Dyrcona |
is *mumble* *mumble* years old.... |
10:23 |
|
jwoodard joined #evergreen |
10:47 |
csharp |
hmm - looks like the new hold_request_capture_protect_idx index is preventing item checkin with no useful errors to the end user |
10:48 |
csharp |
duplicate key value violates unique constraint "hold_request_capture_protect_idx" - DETAIL: Key (current_copy)=(14779072) already exists. |
10:48 |
csharp |
seems like something the application layer should be testing before it tries to update the hold row |
10:49 |
csharp |
rather than failing gracelessly |
10:51 |
csharp |
32e415a2 |
10:51 |
pinesol_green |
[evergreen|Mike Rylander] LP#902255: Protect against hold double-capture - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=32e415a> |
10:51 |
csharp |
hmm |
10:51 |
* csharp |
checks that util.js and circ.properties is up-to-date |
11:27 |
kmlussier |
I may have misunderstood, but I didn't think the code in question only comes into play for asynchronous checkin. It was just higlighted as one occurance where double capture can happen. |
11:28 |
pinesol_green |
[evergreen|Jason Stephenson] Forward port 2.9.0 to 2.9.1 db upgrade script. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ea474a9> |
11:29 |
csharp |
kmlussier: yeah, I'm asking them to try with the checkbox unchecked, but it still looks like there's some bugaboo lurking there |
11:29 |
kmlussier |
Yeah, looking at my notes on bug 902255, I was able to replicate the bug without asynchronous checkin being selected. In testing, the user-friendly error message did appear. |
11:29 |
pinesol_green |
Launchpad bug 902255 in Evergreen "possible to double-scan an item during check-in and have it captured by two holds" [Low,Fix released] https://launchpad.net/bugs/902255 |
11:31 |
csharp |
kmlussier: your comment #7 there is exactly what was reported to m |
11:31 |
csharp |
e |
15:45 |
Bmagic |
jeffdavis: I wonder why we didn't have this problem on 9.2 ? |
15:47 |
jeffdavis |
We figured it had more to do with needing to vacuum after the PG+EG upgrade. |
15:48 |
jeffdavis |
Hard to say, though. At least I don't think we had any definitive evidence of our conclusion. |
15:51 |
csharp |
more info on that unapi.bre error - all I've seen and tested appear to be kid's titles, so the KPAC is suspect |
15:51 |
csharp |
@blame kpac |
15:51 |
pinesol_green |
csharp: kpac forgot to give the gerbils their chocolate-frosted sugar bombs |
15:58 |
dbwells |
berick: Got the validate bits in place for AuthProxy.pm. I pushed it (plus your latest fix) out to production here locally, and am going to let it chill for a bit before pushing back to the collab branch. At this point in the day, probably going to be tomorrow. |
15:59 |
Bmagic |
jeffdavis: now that I am looking at config.tt2 I dont see where to turn off autosuggest. I would have expected to see the setting there. where is use_autosuggest.enabled ? Should I just set that variable in config.tt2? |
09:11 |
Dyrcona |
mdriscoll: That's interesting. We were talking about something similar this morning... |
09:11 |
jboyer-isl |
Ah, we're going to be leaning toward extracts/uploads with Z for availability. |
09:12 |
Dyrcona |
mdriscoll: I'll share the branch in a few minutes. |
09:12 |
mdriscoll |
Dyrcona: great I'll test it. |
09:14 |
|
yboston joined #evergreen |
09:16 |
Dyrcona |
And the search that was mentioned as a problem "harry potter rowling" works. |
09:19 |
mdriscoll |
Here's another z39.50 search with punctuation: Monsters inc (CW-9, NOBLE-3, MVLC-594) |
10:30 |
berick |
https://bugs.launchpad.net/evergreen/+bug/1384740 |
10:30 |
pinesol_green |
Launchpad bug 1384740 in Evergreen "Add authority records support to marc stream importer (Connexion)" [Wishlist,Fix committed] |
10:30 |
berick |
it's in master |
10:31 |
jboyer-isl |
berick: Huzzah! Apparently not in the 2.9.cough version I upgraded us to, but we would be happy to apply some additional in-production testing. :D |
10:32 |
berick |
awesome. we've been using the updated script for bib imports. planning to use it for auth soon. |
10:34 |
jboyer-isl |
One of your comments referenced bug 1171984 that was released sometime in 2.8, does that mean anything needs to be changed to address it, or did the options just not do anything until that bug was closed? |
10:34 |
pinesol_green |
Launchpad bug 1171984 in Evergreen "add support in Vandelay for overlaying authorities during import using match sets" [Wishlist,Fix released] https://launchpad.net/bugs/1171984 |
11:07 |
yboston |
remingtron: thanks |
11:08 |
yboston |
yboston: y por cierto muchas felicidades con lo de de tu familia |
11:09 |
yboston |
remingtron: y por cierto muchas felicidades con lo de de tu familia |
11:21 |
rjackson_isl |
berick++ - first import using patched importer and correct parameters worked - next test will be the authority side |
11:22 |
rjackson_isl |
inclued both an overlay and new recs in one imput file... |
11:22 |
rjackson_isl |
s/inclued/included |
11:23 |
berick |
sweet |
11:24 |
jboyer-isl |
Bummer. A parallel reingest is no sweat for the database, but slony does not like it one bit. :-/ |
11:25 |
Dyrcona |
Alas, poor Slony. I knew him well, Horatio. |
16:48 |
kmlussier |
Dyrcona: I was thinking it might be first by database ID. Because Magazine is not first alphabetically on webby |
16:48 |
kmlussier |
Dyrcona: Oh, so that's a problem. |
16:48 |
kmlussier |
We need an Unset there. |
16:48 |
jihpringle |
yboston: I ran into a few bugs while testing, do you know what the best way to report web client bugs is? |
16:48 |
Dyrcona |
Well, you should be able to add a copy without a circ modifier, I think. |
16:48 |
* kmlussier |
wanders off to Launchpad. |
16:49 |
kmlussier |
And this is why it always takes me so long to work on documentation. :) |
17:12 |
|
mmorgan left #evergreen |
17:37 |
kmlussier |
jihpringle: For bug 1537227, the problem is that you aren't using a registered workstation. |
17:37 |
pinesol_green |
Launchpad bug 1537227 in Evergreen "Web Client: Navigation Buttons in Catalogue Not Working" [Undecided,New] https://launchpad.net/bugs/1537227 |
17:38 |
kmlussier |
We came across that one in testing. |
17:38 |
jihpringle |
kmlussier: thanks, I thought it seemed familar |
17:38 |
kmlussier |
Which is why it's really, really important that we have a way to require workstation registration before the web client is rolled in production. There are several things that don't work as expected without a workstation. |
17:39 |
jihpringle |
yes, that;s definitely crucial |
13:31 |
mllewellyn |
IF VENDACCT == '336033V' AND VENDCODE == '1084'; ORG_UNIT_SAN = '336033V'; END; |
13:32 |
mllewellyn |
I can't figure where this LOC thing comes in. |
13:32 |
berick |
mllewellyn: oh! I should have finished reading.. |
13:33 |
mllewellyn |
I wish it were the SAN issue. :( |
13:35 |
mllewellyn |
From our test order. They added the LOC line to show me what they're expecting. |
13:35 |
mllewellyn |
UNB+UNOB:3+336033V:31B+1556150:31B+160113:1310+1' UNH+1+ORDERS:D:96A:UN' BGM+220+21423+9' DTM+137:20160113:102' NAD+BY+336033V 1084::91' NAD+SU+1556150::31B' NAD+SU+2563::92' CUX+2:USD:9' LIN+420651++6315949045:IB' PIA+5+6315949045:IB' IMD+F+BTI+:::Cinderella' IMD+F+BPU+:::Walt Disney Pictures,' IMD+F+BPD+:::2015.' IMD+F+BPH+:::1 videodisc (112 min.) ' QTY+21:5' GIR+001+BRDGOM:LLO++1:LQT+acquisitions:LST+ |
13:37 |
berick |
mllewellyn: hm, we use the LCO (copy id) field, but I don't recall using LOC |
13:38 |
* Dyrcona |
misspoke earlier. I don't have to strip quotes off the term. I misunderstood my error. :) |
13:38 |
mllewellyn |
This is for Enriched AV processing. |
15:22 |
kmlussier |
Yikes. Yeah, record buckets can only handle so many records. |
15:23 |
phasefx |
might be better in the web client with paging |
15:23 |
Stompro |
phasefx, thanks, I wasn't finding anything but wanted to double check. I need to change the item_type on 20K large print titles and I'm just trying to find the best way. I was going to try and use the marc batch edit function. |
15:23 |
kmlussier |
phasefx: You said xul client. Is there hope there will be improvement in this respect in the web client? My webby testing has been limited to buckets with 50 records. |
15:23 |
Dyrcona |
And, that is why I write so many custom scripts. |
15:23 |
miker |
if you just use them for container searches, never accessed as a list, that could be useful |
15:23 |
phasefx |
kmlussier: I think there's always hope. Not sure what the current performance is with webby |
14:12 |
krvmga |
me, too |
14:12 |
yboston |
we can swithc to that in a second. I had a goal to talk a bit about the web client hacking and we already spoke a little abotu it |
14:13 |
sandbergja_ |
sounds good to me |
14:13 |
yboston |
liek I said I will send out a link in the morning. I will also start a Google hangout in the morning |
14:13 |
yboston |
the wiki page will have login info for a test serve that can be used to document the web client |
14:14 |
yboston |
#link https://webby.evergreencatalog.com/eg/staff/ |
14:14 |
|
dluch joined #evergreen |
14:14 |
yboston |
I think that is about it. We might want to check in the morning to verify what everyone will work on |
14:15 |
yboston |
at this point we can switch to talking about the re-org |
14:16 |
yboston |
#topic docs re-org |
14:16 |
yboston |
go ahead |
14:16 |
sandbergja_ |
I think that there was a lot of excitement when we talked about it on the mailing list |
14:17 |
krvmga |
when i originally talked about this idea, i was thinking of "books" for different staff |
14:17 |
yboston |
#link http://wiki.evergreen-ils.org/doku.php?id=evergreen-docs:reorg_2014 |
14:34 |
sandbergja_ |
yes, yboston++ |
14:34 |
dluch |
yes! yboston++ |
14:35 |
sandbergja_ |
how hard would that be to achieve technically? |
14:35 |
yboston |
#idea use the new re-org layout for storing the new web client docs |
14:36 |
yboston |
my rough understanding is... |
14:36 |
yboston |
that Robert Soulliere would need to do some config set ups on his docs server |
14:36 |
yboston |
to handle a new set of templates for the new re-org |
14:37 |
yboston |
though we might want to have a final decision on the re-org style before we start this, though we can just do soemtests |
14:37 |
yboston |
*some tests |
14:38 |
yboston |
in some ways it might not be that differnt from when Robert set ups the docs foreach new version of EG |
14:39 |
yboston |
lets talk about sandbergja_ list of concers, which are very important |
14:39 |
yboston |
1) when to meet next 2) how to get more people involved |
14:40 |
yboston |
I added 3) what risks shoudl we address, I would also add 4) do we have a final re-org that we can follow |
14:40 |
sandbergja_ |
I feel like we got some consensus around (1) |
14:40 |
yboston |
any other cocnenrs or ideas that we should keep in mind, that perhaps sandbergja_ and I can add to the re-org page in preparation for the eventual re-org meeting? |
14:41 |
krvmga |
i have no others atm |
10:46 |
|
bmills joined #evergreen |
10:48 |
Bmagic |
Dyrcona: it looks like it's money.payment from this line my $last_payment = $e->search_money_payment(..... then return 1 if ($payment_ts + $interval_secs >= $now); |
10:50 |
Dyrcona |
I thought so, but wasn't sure any more. |
10:50 |
kmlussier |
That's my recollection from testing. |
10:56 |
|
maryj joined #evergreen |
11:01 |
|
Christineb joined #evergreen |
11:10 |
Bmagic |
Does anyone have a library that controls access to the public workstations via login? That uses SIP backend? |
11:40 |
kmlussier |
jboyer-isl: I got the reference. :) |
11:41 |
Dyrcona |
We use 9.3 in production and 9.1 on development/training. |
11:42 |
Dyrcona |
'Cause we've been too lazy to upgrade the second db server. |
11:52 |
csharp |
kmlussier: we're moving to 9.4 this weekend - been testing on it for months on two test servers with no issues |
11:53 |
kmlussier |
csharp: Awesome! I'll be interested in hearing how things go in production. |
12:51 |
jeff |
_bott_: is GRPL also running 9.4 in production? |
12:52 |
dbwells_ |
kmlussier: We've been on 9.4 in production since 12/22. So far, so good. |
13:47 |
|
pinesol_green joined #evergreen |
13:48 |
csharp |
@dunno |
13:48 |
pinesol_green |
csharp: I see nothing, I know nothing! |
13:49 |
jeffdavis |
I'm working on a new feature in the staff client. We're not using the web client locally yet, but if I am adding it there for feature parity, I guess I'd better know how to test it. :) |
13:49 |
csharp |
@quote random |
13:49 |
pinesol_green |
csharp: Quote #67: "< Rogan_Ni> Star Wars" (added by berick at 01:38 PM, September 17, 2013) |
13:49 |
Dyrcona |
csharp++ |
17:27 |
kmlussier |
For the logs, the depth appears to be 2. |
17:29 |
berick |
kmlussier: i believe it defaults to the depth of the staff login workstation org unit. |
17:29 |
berick |
which would be 2 in a stock EG setup |
17:31 |
kmlussier |
berick: Ah, ok. That makes sense. |
17:31 |
kmlussier |
berick: Can you guess what I'm testing right now? :) |
17:32 |
berick |
heh, i have a theory patron reg is involved |
17:34 |
kmlussier |
berick: I'm hoping to complete the testing on the latest code for the new editor tonight. |
17:35 |
berick |
kmlussier++ |
17:35 |
kmlussier |
But, first, I suppose I should feed the children. Their faces are looking a little gaunt. |
17:35 |
berick |
hah |
11:35 |
Dyrcona |
mceraso: YW! |
11:36 |
jeff |
and /cl |
11:36 |
jeff |
er |
11:47 |
dbs |
csharp: test received (on gitadmin) |
11:56 |
berick |
dbs: thought of one of your SEO talks today as google news showed a headline of 'Heartburn pills linked to increased risk of kidney disease' next to a picture of David Bowie. |
12:04 |
dbs |
berick: ouch |
12:09 |
csharp |
dbs: thanks! |
12:29 |
|
jihpringle joined #evergreen |
12:33 |
bshum |
csharp: That's happened before a couple times now |
12:33 |
bshum |
csharp: I think it's a memory killer issue |
12:33 |
jeff |
anyone generating logs should be forced to parse those logs before committing. |
12:33 |
jeff |
unparsable log entries should be a test failure. |
12:34 |
jeff |
(mostly unrelated to evergreen, just a general "if i ruled the world" whim of this morning) |
12:35 |
jeff |
i'm parsing logs generated by software which i think i wrote in 2008. |
12:43 |
tsbere |
jeff: At least once I wrote something that logged perfectly parseable logs, then the logging system changed and they became useless. So maybe not past-you's fault? ;) |
12:45 |
csharp |
yay! now I'm seeing feedbackevergreen-ils.org spam! |
12:45 |
csharp |
(meaning that all is back to normal :-)) |
14:55 |
csharp |
berick: thanks for that info - I'll stop chasing the red herring |
14:56 |
csharp |
jeff: I think your question has got me on a better track - I'll report back after checking on environment stuff |
14:56 |
berick |
the 1 exception is the initial "what am I processing" query taking longer than the $req_timeout, in which case the events would never even get created |
14:57 |
csharp |
well, the good news is that I'm working this out now on a test server rather than doing it next week when everythings on fire ;-) |
15:05 |
Dyrcona |
@praise csharp |
15:05 |
* pinesol_green |
You don't want to get mixed up with someone like csharp. csharp is a loner, Dottie. A rebel. |
15:06 |
bshum |
Memory killers |
10:35 |
Bmagic |
mmorgan: bug 1532236 |
10:35 |
pinesol_green |
Launchpad bug 1532236 in Evergreen "Evergreen should allow for HTML formatted action trigger emails" [Undecided,New] https://launchpad.net/bugs/1532236 |
10:36 |
mmorgan |
Bmagic++ |
10:39 |
Dyrcona |
Hmmm... Maybe 1.4 million barcodes are a bit much for a test. |
10:40 |
mmorgan |
Dyrcona: That would be a thorough test ;-) |
10:42 |
Dyrcona |
Yeah. I'm not sure it would upload though, the file is 21.1 MB according to Nautilus File Manager. |
10:43 |
Dyrcona |
I recall reading somewhere that the limit is 10 MB unless you change it, but that could have been inaccurate information. |
10:45 |
csharp |
Bmagic: regarding bug 1532236, we've been wanting HTML email too - not sure if it needs a new A/T reactor or if we can encode some logic into the current SendEmail.pm that would do what we're after |
11:07 |
|
Christineb joined #evergreen |
11:28 |
|
sandbergja joined #evergreen |
11:31 |
Stompro |
Bmagic++ tsbere++ I've been wondering how to create HTML notices for a while. I think cover art included in notices would be appreciated by many customers. |
11:31 |
Bmagic |
excellent - some testing would great |
11:38 |
tsbere |
Stompro: I disagree on the cover art bit, but as I mentioned yesterday I tend to disable HTML/Rich Text email viewing in general. |
11:43 |
Stompro |
tsbere, the multipart should take care of text email purist such as yourself. The docs to can stress the importance of including the text only version. |
11:56 |
tsbere |
Stompro: I just don't like the idea in general. Then again, I dislike the fact email supports HTML in the first place. Too many things can be "hidden", like link targets. >_> |
11:34 |
* csharp |
finds http://wiki.evergreen-ils.org/doku.php?id=dev:browser_staff:dev_notes |
11:34 |
Dyrcona |
Actually, we're using less these days. |
11:35 |
Dyrcona |
Yeah, I remember reading that there was a reason. |
11:35 |
berick |
Dyrcona: i was wondering about real-world data. most of my tests were on develpment servers. |
11:35 |
Dyrcona |
I can take a peek later. |
11:37 |
csharp |
ah - there it is: https://esilibrary.com/exploring-websockets-and-evergreen-iii-proof-of-concept/#sthash.XUhhjAT7.dpbs |
11:39 |
* berick |
keeps meaning to try https://www.nginx.com/blog/websocket-nginx/ |
11:41 |
pinesol_green |
kitteh_ wrote The Great Big Book of Evergreen. |
11:43 |
|
bmills joined #evergreen |
11:43 |
|
mllewellyn joined #evergreen |
11:45 |
jeff |
I'm thinking of scripting up a SIP smoke test to retrieve all patrons and all items via SIP with the intent of uncovering ways that SIPServer and/or the Evergreen SIP implementation fall over. I might later expand it a bit. Would anyone here be interested in running something like that against live data in a test system? |
11:45 |
jeff |
I suppose I'll just try and make it vaguely non-specific and share and go from there. |
11:45 |
csharp |
jeff: yes, but after our upgrade over next weekend |
11:46 |
jeff |
csharp: what, not during!? |
11:47 |
berick |
wimp |
12:47 |
pinesol_green |
Launchpad bug 1470957 in Evergreen 2.9 "Items are incorrectly sorting when using the Sort By Publication date feature" [Medium,New] |
12:47 |
bshum |
So weird stuff happens with pubdate sorting |
12:47 |
kmlussier |
krvmga: Yeah, looking at bug 1470957, I see it refers to date1, which is a fixed field thing. |
12:47 |
berick |
speaking of acq, looking for takers to test bug #1333254. (No EDI required). |
12:47 |
pinesol_green |
Launchpad bug 1333254 in Evergreen "EDI invoices automatically expend debits" [Wishlist,Confirmed] https://launchpad.net/bugs/1333254 |
12:48 |
kmlussier |
huh, pinesol_green must like berick more than me. |
12:48 |
kmlussier |
bug 1470957 |
13:56 |
csharp |
since bug 1207533 renders Triggered Events effectively useless, we're thinking of greying it out instead |
13:56 |
pinesol_green |
Launchpad bug 1207533 in Evergreen 2.9 "Triggered event log times out for large-data sites" [Medium,Confirmed] https://launchpad.net/bugs/1207533 |
14:02 |
|
Stompro joined #evergreen |
14:18 |
tsbere |
csharp: I bet it is because they share a URL |
14:23 |
tsbere |
csharp: More specifically, I believe the issue is related to the deck.js file and the fact they both use the "browser" URL as their target. |
14:25 |
* tsbere |
has an idea to fix it, but wants to test it quick first....which means waiting for his dev machine to reload |
14:29 |
|
jihpringle_ joined #evergreen |
14:29 |
|
jboyer_isl joined #evergreen |
14:29 |
|
collum joined #evergreen |
14:29 |
|
gsams joined #evergreen |
14:32 |
csharp |
tsbere: I'm heading home, but I'll check back in when I get there (FYI, in case you get to a point where I can assist with testing) |
14:33 |
tsbere |
csharp: My test says my idea works. I'll make a working branch for you to poke at. |
14:33 |
csharp |
rock on |
14:36 |
|
rangi` joined #evergreen |
14:36 |
tsbere |
@later tell csharp http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/differentiate_patron_urls |
16:03 |
Bmagic |
agreed - in fact that is our plan |
16:03 |
Bmagic |
but in order to do that, it seems, we have to change the code to "not mess with our headers" |
16:05 |
tsbere |
Bmagic: Should be trivial to make such changes, from what I can see. |
16:05 |
Bmagic |
tsbere: we have it working on a test server by commenting out the three lines there in SendEmail.pm |
16:05 |
Bmagic |
But I thought I would ask if anyone else accomplished this |
16:07 |
tsbere |
Bmagic: I would change them to have "unless $email->header('???')" on the end. |
16:07 |
tsbere |
Then if the A/T sets the headers they stay as what the A/T set, otherwise they get the (hopefully sane) defaults |
17:08 |
TheMadGunt |
Hello out there |
17:08 |
hopkinsju |
The problem is that a search from their system to ours will turn up results one time, then subsequent searches for the same thign turn up 0 results. It'll do that for a while before it starts working again. Seems to me that their system is dropping the connection. |
17:08 |
hopkinsju |
Hi there TheMadGunt |
17:10 |
TheMadGunt |
I was hoping someone could help me out. Stuck on a step doing a test server install |
17:11 |
TheMadGunt |
Step 10.2 - Creating the Database |
17:11 |
bshum |
hopkinsju: It wouldn't surprise me if there was something funky going on. Any log data to support your theory? For us, I always smirked at their SUPER old version of yaz that they were using. |
17:11 |
hopkinsju |
Cool, well hopefully we can help you :-) |
17:14 |
bshum |
Are you using "server edition" 64-bit Ubuntu 14.04 |
17:14 |
bshum |
Not Desktop edition |
17:14 |
TheMadGunt |
No, not desktop |
17:14 |
bshum |
The desktop edition sometimes does funky things and has broken installers. |
17:14 |
bshum |
And nobody's tested on 32-bit anything in... well, forever, probably. |
17:15 |
hopkinsju |
I'm going to turn up logging. |
17:15 |
TheMadGunt |
cool. let me give that a shot and I'll report back either way. THANKS! |
17:15 |
bshum |
Good luck! |
17:16 |
bshum |
Apparently. |
17:16 |
hopkinsju |
*eyeroll* |
17:16 |
* bshum |
smirks at hopkinsju |
17:16 |
TheMadGunt |
I'm in NY. Best time to work on testing things. |
17:16 |
TheMadGunt |
no one to interrupt me. :) |
17:16 |
bshum |
Good stuff... /waves hi from CT |
17:16 |
hopkinsju |
4pm is usually about the time when I can stop checking email and putting out fires and actually get to work. |
13:56 |
bshum |
We got something like <xsl:variable name="locname" select="$lid" /> in our .xsl file that draws from |
13:56 |
bshum |
So I assume that's how we get the full name of the library for lid |
13:57 |
jboyer_isl |
I think ours was an xsl change. That’s what I was referring to with the contains comment. Something in the xslt processing was using it instead of =. |
13:57 |
bshum |
Maybe I'll make a new variable |
13:57 |
bshum |
And test it by changing one of them to use shortname |
13:57 |
bshum |
And then convert everything over |
14:22 |
bshum |
In any case, tsbere++ rjackson_isl++ jboyer_isl++ |
14:22 |
bshum |
Thanks for feedback guys! Appreciate it :) |
15:05 |
|
graced joined #evergreen |
15:16 |
|
Ivran joined #evergreen |
15:19 |
Ivran |
Would someone be able to tell me what I am doing wrong in trying to run this Evergreen report...? All I am trying to do is run a report that counts the number of patrons assigned a particular stat category. |
15:29 |
bshum |
I think I've heard of what jboyer_isl is describing, but unfortunately have not used it before |
15:32 |
jboyer_isl |
It lets you choose between left, inner, and sometimes right joins on the tables in the reporter. Default means “whatever the system thinks is best” which is usually left, I think. |
15:34 |
|
Ivran_ joined #evergreen |
15:34 |
Ivran_ |
I don't think the web client likes me very much. -- I will give the nullability a test and see what I can learn, though! |
15:37 |
jboyer_isl |
Ivran: you’ll probably want to choose links that have None in the Nullable column when you’re selecting the stat cat fields. That way you can inner join the user and SC tables to only look at users with SC entries, then you have to display the entry value (not sure of the field names off hand) and a count distinct on entry id to get the totals for each value. |
15:38 |
Ivran_ |
jboyer_isl: Thank you! I think I can attempt that well enough. I'll see what I can do. |
15:41 |
Bmagic |
Ivran_: I have had similar difficulties with stat cats - nullable is the answer |
15:41 |
Bmagic |
because not all patrons have a row in the stat cat tables |
15:43 |
Ivran_ |
I'm brand new to this, so I just keep trying until I get it. |
15:49 |
Ivran_ |
Ciao for now. I'll come back if I can't figure it out. Thank you! |
15:58 |
bshum |
dbwells: https://bugs.launchpad.net/evergreen/+bug/1526543 didn't have a pullrequest on it, but it looked fine for testing, I'm going to go ahead and push it through, though for note, the default is that reset_password = 'true' so the test approach as described confused me initially :\ |
15:58 |
pinesol_green |
Launchpad bug 1526543 in Evergreen 2.9 "Cannot disable password reset in TPAC" [Low,New] |
15:59 |
bshum |
I may update the test instruction in the git commit message to reflect the actual default and the need to alter the config.tt2 to set that to false. |
16:01 |
dbwells |
bshum: heh, sorry about that. I guess I assumed it was false, since optional things are often off by default. It does make more sense now that nobody else notice it :) And, thank you! |
16:02 |
bshum |
dbwells: Cool, cool |
16:02 |
bshum |
dbwells++ remingtron++ |
10:27 |
miker |
np |
10:28 |
|
mrpeters joined #evergreen |
10:51 |
|
Christineb joined #evergreen |
11:19 |
jeff |
Hrm. Anyone know offhand what semi-common process can cause a hold to change shelf_time and shelf_expire time? |
11:19 |
jeff |
I wonder if simply re-scanning an already on-shelf hold does that. |
11:19 |
* jeff |
tests |
11:21 |
berick |
pretty sure it would take more than that |
11:21 |
berick |
it would have to be un-shelved in some way |
11:22 |
berick |
i think. like, pickup_lib changed, checked in, changed back, checked in later. |
11:23 |
jeff |
Current example happened at a branch other than the one I'm at. Drat. |
11:25 |
* jeff |
tests |
11:29 |
jeff |
Yeah, it's not a simple "scan it again". |
11:29 |
jeff |
At least, not with default checkin modifiers, etc. |
11:42 |
jeff |
Okay, in this specific example it was "patron didn't want the hold anymore, staff were unfamiliar with how to cancel a hold" |
11:43 |
jeff |
So they did a few things, presumably one of which involved reset/retargeting the hold. |
11:43 |
jeff |
Then they just left it in its captured on-holdshelf state and chucked it in the bin for transit to the owning library. |
11:43 |
jeff |
So we went over how to cancel a hold. |
11:47 |
tsbere |
jeff: I can think of two things. One being manual "find another target" triggering, the other being "the copy that *was* on the shelf was checked out to someone else, and now that is a new copy" |
11:47 |
* tsbere |
is amazed he hasn't had to dig out records of the latter in the past few months, actually... |
11:51 |
jeff |
amusing when the target of a ready for pickup hold changes. |
12:29 |
jeff |
There is a working repo, and a launchpad instance. |
12:29 |
jeff |
http://git.evergreen-ils.org/?p=working/SIPServer.git;a=summary |
12:30 |
Bmagic |
oh |
12:30 |
jeff |
https://bugs.launchpad.net/sipserver |
12:30 |
jeff |
keys via the usual means -- i'd test to see if yours are already in place. |
12:31 |
Bmagic |
weird, I see that I somehow have a commit there already |
12:31 |
jeff |
I suspect that any keys submitted added after the creation of that repo are already in place, but I'm not certain. |
12:31 |
Bmagic |
lol, I guess I forgot |
05:09 |
|
rlefaive joined #evergreen |
07:32 |
jboyer-isl |
miker: Yeah, just venting. I'm probably going to try a couple of OS tests today. (never got around to it yesterday.) The only difference between our G8 server that's working perfectly and these G9's that aren't are their G's. (Same NICs, etc.) I may try 12.04 to see if it makes any difference. |
07:33 |
jboyer-isl |
I would be equal parts relieved / disappointed if that works. |
07:43 |
|
graced joined #evergreen |
07:49 |
|
mrpeters joined #evergreen |
07:54 |
|
rlefaive joined #evergreen |
07:55 |
|
rjackson_isl joined #evergreen |
07:57 |
|
ericar joined #evergreen |
08:08 |
miker |
kmlussier: from yesterday afternoon, I've updated the bugs. tl;dr: mod_perl code is not feasibly testable in the way that opensrf app code (via live tests) or db changes (via pgTAP) are -- and, the changes are covered by syntax checks to the same degree as the rest of the mod_perl code, already. |
08:08 |
* miker |
runs away for an appointment |
08:32 |
|
mrpeters1 joined #evergreen |
08:45 |
|
jboyer-isl joined #evergreen |
08:46 |
|
Dyrcona joined #evergreen |
09:58 |
|
jwoodard joined #evergreen |
10:04 |
Dyrcona |
"He's running the scripts....He's checkin' 'em twice." |
10:04 |
Dyrcona |
"He's gonna find out which are naughty or nice." |
10:05 |
Dyrcona |
"Santa Dev is testing a branch." |
10:05 |
Dyrcona |
Don't mind me.... |
10:06 |
miker |
Dyrcona: when I'd just seen the first line I heard it to the tune of going the distance by cake... |
10:06 |
Dyrcona |
heh. |
10:06 |
Dyrcona |
That could make a good base for a development parody song, too. |
10:07 |
Dyrcona |
He's runnin' the perl tests....He's timin' for speed.... |
10:15 |
jeff |
I wonder if metacpan has a "rhymes with" search option for modules... |
10:26 |
|
rlefaive joined #evergreen |
10:54 |
|
ericar_ joined #evergreen |
11:06 |
Dyrcona |
4518 files changed, 1017556 insertions(+), 300704 deletions(-) |
11:10 |
tsbere |
Was a bit behind master. ;) |
11:10 |
Dyrcona |
6,882 commits behind you said. |
11:11 |
csharp |
@quote add 10:04 < Dyrcona> "He's running the scripts....He's checkin' 'em twice. He's gonna find out which are naughty or nice. Santa Dev is testing a branch." |
11:11 |
pinesol_green |
csharp: The operation succeeded. Quote #134 added. |
11:12 |
tsbere |
Not that the rebase changed much beyond "stop merge from throwing a minor fit", I believe |
11:12 |
Dyrcona |
Yeah, warnings about inexact rename detection and setting a limit to at least 2,977. ;) |
10:52 |
* Dyrcona |
isn't surprised. |
10:53 |
Dyrcona |
i might be surprised when you figure out the why, however. ;) |
10:54 |
* Dyrcona |
should revisit the circ history download bug with a new solution. |
10:55 |
kmlussier |
Once I focused just on patches added since August, the number requiring tests wasn't so high. |
10:55 |
* kmlussier |
returns to actual testing now. :) |
10:55 |
tsbere |
jeff: Do you have metarecord or part holds on no longer existing metarecords/parts? |
10:55 |
Dyrcona |
That would not surprise me. |
10:56 |
Dyrcona |
And I was think parts holds on part that have since disappeared. |
12:51 |
kmlussier |
But I know it doesn't reflect all of the work that has been happening |
12:53 |
|
mrpeters1 joined #evergreen |
13:14 |
|
mrpeters joined #evergreen |
13:19 |
mmorgan |
Bmagic: I'm testing lp 1331174. and am curious what your intervals for LONGOVERDUE and LOST are in production. |
13:19 |
pinesol_green |
Launchpad bug 1331174 in Evergreen "Long Overdue processing needs org unit settings separate from Lost Processing" [Wishlist,Confirmed] https://launchpad.net/bugs/1331174 - Assigned to Michele Morgan (mmorgan) |
13:20 |
mmorgan |
The seed mark Long Overdue trigger worked fine to mark items long overdue at 6 months. |
13:22 |
mmorgan |
Then I changed the mark Lost trigger to mark the items Lost at 7 months. But the Lost trigger didn't find anything to mark Lost. It's looking for transactions with stop_fines NULL or MAXFINES, so my LONGOVERDUE transactions didn't get picked up to be marked Lost. |
13:22 |
mmorgan |
Are you using a custom filter for this? |
13:24 |
|
mrpeters joined #evergreen |
13:31 |
* mmorgan |
run out for a bit |
13:38 |
jihpringle |
kmlussier: Am I correct in assuming that the mlnc2 test server isn't generating and sending email? |
13:39 |
jihpringle |
I've tested lp 1197636 up to the point where the email should be sent |
13:39 |
pinesol_green |
Launchpad bug 1197636 in Evergreen "Email record detail does not check for email" [Medium,Triaged] https://launchpad.net/bugs/1197636 - Assigned to Jennifer Pringle (jpringle-u) |
13:40 |
tsbere |
jihpringle: I do not believe any of those mlnc servers were set up for actually sending email. In general. |
13:45 |
kmlussier |
jihpringle: Sorry! You're correct. It's not configured to send email. I totally overlooked that need when I was setting it up. |
14:26 |
|
DPearl joined #evergreen |
14:28 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1319998 Stamping upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3e831ac> |
14:28 |
pinesol_green |
[evergreen|blake] LP1319998_materialized_summary_billing_del_ADDS_to_balance_owed - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=574cab2> |
14:41 |
jboyer-isl |
miker, Dyrcona: Just getting back from a meeting and reading scrollback. I had not come across suggestions to check that (my google-fu was weak) and it never occurred to me because 2015, but I'm absolutely testing that now. I was about to go install another OS to test, this is much faster. |
14:42 |
jboyer-isl |
If it works, you each get a meal/drink on me in NC. |
14:43 |
* mmorgan |
returns and catches up. |
14:45 |
jeff |
ahh, the fond days when 3com switches could lock up Cisco ethernet interfaces hard enough that Cisco would RMA them, but they really just needed to be power cycled. |
14:47 |
jlundgren |
I think I just confirmed my first (new) bug - https://bugs.launchpad.net/evergreen/+bug/1513231 |
14:54 |
jboyer-isl |
Oops, sad trombone. |
14:58 |
kmlussier |
mmorgan: Are you thinking that you would be setting a transaction to Longoverdue without a bill after, say, 3 months, and then setting it to Lost, with a bill after something like 6 months? |
14:59 |
|
jlundgren1 joined #evergreen |
14:59 |
mmorgan |
kmlussier: That's the scenario I'm testing, yes. |
15:00 |
kmlussier |
Bmagic / mmorgan: Would it be reasonable, then, to add a separate "Lost from Long Overdue" trigger that has the necessary json for those sites that want to use that workflow? |
15:01 |
kmlussier |
I can see why you wouldn't want to add it to the typical Lost trigger since there are sites that want to set it and leave it at Long Overdue. |
15:02 |
Bmagic |
kmlussier: it's probably not a bad idea to throw a stock AT idea in the branch - but there are a few possibilities |
15:15 |
mmorgan |
Would clear documentation on how to accomplish the longoverdue to lost be generally accepted? Or is it better to have the examples? |
15:19 |
jboyer-isl |
Network? More like Notwork. |
15:19 |
mmorgan |
jlundgren++ |
15:21 |
kmlussier |
Christineb: Would it be helpful to try the same workflow (if you have time) on another masslnc VM to see if the issue you encountered was caused by the new code? |
15:21 |
kmlussier |
Christineb: The VM's are nearly identical with the exception of the branches that were added for testing. |
15:21 |
Christineb |
kmlussier - Oh great idea, I will try that |
15:23 |
kmlussier |
mmorgan: I think it's generally preferable to have examples, but I don't think the lack of them is a showstopper. But I want to take a closer look at it too. |
15:24 |
kmlussier |
Christineb: You could probably hop on the one jihpringle is using. The access info is on the same spreadsheet. |
16:44 |
kmlussier |
dbwells: I had hoped to look at bug 1422379 today, but it looks like it wasn't meant to be. I hope to put some eyes on it soon, though. |
16:44 |
pinesol_green |
Launchpad bug 1422379 in Evergreen "Move money.billing timestamps back to moment of fine" [Medium,Triaged] https://launchpad.net/bugs/1422379 - Assigned to Kathy Lussier (klussier) |
16:45 |
dbwells |
kmlussier: Hey, thanks for trying. I've been looking at bugs for the last hour or so, and also generally getting stuck in one way or another. |
16:45 |
jlundgren1 |
stompro++ for testing in master build - https://bugs.launchpad.net/evergreen/+bug/1312699 |
16:45 |
pinesol_green |
Launchpad bug 1312699 in Evergreen "Editable Checkout History" [Wishlist,Triaged] - Assigned to Josh Stompro (u-launchpad-stompro-org) |
16:45 |
kmlussier |
Stompro: I'll need to check, but I think the sorting is something that is present in master already. It was a new 2.9 feature |
16:46 |
dbwells |
I think I'll report some "new" bugs instead (stuff we've had in production for a while, in some cases :( ). |
17:18 |
kmlussier |
Good night mmorgan! |
17:18 |
kmlussier |
Ah well, a bit too late |
17:19 |
miker |
jboyer-isl: based on "network? more like notwork" I'm guessing duplex and speed autosense was not the issue? |
17:23 |
kmlussier |
Just took a look at the signedoff bugs that also has a needstest bug. Other than the bug gmcharlt already commented on, there are two from miker http://bit.ly/1UvXOvc |
17:24 |
kmlussier |
miker: If those are examples of bugs where tests would be infeasible, could you note that on the bugs? I don't have a clear sense of what's infeasible and what's doable. |
17:37 |
kmlussier |
"101 bugs reported by me" Looks like I missed an opportunity to celebrate when I hit the 100 mark. |
17:40 |
berick |
bummed I could not participate today. |
17:40 |
berick |
bug_squashers++ |
17:42 |
kmlussier |
berick: Well, you do a lot of fixing between Bug Squashing Days. :) |