02:11 |
|
Mark__T joined #evergreen |
02:51 |
|
jeff_ joined #evergreen |
04:23 |
|
Callender joined #evergreen |
05:02 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
07:41 |
|
mrpeters joined #evergreen |
07:49 |
|
jboyer-isl joined #evergreen |
08:02 |
|
rjackson_isl joined #evergreen |
09:27 |
RoganH |
I haven't had to clean up dog accidents in a while but we get a new foster dog today so that'll probably change. |
09:28 |
|
yboston joined #evergreen |
09:28 |
Bmagic |
ldw: acq.fund_allocation has 2 rows for the fund in question. The first row was the addition of the moneys. The second is the negative amount to balance it to 0. |
09:29 |
RoganH |
Quick opinion question. bshum and I were chatting at ALA and he opinioned that pgtap tests for has_table and has_view tests would be good to have. Drudgery to write but good to have. I'd be willing to write them if they'd be useful. |
09:30 |
Bmagic |
ldw: I deleted the row that was added after the rollover. Specifically, I just changed the fund id number to point to this years fund instead of last years fund. I realize that perhaps there are some database triggers that need to fire, and I just changed the ID, perhaps they didnt fire |
09:37 |
csharp |
RoganH: can you easily summarize what they do? or is that a job for the Goog? ;-) |
09:38 |
jboyer-isl |
RoganH: That does sound useful in a “You have a sane database, you’re off to a good start” kind of way. It shouldn’t be too difficult to build, a couple carefully constructed queries from INFORMATION_SCHEMA and you’re halfway there. |
09:39 |
csharp |
okay, so they just check for whether the table/view exists then? |
09:39 |
csharp |
if so, yeah |
09:39 |
jboyer-isl |
I can’t remember if pgtap has something like has_index, but that would also be a big help for those of us with long upgrade histories. (hi csharp!) |
09:40 |
csharp |
I still occasionally find a missing table or index from the 1.6 - 2.1 upgrade we did over three years ago, so yeah, I'd like that sort of test :-) |
09:41 |
csharp |
jboyer-isl: exactly ;-) |
09:41 |
RoganH |
csharp: basically they verify that the tables and views that should be there are |
09:41 |
RoganH |
jboyer-isl: exactly |
09:42 |
RoganH |
jobyser-isl: yep, it has has_index |
09:42 |
RoganH |
I'd be willing to write the has_index tests too |
09:49 |
csharp |
RoganH++ |
09:49 |
kmlussier |
RoganH++ |
09:49 |
jboyer-isl |
RoganH++ |
10:04 |
jboyer-isl |
It may help to use tables_are rather than has_table, that way you can verify whole schema at a time rather than each table individually. |
10:05 |
jboyer-isl |
There are also indexes_are and schema_are, etc. |
10:05 |
jboyer-isl |
Arr! |
10:05 |
RoganH |
jobyer-isl: The downside of using _are is that if people have added extra tables it will trigger that as a fail on the test. |
10:06 |
RoganH |
jobyer-isl: so I was thinking of doing both so that if one passes and the other fails you know it's only because of the added tables/views/whatever. |
10:06 |
jboyer-isl |
Oh, I might have misread then, I thought it only complained about missing, but that makes sense. |
10:06 |
RoganH |
jboyer-isl: my apologies for butchering 'boyer' twice in a row! |
10:07 |
RoganH |
jboyer-isl: let me check, maybe I'm wrong |
10:07 |
jboyer-isl |
You should hear how some other people have tried to spell it over the years. “Is that wirh a “W”? how many “Y”’s, etc.) |
10:07 |
RoganH |
jboyer-isl: I get it with Rogan a lot though you wouldn't think it's that hard to pronounce or spell |
10:10 |
RoganH |
jobyer-ils: yeah, the _are functions check to see if there are extra tables/views/whatever and fail the test then |
10:10 |
RoganH |
So I lean to including both for more granularity of testing. |
10:11 |
RoganH |
Once I've pulled the tables/views/whatever out of information_schema it won't be that big a deal to do both |
10:11 |
jboyer-isl |
Yeah, I should have read more closely. In that case I’d be hesitant to use the _are functions because I’m always wary of “it’s ok if X fails” and the like. (Now, I also think anyone adding any tables should do it in a separate schema like local. or similar, but I don’t want to argue about it) |
14:18 |
yboston |
of course swap out phones for whatever technology you prefer |
14:19 |
rfrasur |
Let's revisit it. I will say that I'm not a big fan of phone meetings just because I process information visually and because of recordability issues. |
14:19 |
rfrasur |
Oh, okay, lol. |
14:19 |
tspindler |
fyi, if we want to test it out, C/W MARS has a go to webinar account to accomodate up to 100 |
14:19 |
montgoc1 |
I enjoyed the last phone meeting and it is nice to hear voices once in a while. |
14:19 |
rfrasur |
tspindler++ |
14:19 |
yboston |
tspindler: would you like to set up a test a few motnhs from now? |
14:19 |
abneiman |
I've expressed my preference before about phone meetings, in the sense that I feel they facilitate more conversation. |
14:19 |
tspindler |
yboston: yes I can |
14:19 |
abneiman |
However I understand the need to balance that with openness, convenience, etc. |
14:23 |
tspindler |
yboston: I could set up a session with go to webinar sometime (not as a meeting) but anyone can then participate and see how it works |
14:23 |
csharp |
we can research it |
14:23 |
sherbertbc |
rfrasur: agree on 4 months to revisit |
14:23 |
yboston |
so team has volunteered his system, would somebody like to volunteer to test out using Google Hangout? |
14:24 |
yboston |
sorry Tim not team |
14:24 |
csharp |
the only downside is that it requires a google account to access it, and (theoretically) some may object to that being a barrier to participation |
14:24 |
rfrasur |
Well, we tested that already for the meet and greet. |
14:25 |
rfrasur |
But, I can test a Google On Air Hangout, if that's what you mean. |
14:25 |
csharp |
we have a Chrome for meetings box at GPLS that is severely underutilized |
14:25 |
csharp |
I'll investigate that |
14:25 |
yboston |
so 4 months from now is November, we can just shoot to try a meeting with either technology by then |
14:25 |
yboston |
sorry, just trying to come up with actionable items |
14:25 |
rfrasur |
csharp++ #I don't know anything about that. Sounds interesting. |
14:26 |
tspindler |
yboston: I'll announce a test meeting in the next 2 months to use our GoToWebinar so we can test it and invite other members of the Evergreen community to join if they want. |
14:26 |
yboston |
OK |
14:27 |
yboston |
#action tspindler will announce a test meeting in the next 2 months to use our GoToWebinar so we can test it and invite other members of the Evergreen community to join if they want. |
14:28 |
yboston |
#idea use non IRC meetigns when there are topics where IRC might not feel like the best medium |
14:28 |
tspindler |
yboston: do you have any theoretical situations where this is the case? |
14:28 |
yboston |
#idea if using Google Hangouts, use the "on air" feature to allow others to watch/listen |
14:29 |
csharp |
yeah, I think if we meet the criteria of 1) openness to non-board attendees and 2) recording for posterity, I think that would fly with most people |
02:10 |
|
TaraC joined #evergreen |
04:28 |
|
_robbat2|irssi joined #evergreen |
04:51 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
05:34 |
|
Mark__T joined #evergreen |
07:44 |
|
rjackson_isl joined #evergreen |
07:48 |
|
jboyer-isl joined #evergreen |
10:54 |
csharp |
well, they can for us, so I'm trying to rule out the possibility that this is an EG bug or something in our setup |
10:54 |
* bshum |
can double check |
10:54 |
csharp |
bshum++ #thanks! |
10:56 |
bshum |
csharp: When I use an expired staff account, I can still log into the staff client with it. |
10:56 |
bshum |
That's fun. |
10:56 |
bshum |
At least on one of my master test servers. |
10:56 |
csharp |
excellent - it's not just me! |
10:57 |
bshum |
So I presume that qualifies your 2.7+ |
10:57 |
csharp |
@bugforeveryoneorjustme.com |
12:56 |
bshum |
mmorgan++ # That sounds like it could be a culprit... |
13:07 |
jeffdavis |
It's a good suggestion, but the session itself seems fine. With these steps: (1) login, (2) pull authtoken for login from logs, (3) attempt offline circ upload and get the NO_SESSION error, (4) do 'request open-ils.auth open-ils.auth.session.retrieve "AUTHTOKEN"' via srfsh and I can retrieve the session. |
13:08 |
jeffdavis |
Sorry for the incoherent grammar :) |
13:12 |
jeff |
jeffdavis: check your offline-config.pl to ensure that it is valid and correct, not pointing to an old opensrf_core.xml? |
13:14 |
jeff |
jeffdavis: i would expect things to fail before that error if you had a missing config, but if the config is valid, but for testing and not production, or similar... the memcached instance isn't going to have your session token. |
13:16 |
berick |
and make sure you don't see this near the top offline.pl: |
13:16 |
berick |
do '##CONFIG##/offline-config.pl'; |
13:17 |
berick |
##CONFIG## is replaced during build |
14:05 |
jeffdavis |
dbwells: Yes, I am seeing "No user in the cache exists with key oils_auth_" (i.e. with ses missing) after clicking "Upload" |
14:22 |
|
ningalls joined #evergreen |
14:23 |
dbwells |
jeffdavis: This might be an odd question, but what do you see for the offline GET requests in the Apache access log? Is 'ses' missing there, too? (If not, maybe this is a quirk with the Apache config.) |
14:24 |
jeffdavis |
ses is present and correct on the GET requests. |
14:29 |
jeffdavis |
hm, no, I take it back. When I click Upload, there is a GET /cgi-bin/offline/offline.pl which is missing cgi params, although they are present for other requests to offline.pl |
14:33 |
jeffdavis |
When it works on a test server, I see GET requests to upload_xacts.xhtml and upload_xacts.js, then POST /cgi-bin/offline/offline.pl, then GET /cgi-bin/offline/offline.pl with cgi params. |
14:33 |
jeffdavis |
When it fails in production, I don't see the post, and the subsequent GET /cgi-bin/offline/offline.pl is missing CGI params. |
14:40 |
Bmagic |
csharp: more on the invoces: We send a purchase order for a specific provider+vendorcode. The EDI goes to Baker and Taylor with that embedded. The invoice that we get back does not contain the specific vendorcode and therefore it's up to Evergreen to decide which to link. |
14:41 |
|
RoganH joined #evergreen |
14:42 |
Bmagic |
csharp: presumably Evergreen has all of the information in order to link it back to correct vendor code because the invoice mentions the PO number. And the PO has the vendorcode. But on my server, it's linking it back to a different vendorcode that seemly random |
00:30 |
|
bmills joined #evergreen |
01:28 |
|
Mark__T joined #evergreen |
02:17 |
|
bmills joined #evergreen |
04:56 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
06:40 |
|
rlefaive joined #evergreen |
07:16 |
|
rlefaive joined #evergreen |
07:32 |
jeff |
@coffee everyone |
09:33 |
* Dyrcona |
taps foot in annoyance. |
09:44 |
|
rlefaive joined #evergreen |
09:56 |
|
remingtron joined #evergreen |
10:09 |
jboyer-isl |
Dyrcona: for simple tests, you could consider using the Evergreen migration tools to just pull out one or two of your libs data for quicker restores. (depending on your wait time, that is.) |
10:09 |
Dyrcona |
jboyer-isl: But, we use this database for training library staff, so it is nice to have it up to date with production from time to time anyway. |
10:10 |
jboyer-isl |
Oh yeah, you did mention it was a training system. I was thinking just a quick test server setup. |
10:12 |
|
mllewellyn joined #evergreen |
10:35 |
Dyrcona |
heh. After you login, you get a message that you may need a special password, i.e. different from the production server. |
10:38 |
Dyrcona |
And LookupUser works, so I s'pose the configuration is correct. |
10:49 |
kmlussier |
Dyrcona: Good luck with the testing. I hope it goes well! |
10:50 |
Dyrcona |
kmlussier: Thank you. I hope it doesn't eat up the whole of my "vacation." |
10:50 |
kmlussier |
Dyrcona: I hope not either. |
11:02 |
|
rlefaive joined #evergreen |
11:57 |
berick |
jboyer-isl: yep |
11:58 |
jboyer-isl |
Ah. I wasn't interested enough to look into it and we pull sip logs out by machine name now. |
11:58 |
jboyer-isl |
Fixing the actual issue would be nice though. |
11:59 |
berick |
yeah, it was always just a minor annoyance for me, until recently when we migrated to ubuntu (which included all kinds of packaage updates, etc.) the PID was no longer appearing in the SIP syslog output |
12:00 |
berick |
which makes tracking conversations practically impossible |
12:00 |
berick |
SIP enables the syslog pid format, but opensrf does not, so it was getting clobbered |
12:01 |
berick |
testing my patch now on our test sip server fixes both issues (format and destination) |
12:05 |
berick |
now just need to teach SIP to read syslog_facility from oils_sip.xml instead of hard coding it |
12:06 |
jboyer-isl |
berick++ |
12:06 |
jboyer-isl |
Getting things done over there. |
12:14 |
dbs |
berick++ |
13:22 |
|
ericar_ joined #evergreen |
14:11 |
|
nuentoter joined #evergreen |
14:12 |
nuentoter |
quick question, anyone running ubuntu and evergreen on a vmware/virtualbox? |
14:13 |
bshum |
nuentoter: for testing, virtualbox, sure. |
14:13 |
bshum |
For production? No. |
14:13 |
nuentoter |
ok thats what i wanted to know ty very much sir |
14:13 |
bshum |
We do use other virtualization for applications |
14:13 |
bshum |
Err, okay then. |
01:35 |
|
Mark__T joined #evergreen |
01:46 |
|
sbrylander joined #evergreen |
05:04 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
06:51 |
|
TaraC joined #evergreen |
07:37 |
|
jboyer-isl joined #evergreen |
07:38 |
|
gsams joined #evergreen |
12:21 |
jeff |
There isn't a SetEnvIf equivalent for PerlAddVar, but in theory you could modify EGWeb.pm to push an ENV var as the "first" template path if it was set. Other than usual testing, I'd also look to make sure that such a change wasn't going to break the new template caching. |
15:47 |
pdot2 |
2015-07-07 15:45:57 EDT STATEMENT: INSERT INTO actor.usr (profile, juvenile, usrname, claims_returned_count, family_name, first_given_name, expire_date, id, claims_never_checked_out_count, net_access_level, ident_type, active, last_xact_id, passwd, barred, master_account) |
15:47 |
pdot2 |
VALUES ('2', 'f', '21187005375399', '0', 'Derp', 'Herp', '2018-07-07T00:00:00-04:00', '16', '0', '1', '1', 't', '1436298356.88058325.689549189485', '3373', 'f', 'f') |
15:50 |
jeff |
pdot2: the lack of home_ou violates a database constraint. i suspect you may need to run autogen and restart your staff client, if the user editor is trying to create users without any home library set. |
15:55 |
pdot2 |
ah, is a depth of 2 required for home branch? |
15:58 |
pdot2 |
it does state the my default (drop down) values for home library are not valid. |
15:58 |
pdot2 |
will try a complete db wipe (yay testing) and recreating hirearchy |
15:58 |
jeff |
have you modified your default org unit types? |
15:59 |
pdot2 |
yes, and ran autogen.sh, restarted apache2 |
15:59 |
pdot2 |
and restarted my client |
16:09 |
Dyrcona |
Seeing a diff of the changes would be handy, but we're basing it on quality score. |
16:11 |
Dyrcona |
So, maybe I'll add a wishlist bug later. |
16:12 |
|
Newziky joined #evergreen |
16:15 |
yboston |
don't judge me ;) |
16:15 |
yboston |
I once had to diff some marc inside of two sperate EG servers. I used vimdiff supercat_url1 supercat_url2 |
16:16 |
yboston |
like so... |
16:16 |
yboston |
vimdiff http://catalog.berklee.edu/opac/extras/supercat/retrieve/marctxt/record/12481 http://berklee-test.evergreencatalog.com/opac/extras/supercat/retrieve/marctxt/record/12481 |
16:16 |
yboston |
worked great |
16:17 |
Dyrcona |
That could almost work in my case. |
16:17 |
Dyrcona |
yboston++ |
16:17 |
Dyrcona |
Anyway, we've decided to replace MARC on records where the quality dropped by 10 or more. |
09:12 |
* mmorgan |
inhales the aroma, returns the favor:) |
09:12 |
mmorgan |
@coffee kmlussier |
09:12 |
* pinesol_green |
brews and pours a cup of People's Daily Espresso, and sends it sliding down the bar to kmlussier |
09:12 |
kmlussier |
:) |
09:13 |
kmlussier |
I could use some coffee. Testing the negative balances branch this morning. |
09:13 |
mmorgan |
That definitely requires coffee!! |
09:21 |
jwoodard |
I do not even know who our patrons keep getting negative balances. |
09:22 |
jwoodard |
Every week there are a few more. I think EG is just messing with me... |
14:22 |
* kmlussier |
will do her best to break old habits. |
14:22 |
yboston |
I would still send another reply to that thread to anounce the change or send in a new email |
14:22 |
remingtron |
yboston: sure, give me that action item |
14:22 |
yboston |
also, I would have liked to get feedback from Robert about testing out the change |
14:22 |
remingtron |
yboston: and another for phase 2: testing |
14:22 |
yboston |
remingtron: I will give you an action item |
14:23 |
yboston |
OK |
14:23 |
yboston |
#action remingtron will send out an email to the Dig list anouncing that a new file extension will be used for AsciiDoc files |
14:24 |
remingtron |
#info The dev docs already include one .adoc file that I added |
14:24 |
yboston |
did you want to right out the testing action item or feed me your suggestions? |
14:24 |
remingtron |
#link http://docs.evergreen-ils.org/dev/_library_settings_editor.html |
14:24 |
remingtron |
yboston: sure... |
14:24 |
yboston |
sorry, that should have said "write out" |
14:25 |
yboston |
remingtron: also,w ould you liek help in the testing? should we have a seconf action item to reach out to robert? |
14:25 |
remingtron |
remingtron will begin testing use of and conversion to the .adoc extension |
14:25 |
remingtron |
I'll email Robert |
14:25 |
yboston |
#action remingtron will begin testing use of and conversion to the .adoc extension |
14:25 |
remingtron |
as part of my testing phase |
14:26 |
remingtron |
and I'll email the list if I want help, or when phase 3 is ready |
14:26 |
remingtron |
(which is probably the big switch) |
14:26 |
remingtron |
I won't do anything crazy without warning :) |
14:26 |
yboston |
anything else on this topic? |
14:28 |
yboston |
OK, moving on |
14:28 |
yboston |
#info 4) all update the 2.8 outstanding features list; remove names of those that cannot continue working on assignment; post completed or incomplete files |
16:30 |
jwoodard |
I lose a little more of myself each time I close the reports interface. |
16:32 |
alynn26 |
its all in how you pull the data out. Sometimes you get what you want, and sometimes you go back and get more than you want to get what you want. |
16:32 |
alynn26 |
Well it is a love hate relationship. |
16:35 |
kmlussier |
I know people who love reports. They just don't spend much time in here. |
16:36 |
kmlussier |
@later tell Dyrcona I finall got around to posting those billing test cases I promised you. http://wiki.evergreen-ils.org/doku.php?id=qa:billing_test_cases |
16:36 |
pinesol_green |
kmlussier: The operation succeeded. |
16:36 |
kmlussier |
Oh, so sad to see a typo in an @later and to have no way to fix it. :( |
16:37 |
mmorgan |
I think those who have access to query the database directly generally don't like having to dig through the extra layers in the reporter to get the data they need. |
17:11 |
gsams |
@love reports |
17:11 |
pinesol_green |
gsams: The operation succeeded. gsams loves reports. |
17:12 |
gsams |
because it serves an important purpose that I stand behind |
17:12 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
17:12 |
bshum |
Actually that's odd, it should have changed status to checked out or available in that case. |
17:12 |
bshum |
I've never seen an item have a status of reshelving where it was checked out to someone. |
17:12 |
bshum |
Maybe bad SQL gone awry? |
01:27 |
|
Mark__T joined #evergreen |
03:05 |
|
TaraC joined #evergreen |
05:14 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
06:40 |
|
rlefaive joined #evergreen |
08:19 |
|
rjackson_isl joined #evergreen |
08:34 |
|
mmorgan joined #evergreen |
14:29 |
csharp |
@dunno add Ba ba ba dook Dook DOOK! |
14:29 |
pinesol_green |
csharp: The operation succeeded. Dunno #40 added. |
14:34 |
jboyer-isl |
Quick Q for those with some Composite Coded Value Maps experience: Can a record attribute be the root of the tree, or does the root have to be a boolean operator? I've got some definitions that only allow a single value, but they don't display an expression in the editor. |
14:35 |
Stompro |
Dyrcona, I just assigned myself to LP:1312297 so I would put in my next bug fixing branch, if it is higher priority then maybe someone else should grab it. I'm not sure when I'll have time to test again. |
14:35 |
jboyer-isl |
If that's just a display quirk I don't care, but now is the time to go back and make them all children of an OR or something like that if need be. |
14:36 |
Dyrcona |
Stompro: That is basically what I planned to ask you about. |
14:40 |
Stompro |
Drycona, I'll unassign myself, so someone else can grab if they have a chance. I'll still try and test it when I have a chance, if someone doesn't beat me too it. |
14:41 |
Dyrcona |
Stompro: OK with me. |
14:41 |
Stompro |
And one agenda item done, <check> :-) |
14:42 |
Dyrcona |
Mostly. I changed it, but they're really up for discussion. |
14:44 |
Dyrcona |
Meeting starts in about 15 minutes. |
14:46 |
dbwells |
jboyer-isl: I just created a quick test case, and it seemed to work alright, so I think it is just a display quick. |
14:47 |
jboyer-isl |
dbwells: Thanks! |
14:47 |
jboyer-isl |
dbwells++ |
14:48 |
dbwells |
s/quick/quirk/ |
15:18 |
Dyrcona |
Thanks to berick for doing the work. I'm sure it was fun deleting all that code! |
15:18 |
* miker |
shed a single tear for the backend js |
15:19 |
Dyrcona |
I recall occasionally having problems getting SpiderMonkey to install, so I won't cry. :) |
15:19 |
jeff |
berick++ also for bug 1312297 which I suspect is close to next. I'm reviewing/testing -- any comments on need for tests and/or release notes? Release notes seems like a "for certain". |
15:19 |
pinesol_green |
Launchpad bug 1312297 in Evergreen "time to remove the old web-based selfcheck interface" (affected: 4, heat: 18) [Wishlist,Confirmed] https://launchpad.net/bugs/1312297 |
15:19 |
Dyrcona |
jeff: Yes, that's the next "topic" |
15:19 |
jeff |
Ah. I would probably know that if I had the agenda up. Sorry! |
15:23 |
Dyrcona |
#action jeff will look into removing old self check interface. |
15:23 |
Dyrcona |
I'll review. |
15:24 |
Dyrcona |
Though, I think some of it now is just review, isn't it? |
15:24 |
jeff |
And, does anyone have input on tests/QA for these mostly web/js removals? |
15:24 |
jeff |
selfcheck is review and release notes (which i can craft). i think berick's done the work already. |
15:24 |
Dyrcona |
#action jeff will look at removing old JSPAC code. |
15:24 |
Dyrcona |
yep. berick++ again. |
15:25 |
Dyrcona |
As for tests, I'm not sure what one could except make sure basic functionality of other parts of Evergreen still works. |
15:26 |
Dyrcona |
jeff++ for taking those two on. |
15:26 |
jeff |
That's good enough for me. If something makes sense to test, I'll do it, but won't stress about the RM not accepting removal of jspac due to lack of tests. :-) |
15:27 |
Dyrcona |
The old self check should be fairly simple, 'cause I don't think anything else really touches it. |
15:27 |
Dyrcona |
heh |
15:27 |
jeff |
I have at least one other question that I might hit the general/dev list with -- removing lots (and LOTS) of images that have been in the web dir for a while that have only ever been used in "stock" by things like jspac/craftsman. |
15:31 |
yboston |
Would a quick warning email to the general list complement the mention in the release notes? |
15:31 |
jeff |
"hey, this still is no longer installed -- if you have it kicking around and you don't want to do a clean install of your web dir you might want to clean things up" |
15:31 |
kmlussier |
+1 to removing them and addressing it through release notes |
15:32 |
jeff |
yboston: possibly a heads-up after the work is tested and merged and the release notes are crafted. less uncertainty that way. |
15:32 |
jeff |
yboston++ i'll make a mental note |
15:32 |
Dyrcona |
#agreed release notes are a good idea. |
15:32 |
Dyrcona |
:) |
15:32 |
bshum |
Dyrcona++ :) |
15:43 |
jeff |
miker: i think i found at least three sprintf javascript implementations, one of which was added, then the code using it was removed, then LATER code re-used the sprintf implementation that had been left behind... :-) |
15:44 |
Dyrcona |
#info Query dbwells on the conditional negative balances work. |
15:44 |
Dyrcona |
So my questions for dbwells are do you think this could get polished up before the alpha? |
15:44 |
Dyrcona |
And, would you like some help writing tests, etc.? |
15:45 |
kmlussier |
I have put a deadline in my calendar to complete another round of negative balance testing by Wednesday. It's looking promising at the moment. |
15:45 |
jeff |
I'd like to volunteer to assist where possible/useful on testing and/or tests. |
15:45 |
Dyrcona |
I am also volunteering to help with whatever needs done at this point. |
15:46 |
Dyrcona |
I started the mess and feel the least I can do is help to get it done. |
15:46 |
dbwells |
the bug is pretty much as stated on the branch, i.e. ready for eyeballs, and still needing tests. We've done the work of getting at least one interesting test to load, so we're still hoping the others will flow from that more easily, but haven't gotten back to it yet. |
15:46 |
dbwells |
When is the alpha, again? |
15:46 |
Dyrcona |
The alpha is the 29th of July, so exactly 4 weeks from today. |
15:47 |
Dyrcona |
We've traditionally accepted new features up to the beta cut-off. |
15:47 |
dbwells |
I think it can make alpha, barring some major setback. |
15:48 |
jeff |
Dyrcona++ dbwells++ kmlussier++ |
15:48 |
kmlussier |
I think it would be nice to shoot for alpha. If the timeline slips a bit, then, it isn't pushed off to another release. And it gives more people to play with scenarios that may have been missed in earlier testing. |
15:48 |
dbwells |
I'll plan to push whatever tests I have on next Friday (even if it's still just the one), then others can more easily add to it at that point. |
15:48 |
Dyrcona |
dbwells++ kmlussier++ |
15:48 |
Dyrcona |
For the logs, the beta is planned for August 19. |
15:48 |
dbwells |
Of course, if people just want to jump in with tests from scratch, I don't oppose that in any way, either :) |
15:49 |
kmlussier |
When it gets in, we can have a nice IRC party where I will gladly hand out desserts to everyone involved in the project. Virtual desserts, of course. |
15:49 |
bshum |
Hehe |
15:49 |
kmlussier |
See how I said 'when' and not 'if.' :) |
15:50 |
Dyrcona |
I think an action or info should come out of this. |
15:50 |
dbwells |
I'll action myself for the test stuff. |
15:50 |
kmlussier |
Dyrcona: You can give me an action item to finish my testing by next Wednesday. |
15:50 |
kmlussier |
Or I guess I can action myself. |
15:50 |
Dyrcona |
Ok. |
15:50 |
Dyrcona |
you can add the actions yourselves. |
15:51 |
dbwells |
#action dbwells will hopefully write more neg balances tests and push whatever he has ready on July 10 |
15:51 |
kmlussier |
#action kmlussier to complete her testing on the negative balance branch by July 8 |
15:51 |
* kmlussier |
works best under deadline pressure. |
15:51 |
Dyrcona |
deadlines++ |
15:52 |
Dyrcona |
#action Dyrcona will follow up with negative balance branch after July 10. |
15:52 |
* dbwells |
works only under deadline pressure ;) |
15:54 |
Dyrcona |
#topic New and Old Business |
15:54 |
Dyrcona |
So earlier we said there were some action items from the face to face meeting that needed to be added. |
15:55 |
Dyrcona |
Now's the time to do that. |
15:56 |
yboston |
At the meeting we spoke about a test day, and Liam started the planning on that |
15:56 |
yboston |
he sent out one email about it |
15:56 |
jeff |
#action jeff will articulate ideas on merge vs cherry-pick and start discussion/proposal on dev list |
15:58 |
Dyrcona |
yboston: I feel iffy giving a vague action to someone who isn't here. |
15:58 |
jeff |
with Liam not here to take an action, perhaps an info pointing out that planning is under way? |
15:58 |
yboston |
I can follow up with him, I already followed up with him last week |
15:58 |
jeff |
now THAT sounds like an action item with your name on it. ;-) |
15:59 |
Dyrcona |
#action yboston to followup with ldw about a testing day. |
15:59 |
Dyrcona |
:) |
15:59 |
Dyrcona |
should probably be a space between follow and up, but English.... |
15:59 |
miker |
jeff: do your ideas boil down to merg-- ? ;) |
16:06 |
bshum |
jeff: I know, I jinxed it. |
16:06 |
* pinesol_green |
brews and pours a cup of Guatemala Pandora Pacamara Medium-Light Roast, and sends it sliding down the bar to egbuilder |
16:06 |
Dyrcona |
Heh. |
16:06 |
kmlussier |
Do we have a Launchpad tag for code that needs tests? |
16:06 |
Dyrcona |
No, we don't. |
16:06 |
bshum |
kmlussier: We can add one, simple enough for "needstests" |
16:07 |
jboyer-isl |
"unproven" |
16:07 |
Dyrcona |
Just a bit... ;) |
16:07 |
jeff |
"worksintheory" :-) |
16:07 |
kmlussier |
heh, i like worksintheory |
16:07 |
Dyrcona |
Although there's a famous line from Knuth: Beware of bugs in the following code. I have only proven it correct and not tested it. |
16:08 |
jboyer-isl |
In the interest of not waffling too much, +1 to needstests |
16:08 |
Dyrcona |
Well, that could be something to discuss at the next dev meeting or on the list. |
16:09 |
* bshum |
already added it, but yes, probably |
16:12 |
miker |
Dyrcona++ # for meeting |
16:12 |
* miker |
's favorite bugzilla status: WORKSFORME |
16:14 |
jeff |
``If you close a JIRA ticket for a bug in a WatchKit app that you can’t reproduce the resolution status should be “Not on my watch.”'' https://twitter.com/_Jordan/status/593231842339201026 |
16:17 |
kmlussier |
Is bug 1174498 something that would need a test before going in? |
16:17 |
Bmagic |
did someone pass me a beer? |
16:17 |
pinesol_green |
Launchpad bug 1174498 in Evergreen "Payment by billing type breakdown" (affected: 7, heat: 38) [Wishlist,Triaged] https://launchpad.net/bugs/1174498 |
16:17 |
kmlussier |
Bmagic: Yeah, that was me. You're welcome. :) |
16:56 |
Dyrcona |
Stompro++ |
16:56 |
Dyrcona |
I meant to copy/paste my blog post about scripted circ going away and sending it to the general list, but time got away from me. |
16:56 |
Dyrcona |
Perhaps tomorrow. |
16:56 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
16:57 |
kmlussier |
I still need to write a blog post on Bug Squashing Day. And on our ALA Exhibit. |
16:58 |
Dyrcona |
We have a pile of action items from today's meeting. |
17:00 |
Dyrcona |
Well, time for me to go. |
15:05 |
jeff |
selling something... like parts. |
15:12 |
* mmorgan |
can get you a deal on parts ;-) |
15:12 |
gsams |
jeff++ |
15:12 |
Stompro |
Dyrcona, thanks for the quickpicks script. So say I'm doing a bug testing branch with commits from 10 different LP bugs, I pull them all in using the -s flag with quickpick. Now time passes and I test all the various LP bugs. Is there an easy way to push signoff branches with just certain commits directly from my bug fix branch? Or do I need to manage each signoff branch individually? Sorry for the long post. |
15:13 |
tsbere |
Stompro: You will need to build individual signoff branches. |
15:13 |
Dyrcona |
Stompro: When I'm testing, I usually checkout -b a new branch based on master and then merge the branches that I want to test into that. |
15:14 |
Dyrcona |
When I want to sign off on one of the branches, I usually create a new branch based on master, then quickpick -s the branch I want to sign off on. |
15:16 |
Stompro |
Ok, that is what I thought, and where I was being lazy. I'm sure I'll get faster at it with more practice. |
15:17 |
miker |
bshum: you hate RAID? |
15:17 |
|
bmills left #evergreen |
15:18 |
bshum |
In general it's good to test everything in collaboration, eventually. Since they'll be merged that way at some point. But too many at once it can be hard to figure out what broke what. |
15:19 |
bshum |
miker: Maybe I meant to say I hate thinking about RAID configs. Or RAID and SSDs. Or failing RAID arrays... |
15:19 |
bshum |
@dontcare RAID |
15:19 |
pinesol_green |
bshum: The operation succeeded. bshum no longer hates RAID. |
15:19 |
miker |
;) |
15:19 |
Dyrcona |
bshum: Or HP RAID in particular? |
15:20 |
bshum |
@hate HP |
15:20 |
pinesol_green |
bshum: The operation succeeded. bshum hates HP. |
15:25 |
|
mrpeters1 joined #evergreen |
15:25 |
Dyrcona |
I usually test four or five branches at once, and add in our local customization branches. |
15:26 |
|
Newziky1 joined #evergreen |
15:26 |
|
Newziky1 left #evergreen |
15:27 |
Dyrcona |
And, when I see signed off lp bugs that aren't fix committed, I'll sometimes merge those in, do a quick smoke test, then push them. |
15:30 |
Dyrcona |
@loves |
15:30 |
|
bmills joined #evergreen |
15:30 |
pinesol_green |
Dyrcona loves git; scripted sign off; sed; OpenBSD; gnu/emacs; and git tag |
16:52 |
mrpeters |
will it be gone before the next 2.8 release? |
16:52 |
mrpeters |
berick: thansk |
16:52 |
Dyrcona |
Nope. It will be gone in 2.9. |
16:53 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
16:59 |
|
Newziky left #evergreen |
17:01 |
Bmagic |
I give up, what table keeps the patron credit (when choosing to convert change to patron credit) ? |
17:02 |
berick |
Bmagic: you'll never guess... actor.usr :) |