| Time |
Nick |
Message |
| 04:27 |
|
sleary joined #evergreen |
| 07:15 |
|
collum joined #evergreen |
| 07:29 |
|
BDorsey joined #evergreen |
| 08:15 |
|
kworstell-isl joined #evergreen |
| 08:26 |
|
sleary joined #evergreen |
| 08:29 |
|
mmorgan joined #evergreen |
| 08:33 |
|
dguarrac joined #evergreen |
| 09:19 |
|
mantis1 joined #evergreen |
| 09:20 |
mantis1 |
I added a new org unit to our database but I'm not finding it as an option when editing hours through the GUI. Not sure what I'm missing. |
| 09:21 |
pinesol |
News from commits: LP2015137 Tab order for admin splash link tables <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=483757bc507345013e58571ef1a8e89c11a998ac> |
| 09:32 |
|
mantis1 left #evergreen |
| 09:36 |
|
terranm joined #evergreen |
| 09:37 |
|
mantis1 joined #evergreen |
| 09:37 |
mantis1 |
urgh nevermind |
| 09:51 |
pinesol |
News from commits: LP#1901072 Menus Don't Recognize Max Recent Patrons Setting <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1608860dc3376201c224a3d032e61fd4dfd3ba26> |
| 09:53 |
|
sleary joined #evergreen |
| 10:02 |
|
terranm joined #evergreen |
| 10:20 |
JBoyer |
festivus has been updated with a fresh rel_3_11 to incorporate the fixes from Monday and Tuesday. Great work so far everyone! |
| 10:20 |
JBoyer |
terranm++ |
| 10:21 |
terranm |
Thanks JBoyer++ |
| 10:22 |
terranm |
I'll send out an update to the lists |
| 10:24 |
mmorgan |
JBoyer++ |
| 10:24 |
mmorgan |
terranm++ |
| 10:29 |
sleary |
both of the accessibility bugs marked as waiting on rebase should merge now |
| 10:31 |
terranm |
sleary++ |
| 10:32 |
|
Christineb joined #evergreen |
| 10:52 |
gmcharlt |
calling out bug 2019117 as worthy of quick review |
| 10:52 |
pinesol |
Launchpad bug 2019117 in Evergreen "two line item actions broken after upgrade to Angular 15" [High,New] https://launchpad.net/bugs/2019117 |
| 10:52 |
gmcharlt |
(curse you, Angular 15, for doing the right thing!) |
| 10:55 |
jeff |
I can push that, especially since JBoyer's signed off and I don't see need to duplicate testing. |
| 10:56 |
jeff |
the angular 15 upgrade only affects 3.11 anyway, so it's push to master and rel_3_11, right? |
| 10:56 |
gmcharlt |
jeff: correct |
| 10:56 |
gmcharlt |
(and thanks!) |
| 10:57 |
mmorgan |
gmcharlt++ |
| 10:57 |
mmorgan |
jeff++ |
| 10:59 |
jeff |
in this case, I'm cherry-picking to master and rel_3_11 and then pushing, not adding any additional context or signoff. does that sound right as well? |
| 10:59 |
jeff |
s/context/comment/ i suppose |
| 10:59 |
gmcharlt |
jeff: you should also add the signoff, e.g., git cherry-pick -s |
| 10:59 |
jeff |
got it! thanks! |
| 11:02 |
jeff |
pushed to master and rel_3_11, commented as such on bug, marked Fix Committed and unassigned myself. |
| 11:02 |
jeff |
gmcharlt++ JBoyer++ |
| 11:02 |
gmcharlt |
jeff++ |
| 11:02 |
mmorgan |
JBoyer++ |
| 11:03 |
JBoyer |
gmcharlt++ jeff++ |
| 11:15 |
|
bgillap joined #evergreen |
| 11:21 |
pinesol |
News from commits: LP#2019032: restore functionality of two line item actions <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6d6d2b4475a78824c8f8852a934255a66c63201f> |
| 11:46 |
|
jihpringle joined #evergreen |
| 12:19 |
|
bgillap joined #evergreen |
| 12:39 |
berick |
someone remind me how to upgrade to Ubuntu 22.04 w/ PG 10 without having to first uninstall PG 10? i know I can uninstall w/o purging, but IIRC there is an easier way |
| 12:40 |
berick |
the issue being that do-release-upgrade really wants to remove postgresql-10-* packages |
| 12:45 |
JBoyer |
berick, the last time I ran into this I did wipe out Pg, but you may be able to get over the hump by just removing the pl-pgperl package and putting it back after. Not certain though. |
| 12:46 |
* berick |
tries |
| 12:47 |
berick |
hey, I got farther in the process... |
| 12:47 |
berick |
JBoyer++ |
| 12:50 |
|
dmoore joined #evergreen |
| 13:02 |
mantis1 |
When updating to 3.9, has anyone noticed if those libraries with max fines instated had additional fines accuring on billed and lost items? |
| 13:02 |
mantis1 |
For some reason that's happening with one our libraries on jbook items |
| 13:25 |
mantis1 |
Maybe the Granular control over how to use price and acquisition cost to determine item value feature from 3.8 might have something to do with it |
| 13:33 |
jeff |
Interesting. Did the circulations in question have a stop_fines of MAXFINES and a stop_fines_date set, but after the upgrade additional money.billing entries were created on those circulations? |
| 13:35 |
jeff |
I think you're talking about the change introduced in lp 1905028 |
| 13:35 |
pinesol |
Launchpad bug 1905028 in Evergreen "Wishlist: Option to have lost items be charged the Acquisitions Cost" [Wishlist,Fix released] https://launchpad.net/bugs/1905028 |
| 13:38 |
jeff |
I think that change would impact what a circulations' max_fine would be set to if the max_fine were a percentage of price or capped at price. I believe it would only take effect when the circulation was created (at checkout or renewal). Can you give more detail on what you're seeing? |
| 14:03 |
jihpringle |
mantis1: I don't remember this coming up as an issue for us when we upgraded from 3.7 to 3.9 (in case that is useful) |
| 14:06 |
jeff |
(though I might be wrong about it impacting the max_fine calculation) |
| 14:11 |
jeff |
ah, I think I'm correct that it (the change) would potentially impact it (setting max_fines on a new circulation) |
| 14:14 |
jeff |
the in-db circ matrix logic determines the max_fine_rule, but the Perl layer still takes care of setting the actual number in circulation.max_fines. |
| 14:15 |
jeff |
that would impact max fine rules that are percent-of-price as well as fines that would be capped by the setting Circ: Cap Max Fine at Item Price (circ.max_fine.cap_at_price) |
| 14:16 |
jeff |
mantis1: I'll hold off on speculating further until/unless you have some more info. :-) |
| 14:27 |
mantis1 |
thanks for everyone's help. I don't know the money schema too well |
| 14:27 |
mantis1 |
which table is the best to look up the MAXFINES? |
| 14:28 |
mantis1 |
stop_fines rather |
| 14:31 |
jeff |
stop_fines and stop_fines_time are both columns in the action.circulation table. |
| 14:31 |
jeff |
can you describe what you're seeing / what staff are reporting? |
| 14:32 |
Stompro |
jeff, What is the primary ILL product that NCIPServer supports again? |
| 14:35 |
mantis1 |
Staff are reporting that fines are still accumulating on billed items after they have been returned. These do have a max fine of $22 for example. With one item that was last billed on March 31 (before we brought the db down for the upgrade) for the cost of the item. It then went through an adjusted lost item returned payment note and there's 17.20 owed in balance for the item. This item was last due at the end of Decembe |
| 14:35 |
mantis1 |
It seems to me that these probably have to do with the upgrade because a lot of the xamples that were brought in had last billing notices that were sent out the day before we upgraded. |
| 14:38 |
mmorgan |
There are some library settings that come into play: Restore overdues on lost item return, Lost Checkin Generates New Overdues |
| 14:40 |
mmorgan |
mantis1^^ Are those set to true? |
| 14:41 |
jeff |
Stompro: we use it with III INN-Reach. |
| 14:45 |
jeff |
mantis1: what Evergreen version were you on before the upgrade, and what did you upgrade to? |
| 14:45 |
Stompro |
Jeff, Thanks, I think Dyrcona mentioned a different product... but I just cannot find it right now. Are you running the current NCIPServer code from git.evergreen-ils.org or do you have a customized version? |
| 14:46 |
jeff |
Stompro: oh, sorry. I misread and thought you were asking about iNCIPit, since I think you had mentioned that at the conference during one conversation. My answer is incorrect for NCIPServer! |
| 14:47 |
mantis1 |
jeff: 3.6.5 |
| 14:47 |
Stompro |
No problem, NCIPServer is kind of a generic name. I found it, Auto-Graphics' SHAREit is what Jason mentioned. |
| 14:48 |
mantis1 |
mmorgan: ah they are both set to true |
| 14:48 |
mantis1 |
do you usually keep the lost checkin generates new overdues false? |
| 14:50 |
mmorgan |
We also have both of those set to True. You may only notice the effect for circs with high max_fines. |
| 14:50 |
Stompro |
jeff, I think we will be using iNCIPit, but just for a short gap period to get up and running with VDX for less than a year. I'm guessing that our new state wide system will support NCIP V2 though. |
| 14:50 |
mmorgan |
That is, if the item goes to Lost before reaching maxfines. |
| 14:51 |
jeff |
Stompro: yep, some folk named jeff and Dyrcona agree: |
| 14:51 |
jeff |
16:48 < Dyrcona> Stompro: Evergreen's NCIPServer really only supports 1 remote vendor: Autographics ILL Product (I forget the product's name). |
| 14:51 |
jeff |
16:48 < jeff> Auto-Graphics SHAREit |
| 14:51 |
jeff |
16:48 < Dyrcona> Share-It... That's what it's callde |
| 14:54 |
mantis1 |
mmorgan: I think it does go to lost before max fines |
| 14:54 |
mantis1 |
mmorgan++ |
| 14:54 |
mantis1 |
jeff++ |
| 14:56 |
jeff |
looking at the billing and payment history for the transaction in question would be helpful. if you have the transaction id, the expanded view of SELECT * FROM money.billing WHERE xact = -1; and SELECT * FROM money.payment_view WHERE xact = -1; are a good start (replacing -1 with the transaction (circ) id and skimming for any data you need/want to redact). |
| 14:56 |
jeff |
expanded view in psql is toggled with \x |
| 14:57 |
jeff |
you could add an ORDER BY billing_ts and ORDER BY payment_ts to those, but it's not critical. |
| 15:03 |
mantis1 |
thank you! |
| 15:03 |
mantis1 |
I think I have some idea of what to do now |
| 15:08 |
|
sleary joined #evergreen |
| 15:14 |
jeff |
I'm curious if something is sensitive to the "price" of an item changing between when it was marked lost (and billed) and returned. |
| 15:15 |
jeff |
But I'm also wondering if the problem lies elsewhere, especially if the change in lp 1905028 doesn't change how a price is determined unless you set the relevant org unit settings. |
| 15:15 |
pinesol |
Launchpad bug 1905028 in Evergreen "Wishlist: Option to have lost items be charged the Acquisitions Cost" [Wishlist,Fix released] https://launchpad.net/bugs/1905028 |
| 15:22 |
mantis1 |
jeff: I will update you once I figure it out |
| 15:22 |
mantis1 |
thanks for your guidance! |
| 15:24 |
|
mantis1 left #evergreen |
| 15:31 |
jeff |
I probably should have been more explicit in my offer to look at the billings and payments. :-) |
| 16:05 |
|
bgillap_ joined #evergreen |
| 16:11 |
|
kco joined #evergreen |
| 17:07 |
|
mmorgan left #evergreen |
| 17:20 |
|
kworstell_isl joined #evergreen |
| 20:51 |
|
rhamby_ joined #evergreen |
