| 08:55 |
|
Dyrcona joined #evergreen |
| 10:03 |
|
dguarrac joined #evergreen |
| 10:45 |
|
Christineb joined #evergreen |
| 10:54 |
Dyrcona |
Yuck. Tests are failing... |
| 11:56 |
|
jihpringle joined #evergreen |
| 12:20 |
|
collum joined #evergreen |
| 14:22 |
Dyrcona |
The test failures are consistent. I guess I'll have to check on plain old master on a supported distro and Pg version.... I'm using Ubuntu 24 and Pg 16. |
| 15:59 |
Dyrcona |
That should be a lowercase '-r', not '-R'. I should have copy/pasted. |
| 16:09 |
Dyrcona |
So, it is something in this VM's environment because the tests fail when installed from git, too. |
| 16:43 |
Dyrcona |
So... Install Pg 16 on the vm where the tests were failing and configure it to use that one instead of the db server, and the tests pass. That's it. That's all I changed. |
| 16:45 |
Dyrcona |
That *might* help explain some billing bugs, maybe.... If the tests consistently fail on a remote database. |
| 16:49 |
Dyrcona |
Except this one decided to fail: live_t/18-lp1592891_sip_standing_penalties.t. It was succeeding before. |
| 16:49 |
* Dyrcona |
calls it a day/week. |
| 15:06 |
sandbergja |
that's farther than we've gotten hahaha. Unsurprisingly, we have spent a lot of time on the ownership chapter |
| 15:07 |
Dyrcona |
yeah. if [ ! -f ../dojo.tgz ].... I just have to rename it. |
| 15:08 |
Dyrcona |
Yeah, the ownership seems tricky.. Just pass everything as a reference is my take away. :) |
| 15:08 |
sandbergja |
heh, seriously! |
| 15:09 |
sandbergja |
we did try an experiment this week in one of our rails apps, we rewrote a method in Rust, and then used ffi to let Ruby find the compiled dynamic library. All of our ruby tests still passed, it was pretty cool. Lots of glue code though :-( |
| 15:09 |
berick |
neat! |
| 15:10 |
Dyrcona |
Yeah. Sound neat. I was think of doing crazy stuff at some point like hooking up the LibreOffice API. |
| 15:10 |
sandbergja |
ooh, cool |
| 15:43 |
Dyrcona |
I suspect that this has more to do with using the latest main over anything sandbergja changed. |
| 15:43 |
Dyrcona |
Bleh: fatal: tag 'rel_3_14_0' already exists |
| 15:44 |
Dyrcona |
I'll have to start over and delete the tag. |
| 15:45 |
sandbergja |
Dyrcona: was that angular error from `ng build` or the tests? |
| 15:46 |
Dyrcona |
sandbergja: I'm not sure. Let me check the scroll back. |
| 15:46 |
sandbergja |
hmmmm... I wonder if it would be good to have a "clobber" option for the git tag, in case you have to re-run it |
| 15:46 |
Dyrcona |
The warnings and errors come after "Browser application bundle generation complete." |
| 15:47 |
sandbergja |
ah gotcha |
| 15:48 |
Dyrcona |
It doesn't say it is running tests, yet. I could try a manual build from git later to see what happens. |
| 15:48 |
Dyrcona |
I'm going to git clean -xfd to make sure. I think I did that earlier. |
| 15:48 |
Bmagic |
Dyrcona berick: I solved by downloading the file manually via web browser (theory is that the browser is more error tolerante compared to wget) - then put the resulting download file in ../release/dojo..... (exact path is mentinoed in the build bash script) - and if the file exists, then it doesn't waste time wgeting a fresh copy |
| 15:49 |
Dyrcona |
Bmagic: I just did more or less the same, but used rsync to pull both dojo.tgz from the server and compare them on my laptop before sending one to the vm where I'm playing around. |
| 08:29 |
|
mmorgan joined #evergreen |
| 09:01 |
|
dguarrac joined #evergreen |
| 09:23 |
|
Dyrcona joined #evergreen |
| 09:24 |
Dyrcona |
Why is it that something tested in production over a week ago and worked, doesn't work when I actually want to use it? |
| 09:31 |
Dyrcona |
OK. It IS working. The first thing it tried to do ended up being invalid as far as the new process is concerned. |
| 09:31 |
Dyrcona |
The a/t event is not invalid, but it doesn't meet other criteria in the script. |
| 10:00 |
|
kmlussier joined #evergreen |
| 15:35 |
Bmagic |
with the understanding that we will have a follow-up LP to update the bits for ValKey when that's possible |
| 15:35 |
berick |
the bigger qestion for me is whether the functionality is complete for the various use cases |
| 15:36 |
berick |
which is to some extent aimed at the Equinox folks |
| 15:36 |
Dyrcona |
I've been using it since October on a test instance and haven't noticed anything that doesn't work. |
| 15:36 |
Bmagic |
We have it running on production, for a small library. Working just fine. Though, I'd feel more confident if it were on production for a larger library/consortium |
| 15:37 |
berick |
Bmagic: i'm deploying it as soon as it's merged to opensrf main |
| 15:37 |
berick |
(part of why i'm asking now, want to get going on it) |
| 15:43 |
csharp_ |
the thin ice we're skating on held! (this is fine dog) |
| 15:43 |
* kmlussier |
is hoping reddis isn't quite so painful. |
| 15:43 |
Dyrcona |
jeff csharp_: Yeah, that was my suggestion about the numbering. |
| 15:43 |
Bmagic |
We have a few systems adopting 3.13 over the next few months, I think we can give redis a whirl at the same time. I'd like to see it up and running in a larger environment as proof. I don't think any test environment can do what a production environment does |
| 15:44 |
Dyrcona |
kmlussier: I'm sorry, didn't mean to make light of it. All software is some kind of pain to use. |
| 15:44 |
Dyrcona |
berick has done a great job making the Redis integration just work. Very little configuration required. |
| 15:44 |
Bmagic |
agreed berick++ |
| 16:03 |
Bmagic |
terranm: looks good for me |
| 16:04 |
redavis |
terranm, perfect |
| 16:04 |
sleary |
terranm++ |
| 16:04 |
terranm |
Maybe we'll have the new circ/patron interfaces to test then? |
| 16:04 |
LindaJansova |
terranm++ |
| 16:04 |
redavis |
terranm++ |
| 16:04 |
Bmagic |
terranm++ |
| 10:31 |
|
kworstell-isl joined #evergreen |
| 10:41 |
|
kworstell-isl joined #evergreen |
| 11:25 |
|
Christineb joined #evergreen |
| 12:43 |
mantis |
When manually testing hold expiring soon notices, I have a test set up so that the hold that is captured has a shelf expiration two days from now, but when I run a script, nothing runs. Not sure if anyone has any ideas or tried testing this notice before. |
| 12:52 |
berick |
mantis: we use it w/ delay = '-2 days' and max_delay = '-1 day' |
| 12:53 |
mantis |
ah ok |
| 12:53 |
mantis |
I have a max delay of 2 days |
| 12:54 |
Dyrcona |
Negative for before, positive for after. |
| 12:54 |
eeevil |
mantis: think of delay and max_delay as the age of the timestamp in the field pointed at by delay_field (in fact, it's exactly that!) |
| 12:54 |
eeevil |
as in, the output of the age() function in the db |
| 12:55 |
mantis |
eevil: I also thought had to do something with the timestamp, but testing wasn't as fruitful |
| 12:55 |
mantis |
and when you edit the hold dates in the regular circ module, it doesn't give a timestamp option |
| 12:55 |
mantis |
berick: I gave that a shot and no dice |
| 12:56 |
mantis |
my shelf expire time is set to 6-12-2024 00:00:00-04 |
| 13:01 |
Dyrcona |
mantish: action_trigger.event_hook specifies a "core_type" for the event. This is the main IDL class used by the event. action_trigger.event_definition specifies a delay_field, delay, and max_delay. |
| 13:01 |
Dyrcona |
The delay and max_delay (if present) are added to the value of the delay_field of the object being processed to determine if an event should be generated for that object. |
| 13:03 |
Dyrcona |
To process things from the past, i.e. a 30-day overdue event, you would use positive values in delay and max_delay. For future things, like hold expires in 2 days, use negative values. So a delay of '-2 days' and a max_delay of '-1 days' would get everything between tomorrow and two days from now. |
| 13:11 |
mantis |
eevil++ |
| 13:11 |
mantis |
Dyrcona++ |
| 13:11 |
Dyrcona |
I'd check the action_trigger_filers.json in /openils/conf, or if you're using custom filters, make sure that file is there. |
| 13:11 |
* Dyrcona |
often forgets the filters when testing triggers. |
| 13:15 |
Rogan |
This is also sent out on the general dev lists but details for the 2024 Hack-A-Way are now available: https://wiki.evergreen-ils.org/doku.php?id=hack-a-way:hack-a-way-2024 |
| 13:48 |
|
terranm joined #evergreen |
| 13:54 |
terranm |
Claiming 1419 |
| 12:03 |
|
Christineb joined #evergreen |
| 12:13 |
Dyrcona |
This is why I kept putting this off: there are a couple of places this could be fixed, and then there's the temptation to rip it up and implement something quite a bit different.... |
| 12:21 |
Dyrcona |
I suppose I could build a copy of the provider/account list and use grep to prevent duplicates. |
| 12:29 |
Dyrcona |
That works in my simple test. The list went from 180 to 29. |
| 12:47 |
Dyrcona |
heh. I typoed "Depulicate" as "Depuplicate" and my spell check suggested "Depopulate" with also works. :) |
| 12:48 |
Dyrcona |
OMG!!! "Deduplicate" not "Depulicate.".... |
| 12:48 |
Dyrcona |
@blame finger |
| 12:48 |
pinesol |
Dyrcona: finger is why we can never have nice things! |
| 12:48 |
berick |
@band add The Depopulaters |
| 12:48 |
pinesol |
berick: Band 'The Depopulaters' added to list |
| 12:49 |
Dyrcona |
berick: I ended up adding a loop in O::A::Acq::EDI::retreive_core to remove duplicate accounts/in_dir combinations from the list. I can test it in a minute. I'll put a link to the commit once I've pushed it to the working repo. |
| 12:58 |
|
jvwoolf joined #evergreen |
| 13:00 |
jeffdavis |
I think "depulication" would technically be flea removal. |
| 13:09 |
Dyrcona |
jeffdavis++ |
| 16:31 |
Bmagic |
completely deleting the value |
| 16:31 |
abneiman |
yes |
| 16:32 |
berick |
not really a shortcut, but an inability to move the curser to the character you want to edit |
| 16:32 |
Bmagic |
WTF, it didn't do that in a previous test |
| 16:32 |
abneiman |
anyway I think we have a fix |
| 16:32 |
abneiman |
stand by |
| 16:34 |
sleary |
I'm seeing the right arrow issue, but I have no problem saving an edited subfield. |
| 16:36 |
berick |
yeah, other fields save OK for me too |
| 16:36 |
sleary |
... yeah, that's bad |
| 16:36 |
berick |
Bmagic: same :) |
| 16:37 |
Bmagic |
interesting. What a nuance. Thinking back to when I tested that branch, I edited marc records like crazy but I don't think I interacted with a larger subfield like that |
| 16:37 |
abneiman |
I'm not seeing it on our internal 3.13-rc, even in multi line fields |
| 16:37 |
abneiman |
weird |
| 16:37 |
Bmagic |
weird indeed. Imma install from git and see |
| 17:11 |
|
jihpringle joined #evergreen |
| 17:15 |
berick |
sleary: yes |
| 17:19 |
* berick |
sees the working branch |
| 17:20 |
sleary |
berick I think we have a fix, but eeevil just found a bunch of missing libraries on my dev server that are causing other problems |
| 17:20 |
sleary |
testing it on a different server now |
| 17:20 |
eeevil |
deploying to butternut for testing now... |
| 17:22 |
berick |
seems partly fixed. editing existing values is better. creating new ones is still having issues. |
| 17:24 |
|
kworstell-isl joined #evergreen |
| 17:24 |
eeevil |
berick: you mean the arrow key issue, or something else? |
| 11:41 |
eeevil |
berick might know off the top of his head, though? |
| 11:46 |
berick |
ideally those params would be passed invididually to mkurl (inside the {}), but passing the params via the base URL string should also work |
| 11:46 |
|
mantis1 joined #evergreen |
| 11:48 |
mantis1 |
when testing action triggers/notices, what would it take for something to fall into 'invalid' status? |
| 11:49 |
berick |
mantis1: the event def will have a validator |
| 11:49 |
berick |
and its check(s) failed |
| 11:50 |
berick |
e.g. hold ready for pickup notice, but the hold was canceled in the meantime |
| 11:50 |
Dyrcona |
mantis1: The validator fails. Look at the event_definition and you can find the code somewhere under OpenILS/Application/Trigger/Validator.pm or OpenILS/Application/Trigger/Validator/* |
| 11:51 |
Dyrcona |
The event definition validator field value corresponds to a subroutine name. |
| 11:51 |
* Dyrcona |
is testing a custom db upgrade from 3.10.3 to main, and stuff keeps failing left and right. |
| 11:51 |
mantis1 |
I'm trying to test a pre-overdue but it seems like it should have passed |
| 11:51 |
mantis1 |
I checked out an item that would be due within the right time frame |
| 11:51 |
mantis1 |
but I'm also trying out a new HTML format for it |
| 11:52 |
Dyrcona |
What's the validator? |
| 11:52 |
mantis1 |
CircIsOpen |
| 11:56 |
Dyrcona |
Are there action_trigger.event_params entries specifying 'target_age_field' and 'min_target_age' for the event_definition? |
| 11:57 |
Dyrcona |
if target_age_field is missing, the delay_field will be used instead. |
| 11:58 |
Dyrcona |
if min_target_age is missing, it will fail to validate. |
| 12:03 |
mantis1 |
the thing is it does work but in a testing environment, it's just coming up invalid |
| 12:03 |
mantis1 |
not sure what the difference between this and production would be |
| 12:03 |
Dyrcona |
action_trigger.filters in /openils/conf ? |
| 12:05 |
mantis1 |
it's the same as production it looks like |
| 12:06 |
mantis1 |
also in that table, we have max_delay_age and min_target_age |
| 12:12 |
Dyrcona |
mantis1: if none of that turns out to be the issue, keep asking. I'll keep looking. :) |
| 12:12 |
mantis1 |
sorry how do you check for timezone in the GUI? I didn't see anything in the docs about it |
| 12:13 |
Dyrcona |
I use timedatectl on the command line |
| 12:14 |
mantis1 |
looks like it's set right; EDT |
| 12:14 |
mantis1 |
I also ran some tests with a notification from production on this server without any changes and it's also giving an invalid status |
| 12:14 |
Dyrcona |
OK. It's under Settings -> "Date & Time" in the GUI. |
| 12:15 |
Dyrcona |
There are some warnings you grep the logs for. |
| 12:16 |
Dyrcona |
"'min_target_age' parameter required for MinPassiveTargetAge validator" |
| 10:30 |
Dyrcona |
Makes sense, I guess. The database that I was messing with yesterday has been upgraded to main. |
| 10:30 |
* Dyrcona |
checks on not upgraded. |
| 10:30 |
Dyrcona |
I think it's time to play some Police: Too Much Information. :) |
| 10:35 |
Rogan |
Dyrcona it's always a good time for the Police (I'm fond of 80s music as a personal taste but the Police have stood the test of time IMO) |
| 10:45 |
pinesol |
News from commits: LP2067115: More fieldmapper comboboxes domId <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d44e6b0da02c250fa6e233f38ff566aed86ca39d> |
| 10:45 |
pinesol |
News from commits: LP2067115: Fieldmapper should set combobox domId, not id <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=841a2281fb1727327bb15eb476c0406fed463616> |
| 10:56 |
|
Christineb joined #evergreen |
| 11:14 |
|
smayo joined #evergreen |
| 11:14 |
|
collum joined #evergreen |
| 11:25 |
smayo |
I've been trying to test a new function that should be on the AngularJS navbar (dark mode color switch) but none of my changes to navbar.js have been doing anything, and the function neither runs nor throws an error. I check the page sources and find that navbar.js is not there. But the navbar still does everything but the new stuff??? |
| 11:25 |
Bmagic |
seems like a dev environment issue? |
| 11:26 |
|
sleary joined #evergreen |
| 11:26 |
Bmagic |
the browser will omit loading JS files if they aren't syntactically sound |
| 11:30 |
smayo |
Will do |
| 11:33 |
smayo |
Environment does NOT load navbar.js with vanilla |
| 11:34 |
Bmagic |
does this: https://bugsquash.mobiusconsortium.org/eg/opac/home |
| 11:35 |
smayo |
It's not there on your test server either |
| 11:35 |
Bmagic |
if it's in eg2, then the filename won't surface the same on the browser, it's all compiled and boiled down into random js files, and some are combined into a single |
| 11:36 |
smayo |
I'm looking for it on the circ page |
| 11:37 |
smayo |
There IS a machine code-ish version of it in core.module.js, which IS included, but it doesn't have an individual file like, say, grid.js |
| 12:42 |
* JBoyer |
trips over a pile of helm charts, transpilers, and docker images and grumbles "When did people stop /writing software/ instead of orchestrating infrastructure to LARP Google 2.0?!" |
| 12:42 |
Dyrcona |
JBoyer++ |
| 12:43 |
Dyrcona |
Bmagic: Smells like WASM. :) |
| 12:43 |
* Dyrcona |
wonders why an event was not created in his test. |
| 12:46 |
Dyrcona |
hold.available is supposed to get created right away, no? |
| 12:50 |
Dyrcona |
The environment is set up. |
| 12:52 |
Dyrcona |
Yeahp. I can find it calling even.autocreate in the logs. |
| 10:49 |
pinesol |
smayo: Band ''Good good boss man'' added to list |
| 11:20 |
Dyrcona |
OK. Got it: {"-and" => {sms_notify => {"not" => undef}, sms_notify => {"!=" => ""}}} # It wasn't that hard after all. I confused "+" on a table with "-" on an operator. |
| 11:20 |
Dyrcona |
Don't worry. I also did not spend the last hour on this.... :) |
| 11:30 |
eeevil |
Dyrcona: the comparitor for "is not null" can be anything (that passes the "it looks like a comparitor and not an injection attempt" test) other than "=", and "is null" must be exactly "=" ... late for you this morning, I know, but for the logs: https://wiki.evergreen-ils.org/doku.php?id=documentation:tutorials:json_query#other_kinds_of_comparisons (A note immediately above that "Other Kinds" heading, and toward the end of that section as well.) |
| 11:33 |
Dyrcona |
eeevil++ I refer to that document frequently. My problem was with the "and" moreso than the not null in the end. |
| 11:35 |
|
Dyrcona left #evergreen |
| 11:35 |
|
Dyrcona joined #evergreen |
| 14:24 |
Dyrcona |
And people say Lisp is ugly..... |
| 14:31 |
Dyrcona |
Yeah, that works with the ids added. |
| 14:38 |
|
kworstell_isl joined #evergreen |
| 15:34 |
Dyrcona |
berick mmorgan Bmagic : https://github.com/CWMARSINC/evergreen-xml-notices/tree/cwmars is what I've got so far for CW MARS. I'm going to test it for hold notifications this afternoon. We're not planning to use the two configured curbside notices, yet. I want to check if the code needs more modification for those. |
| 15:35 |
mmorgan |
Dyrcona++ |
| 16:05 |
Bmagic |
claiming 1417 |
| 17:00 |
|
dguarrac_ joined #evergreen |
| 13:04 |
Dyrcona |
Hrm... It says the hook is passive, but I'm copying values from another event with the same hook, and it doesn't have a max_delay.... |
| 13:06 |
Dyrcona |
And the hook doesn't exist.... |
| 13:06 |
* Dyrcona |
checks for typos. |
| 13:07 |
Dyrcona |
OK. It's an odd one: au.sms_text.test. That dot between text & test is usually a comma, and I should have copy and pasted instead of typing. |
| 13:07 |
Bmagic |
:) |
| 13:34 |
|
LindaJansova joined #evergreen |
| 13:36 |
* Dyrcona |
is having one of "those" days where the brain and fingers cannot get it together. typos-- |
| 13:38 |
pinesol |
Dyrcona: go with Stanely Kubrick |
| 13:38 |
Dyrcona |
pinesol: You have a very dark sense of humor. |
| 13:38 |
pinesol |
Dyrcona: As great as you are man, you'll never be greater than yourself. |
| 13:39 |
Dyrcona |
berick: Have you got a suggestion for running test SMS messages through the XML notice generator? I was thinking of running it once per minute, but I guess I'll have to check with Unique support about what they might expect. |
| 13:40 |
Dyrcona |
@decide underscore or comma |
| 13:40 |
pinesol |
Dyrcona: go with underscore |
| 13:41 |
Dyrcona |
pinesol++ |
| 14:21 |
Dyrcona |
I'm looking at curbside. (We have one library, at least, still using it.) I might need some new templates. |
| 14:21 |
Dyrcona |
Maybe not. |
| 14:39 |
Dyrcona |
"1, 2, 5!" |
| 14:49 |
Dyrcona |
hmm.. Don't think sending test SMS is gonna work this way. The staff client expect an almost immediate response. With NOOP_True, it will always report success won't it? |
| 14:51 |
Dyrcona |
Eh, no.... There's no template output, so the staff client will always report failure. Staff will not like that. |
| 14:59 |
berick |
Dyrcona: oh you're trying to use open-ils.actor.event.test_notification ? |
| 15:00 |
berick |
yeah that would take some changes to tie-in a 3rd party sms generator |
| 15:00 |
Dyrcona |
berick: No, the staff client uses it. I'm just trying to figure out how that would work. |
| 15:01 |
berick |
right, yeah, it should basically work, but like you said, the UI will not get the output it may currently be expecting |
| 15:01 |
Dyrcona |
That's the conclusion I'm coming to, unless we hack the staff client. |
| 15:02 |
Dyrcona |
It looks like it might only fire 1 event, even if two are configured... I should test that, though. |
| 15:02 |
Dyrcona |
I'll enable my test event and see what happens on a test system. |
| 15:07 |
Dyrcona |
With both events active, neither got created. |
| 15:11 |
Dyrcona |
The default event from Evergreen by itself works. My custom event does not. The latter reports a failure and the event fails to get created. I'll check if the validation needs anything, but I think the validator is NOOP_True. |
| 15:12 |
Dyrcona |
Huh... I wonder if I'm looking at the correct database... |
| 15:21 |
Bmagic |
ha! so that's what that column is for |
| 15:21 |
mmorgan |
:) |
| 15:21 |
Bmagic |
nope, not backdated |
| 15:22 |
Dyrcona |
On my events thing: with both events enabled only 1 fires. In any case the event that fires is set to complete, so we can't use this as-is for test text messages. |
| 15:22 |
Bmagic |
Dyrcona: that's what I was thinking |
| 15:22 |
Bmagic |
(on your thing) |
| 15:23 |
Dyrcona |
Yeah, I just had to run it to make sure. |
| 15:23 |
Dyrcona |
My test system does fire my test event with both enabled, but that's probably just "luck." |
| 15:30 |
mmorgan |
Bmagic: Is the max_fine in the circ properly set to 10? |
| 15:30 |
Bmagic |
mmorgan: yes |
| 15:30 |
Bmagic |
technicall 10.00 |
| 08:44 |
|
Dyrcona joined #evergreen |
| 08:47 |
|
mmorgan joined #evergreen |
| 09:14 |
|
dguarrac joined #evergreen |
| 09:21 |
Dyrcona |
berick | Bmagic: I'm working on moving the xml notices to production for live testing. I see one of the hold ready for pickup events that I'm mimicking from someone else has --process-hooks set. Is that going to interfere with our regular hold ready for pickup notices? |
| 09:26 |
* Dyrcona |
takes a look and figures, "No." |
| 09:30 |
Bmagic |
I think worse case: the cron job that runs the xml output could run the reactor for the non-xml stuff. Which isn't a big* deal IMO. Still though, I prefer to make the xml AT granularities unique |
| 09:38 |
csharp_ |
yeah, granularity is key |
| 10:56 |
Dyrcona |
Six trigger drones running, and none of them doing anything. |
| 10:59 |
Dyrcona |
Yeah. A stderr message in the open-ils.trigger log that the client disconnected. |
| 10:59 |
* Dyrcona |
tries again. |
| 11:01 |
Dyrcona |
Nothing like testing in produciton. |
| 11:01 |
Dyrcona |
production, even... |
| 11:02 |
eeevil |
berick: you are now comma-free |
| 11:04 |
berick |
eeevil++ |
| 10:19 |
pinesol |
News from commits: LP2006969 (follow-up): fix a lint issue in MARC editor case statement <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ad1d4106a3013dfd1ae2fd44493e6d994f441309> |
| 10:20 |
berick |
don't forget https://en.wikipedia.org/wiki/Snarf_(ThunderCats) |
| 10:20 |
kmlussier |
heh |
| 10:29 |
Bmagic_ |
test |
| 10:29 |
Bmagic_ |
dang it, still have the tail |
| 10:29 |
Bmagic |
there |
| 10:30 |
Bmagic |
csharp_: sup? |
| 15:17 |
Dyrcona |
I wonder if it would make more sense to wrap a check for "if for_email" around the email address and the text_number below that with a "if for_text" wrapped around it in the template? |
| 15:18 |
Dyrcona |
Hm... That complicates the logic further doesn't it? Because it would seem natural to add another check around the block that prints the street address. |
| 15:23 |
Dyrcona |
Bmagic: I copied the minimum of that I think is necessary to the utilities repo. |
| 15:24 |
Dyrcona |
I also pushed a branch to github with the same changes on the a clone of berick's original repository: https://github.com/CWMARSINC/evergreen-xml-notices/tree/cwmars-test (I'm pretty sure that one is public.) |
| 15:27 |
* Dyrcona |
was going to use that on a test system to see how it works. Maybe I'll try that right now. |
| 15:28 |
|
jvwoolf joined #evergreen |
| 15:32 |
jvwoolf |
csharp_: Do all of the PINES libraries have LibraryIQ, or just some? |
| 15:33 |
csharp_ |
jvwoolf: at this point, just two |
| 15:45 |
|
jihpringle joined #evergreen |
| 15:53 |
jvwoolf |
csharp_: We have 4 including a big system. Helping them out with some location cleanup at this very moment, so they can make more use of the tool. |
| 16:07 |
|
jvwoolf left #evergreen |
| 16:33 |
Dyrcona |
Well, the test of hold ready for pickup notifications yielded an empty file because the test data is about 17 days out of date. :) |
| 16:36 |
Dyrcona |
I should add for_text to a couple more files.... I was gonna wing it by setting FOR_EMAIL to --for-text. :) |
| 16:43 |
Bmagic |
what's the setting/mechanism that warns catalogers that they are importing a duplicate in the z39.50 interface? |
| 16:48 |
Dyrcona |
I don't remember off the top of my head. I'd have to grep through the code to find it. |
| 09:59 |
|
sleary joined #evergreen |
| 10:00 |
|
kmlussier joined #evergreen |
| 10:00 |
|
mmorgan1 joined #evergreen |
| 10:22 |
Dyrcona |
Bmagic: I have not had a chance to test the 3.13 beta tarball, yet. I was going to do it first thing this morning, but stuff came up. |
| 10:32 |
Dyrcona |
@decide bookworm or jammy |
| 10:32 |
pinesol |
Dyrcona: go with jammy |
| 10:33 |
|
redavis joined #evergreen |
| 10:48 |
|
Christineb joined #evergreen |
| 11:39 |
Dyrcona |
I'm doing it all by hand from the tarballs. I've got OpenSRF 3.3.0 up and running and test pass, but we knew that should work. |
| 11:42 |
kmlussier |
Dyrcona: It never hurts to double check just in case something changed. |
| 11:44 |
Dyrcona |
True. |
| 12:07 |
|
jihpringle joined #evergreen |
| 13:02 |
|
cbrown-isl joined #evergreen |
| 13:12 |
Dyrcona |
So picky... Have to remember to run autogen.sh and restart apache2. |
| 13:18 |
|
dmoore joined #evergreen |
| 13:27 |
Dyrcona |
Bmagic: All Perl and pgtap tests pass with the 3.13 beta tarball on a fresh installation. |
| 13:27 |
|
kworstell-isl joined #evergreen |
| 13:28 |
Dyrcona |
I'll give the db upgrade a whirl |
| 13:41 |
Dyrcona |
The db upgrade seems to work. |
| 13:42 |
|
sandbergja joined #evergreen |
| 13:43 |
sandbergja |
berick: trying to set up a redis dev environment, and osrf_control -l --start-all gave me the error "[auth] ERR Protocol error: invalid bulk length, at /usr/share/perl5/Redis.pm line 311." Does that sound familiar at all? |
| 13:48 |
Dyrcona |
So, after doing a db upgrade, the following pgtap tests fail: t/lp1371647_add_fixed_fields.pg and t/lp1588543_marc_record_attributes.pg. I'm not sure we really care about running tests after doing an upgrade, so don't let that hold up the release. |
| 13:49 |
* Dyrcona |
did the db upgrade twice to make sure the failure was consistent. |
| 13:50 |
Dyrcona |
sandbergja: When I've had an auth error with Redis, I've usually forgotten to update the opensrf_core.xml file. |
| 13:52 |
sandbergja |
Dyrcona++ |
| 15:19 |
redavis |
!!! |
| 15:19 |
Bmagic |
#link https://evergreen-ils.org/downloads/Evergreen-ILS-3.13-beta.tar.gz |
| 15:19 |
sandbergja |
nice! woohoo! |
| 15:20 |
Bmagic |
If anyone has some time, testing that would be sweet |
| 15:20 |
mmorgan |
Bmagic++ berick++ shulabear++ sleary++ abneiman++ |
| 15:20 |
dluch |
releaseteam++ |
| 15:20 |
redavis |
Bmagic++ berick++ shulabear++ sleary++ abneiman++ |
| 15:30 |
redavis |
That was my thinkin's. Cool. Thanks for the spell wisdom. Makes sense. |
| 15:30 |
Bmagic |
ok, that's another branch to merge..... |
| 15:30 |
Bmagic |
someone else should probably do it |
| 15:30 |
Dyrcona |
FWIW, I don't disable JIT on my test db with Pg12+. |
| 15:31 |
csharp_ |
I would have to watch a tutorial - my scant reading doesn't have me grokking it yet |
| 15:31 |
Bmagic |
(since I authored it) - anyone want to take the action item? |
| 15:31 |
csharp_ |
could be one of those things that tests fine but causes havoc at scale |
| 15:31 |
Bmagic |
or I guess I should back up and ask if it needs* to make it in before 3.13 is official |
| 15:32 |
csharp_ |
I think since PG11 is dead, we should push it asap |
| 15:32 |
Dyrcona |
csharp_: Depends on a number of factors from what I understand. |
| 15:40 |
csharp_ |
1 bug <--> 1 issue is the kind of granularity I try for |
| 15:40 |
mmorgan |
Commits can get missed. |
| 15:40 |
csharp_ |
but I'm not developing big ol' UIs and things |
| 15:40 |
kmlussier |
But if the commit with the shared component is added to a specific launchpad bug, and then somebody has feedback on that shared component as part of testing, won't that discussion be on that specific LP bug even if it's for a distinct feature? |
| 15:40 |
csharp_ |
mmorgan: I agree |
| 15:41 |
kmlussier |
csharp_: So are you saying those shared components should get their own distinct bug? |
| 15:41 |
redavis |
(s/omnibus bus (that's funny)/omnibus bug) |
| 15:44 |
csharp_ |
there's not a consensus for anything |
| 15:45 |
mmorgan |
Extra intermediate work may save work further down the line... |
| 15:45 |
csharp_ |
yeah, and hints in the bug comments usually say "the top 10 commits on <branch>" |
| 15:45 |
eeevil |
if all commits on a branch attached to an LP must have that LP prefix before being pushed to working, I'm fine with that rule. but that's not ... what I though the rule was, and wanted to avoid extra work that would 1) delay testing 2) make everyone that wanted to look at it move to another branch |
| 15:45 |
redavis |
Does it need to be a vote? since it's already in the guidelines? |
| 15:45 |
berick |
i don't think we're talking about working bracnches eeevil |
| 15:45 |
berick |
just the final product |
| 15:50 |
shulabear |
https://wiki.evergreen-ils.org/doku.php?id=newdevs:git:create |
| 15:50 |
eeevil |
(and, yeah, I do think the committer can amend the commits as appropriate -- or ask the author for a cleanup "final" branch) |
| 15:50 |
Dyrcona |
kmlussier: I do, but I don't use it any more. I do this `git cherry-pick ^HEAD working/user/whoever/branch` |
| 15:51 |
Dyrcona |
Or, I check out the branch and rebase on master. That's why I don't like extraneous commits, i.e. not related to what's being tested. |
| 15:51 |
csharp_ |
I've been doing 'git cherry-pick commit1^..commit10', but I'll experiment with Dyrcona's method |
| 15:52 |
Bmagic |
Dyrcona: I could see an issue with that command if the working branch was based on a different working branch? That would bring in more than just the feature you wanted to checkout? |
| 15:52 |
Dyrcona |
Yes, you have to start from the same or similar bases. |
| 07:59 |
|
BDorsey joined #evergreen |
| 08:18 |
|
kworstell-isl joined #evergreen |
| 08:34 |
|
mmorgan joined #evergreen |
| 08:45 |
mmorgan |
rlefaive: bug 1993824, released in 3.12 resolved those issues. I did a quick test on a test server and was able to download csv and delete a session. |
| 08:45 |
pinesol |
Launchpad bug 1993824 in Evergreen "wishlist: Angular Link Checker Interface" [Wishlist,Fix released] https://launchpad.net/bugs/1993824 |
| 08:50 |
|
Dyrcona joined #evergreen |
| 08:57 |
|
dguarrac joined #evergreen |
| 11:49 |
Dyrcona |
I think verify_passwd requires a hash of the password. |
| 11:51 |
csharp_ |
or the salt |
| 11:51 |
Bmagic |
looking at the function, maybe I can delete the row in actor.passwd? |
| 11:52 |
Dyrcona |
Bmagic: actor.change_password worked for me yesterday on a system that's running main from early last month. I changed a patron's password on the test system to play with NCIPServer authentication. |
| 11:52 |
Dyrcona |
I could login with the new password. |
| 11:53 |
Bmagic |
no go on my test machine. Tried srfsh also |
| 11:54 |
Bmagic |
srfsh# login admin demo123 |
| 11:56 |
Bmagic |
something is afoot |
| 11:56 |
Bmagic |
I'm sure it's me, crawling logs |
| 15:57 |
Dyrcona |
I don't think there can be one because acn doesn't have a field that links to actor.usr, but I could be wrong. |
| 15:58 |
jmurray-isl |
I was wondering. The template gets its user info from the user_data variable, instead. |
| 15:59 |
Dyrcona |
Yeah. Evergreen supplies the user data when the event is created. |
| 16:00 |
jmurray-isl |
In addition to that one, the Send Test SMS action trigger (hook: au.sms_text.test) doesn't seem to have context_usr_path defined either, but the primary target should be actor.usr.id. I've tried various things, but nothing has worked to populate that one, either. |
| 16:00 |
Dyrcona |
For that event, you only get the carrier and the number. |
| 16:02 |
Dyrcona |
My previous comment was for texting a call number. |
| 16:02 |
Dyrcona |
For au.sms_text.test the core type is au. |
| 16:02 |
jmurray-isl |
Yep, I've tried, target, target.id, and id and none seem to work. |
| 16:03 |
Dyrcona |
What's your ultimate goal? |
| 16:04 |
jmurray-isl |
To populate context_user on SMS action trigger events so I can reference them in an SQL query daily report on the counts of SMS events to various carriers |
| 16:05 |
jmurray-isl |
Those two action trigger definitions were the outliers. |
| 16:06 |
jmurray-isl |
Their number is minimal, to be fair, but I was mostly wondering for completion sake. |
| 16:09 |
Dyrcona |
For the send test sms, you can use the target in your SQL. |
| 16:10 |
jmurray-isl |
Yep. |
| 16:11 |
Dyrcona |
I don't think you can get anything in the text call number event context_usr without changing Perl code. |
| 16:11 |
jmurray-isl |
Gotcha. |
| 16:19 |
JBoyer |
FYI for GitLab hosters, they’ve laid a security egg re: password resets: https://arstechnica.com/?p=2021409 |
| 16:19 |
JBoyer |
Update asap |
| 16:19 |
|
jihpringle joined #evergreen |
| 16:23 |
Dyrcona |
jmurray-isl: Yes. It's pulled from the target using the context_usr_path. Since the usr is the target for the test sms event, it's not possible to grab it. Look at OpenILS/Application/Trigger/Event.pm around line 496. |
| 16:25 |
Dyrcona |
jmurray-isl: When you tried id on the send test sms, did you restart the open-ils.trigger service after making the change? "id" might work on that one since the core_type is au. |
| 16:27 |
jmurray-isl |
I did not restart the service. I'll try that. |
| 16:30 |
Dyrcona |
I was trying to test it, too, but I didn't set websockets port last time that I built opensrf for debuggin. |
| 16:34 |
Dyrcona |
then a hard reload in Chrome... |
| 16:38 |
Dyrcona |
Context user was filled in with the wrong id, and the event errored. |
| 16:40 |
Dyrcona |
Nope. I take that first part back. context_user was not set. The event did error. |
| 12:18 |
dickreckard |
Bmagic: a new clean database works correctly with the current Evergreen bits. it seems to be the upgraded db that breaks the keyword search ( and probably other things then. ) |
| 12:18 |
Bmagic |
I see what you mean, carry on |
| 12:26 |
|
smayo joined #evergreen |
| 12:49 |
Dyrcona |
I have test/dev servers where features sometimes don't work. I've got one where the acq. interface completely fails. Search has been a problem in the past. A full ingest sometimes helps. |
| 12:49 |
Dyrcona |
dickreckard ^^ |
| 12:57 |
Dyrcona |
We usually blame these issues on the test environment being slower than production. |
| 14:05 |
|
sleary joined #evergreen |
| 14:54 |
Dyrcona |
oops. accidentally pushed a working branch to NCIPServer origin, and gitolite won't let me delete it. I should probably check/update the configuration to prevent pushing working branches in that repo. There's only 3 of us that use it, anyway.... |
| 15:09 |
|
kworstell-isl joined #evergreen |
| 16:06 |
Dyrcona |
I guess a username that's 14 digits will cause us problems.... I've recently come out against letting patrons chose their own usernames in light of these issues and other bugs. |
| 16:07 |
Dyrcona |
I've been outvoted, so I go along with it. |
| 16:08 |
Dyrcona |
Stompro: Do you want to update the code or should I? |
| 16:09 |
Stompro |
Feel free, I'll hopefully be able to test it out tomorrow afternoon. I don't get why usernames don't actually work either, that might be a different bug. |
| 16:10 |
Dyrcona |
Well my barcode == username, and breaks the rules. I should have tested with a regular patron, and in light of this, I will test it again. |
| 16:11 |
Dyrcona |
I think I know the account to test with. One of those with the lowercase d in the barcode. They also have a different username. |
| 16:13 |
Dyrcona |
Hm.. the lowercase d password is inactive in my test database and the uppercase D one is active. I guess that's even better. :) |
| 16:17 |
Dyrcona |
Also, the code was implemented to only expect barcodes, but.... |
| 16:21 |
Stompro |
do you mean the "<AuthenticationInputType>barcode</AuthenticationInputType>" part? |
| 16:22 |
Stompro |
I noticed that also, but I don't remember what the other options in the standard were there off the top of my head. |
| 08:52 |
|
mmorgan joined #evergreen |
| 08:57 |
|
dguarrac joined #evergreen |
| 09:54 |
|
sleary joined #evergreen |
| 09:54 |
abneiman |
Bmagic++ # test server for parts |
| 09:58 |
|
redavis joined #evergreen |
| 11:39 |
abneiman |
for core committers, noting that Equinox/ECDI's big Acq pieces are pullrequested & signedoff if anyone has time to review: https://bugs.launchpad.net/evergreen/+bug/2039609 |
| 11:39 |
pinesol |
Launchpad bug 2039609 in Evergreen "wishlist: Acquisitions Sprint A - Z39.50 and other fixes" [Wishlist,Confirmed] |
| 11:39 |
abneiman |
Also, reports / reports security are here - the former has been extensively tested by the community; the latter by BCLC: https://bugs.launchpad.net/evergreen/+bug/1993823 and https://bugs.launchpad.net/evergreen/+bug/2043142 |
| 11:39 |
pinesol |
Launchpad bug 1993823 in Evergreen "wishlist: Angular Reports Interface" [Wishlist,Confirmed] |
| 11:39 |
pinesol |
Launchpad bug 2043142 in Evergreen "wishlist: Reports security improvements" [Wishlist,New] |
| 11:41 |
abneiman |
all of those are available at butternut.evergreencatalog.com for further review |
| 12:00 |
|
jihpringle joined #evergreen |
| 12:10 |
Bmagic |
Dyrcona: I'm troubleshooting the SFTP ingram sftp thing. I've successfully logged into their server using a GUI tool, but the funny thing is, their server is sending my GUI tool a banner message. Which, I think, is tricking the Evergreen code. We're able to push orders, but we can't receive. When attempting to scp manually via scp command, I get this: "exec request failed on channel 0" - which is their server attempting to use my tty ( |
| 12:10 |
Bmagic |
according to google) |
| 12:11 |
Bmagic |
did you deal with this during testing? |
| 12:11 |
berick |
hm, just deployed locally. i've only testing sending so far. |
| 12:11 |
berick |
*tested |
| 12:13 |
Bmagic |
bouncing this off of you: scp account_redacted ftp.ingramcontent.com:/outgoing/filename_redacted.EIN ./test.ein |
| 12:13 |
Bmagic |
does that look sound? |
| 12:14 |
Bmagic |
(it prompts for the password) - which I provide, then I get the "exec request failed on channel 0" error |
| 12:16 |
berick |
Bmagic: that fails for me too, but using "sftp" instead of "scp" works OK |
| 15:20 |
|
kworstell-isl joined #evergreen |
| 16:21 |
Stompro |
I think the fake ISBN's that B&T creates for DVDs are not conflicting with real codes. Looks like Romania and Argentina were assigned 630 and 631 in 2023. |
| 16:21 |
Stompro |
s/are not/are now/ |
| 16:36 |
Stompro |
But, a test system with ISBN::Data from 2021 also doesn't load them... so maybe something else is causing this. |
| 16:39 |
Dyrcona |
Fake ISBNs were problem never a good idea. |
| 16:40 |
Dyrcona |
s/problem/probably/ but somehow problem is more appropriate though is not an adverb. |
| 16:50 |
mmorgan |
probably a problem |
| 15:37 |
Bmagic |
I think* it was saving a bib record, which in-turn queried reporter.old_super_simple_record - which is what's written on the bug report |
| 15:37 |
eeevil |
there are certain things that JIT wants to do that we have already poured a lot of brain power into manually tuning |
| 15:37 |
Bmagic |
that makes sense |
| 15:38 |
eeevil |
it's not that EG is incompatible with PG's JIT, it's that (just like autovac and stats targets, and lots of other stuff, tbh) it requires config that is tuned to your particular size and shape of data |
| 15:39 |
eeevil |
a small EG instance may benefit a BUNCH from JIT, and reporting might as well (I've tested neither, but I have suspicions) |
| 15:40 |
sandbergja |
thanks, eeevil, that's helpful info to have |
| 15:40 |
eeevil |
but(!) unless someone has the tuits to learn the feature well, and analyze our queries in that context, I agree that we should recommend disabling JIT for now |
| 15:40 |
Bmagic |
eeevil++ |
| 15:41 |
eeevil |
I'd actually propose we investigate (as a community, as broadly as we can manage) cross-column stats targets before jumping into JIT |
| 15:41 |
Dyrcona |
I'm OK with that, but I don't think I've every encountered an issue caused by JIT. Pg 16 (even unoptimized) has pretty much always been faster than Pg 10 for me. BUT! I've not run it in produciton, just in testing on a production-sized database with a production-sized server. |
| 15:41 |
eeevil |
(not to derail the JIT-specific discussion, but as a query tuning tool I think that will pay off for more folks) |
| 15:42 |
eeevil |
Dyrcona: I haven't seen JIT-specific issues either, but I think we can be fairly sure that plan stability is /higher/ without JIT (until we learn to tune it well) |
| 15:43 |
Bmagic |
Disabling it fixed our problem on a test-then-production instance |
| 15:43 |
Bmagic |
pretty sure it manifested as a time-out when clicking on save in the MARC editor |
| 15:43 |
Dyrcona |
So, we'll recommend disabling JIT in the installation instructions, then. |
| 15:43 |
eeevil |
which is to say, yes, some folks will lose out on some optimizations they get "for free" with JIT on, but things are much less likely to go sideways in ways some have seen |
| 13:51 |
csharp_ |
Dyrcona: I just applied the fix and tlittle will be changing relevant accounts |
| 13:51 |
mmorgan |
Dyrcona++ |
| 13:51 |
csharp_ |
we asked Ingram for a test location and got crickets, so we'll be testing live |
| 13:52 |
csharp_ |
vendors don't seem to value testing in advance |
| 14:00 |
Dyrcona |
Ingram has a test server, but don't know how up to date it is. |
| 14:00 |
* Dyrcona |
tried sftp with B&T and the error was a rather unceremonious, "go away." |
| 14:03 |
Dyrcona |
Ugh! I typoed the page name when I created it..... |
| 14:06 |
Dyrcona |
OK, fixed it: https://wiki.evergreen-ils.org/doku.php?id=acq:edi_sftp |
| 14:07 |
Dyrcona |
Is there a particular mailing list I should send this to? I was just going to email the general list. |
| 14:12 |
Dyrcona |
I set up a test vm with sftp and copied files from production, but some things didn't show up until we used the production server. |
| 14:36 |
Dyrcona |
I feel like if I email the general list, someone's going to complain: "What is this? Why am I getting this?" |
| 14:37 |
pinesol |
News from commits: LP1843940 - Permission Tree Display Sort Order <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b3a4e37a697d5ba5ec126127b2bcc0b77306c6e4> |
| 14:39 |
Rogan |
Dyrcona I feel like when you sign up for the general list you're on the hook for a variety of evergreen related emails |
