| 15:22 |
eeevil |
I'm going to merge the self checkout followup followup, and then I think I'm done merging for the day... whew |
| 15:23 |
Dyrcona |
:) |
| 15:24 |
Dyrcona |
Reminds me of a line from "Christmas in Connecticut:" Shortcut to the the shortcut. Said after Sam(?) bogs the car down in a pond. |
| 15:25 |
pinesol |
News from commits: LP1840773: Test followup for self-checkout <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d7b2194676e773dd014d93dc55a73688337a47d0> |
| 15:25 |
pinesol |
News from commits: Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c94c0cb1403cf8c36760ec8c4cec335e4f5db210> |
| 15:25 |
pinesol |
News from commits: LP#1903749: Add upgrade script and seed data <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6fb3a2a60282c7ed31cc339cab58713186d0b4e5> |
| 15:25 |
pinesol |
News from commits: LP#1903749: WIP - allow adjacent-copy capture during stalling <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=04a228ddcae3907c4682f18099027342577e722e> |
| 15:25 |
pinesol |
News from commits: Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9dccf19cb03fc63b3f5ed33b380ea4383c10fbd1> |
| 15:25 |
pinesol |
News from commits: LP#2043142: Base IDL-configured report security <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=25e1fb282b4432aa97111419375c947d2027a600> |
| 15:26 |
Dyrcona |
Dang it! Wrong movie and wrong character. It's Gus from Holiday Inn..... I never should have gotten that gyro for lunch. :) |
| 15:30 |
Dyrcona |
I also wonder if this should be a bug all on its own? https://bugs.launchpad.net/evergreen/+bug/2073561/comments/16 |
| 15:30 |
pinesol |
Launchpad bug 2073561 in Evergreen "Incorrect content in the config.coded_value_map with ctype audience after applying the upgrade script from 3.12.3 to 3.13.0" [Medium,Confirmed] - Assigned to Jason Stephenson (jstephenson) |
| 16:46 |
Bmagic |
I'm troubleshooting a search result issue. Search does return results at the consortium level and you can see the item is clearly attached to a bib at a branch, but when I change the search to scope to that branch, no results. that's all I change, the branch |
| 16:46 |
Bmagic |
disable triggers? which triggers are you thinking are disabled? |
| 16:47 |
Bmagic |
how is it possible for earch to return just fine at the consortium level for a bib that contains exactly one item, attached at branch A, but searching in the scope of branch A doesn't return? |
| 16:48 |
eeevil |
triggers maintain the data used to test visibility, so ... those ones |
| 16:49 |
eeevil |
are there located URIs on the bib? |
| 16:49 |
|
jihpringle joined #evergreen |
| 16:49 |
Bmagic |
no |
| 16:51 |
jihpringle |
Bmagic: long shot but is there any chance the shelving location is deleted? |
| 16:51 |
Bmagic |
biblio record entry has {} for vis_attr_vector |
| 16:51 |
eeevil |
Bmagic: and, to be clear, modern EG tests visibility on demand, it does not use the old visibility caching. various stuff is collected statically into an int array, and then that is checked with an overlaps test against the currently-configured set of visible things |
| 16:51 |
Bmagic |
I checked that, non of the things are opac_visible='false |
| 16:52 |
jihpringle |
we ran into some really weird issues in search and display when a library accidentally deleted a shelving location they were still using |
| 16:52 |
Bmagic |
the status is "in Process" which is opac visible, the shelving location is visible, the org unit is visible |
| 14:42 |
|
abowling joined #evergreen |
| 14:43 |
redavis |
Dyrcona, did you allow it for all permission groups or one specifically? |
| 14:46 |
Dyrcona |
1 specifically... the one I'm in. |
| 14:48 |
redavis |
Is this a localized server environment or test w/ concerto? |
| 14:50 |
Dyrcona |
It's basically a copy of our production that has been upgraded to 3.13.3. |
| 14:50 |
Dyrcona |
I think I have to do more configuration before I can actually turn it on. I'll check the documentation. |
| 14:51 |
redavis |
Got it. I was going to see if you wanted someone to take a look if had an anonymous dataset. But...n/m. I ain't an expert at all, but did fuss around with it a lot. |
| 14:53 |
abneiman |
still some open spots on the BuildMaster sheet for next week if anyone's available: https://docs.google.com/spreadsheets/d/1gZayHfF7qK0zwLMEAXt-PbKBMiAM_F6EZguqzIYceBY/edit?usp=sharing |
| 14:54 |
abneiman |
(shameless plug) |
| 14:55 |
redavis |
specifically someone to test Bmagic's 3.13.4 tarball. |
| 14:55 |
|
mantis left #evergreen |
| 14:56 |
Dyrcona |
I'm getting something about undefined factors. I have more set up to do. |
| 14:57 |
Dyrcona |
Doesn't help I'm trying to do something else time sensitive, and I think I missed it. |
| 16:05 |
redavis |
NC was very hard after it, as was GA and grumblings from IN as well. |
| 16:05 |
redavis |
lol, I won't tell anyone about SIP2. Until the "after days" |
| 16:07 |
Dyrcona |
I think this works well enough to put in for 3.14 beta. Any bugs turn up we can fix them before the final release. |
| 16:08 |
redavis |
Yes. And it's going to need some broader scope production testing as well. There will invariably be some tickets that spin off from it, but I think it's a very solid and functional big first step. |
| 16:08 |
redavis |
For something that a lot of people concede is necessary but feel like it's a PITA. |
| 16:09 |
Dyrcona |
It just means I have to get up to get my phone out of my pants when working from home. :) |
| 16:09 |
redavis |
see? It's actually SAVING you from a PITA. |
| 16:09 |
Dyrcona |
I already do this for Github, Gmail/Google, payroll/time clock, etc. |
| 17:33 |
eeevil |
right on. now, having tossed those out, I run away! |
| 17:33 |
Bmagic |
laters |
| 17:38 |
Guest6 |
Hello. In web staff client for holding "Pickup Location" shows Short (Policy) Names. I want to show organisation unit names. How can I do this? |
| 17:40 |
Bmagic |
eeevil: combined was set to no, so I set it to yes. That didn't fix it, but maybe we need to reingest after that? I just reingested the one record that I'm testing with and it doesn't to seem to have solved it. I didn't restart Evergreen though |
| 17:41 |
Bmagic |
Guest6: is this while placing a hold? Or are you creating/editing a hold policy? |
| 17:48 |
Guest6 |
Yes, while pacing hold. |
| 17:49 |
Guest6 |
while placing hold. |
| 11:37 |
csharp_ |
ian2: logs information that's probably useful: https://docs.google.com/document/d/1BJ7kSr5LfPkxXRhcrYjNyPlbT9PlNFHg6zL-tyetnKA/edit?pli=1 |
| 11:38 |
csharp_ |
that doc or something like it needs to go into the official documentation |
| 11:38 |
csharp_ |
I'll submit a docs pull request at some point |
| 11:38 |
mmorgan |
ian2: Not really, we originally had a single hold.available trigger at the CONS level, but moved them all down to system and branch level during covid times by cloning the CONS one and editing the owner. Then we could enable when appropriate. |
| 11:41 |
mmorgan |
ian2: I assume you're testing by checking in a held item so that it goes on the Holds Shelf? |
| 11:42 |
ian2 |
You assume correct |
| 11:42 |
mmorgan |
:) |
| 12:17 |
Bmagic |
csharp_: PG15 is working for us, but I've been limiting it to Evergreen 3.12 and higher. I can't say for previous versions of EG |
| 15:20 |
Bmagic |
#action waiting on |
| 15:20 |
Bmagic |
whoops |
| 15:20 |
Bmagic |
#action waiting on gmcharlt for access to POEditor for git integration |
| 15:20 |
Bmagic |
#info sleary and sandbergja will create/consolidate the test writing wiki page(s) |
| 15:21 |
sleary |
sandbergja and I will meet later this week to work on that |
| 15:21 |
sleary |
carry forward, please |
| 15:21 |
Bmagic |
#action sleary and sandbergja will create/consolidate the test writing wiki page(s) |
| 15:21 |
Bmagic |
#info sandbergja will make it easier for folks to know how to run the tests in single file mode and all-mode |
| 15:21 |
Bmagic |
I guess that's the same thing? |
| 15:21 |
sleary |
yes |
| 15:21 |
Bmagic |
#info berick and jeff will look at making Hatch look better in the chrome store, so that it's not removed |
| 15:21 |
Bmagic |
#info berick: added pullrequest for bug 2076921 |
| 15:21 |
pinesol |
Launchpad bug 2076921 in Evergreen "Hatch: Chrome Extension Requires Redevelopment" [High,Confirmed] https://launchpad.net/bugs/2076921 - Assigned to Jeff Godin (jgodin) |
| 15:21 |
jeff |
berick has a branch / pullrequest for the Manifest V3 changes, and I've just grabbed the bug to test. The changes look like they were "routine" and not "we hav to completely change our approach", so I'm cautiously optimistic. :-) |
| 15:22 |
berick |
yeah, was less intrusive than I expected |
| 15:22 |
Bmagic |
jeff++ |
| 15:22 |
Bmagic |
berick++ |
| 15:22 |
mmorgan |
berick++ |
| 15:22 |
mmorgan |
jeff++ |
| 15:22 |
jeff |
other testing welcome, especially if you feel your environment may be unusual (though this changes the extension, and not the native messenger / locally installed bits) |
| 15:22 |
csharp_ |
jeff++ |
| 15:22 |
csharp_ |
berick++ |
| 15:22 |
shulabramble |
jeff++ berick++ |
| 15:23 |
Bmagic |
who is the one that installs/updates the extension in the store? |
| 15:23 |
berick |
i should have access |
| 15:23 |
berick |
galen does too, maybe others |
| 15:23 |
jeff |
I think the next step assuming successful testing will be to do a short beta test in the Chrome web store, to ensure that the V2 -> V3 upgrade doesn't introduce any unexpected "hey you have to re-re-enable this 'sideloaded' extension" problems, etc. |
| 15:23 |
Bmagic |
jeff: perfect |
| 15:24 |
Bmagic |
we need a sign-off, merge, and beta version in the store? |
| 15:24 |
berick |
and likely some docs around Firefox, since I had to break the manifests into one file per browser |
| 15:25 |
jeff |
prettyty much. please carry forward as testing in progress, and I hope/expect we should have progress to report next meeting. |
| 15:25 |
jeff |
assuming my keyboard / terminal stops repeating my letters. :-P |
| 15:25 |
dluch |
lol |
| 15:26 |
Bmagic |
#action bug 2076921 expected to get more testing and merged, and beta uploaded to store |
| 15:26 |
pinesol |
Launchpad bug 2076921 in Evergreen "Hatch: Chrome Extension Requires Redevelopment" [High,Confirmed] https://launchpad.net/bugs/2076921 - Assigned to Jeff Godin (jgodin) |
| 15:26 |
Bmagic |
#info Bmagic will work on upgrading the version of DokuWiki |
| 15:26 |
Bmagic |
I did it! Thank you, thank you |
| 15:49 |
sandbergja |
jeffdavis: I'm glad you mentioned that, I was wondering about that |
| 15:49 |
Bmagic |
sure! It seems like we don't have a lot* of jQuery and dojo code integrated anymore |
| 15:49 |
dluch |
jeffdavis++ |
| 15:49 |
sandbergja |
can it be accurately tested with the test ebook, or would it need to be done with an Overdrive subscription? |
| 15:49 |
dluch |
jeff++ |
| 15:49 |
Bmagic |
jeffdavis++ jeff++ |
| 15:49 |
sleary |
Bmagic that is my impression, but there may be random pockets of stuff I haven't unearthed |
| 15:50 |
Bmagic |
fewer_dependencies++ |
| 15:50 |
jeffdavis |
sandbergja: it's been a long time since I touched it, but the test stuff ought to be enough to confirm that the UI is working IIRC |
| 15:50 |
sleary |
and I will note that it will still be possible to include jQuery if you want it for your custom theme; I just want to eliminate its weight from our default templates, since most of what it does can be done in plain JS these days |
| 15:51 |
Bmagic |
sleary++ # yes! |
| 15:51 |
Bmagic |
ok, anything else on that? |
| 15:52 |
sandbergja |
just to return to my favorite soapbox, it's much easier to write automated tests for opac js behavior that does not rely on external dependencies |
| 15:52 |
sandbergja |
so fewer_dependencies++ for that reason too! |
| 15:52 |
sleary |
sandbergja++ automated_testing++ |
| 15:52 |
shulabramble |
plain_js++ |
| 15:53 |
Bmagic |
a win, win, and probably another win too |
| 14:51 |
pinesol |
Launchpad bug 1948983 in Evergreen "Reports Administrator Permission to View Other Users Templates, Reports, and Output" [Wishlist,Confirmed] https://launchpad.net/bugs/1948983 |
| 14:52 |
jihpringle |
Bmagic: is that in angular reports? |
| 14:52 |
Bmagic |
yes, sorry, 3.13 |
| 14:53 |
jihpringle |
I've seen that in testing, I thought it got reported but maybe not |
| 14:53 |
Bmagic |
should it be a bug? Or are "we" (the community) assuming that when you share a template folder, it's fair game for adding templates? |
| 14:54 |
jihpringle |
for us, it would definitely be a bug |
| 14:54 |
jihpringle |
it would make our shared consortium template folders unusable if anyone can save into them |
| 14:59 |
Bmagic |
I'll write a new report for it I guess |
| 14:59 |
abneiman |
Bmagic: curious for details on this one, as IIRC (and as jihpringle mentioned) this was disovered & fixed during the run up to 3.13 |
| 15:00 |
Bmagic |
we have a consortium on 3.13.0, and a staff member cloned a template into another staff member's shared folder. Maybe it was fixed later? 3.13.1 or .2? |
| 15:01 |
abneiman |
on a stock 3.13.1 test system, a CONS-shared folder behaves as expected (i.e. templates can be used to create a new report, or cloned into one of your own folders). I am NOT seeing that a user can choose a shared folder as a destination for a clone. |
| 15:01 |
Bmagic |
what about simple reports? |
| 15:01 |
Bmagic |
maybe a loophole |
| 15:02 |
abneiman |
simple reports doesn't support sharing or folders |
| 15:02 |
jihpringle |
I think it was happening when you went to clone from shared folder and then canceled it partway through, instead of cancelling the clone it created the template in the shared folder it came from |
| 15:03 |
jihpringle |
(I tested quite a while ago and haven't tested on a 3.13 server) |
| 15:05 |
Bmagic |
I'm testing |
| 15:10 |
Bmagic |
must be something on 3.13.0, because bugsquash.mobiusconsortium.org doesn't allow it |
| 15:20 |
abneiman |
dunno, the only difference between 3.13.0 and 3.13.1 is a handful of security patches. I had Christine Burns' original comment about the cloning issue (https://bugs.launchpad.net/evergreen/+bug/1993823/comments/8) in my internal feedback list with a note "resolved 4/17" |
| 15:20 |
pinesol |
Launchpad bug 1993823 in Evergreen "wishlist: Angular Reports Interface" [Wishlist,Fix released] |
| 15:22 |
abneiman |
anyway I have to run but I'd be interested in other details of how this happened, Bmagic |
| 15:23 |
Bmagic |
me too! I don't see how they did it. It's not in the UI on production |
| 15:24 |
Dyrcona |
It's just one of those things, like the purchase orders I'm looking at that silently fail to create EDI messages, though everything looks right to be able to do that. |
| 15:40 |
Dyrcona |
OK. If I run edi_order_pusher.pl in test mode on one fo the PO ids, it produces output. |
| 15:54 |
Dyrcona |
So, when I ran the order pusher on each purchase order id, they worked. For some reason, these purchase orders were not getting picked up by the order pusher otherwise, even though they turn up when I run the equivalent SQL query to get all of the active pos. |
| 16:06 |
Bmagic |
UHG |
| 16:06 |
Bmagic |
that's annoying |
| 09:58 |
Dyrcona |
:) |
| 09:58 |
pinesol |
News from commits: LP#2069472 Conjoined Items Grid Config Not Saving <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=716e81310735d18537d2f0b7b75701a703faf319> |
| 09:58 |
csharp_ |
pinesol: blame [someone] for Dyrcona lapsing into German |
| 09:58 |
pinesol |
dluch_ tests their code on the LIVE SERVERS, then blames the user. SAD! for Dyrcona lapsing into German |
| 09:59 |
Dyrcona |
Whatever.. It just popped into my head because of the praise. It was a tagline I used to use on a MMO years ago: "Entdecke die Insel von Dyrcona." (Yeah, I used it as my gamer tag, too.) |
| 10:00 |
Dyrcona |
It means, "discover the island." |
| 10:03 |
csharp_ |
Dyrcona++ |
| 11:52 |
mmorgan |
redavis: What are you trying to meld together? |
| 11:52 |
Dyrcona |
redavis: What are you trying to do, and if you it frequently, maybe a view is in order? |
| 11:54 |
jeff |
speaking of billing: when staff incorrectly record the payment type, how are most folk handling that? manual corrections in the back office, directly correcting the issue in the database, or something else? |
| 11:54 |
redavis |
I was trying to get a report of anyone that had a bill. I could set up a traditional report (if clark kent is running on the test server), but was hoping I could run into simple reporter and throw something together quickly. |
| 11:55 |
jeff |
(I can't remember if I've asked that question here recently or not) |
| 11:56 |
redavis |
I didn't find an easy way to get patron connected to billing in simple reporter. It seems to focus on org units. I suspect if I used the circulation "source" it might be doable, but it went beyond the "quick and easy." |
| 11:56 |
Dyrcona |
jeff: I don't deal with that, and I don't hear anyone at CW MARS talking about it. If you really want an answer, you might try the general list. |
| 12:27 |
Dyrcona |
@band add The Reporters |
| 12:27 |
pinesol |
Dyrcona: Band 'The Reporters' added to list |
| 12:40 |
|
kmlussier left #evergreen |
| 12:42 |
eeevil |
(I (I won't blame/out others) call the full reporter Avril internally -- why you gotta make everything so complicated?) |
| 12:43 |
eeevil |
redavis: jfyi, both simple and full reports depend on clark to generate output, so if you have simple on test, you have full also. |
| 12:51 |
redavis |
eeevil, acknowledged about clark/avril. It wasn't so much the running as the preparing to run. I was putting more energy into the building than getting on with the testing. |
| 12:54 |
redavis |
and also acknowledged about SR in relation to billing JBoyer. I just don't generally use SR, and wanted to be a little lazy about building a template in the full reporter...so was hoping someone had done a lot of work so I wouldn't have to. And then I realized, I still don't have to...cuz what I was doing was a choice. So...I quit and ate lunch. The world is better. Also, I love Avril Lavigne and am mostly very happy |
| 12:54 |
redavis |
with complexity. Even if it makes things more...complicated. |
| 13:42 |
|
kworstell_isl joined #evergreen |
| 14:37 |
Dyrcona |
I might have an idea how to fix the 1416 upgrade before it gets run, i.e. replace it. |
| 14:39 |
Dyrcona |
Instead of grabbing the first record attr defintion from the list of rec_types, we add the rec_type as a function parameter. |
| 11:14 |
csharp_ |
ehrmagerd berg squersh |
| 11:15 |
Bmagic |
lol, took me a second |
| 11:15 |
Bmagic |
csharp_++ |
| 12:03 |
Bmagic |
what's the magic trick to get the nightwatch tests to run with gecko/firefox? This is the command i'm using: mkdir $HOME/tmp; MOZ_HEADLESS=1 TMPDIR=$HOME/tmp ng e2e |
| 12:03 |
Bmagic |
error: Failed to connect to GeckoDriver on localhost with port 4444. |
| 12:07 |
|
jihpringle joined #evergreen |
| 12:13 |
Bmagic |
just found out that firefox isn't installed, gonna install it |
| 17:11 |
|
mmorgan left #evergreen |
| 17:35 |
Bmagic |
lol |
| 17:35 |
Bmagic |
JBoyer++ |
| 17:36 |
Bmagic |
for those of us who are still here: I'm running perl live tests via "make livecheck" - and it's all passing, but it's stumbling on the offline interface check. There's this grep command: 'wget --no-check-certificate -m https://localhost/eg/staff/offline-interface 2>&1 |grep -B 2 " 404 "|grep https|grep -v robots.txt|wc -l' |
| 17:36 |
Bmagic |
which in my case returns 13, bunch of js and css files in the build folder |
| 17:47 |
Bmagic |
nevermind, figured it out :) |
| 17:47 |
csharp_ |
what was it? |
| 17:48 |
csharp_ |
localhost/docker? |
| 17:48 |
Bmagic |
rsync -L -a --no-owner --no-perms --size-only /home/opensrf/repos/Evergreen-build/Open-ILS/web/js/ui/default/staff/ /openils/var/web/js/ui/default/staff |
| 17:49 |
Bmagic |
I had performed a step out of order, and the final /openils folder needed the results of "cd /home/opensrf/repos/Evergreen-build/Open-ILS/web/js/ui/default/staff/ && npm run build-prod" |
| 17:49 |
csharp_ |
ah |
| 17:50 |
csharp_ |
hooray for tests! |
| 17:50 |
Bmagic |
yeah, the more I run them, the more I want to write more |
| 17:50 |
Bmagic |
those nightwatch tests are spectacular because they click on the interface the way humans do |
| 17:51 |
csharp_ |
still haven't found time to get to that |
| 17:52 |
Bmagic |
I'm working on bug 2068740 |
| 17:52 |
pinesol |
Launchpad bug 2068740 in Evergreen "Concerto and Enhanced Concerto user passwords should be updated" [Undecided,Confirmed] https://launchpad.net/bugs/2068740 |
| 17:52 |
Bmagic |
which, has the nasty side-effect of ruining our test suite. perl, postgres and angular/nightwatch |
| 17:53 |
Bmagic |
and violla: I got real familiar with our tests |
| 17:55 |
csharp_ |
can we just pass environment vars or something? |
| 17:55 |
Bmagic |
yeah, I know what you mean. I had the same thoughts: our tests need to be smarter |
| 17:56 |
Bmagic |
lots of hardcoded ID numbers and assumptions of the concerto set |
| 17:56 |
Bmagic |
nightwatch, for example, expects to find "BR1" in the branch list when it's siumating all of the clicks to register a workstation |
| 17:57 |
csharp_ |
ick |
| 17:57 |
Bmagic |
siumataing/simulating # lol |
| 17:57 |
Bmagic |
so, automatically, the nightwatch test requires the old concerto set and doesn't work with enhanced |
| 18:01 |
csharp_ |
Bmagic++ # doing God's work |
| 18:05 |
|
kmlussier left #evergreen |
| 18:11 |
sleary |
I have not had time to play with Nightwatch as much as I would like, but there is a recording of Jane explaining the tests somewhere in the New Devs meeting archives |
| 18:12 |
sleary |
as soon as I figure out how to make it take screenshots automatically, I will acheive documentation nirvana |
| 10:27 |
Dyrcona |
If you were hosting Aspen also, I'd suggest getting into Solr. That way there is only 1 to support. But... I suppose one could always add ES to Aspen... :) |
| 10:28 |
Rogan |
I need a face melting emoji to reply to Dyrcona's comment there |
| 10:30 |
Rogan |
joking aside, I've been working with Aspen on a mostly application end user level but hoping to dig into the guts more |
| 10:32 |
* Dyrcona |
has PRs added to Aspen. :) I have yet to set up a test Aspen installation, but it's on my list of things that I'll (probably) never get to. |
| 10:35 |
redavis |
Y'all are the best ever. Also, pretty sure my husband wasn't expecting a long diatribe aboue databases, indexes, and search when he asked how my studying for the master gardener class was going. |
| 10:35 |
berick |
ooh, Master Gardener |
| 10:35 |
berick |
nice |
| 11:22 |
redavis |
mmorgan, Bmagic, once y'all get your branches, I'll send out an email that the merge pause has been lifted. |
| 11:22 |
Bmagic |
redavis++ # rock'n roll branch'n emailer |
| 11:23 |
* mmorgan |
is just going into a meeting, will have to grab it after. |
| 11:23 |
Dyrcona |
csharp_: I have not seen that on my test systems, but granted, I don't update a whole lot of bibs all at once. We probably should consider forcing serialized updates on bibs. |
| 11:23 |
berick |
csharp_: see also the description of bug 1880726. |
| 11:23 |
pinesol |
Launchpad bug 1880726 in Evergreen "MARC Batch Edit Angular Port" [Wishlist,Fix released] https://launchpad.net/bugs/1880726 |
| 11:23 |
redavis |
I ain't got a lot of skillz, but I can email like a master...typer (with typos included) |
| 15:02 |
|
halloy1408 joined #evergreen |
| 15:05 |
|
adam_reid joined #evergreen |
| 15:09 |
|
Stompro joined #evergreen |
| 15:17 |
Dyrcona |
Hm... I should probably update the Redis branch on the server where I'm testing it. |
| 15:24 |
Dyrcona |
I wonder if I can just install it while things are running. Well, I guess I'll find out. |
| 15:30 |
Dyrcona |
That seemed to work. |
| 15:30 |
Dyrcona |
Nothing has gone boom so far.... |
| 15:11 |
mmorgan |
sandbergja++ abneiman++ redavis++ Dyrcona++ |
| 15:11 |
sleary |
Dyrcona++ |
| 15:11 |
redavis |
Dyrcona++ sandbergja++ abneiman++ mmorgan++ |
| 15:11 |
Bmagic |
#info abneiman will review existing EOLI PRs for test plans |
| 15:11 |
shulabramble |
Dyrcona++ sandbergja++ abneiman++ mmorgan++ |
| 15:12 |
abneiman |
I reviewd them but did not add test plans to any. Will do so in advance of BSW. |
| 15:13 |
Bmagic |
abneiman++ |
| 15:13 |
sandbergja |
abneiman++ # that's awesome |
| 15:13 |
shulabramble |
abneiman++ |
| 15:13 |
Bmagic |
want that carried? |
| 15:14 |
jvwoolf |
abneiman++ |
| 15:14 |
abneiman |
nah |
| 15:14 |
Bmagic |
#info abneiman will add a discussion item for next meeting: test plans for big features |
| 15:14 |
abneiman |
I ninja-edited that into the agenda 10 minutes ago :) |
| 15:14 |
Bmagic |
I see that, lol |
| 15:14 |
* redavis |
was also ninja editing |
| 15:34 |
Bmagic |
#info Needstestplan tag Added - 0 |
| 15:34 |
Bmagic |
#info Needsrebase tag Added - 5 |
| 15:34 |
Bmagic |
#info Fix Committed - 22 |
| 15:34 |
Bmagic |
#topic New Business - (Jane) How can we encourage more automated testing?, What are current barriers to writing and running the automated tests? |
| 15:34 |
sandbergja |
ok, my turn to paste some stuff: |
| 15:34 |
Bmagic |
#link https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa |
| 15:34 |
sandbergja |
During the 3.12 and 3.13 release process, we found a number of big issues that we were able to resolve before cutting the release, for example: |
| 15:34 |
sandbergja |
an unpredictable intermittent failure in search, a bug that prevented users from adding new action trigger event defs, a case where I had committed the wrong patch from a launchpad ticket, one where the holdings view wouldn't load, and a major accessibility regression that detached form inputs from their labels across the client. |
| 15:35 |
sandbergja |
And the way we found those was by one of our automated tests failing, alerting us to the issue, which is great! Very nice that we discovered those before they were in production. |
| 15:35 |
sandbergja |
However, it makes me think how many more regressions we could be catching if we'd been writing and running tests more often over the past 9 years. |
| 15:35 |
sandbergja |
So... I'd like to know: how can we get there? What barriers can we iron out around automated testing? |
| 15:36 |
redavis |
sandbergja++ |
| 15:36 |
shulabramble |
sandbergja++ |
| 15:37 |
Bmagic |
those node nightwatch tests are clever. Automating the process of clicking on the interface like a human would. Not sure what the barriers are? Hard to write? |
| 15:38 |
sleary |
IIRC there are two (maybe three?) different QA/guideline documents for contributions that have different instructions, and we need to consolidate them into one coherent process. |
| 15:38 |
Bmagic |
consolidate! +1. Got links? |
| 15:38 |
Stompro |
For me personally it is just the time it takes to create the tests, but I know if I do it more often it wouldn't take me as long. |
| 15:39 |
sleary |
working on links |
| 15:40 |
sandbergja |
Stompro++ sleary++ Bmagic++ |
| 15:41 |
Bmagic |
giving sleary a minute |
| 15:43 |
Bmagic |
sleary++ |
| 15:43 |
sandbergja |
consolidating and refining those seems like a great place to start |
| 15:43 |
sleary |
https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:common_qa_problems might also be relevant |
| 15:44 |
terranm |
+1 to a single page just about writing tests |
| 15:44 |
Bmagic |
do we need to make assignments around this? |
| 15:44 |
sleary |
sandbergja I will be happy to help with that... about a month from now, lolsob |
| 15:44 |
Bmagic |
sleary++ |
| 15:44 |
terranm |
sleary++ sandbergja++ |
| 15:44 |
shulabramble |
+1 to a page about writing tests |
| 15:44 |
sandbergja |
a month sounds great! And I'm also happy to help as needed! |
| 15:45 |
mmorgan |
+1 to a page about writing, and also running them |
| 15:45 |
jeff |
do we need to do anything to remove barriers to running the tests? i.e., is setting up an environment where you can run the tests challenging or not-well-documented? |
| 15:45 |
redavis |
sandbergja++ sleary++ |
| 15:45 |
sleary |
I know that sandbergja has given a couple of talks in New Devs about test-driven development, and we can pull things from those meeting archives |
| 15:45 |
redavis |
jeff, good question |
| 15:45 |
Bmagic |
#action sleary and sandbergja will create/consolidate the test writing wiki page(s) |
| 15:45 |
terranm |
It always makes sense when I watch Jane do it, but then confusion returns |
| 15:46 |
Bmagic |
jeff: the docker container image now days is including the pre-reqs which is nice |
| 15:46 |
sleary |
jeff I think there is one quirk around Firefox, but it's mentioned in the eg2 CHEAT SHEET doc |
| 15:46 |
Bmagic |
Imma preserve those wiki urls |
| 15:46 |
sandbergja |
for me, reloading a test database from scratch can take a while, and a clean db is necessary for some of the tests |
| 15:46 |
Bmagic |
#link https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:common_qa_problems |
| 15:47 |
Bmagic |
#link https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa |
| 15:47 |
Bmagic |
I added a feature to the the dev container, which I find myself using a bunch, that automates the creation of new databases by editing a text file |
| 15:47 |
sleary |
the e2e tests take a while to run, and the syntax for running them on a single file or directory is not easy to remember |
| 15:48 |
sandbergja |
true sleary |
| 15:48 |
sleary |
we can probably script our way out of that problem :) |
| 15:48 |
sandbergja |
Bmagic I know you've told me this before, but I gotta start using the dev containers! |
| 15:49 |
Bmagic |
sandbergja: the water is fine, lol |
| 15:49 |
Bmagic |
the takeaway was consolidating the wiki pages |
| 15:50 |
Bmagic |
shall we add something else? |
| 15:50 |
sleary |
maybe step 2 can be writing some simple example tests or pinpointing old ones as good examples for basic tasks |
| 15:50 |
sandbergja |
maybe as part of that process we can look into the syntax for nightwatch on a single file or directory -- whether it is a docs fix or a script fix? |
| 15:51 |
sleary |
sandbergja++ |
| 15:52 |
Bmagic |
making sure I'm understanding: making the test run differently depending on what was committed? |
| 15:52 |
sleary |
running the tests on only the files you changed rather than the whole Angular project |
| 15:52 |
Bmagic |
gotcha, and what's missing for that to work? |
| 15:52 |
sleary |
memorable syntax |
| 15:53 |
sleary |
sheet |
| 15:53 |
eeevil |
I would appreciate a how-to, for sure. fwiw |
| 15:53 |
sandbergja |
so better syntax and better docs perhaps |
| 15:54 |
Bmagic |
maybe a wrapper that takes some evergreen-community arguments. like ./wrapper --one-test path/to/file |
| 15:54 |
sleary |
that's what I was thinking, but docs would be simpler :) |
| 15:54 |
Bmagic |
docs would be simplier :) |
| 15:55 |
dluch |
docs++ ;-) |
| 15:56 |
sleary |
that should probably be a separate action from the wiki page consolidation |
| 15:56 |
Bmagic |
would you like to have it? |
| 15:56 |
sandbergja |
you could put my name on it |
| 15:56 |
Bmagic |
#action sandbergja will make it easier for folks to know how to run the tests in single file mode and all-mode |
| 15:57 |
Bmagic |
sandbergja++ |
| 15:57 |
sleary |
sandbergja++ |
| 15:57 |
sandbergja |
thanks everyone! |
| 15:57 |
dluch |
sandbergja++ |
| 15:58 |
berick |
count me in for helping with Hatch work. hopefully i can pitch in starting next week |
| 15:58 |
* berick |
runs off to another meeting |
| 15:58 |
jeff |
happy to help / help test. |
| 15:58 |
Bmagic |
berick++ |
| 15:58 |
Bmagic |
jeff++ |
| 15:58 |
sandbergja |
berick++ jeff++ |
| 16:01 |
sleary |
csharp_ most likely. I think I can, but I'm reluctant to touch things without taking time to make my own backups |
| 16:02 |
Bmagic |
I can help too :) |
| 16:02 |
Bmagic |
#action Bmagic will work on upgrading the version of DokuWiki |
| 16:03 |
Bmagic |
#topic (ABN) Test plans for big features? |
| 16:03 |
Bmagic |
We're almost done... sorry we're going over |
| 16:03 |
abneiman |
yes, so, briefly |
| 16:03 |
abneiman |
what does the community want to / need to see out of test plans for new features? |
| 16:04 |
abneiman |
things that are beyond the scope of "X is broken, install patch Y, follow steps 1 2 3, profit" |
| 16:04 |
Bmagic |
are you finding that certain things need more than our bsw and bff ? |
| 16:04 |
abneiman |
asking because several EOLI feature PRs are either forthcoming soon, or carryovers from 3.13, and I want to make sure I'm doing what is needed to facilitate review & commit of those things |
| 16:05 |
Stompro |
I always appreciate notes on how to configure the system if certain lib settings need to be enabled, etc. |
| 16:05 |
jeff |
varies, but maybe starting with: "here is a summary of / pointer to description of what this code should add/change/fix; here is a recommended way to test / how we tested; here are special considerations / gotchas"? |
| 16:05 |
abneiman |
Stompro++ jeff++ |
| 16:05 |
mmorgan |
What Stompro said. Also if certain data is needed. |
| 16:05 |
abneiman |
both helpful thanks |
| 16:05 |
abneiman |
mmorgan++ |
| 16:06 |
redavis |
Stompro++ jeff++ mmorgan++ |
| 16:06 |
abneiman |
and Bmagic, regarding BSW, I acknowlege that it's hard to test big features when there's a lot of other fixes flying around ... which is fine, IMO, that's what BSW is about. |
| 16:06 |
Bmagic |
Stompro++ jeff++ mmorgan++ |
| 16:07 |
Bmagic |
abneiman++ # I think I took your query the wrong direction after reading Stompro, jeff and mmorgan's ideas |
| 16:07 |
abneiman |
like I said, I want to make sure we're doing what we can to faciliate merges of features. And to maybe offer similar guidelines to other feature developers |
| 16:41 |
Bmagic |
csharp_: that sounds super easy |
| 16:41 |
csharp_ |
yep, and quick |
| 16:41 |
csharp_ |
just back up the folder for safety |
| 16:41 |
Bmagic |
do you have an reservations about clicking on it without testing it on a cloned env? |
| 16:41 |
csharp_ |
nah, I've done it several times |
| 16:42 |
Bmagic |
ok then, sounds like it's in good hands! |
| 16:42 |
csharp_ |
we do keep backups for 30 days on that server at ITS also |
