| 01:50 |
|
khuckins_ joined #evergreen |
| 02:40 |
|
khuckins joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:18 |
|
khuckins joined #evergreen |
| 06:27 |
|
khuckins joined #evergreen |
| 07:17 |
|
Dyrcona joined #evergreen |
| 13:03 |
jeff |
apache's /tmp is not your /tmp :-) |
| 13:04 |
jeffdavis |
I believe private /tmp is a change between Ubuntu 16.04 and 18.04 fwiw |
| 13:07 |
Dyrcona |
Well, I hadn't noticed because I don't use it much on development, and we've been using /openils/var/tmp mounted via NFS in production for years. |
| 13:08 |
Dyrcona |
So, I'm actually testing a security bug and trying to import a MARC record to trigger it, but the record won't import. |
| 13:08 |
Dyrcona |
When I select it and hit Import Selected Records, the screen goes back to the main Import view, and the record does NOT end up in biblio.record_entry. |
| 13:09 |
Dyrcona |
FWIW, I have no idea what I'm doing in the staff client, particularly the Angular interface. |
| 13:28 |
Dyrcona |
So, maybe Vandelay is broken in master on Ubuntu 20.04? |
| 15:03 |
|
jvwoolf joined #evergreen |
| 15:07 |
Dyrcona |
I wonder if XUL really matters for bug 1076582? |
| 15:07 |
pinesol |
Launchpad bug 1076582 in Evergreen "Remove or document references to openils_dojo.js" [Low,Confirmed] https://launchpad.net/bugs/1076582 - Assigned to Jason Stephenson (jstephenson) |
| 15:08 |
Dyrcona |
After applying the branch, I found a couple of active references to openils_dojo.js in the XUL code, and I wonder if building a XUL client and testing it is worth the trouble at this point? |
| 15:13 |
|
sandbergja_ joined #evergreen |
| 15:20 |
|
jihpringle joined #evergreen |
| 15:24 |
JBoyer |
If there's not a reference under Open-ILS/xul/server I don't think it matters whether the client works or not. (I was thinking there *may* be something still using parts of server/* ?) |
| 16:01 |
Dyrcona |
Well. It seems to have undone the security patch that I just installed, but I think that's because I switched branches when building the custom dojo. |
| 16:03 |
Dyrcona |
I seem to be getting a lot of uncaught exceptions, too. |
| 16:19 |
Dyrcona |
I should probably wipe /openils and install fresh. |
| 16:27 |
csharp |
so we're running the upgrade script for bug 1893997 against a PINES test server and lordy that's going to take a long time to run |
| 16:27 |
pinesol |
Launchpad bug 1893997 in Evergreen "Wishlist: Did you mean? Single word, single class substitutions" [Wishlist,New] https://launchpad.net/bugs/1893997 |
| 16:27 |
csharp |
followed by a reingest |
| 16:28 |
csharp |
gonna research whether the changes can be applied outside of a downtime window |
| 16:35 |
Dyrcona |
Yeahp. |
| 16:36 |
Dyrcona |
It looks to me like you'll be ok as long as you don't set the opac.did_you_mean.max_suggestions org unit setting. |
| 16:45 |
|
sandbergja_ joined #evergreen |
| 16:57 |
Dyrcona |
Ah, well. Testing will have to continue tomorrow. |
| 16:58 |
csharp |
Dyrcona: thanks for checking on that |
| 16:59 |
Dyrcona |
Well, I'm not 100% certain. I based that assumption on what I see in the upgrade script. |
| 16:59 |
|
jvwoolf left #evergreen |
| 17:01 |
Dyrcona |
I'll be back tomorrow. Have a good rest or your day or night, everyone! |
| 17:12 |
|
stompro_ joined #evergreen |
| 17:24 |
|
mmorgan left #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:02 |
|
sandbergja_ joined #evergreen |
| 20:39 |
|
sandbergja_ joined #evergreen |
| 20:51 |
|
malexander joined #evergreen |
| 01:08 |
|
phasefx joined #evergreen |
| 03:44 |
|
khuckins joined #evergreen |
| 04:16 |
|
khuckins joined #evergreen |
| 04:56 |
pinesol |
News from qatests: Failed Installing OpenSRF pre-requisites <http://testing.evergreen-ils.org/~live//archive/2021-02/2021-02-25_04:00:18/test.7.html> |
| 04:56 |
|
book` joined #evergreen |
| 04:57 |
|
akilsdonk_ joined #evergreen |
| 06:21 |
|
khuckins joined #evergreen |
| 10:31 |
Dyrcona |
Based on my "research," your current script is complete for the stock indexes. I haven't added any custom GIST indexes. |
| 10:34 |
Dyrcona |
JBoyer: I'm 99% sure that neither supports multicolumn indexes, and GIN only works on columns of type tsvector. |
| 10:34 |
Dyrcona |
https://www.postgresql.org/docs/10/textsearch-indexes.html |
| 10:35 |
Dyrcona |
JBoyer: I'll assign the bug to myself and test your upgrade script on my training database over the weekend. |
| 10:35 |
JBoyer |
That's convenient then. If some enterprising committer wants to strip out the last AND clause I wouldn't argue. I also think it's really unlikely that anyone would have their own but you never know. |
| 10:35 |
JBoyer |
Dyrcona++ |
| 10:41 |
Dyrcona |
I agree with you that if someone added their own, then they should take responsibility for updating them. |
| 10:49 |
|
collum_ joined #evergreen |
| 11:06 |
|
khuckins joined #evergreen |
| 11:17 |
|
collum joined #evergreen |
| 11:30 |
miker |
Dyrcona: just had a thought and wanted to surface it outside my head, and since you've been testing modern PG versions... one thing to consider, especially WRT query speed differences and particular queries, is the new [NOT] MATERIALIZED clause for WITHs (CTEs) in PG 12+. We've started using WITH a good bit in hand-tooled queries and the behavioral change to fold CTEs when they appear to be side-effect free and are only referenced once could |
| 11:30 |
miker |
potentially hurt us. so, if you run into queries that are slower /and/ use WITH, I'd personally be very interested in those examples |
| 11:50 |
|
jihpringle joined #evergreen |
| 12:03 |
|
sandbergja___ joined #evergreen |
| 12:04 |
Dyrcona |
miker: OK. I'll keep an eye out for WITH queries. The ones that I've noticed so far have negative logic. |
| 12:05 |
Dyrcona |
JBoyer: There's an extra semi-colon in your update script. It's no biggie. I'll fix it. Do you mind if I write a release note? |
| 12:05 |
|
gmcharlt joined #evergreen |
| 12:07 |
Dyrcona |
miker: I have done almost 0 testing on Pg 11 or Pg 13, fwiw. I've mostly looked at Pg 12. Pg 10 seems to perform about the same as Pg 9.6. |
| 12:41 |
|
sandbergja_ joined #evergreen |
| 12:42 |
JBoyer |
Dyrcona, +1. I guess I hadn't considered a relnote since no features or anything are actually changing; though it is good to know that things should be faster. |
| 12:42 |
JBoyer |
And which semicolon since I'm curious? |
| 16:58 |
|
sandbergja_ joined #evergreen |
| 17:19 |
|
mmorgan left #evergreen |
| 17:57 |
|
sandbergja_ joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 20:48 |
|
sandbergja_ joined #evergreen |
| 21:29 |
pinesol |
[evergreen|Bill Erickson] LP1913458 Bucket Add/Delete Item Operations Batched - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1d0e181> |
| 21:45 |
|
sandbergja_ joined #evergreen |
| 22:30 |
|
malexander joined #evergreen |
| 23:51 |
|
sandbergja_ joined #evergreen |
| 00:07 |
|
sandbergja joined #evergreen |
| 00:48 |
|
sandbergja joined #evergreen |
| 04:12 |
|
khuckins joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:16 |
|
rjackson_isl_hom joined #evergreen |
| 08:15 |
|
mantis1 joined #evergreen |
| 08:15 |
|
collum joined #evergreen |
| 13:38 |
pinesol |
Launchpad bug 1871211 in Evergreen "wishlist: Single Sign on for Evergreen OPAC" [Wishlist,New] https://launchpad.net/bugs/1871211 |
| 13:40 |
mmorgan |
sandbergja: That's not my area of expertise, so I don't feel comfortable weighing in. Sorry! |
| 13:57 |
|
Cocopuff2018 joined #evergreen |
| 14:31 |
jeffdavis |
sandbergja: I'm not on the release team but I would support that. I haven't been able to test properly for the same reason as you (difficulty setting up a Shibboleth test instance) but I trust the signoff and your judgement. :) |
| 14:57 |
|
sandbergja_ joined #evergreen |
| 15:57 |
|
collum_ joined #evergreen |
| 16:07 |
|
dbwells joined #evergreen |
| 16:51 |
|
mantis1 left #evergreen |
| 16:57 |
|
jihpringle joined #evergreen |
| 17:10 |
|
mmorgan left #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:14 |
|
sandbergja_ joined #evergreen |
| 18:17 |
|
dbwells joined #evergreen |
| 19:45 |
|
sandbergja_ joined #evergreen |
| 04:51 |
|
khuckins joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:20 |
|
khuckins joined #evergreen |
| 07:21 |
|
rjackson_isl_hom joined #evergreen |
| 07:47 |
|
collum joined #evergreen |
| 08:30 |
|
rfrasur joined #evergreen |
| 08:37 |
|
mmorgan joined #evergreen |
| 08:39 |
|
Dyrcona joined #evergreen |
| 08:46 |
Dyrcona |
I'm trying to decide if I should do my next test on Pg 9.6 or Pg 12. I also wonder if I should log all queries or just those over a certain threshold, like 250ms or so. |
| 08:48 |
Dyrcona |
Looks like I have plenty of free space to log all queries for a while. |
| 08:59 |
csharp |
looks like my troubles from yesterday may have been a super-long-running emergency closing (15 hours) |
| 08:59 |
csharp |
also did some PG vacuuming last night |
| 10:56 |
Dyrcona |
Looks to me like the query is running over a second only to have the results ignored. |
| 11:00 |
Dyrcona |
OK. That's IDL stuff. Moving along.... |
| 11:08 |
Dyrcona |
Hmm.. Looks like my hold targeter ran faster than yesterday, but it is still too long. |
| 11:14 |
Dyrcona |
I'll test my changes on Pg 9.6, and then tomorrow run the old code and log long running queries. The old code seemed faster yesterday. |
| 11:27 |
Dyrcona |
So, my code is faster on Pg 9.6 than it is on Pg 12. This is an area that we'll have to look at. |
| 11:29 |
Dyrcona |
The 9.6 db has default optimizations, and it was updated yesterday morning, so it has not had the hold targeter run since Saturday. |
| 11:30 |
Dyrcona |
miker: Should I open a Lp bug about future Postgres versions? |
| 11:37 |
Dyrcona |
I've also discovered that my maintenance_work_mem setting is way out of whack on my development server for Pg 12. I'm going to remove my optimizations from the config for now. |
| 11:38 |
Dyrcona |
I had GB instead of MB. :) |
| 11:38 |
csharp |
oof - I've done that |
| 11:41 |
Dyrcona |
I should reload Pg 11 and Pg 13 and test this against those dbs, too. |
| 11:53 |
|
jihpringle joined #evergreen |
| 12:30 |
|
mantis1 left #evergreen |
| 12:30 |
|
khuckins joined #evergreen |
| 17:49 |
|
akilsdonk joined #evergreen |
| 17:51 |
|
WarpedMJ joined #evergreen |
| 17:59 |
|
PityDaFool joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:01 |
|
ome joined #evergreen |
| 18:08 |
|
ljharbjj joined #evergreen |
| 18:10 |
pinesol |
[evergreen|Terran McCanna] LP1916085 Bootstrap OPAC - Pagination on copy table - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c2e0686> |
| 19:49 |
|
nfBurton28 joined #evergreen |
| 21:19 |
|
yar joined #evergreen |
| 11:10 |
Dyrcona |
Trying to create a VM from the Ubuntu 18.04.5 live server image is not going very well. |
| 11:18 |
|
malexander joined #evergreen |
| 11:28 |
|
malexander joined #evergreen |
| 11:31 |
terranm |
phasefx: I'm configuring the geo work on my test server with my Google API key - which map API(s) do I need to enable? I have Maps JavaScript API and Geocoding API enabled already, do I need something else? |
| 11:34 |
terranm |
Distance Matrix API maybe? |
| 11:37 |
terranm |
Geolocation API? |
| 11:50 |
JBoyer |
terranm, I would expect that Geocoding is the primary one you need, is it giving you errors or just not giving you results? |
| 11:50 |
terranm |
Just no results |
| 11:54 |
terranm |
The browser console just says "Net: request open-ils.actor.geo.retrieve_coordinates" and then doesn't do anything |
| 13:04 |
csharp |
maybe needs a RewriteCond to handle that |
| 13:06 |
csharp |
yep, this seems to confirm the issue: https://stackoverflow.com/questions/10307406/perl-xml-rpc-over-https |
| 13:21 |
Dyrcona |
There's a nagging voice in my head saying there's a better way to fix that, but I'd really have to look at the code again, and I'm doing something else at the moment. |
| 13:22 |
* Dyrcona |
tests the Ubuntu 20.04 branches. |
| 13:22 |
csharp |
well turns out the "better way" was for the client to use "https://" instead :-) |
| 13:22 |
csharp |
that Just Worked™ |
| 13:25 |
Dyrcona |
Yeah, I was looking at the module and about to say that it shouldn't affect us. |
| 13:37 |
berick |
related, bug 1882967 |
| 13:38 |
pinesol |
Launchpad bug 1882967 in Evergreen "SSL / TLS changes" [Wishlist,New] https://launchpad.net/bugs/1882967 |
| 13:39 |
Dyrcona |
Yeahp. |
| 13:41 |
Dyrcona |
I'm also going to test websocketd 0.4.1. I've been using 0.3.1 in production for the past 2 years, and it has been rock solid, even more so than 0.3.0. We should consider updating the README. |
| 13:53 |
|
alynn26 joined #evergreen |
| 13:53 |
berick |
Dyrcona++ # websocketd testing |
| 14:00 |
|
abowling2 joined #evergreen |
| 14:03 |
Dyrcona |
csharp: I'm going to test the nginx redirect to https on this vm. |
| 14:08 |
Dyrcona |
I'm gonna update the TLS settings, too. |
| 14:08 |
Dyrcona |
I'll open a Lp bug for the TLS settings. |
| 14:12 |
Dyrcona |
And, these changes stop XUL from being able to connect. :) |
| 04:13 |
|
khuckins joined #evergreen |
| 04:29 |
|
khuckins joined #evergreen |
| 05:20 |
|
rjackson_isl_hom joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:24 |
|
Dyrcona joined #evergreen |
| 08:05 |
|
collum joined #evergreen |
| 08:17 |
|
mantis1 joined #evergreen |
| 10:08 |
Dyrcona |
OK. We're all 18.04 in production here, and I'd like to jump to 20.04 soon. *cough* ahem. bug 1875544 *cough* |
| 10:08 |
pinesol |
Launchpad bug 1875544 in OpenSRF "Ubuntu 20.04 (Focal Fossa) support" [Undecided,Confirmed] https://launchpad.net/bugs/1875544 |
| 10:08 |
Dyrcona |
Also, I feel like I should have sent that email to the development list earlier this week. |
| 10:09 |
Dyrcona |
Ackshually, I should replace my egdev vm at CWMARS with 20.04. I used it originally to test 18.04. |
| 10:11 |
|
terranm joined #evergreen |
| 10:17 |
csharp |
[en-US] open-ils.actor open-ils.actor.ou_setting.ancestor_default.batch 402, ["opac.holds.org_unit_not_pickup_lib","credit.payments.allow"] |
| 10:18 |
csharp |
that's a call that's spamming us - not sure exactly how to track it up to which UI is doing that |
| 14:46 |
Dyrcona |
Seems to have been chugging right along processing fines and bills, then BOOM! |
| 14:50 |
Dyrcona |
@band add Angular Grids |
| 14:50 |
pinesol |
Dyrcona: Band 'Angular Grids' added to list |
| 15:25 |
terranm |
JBoyer or gmcharlt - I'm trying to test the lassos functionality on festivus, but admin / demo123 isn't allowing me to log in |
| 15:29 |
terranm |
Not able to log into the staff client with any concerto logins either |
| 15:37 |
terranm |
(but I *am* able to log into the opac) |
| 15:46 |
|
mantis1 left #evergreen |
| 16:05 |
JBoyer |
terranm, I'm able to login to the opac and staff client as admin, are you still having trouble? |
| 16:08 |
terranm |
JBoyer: Bah, yes - I had to clear my cookies for that domain. Bad workstation was stuck, I guess? We've seen that with some of our libraries in production as well |
| 16:09 |
JBoyer |
Oof, hope that's not common for the libraries. Glad you're in again. |
| 16:12 |
terranm |
Thx, I should have thought of that first. We saw it a number of times coming back from our upgrade last month. Hatch broke for most people that were using it and had to be reinstalled, too. |
| 16:32 |
|
Dyrcona joined #evergreen |
| 16:41 |
Dyrcona |
Here's something that I like to do when testing with Chrome. I'll open the developer tools to the Application "tab." Below the circular chart showing data usage, there's a button called "Clear Site Data." Comes in real handy for clearing cache, settings, etc. |
| 16:45 |
|
dbwells joined #evergreen |
| 16:45 |
terranm |
Oh, nice. I have the setting page bookmarked because I have to clear data so often, but that's easier |
| 16:47 |
|
dbwells joined #evergreen |
| 17:08 |
|
dbwells joined #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:26 |
|
jihpringle joined #evergreen |
| 22:16 |
|
sandbergja joined #evergreen |
| 22:23 |
|
sandbergja joined #evergreen |
| 01:20 |
|
mrisher_ joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:56 |
|
collum joined #evergreen |
| 08:00 |
|
rjackson_isl_hom joined #evergreen |
| 08:06 |
|
mantis1 joined #evergreen |
| 10:56 |
Dyrcona |
Yes, it is that trigger. We're trying to "move" copies from a branch locations to system locations with the same names. |
| 10:57 |
miker |
yep, gets me every time, too :) |
| 11:00 |
Dyrcona |
Do I remember correctly, or am I making this up, that you can disable a trigger inside of a transaction and that has no effect outside of the transaction? |
| 11:02 |
terranm |
mmorgan: which server were you testing when you tested this one? https://bugs.launchpad.net/evergreen/+bug/564026 |
| 11:02 |
pinesol |
Launchpad bug 564026 in Evergreen "Wishlist: add error msg when searching by ID" [Low,Confirmed] |
| 11:03 |
|
Cocopuff2018 joined #evergreen |
| 11:04 |
Dyrcona |
I think I'm making that up. |
| 11:06 |
terranm |
mmorgan: yes, it's working fine on current master (see terran-testbox) so maybe it was a more recent change |
| 11:07 |
terranm |
checking our 3.6.1 production server... |
| 11:07 |
terranm |
Hmm, no, I'm getting a nice "Record not found" error message on our production server as well |
| 11:08 |
mmorgan |
terranm: Checking my master test server, I see Record not found. |
| 11:09 |
mmorgan |
Hmm. So this was fixed somewhere along the line? Maybe some local customization is breaking it. |
| 11:10 |
terranm |
That's what I'm guessing - I'm going to go ahead and close that lp bug unless you object |
| 11:10 |
mmorgan |
No objection here! |
| 11:10 |
terranm |
thx! |
| 12:11 |
csharp |
not sure if someone with rootly powers on git could amend my commit to add a signoff or if that's worth doing at all |
| 12:12 |
csharp |
also, since I've been using gitlab and github more often for other things, I want to move EG to one of those (self-hosted gitlab or otherwise), but that is not this day |
| 12:15 |
|
jihpringle joined #evergreen |
| 12:25 |
JBoyer |
csharp, I'm going to assume that it's ok that a signoff was missed so long as it was tested. Wouldn't be the first time, won't be the last. :) |
| 12:26 |
JBoyer |
csharp++ Dyrcona++ # yay code cleanup |
| 12:34 |
Dyrcona |
charp++ |
| 12:34 |
mmorgan |
@karma charp |
| 13:04 |
mmorgan |
typos-- :) |
| 13:05 |
berick |
Bmagic: it can also pull the PO ID from the lineitems in the invoice message |
| 13:06 |
Bmagic |
berick: yes! I was just reading that code.... looking |
| 13:17 |
terranm |
Bmagic: I've lost track of what time you last rebuilt your test server - do you recall if Bill's most recent commit on this one is on there? https://bugs.launchpad.net/evergreen/+bug/1888723 |
| 13:17 |
pinesol |
Launchpad bug 1888723 in Evergreen "Holdings and Item Attributes Editors (VolCopy) Angular Port" [Wishlist,New] |
| 13:20 |
Bmagic |
terranm, his branch was merged at this time Feb 9 16:06:35 |
| 13:20 |
terranm |
Bmagic++ |
| 13:21 |
Bmagic |
I took a look at the source, and the last commit onto that branch DID NOT make it into the test machine |
| 13:22 |
Bmagic |
neither did this one https://git.evergreen-ils.org/?p=working/Evergreen.git;a=blobdiff;f=Open-ILS/src/eg2/src/app/staff/cat/volcopy/volcopy.service.ts;h=46d9b39dc7aa1bc8f40b96f90dffd7ac10958de9;hp=1396a8d346c8692e6f5103bc4aaee8665246f714;hb=9413ae89f1f71a3ea720532289849baf0c566a41;hpb=99ef208257f7578449c4ae71410e9dc43c71f217 |
| 13:23 |
Bmagic |
looking back through the branch, there are quite a few commits that are not on the test server |
| 13:26 |
Bmagic |
I used this command: git merge working/user/berick/lp1888723-angular-volcopy-v8 and it was successful. Now that you've got me looking at the git log, I' |
| 13:27 |
Bmagic |
I'm not seeing his commit messages. Maybe I don't understand what git merge does to my branch. Should it make the same number of commits as his branch? |
| 13:27 |
Dyrcona |
I was rereading bug 608308 just now, and it made me think: Has anyone started a branch to remove XUL? |
| 13:51 |
|
jvwoolf1 joined #evergreen |
| 14:00 |
Dyrcona |
Bmagic: Merge reorders commits by date. I'd recommend the following: |
| 14:01 |
Dyrcona |
git checkout -b <branchname> working/user/berick/lp1888723-angular-volcopy-v8 ; git rebase origin/master |
| 14:02 |
Dyrcona |
Where <branchname> is what ever you want to call your testing branch. |
| 14:03 |
Dyrcona |
If the rebase has conflicts, don't bother trying to resolve them, just comment on the bug that it needs a rebase on master, and move on to another bug. |
| 14:03 |
Dyrcona |
You can clean up a failed rebase with git rebase --abort |
| 14:11 |
|
terranm joined #evergreen |
| 14:21 |
Bmagic |
RFF+ON:199189'RFF+LI:199189EasyHoliday/7370'ALC+A++++DI'PCD+3:0'LIN+3++9780310769064 |
| 14:22 |
Bmagic |
It appears that the edi_li->id is getting assigned "7370" |
| 14:22 |
Bmagic |
which matches acq.lineitem.id from 2013 |
| 14:22 |
berick |
Bmagic: Open-ILS/src/support-scripts/test-scripts/edi_reader.pl can be used to see what EDIReader produces, BTW |
| 14:23 |
Bmagic |
ah! right! I'll double check the theory |
| 14:25 |
Bmagic |
berick++ # confirmed: 'id' => '7370', |
| 14:26 |
Bmagic |
so the big question is: do we have a bug? |
| 15:32 |
|
mantis1 left #evergreen |
| 15:33 |
berick |
Dyrcona++ |
| 15:41 |
JBoyer |
berick, not urgent, but I figure you have a good chance of knowing a simple for bug 1915326 |
| 15:41 |
pinesol |
Launchpad bug 1915326 in Evergreen "AngularJS egOrg tests fail" [Low,New] https://launchpad.net/bugs/1915326 |
| 15:42 |
JBoyer |
Basically, referencing lf (for lf.isOffline) breaks the tests since lf isn't defined at that point. |
| 15:45 |
* berick |
calls 1245 |
| 15:50 |
JBoyer |
Though if there's no better fix than if ( (lf && lf.isOffline) ... I can throw that branch together |
| 16:00 |
pinesol |
[evergreen|Galen Charlton] LP#1474029: teach Evergreen how to prevent expired staff from logging in - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=18f5404> |
| 16:16 |
|
dbwells joined #evergreen |
| 16:22 |
|
terranm joined #evergreen |
| 16:23 |
|
jihpringle joined #evergreen |
| 16:24 |
Dyrcona |
I have successfully tested the backport of sandbergja's Angular fix on bug 1913219 to rel_3_5. Should I just push it or does anyone else want to have a look on 3.5? |
| 16:24 |
pinesol |
Launchpad bug 1913219 in Evergreen 3.5 "Edit from OPAC View doesnt' close on Save & Exit" [Medium,Confirmed] https://launchpad.net/bugs/1913219 - Assigned to Jason Stephenson (jstephenson) |
| 16:29 |
csharp |
Dyrcona: got for it |
| 16:29 |
csharp |
er... *go* for it |
| 17:25 |
|
malexander joined #evergreen |
| 17:56 |
|
dbwells joined #evergreen |
| 17:58 |
|
dbwells joined #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:11 |
|
dbwells joined #evergreen |
| 18:16 |
|
sandbergja_ joined #evergreen |
| 20:09 |
|
sandbergja_ joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:11 |
|
kip joined #evergreen |
| 07:00 |
|
Dyrcona joined #evergreen |
| 07:10 |
|
kip joined #evergreen |
| 11:57 |
pinesol |
[evergreen|Terran McCanna] LP1908724 Staff Catalog Sort by PubDate Wording - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=893a5f9> |
| 11:59 |
pinesol |
[evergreen|Bill Erickson] LP1907286 Staff catalog sets last retrieved record - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=449df59> |
| 12:12 |
|
jihpringle joined #evergreen |
| 12:28 |
Dyrcona |
Speaking of release notes, the branch on bug 1861319 has release notes AND tests! |
| 12:28 |
pinesol |
Launchpad bug 1861319 in Evergreen "Allow Item Renewal on Expired Patron Record" [Wishlist,Confirmed] https://launchpad.net/bugs/1861319 |
| 12:28 |
|
sandbergja joined #evergreen |
| 12:56 |
|
mantis1 joined #evergreen |
| 13:01 |
pinesol |
[evergreen|Mike Risher] lp1847519 Port of Circulation Limit Set UI - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=db7271e> |
| 13:01 |
|
mantis1 left #evergreen |
| 13:05 |
|
mantis1 joined #evergreen |
| 13:09 |
Bmagic |
JBoyer: our test server does* have the RemoteIP settings: RemoteIPInternalProxy 127.0.0.1/24 RemoteIPInternalProxy ::1 RemoteIPHeader X-Real-IP |
| 13:10 |
Bmagic |
I'm not sure based on the comments above whether those are or are not suppose to be uncommented? Ours are uncommented |
| 13:10 |
JBoyer |
Is nginx (or whatever) running on the same VM? |
| 13:10 |
Bmagic |
yes |
| 16:39 |
mrisher |
jihpringle: I put in a fix on that bug you reported yesterday. Thanks for spotting it! 1857911 |
| 16:40 |
mrisher |
(bug #1857911) |
| 16:40 |
pinesol |
Launchpad bug 1857911 in Evergreen "Angular: Local Admin Statistical Categories Port" [Wishlist,New] https://launchpad.net/bugs/1857911 |
| 16:42 |
jihpringle |
mrisher: awesome, I'll keep an eye out and give it another test if it gets updated on one of the test servers this week |
| 16:52 |
terranm |
Err... so if I have a carousel that is manually created from a bucket, then I change the contents of that bucket, how does the carousel update? (Mine is still showing the initial bucket records and it won't let me manually refresh it) |
| 16:55 |
terranm |
Oh never mind, I was looking at the wrong bucket. X) |
| 17:15 |
|
mmorgan left #evergreen |
| 17:35 |
jihpringle |
thanks Bmagic++ |
| 17:36 |
Bmagic |
no prob! |
| 17:36 |
Bmagic |
classic unplug it and plug it back in |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:04 |
|
jihpringle joined #evergreen |
| 18:51 |
JBoyer |
Any day you have to enable trace logging in apache is probably not a good day. Incidentally, I've learned you generally don't have to go any higher than trace4 if you're diagnosing named virtualhost problems. |
| 18:52 |
JBoyer |
ALSO, if you include :443 or :80 in a servername / serveralias you're committing a crime. |
| 00:47 |
|
sandbergja joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:17 |
|
rjackson_isl_hom joined #evergreen |
| 07:19 |
|
rjackson_ils joined #evergreen |
| 07:35 |
|
collum joined #evergreen |
| 08:31 |
|
troy__ joined #evergreen |
| 08:31 |
|
rfrasur joined #evergreen |
| 09:14 |
|
terranm joined #evergreen |
| 09:22 |
terranm |
Good morning everyone - Feedback Fest community test servers are up and running here! https://docs.google.com/spreadsheets/d/1XeRK2oTIIu5pu7iy2ceWbE1ZRBgz9X2W1YC_E6QNexg/edit?usp=sharing |
| 09:34 |
|
dbwells joined #evergreen |
| 09:43 |
|
JMooreWyomissing joined #evergreen |
| 09:48 |
JMooreWyomissing |
Has anyone heard about registration for 2021 Evergreen International Conference? I know it's entirely online this year. Website has a post from late December but no updates since then... |
| 15:34 |
|
mantis1 left #evergreen |
| 15:43 |
|
sandbergja joined #evergreen |
| 16:08 |
|
sandbergja joined #evergreen |
| 16:16 |
jihpringle |
terranm Bmagic: I've run into an issue on Blake's test server - it looks like one of the fixes has broken Circulation Policies but I don't know which one (maybe https://bugs.launchpad.net/evergreen/+bug/1847519 since it's related to circ policies) |
| 16:17 |
pinesol |
Launchpad bug 1847519 in Evergreen "Angular: Local Admin Circulation Limit Set Port" [Wishlist,Confirmed] |
| 16:17 |
jihpringle |
I have other fixes on the server that I'd like to sign off on but I don't want to sign off if they break Circulation Policies |
| 16:17 |
jihpringle |
no matter what I do I can't save a new policy, but I can create a new one on Tiffany's test server |
| 16:26 |
|
dbwells joined #evergreen |
| 16:30 |
|
dbwells joined #evergreen |
| 16:32 |
terranm |
jihpringle: Thanks, I'll email Blake since it looks like he's not logged into IRC right now |
| 16:33 |
jihpringle |
thanks terranm: I'm now three for three with fixes not working quite right on that server |
| 16:33 |
terranm |
:) |
| 16:36 |
csharp |
jihpringle: I have that patch installed on current master on my test server: csharp-master.gapines.org/eg/staff admin/demo123 |
| 16:36 |
csharp |
it's isolated, so you should be able to just test it |
| 16:36 |
jihpringle |
thanks, I'll give it a try :) |
| 16:38 |
csharp |
I know it's more efficient to bundle the test patches on each server, but sometimes testing one at a time is necessary for due diligence |
| 16:40 |
|
sandbergja joined #evergreen |
| 16:40 |
jihpringle |
thanks csharp I can't create new circ policies on your server either so looks like it is that patch causing issues |
| 16:48 |
|
jihpringle joined #evergreen |
| 17:12 |
|
terranm joined #evergreen |
| 17:16 |
csharp |
jihpringle: confirmed on master - I can't create a new circ policy as admin |
| 17:16 |
jihpringle |
glad it's not just me :) |
| 17:16 |
csharp |
so, um, I guess it's not related to mrisher's stuff but we need to be able to add those to test mrisher's stuff :-/ |
| 17:17 |
jihpringle |
weirdly it worked on Tiffany's server though |
| 17:17 |
csharp |
that's interesting |
| 17:19 |
csharp |
slightly different master, looks like - that points to a recent change causing the issue |
| 17:29 |
csharp |
JBoyer: I can confirm that they are correct on tiffany-master and *not* on csharp-master |
| 17:29 |
JBoyer |
That's a good sign! |
| 17:29 |
|
dbwells joined #evergreen |
| 17:30 |
csharp |
rebuilding master on my server now, then we'll be able to test mrisher's fix :-) |
| 17:30 |
JBoyer |
And also a big question mark, because I've only seen that happen in dojo interfaces and Angular ones seemed to be immune. Maybe that's a cstore / pcrud difference. |
| 17:30 |
csharp |
dojo-- |
| 17:30 |
csharp |
dojo--\ |
| 17:35 |
jihpringle |
JBoyer++ csharp++ |
| 17:36 |
csharp |
ok - reapplying the patch on my server - we'll see what happens :-) |
| 17:39 |
dluch |
JMooreWyomissing: The conference committee will be sending out more information on Wednesday. Stay tuned! |
| 17:43 |
csharp |
ok, jihpringle, you're up if you want to test again (make sure to log out and register a new workstation - I take the nuclear approach when I rebuild my server :-) ) |
| 17:43 |
jihpringle |
will do, thanks csharp |
| 17:50 |
jihpringle |
csharp everything looks good! I'll sign off on the patch |
| 17:50 |
jihpringle |
thanks! |
| 17:57 |
gmcharlt |
I can see that as valid - e.g., a location that has no collection but does have a hold pickup service - but I wanted to confirm |
| 17:58 |
pastebot |
"gmcharlt" at 168.25.130.30 pasted "berick: please go ahead and repatch; here is the additional change needed" (12 lines) at http://paste.evergreen-ils.org/10100 |
| 17:59 |
berick |
gmcharlt: thanks, will do. |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:05 |
pinesol |
[evergreen|Garry Collum] LP1908113: link carousel titles in Bootstrap OPAC - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=343a720> |
| 18:06 |
pastebot |
"berick" at 168.25.130.30 pasted "hold org select" (8 lines) at http://paste.evergreen-ils.org/10101 |
| 18:06 |
berick |
gmcharlt: hm, looking at the tpac code, i think it's doing the opposite of what you said, no? |
| 18:06 |
berick |
can_have_vols_only=1 but no can_have_users_only flag |
| 05:24 |
|
khuckins joined #evergreen |
| 05:59 |
|
khuckins joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:00 |
|
khuckins_ joined #evergreen |
| 06:02 |
|
khuckin__ joined #evergreen |
| 07:25 |
|
rjackson_isl_hom joined #evergreen |
| 10:46 |
Dyrcona |
Hmm. Schedule something for 11:30 am or just do it myself? |
| 10:46 |
Dyrcona |
@decide at or manual |
| 10:46 |
pinesol |
Dyrcona: That's a tough one... |
| 10:55 |
Dyrcona |
Bleh.. Tryina test a rsync command and looks like it ignored the -n option. |
| 10:56 |
Dyrcona |
So, a couple of files got copied early. Hope that didn't break anything. If it did, guess I'll hear about it. |
| 10:57 |
Dyrcona |
Things are working for me, so guess it's no big deal |
| 11:03 |
Dyrcona |
berick: If I'm using rsync to update /openils/var/web/eg2/en-US/ should I use --delete to remove older versions of some of the files? |
| 13:55 |
Dyrcona |
:) |
| 13:55 |
JBoyer |
berick++ |
| 13:55 |
JBoyer |
Dyrcona++ |
| 13:56 |
Dyrcona |
JBoyer++ # For testing us. :) |
| 13:56 |
stephengwills |
that pesky SIX key! |
| 14:06 |
|
sandbergja_ joined #evergreen |
| 14:23 |
mantis1 |
Question about the autorenewal feature. Is there a way to block autorenewals from happening if there is a hold on said item? |
| 14:24 |
mantis1 |
I tested it with both a copy and bib level hold for two separate items, and autorenewals went through. |
| 14:41 |
jeff |
I don't know that there's an autorenew-specific block, but there's an org unit setting for blocking renewals when there's a hold, and there's also the option of defining a minimum hold:copy ratio as part of your circ policy. In theory the latter gives you more nuanced control, but I can't confirm that because we're not currently using it. |
| 14:47 |
|
alynn26 joined #evergreen |
| 14:52 |
|
terranm joined #evergreen |
| 15:19 |
JBoyer |
mrisher++ |
| 15:19 |
mrisher |
I'll miss you too!@ |
| 15:19 |
JBoyer |
Feedback fest is a good time. |
| 15:20 |
mrisher |
these are the 3: |
| 15:20 |
mrisher |
Needs discussion https://bugs.launchpad.net/evergreen/+bug/1848579 |
| 15:20 |
mrisher |
Needs testing https://bugs.launchpad.net/evergreen/+bug/1844169 , https://bugs.launchpad.net/evergreen/+bug/1847519 |
| 15:20 |
pinesol |
Launchpad bug 1848579 in Evergreen "Angular grids: interval columns are not filterable" [Medium,Confirmed] |
| 15:20 |
pinesol |
Launchpad bug 1844169 in Evergreen "Angular: Local Admin Search Filter Groups Port" [Wishlist,Confirmed] |
| 15:20 |
pinesol |
Launchpad bug 1847519 in Evergreen "Angular: Local Admin Circulation Limit Set Port" [Wishlist,Confirmed] |
| 15:20 |
sandbergja |
mrisher++ |
| 15:21 |
JBoyer |
In fact... I would suggest that anyone that can put together a test server (or 2) try to make sure that some of mmorgan's interesting / important bugs *and* some of sandbergja's old bugs are included, and mrisher's 3 because more Angular == more better. |
| 15:22 |
csharp |
Oldsquash week? |
| 15:22 |
JBoyer |
Not on every test server, of course, but I imagine there will be a handy worksheet like last time and we should try to make sure those are running *somewhere* |
| 15:22 |
dluch |
lol |
| 15:22 |
mmorgan |
Just a clarification on my list - those all have signoffs, do they need to have a place on a test server? |
| 15:23 |
JBoyer |
They do not! no one bother with mmorgan's list of bugs you don't need to load on a test server! :) |
| 15:23 |
mmorgan |
Just commit them!;-) |
| 15:23 |
JBoyer |
That also counts as feedback fest progress, yes. |
| 15:23 |
JBoyer |
Ok. |
| 15:26 |
mmorgan |
Make sense! I wasn't sure if committers built their own test enviroments for committing purposes. |
| 15:26 |
Dyrcona |
I'll see if I can make time to look at some of the signed off bugs this wek. |
| 15:26 |
|
mantis1 left #evergreen |
| 15:26 |
JBoyer |
I also assume committers do all of their testing directly rather than asking someone else to poke at things. |
| 15:26 |
mmorgan |
Dyrcona++ |
| 15:26 |
Dyrcona |
mmorgan: I think most of us do have our own test systems. |
| 15:26 |
JBoyer |
Moving on, we'll skip OpenSRF updates since there's nothing on the agenda, so up next is |
| 15:27 |
JBoyer |
#topic Evergreen Updates |
| 15:27 |
|
Topic for #evergreen is now Evergreen Updates (Meeting topic: 2020-02-02 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2021-02-02) |
| 15:32 |
JBoyer |
#topic Security/point releases for 3.6.2, 3.5.3 and 3.4.6 on Wednesday, February 17, 2021. |
| 15:32 |
|
Topic for #evergreen is now Security/point releases for 3.6.2, 3.5.3 and 3.4.6 on Wednesday, February 17, 2021. (Meeting topic: 2020-02-02 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2021-02-02) |
| 15:32 |
dluch |
terranm++ |
| 15:32 |
terranm |
Bmagic: Are you willing to host a feedback fest test server next week? |
| 15:32 |
terranm |
We'll have two as well |
| 15:32 |
Bmagic |
sure! |
| 15:32 |
terranm |
Bmagic++ |
| 15:32 |
mmorgan |
Bmagic++ |
| 15:51 |
Dyrcona |
mmorgan++ |
| 15:51 |
Dyrcona |
I |
| 15:51 |
terranm |
Maybe number of new bugs added since previous meeting? |
| 15:52 |
Dyrcona |
When you're testing the branch on a Lp bug, please assign the bug to yourself. |
| 15:52 |
mmorgan |
terranm: Good idea! |
| 15:52 |
terranm |
Likewise, number of signoffs and pullrequests added since previous meeting? |
| 15:52 |
mrisher |
terranm++ |
| 17:02 |
|
mrisher joined #evergreen |
| 17:18 |
|
mmorgan left #evergreen |
| 17:57 |
|
sandbergja_ joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 20:22 |
|
stephengwills left #evergreen |
