| Time |
Nick |
Message |
| 01:50 |
|
mrisher joined #evergreen |
| 02:43 |
|
dbwells joined #evergreen |
| 02:43 |
|
lisacarlucci joined #evergreen |
| 02:43 |
|
abneiman joined #evergreen |
| 02:43 |
|
phasefx joined #evergreen |
| 02:43 |
|
lbarry joined #evergreen |
| 02:43 |
|
jweston joined #evergreen |
| 02:43 |
|
jeffdavis joined #evergreen |
| 03:14 |
|
devted joined #evergreen |
| 04:22 |
|
akilsdonk joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:56 |
|
agoben joined #evergreen |
| 07:26 |
|
rjackson_isl_hom joined #evergreen |
| 07:49 |
|
collum joined #evergreen |
| 07:52 |
oleonard |
rhamby around? |
| 08:32 |
rhamby |
oleonard: yep |
| 08:32 |
oleonard |
Hi! |
| 08:32 |
rhamby |
sorry, brain was on some authorities stuff this am |
| 08:32 |
rhamby |
morning |
| 08:34 |
oleonard |
I had some questions to ask, but now I think it's probably better to say that we should meet. Do you think Jason will be adding to that conversation about the goals for color customization? |
| 08:35 |
rhamby |
yeah, he definitely will |
| 08:35 |
rhamby |
if you want to chat today I can make some time and see what phasefx has |
| 08:35 |
oleonard |
Okay. I'll wait for his info and then will probably suggest we have a live conversation. |
| 08:36 |
* phasefx |
adds to the conversaton, "+1 |
| 08:36 |
rhamby |
oh, by that I meant he will have more to add, what I emailed you was for kick off purposes both our thoughts |
| 08:36 |
rhamby |
I tried to combine them so you didn't get zapped from two directions |
| 08:38 |
oleonard |
When we talk about customizations are we talking about configurations the system administrator is doing on the server or settings found in the staff interface? |
| 08:39 |
rhamby |
for our purposes we're talking sysadmin level, not settings |
| 08:39 |
oleonard |
So "physically" adding a CSS/tt2 file to the installation? |
| 08:40 |
rhamby |
our hope from the stand point of migrations and helping new libraries setting themselves up is to make it simple for sysadmins to modify the css and/or tt2 for this |
| 08:40 |
rhamby |
yep |
| 08:40 |
|
mmorgan joined #evergreen |
| 08:41 |
oleonard |
I'm curious, is there talk of replacing the tt2 version of CSS files with something like SCSS? |
| 08:41 |
rhamby |
my personal hope is via css |
| 08:41 |
rhamby |
not that I'm aware of at this point but I wouldn't be surprised if someone was looking at it |
| 08:42 |
rhamby |
I only know the bare bones of scss but it's interesting |
| 08:42 |
oleonard |
I'm in the process of trying to get a Bootstrap 4 update to the Koha OPAC, and found it very useful to use Bootstrap's SCSS options for customization |
| 08:43 |
rhamby |
I can't speak for the whole evergreen community but if you think it's worth looking at I think it can be on the table |
| 08:44 |
phasefx |
I'd also be in favor of moving away from TT2 variables and toward CSS variables. I think the community would want to keep TT for choosing which branches get served which files, though, a sort of file inheritance |
| 08:45 |
phasefx |
well, that's more properly an Apache thing, not a TT thing |
| 08:45 |
rhamby |
phasefx = jason ethridge |
| 08:45 |
rhamby |
yeah, I think it's fair to say phasefx has more thoughts about implementation while my thoughts to date are more about end goals |
| 08:46 |
rhamby |
rhamby != css guru |
| 08:46 |
oleonard |
phasefx: You're speaking specifically about TT inheritance for CSS customization? |
| 08:48 |
phasefx |
oleonard: right now we're defining TT variables to hold color values, and interpolating those into CSS files; I'd be in favor of moving away from that. The inheritance thing, I don't think that's really an issue for us. That's like: system.library.org/eg gets served /openils/var/templates/main.tt2, and branch.library.org/eg gets served /openils/var/templates-branch/main.tt2 if it exists, and falls back to /openils/var/templates/main.tt2 |
| 08:48 |
|
alynn26 joined #evergreen |
| 08:49 |
oleonard |
Okay, that makes sense. |
| 08:50 |
oleonard |
Yeah, the use of files like colors.tt2 is definitely the kind of thing that SCSS can replace. But it's probably a bigger discussion. |
| 08:50 |
phasefx |
locally, we're also using TT to make certain things more data driven, like custom navigation links, but that' s not a stock EG thing. The community may or may not like something like that |
| 08:51 |
oleonard |
I'm very used to having a long historical memory of why things are the way they are in Koha, so looking at EG is interesting :) |
| 08:52 |
rhamby |
yeah, and we're looking at a fairly close timeline for 3.6 so TT replacement may not be viable (though I find it interesting) |
| 08:52 |
phasefx |
we've been through a few OPAC's :) |
| 08:52 |
rhamby |
it is safe to say change is something we've been fine with :) |
| 08:52 |
phasefx |
I think TT is not going away, but we can use it or not |
| 08:53 |
phasefx |
I think the OPAC also uses TT for determining whether certain functionality is enabled or not |
| 08:54 |
oleonard |
Oh sure, I'm definitely not suggesting TT go away! Just talking about how the CSS is built. |
| 08:54 |
phasefx |
+1 |
| 08:54 |
|
dguarrac joined #evergreen |
| 08:56 |
oleonard |
Oh speaking of questions about why things are they way they are... Do you know why semiauto.css is a separate file? |
| 08:57 |
phasefx |
I do not |
| 08:58 |
|
mantis1 joined #evergreen |
| 08:58 |
phasefx |
I'm a little surprised if that even gets used, seems like old opac path |
| 08:59 |
JBoyer |
For when berick is around: I'm looking at adding the latest updates to LP 1888723 to our test server and see you've uploaded a new branch. Is it identical to the previous branch + those 2 new commits? I don't want to half-apply anything. :) |
| 08:59 |
pinesol |
Launchpad bug 1888723 in Evergreen "Holdings and Item Attributes Editors (VolCopy) Angular Port" [Wishlist,New] https://launchpad.net/bugs/1888723 |
| 08:59 |
rhamby |
I know when the Left to right and Right to Left css work was being done it was dicussed about merging semiauto in follow up work but obviosuly it didn't happen |
| 08:59 |
phasefx |
oh, looks like we do pull in old css from the jspac (the version before the tpac we have now) |
| 09:00 |
oleonard |
phasefx it's such a small file I wondered why it wasn't merged with style.css. Just curious. |
| 09:00 |
rhamby |
I think the intent has been to do so it's just legacy and not on anyone's radar as a priority |
| 09:00 |
phasefx |
it looks like bits of it were copied/moved to style.css, according to a comment in the file |
| 09:01 |
phasefx |
my git-fu is weak, and that file has changed location at least once |
| 09:02 |
phasefx |
I think it may be an accident we still reference semiauto.css |
| 09:02 |
phasefx |
https://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6439d5f95c101c43fb78001b2fa62c43f5756d00 |
| 09:02 |
pinesol |
phasefx: [evergreen|Dan Scott] TPAC: Bring used CSS definitions over from semiauto.css - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6439d5f> |
| 10:05 |
|
kenstir joined #evergreen |
| 10:12 |
kenstir |
Hey everyone! I have an issue implementing part holds in the mobile app. My real question is this: how do I determine whether to offer the option "- All Parts -"? The app does everything via OpenSRF. |
| 10:14 |
kenstir |
I know how to call open-ils.search.biblio.record_hold_parts to get the parts, but I can't distinguish between "all items have parts" and "some items have parts". |
| 10:15 |
berick |
JBoyer: yes, applying just the 2 additional commits should work fine. the new branch was rebased as a force of habit, but it shouldn't affect the commits. |
| 10:15 |
kenstir |
I found where the OPAC sets the `part_required` variable, Account::load_place_hold, and it's some complex `$e->json_query()` |
| 10:16 |
* phasefx |
was just about to paste a link to that |
| 10:17 |
phasefx |
IIUC, it's looking at all copies associated with the record. If every copy has a part associated with it, then part_required gets set to true |
| 10:18 |
kenstir |
phasefx: Is there a way for me to execute such a query via OpenSRF? |
| 10:18 |
phasefx |
we probably do not want to be doing that client side |
| 10:18 |
phasefx |
hrmm |
| 10:19 |
phasefx |
IMO, we should create a method specifically for it that you can call via OpenSRF, if one doesn't exist |
| 10:21 |
|
terranm joined #evergreen |
| 10:22 |
phasefx |
or improve open-ils.circ.title_hold.is_possible if need be |
| 10:22 |
phasefx |
kenstir: are you using that one already? ^ |
| 10:23 |
kenstir |
phasefx: No I am not, I just call open-ils.circ.holds.test_and_create.batch |
| 10:24 |
phasefx |
it may be that you can call that one prior to actually placing a hold to help inform the hold placement UI, and still do test_and_create when the hold is actually attempted |
| 10:26 |
phasefx |
are you actually allowing batch holds to be created, or just one at a time? |
| 10:27 |
kenstir |
phasefx: that's a great idea. No just one at a time. I was asked to call test_and_create because the app used to call another API that bypassed the `test` part and allowed holds when it shouldn't have |
| 10:27 |
* phasefx |
nods nods |
| 10:28 |
phasefx |
that's probably something bug-worthy on the Evergreen side if it hasn't already been addressed |
| 10:28 |
kenstir |
it definitely is filed in LP, though I think it isn't fixed yet |
| 10:29 |
phasefx |
incidentally, there is a open-ils.circ.title_hold.is_possible.batch |
| 10:29 |
phasefx |
I just don't know how smart either method is when it comes to part |
| 10:29 |
kenstir |
LP#1017990 |
| 10:30 |
kenstir |
I will try them! Incidentally, what does the "batch" mean in that API? I guess it can operate on more than one record at a time. Though I don't need that here. And test_and_create does not seem to have a non-batch variant. |
| 10:32 |
phasefx |
the .batch just calls a method that wraps the non-batch version in a loop for each record |
| 10:32 |
phasefx |
I'm not sure exactly how you invoke them differently |
| 10:33 |
phasefx |
array of hashed parameters |
| 10:33 |
phasefx |
vs hash |
| 10:36 |
|
mllewellyn joined #evergreen |
| 10:36 |
|
mllewellyn left #evergreen |
| 10:37 |
JBoyer |
berick++ |
| 10:42 |
|
jvwoolf joined #evergreen |
| 10:47 |
|
devted joined #evergreen |
| 10:57 |
|
jvwoolf1 joined #evergreen |
| 11:08 |
rhamby |
csharp++ all the mailing list updating |
| 11:16 |
csharp |
rhamby: only took nearly a decade :-) |
| 11:16 |
rhamby |
chsarp: well, by red dwarf time lines you're screaming along! |
| 11:17 |
terranm |
ha! |
| 11:35 |
gmcharlt |
csharp++ |
| 11:53 |
csharp |
ok - all the lists are migrated |
| 11:53 |
gmcharlt |
csharp++ |
| 11:53 |
berick |
csharp++ |
| 11:54 |
jeff |
csharp++ |
| 11:54 |
csharp |
autoreplies for -general -dev and -documentation will be active for 2 weeks, then we will scuttle the server |
| 11:55 |
terranm |
csharp++ |
| 11:58 |
csharp |
old list archives will be moved over too - it appears that copying them in with the current list archives is ok (see http://list.evergreen-ils.org/pipermail/evergreen-commits/) |
| 12:07 |
|
jihpringle joined #evergreen |
| 12:13 |
|
khuckins joined #evergreen |
| 12:16 |
|
alynn26_away joined #evergreen |
| 12:37 |
|
collum joined #evergreen |
| 12:46 |
|
collum joined #evergreen |
| 12:48 |
pinesol |
[evergreen|Bill Erickson] LP1865564 Holds grid avoid dupes (AngularJS) - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8bc57fe> |
| 12:48 |
pinesol |
[evergreen|Bill Erickson] LP1865564 Clear holds cache after Request Items - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3044d37> |
| 12:51 |
|
collum joined #evergreen |
| 13:02 |
|
collum joined #evergreen |
| 13:02 |
terranm |
FYI, my test server is refreshed with a new set of patches to test - https://docs.google.com/spreadsheets/d/11MjEa8V8d7NYxVM3s1Ra1IOdbhZPFExoWiWDOAKEXoE/edit?usp=sharing |
| 13:08 |
|
collum joined #evergreen |
| 13:10 |
JBoyer |
csharp++ |
| 13:11 |
JBoyer |
Also, angular-acq-test has the latest versions of lp 1888723 and lp 1813191 |
| 13:11 |
pinesol |
Launchpad bug 1888723 in Evergreen "Holdings and Item Attributes Editors (VolCopy) Angular Port" [Wishlist,New] https://launchpad.net/bugs/1888723 |
| 13:11 |
pinesol |
Launchpad bug 1813191 in Evergreen "Move calculated dewey ranges/blocks to their own reporting view" [Wishlist,New] https://launchpad.net/bugs/1813191 |
| 13:18 |
|
kenstir joined #evergreen |
| 14:33 |
pinesol |
[evergreen|Josh Stompro] LP1819367 - Allow paste of list of barcodes in csv format - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=abc18bf> |
| 14:49 |
|
jvwoolf joined #evergreen |
| 15:07 |
|
khuckins joined #evergreen |
| 15:08 |
|
khuckins joined #evergreen |
| 15:16 |
jeffdavis |
terranm: are you able to confirm that ctx.show_related_resources is set to "true" in config.tt2 on https://terran-master.gapines.org/ ? The branch for bug 1230380 doesn't seem to be working there but it worked in my test environment. |
| 15:16 |
pinesol |
Launchpad bug 1230380 in Evergreen "856 electronic access link doesn't display when 2nd indicator is anything other than 0 or 1" [Wishlist,Confirmed] https://launchpad.net/bugs/1230380 |
| 15:19 |
jihpringle |
sandbergja: hey Jane, I'm taking a look at course reserves (which looks pretty neat so far) but I think something's up with the server |
| 15:19 |
jihpringle |
when signed in as a local admin or the global user I can't search the catalogue (returns zero for all searches) and I can't register new patrons |
| 15:19 |
sandbergja |
jihpringle: let me take a look! |
| 15:20 |
jihpringle |
thanks :) |
| 15:21 |
terranm |
jeffdavis: Sorry, I overlooked that. It should be set to true now. |
| 15:22 |
jeffdavis |
terranm++ |
| 15:22 |
sandbergja |
Oh, yes! one of the services stopped :-( |
| 15:22 |
sandbergja |
Thanks for catching that, jihpringle |
| 15:23 |
sandbergja |
jihpringle: should be back now |
| 15:23 |
sandbergja |
Thanks so much for testing! |
| 15:25 |
jihpringle |
awesome, thanks sandbergja! . |
| 15:28 |
|
dguarrac_ joined #evergreen |
| 15:29 |
|
AFloyd__ joined #evergreen |
| 15:33 |
|
mantis1 left #evergreen |
| 16:29 |
|
dbwells joined #evergreen |
| 16:37 |
|
nfBurton joined #evergreen |
| 16:44 |
|
mrisher joined #evergreen |
| 16:45 |
|
mrisher joined #evergreen |
| 16:57 |
|
dbwells joined #evergreen |
| 17:08 |
nfBurton |
What tag do I give in Launchpad to a bug that's covered by another bug's patch? |
| 17:18 |
berick |
nfBurton: if it makes sense to, you can 'Mark as duplicate'. otherwise a comment in the bug explaining the situation is fine. no tag for this scenario. |
| 17:18 |
sandbergja |
abneiman: berick: re source for authority records |
| 17:18 |
nfBurton |
Oh okay. Wanted to make sure they got caught |
| 17:18 |
sandbergja |
I have been dutifully adding sources to authority record vandelay uploads for *years* |
| 17:19 |
sandbergja |
and only today found out that they had not once been recorded in the db |
| 17:19 |
sandbergja |
I'm not sure whether to give you both karma, or just cry |
| 17:19 |
abneiman |
sandbergja: omg !!!!! :( |
| 17:19 |
sandbergja |
so I'll do both hahaha |
| 17:19 |
sandbergja |
berick++ |
| 17:19 |
sandbergja |
abneiman++ |
| 17:19 |
sandbergja |
(cries) |
| 17:19 |
berick |
oh no! |
| 17:20 |
sandbergja |
oh well! |
| 17:20 |
abneiman |
sandbergja++ # consolation fake internet points for the years of effort? |
| 17:20 |
sandbergja |
to be fair, it was just clicking on a dropdown: not that much effort |
| 17:20 |
sandbergja |
But, uh, I think I will go ahead an open an LP bug |
| 17:21 |
sandbergja |
And clearly, I never actually used those data, since I only now just discovered it |
| 17:22 |
abneiman |
yeah, definitely bugworthy |
| 17:27 |
abneiman |
it's OK, thanks to JBoyer I learned a thing about the way reporter treats identical rows that explained so many annoying report discrepancies I encountered in my years at KCPL. I learned this thing two weeks ago, a mere three years and 10 months after I left KCPL. /facepalm |
| 17:27 |
abneiman |
but, JBoyer++ |
| 17:34 |
sandbergja |
berick: one thing I noticed on bug 1879335 is that the MARC authority editor includes the authority linker, which it should not. Should I file that as a separate bug? |
| 17:34 |
pinesol |
Launchpad bug 1879335 in Evergreen "Manage Authorities Angular Port" [Wishlist,New] https://launchpad.net/bugs/1879335 |
| 17:41 |
|
mmorgan left #evergreen |
| 17:45 |
berick |
sandbergja: oh, huh, I thought I checked that. a comment in the bug is fine, unless you're just about to merge it ;) |
| 17:48 |
sandbergja |
I'll throw a comment in the bug. Thanks! |
| 17:48 |
sandbergja |
Although it is really nice and I do want to merge it soon. :-) |
| 17:53 |
berick |
sandbergja: thanks, I'll look at it soon |
| 18:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:33 |
|
dbwells joined #evergreen |
| 19:24 |
|
sandbergja joined #evergreen |
| 19:50 |
|
nfBurton joined #evergreen |
