| Time |
Nick |
Message |
| 00:03 |
|
dbwells joined #evergreen |
| 01:35 |
|
dbwells joined #evergreen |
| 02:50 |
|
dbwells joined #evergreen |
| 03:59 |
|
dbwells joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Failed Building the AsciiDoc output formats <http://testing.evergreen-ils.org/~live//archive/2020-09/2020-09-08_04:00:13/test.81.html> |
| 06:42 |
|
oleonard joined #evergreen |
| 06:43 |
|
dbwells joined #evergreen |
| 07:00 |
|
agoben joined #evergreen |
| 07:33 |
|
rjackson_isl_hom joined #evergreen |
| 07:39 |
|
collum joined #evergreen |
| 08:36 |
|
csharp joined #evergreen |
| 08:37 |
|
mantis1 joined #evergreen |
| 08:40 |
|
rfrasur joined #evergreen |
| 08:48 |
|
alynn26 joined #evergreen |
| 08:52 |
|
dbwells joined #evergreen |
| 09:06 |
|
Dyrcona joined #evergreen |
| 09:09 |
Bmagic |
gmcharlt++ |
| 09:10 |
Bmagic |
gmcharlt: it seems to me you spent a fair amount of time on this. Mainly consuming and reading how it's all glued together. Thank you! |
| 09:14 |
Bmagic |
gmcharlt: speaking of the eg-antora repo, what's the workflow for me/us? I committed to the working repo several months ago (I couldn't commit to master) - but the alert to you/core committers was where it broke down. |
| 09:44 |
|
jvwoolf1 left #evergreen |
| 09:53 |
|
jvwoolf joined #evergreen |
| 10:01 |
|
rlefaive joined #evergreen |
| 10:10 |
gmcharlt |
Bmagic: I think the work flow is to give you (and maybe all DIG committers) write access to master for eg-antora |
| 10:10 |
Bmagic |
that'll work |
| 10:12 |
gmcharlt |
hmmm |
| 10:12 |
gmcharlt |
but you already had that access |
| 10:13 |
gmcharlt |
Bmagic: please try pushing a no-op commit to eg-antora:master and advise if you get any error messages |
| 10:29 |
|
collum_ joined #evergreen |
| 10:30 |
|
collum_ joined #evergreen |
| 10:44 |
|
nfBurton joined #evergreen |
| 10:46 |
|
stephengwills joined #evergreen |
| 10:50 |
* gmcharlt |
claims 1222 and 1223 |
| 10:53 |
pinesol |
[evergreen|Mike Rylander] LP#1860703: Create A/T hook and reactor for push integration - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7170295> |
| 10:53 |
pinesol |
[evergreen|Mike Rylander] LP#1860703: Additional A/T hooks for use with various patron changes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d0acd1e> |
| 10:53 |
pinesol |
[evergreen|Mike Rylander] LP#1860703: Adding release notes for A/T HTTP reactor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e8c6bb1> |
| 10:53 |
pinesol |
[evergreen|Galen Charlton] LP#1860703: stamp schema update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=957beb5> |
| 10:57 |
|
Christineb joined #evergreen |
| 11:22 |
|
nfBurton joined #evergreen |
| 11:32 |
* gmcharlt |
grabs 1224 |
| 11:35 |
pinesol |
[evergreen|Rogan Hamby] LP#1835736: add stock icon and search formats for preloaded audio - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=443ac84> |
| 11:35 |
pinesol |
[evergreen|Galen Charlton] LP#1835736: stamp schema update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=60a229a> |
| 11:41 |
|
dbwells_ joined #evergreen |
| 11:42 |
Bmagic |
gmcharlt: I thought I did! I'll perform the routine later today and get back with you. I pasted the original error on that email thread in May/June |
| 11:42 |
gmcharlt |
ok |
| 11:45 |
nfBurton |
gmcharlt I made a rather large push of LP1778972 last night and marked it with a pull request. I think it's ready to go at this point. |
| 11:46 |
gmcharlt |
nfBurton: thanks. |
| 11:47 |
gmcharlt |
also, as an FYI, some looseness will be permitted since that skin will just be an experimental alternative in 3.6. e.g., a new feature in 3.6 that only touched the TPAC templates won't block the Boostrap skin |
| 11:47 |
rfrasur |
nfBurton, after I finish up a different thing, I'd planned to get in that and kick the tires a little. |
| 11:47 |
gmcharlt |
under the assumption (which we can enforce) that loose ends like that will be tied in during the 3.7 cycle |
| 11:49 |
nfBurton |
Yeah, I plan to support it for a while and have ideas for improvements in the next iteration already |
| 11:50 |
nfBurton |
It closes a number of other tickets as well that |
| 11:50 |
nfBurton |
I tried to keep both supported. |
| 11:51 |
|
dbwells joined #evergreen |
| 11:51 |
nfBurton |
Turns out a function in simple.js has been causing jQuery issues. But now that that is resolved, I would like to remove dojo one day |
| 11:52 |
|
jihpringle joined #evergreen |
| 11:57 |
* oleonard |
waves to gmcharlt and nfBurton |
| 11:58 |
nfBurton |
I'm a weeb that doesn't know how to wave, but HI |
| 11:58 |
gmcharlt |
nfBurton: "/me does an action in the third person" |
| 11:58 |
gmcharlt |
... is how you say it in IRC |
| 11:58 |
oleonard |
nfBurton I saw that you tried to ping me several days ago, sorry I missed it |
| 11:59 |
oleonard |
I've been looking at your Bootstrap work, hoping to add some tweaks. |
| 12:03 |
nfBurton |
Nice. More eyes the better. I'm not really a designer but we have to be WCAG2.0 AA in Ontario by 2021 so it's been a big motive to get this done. |
| 12:04 |
nfBurton |
@gmcharlt how long can I make changes to the branch? I know Slush and Freeze are coming up but I'm new to the dev cycle |
| 12:04 |
pinesol |
nfBurton: Leave me alone, I'm busy right now. |
| 12:04 |
nfBurton |
lol |
| 12:05 |
|
khuckins joined #evergreen |
| 12:06 |
|
nfBurton15 joined #evergreen |
| 12:07 |
gmcharlt |
nfBurton: I'd say try to have any immediate tweaks wrapped up by end of day on Wednesday (tomorrow), so that Thursday and Friday are clear for me and others to do more review of the patches and to keep things clear to any changes that may need to be made to fit into Evergreen's build system |
| 12:07 |
oleonard |
nfBurton visually speaking one of the biggest changes that I'm going to suggest is that the profile of the persistent search fields be reduced. https://snipboard.io/de0kKj.jpg |
| 12:08 |
oleonard |
... but I'm not sure if the higher-profile layout of that form was something you were pushing for specifically |
| 12:08 |
oleonard |
whoops |
| 12:09 |
nfBurton15 |
Not really, just updating what was there. |
| 12:09 |
nfBurton15 |
Yeah my internet is wonky today, I'm still here |
| 12:09 |
nfBurton15 |
Just different hats lol |
| 12:11 |
nfBurton15 |
I like the lower profile though |
| 12:12 |
oleonard |
Okay good, I thought that would be a less-drastic change from the previous design |
| 12:14 |
nfBurton15 |
lol. It's weird trying to please everyone not knowing what they may want. As such is programming. That's why I'm really enjoying the feedback phase |
| 12:16 |
oleonard |
nfBurton15 in my test system I was seeing errors about a missing file, popper.js. Is that just me or have you seen that too? |
| 12:17 |
nfBurton15 |
No, it's in there |
| 12:17 |
nfBurton15 |
I made a large push last night too fixing a bunch of console errors |
| 12:17 |
nfBurton15 |
Actually I may have missed it, I will check |
| 12:18 |
oleonard |
Okay I probably need gmcharlt's help updating my system. |
| 12:19 |
nfBurton15 |
Nah I missed it |
| 12:19 |
oleonard |
nfBurton15: FYI the place I was seeing it interfere with functionality was with the "Add to my list" button on the bibliographic details page. |
| 12:19 |
nfBurton15 |
There are so many files involved now XD |
| 12:20 |
oleonard |
I've been really enjoying working with Bootstrap 4 for Koha's OPAC. I think it's very useful. |
| 12:21 |
nfBurton15 |
It's nice because you barely need css to get what you want |
| 12:23 |
|
jihpringle joined #evergreen |
| 13:22 |
|
jihpringle joined #evergreen |
| 13:38 |
jeff |
/cl |
| 13:38 |
jeff |
bah. |
| 13:42 |
|
dbwells joined #evergreen |
| 14:25 |
|
jihpringle joined #evergreen |
| 15:10 |
|
nfBurton joined #evergreen |
| 15:23 |
|
dbwells joined #evergreen |
| 15:42 |
|
jvwoolf1 joined #evergreen |
| 15:49 |
|
mantis1 left #evergreen |
| 16:17 |
|
rlefaive joined #evergreen |
| 16:33 |
|
jihpringle joined #evergreen |
| 17:23 |
Bmagic |
gmcharlt: I decided to dump the details into that old email thread. Hopefully the email found you just now :) |
| 17:55 |
|
jihpringle joined #evergreen |
| 18:01 |
pinesol |
News from qatests: Failed Create Evergreen Database <http://testing.evergreen-ils.org/~live//archive/2020-09/2020-09-08_16:00:02/test.41.html> |
| 19:44 |
|
rfrasur joined #evergreen |
| 19:50 |
rfrasur |
gmcharlt, are you available? |
| 21:39 |
|
sandbergja joined #evergreen |
| 22:10 |
|
sandbergja joined #evergreen |
| 22:18 |
|
rfrasur_ joined #evergreen |
| 22:46 |
|
dbwells_ joined #evergreen |
| 23:10 |
|
annagoben joined #evergreen |
