| 01:19 |
pinesol_green |
Showing latest 5 of 11 commits to Evergreen... |
| 01:19 |
pinesol_green |
[evergreen|Bill Erickson] LP#1596595 Targeter accepts a list of hold ID's - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=dbcd6ec> |
| 01:19 |
pinesol_green |
[evergreen|Bill Erickson] LP#1596595 Targeter use child editor for settings - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=129a38b> |
| 01:19 |
pinesol_green |
[evergreen|Bill Erickson] LP#1596595 AOUS lookup batch by org id - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=85e73bc> |
| 01:19 |
pinesol_green |
[evergreen|Bill Erickson] LP#1596595 Targeter leverages batch AOUS lookups - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=895f8bd> |
| 01:19 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1596595: Stamping upgrade scripts for hold targeter refactoring - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=eee584e> |
| 01:43 |
pinesol_green |
[evergreen|Jason Boyer] LP1517137: Add Permissions Missing From Stock Data - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=06e1f29> |
| 01:43 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1517137: Release note entry for addition of missing permissions - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7e590bd> |
| 01:43 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1517137: Stamping upgrade script for adding overlooked permissions - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b3a6cba> |
| 01:59 |
pinesol_green |
[evergreen|Josh Stompro] LP#1494748 - Change pay fines link to a button & increase checkbox sizes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c222f68> |
| 01:59 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1494748: Decrease the input size on Firefox by a smidge - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ced1e6c> |
| 01:59 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1494748: Release notes entry for self check interface improvements - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f9f830e> |
| 05:00 |
pinesol_green |
News from qatests: Test Failure <http://testing.evergreen-ils.org/~live> |
| 07:21 |
|
kmlussier joined #evergreen |
| 07:24 |
kmlussier |
Good morning #evergreen! Happy DIG hackaway day! |
| 07:25 |
|
agoben joined #evergreen |
| 07:25 |
kmlussier |
And happy 2.12 feature freeze day! |
| 07:25 |
* kmlussier |
sees more test failures and wonders if she can break Evergreen even more today. |
| 07:33 |
kmlussier |
rhamby: Following up on our conversation last night, I have filed bug 1665626 |
| 07:33 |
pinesol_green |
Launchpad bug 1665626 in Evergreen "Need more metarecord groups in sample dataset" [Undecided,New] https://launchpad.net/bugs/1665626 |
| 07:38 |
phasefx |
kmlussier: one option may be to create the test data needed as part of the test. Some pros and cons to that, but I've tried it before with some things |
| 07:40 |
rhamby |
kmlussier: sounds good. It'll be something I can do tomorrow morning when the house is asleep :) |
| 07:41 |
kmlussier |
phasefx: Yeah, that would work too, but, either way, we should have so grouped records in the test dataset. It makes it easier to test metarecord things. |
| 07:41 |
phasefx |
kmlussier: yeah, you're right |
| 07:42 |
kmlussier |
Of course, the nice thing about making it part of the test is that you don't have to worry about the test data moving on you. On the other hand, the person who wrote the test is on vacation right now. :) |
| 08:02 |
kmlussier |
I just ran the hold targeter test that failed. It failed for me too, but I got different errors, all of which related to the metarecord hold. |
| 08:10 |
kmlussier |
I think I know what the problem is there. It's targeting metarecord 42, but with the change in parting, metarecord 42 probably is the master of a totally new record now. |
| 08:10 |
* kmlussier |
sees if she can trace it down. |
| 08:11 |
|
Stompro joined #evergreen |
| 08:12 |
|
Dyrcona joined #evergreen |
| 08:18 |
Dyrcona |
What was it Helmuth von Moltke said? "No plan survives first contact with the enemy." |
| 08:32 |
pinesol_green |
Dyrcona: Your current monologue is at least 9 lines long. |
| 08:34 |
kmlussier |
My suspicion was wrong. The metarecord is pointing to the same bib in concerto now. |
| 08:38 |
Dyrcona |
Evergreen 2.9 is past its security release date. Should it be removed from the downloads page? |
| 08:38 |
kmlussier |
berick: Do you think you might have time today to look at 20-hold-targeter.t? This morning's test failed for hold 1 - http://testing.evergreen-ils.org/~live/test.24. |
| 08:38 |
kmlussier |
When I ran it on my VM, I didn't have trouble with that particular test, but I had errors with the test for hold 263. |
| 08:38 |
* kmlussier |
will past the output in a second. |
| 08:38 |
Dyrcona |
Also, I think the release date for 2.11 is wrong on the downloads page. |
| 08:39 |
kmlussier |
Dyrcona: yes. I noticed that yesterday but forgot to say something. |
| 08:39 |
kmlussier |
That is, I noticed that 2.9 was past the security date. |
| 08:41 |
Dyrcona |
Oh, yeah. Duh. |
| 08:42 |
Dyrcona |
I just noticed it was the same as 2.10 and thought that was wrong. |
| 08:42 |
Dyrcona |
Silly brain.... :) |
| 08:42 |
kmlussier |
berick: The output when I run that test is http://pastebin.com/DJr1L6z2 |
| 08:44 |
kmlussier |
That just leaves the web client build test. I'm not sure what's going on there. |
| 08:45 |
|
mmorgan joined #evergreen |
| 08:49 |
|
bos20k joined #evergreen |
| 09:15 |
|
afterl joined #evergreen |
| 09:15 |
kmlussier |
berick: Actually, ignore my output. Just realized I have the old hold targeter running in a cron job, which may have affected the test results? When I manually retargeted hold 263, I was left with 1 error. |
| 09:16 |
kmlussier |
It expected 22 mapped copies, but only got 21. 21 seems right to me since I only see 21 visible copies in the catalog. But I may be missing something. |
| 09:22 |
|
jvwoolf joined #evergreen |
| 09:23 |
gmcharlt |
oh, in case it wasn't obvious, I lift my hold on merging to rel_2_11 and rel_2_10 |
| 09:25 |
kmlussier |
:) |
| 09:28 |
kmlussier |
Starting my morning off right. Testing code that hasn't actually been loaded on the server I'm using. |
| 09:28 |
kmlussier |
@coffee |
| 09:28 |
* pinesol_green |
brews and pours a cup of La Esperanza Colombia Huila, and sends it sliding down the bar to kmlussier |
| 09:29 |
dbs |
kmlussier: that's your control group, right? :) |
| 09:29 |
gmcharlt |
@coffee kmlussier |
| 09:33 |
gmcharlt |
(I'm dealing with updating milestones in LP, hence my question) |
| 09:34 |
kmlussier |
Yes, looks like it. |
| 09:40 |
|
yboston joined #evergreen |
| 09:57 |
berick |
kmlussier: hey just to confirm, you are testing on a new concerto data set? |
| 09:58 |
berick |
kmlussier++ merging the midnight oil |
| 10:00 |
kmlussier |
berick: The only new thing I know of that has changed in the concerto data set is that some grouped records are no longer living in the same metarecord group. But it doesn't appear to affect the records in your tests. |
| 10:00 |
berick |
kmlussier: there's a concerto change in one of the hold targeter commits |
| 10:00 |
berick |
it adds a metarecord hold |
| 10:01 |
kmlussier |
berick: Yes, that's there. |
| 10:01 |
berick |
ok |
| 10:01 |
berick |
possible some parallel changes occurred that affect the test. kmlussier, I can revisit in a bit, after I deploy some security patches |
| 10:02 |
kmlussier |
berick: Great, thanks! Yes, secure your system first. :) |
| 10:02 |
kmlussier |
berick++ |
| 10:21 |
kmlussier |
Calling 1022 and 1023 |
| 10:38 |
kmlussier |
If somebody else doesn't beat me to it, that is. |
| 10:39 |
kmlussier |
Would anyone be willing to look at bug 1661747 for JBoyer today? |
| 10:39 |
pinesol_green |
Launchpad bug 1661747 in Evergreen "Add get_org_unit_ancestor_at_depth to action trigger reactor helpers" [Wishlist,New] https://launchpad.net/bugs/1661747 |
| 10:40 |
kmlussier |
Dyrcona: Did you ever get any sample ISBN's to test the czech added content module? |
| 10:41 |
Dyrcona |
kmlussier: Better than that. They sent me some MARC records, that I admittedly have not looked at, yet. |
| 10:41 |
Dyrcona |
I've been doing C/W MARS stuff this morning. |
| 10:41 |
kmlussier |
Dyrcona: Do you think you'll have a chance to look at it today? If not, maybe you can send them my way and I can give it a try. |
| 10:58 |
Dyrcona |
Your branch and 'origin/user/jkotrla/lp1624366-added_content_obalkyknih_2' have diverged, and have 102 and 2 different commits each, respectively |
| 10:58 |
Dyrcona |
I'm the king of typos. |
| 10:59 |
Dyrcona |
Maybe I meant an em dash? |
| 10:59 |
Dyrcona |
Working is my origin on my test vms for obvious reasons. |
| 10:59 |
Dyrcona |
So guess I'll install again. |
| 11:02 |
Dyrcona |
I just heard from Eva and it's OK to add the records that she sent to Concerto, so I'll add them with this branch when I push it later. |
| 11:03 |
* Dyrcona |
is confident the testing will be a success. |
| 11:03 |
Dyrcona |
Should I add the documentation as a release note, or will someone else take care of that? |
| 11:03 |
|
Christineb joined #evergreen |
| 11:05 |
kmlussier |
Dyrcona: Jane was going to take care of the documentation. |
| 11:34 |
kmlussier |
Ooh! Something isn't looking good in the web client patron interface. I don't know if it's in master or is one of the branches I loaded. |
| 11:35 |
kmlussier |
Dyrcona: Did you say you just built the web client? |
| 11:36 |
Dyrcona |
Yeah, after rebasing the obalky branch and installing. I build the web client and xul client. |
| 11:36 |
Dyrcona |
I've been using the web client in a lot of my testing on my vm lately. |
| 11:36 |
gmcharlt |
Dyrcona: the branch is a little dusty (*cough* *hack*), but is there anything you still have out there would would benefit from mergin 939535? |
| 11:37 |
kmlussier |
I think the problems I'm seeing are related to a branch I haven't merged yet. |
| 11:37 |
Dyrcona |
gmcharlt: Not at the moment, and I forgot that I even did that. |
| 11:41 |
kmlussier |
Webby looks fine too, so I'll just focus on making sure I don't merge whatever broke my checkout screen. |
| 11:41 |
Dyrcona |
Maybe I'll check it out and take it for a spin. I'm probably more amenable to berick's suggestion today. |
| 11:42 |
gmcharlt |
speaking of OpenSRF 2.5-beta - I'll realize that simultaneously with the EG 2.12-beta release |
| 11:43 |
berick |
kmlussier: fyi, looking at hold tests. data has changed in a variety of ways. unclear how, since it was OK a few days ago. metarecord 42 picked up a record. bib 45 only has 21 in holdable locations, before it has 22. also, if I run the fill test suite, patrons pick up penatles that aren't there when running in isolation. (also seeing neg. balance test failures, not sure if that has any effect). |
| 11:43 |
berick |
more to follow.. |
| 11:43 |
Dyrcona |
I'll have to see if I can find my client code that used it. I probably do not still have it hanging around. |
| 11:44 |
kmlussier |
OK, I haven't seen any of the negative balance test failures. I ran the full suite of pgtap tests yesterday. |
| 11:44 |
Dyrcona |
Unless it's a branch at mvlc. |
| 11:44 |
berick |
kmlussier: perl live tests |
| 11:44 |
Dyrcona |
pgtap tests should not be a problem, IIRC. |
| 11:44 |
Dyrcona |
perl live tests mostly can only run once, then you have to reload the db. |
| 11:44 |
|
mmorgan joined #evergreen |
| 11:45 |
Dyrcona |
been a while since I ran all of the pgtap tests, though. |
| 11:45 |
Dyrcona |
that may have changed. |
| 11:45 |
kmlussier |
berick: Ah, ok. For some reason, I was thinking they were pgtap. But I didn't see any hiccups with negative balance tests in this morning's test results. |
| 11:45 |
berick |
it occurs to me if we don't enforce a leave-it-like-you-found-it policy on perl live tests, writing new tests is going to be painstakingly slow process |
| 11:46 |
berick |
rebuild db, run all tests, new test fails, start over, ... |
| 11:46 |
gmcharlt |
agreed |
| 11:46 |
Dyrcona |
But, I had a test that worked, then started failing after some other data/code was changed. IIRC, someone else ended up fixing it. |
| 11:46 |
Dyrcona |
Anyway, back to what I was doing. |
| 11:49 |
berick |
kmlussier: it's possible (nay, likely) my fines test failure was a result of running the live tests multiple times |
| 11:50 |
berick |
kmlussier: will confirm shortly |
| 11:52 |
kmlussier |
berick: As far as the changes in the metarecords, I don't have a good handle on how the sample data is built, but I wonder if my code that broke up the existing metarecord groups somehow threw off how the holdings were applied to the records. |
| 11:53 |
dbwells |
berick: when we wrote the negative balance tests, we also included a neg_bal_testing_reset.sql which might do what you need. |
| 11:57 |
dbwells |
berick: I think the main reason that doesn't just happen is that its awfully helpful to actually see the resulting test-generated data when it fails. I agree we should think about a better system or convention for that. |
| 11:58 |
berick |
dbwells: thanks |
| 11:59 |
Dyrcona |
Well, I think it would be hard to leave it like you found it with Perl tests that are doing backend calls. There's no undo mechanism for that, and a lot of things can't be deleted or undone, really. |
| 11:59 |
Dyrcona |
Bills could be paid, etc., but don't think they can be removed without gymnastics. :) |
| 12:00 |
dbwells |
yeah, the "reset" just deletes data above a certain id in certain tables. It isn't exactly future- or fool-proof by any stretch. |
| 12:08 |
kmlussier |
bug 1661754 seems more like a bug fix than new feature to me. Does anyone object to my backporting it? |
| 01:37 |
* dbs |
wonders what madness is suddenly causing a request for / to redirect to /eg/opac/home and then to /eg/opac/login?redirect_to=%2Feg%2Fopac%2Flogin%3Fredirect_to%3D%252Feg%252Fopac%252Flogin%253Fredirect_to... |
| 01:49 |
dbs |
ahh. if you happen to create an /openils/var/web/eg directory, you get... much pain |
| 05:01 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 07:14 |
|
rjackson_isl joined #evergreen |
| 07:23 |
|
agoben joined #evergreen |
| 08:12 |
jeff |
dbs: yep, i think jeffdavis and i ran into that a while back. |
| 10:29 |
|
jvwoolf joined #evergreen |
| 10:29 |
kmlussier |
JBoyer: Yes, I'm about to head into a meeting too. I'll check back later. |
| 10:31 |
|
mmorgan1 joined #evergreen |
| 10:45 |
JBoyer |
Meeting over. I'll fix it. My testing method was just lacking (add perm at >1000, run script, woo.) This time I'll assign it to a few groups to make sure the right thing is done. |
| 11:03 |
|
Christineb joined #evergreen |
| 11:15 |
JBoyer |
kmlussier, Given the way the script is written I'm rather confused how it would keep the >1000 permissions around. Did it not insert the <1000 versions? (they can't both exist in the table simultaneously) |
| 11:15 |
JBoyer |
I will say if you've inserted anything in the id = 564 to 589 range those will be "skipped" under the assumption you needed it before running the script and have dealt with everything yourself. |
| 14:54 |
kmlussier |
That's it. |
| 14:54 |
graced |
#topic Release Manager's Report |
| 14:54 |
graced |
kmlussier? |
| 14:54 |
kmlussier |
The 2.12 feature freeze deadline is tomorrow. We've been busy this week testing new features to be included in the release. |
| 14:55 |
kmlussier |
On the agenda, I highlighted some of the new features that have already made it into 2.12. |
| 14:55 |
kmlussier |
gmcharlt will be cutting the beta release next week. It should be available on Wednesday. |
| 14:56 |
kmlussier |
Also, the web client seems to be making some nice progress for 2.12. |
| 14:56 |
kmlussier |
That's all I have. |
| 14:56 |
graced |
kmlussier++ |
| 14:57 |
tspindler |
kmlussier++ |
| 14:57 |
collum |
kmlussier++ |
| 15:14 |
berick |
kmlussier: i could go either way on squashing. The bulk was already squashed. some commits makes sense as-is. other new commits each address bugs in the LP, so keeping them separate is not a bad thing, imo. if squashing is desired, though, i'm happy to. othwerwise, I say go for it. |
| 15:15 |
kmlussier |
berick: I had no strong opinions, so I'll go for it. Thanks! |
| 15:15 |
kmlussier |
berick++ |
| 15:16 |
berick |
miker: my sincere hope is future hatches can work with older EG's. so far through recent testing, the API has been stable. i expect we'll need some hatch-specific versioning, though. |
| 15:16 |
kmlussier |
I'm thinking at release time, we probably should put the hatch installer on the downloads page? |
| 15:16 |
berick |
kmlussier: makes sense. |
| 15:16 |
berick |
kmlussier: are you planning to also merge the Hatch branch into Hatch master? I can do that if you're not |
| 16:35 |
gmcharlt |
similarly, https://evergreen-ils.org/egdownloads/ is now updated |
| 16:37 |
kmlussier |
gmcharlt++ dbwells++ |
| 16:53 |
gmcharlt |
https://evergreen-ils.org/security-releases-opensrf-2-4-2-and-2-5-0-alpha2-evergreen-2-10-10-and-evergreen-2-11-3/ |
| 16:57 |
pinesol_green |
[opensrf|Mike Rylander] LP#1652382: normalization of memcache keys in C code - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=dbc54c6> |
| 16:57 |
pinesol_green |
[opensrf|Mike Rylander] LP#1652382: Make use of the clean key just created - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=3277648> |
| 16:57 |
pinesol_green |
[opensrf|Galen Charlton] LP#1652382: handle cases where supplied key is longer than 250 bytes - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=7524221> |
| 16:57 |
pinesol_green |
[opensrf|Galen Charlton] LP#1652382: more improvements to cache key munging - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=cbd252b> |
| 16:58 |
|
khuckins__ joined #evergreen |
| 17:01 |
pinesol_green |
[evergreen|Chris Sharp] LP#16663435 - Stripe org settings lack view permissions. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e664df4> |
| 17:01 |
pinesol_green |
[evergreen|Jason Stephenson] LP#16663435 - Release Note for Missing Stripe Settings Permissions - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a02bcf5> |
| 17:01 |
pinesol_green |
[evergreen|Galen Charlton] LP#16663435: stamp database update - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c9af31b> |
| 17:02 |
pinesol_green |
News from qatests: Test Failure <http://testing.evergreen-ils.org/~live> |
| 17:03 |
kmlussier |
uh oh |
| 17:03 |
kmlussier |
That's must be from the code I merged last night. |
| 17:03 |
pinesol_green |
[evergreen|Galen Charlton] release notes for 2.10.10 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9af4ae7> |
| 17:04 |
kmlussier |
But the test passed this morning. hmmmm |
| 17:07 |
|
mmorgan left #evergreen |
| 17:15 |
|
khuckins_ joined #evergreen |
| 17:37 |
jeffdavis |
updated bug 1541559 with a branch for review and some basic setup instructions |
| 18:54 |
|
Jillianne joined #evergreen |
| 19:09 |
|
kmlussier joined #evergreen |
| 19:36 |
Dyrcona |
Oh. I'm still signed in... I forgot. |
| 20:39 |
* kmlussier |
thinks she knows why the test failed today. |
| 20:44 |
kmlussier |
When I was working on bug 1553287, I noticed that the addition of parts would break up all of our metarecord groups in the test data. |
| 20:44 |
pinesol_green |
Launchpad bug 1553287 in Evergreen "Incorporating part information into biblio fingerprint" [Wishlist,Fix committed] https://launchpad.net/bugs/1553287 |
| 20:44 |
kmlussier |
And the test relies on 3 records being part of the same metarecord group. |
| 20:46 |
kmlussier |
So we need new sample records that can be grouped together and then point the test to those records. |
| 20:50 |
kmlussier |
Maybe we can get a few Harry Potter and the Sorcerer's Stone records to add to the test data. They have the added benefit of being easy to remember. |
| 21:04 |
jeff |
sounds reasonable. :-) |
| 21:16 |
rhamby |
kmlussier: I vote for at least one lovecraft collection to be added |
| 21:17 |
kmlussier |
rhamby: Sure! You got the MARC records? |
| 05:01 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 06:22 |
|
JBoyer_alt joined #evergreen |
| 06:56 |
csharp |
95ce9261 |
| 06:56 |
pinesol_green |
csharp: [evergreen|miker] add view and change permission slots to config.org_unit_setting_type, for controlling access to specific ou settings - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=95ce926> |
| 10:22 |
Thad |
Please suck in the full view of that issue, especially WHY it was initally created with the 1st comment. And then provide your feedback on it. |
| 10:29 |
gmcharlt |
I'd like to request review of the PR for bug 1639236, as I'd like to get that fix in for 2.11.3 today |
| 10:29 |
pinesol_green |
Launchpad bug 1639236 in Evergreen 2.11 "Temporary List Display Broken in 2.11/Master" [Medium,Confirmed] https://launchpad.net/bugs/1639236 |
| 10:29 |
csharp |
gmcharlt: I'll test it |
| 10:29 |
gmcharlt |
csharp: thanks! |
| 10:30 |
csharp |
that issue has been really bugging us (no pun intended) since the upgrade - I hate it when we lose features we had before :-/ |
| 10:31 |
* bshum |
thinks about https://bugs.launchpad.net/evergreen/+bug/1647819 too, which he tested before finding out about the other bug |
| 10:31 |
pinesol_green |
Launchpad bug 1647819 in Evergreen "Typo in anon_list.tt2" [Low,New] |
| 10:32 |
csharp |
yeah - there's a copy-paste-o at work there |
| 10:33 |
pinesol_green |
[evergreen|Chris Sharp] LP#1647819 - Missing closing angle bracket in anon_list.tt2 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=5160e5f> |
| 10:59 |
|
Christineb joined #evergreen |
| 11:13 |
kmlussier |
@coin |
| 11:13 |
pinesol_green |
kmlussier: heads |
| 11:13 |
kmlussier |
Looks like I'll be testing hatch this morning. :) |
| 11:13 |
kmlussier |
Errrr...more likely to be afternoon. |
| 11:16 |
|
bmills joined #evergreen |
| 11:18 |
berick |
heh, watched the futurama episode recently where the key difference between 2 parallel universes was that a coin toss in one was always the opposite of the other. |
| 11:18 |
berick |
so, rest assured kmlussier, in a parallel universe, you are testing something else. |
| 11:19 |
berick |
who needs clones in the multiverse? |
| 11:20 |
Dyrcona |
Every time you flip a coin, a new universe is created. |
| 11:21 |
* mmorgan |
's head is starting to hurt. |
| 11:21 |
berick |
mmorgan: re: bug 1661754, i wonder if there are legit cases for marking a long-overdue item as lost.. (maybe that's in the IRC chatter -- I haven't read it) |
| 12:09 |
|
brahmina joined #evergreen |
| 12:20 |
|
bmills joined #evergreen |
| 12:30 |
|
kmlussier2 joined #evergreen |
| 12:32 |
kmlussier2 |
berick: I ran the new Hatch installer & updated print.js with the changes from your last commit. Still having trouble printing if I change any of the printer options. If I use default settings, I can print the Test page. |
| 12:33 |
kmlussier2 |
I'll paste output in a second. Having trouble connecting to pastebin |
| 12:35 |
kmlussier2 |
berick: http://pastebin.com/eCA0RLaV |
| 12:36 |
* kmlussier2 |
heads off to lunch before testing more |
| 12:38 |
berick |
kmlussier2: *sigh* same bug, different line of code. pushing a fix. |
| 12:42 |
berick |
kmlussier2: fix and updated .exe posted to LP |
| 12:42 |
berick |
(and enjoy your lunch!) |
| 12:55 |
Dyrcona |
ha |
| 12:56 |
JBoyer |
And a hell of a thing to debug if it doesn't already exist, heh. |
| 12:56 |
kmlussier2 |
lol |
| 12:56 |
Dyrcona |
I plan on deleting the image when my test is done. |
| 12:56 |
JBoyer |
That also saves a lot of space :D |
| 12:56 |
Dyrcona |
:) |
| 12:57 |
Dyrcona |
I made it so it could go up to 600 GB. I think that's enough to load our production data. |
| 12:58 |
Dyrcona |
On a Pg-related note, does "no action" on delete on a fkey contraint prevent the delete from happening, or does it leave the junk id in the table? |
| 12:59 |
* Dyrcona |
should just RTFM. :) |
| 12:59 |
JBoyer |
I would guess it prevents a real delete anywhere else. Unless you loosen the FK. |
| 13:00 |
JBoyer |
Also, +1 to testing on "real" databases. |
| 13:00 |
Dyrcona |
Yeah, that's what I think, but I'll look it up. Someone wants to delete a patron group used by some hold matrix entries. |
| 13:00 |
Dyrcona |
+elebenty! |
| 13:02 |
Dyrcona |
JBoyer++ |
| 17:00 |
Dyrcona |
Oh.... you have say apache2.service... because Lennaert is what Linus called him. :) |
| 17:01 |
* Dyrcona |
can't wait to get home to the sanctity of his BSD castle. :) |
| 17:01 |
Dyrcona |
And, it's time to go! |
| 17:01 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 17:05 |
|
frank_guel joined #evergreen |
| 17:06 |
frank_guel |
Hi all, how are you today, I am from Mexico, I am triying to upgrade from the 2.8.4v to the 2.11.2 v, but I can´t find the 2.11.1-2.11.2-upgrade-db.sql file, Does it exist? |
| 17:06 |
frank_guel |
sorry. the 2.11.0-2.11.1-upgrade-db.sql |
| 00:58 |
|
wdfwefewvfgew joined #evergreen |
| 00:58 |
|
wdfwefewvfgew left #evergreen |
| 05:00 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 06:45 |
|
ChatSharp joined #evergreen |
| 06:48 |
|
ChatSharp left #evergreen |
| 07:15 |
|
JBoyer joined #evergreen |
| 09:00 |
* pinesol_green |
brews and pours a cup of Nectar, and sends it sliding down the bar to brews and pours a pot of BH02: Holy Basil Purple Leaf, and sends it sliding down the bar to gmcharlt (http://ratetea.com/tea/upton/bh02-holy-basil-purple-leaf/1937/) |
| 09:01 |
gmcharlt |
er, apparently now *I* am tea |
| 09:02 |
kmlussier |
gmcharlt: I would have expected you to be coffee |
| 09:02 |
* gmcharlt |
too |
| 09:02 |
gmcharlt |
I am now reevaluating my perception of myself |
| 09:02 |
|
collum joined #evergreen |
| 09:19 |
|
collum_ joined #evergreen |
| 09:31 |
gmcharlt |
bshum: re your patch for bug 1664021, what creates 'test-driver'? |
| 09:31 |
pinesol_green |
Launchpad bug 1664021 in Evergreen "Add to .gitignore 2017" [Wishlist,Triaged] https://launchpad.net/bugs/1664021 |
| 09:35 |
bshum |
gmcharlt: Hmm.... I'm not sure right now. I just know I always see it there on my test systems after I do stuff. |
| 09:40 |
|
maryj joined #evergreen |
| 09:41 |
bshum |
It's from automake I think |
| 10:00 |
* berick |
confirms test-driver is part of automake |
| 10:12 |
|
Dyrcona joined #evergreen |
| 10:20 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1662319: zindex Tweak in Patron Account - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b7f6960> |
| 10:20 |
gmcharlt |
kmlussier: with various bugfixes either done or underway, I think collab/kmlussier/webstaff-sprint-4-5 will be in a good state to merge into master after EOB today |
| 15:41 |
JBoyer |
s a fresh link, in case it helps, and I may just see about moving it to GDrive instead. https://1drv.ms/u/s!AgYcRFgkcdi2nGh6RISd44rZQQjY |
| 15:41 |
eby |
that one worked fine. thanks JBoyer |
| 15:46 |
JBoyer |
Hello future visitors to the Evergreen IRC Logs looking for Ansible Playbooks! Your quest now redirects you to Google Drive: https://drive.google.com/file/d/0BxJL4m6fifaxem1xeGJmSHhnQWM/view?usp=sharing Bon Voyage. |
| 15:52 |
_adb |
JBoyer++, thanks |
| 15:53 |
_adb |
the .txt says OS: Ubuntu 12.04. has it been tested on 14 or 16? |
| 15:53 |
JBoyer |
eby, _adb: a quick note, those haven't been updated since they were posted and may not work with newer ansible versions. You may have to do some (minor) debugging to get them to work as expected. Luckily since individual modules do fairly simple tasks they shouldn't be too difficult to adapt. |
| 15:55 |
JBoyer |
I'm using a customized version on 14.04 (it got to be too much of a hassle to maintain the separation between the playbooks and EI specific stuff, they really need to be made more generic but time and tuits are always lacking) |
| 15:55 |
eby |
i figured. but definitely an advanced starting point. thanks again |
| 17:00 |
bshum |
abowling: I think the git-admins still control that stuff |
| 17:00 |
bshum |
The community git admins I mean |
| 17:00 |
abowling |
bshum: thx |
| 17:00 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 17:07 |
|
jlundgren left #evergreen |
| 17:09 |
|
mmorgan left #evergreen |
| 17:13 |
|
Dyrcona joined #evergreen |
| 05:01 |
pinesol_green |
News from qatests: Test Failure <http://testing.evergreen-ils.org/~live> |
| 05:50 |
|
bshum joined #evergreen |
| 07:08 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1654534: Prevent loop that occurs when staff us 'place another hold' link - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=cc481b0> |
| 07:11 |
|
rjackson_isl joined #evergreen |
| 07:16 |
|
agoben joined #evergreen |
| 07:27 |
|
kmlussier joined #evergreen |
| 07:40 |
|
Callender joined #evergreen |
| 07:42 |
bshum |
@later tell gmcharlt Was talking to kmlussier and wanted to inquire about doing a POT sync and PO sync for master to get new strings into play and also updated files for Arabic for testing. As buildmaster 2.12, checking with you as well, but I don't see any harm in doing more i18n sync-ups. Opinion? |
| 07:42 |
pinesol_green |
bshum: The operation succeeded. |
| 07:47 |
bshum |
That may or may not affect any decision or changes necessary for 2.11 support for Spanish actually. Before the next POT, if we do any PO sync we can probably still safely backport them before any string updates in templates for master take effect. |
| 07:47 |
bshum |
If we want to, it's our last chance to do any PO sync from LP translations before we do a POT sync for new template strings drift. |
| 09:58 |
berick |
csharp: what are you trying to do? |
| 09:59 |
Dyrcona |
berick: He's trying to build hatch. |
| 10:00 |
|
mmorgan1 joined #evergreen |
| 10:00 |
berick |
well, more to point, csharp if you're just testing Windows for now, you don't have to compile. the libs are included in the insatller I posted on the ticket. if you want to build and/or run on linux, then carry on :) |
| 10:01 |
berick |
also the -Xdiags:verbose can be removed if it's causing problems. it's just for debugging. it's never cause probs for me, though, in either flavor of jdk |
| 10:02 |
Dyrcona |
berick: Am I right that hatch requires JavaFX for printing? |
| 10:02 |
berick |
csharp: oh, and you should be able to compile without X, but not run it |
| 10:02 |
berick |
Dyrcona: yes, openjfx is required on linux |
| 10:19 |
JBoyer |
Yeah. |
| 10:19 |
kmlussier |
copy_counts.tt2 shows up in the record detail page, right? |
| 10:20 |
kmlussier |
No, you said search results. Let me check there. |
| 10:20 |
csharp |
we usually keep our test server at the previous version for a few weeks post upgrade exactly for "it did X before the upgrade" issues |
| 10:22 |
kmlussier |
On 2.10, it is included Lost (and I assume missing) in the Y of x of Y accounts when logged into the staff client. |
| 10:22 |
JBoyer |
csharp, that's not a bad idea (provided thing are caught in time... we're a a month and a half out now.) |
| 10:22 |
JBoyer |
Ah. |
| 12:23 |
kmlussier |
If you hadn't found those already. |
| 12:24 |
mmorgan |
kmlussier is reading my mind :) |
| 12:24 |
mmorgan |
kmlussier++ |
| 12:24 |
* kmlussier |
runs out to buy lunch for the three family members who spent the morning shoveling snow while I tested code inside a warm house. |
| 12:25 |
sandbergja |
Hey everyone! I have a student here who will be helping out with the DIG hackaway next week. Who's the best person to get her an account on the wiki? |
| 12:26 |
|
jihpringle joined #evergreen |
| 12:29 |
sandbergja |
Is anybody still checking the docs evergreen-ils.org email account? |
| 13:06 |
kmlussier |
I see a lot of outdated info there. |
| 13:06 |
* bshum |
misses anoop :( |
| 13:07 |
bshum |
But as far as wiki admins go, there are lots of them in this room, myself included |
| 13:19 |
kmlussier |
berick: OK, finally getting to this party. I'm going through install steps again. Last week, I recall you asked about an evergreen directory, which I did not have. |
| 13:20 |
kmlussier |
I see making this directory is part of the optional Test Hatch steps. So should I consider that a non-optional step? |
| 13:21 |
berick |
kmlussier: the directory should be created by hatch when needed to store data |
| 13:21 |
berick |
but for now I would go ahead and create it and run the hatch test |
| 13:21 |
berick |
just to rule that out |
| 13:21 |
kmlussier |
ok, will do |
| 13:22 |
berick |
when the hatch test succeeds, btw, it just looks like a bunch of log entries |
| 13:22 |
berick |
it's not super friendly. the messages should not look like errors, though |
| 13:22 |
gmcharlt_ |
sandbergja: currently Yamil, rsouliere, phasefx, me, sdineen |
| 13:22 |
gmcharlt_ |
sandbergja: fair to assume that you'd like to be added? |
| 13:23 |
|
gmcharlt joined #evergreen |
| 13:28 |
sandbergja |
Okay! I see them now! |
| 13:29 |
jihpringle |
gmcharlt_: can you remove sdineen as an admin from that list? She isn't really involved in DIG anymore |
| 13:29 |
jihpringle |
sandbergja: if you want someone from the the BC Coop on the admin list I'm happy to be added |
| 13:30 |
berick |
kmlussier: just tested without manually creating the directory. at first, it showed an error, because the logging could not write to the log file, but then the first time the test tries to store data, it creates the directory (and then the logger is happy). |
| 13:32 |
gmcharlt |
jihpringle: I've removed her |
| 13:32 |
jihpringle |
thanks |
| 13:54 |
csharp |
TIL that you need AngularJS installed to run the web client |
| 13:58 |
berick |
the more you know.. *rainbow swipe* |
| 14:02 |
dbs |
csharp: you need AngularJS installed on your client to run the web client? o.0 |
| 14:05 |
dbs |
As part of Hatch? |
| 14:07 |
csharp |
dbs: no - I just realized that my test box didn't have it installed :-) |
| 14:07 |
csharp |
Hatch just needs java |
| 14:07 |
csharp |
and Chrome, I guess (at least I'm testing the Chrome(ium) extension) |
| 14:09 |
berick |
csharp: ugh, i think the windows installer only knows about Chrome at the moment. :( IIRC, chromium uses different registrey keys for native messaging |
| 14:09 |
csharp |
yeah - I'm using Chrome on Windows |
| 14:09 |
csharp |
s'okay |
| 14:16 |
bmills |
Bmagic++ lp 1532236 |
| 14:16 |
pinesol_green |
Launchpad bug 1532236 in Evergreen "Evergreen should allow for HTML formatted action trigger emails" [Wishlist,Confirmed] https://launchpad.net/bugs/1532236 |
| 14:17 |
bmills |
libraries are loving being able to include their logo for the new welcome to the library email |
| 14:18 |
kmlussier-clone |
berick: I had trouble running the Hatch test, so I removed the echo off the the beginning of the file and am seeing this - http://pastebin.com/rDKxqXev |
| 14:19 |
kmlussier-clone |
Apologies for the bad line breaks in that paste. |
| 14:19 |
kmlussier-clone |
@blame windows |
| 14:19 |
pinesol_green |
kmlussier-clone: windows 's bugfix broke kmlussier-clone's feature! |
| 14:19 |
csharp |
OMG a clone! |
| 14:21 |
kmlussier-clone |
csharp: Yes, while I work on hatch, kmlussier is working on authority testing. Or maybe she's just drinking coffee. |
| 14:22 |
csharp |
wow - I want one |
| 14:22 |
berick |
kmlussier-clone: ok, it's referencing a bad Java path |
| 14:22 |
csharp |
those movies never end well, though, so maybe not :-/ |
| 14:23 |
berick |
kmlussier-clone: do you have a directory C:\Program Files\Java ? |
| 14:23 |
berick |
and if so, what's in that directory |
| 14:24 |
kmlussier-clone |
Yes, it has a directory called jre1.8.0_121 |
| 14:24 |
berick |
ok.. you'll need to edit hatch.bat |
| 14:25 |
berick |
and where it says jdk1.8.0_111 replace it with jre1.8.0_121 (near the top) |
| 14:25 |
berick |
note to self: just use whatever java is in the path on windows |
| 14:26 |
berick |
those environment variables were useful for testing, but now they're just getting in the way |
| 14:26 |
csharp |
Hatch is Available ! |
| 14:26 |
berick |
csharp++ # woohoo |
| 14:26 |
berick |
csharp: can you see printers in the printer admin? |
| 14:29 |
berick |
csharp: ignore that |
| 14:29 |
kmlussier-clone |
csharp: Broken, as in screens aren't loading? |
| 14:30 |
csharp |
kmlussier-clone: correct |
| 14:30 |
berick |
csharp: ok, can you try the hatch test please? |
| 14:30 |
berick |
from the command line |
| 14:30 |
kmlussier-clone |
csharp: Yeah, that's what happened when I tried last week. I haven't gotten that far yet today. |
| 14:30 |
csharp |
sure |
| 14:31 |
berick |
i bet you're having the same issue as kmlussier-clone , bad java path |
| 14:32 |
* berick |
tries a test w/ no hard-coded paths.. |
| 14:33 |
csharp |
yep, I can see the path is wrong |
| 14:35 |
berick |
ok, cool, works fine without the hard-coded paths |
| 14:35 |
* berick |
pushes to repo |
| 14:38 |
csharp |
yep - it works fine after changing the path |
| 14:38 |
csharp |
I don't have any printers available to this VM, so I'll have to test for real next week |
| 14:39 |
berick |
csharp: can you try the 'copy settings to hatch' button in the hatch UI? |
| 14:39 |
* berick |
just pushed this BTW http://git.evergreen-ils.org/?p=working/Hatch.git;a=commitdiff;h=720d7579a661dbca8a41bff0275f6df5edd24b51 |
| 14:39 |
csharp |
Settings successfully migrated |
| 14:41 |
* berick |
suddenly feels less alone in the world |
| 14:41 |
csharp |
we're right behind you.. well several miles back, but you get the idea ;-) |
| 14:54 |
JBoyer |
csharp, Quick note since I just noticed "I don't have any printers available in this VM.": Last I knew Windows will let you add a "Generic Plain Text" printer connected to the LPT port which doesn't actually require it to be available or connected. |
| 14:55 |
JBoyer |
Doesn't allow you to really test printing, but it will get you the Printer Properties dialog if that's what you want to test in Hatch. |
| 14:58 |
csharp |
I'll try that |
| 14:58 |
csharp |
after I'm sure this works on Windows, Linux is next |
| 15:04 |
csharp |
the PDF printer works |
| 15:48 |
berick |
yay again |
| 16:08 |
* kmlussier |
just needed to get her 12yo daughter's help in navigating this Win8 machine. |
| 16:17 |
kmlussier |
berick: Can you think of a reason why a printer connected to my laptop wouldn't show up in the Select Printer dropdown? |
| 16:19 |
abowling |
anyone have any thoughts on this? everything is connecting fine and tested in srfsh. |
| 16:19 |
abowling |
open-ils.cstore 2017-02-10 16:16:34 [ERR :4809:osrf_app_session.c:1015:148676133047469] client_send_message failed |
| 16:20 |
kmlussier |
berick: Before trying to connect a printer locally, I had configured a Google Cloud printer as the default printer. Printing from Items Out and from Checkin weren't working, nor did the test print work. |
| 16:21 |
kmlussier |
When trying a test print, I saw this in the Console: http://pastebin.com/vr9v7N29 |
| 16:21 |
miker |
abowling: are you asking because you have a problem, or just because that message is in the logs? |
| 16:21 |
berick |
kmlussier: looking.. |
| 16:22 |
abowling |
miker: problem. db returns no results |
| 16:37 |
berick |
fix pushed. requires recompile |
| 16:37 |
berick |
i can push another windows installer soon to pick that up and the path fixes |
| 16:38 |
berick |
but for now, if you don't modify the Color setting, it should be OK. |
| 16:48 |
kmlussier |
berick: Need to leave soon, but even though the test print is working, I'm still unable to print from Items Out or a Transit Slip from check in. I don't see errors related to printing in the Console. |
| 16:48 |
kmlussier |
Give me a sec, I'll paste what I do have. |
| 16:50 |
berick |
kmlussier: thanks. |
| 16:51 |
* mmorgan |
also attempted to print from items out without success, though the test print was successful. |
| 16:51 |
kmlussier |
berick: This is what happened when I clicked print for the Transit slip - http://pastebin.com/gsa2wZxm |
| 16:51 |
kmlussier |
There are errors, but I was guessing that the piece related to printing was at the bottom, which looked fine. |
| 16:51 |
kmlussier |
Also, for the Items Out printing, the only errors that came up occurred when I was selecting the items to print. |
| 16:55 |
kmlussier |
I misspoke earlier, the Items Out errors occurred when I clicked the actions button. http://pastebin.com/m8Bir16r |
| 16:56 |
berick |
great |
| 16:56 |
berick |
i'll see if I can reproduce |
| 16:56 |
kmlussier |
berick: Actually, the non-hatch testing was done with 2.11, not master. I can test again on master later but really does need to fly now. |
| 16:56 |
berick |
fly! |
| 16:56 |
kmlussier |
berick: Thanks for all of your work on this! |
| 16:57 |
* mmorgan |
had similar experience. Just tried items out printing without hatch and it worked, with hatch, it did not print. |
| 16:58 |
berick |
mmorgan: good to know |
| 16:58 |
berick |
i've been so focused on just getting it work with the browser, actually /using/ it was not on my radar ;) |
| 17:02 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 17:02 |
mmorgan |
Well the browser and hatch do seem comfortable with each other, and the interfaces look great to me. |
| 17:02 |
mmorgan |
berick++ |
| 17:02 |
berick |
ah, found it, it's not getting called right |
| 17:11 |
pinesol_green |
berick: The operation succeeded. |
| 17:29 |
pinesol_green |
[evergreen|Jason Stephenson] LP 1648918: Remove Workstation at Root of User's Permission Tree - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=7161adb> |
| 17:29 |
pinesol_green |
[evergreen|Bill Erickson] LP#1653742 Copy tree authoritative API share cstores - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=53adf05> |
| 18:47 |
csharp |
berick: I tested your latest fix too - all works with the assumption that "java" is in the system path |
| 01:54 |
|
Callender_ joined #evergreen |
| 05:01 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 06:06 |
|
genpaku joined #evergreen |
| 07:11 |
|
rjackson_isl joined #evergreen |
| 07:30 |
|
agoben joined #evergreen |
| 09:07 |
rhamby |
@weather 30046 |
| 09:07 |
pinesol_green |
rhamby: Lawrenceville, GA :: Partly Cloudy :: 43F/6C | Wind Chill: 34F/1C | Thursday: Mostly sunny and windy. High 49F. Winds NW at 20 to 30 mph. Thursday Night: Clear skies. Low 28F. Winds NW at 10 to 15 mph. | Updated: 12m ago |
| 09:08 |
rhamby |
kmlussier: not today and probably not tomorrow but next week I'm going to force myself to deal with some outreach stuff. how is next week looking for me bothering you? |
| 09:17 |
kmlussier |
rhamby: Well, it is feature freeze at the end of next week, so I'll be doing a lot of testing. But I should be around. |
| 09:18 |
rhamby |
kmlussier: I don't know how much I'll need to bug you but I'll probably at least want to bounce a few ideas off you |
| 09:19 |
|
maryj joined #evergreen |
| 09:21 |
kmlussier |
Dyrcona: So I should hold off on bug 1005040 until the issue you mentioned in comment 11 is addressed? |
| 10:41 |
pinesol_green |
[opensrf|Galen Charlton] LP#1652122: fix infinite recursion in opensrf.system.method.all - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=bd5fc63> |
| 10:42 |
Dyrcona |
And, I'll pickup that one, too. :) |
| 10:48 |
Dyrcona |
miker: Yep. Looks like that one fixes that. |
| 10:48 |
miker |
cool, thanks for testing. have time to sign off, etc? |
| 10:50 |
Dyrcona |
Yeah, I was just looking at the code before signing off. Should I just push it to master? |
| 10:56 |
miker |
let me make sure of that... |
| 10:57 |
miker |
yes, I think so for now |
| 11:49 |
|
brahmina joined #evergreen |
| 12:03 |
|
sandbergja joined #evergreen |
| 12:06 |
|
bmills joined #evergreen |
| 12:09 |
* csharp |
builds a Windows 10 workstation to start testing hatch |
| 12:18 |
berick |
csharp++ # i'm around if hit any snags. since so few have tread there, i'm guessing you will. |
| 12:19 |
* berick |
is reminded of a docs change he meant to make after kmlussier's testing last week.. |
| 12:19 |
berick |
oh right the permission granting |
| 12:22 |
* berick |
pushed the doc update |
| 12:23 |
csharp |
berick: thanks |
| 12:23 |
|
jihpringle joined #evergreen |
| 12:29 |
kmlussier |
berick: I'll check that out as soon as I get back to testing hatch. Thanks! |
| 12:30 |
berick |
kmlussier: cool, i believe your past that step, btw, so my doc change probably won't have any effect your testing. |
| 12:30 |
berick |
unless you start over |
| 12:30 |
kmlussier |
berick: I was thinking of starting over. |
| 12:31 |
* berick |
nods |
| 12:42 |
|
jihpringle joined #evergreen |
| 15:56 |
berick |
Dyrcona: indeed, and the Actions drop-down above the grid |
| 15:57 |
Dyrcona |
Oh. Missed the Actions drop down, 'cause I think it is all the way to the left in XUL, but I might be wrong. |
| 16:02 |
Dyrcona |
So, I have half of a fix. More work required. |
| 16:04 |
pinesol_green |
Showing latest 5 of 17 commits to Evergreen... |
| 16:04 |
pinesol_green |
[evergreen|Mike Rylander] LP1281280: Allow test script to run without a full installation - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9a03ed4> |
| 16:04 |
pinesol_green |
[evergreen|Mike Rylander] LP#1005040: Styling cleanup for filter display - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=f12cc28> |
| 16:04 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1005040: Release notes entry for advanced search limiter improvements - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=32d9fd0> |
| 16:04 |
pinesol_green |
[evergreen|Mike Rylander] Adjust comment about apostrophes in opensearch code. This is a marker for future work. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=38ca8cc> |
| 16:04 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1005040: Stamping upgrade script for realign search layers - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c9afb45> |
| 16:16 |
Dyrcona |
Right click is now acting weird on me. It's taking me to Item Status as if I'd left clicked. |
| 16:16 |
Dyrcona |
The menu pops up and then I end up at Item Status. |
| 16:17 |
* Dyrcona |
blames low RAM and/or Firefox. |
| 16:56 |
|
bmills joined #evergreen |
| 16:58 |
kmlussier |
Ok, so if I'm on the Harry Potter record, it will provide a link to any editions that match particular formats. When it lists the 'book' format, it's based on the icon_format definition. |
| 16:59 |
kmlussier |
But when you click the link, it's limiting to search_format='book', which is defined entirely differently from the icon format, so you get a different number of results than you expected. |
| 17:01 |
pinesol_green |
News from qatests: Test Success <http://testing.evergreen-ils.org/~live> |
| 17:01 |
kmlussier |
We know both need to be based on the same record attribute so that the counts match up correctly, but we were just looking for direction on which one should be used. |
| 17:02 |
kmlussier |
I think Bmagic saw a benefit to re-using the code that was being used for icon formats, but then that means we would be filtering by icon_format when clicking the link. This works, but some might find it strange to limit based on icon format. |
| 17:04 |
Dyrcona |
icon_format makes sense because it often corresponds to what people think of as item types. |
| 17:05 |
JBoyer |
I didn't think icon_format had Filter set to True, but it does so I suppose that should work out fine. |
| 17:10 |
kmlussier |
Yes, I did some testing with icon_format and had no trouble filtering the results that way. |
| 17:10 |
* miker |
reads up |
| 17:12 |
|
mmorgan left #evergreen |
| 17:15 |
miker |
is it too much to have a new YAOUS that defines how a site wants to divide up their MR types? |
