| Time |
Nick |
Message |
| 06:10 |
|
gsams joined #evergreen |
| 07:13 |
|
rjackson_isl joined #evergreen |
| 08:44 |
|
mmorgan joined #evergreen |
| 08:53 |
|
collum joined #evergreen |
| 09:07 |
|
mmorgan1 joined #evergreen |
| 10:16 |
|
Christineb joined #evergreen |
| 10:48 |
|
rrivas joined #evergreen |
| 10:50 |
|
rrivas left #evergreen |
| 11:52 |
|
mmorgan joined #evergreen |
| 11:54 |
|
brahmina joined #evergreen |
| 11:55 |
|
bmills joined #evergreen |
| 12:06 |
|
jihpringle joined #evergreen |
| 12:40 |
|
DPearl joined #evergreen |
| 14:10 |
jeffdavis |
I'm thinking about live tests for bug 1541559 |
| 14:11 |
pinesol_green |
Launchpad bug 1541559 in Evergreen "OneClickdigital API integration" [Wishlist,New] https://launchpad.net/bugs/1541559 - Assigned to Jeff Davis (jdavis-sitka) |
| 14:11 |
jeffdavis |
The module is modeled after AddedContent, so there is a main EbookAPI module and separate handler sub-modules for the different vendor APIs (OneClickdigital, OverDrive) |
| 14:13 |
jeffdavis |
I don't think we can hard-code any tests that actually talk to those APIs, so I am thinking of having a "Test" handler that doesn't do any HTTP lookups, just responds correctly to the various ways that the main module can use a handler sub-module. It could also serve as a kind of reference implementation for future handlers. |
| 14:13 |
jeffdavis |
Does that make sense, or is it overkill? |
| 14:16 |
jeffdavis |
"HTTP lookup" is not the right way to put that, hope my technical solecisms don't confuse things too much :) |
| 14:21 |
phasefx |
jeffdavis: you could mockup a web server using expect |
| 14:21 |
phasefx |
and point to localhost and some port instead of an actual third-party host for the config |
| 14:22 |
phasefx |
well, if not using SSL, that is |
| 14:27 |
jeffdavis |
Is that what we want to do for automated testing? |
| 14:28 |
phasefx |
:-/ |
| 14:29 |
jeffdavis |
sorry, afaik we aren't doing anything like that so far, and I don't know enough about tests to know if I'm stepping into a minefield that way |
| 14:29 |
phasefx |
might be easier but more brittle |
| 14:29 |
tsbere |
I think the "Test" module is a good idea, overall, for testing things that would call out to third parties. Though setting up a general test service somewhere that said module could poke at might work too. |
| 14:29 |
tsbere |
At least you get better coverage of some of the code paths with the test module, right? |
| 14:31 |
phasefx |
you tie the test to the implementation with a module, but that's probably okay. But if you ever want to reimpliment, a black box test service could be useful |
| 14:34 |
jeffdavis |
This would have been a good thing to ask about if I were going to the hackaway :) |
| 14:35 |
* phasefx |
had never been in the habit of writing tests when he was more active with coding, so this is all thought exercise for him. "Grain of salt also advised :) |
| 14:38 |
jeffdavis |
all advice and suggestions are appreciated :) |
| 14:53 |
|
gsams_ joined #evergreen |
| 14:55 |
|
gsams joined #evergreen |
| 15:04 |
|
mmorgan1 joined #evergreen |
| 15:14 |
|
kmlussier joined #evergreen |
| 15:14 |
* kmlussier |
waves from the Harrison House. :) |
| 16:10 |
|
mmorgan joined #evergreen |
| 16:17 |
|
bmills joined #evergreen |
| 16:30 |
|
kmlussier joined #evergreen |
| 17:05 |
|
mmorgan left #evergreen |
| 17:15 |
pinesol_green |
Showing latest 5 of 10 commits to OpenSRF... |
| 17:15 |
pinesol_green |
[opensrf|Mike Rylander] LP#1612771: Add chunking support to JS implementation - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=fd1ce35> |
| 17:15 |
pinesol_green |
[opensrf|Galen Charlton] LP#1612771: don't adjust max_stanza_size during installation - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=d79c7ee> |
| 17:16 |
pinesol_green |
[opensrf|Galen Charlton] LP#1612771: update protocol documentation - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=4f73f38> |
| 17:16 |
pinesol_green |
[opensrf|Galen Charlton] LP#1612771: fix error in POD - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=76a5fd0> |
| 17:16 |
pinesol_green |
[opensrf|Galen Charlton] LP#1612771: add release notes - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=dbf9ec1> |
| 17:25 |
pinesol_green |
[opensrf|Mike Rylander] LP#1631522: Dispatch mode for method_lookup subrequests - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=9d106ae> |
| 17:26 |
pinesol_green |
[opensrf|Galen Charlton] LP#1631522: include example of ->dispatch in example app - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=1431100> |
| 17:26 |
pinesol_green |
[opensrf|Galen Charlton] LP#1631522: dev doc now describes ->dispatch - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=31a0bfe> |
| 17:26 |
pinesol_green |
[opensrf|Galen Charlton] LP#1631522: add release notes for ->dispatch - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=168b4ca> |
| 20:52 |
|
bmills joined #evergreen |
| 22:32 |
|
bmills joined #evergreen |
| 23:05 |
|
bmills joined #evergreen |
