Evergreen ILS Website

Search in #evergreen

Channels | #evergreen index




Results

Result pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143

Results for 2021-02-10

01:20 mrisher_ joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:56 collum joined #evergreen
08:00 rjackson_isl_hom joined #evergreen
08:06 mantis1 joined #evergreen

Results for 2021-02-09

06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:11 kip joined #evergreen
07:00 Dyrcona joined #evergreen
07:10 kip joined #evergreen
11:57 pinesol [evergreen|Terran McCanna] LP1908724 Staff Catalog Sort by PubDate Wording - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=893a5f9>
11:59 pinesol [evergreen|Bill Erickson] LP1907286 Staff catalog sets last retrieved record - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=449df59>
12:12 jihpringle joined #evergreen
12:28 Dyrcona Speaking of release notes, the branch on  bug 1861319 has release notes AND tests!
12:28 pinesol Launchpad bug 1861319 in Evergreen "Allow Item Renewal on Expired Patron Record" [Wishlist,Confirmed] https://launchpad.net/bugs/1861319
12:28 sandbergja joined #evergreen
12:56 mantis1 joined #evergreen
13:01 pinesol [evergreen|Mike Risher] lp1847519 Port of Circulation Limit Set UI - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=db7271e>
13:01 mantis1 left #evergreen
13:05 mantis1 joined #evergreen
13:09 Bmagic JBoyer: our test server does* have the RemoteIP settings: RemoteIPInternalProxy 127.0.0.1/24 RemoteIPInternalProxy ::1  RemoteIPHeader X-Real-IP
13:10 Bmagic I'm not sure based on the comments above whether those are or are not suppose to be uncommented? Ours are uncommented
13:10 JBoyer Is nginx (or whatever) running on the same VM?
13:10 Bmagic yes
16:39 mrisher jihpringle: I put in a fix on that bug you reported yesterday.  Thanks for spotting it!  1857911
16:40 mrisher (bug #1857911)
16:40 pinesol Launchpad bug 1857911 in Evergreen "Angular: Local Admin Statistical Categories Port" [Wishlist,New] https://launchpad.net/bugs/1857911
16:42 jihpringle mrisher: awesome, I'll keep an eye out and give it another test if it gets updated on one of the test servers this week
16:52 terranm Err... so if I have a carousel that is manually created from a bucket, then I change the contents of that bucket, how does the carousel update? (Mine is still showing the initial bucket records and it won't let me manually refresh it)
16:55 terranm Oh never mind, I was looking at the wrong bucket. X)
17:15 mmorgan left #evergreen
17:35 jihpringle thanks Bmagic++
17:36 Bmagic no prob!
17:36 Bmagic classic unplug it and plug it back in
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:04 jihpringle joined #evergreen
18:51 JBoyer Any day you have to enable trace logging in apache is probably not a good day. Incidentally, I've learned you generally don't have to go any higher than trace4 if you're diagnosing named virtualhost problems.
18:52 JBoyer ALSO, if you include :443 or :80 in a servername / serveralias you're committing a crime.

Results for 2021-02-08

00:47 sandbergja joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:17 rjackson_isl_hom joined #evergreen
07:19 rjackson_ils joined #evergreen
07:35 collum joined #evergreen
08:31 troy__ joined #evergreen
08:31 rfrasur joined #evergreen
09:14 terranm joined #evergreen
09:22 terranm Good morning everyone - Feedback Fest community test servers are up and running here! https://docs.google.com/spreadsheets/d/1XeRK2oTIIu​5pu7iy2ceWbE1ZRBgz9X2W1YC_E6QNexg/edit?usp=sharing
09:34 dbwells joined #evergreen
09:43 JMooreWyomissing joined #evergreen
09:48 JMooreWyomissing Has anyone heard about registration for 2021 Evergreen International Conference?  I know it's entirely online this year.  Website has a post from late December but no updates since then...
15:34 mantis1 left #evergreen
15:43 sandbergja joined #evergreen
16:08 sandbergja joined #evergreen
16:16 jihpringle terranm Bmagic: I've run into an issue on Blake's test server - it looks like one of the fixes has broken Circulation Policies but I don't know which one (maybe https://bugs.launchpad.net/evergreen/+bug/1847519 since it's related to circ policies)
16:17 pinesol Launchpad bug 1847519 in Evergreen "Angular: Local Admin Circulation Limit Set Port" [Wishlist,Confirmed]
16:17 jihpringle I have other fixes on the server that I'd like to sign off on but I don't want to sign off if they break Circulation Policies
16:17 jihpringle no matter what I do I can't save a new policy, but I can create a new one on Tiffany's test server
16:26 dbwells joined #evergreen
16:30 dbwells joined #evergreen
16:32 terranm jihpringle: Thanks, I'll email Blake since it looks like he's not logged into IRC right now
16:33 jihpringle thanks terranm: I'm now three for three with fixes not working quite right on that server
16:33 terranm :)
16:36 csharp jihpringle: I have that patch installed on current master on my test server: csharp-master.gapines.org/eg/staff admin/demo123
16:36 csharp it's isolated, so you should be able to just test it
16:36 jihpringle thanks, I'll give it a try :)
16:38 csharp I know it's more efficient to bundle the test patches on each server, but sometimes testing one at a time is necessary for due diligence
16:40 sandbergja joined #evergreen
16:40 jihpringle thanks csharp I can't create new circ policies on your server either so looks like it is that patch causing issues
16:48 jihpringle joined #evergreen
17:12 terranm joined #evergreen
17:16 csharp jihpringle: confirmed on master - I can't create a new circ policy as admin
17:16 jihpringle glad it's not just me :)
17:16 csharp so, um, I guess it's not related to mrisher's stuff but we need to be able to add those to test mrisher's stuff :-/
17:17 jihpringle weirdly it worked on Tiffany's server though
17:17 csharp that's interesting
17:19 csharp slightly different master, looks like - that points to a recent change causing the issue
17:29 csharp JBoyer: I can confirm that they are correct on tiffany-master and *not* on csharp-master
17:29 JBoyer That's a good sign!
17:29 dbwells joined #evergreen
17:30 csharp rebuilding master on my server now, then we'll be able  to test mrisher's fix :-)
17:30 JBoyer And also a big question mark, because I've only seen that happen in dojo interfaces and Angular ones seemed to be immune. Maybe that's a cstore / pcrud difference.
17:30 csharp dojo--
17:30 csharp dojo--\
17:35 jihpringle JBoyer++  csharp++
17:36 csharp ok - reapplying the patch on my server - we'll see what happens :-)
17:39 dluch JMooreWyomissing: The conference committee will be sending out more information on Wednesday. Stay tuned!
17:43 csharp ok, jihpringle, you're up if you want to test again (make sure to log out and register a new workstation - I take the nuclear approach when I rebuild my server :-) )
17:43 jihpringle will do, thanks csharp
17:50 jihpringle csharp everything looks good!  I'll sign off on the patch
17:50 jihpringle thanks!
17:57 gmcharlt I can see that as valid - e.g., a location that has no collection but does have a hold pickup service - but I wanted to confirm
17:58 pastebot "gmcharlt" at 168.25.130.30 pasted "berick: please go ahead and repatch; here is the additional change needed" (12 lines) at http://paste.evergreen-ils.org/10100
17:59 berick gmcharlt: thanks, will do.
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:05 pinesol [evergreen|Garry Collum] LP1908113: link carousel titles in Bootstrap OPAC - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=343a720>
18:06 pastebot "berick" at 168.25.130.30 pasted "hold org select" (8 lines) at http://paste.evergreen-ils.org/10101
18:06 berick gmcharlt: hm, looking at the tpac code, i think it's doing the opposite of what you said, no?
18:06 berick can_have_vols_only=1  but no can_have_users_only flag

Results for 2021-02-07

15:43 sandbergja joined #evergreen
17:10 sandbergja joined #evergreen
17:43 sandbergja joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
19:08 sandbergja joined #evergreen
19:30 sandbergja joined #evergreen
21:40 sandbergja joined #evergreen

Results for 2021-02-06

06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
12:58 sandbergja joined #evergreen
16:34 RBecker left #evergreen
16:34 sandbergja joined #evergreen
17:41 sandbergja joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
20:07 sandbergja joined #evergreen
20:32 sandbergja joined #evergreen
21:14 sandbergja joined #evergreen

Results for 2021-02-05

04:03 malexander joined #evergreen
04:46 khuckins joined #evergreen
05:09 sandbergja joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:20 rjackson_isl_hom joined #evergreen
07:26 collum joined #evergreen
07:35 malexander joined #evergreen
15:51 tlittle joined #evergreen
17:13 mmorgan left #evergreen
17:22 Bmagic And for something completely different: authority control. Reading this code: authority_control_fields.pl - it seems to me that the authority records are required to have a "003" ? This line:  my $cni = $auth_marc->field('003')->data(); dies quite often and throws errors
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:11 Cocopuff2018 joined #evergreen
18:42 malexander_ joined #evergreen
20:34 mrisher joined #evergreen

Results for 2021-02-04

16:58 mmorgan left #evergreen
17:19 jihpringle joined #evergreen
17:20 Bmagic csharp: the DOS "fix" for us was the nginx limitation on the unapi URL OpenSRF Bug 1913617
17:20 pinesol Launchpad bug 1913617 in OpenSRF "NGINX could use a DOS mitigation example" [Undecided,New] https://launchpad.net/bugs/1913617
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:20 sandbergja_ joined #evergreen
18:34 sandbergja_ joined #evergreen
18:44 sandbergja_ joined #evergreen

Results for 2021-02-03

14:18 Dyrcona Both IDLs come out as valid XML when I check them.
14:25 Dyrcona The composite types mentioned in the pgerrors.txt have been in the IDL since 2009.
14:25 Dyrcona I'm stumped.
14:30 jeffdavis Dyrcona: there are a couple of test scripts for search in Open-ILS/src/support-scripts/test-scripts/ - do they show anything interesting?
14:30 jeffdavis my next guess would be an issue with visibility attrs
14:37 Dyrcona jeffdavis: I haven't run them.
14:39 Dyrcona I don't think the problem is really search or the database, because it works with the experimental Angular catalog, but I'll give those scripts a shot. I still think it has to be the templates or something in the Perl.
14:57 Dyrcona So, query_tests.pl returns results on some of the searches. Naturally, many of them return nothing because it looks like it is written for the concerto dataset.
17:32 dbwells joined #evergreen
17:38 mmorgan left #evergreen
17:41 jihpringle joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
22:59 Cocopuff2018 joined #evergreen

Results for 2021-02-02

05:24 khuckins joined #evergreen
05:59 khuckins joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:00 khuckins_ joined #evergreen
06:02 khuckin__ joined #evergreen
07:25 rjackson_isl_hom joined #evergreen
10:46 Dyrcona Hmm.  Schedule something for 11:30 am or just do it myself?
10:46 Dyrcona @decide at or manual
10:46 pinesol Dyrcona: That's a tough one...
10:55 Dyrcona Bleh.. Tryina test a rsync command and looks like it ignored the -n option.
10:56 Dyrcona So, a couple of files got copied early. Hope that didn't break anything. If it did, guess I'll hear about it.
10:57 Dyrcona Things are working for me, so guess it's no big deal
11:03 Dyrcona berick: If I'm using rsync to update  /openils/var/web/eg2/en-US/ should I use --delete to remove older versions of some of the files?
13:55 Dyrcona :)
13:55 JBoyer berick++
13:55 JBoyer Dyrcona++
13:56 Dyrcona JBoyer++ # For testing us. :)
13:56 stephengwills that pesky SIX key!
14:06 sandbergja_ joined #evergreen
14:23 mantis1 Question about the autorenewal feature.  Is there a way to block autorenewals from happening if there is a hold on said item?
14:24 mantis1 I tested it with both a copy and bib level hold for two separate items, and autorenewals went through.
14:41 jeff I don't know that there's an autorenew-specific block, but there's an org unit setting for blocking renewals when there's a hold, and there's also the option of defining a minimum hold:copy ratio as part of your circ policy. In theory the latter gives you more nuanced control, but I can't confirm that because we're not currently using it.
14:47 alynn26 joined #evergreen
14:52 terranm joined #evergreen
15:19 JBoyer mrisher++
15:19 mrisher I'll miss you too!@
15:19 JBoyer Feedback fest is a good time.
15:20 mrisher these are the 3:
15:20 mrisher Needs discussion https://bugs.launchpad.net/evergreen/+bug/1848579
15:20 mrisher Needs testing https://bugs.launchpad.net/evergreen/+bug/1844169 , https://bugs.launchpad.net/evergreen/+bug/1847519
15:20 pinesol Launchpad bug 1848579 in Evergreen "Angular grids: interval columns are not filterable" [Medium,Confirmed]
15:20 pinesol Launchpad bug 1844169 in Evergreen "Angular: Local Admin Search Filter Groups Port" [Wishlist,Confirmed]
15:20 pinesol Launchpad bug 1847519 in Evergreen "Angular: Local Admin Circulation Limit Set Port" [Wishlist,Confirmed]
15:20 sandbergja mrisher++
15:21 JBoyer In fact... I would suggest that anyone that can put together a test server (or 2) try to make sure that some of mmorgan's interesting / important bugs *and* some of sandbergja's old bugs are included, and mrisher's 3 because more Angular == more better.
15:22 csharp Oldsquash week?
15:22 JBoyer Not on every test server, of course, but I imagine there will be a handy worksheet like last time and we should try to make sure those are running *somewhere*
15:22 dluch lol
15:22 mmorgan Just a clarification on my list - those all have signoffs, do they need to have a place on a test server?
15:23 JBoyer They do not! no one bother with mmorgan's list of bugs you don't need to load on a test server! :)
15:23 mmorgan Just commit them!;-)
15:23 JBoyer That also counts as feedback fest progress, yes.
15:23 JBoyer Ok.
15:24 csharp I do think it's worth the committer's time to test an older signed-off bug, but point taken
15:24 Dyrcona I generally don't signoff and commit unless I've tested a bug fix.
15:24 csharp same
15:24 Dyrcona But, I suppose I could just commit ones that I've already tested. :)
15:25 JBoyer csharp, certainly, but FF may allow for more in-depth testing, where a committer's testing usually involves knowing that it's already been given the once-over before they looked at it.
15:26 mmorgan Make sense! I wasn't sure if committers built their own test enviroments for committing purposes.
15:26 Dyrcona I'll see if I can make time to look at some of the signed off bugs this wek.
15:26 mantis1 left #evergreen
15:26 JBoyer I also assume committers do all of their testing directly rather than asking someone else to poke at things.
15:26 mmorgan Dyrcona++
15:26 Dyrcona mmorgan: I think most of us do have our own test systems.
15:26 JBoyer Moving on, we'll skip OpenSRF updates since there's nothing on the agenda, so up next is
15:27 JBoyer #topic Evergreen Updates
15:27 Topic for #evergreen is now Evergreen Updates (Meeting topic: 2020-02-02 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/dok​u.php?id=dev:meetings:2021-02-02)
15:32 JBoyer #topic Security/point releases for 3.6.2, 3.5.3 and 3.4.6 on Wednesday, February 17, 2021.
15:32 Topic for #evergreen is now Security/point releases for 3.6.2, 3.5.3 and 3.4.6 on Wednesday, February 17, 2021. (Meeting topic: 2020-02-02 - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/dok​u.php?id=dev:meetings:2021-02-02)
15:32 dluch terranm++
15:32 terranm Bmagic: Are you willing to host a feedback fest test server next week?
15:32 terranm We'll have two as well
15:32 Bmagic sure!
15:32 terranm Bmagic++
15:32 mmorgan Bmagic++
15:51 Dyrcona mmorgan++
15:51 Dyrcona I
15:51 terranm Maybe number of new bugs added since previous meeting?
15:52 Dyrcona When you're testing the branch on a Lp bug, please assign the bug to yourself.
15:52 mmorgan terranm: Good idea!
15:52 terranm Likewise, number of signoffs and pullrequests added since previous meeting?
15:52 mrisher terranm++
17:02 mrisher joined #evergreen
17:18 mmorgan left #evergreen
17:57 sandbergja_ joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
20:22 stephengwills left #evergreen

Results for 2021-02-01

00:26 sandbergja joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:57 Dyrcona joined #evergreen
07:16 rjackson_isl_hom joined #evergreen
08:12 mantis1 joined #evergreen
09:43 sandbergja Dyrcona++
09:44 mmorgan Dyrcona++
09:44 mmorgan Got our first report from users of this issue this morning. They characterized the issue as Urgent.
09:57 Dyrcona The fix for the edit link should be pretty simple. I'm about to try the "obvious" fix on a test vm. I should have something ready this week.
09:59 mmorgan Dyrcona: Would the fix involve removing that intermediate redirect?
10:02 Dyrcona mmorgan: I don't think so. I'm just switching from href to onclick.
10:03 Dyrcona If that doesn't work, then I'll look into more complicated solutions.
17:30 pinesol Launchpad bug 1896285 in Evergreen 3.5 "Use batch methods for multi-row grid actions" [Medium,Confirmed] https://launchpad.net/bugs/1896285
17:36 jeffdavis done
17:37 jeffdavis I also shared a signoff and followup for bug 1913811
17:37 pinesol Launchpad bug 1913811 in Evergreen "Too many parallel open-ils.actor.user.itemsout.notices requests" [High,Confirmed] https://launchpad.net/bugs/1913811
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:34 mrisher__ joined #evergreen
19:08 mrisher joined #evergreen
19:31 sandbergja_ joined #evergreen

Results for 2021-01-31

06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
09:36 Cocopuff2018 joined #evergreen
11:14 sandbergja joined #evergreen
14:06 sandbergja joined #evergreen
16:33 Cocopuff2018 joined #evergreen
16:42 sandbergja joined #evergreen
17:05 nfBurton joined #evergreen
18:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:03 nfBurton28 joined #evergreen
19:45 sandbergja joined #evergreen
20:48 sandbergja joined #evergreen

Results for 2021-01-30

00:05 Cocopuff2018 joined #evergreen
00:20 sandbergja joined #evergreen
03:28 alynn26 joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:50 alynn26_away joined #evergreen
09:44 Cocopuff2018 joined #evergreen
11:10 pinesol` joined #evergreen
13:38 nfBurton joined #evergreen
14:29 mrisher joined #evergreen
15:38 Cocopuff2018 joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
19:14 sandbergja joined #evergreen
20:15 sandbergja joined #evergreen
21:34 sandbergja joined #evergreen

Results for 2021-01-29

00:00 jonadab joined #evergreen
02:19 yar joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:23 rjackson_isl_hom joined #evergreen
08:01 kip joined #evergreen
08:01 jweston joined #evergreen
10:36 Cocopuff2018 joined #evergreen
10:40 rfrasur joined #evergreen
10:41 mantis2 joined #evergreen
10:59 Dyrcona Writing the live tests sometimes takes longer than writing/modifying the original code.
11:26 rhamby jboyer noting that while investigating the old zazzle storefront connected to the SFC that it still exists and has a $0.15 balance on it
11:26 rhamby I don't have access to the SFC email but I'm going to remove the Evergreen designs
11:46 sandbergja joined #evergreen
12:19 berick the scenario I'm describing should not happen under normal condiations, just when manually sharing URL's
12:19 berick e.g. debugging
12:20 berick the other explanation is a JS error
12:21 mmorgan Dyrcona: berick: Just was able to see this behavior in the client on a test server.
12:22 Dyrcona mmorgan: Console output? I won't actually take a look until next week some time.
12:23 mmorgan Don't see any errors in the console.
12:24 mmorgan I do see this warning, though: app.js:2080 Scripts may close only the windows that were opened by them
12:38 pinesol Launchpad bug 1888723 in Evergreen "Holdings and Item Attributes Editors (VolCopy) Angular Port" [Wishlist,New] https://launchpad.net/bugs/1888723
12:38 berick but could also be fixed in the angjs code, I'm sure
12:40 mmorgan Just FYI, the same redirect happened in the angjs version, but the tab closed after clicking Save and Exit
12:41 berick I justed tested the 'legacy' catalog, and it also has the same problem
12:42 berick it only happens from the 'opac view' though, since that one requires the redirect
12:43 mmorgan Oh, I see that, too, now. Prior to 3.6, the tab would close after clicking Save and Exit.
12:45 berick mmorgan: i'd be surprised if that were true, the redirect has always been there when jumping from the opac view.  i could be wrong...
12:49 Dyrcona We're on 3.2.10, but we've backported a few things, though I don't think anything related to this. I could check the code, though.
13:23 Dyrcona Chrome 88 was released on January 19th which coincides with the first day that our users were back after our server upgrade on January 18. I was going to check the bug fixes, but "This bug tracker is currently unavailable due to database issues."
13:24 mmorgan :-/
13:28 Dyrcona "Waiting for bugs.chromium.org...." You'd think Google could at least run a decent bug site.
13:30 Dyrcona Search isn't working on my test vm....
13:32 Dyrcona I should read Paolo Coelho because a) a friend once told me that I should and b) I always pick on him for testing cataloging.
13:35 Dyrcona OK, so save & exit works for me on my test vm with Chrome 88 using the Add Holdings button from the record summary.
13:40 jeffdavis My usual test subject is "Martin Chuzzlewit" because it's widely available, yet never popular enough to be a problem if you screw something up.
13:43 Bmagic Is there a cancel order option that will subsequently delete any and all of the associated copies in asset.copy?
13:44 Dyrcona jeffdavis++ # I'm using a test vm, so no danger in screwing something up.
13:45 Dyrcona Following mmorgan's steps, I get "Scripts may close only the windows that were opened by them" in the console, but the save works.
13:45 Dyrcona If I edit from the Holdings View, then Save & Exit works as expected.
13:46 Dyrcona I'm gonna try with Firefox, next.
16:15 Dyrcona jeffdavis: I'm OK with it.
16:17 berick works for me
16:20 jeffdavis thanks, done
16:27 Dyrcona Well, I managed to write 10 test today, though I guess some of the test are not for the actual functionality of the new code.
16:29 Dyrcona I think I'll remove some of the tests on Monday. We don't need to keep testing login and workstation registration, though I'll BAIL_OUT if those fail.
16:31 mmorgan Dyrcona: berick: sandbergja__: So I was just on a meet with my colleague who supports cataloging and had her test whether the holdings editor window closed or stayed open after hitting Save and Exit.
16:32 mmorgan She reported that it closed, and I asked her to check her Chrome version, it was 87.xxxx. After she updated Chrome to 88.xxx, she is now seeing the behavior where the holdings editor tab does not close.
16:33 mmorgan So, yeah, Chrome :-(
16:37 berick huh
16:37 Dyrcona mmorgan++
16:38 berick more strict re: the redirect, i guess
17:45 jeffdavis Sounds like we're seeing the Save & Exit issue too on 3.5.
17:48 Christineb for me it only happens if I open the holdings editor via  OPAC View -> Edit
17:51 jeffdavis Bill mentioned that there's an intermediate redirect involved when you take that specific route, which seems to be what Chrome is objecting to.
18:01 pinesol News from qatests: Failed Installing Evergreen pre-requisites - Expected 1 errors but encountered 3. <http://testing.evergreen-ils.org/~live//arch​ive/2021-01/2021-01-29_16:00:02/test.26.html>
19:58 alynn26 joined #evergreen
21:10 alynn26 joined #evergreen
22:30 sandbergja joined #evergreen

Results for 2021-01-28

01:49 troy__ joined #evergreen
01:49 troy__ joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:15 rjackson_isl_hom joined #evergreen
07:48 csharp Bmagic: re EBSCO - assuming it's EDS, we don't allow them real-time updates, but rather do a manual export that we upload to them monthly (but that may not be feasible for your situation)
07:51 collum joined #evergreen
10:26 Dyrcona Backporting sucks.
10:27 Dyrcona I'm told that curbside isn't working on our training server with 3.5.2, but it works fine with 3.2.10 on production. I need to see if we're missing commits or I did a bad conflict resolution. It may be easier just to build a new branch.
10:27 Dyrcona Not to mention the other stuff backported to training.....
10:28 Dyrcona So much for working on Perl test today.....
10:28 Dyrcona s/test/tests/
10:31 Dyrcona Doesn't help that I have a list of 18 commits for the curbside feature. I'll have to check that list is accurate. I suppose I could try the 3.5 backport branch, but I seem to recall not using it because it was missing something.
10:33 Dyrcona Oh, that's right. There isn't a 3.5 curbside branch.
10:38 Dyrcona Oorah! git log working/collab/gmcharlt/lp​1879983_curbside_pickup_pr ^35fca97a4ec4f5009735544a26160060eaff7610 | grep -c ^commit
13:50 pinesol [evergreen|Jane Sandberg] LP 1857351: fix field order for Course Terms - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=ced3a85>
14:04 sandbergja_ joined #evergreen
14:23 berick grabbing 1243
14:24 pinesol [evergreen|Bill Erickson] LP1894131 Sticky catalog holdings org select - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=1a9f22f>
14:24 pinesol [evergreen|Bill Erickson] LP1894131 DB Stamp: Sticky Holdings Org - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a8d4d1b>
14:24 pinesol [evergreen|Bill Erickson] LP1901760 Shared Worker minor lint repair - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=45b0e0f>
15:04 jihpringle joined #evergreen
15:30 mantis1 left #evergreen
16:04 khuckins joined #evergreen
17:11 mmorgan left #evergreen
17:33 Cocopuff2018 joined #evergreen
18:01 pinesol News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live//arch​ive/2021-01/2021-01-28_16:00:03/test.29.html>
18:31 pinesol [evergreen|Terran McCanna] LP1855761 Typo when creating new carousel mapping - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=600eedd>
18:31 pinesol [evergreen|Terran McCanna] LP1855761 Another typo fix - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=e7b5cdc>
18:31 pinesol [evergreen|Michele Morgan] LP1855761 Fix additional occurrences of 'Succeessfully' - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2066633>
18:37 Cocopuff2018 joined #evergreen
19:21 sandbergja Weird that the test was only failing on Chrome
19:21 sandbergja But I'm glad that it failed somewhere, because it did rightly find a goofy typo
19:23 pinesol [evergreen|Jane Sandberg] LP1857351 (follow-up): Fix typo that led to failing test - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=43a802a>
19:34 sandbergja_ joined #evergreen
20:12 troy__ joined #evergreen
20:12 jonadab joined #evergreen

Results for 2021-01-27

09:36 Cocopuff2018 joined #evergreen
09:37 jvwoolf joined #evergreen
09:38 jvwoolf1 joined #evergreen
09:54 berick csharp: many thanks for your testing.
09:55 berick one thing we could do is optinally turn throttling on/off, only turn it on for testing/development, and when it hits the max it just stops and logs a bunch of info.
09:55 berick forcing the dev to refactor
09:57 berick or even a debug thottle mode (log only) and strict throttle mode (stop everything)
10:04 Dyrcona Maybe we should just refactor?
10:05 Dyrcona I was thinking about that a bit this morning before clocking in. I considered raising a related topic for the next developers' meeting, but decided not to do so at this time.
10:06 berick Dyrcona: that's kind of my goal, is to isolate the trouble areas
15:47 dbwells joined #evergreen
15:55 csharp I've seen that before
16:00 sandbergja joined #evergreen
16:20 jeff mantis1 left, but we're printing barcodes in receipts using Hatch without issue, but we're printing those to a laser printer, not thermal receipt printer. I'm not sure I've tested printing to a receipt printer, but could.
16:22 jeff we're using the "holds for patron" template to print available on-shelf at-this-library holds and a scannable barcode. pullers grab them off the hold shelf and check the items out on our selfchecks after scanning the barcode on the slip.
16:22 jeff (the slips are then shredded)
16:25 Cocopuff2018 joined #evergreen
16:26 jvwoolf jeff: We are trying to get them to print to a thermal receipt printer. Trying to get it to print the patron barcode on the hold slip. Works without Hatch, but not with.
16:27 jvwoolf We're also on a pretty old version of EG at this point

Results for 2021-01-26

01:56 awitter joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:18 rjackson_isl_hom joined #evergreen
07:51 mantis1 joined #evergreen
08:00 mantis1 joined #evergreen
08:40 mmorgan joined #evergreen
08:50 collum joined #evergreen
09:03 Dyrcona joined #evergreen
09:57 Dyrcona Truncate action_trigger.event and a test of the daily a/t runner goes really fast.
10:00 Christineb joined #evergreen
10:08 Bmagic Dyrcona++ # burn it all down
11:14 Dyrcona Well, it still takes a while to churn through 14,286 events. But collecting them into the table was really fast. :)
11:48 csharp berick: new fix applied to PINES production - so far so good, drone-wise - I'll let you know if we hear complaints
11:53 berick csharp: cool
12:03 jihpringle joined #evergreen
13:01 jeffdavis csharp++ # sometimes you gotta test in production
13:06 csharp jeffdavis: yep, it's the only way to see if something that only emerges in production actually works!
13:36 jeffdavis updated bug 1896285 - I think the 3.5 version is OK to go in rel_3_5
13:36 pinesol Launchpad bug 1896285 in Evergreen 3.5 "Use batch methods for multi-row grid actions" [Medium,Confirmed] https://launchpad.net/bugs/1896285
17:00 Bmagic csharp: JS cache client-side might account for the patch not "taking hold" on some workstations
17:26 mmorgan left #evergreen
17:49 Cocopuff2018 joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:02 book` joined #evergreen
19:04 Dyrcona joined #evergreen
19:09 sandbergja joined #evergreen

Results for 2021-01-25

09:07 alynn26 joined #evergreen
09:24 dbwells joined #evergreen
09:54 mmorgan joined #evergreen
09:54 csharp berick: I was able to test your patch over the weekend and it works as expected - because drone exhaustion was dire this morning, I've applied it to PINES production and am watching carefully
09:54 csharp so far so good though
09:55 csharp if we don't see any problems by noon or so, I'll sign off/commit
09:57 berick csharp++
10:00 Cocopuff2018 joined #evergreen
10:09 JBoyer Hi! If you haven't seen my Dev Meeting Poll on evergreen-dev or evergreen-general, it's here: https://forms.gle/ypTx2zqLbW7eVoj99
15:21 csharp oh?
15:21 berick csharp: it does seem likely the patch is at fault (sigh(
15:23 Dyrcona csharp++ # For boldly going where no Evergreen sysadmin has gone before.
15:24 csharp Dyrcona: all while staying in my living room office for nearly a year!
15:25 csharp berick: I rolled the patch out, but I can apply any fixes to a test server
15:25 csharp working without the patch means I have to babysit all day long
15:26 * berick nods
15:30 mantis1 left #evergreen
15:32 mmorgan So, poking at Curbside, I have hours open set as 2:00pm - 5:30pm, 4 hour appointment slots. As a patron, I'm offered appointments at 2:00am, 6:00am, 10:00am, 2:00pm. Anyone seen this problem?
16:39 rfrasur joined #evergreen
17:19 mmorgan left #evergreen
17:56 Cocopuff2018 joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:47 sandbergja joined #evergreen
21:26 sandbergja joined #evergreen
21:52 JBoyer joined #evergreen

Results for 2021-01-24

06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
13:48 sandbergja joined #evergreen
14:20 sandbergja joined #evergreen
14:50 sandbergja joined #evergreen
16:47 Cocopuff2018 joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
19:20 laurie joined #evergreen
19:55 sandbergja joined #evergreen
20:54 sandbergja joined #evergreen

Results for 2021-01-23

02:12 sandbergja joined #evergreen
04:06 jamesrf joined #evergreen
04:06 JBoyer joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
11:37 sandbergja joined #evergreen
12:32 sandbergja joined #evergreen
13:00 sandbergja joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:45 Cocopuff2018 joined #evergreen
20:56 sandbergja joined #evergreen
21:51 sandbergja joined #evergreen

Results for 2021-01-22

04:15 jamesrf joined #evergreen
04:15 JBoyer joined #evergreen
05:08 dbwells joined #evergreen
06:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:27 rjackson_isl_hom joined #evergreen
07:35 Dyrcona joined #evergreen
07:38 dbwells joined #evergreen
08:59 pinesol Launchpad bug 1901760 in Evergreen "Staff Client Whitescreen on login on all browsers on iOS/Android" [High,Confirmed] https://launchpad.net/bugs/1901760 - Assigned to Jason Stephenson (jstephenson)
09:00 JBoyer Dyrcona++
09:08 Dyrcona Works on my daughter's iPad, too, but I noticed the hamburger menu options appear greyed out or at least very light, though they work. Must be a style.
09:08 csharp seeing an issue only on our production server where the search box on the splash screen for the staff client is apparently double-URL-encoding spaces and creating things that look like "query=harry%2520potter" and showing "harry%20potter" in the search box in the staff catalog
09:09 csharp I've chased things as far as I know how and can't see what's causing it - I'm just stumped and have been for a few days now
09:09 csharp on the other hand, this appears to be the highest-priority issue we have right now after a major upgrade, so there's that :-)
09:10 csharp our test versions running the same code are *not* experiencing the problem and encoding the URL params correctly
09:11 Dyrcona All O/S and package updates applied to both sets of machines?
09:11 csharp yes
09:11 csharp and another factor is that production is on Ubuntu 16.04 and our test machines have been on 18.04
09:12 csharp I went down a rabbit hole fighting with a local VM trying to install OpenSRF last night and haven't resumed
09:12 csharp (on 16.04)
09:13 Dyrcona I guess something recent doesn't like 16.04, but tbh, I've seen weird behavior that just "goes away" after a clean install. (I assume this after an in place upgrade on production.)
09:27 dbwells joined #evergreen
09:28 Bmagic csharp: strange indeed
09:29 csharp Dyrcona: yes - it's an in-place upgrade and we're moving to fresh 18.04 installs very soon
09:30 Bmagic Though, I just wasted almost 2 days working a problem similar. And finally, I decided to setup a whole new test environment, fresh install DB, fresh install Application server, but otherwise identical - and the problem was no longer there! Which was a bad thing, because I couldn't diagnose it
09:30 csharp so you're confirming my working theory - gonna keep going on my 16.04 test install
09:31 csharp it may come down to one of those things where my cautious "don't upgrade too many things at once" strategy means I have problems I wouldn't have seen if I had gone ahead and upgraded OS along with :-/
09:31 Bmagic Right now, the only thing I could think of was memcached on production is caching queries and introducing the difference
09:31 jvwoolf joined #evergreen
09:31 csharp huh - that's interesting
12:34 mmorgan csharp: We have been seeing the same thing on 3.6, we also applied those fixes, but are still seeing the problem.
12:35 csharp mmorgan: good to confirm - thanks
13:11 berick if anyone can track it down i can help fix
13:24 pinesol [evergreen|Bill Erickson] LP1901760 Improve SharedWorker non-support handling (AngJS) - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3c1188f>
13:24 pinesol [evergreen|Bill Erickson] LP1901760 Improve SharedWorker non-support handling (Angular) - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=c9f731f>
13:24 pinesol [evergreen|Bill Erickson] LP1901760 Remove SharedWorker testing cruft - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=66e7e45>
13:27 Dyrcona Y'kinow with that fix that I pushed applied, your users on Android Chrome and iOS devices will not be caching settings and will not have the benefit of the fix for bug 1848550. All it takes is 1 errant client to max out the actor drones.
13:27 pinesol Launchpad bug 1848550 in Evergreen "Cache settings more aggressively in web client" [Undecided,Fix released] https://launchpad.net/bugs/1848550
13:29 berick ok, yeah, it's time for a comprehensive fix.  i'll open a bug to support max-parallel-requests on the client side.
17:00 * berick cleans it up
17:02 berick force-pushed and fixed
17:26 mmorgan left #evergreen
18:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:22 sandbergja joined #evergreen
18:40 jvwoolf joined #evergreen
18:47 jihpringle joined #evergreen

Results for 2021-01-21

02:48 AFloyd__ joined #evergreen
04:26 AFloyd__ joined #evergreen
05:20 rjackson_isl_hom joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:48 alynn26_away joined #evergreen
07:55 mantis1 joined #evergreen
07:57 rfrasur joined #evergreen
11:29 miker I'll sign off yours, JBoyer
11:31 alynn26_away joined #evergreen
12:07 AFloyd__ joined #evergreen
12:16 Dyrcona So, I'm doing an fresh installation and I'm testing opensrf. When I run srfsh, I get "Unable to bootstrap client for requests." Services say they are running. What did I miss?
12:16 JBoyer Huh, didn't realize I had removed the opac tag on that bug. opos.
12:21 jihpringle joined #evergreen
12:21 Dyrcona OK. In my case, I botched the domain parameter in .srfsh.xml.
17:38 Bmagic I'll make the bug report
17:40 berick Bmagic++
17:44 Bmagic berick: bug 1912699
17:44 pinesol Launchpad bug 1912699 in Evergreen "SIP returns multiple AVs in a 64 response message" [Undecided,New] https://launchpad.net/bugs/1912699
17:49 collum joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:34 collum joined #evergreen
19:36 Cocopuff2018 joined #evergreen
19:46 dbwells joined #evergreen

Results for 2021-01-20

00:42 sandbergja joined #evergreen
01:35 sandbergja joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:51 rjackson_isl_hom joined #evergreen
08:18 alynn26 joined #evergreen
08:21 stephengwills joined #evergreen
12:52 Dyrcona Bmagic: You had something like that happen with docker and a host name that started with a number, IIRC.
12:53 Bmagic oh that, yep
12:53 Dyrcona I'm getting this with autogen.sh. I don't think a numeric hostname is my issue.
12:54 Dyrcona I guess I'll break for lunch and look at this later. I may have to set this test up on a different VM.
12:55 Bmagic for me, autogen is where it stopped. The funny thing is that I didn't get an error from autogen. autogen simply hung while apparently waiting for a response. It wasn't until I looked at the logs that I saw the error
12:58 Dyrcona I'll just delete the VM and build a replacement.
13:02 jihpringle joined #evergreen
17:21 jihpringle joined #evergreen
17:32 Dyrcona joined #evergreen
17:36 Dyrcona Oh. Shut the laptop lid without logging out. G'night!
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:15 RBecker joined #evergreen
18:23 dbwells joined #evergreen
18:26 dbwells joined #evergreen

Results for 2021-01-19

01:49 sandbergja joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:57 jeff joined #evergreen
06:59 berick joined #evergreen
06:59 cesardv joined #evergreen
13:01 jvwoolf joined #evergreen
13:04 jvwoolf1 joined #evergreen
13:10 sandbergja joined #evergreen
13:19 Dyrcona Hmm.. Since I'm "downgrading" a test machine from 3.6.1 to 3.5.2, I guess I'll wipe out /openils.
13:31 csharp JBoyer++
13:31 csharp JBoyer: looks like that does it'
13:34 csharp yep - confirmed on multiple searches
17:14 mmorgan left #evergreen
17:32 sandbergja joined #evergreen
17:56 jihpringle joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
22:29 sandbergja joined #evergreen
23:28 Cocopuff2018 joined #evergreen
23:35 sandbergja joined #evergreen

Results for 2021-01-18

01:36 sandbergja joined #evergreen
01:49 ddale joined #evergreen
01:50 ddale We have upgraded to 3.6.1 this weekend. I am working on the curbside pickup feature.  I am wondering how to change an appointment? Is there some place where all appointments can be seen and edited?
06:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:59 rhamby joined #evergreen
08:03 collum joined #evergreen
08:35 collum joined #evergreen
16:52 stephengwills left #evergreen
17:26 dbwells joined #evergreen
17:50 sandbergja joined #evergreen
18:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:04 dbwells joined #evergreen
18:06 dbwells joined #evergreen
18:38 jihpringle joined #evergreen

Results for 2021-01-17

01:12 sandbergja joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
13:31 sandbergja joined #evergreen
13:57 Cocopuff2018 joined #evergreen
15:45 sandbergja joined #evergreen
16:45 sandbergja joined #evergreen
17:01 sandbergja joined #evergreen
17:31 sandbergja joined #evergreen
18:00 pinesol News from qatests: Failed Installing Evergreen pre-requisites - Expected 1 errors but encountered 3. <http://testing.evergreen-ils.org/~live//arch​ive/2021-01/2021-01-17_16:00:02/test.26.html>
20:31 sandbergja joined #evergreen
21:15 sandbergja joined #evergreen
21:20 jweston joined #evergreen

Results for 2021-01-16

14:13 book` joined #evergreen
14:13 RBecker joined #evergreen
14:14 rhamby joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
21:20 sandbergja joined #evergreen
21:30 sandbergja joined #evergreen
21:43 sandbergja joined #evergreen

Results for 2021-01-15

02:42 gryffonophoneme joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:11 stephengwills joined #evergreen
07:13 rjackson_isl_hom joined #evergreen
08:08 ml9l joined #evergreen
17:38 laurie joined #evergreen
17:38 kip joined #evergreen
17:49 rjackson_isl_hom joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:21 Bmagic joined #evergreen
19:14 gryffonophoneme joined #evergreen

Results for 2021-01-14

09:05 rjackson_isl_hom Running into a selfcheck issue at a library trying to use the Get Receipt and Finish option. That never works for them, but the Quick Receipt and Continue does
09:05 rjackson_isl_hom Has anyone run into thisand if so any workarounds?
09:42 mmorgan rjackson_isl_hom: Is this the built in selfcheck? Just tested ours on a training server and Get Receipt and Finish worked. In what way does it not work? Does it just silently fail?
09:43 rjackson_isl_hom according to the reporting library yes - just fails to print
09:43 rjackson_isl_hom likewise tried locally on test server with success from home - printing to a pdf since I have no real printer
09:44 rjackson_isl_hom and yes to the built in self check for Evergreen
09:47 mmorgan rjackson_isl_hom: The selfcheck receipts are action triggers. Could the problem be with the trigger?
09:47 rjackson_isl_hom are they defined with a default and then possibly one per branch if so desired?
09:50 Dyrcona It's sad that consider 8 "not connected to the network" errors in the past half hour to be normal.
11:43 berick yeah, we have a few
11:46 Bmagic I would guess most people do. Those that have been using Evergreen acq for a few years
11:57 Bmagic berick: bug 1911786
11:57 pinesol Launchpad bug 1911786 in Evergreen "EDI Order Pusher needs tighter control over PO selection" [Undecided,New] https://launchpad.net/bugs/1911786
12:19 jihpringle92 joined #evergreen
14:01 sandbergja joined #evergreen
16:30 laurie joined #evergreen
17:21 mmorgan left #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
19:05 Christineb joined #evergreen
19:05 troy__ joined #evergreen
19:05 jeffdavis joined #evergreen

Result pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143