| Time |
Nick |
Message |
| 00:26 |
|
sandbergja joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:57 |
|
Dyrcona joined #evergreen |
| 07:16 |
|
rjackson_isl_hom joined #evergreen |
| 08:12 |
|
mantis1 joined #evergreen |
| 08:36 |
|
mmorgan joined #evergreen |
| 08:48 |
|
mantis1 left #evergreen |
| 08:49 |
mmorgan |
Good morning #evergreen! |
| 08:50 |
mmorgan |
@coffee [someone] |
| 08:50 |
* pinesol |
brews and pours a cup of El Salvador La Montana Pacamara, and sends it sliding down the bar to ejk |
| 08:56 |
|
rfrasur joined #evergreen |
| 09:02 |
Dyrcona |
Hm.. Search results coming up blank on training after a full ingest. Must be a busted template or something like that. |
| 09:31 |
|
dbwells joined #evergreen |
| 09:31 |
|
dbwells joined #evergreen |
| 09:33 |
|
alynn26 joined #evergreen |
| 09:43 |
Dyrcona |
mmorgan sandbergja: We had a new ticket opened this morning that sounds like the cataloging Save & Exit issue that we discussed last week, but I suspect it is a different way to get there. I'm waiting on more details before I open a Launchpad bug. |
| 09:43 |
sandbergja |
Dyrcona++ |
| 09:44 |
mmorgan |
Dyrcona++ |
| 09:44 |
mmorgan |
Got our first report from users of this issue this morning. They characterized the issue as Urgent. |
| 09:57 |
Dyrcona |
The fix for the edit link should be pretty simple. I'm about to try the "obvious" fix on a test vm. I should have something ready this week. |
| 09:59 |
mmorgan |
Dyrcona: Would the fix involve removing that intermediate redirect? |
| 10:02 |
Dyrcona |
mmorgan: I don't think so. I'm just switching from href to onclick. |
| 10:03 |
Dyrcona |
If that doesn't work, then I'll look into more complicated solutions. |
| 10:03 |
berick |
Dyrcona: there are other cases where href works fine |
| 10:03 |
* mmorgan |
nods |
| 10:05 |
Dyrcona |
berick: Well, the edit link is definitely broken and that's the only one I'm looking at for the moment. |
| 10:07 |
berick |
Dyrcona: just saying i have the same edit link in the angular volcopy branch without the redirect and the save+close works fine |
| 10:08 |
berick |
can't hurt to try, but i suspec the redirect is the real problem |
| 10:08 |
Dyrcona |
berick: I'm not looking at Angular catalog. I'm mucking with ttopac. We're not even close to using Angular, yet, here. |
| 10:08 |
Dyrcona |
Well, if I try something simple and it doesn't work, I'll look into eliminating the redirect. |
| 10:09 |
* mmorgan |
has always found that intermediate redirect slow and confusing, just my $.02 |
| 10:13 |
jeff |
I think we're running into this/these: |
| 10:14 |
jeff |
https://bugs.chromium.org/p/chromium/issues/detail?id=1170034 |
| 10:14 |
jeff |
https://bugs.chromium.org/p/chromium/issues/detail?id=1170131 |
| 10:15 |
jeff |
Issue 1170034: Because the error "scripts may close only the windows that were opened by them" confuses users, we should confirm whether the users attempt to close the tab or not, instead of silent error. |
| 10:15 |
jeff |
Issue 1170131: After a |noopener| window performs a same-page navigation to a URL fragment, window.close() is denied |
| 10:15 |
|
mantis1 joined #evergreen |
| 10:16 |
jeff |
I suspect we're not hitting the url fragment / hash variant. |
| 10:20 |
Dyrcona |
jeff: Yes, we are, and window.open works. |
| 10:20 |
Dyrcona |
At least for me. :) |
| 10:25 |
Dyrcona |
jeff: It sounds like I'm disagreeing with you, and saying we're hitting the url fragment issue. We're not hitting that one, but 1170034. (Tryna multitask and failing to parse all data in haste.) |
| 10:28 |
jeff |
I was about to clarify, but I had already reached the conclusion that you were replying to my earlier assertion and not the most recent one. :-) |
| 10:28 |
jeff |
But thanks for clarifying! |
| 10:32 |
Dyrcona |
jeff++ |
| 10:32 |
Dyrcona |
I'm going to try removing the redirect if it isn't too hard. |
| 10:39 |
Dyrcona |
Eh, no. That looks like too much work for what is basically dead code. |
| 10:40 |
JBoyer |
Once more I make the rounds, asking those that would meet to discuss development to please click on this Google Forms link and tell me when you can make it: https://forms.gle/ypTx2zqLbW7eVoj99 |
| 10:40 |
JBoyer |
More Properly: This is the last reminder to please fill out the Developer Meeting time poll at https://forms.gle/ypTx2zqLbW7eVoj99 |
| 10:53 |
|
sandbergja_ joined #evergreen |
| 11:04 |
Dyrcona |
Back on my training search issue: I'm not seeing any template errors in the logs, but something related to badges. |
| 11:05 |
Dyrcona |
And I doubt that is my problem... but... |
| 11:10 |
Dyrcona |
Hm... training isn't logging everything to syslog. I guess I need to fix that. |
| 11:11 |
Dyrcona |
48GB is a bit much to search through. |
| 11:14 |
Dyrcona |
Juggling too many branches and wearing too many hats. |
| 11:26 |
* mmorgan |
admires Dyrcona's wardrobe of hats |
| 11:28 |
mmorgan |
Also want to mention that the intermediate redirect and failure of the holdings editor to close is a problem in both the angular and traditional catalogs |
| 11:30 |
Dyrcona |
Well, I'm thinking that should be its own bug, since the traditional catalog is on the way out, and AFAIAC that is beyond the scope of what I'm trying to fix. |
| 11:44 |
|
jihpringle joined #evergreen |
| 13:16 |
Dyrcona |
Aight....Can't figure out my search problem on training. |
| 14:39 |
Dyrcona |
So, Save & Exit is doing the same thing for me in master. |
| 14:44 |
Dyrcona |
And, my patch doesn't seem to fix it. |
| 15:02 |
|
rfrasur joined #evergreen |
| 15:07 |
mmorgan |
:-( |
| 15:13 |
Dyrcona |
mmorgan | sandbergja: bug 1914114 |
| 15:13 |
pinesol |
Launchpad bug 1914114 in Evergreen "Copy Editor Save & Exit Does Not Always Close the Tab" [Medium,Confirmed] https://launchpad.net/bugs/1914114 |
| 15:13 |
mmorgan |
Dyrcona++ |
| 15:13 |
sandbergja |
Dyrcona++ |
| 15:15 |
Dyrcona |
Well, I guess on master, I was using the new Angular catalog. I suppose I'll edit the bug description to that effect. |
| 15:17 |
jeffdavis |
bug 1913219 |
| 15:18 |
* jeffdavis |
looks significantly at pinesol |
| 15:18 |
jeffdavis |
https://bugs.launchpad.net/evergreen/+bug/1913219 |
| 15:18 |
|
pinesol` joined #evergreen |
| 15:18 |
jeffdavis |
^ duplicate bug? |
| 15:21 |
Dyrcona |
jeffdavis: Yes and no. |
| 15:22 |
Dyrcona |
But, mostly, yes. |
| 15:22 |
Dyrcona |
I swear that bug did not come up when I opened mine. |
| 15:23 |
berick |
fyi we're migrating all of our notices to 3rd party. I posted the code I use to generate the XML files in case it's helpful to anyone. https://github.com/berick/evergreen-xml-notices |
| 15:24 |
berick |
it leverages A/T, but pushes most of the processing to external scripts to avoid the main A/T pitfalls and avoid loads of template duplication. |
| 15:29 |
|
mantis1 left #evergreen |
| 15:29 |
mmorgan |
berick++ |
| 15:29 |
Dyrcona |
I guess 1 duplicat is OK. We've had 5 duplicates of this issue in our internal ticket system since last week. |
| 15:30 |
JBoyer |
Something fun for tomorrow: https://bugs.launchpad.net/evergreen/+bug/1914116 |
| 15:30 |
pinesol |
Launchpad bug 1914116 in Evergreen "An audit of query parameters is needed" [Critical,New] |
| 15:30 |
Dyrcona |
berick: Sounds cool. |
| 15:30 |
JBoyer |
Because without it, all of our point releases will have broken opacs! |
| 15:30 |
JBoyer |
Yay delays, I guess. |
| 15:33 |
Dyrcona |
multitasking-- |
| 15:33 |
Dyrcona |
distractions-- |
| 15:34 |
mmorgan |
Multitasking = multiple tasks worked on, none finished. |
| 15:48 |
|
jihpringle joined #evergreen |
| 15:52 |
Dyrcona |
emergency-closing-- # Slow queries: got one running for 5 hours 45 minutes and another for 6 hours 39 minutes. |
| 15:53 |
Dyrcona |
action.emergency_closing_stage_2_hold |
| 15:54 |
Dyrcona |
I guess if I cancel them, holds won't get updated, but they may not get updated anyway depending on transaction issues, timeouts, and rollbacks. Suppose I should look at the code.... |
| 15:58 |
Dyrcona |
CStore db transactions don't time out do they? The client may time out waiting for the cstore to return, though, right? |
| 16:00 |
|
sandbergja_ joined #evergreen |
| 16:02 |
Dyrcona |
Oh, well. That's a problem for another day. |
| 16:46 |
|
sandbergja_ joined #evergreen |
| 17:05 |
|
mmorgan left #evergreen |
| 17:16 |
|
khuckins joined #evergreen |
| 17:16 |
|
jihpringle joined #evergreen |
| 17:30 |
jeffdavis |
I'll go ahead and push the bug 1896285 fixes to rel_3_5 |
| 17:30 |
pinesol |
Launchpad bug 1896285 in Evergreen 3.5 "Use batch methods for multi-row grid actions" [Medium,Confirmed] https://launchpad.net/bugs/1896285 |
| 17:36 |
jeffdavis |
done |
| 17:37 |
jeffdavis |
I also shared a signoff and followup for bug 1913811 |
| 17:37 |
pinesol |
Launchpad bug 1913811 in Evergreen "Too many parallel open-ils.actor.user.itemsout.notices requests" [High,Confirmed] https://launchpad.net/bugs/1913811 |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:34 |
|
mrisher__ joined #evergreen |
| 19:08 |
|
mrisher joined #evergreen |
| 19:31 |
|
sandbergja_ joined #evergreen |
| 20:27 |
|
sandbergja_ joined #evergreen |
| 21:48 |
|
sandbergja_ joined #evergreen |
| 22:40 |
|
Cocopuff2018 joined #evergreen |
