| Time |
Nick |
Message |
| 00:47 |
|
sandbergja joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:17 |
|
rjackson_isl_hom joined #evergreen |
| 07:19 |
|
rjackson_ils joined #evergreen |
| 07:35 |
|
collum joined #evergreen |
| 08:03 |
|
mantis1 joined #evergreen |
| 08:23 |
|
rjackson_isl joined #evergreen |
| 08:27 |
|
Dyrcona joined #evergreen |
| 08:27 |
|
mmorgan joined #evergreen |
| 08:28 |
|
kip joined #evergreen |
| 08:31 |
|
troy__ joined #evergreen |
| 08:31 |
|
rfrasur joined #evergreen |
| 09:14 |
|
terranm joined #evergreen |
| 09:22 |
terranm |
Good morning everyone - Feedback Fest community test servers are up and running here! https://docs.google.com/spreadsheets/d/1XeRK2oTIIu5pu7iy2ceWbE1ZRBgz9X2W1YC_E6QNexg/edit?usp=sharing |
| 09:34 |
|
dbwells joined #evergreen |
| 09:43 |
|
JMooreWyomissing joined #evergreen |
| 09:48 |
JMooreWyomissing |
Has anyone heard about registration for 2021 Evergreen International Conference? I know it's entirely online this year. Website has a post from late December but no updates since then... |
| 09:55 |
csharp |
JMooreWyomissing: the planners are active in this channel or on the Evergreen email lists (https://evergreen-ils.org/communicate/mailing-lists/) |
| 09:55 |
csharp |
I'm not involved in planning this year, so I don't have additional information at this point |
| 09:58 |
terranm |
Other than it being scheduled for May 24-27, I don't have any other details yet |
| 10:28 |
pinesol |
[evergreen|Terran McCanna] LP1910138 Display Precat Info in Circ History - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=17836cf> |
| 10:28 |
pinesol |
[evergreen|Galen Charlton] LP#1910138: (follow-up) remove unneeded sr-only span in table cell - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b110e1f> |
| 10:30 |
pinesol |
[evergreen|Garry Collum] LP1908298 Bootstrap OPAC: Type filter missing from advanced search - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=35697fe> |
| 10:31 |
|
malexander joined #evergreen |
| 10:52 |
pinesol |
[evergreen|Garry Collum] LP1902265: implement per-hold notification updates in Bootstrap OPAC - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b40e7bc> |
| 10:54 |
pinesol |
[evergreen|Garry Collum] LP1903594 Bootstrap opac: suspend hold not working - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=53888f6> |
| 11:00 |
pinesol |
[evergreen|Jason Boyer] LP1895676: Record Print and Email Enhancements for Bootstrap OPAC - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=75bccb4> |
| 11:14 |
pinesol |
[evergreen|Garry Collum] LP1907866 Bootstrap Opac: fix adding basket to existing List - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=80c089d> |
| 11:19 |
|
terranm joined #evergreen |
| 11:19 |
terranm |
gmcharlt++ Galen is on a roll with 5 signed off patches committed already this morning! |
| 11:34 |
|
Christineb joined #evergreen |
| 11:49 |
terranm |
collum++ for first two signoffs during feedback fest! |
| 11:55 |
|
malexander_ joined #evergreen |
| 12:09 |
mmorgan |
gmcharlt++ |
| 12:09 |
mmorgan |
collum++ |
| 12:09 |
mmorgan |
terranm++ |
| 12:12 |
pinesol |
[evergreen|Jane Sandberg] LP1895678: Bring course materials into the bootstrap OPAC - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6a4b8d9> |
| 12:18 |
pinesol |
[evergreen|Garry Collum] LP1908766 Bootstrap OPAC: Lost ability to have notes in lists. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c7851de> |
| 12:26 |
|
khuckins joined #evergreen |
| 12:33 |
|
jihpringle joined #evergreen |
| 12:46 |
|
malexander__ joined #evergreen |
| 14:59 |
|
malexander_ joined #evergreen |
| 15:29 |
|
sandbergja joined #evergreen |
| 15:34 |
|
mantis1 left #evergreen |
| 15:43 |
|
sandbergja joined #evergreen |
| 16:08 |
|
sandbergja joined #evergreen |
| 16:16 |
jihpringle |
terranm Bmagic: I've run into an issue on Blake's test server - it looks like one of the fixes has broken Circulation Policies but I don't know which one (maybe https://bugs.launchpad.net/evergreen/+bug/1847519 since it's related to circ policies) |
| 16:17 |
pinesol |
Launchpad bug 1847519 in Evergreen "Angular: Local Admin Circulation Limit Set Port" [Wishlist,Confirmed] |
| 16:17 |
jihpringle |
I have other fixes on the server that I'd like to sign off on but I don't want to sign off if they break Circulation Policies |
| 16:17 |
jihpringle |
no matter what I do I can't save a new policy, but I can create a new one on Tiffany's test server |
| 16:26 |
|
dbwells joined #evergreen |
| 16:30 |
|
dbwells joined #evergreen |
| 16:32 |
terranm |
jihpringle: Thanks, I'll email Blake since it looks like he's not logged into IRC right now |
| 16:33 |
jihpringle |
thanks terranm: I'm now three for three with fixes not working quite right on that server |
| 16:33 |
terranm |
:) |
| 16:36 |
csharp |
jihpringle: I have that patch installed on current master on my test server: csharp-master.gapines.org/eg/staff admin/demo123 |
| 16:36 |
csharp |
it's isolated, so you should be able to just test it |
| 16:36 |
jihpringle |
thanks, I'll give it a try :) |
| 16:38 |
csharp |
I know it's more efficient to bundle the test patches on each server, but sometimes testing one at a time is necessary for due diligence |
| 16:40 |
|
sandbergja joined #evergreen |
| 16:40 |
jihpringle |
thanks csharp I can't create new circ policies on your server either so looks like it is that patch causing issues |
| 16:48 |
|
jihpringle joined #evergreen |
| 16:51 |
csharp |
jihpringle++ |
| 17:04 |
csharp |
huh - looking at it though, I don't see how the Angular change would affect dojo - going to try installing stock master and try to add a policy |
| 17:05 |
csharp |
seeing "Uncaught Transaction begin error" in the console |
| 17:07 |
|
mmorgan left #evergreen |
| 17:12 |
|
terranm joined #evergreen |
| 17:16 |
csharp |
jihpringle: confirmed on master - I can't create a new circ policy as admin |
| 17:16 |
jihpringle |
glad it's not just me :) |
| 17:16 |
csharp |
so, um, I guess it's not related to mrisher's stuff but we need to be able to add those to test mrisher's stuff :-/ |
| 17:17 |
jihpringle |
weirdly it worked on Tiffany's server though |
| 17:17 |
csharp |
that's interesting |
| 17:19 |
csharp |
slightly different master, looks like - that points to a recent change causing the issue |
| 17:23 |
csharp |
yeah, confirmed working on tiffany-master - hmm |
| 17:27 |
JBoyer |
csharp, jihpringle I don't suppose the RemoteIP settings in your respective eg_vhost.conf files? I thought I've seen that caused similar problems in the past. |
| 17:27 |
csharp |
JBoyer: good point - I'll look |
| 17:28 |
JBoyer |
I apparently didn't finish that thought. I don't suppose those settings are un-commented and set correctly? - That's somewhat more English than before. |
| 17:28 |
csharp |
heh |
| 17:29 |
csharp |
JBoyer: I can confirm that they are correct on tiffany-master and *not* on csharp-master |
| 17:29 |
JBoyer |
That's a good sign! |
| 17:29 |
|
dbwells joined #evergreen |
| 17:30 |
csharp |
rebuilding master on my server now, then we'll be able to test mrisher's fix :-) |
| 17:30 |
JBoyer |
And also a big question mark, because I've only seen that happen in dojo interfaces and Angular ones seemed to be immune. Maybe that's a cstore / pcrud difference. |
| 17:30 |
csharp |
dojo-- |
| 17:30 |
csharp |
dojo--\ |
| 17:30 |
csharp |
dojo--\ |
| 17:30 |
csharp |
dojo-- |
| 17:31 |
csharp |
@karma dojo |
| 17:31 |
pinesol |
csharp: Karma for "dojo" has been increased 0 times and decreased 5 times for a total karma of -5. |
| 17:31 |
csharp |
dojo-- |
| 17:34 |
csharp |
JBoyer++ #confirmed working |
| 17:34 |
JBoyer |
csharp++ |
| 17:34 |
JBoyer |
Nice. |
| 17:35 |
jihpringle |
JBoyer++ csharp++ |
| 17:36 |
csharp |
ok - reapplying the patch on my server - we'll see what happens :-) |
| 17:39 |
dluch |
JMooreWyomissing: The conference committee will be sending out more information on Wednesday. Stay tuned! |
| 17:43 |
csharp |
ok, jihpringle, you're up if you want to test again (make sure to log out and register a new workstation - I take the nuclear approach when I rebuild my server :-) ) |
| 17:43 |
jihpringle |
will do, thanks csharp |
| 17:50 |
jihpringle |
csharp everything looks good! I'll sign off on the patch |
| 17:50 |
jihpringle |
thanks! |
| 17:51 |
csharp |
jihpringle++ |
| 17:52 |
gmcharlt |
berick: around? |
| 17:52 |
|
awitter joined #evergreen |
| 17:52 |
berick |
gmcharlt: hey what's up? |
| 17:54 |
gmcharlt |
berick: re 1908743, I've got it working, though it needed a followup to munge the OU value (otherwise false would come over as "false") |
| 17:54 |
gmcharlt |
however, I see a difference as compared to the embedded OPAC regarding can_have_users OU types |
| 17:54 |
gmcharlt |
i.e., the OPAC would allow a pickup location that allows users but not items |
| 17:55 |
berick |
gmcharlt: ah, that change was not intentional |
| 17:55 |
gmcharlt |
whereas the version in your patch disables OUs either can_have_users or can_have_copies is false |
| 17:57 |
berick |
i can repatch or sign off on a repatch |
| 17:57 |
gmcharlt |
so to confirm, OU whsoe types permits users but not items is intended as a valid pickup location? |
| 17:57 |
gmcharlt |
I can see that as valid - e.g., a location that has no collection but does have a hold pickup service - but I wanted to confirm |
| 17:58 |
pastebot |
"gmcharlt" at 168.25.130.30 pasted "berick: please go ahead and repatch; here is the additional change needed" (12 lines) at http://paste.evergreen-ils.org/10100 |
| 17:59 |
berick |
gmcharlt: thanks, will do. |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:05 |
pinesol |
[evergreen|Garry Collum] LP1908113: link carousel titles in Bootstrap OPAC - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=343a720> |
| 18:06 |
pastebot |
"berick" at 168.25.130.30 pasted "hold org select" (8 lines) at http://paste.evergreen-ils.org/10101 |
| 18:06 |
berick |
gmcharlt: hm, looking at the tpac code, i think it's doing the opposite of what you said, no? |
| 18:06 |
berick |
can_have_vols_only=1 but no can_have_users_only flag |
| 18:09 |
gmcharlt |
which I read as OU's type does not allow volumes == OU is disabled in the selector |
| 18:10 |
gmcharlt |
i.e., IF can_have_vols_only AND org_unit.ou_type.can_have_vols != 't'; |
| 18:10 |
gmcharlt |
whereas it's ignoring can_have_users entirely |
| 18:13 |
* gmcharlt |
searches for caffeine |
| 18:14 |
berick |
:) |
| 18:15 |
berick |
ok, yeah, i'll just make it match the tpac. disable if can-have-vols === false |
| 18:16 |
gmcharlt |
berick: yeah, you were right that I was misreading the code, but checking can_have_users at all does remain a discrepancy |
| 18:17 |
berick |
I'll remove my can_have_users check |
| 18:18 |
gmcharlt |
adding a can_be_pickupup_lib to aout may be a good idea in the future, regardless, given the existance of pickup-only machines and lobbys |
| 18:18 |
berick |
agreed |
| 18:19 |
* gmcharlt |
stares at "lobbys", and really does go off in search of caffeine |
| 19:27 |
|
jihpringle joined #evergreen |
| 19:50 |
|
mantis1 joined #evergreen |
| 19:51 |
|
mantis1 left #evergreen |
| 21:34 |
|
sandbergja joined #evergreen |
| 21:58 |
|
sandbergja joined #evergreen |
| 22:28 |
|
Christineb joined #evergreen |
| 22:38 |
|
sandbergja joined #evergreen |
