| Time |
Nick |
Message |
| 00:00 |
|
jonadab joined #evergreen |
| 02:19 |
|
yar joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:23 |
|
rjackson_isl_hom joined #evergreen |
| 08:01 |
|
kip joined #evergreen |
| 08:01 |
|
jweston joined #evergreen |
| 08:01 |
|
mantis1 joined #evergreen |
| 08:20 |
|
collum joined #evergreen |
| 08:22 |
|
rfrasur joined #evergreen |
| 08:32 |
|
Dyrcona joined #evergreen |
| 08:37 |
|
alynn26 joined #evergreen |
| 08:37 |
|
mmorgan joined #evergreen |
| 09:23 |
|
jvwoolf joined #evergreen |
| 10:05 |
Dyrcona |
@weather |
| 10:05 |
pinesol |
Dyrcona: Error: Failed to load Wunderground API. Check the logs for more information. |
| 10:05 |
Dyrcona |
@wunder |
| 10:05 |
pinesol |
Dyrcona: I see nothing, I know nothing! |
| 10:05 |
Dyrcona |
Ah well, it's cold. |
| 10:24 |
* Dyrcona |
thinks he should have split that log that he just put on the fire. |
| 10:29 |
|
jvwoolf1 joined #evergreen |
| 10:31 |
Bmagic |
fire++ |
| 10:36 |
|
Cocopuff2018 joined #evergreen |
| 10:40 |
|
rfrasur joined #evergreen |
| 10:41 |
|
mantis2 joined #evergreen |
| 10:59 |
Dyrcona |
Writing the live tests sometimes takes longer than writing/modifying the original code. |
| 11:26 |
rhamby |
jboyer noting that while investigating the old zazzle storefront connected to the SFC that it still exists and has a $0.15 balance on it |
| 11:26 |
rhamby |
I don't have access to the SFC email but I'm going to remove the Evergreen designs |
| 11:46 |
|
sandbergja joined #evergreen |
| 11:50 |
Dyrcona |
Anyone else dealt with this: ...in Evergreen holdings editor, the tab no longer closes after clicking the "Save & exit" button? |
| 11:50 |
Dyrcona |
Seems to be sporadic. |
| 11:51 |
berick |
Dyrcona: it can happen if the tab was opened directly from a URL instead of a window.open() from another tab. |
| 12:00 |
mmorgan |
Dyrcona: We found that behavior is a signal that the item did not save. Are the items saving successfully? |
| 12:05 |
Dyrcona |
mmorgan: I'm told that the items do save |
| 12:06 |
* mmorgan |
nods |
| 12:07 |
Dyrcona |
"If you go to the record page with all the tabs and refresh the page the revisions show up" |
| 12:07 |
Dyrcona |
berick: Any idea why that happens? |
| 12:08 |
berick |
Dyrcona: why what happens, going directly to the URL? |
| 12:09 |
Dyrcona |
Yeah, why the tab won't close if opened by a URL? Let me guess... noopener? |
| 12:10 |
berick |
oh, the browser won't allow it. JS can't close it if the JS didn't open it, in short. |
| 12:11 |
berick |
via window.open() |
| 12:12 |
berick |
or at least opened via click from another tab |
| 12:16 |
Dyrcona |
So, to fix, we'd have to modify all of the links that open holdings maintenance to use JavaScript's window.open. |
| 12:19 |
berick |
Dyrcona: no, the existing links should work fine |
| 12:19 |
berick |
the scenario I'm describing should not happen under normal condiations, just when manually sharing URL's |
| 12:19 |
berick |
e.g. debugging |
| 12:20 |
berick |
the other explanation is a JS error |
| 12:21 |
mmorgan |
Dyrcona: berick: Just was able to see this behavior in the client on a test server. |
| 12:22 |
Dyrcona |
mmorgan: Console output? I won't actually take a look until next week some time. |
| 12:23 |
mmorgan |
Don't see any errors in the console. |
| 12:24 |
mmorgan |
I do see this warning, though: app.js:2080 Scripts may close only the windows that were opened by them |
| 12:24 |
mmorgan |
That enough to go on? |
| 12:24 |
berick |
mmorgan: can you describe the steps taken to get to the page? |
| 12:26 |
mmorgan |
Retrieve a bib in the staff catalog, click on Edit for an existing item. New tab opens, first flashes item status, then holdings editor loads. |
| 12:27 |
mmorgan |
Make an edit to the item, click Save and Exit. The edit screen clears of item info, but the tab remains open. |
| 12:36 |
berick |
thanks mmorgan |
| 12:37 |
berick |
ok so there's an intermediate redirect that goes catalog => item status page => edit page (as you noted) |
| 12:38 |
berick |
that redirect breaks it |
| 12:38 |
berick |
fwiw, not an issue with bug 1888723 |
| 12:38 |
pinesol |
Launchpad bug 1888723 in Evergreen "Holdings and Item Attributes Editors (VolCopy) Angular Port" [Wishlist,New] https://launchpad.net/bugs/1888723 |
| 12:38 |
berick |
but could also be fixed in the angjs code, I'm sure |
| 12:40 |
mmorgan |
Just FYI, the same redirect happened in the angjs version, but the tab closed after clicking Save and Exit |
| 12:41 |
berick |
I justed tested the 'legacy' catalog, and it also has the same problem |
| 12:42 |
berick |
it only happens from the 'opac view' though, since that one requires the redirect |
| 12:43 |
mmorgan |
Oh, I see that, too, now. Prior to 3.6, the tab would close after clicking Save and Exit. |
| 12:45 |
berick |
mmorgan: i'd be surprised if that were true, the redirect has always been there when jumping from the opac view. i could be wrong... |
| 12:49 |
Dyrcona |
We're on 3.2.10, but we've backported a few things, though I don't think anything related to this. I could check the code, though. |
| 12:50 |
* mmorgan |
may be thinking of the Add Holdings workflow. |
| 12:51 |
mmorgan |
We had lots of problems wth item templates when we first migrated to the web client. Whether the tab closed or not was an indication that the item saved (or not) and pointed to a template problem. |
| 12:53 |
mmorgan |
Dyrcona: It sounds like this is a new ticket, suggesting a change in behavior, no? |
| 13:01 |
Dyrcona |
mmorgan: Yes, I'm about to look through recent commits in our production branch to see what changed. The most recent patch we applied was for the shared workers to cache settings. I don't think that should have affected cataloging. |
| 13:04 |
Dyrcona |
We also recently upgraded all of production to Ubuntu 18.04, but that should not be related, either. |
| 13:23 |
Dyrcona |
Chrome 88 was released on January 19th which coincides with the first day that our users were back after our server upgrade on January 18. I was going to check the bug fixes, but "This bug tracker is currently unavailable due to database issues." |
| 13:24 |
mmorgan |
:-/ |
| 13:28 |
Dyrcona |
"Waiting for bugs.chromium.org...." You'd think Google could at least run a decent bug site. |
| 13:30 |
Dyrcona |
Search isn't working on my test vm.... |
| 13:32 |
Dyrcona |
I should read Paolo Coelho because a) a friend once told me that I should and b) I always pick on him for testing cataloging. |
| 13:35 |
Dyrcona |
OK, so save & exit works for me on my test vm with Chrome 88 using the Add Holdings button from the record summary. |
| 13:40 |
jeffdavis |
My usual test subject is "Martin Chuzzlewit" because it's widely available, yet never popular enough to be a problem if you screw something up. |
| 13:43 |
Bmagic |
Is there a cancel order option that will subsequently delete any and all of the associated copies in asset.copy? |
| 13:44 |
Dyrcona |
jeffdavis++ # I'm using a test vm, so no danger in screwing something up. |
| 13:45 |
Dyrcona |
Following mmorgan's steps, I get "Scripts may close only the windows that were opened by them" in the console, but the save works. |
| 13:45 |
Dyrcona |
If I edit from the Holdings View, then Save & Exit works as expected. |
| 13:46 |
Dyrcona |
I'm gonna try with Firefox, next. |
| 13:46 |
Dyrcona |
Bmagic: I have no idea. |
| 13:47 |
Bmagic |
Dyrcona: reading Order.pm, lol |
| 13:54 |
Dyrcona |
Bleh..... I hate browsers. I fat palmed my touchpad while typing and all of a sudden I'm on a different ticket in our ticket system and I've lost everything that I was typing into the ticket update box. |
| 13:55 |
* Dyrcona |
recreates his notes in a text editor to copy and paste later. |
| 14:05 |
Dyrcona |
Firefox is the same as Chrome. Everything but the steps mentioned by mmorgan above (http://irc.evergreen-ils.org/evergreen/2021-01-29#i_472877) work as expected. |
| 14:32 |
sandbergja__ |
Dyrcona: mmorgan: we're seeing the same issue when we try to use the Edit link in the OPAC, and the holdings editor doesn't close on Save and Exit". We're on 3.4.2 with curbside added. Let me know when you add it to lp |
| 14:39 |
|
alynn26_away joined #evergreen |
| 15:40 |
|
mantis2 left #evergreen |
| 15:44 |
Dyrcona |
I love it when they tell me that "this is new behavior" when I know for a fact that it can't be. |
| 15:51 |
Dyrcona |
sandbergja__: I'm not necessarily going to add it to Lp. If I come up with a local fix, then maybe I will. |
| 15:55 |
jeffdavis |
with the existing batch action fixes applied, open-ils.actor.user.itemsout.notices seems to be our next biggest culprit for parallel requests exhausting open-ils.actor drones |
| 15:56 |
berick |
jeffdavis++ chipping away |
| 15:57 |
jeffdavis |
One day I'll get all these moles whacked. :) |
| 16:04 |
* mmorgan |
always defers to the folks that use the client every day when they report new behavior :-/ |
| 16:08 |
Dyrcona |
Well, I said on the ticket that if it is new behavior, then it is caused by browser updates, not changes in Evergreen. |
| 16:11 |
mmorgan |
Certainly likely! |
| 16:11 |
jeffdavis |
bug 1913811 |
| 16:11 |
pinesol |
Launchpad bug 1913811 in Evergreen "Too many parallel open-ils.actor.user.itemsout.notices requests" [Undecided,New] https://launchpad.net/bugs/1913811 |
| 16:12 |
jeffdavis |
Any objections to using "parallel-requests" as a tag for these bugs? |
| 16:13 |
Dyrcona |
Is just parallel OK? I think parallel-requests is kind of long. |
| 16:14 |
Dyrcona |
I guess parallel is vague, though. |
| 16:15 |
Dyrcona |
jeffdavis: I'm OK with it. |
| 16:17 |
berick |
works for me |
| 16:20 |
jeffdavis |
thanks, done |
| 16:27 |
Dyrcona |
Well, I managed to write 10 test today, though I guess some of the test are not for the actual functionality of the new code. |
| 16:29 |
Dyrcona |
I think I'll remove some of the tests on Monday. We don't need to keep testing login and workstation registration, though I'll BAIL_OUT if those fail. |
| 16:31 |
mmorgan |
Dyrcona: berick: sandbergja__: So I was just on a meet with my colleague who supports cataloging and had her test whether the holdings editor window closed or stayed open after hitting Save and Exit. |
| 16:32 |
mmorgan |
She reported that it closed, and I asked her to check her Chrome version, it was 87.xxxx. After she updated Chrome to 88.xxx, she is now seeing the behavior where the holdings editor tab does not close. |
| 16:33 |
mmorgan |
So, yeah, Chrome :-( |
| 16:37 |
berick |
huh |
| 16:37 |
Dyrcona |
mmorgan++ |
| 16:38 |
berick |
more strict re: the redirect, i guess |
| 16:38 |
berick |
mmorgan++ indeed |
| 16:38 |
mmorgan |
bwillis++ actually, but she's rarely in IRC |
| 16:39 |
Dyrcona |
bwillis++ |
| 16:39 |
Dyrcona |
I'll see if I can fix it next week. |
| 16:40 |
mmorgan |
Dyrcona++ |
| 16:40 |
sandbergja__ |
Dyrcona++ |
| 16:41 |
sandbergja__ |
let me know if I can help; our cataloger is really excited to get "Save & Exit" exiting again |
| 16:43 |
Dyrcona |
sandbergja__: OK. I'll let you know when I bug it on Lp. |
| 16:49 |
|
sandbergja joined #evergreen |
| 17:15 |
|
mmorgan left #evergreen |
| 17:26 |
|
Christineb joined #evergreen |
| 17:45 |
jeffdavis |
Sounds like we're seeing the Save & Exit issue too on 3.5. |
| 17:48 |
Christineb |
for me it only happens if I open the holdings editor via OPAC View -> Edit |
| 17:51 |
jeffdavis |
Bill mentioned that there's an intermediate redirect involved when you take that specific route, which seems to be what Chrome is objecting to. |
| 18:01 |
pinesol |
News from qatests: Failed Installing Evergreen pre-requisites - Expected 1 errors but encountered 3. <http://testing.evergreen-ils.org/~live//archive/2021-01/2021-01-29_16:00:02/test.26.html> |
| 19:58 |
|
alynn26 joined #evergreen |
| 21:10 |
|
alynn26 joined #evergreen |
| 22:30 |
|
sandbergja joined #evergreen |
| 23:36 |
|
sandbergja joined #evergreen |
