| 12:47 |
Dyrcona |
configure: error: "pgsql driver not installed?" |
| 12:47 |
Dyrcona |
See 'config.log' for more details |
| 12:50 |
|
mantis joined #evergreen |
| 12:52 |
mantis |
does anyone enable Global Flags related to ingest? We started giving it a try in our test server but our cataloger can't delete any records |
| 12:52 |
mantis |
we enabled ingest.queued.biblio.all, |
| 12:52 |
mantis |
ingest.queued.biblio.insert, and ingest.queued.biblio.update - not sure if that's overkill with .all enabled |
| 12:53 |
mantis |
sorry also the .delete flag |
| 13:06 |
Dyrcona |
mantis: maybe there's a cron job required for queued ingest? I don't remember. |
| 13:07 |
Dyrcona |
./config.log:configure:14202: gcc -qversion >&5 |
| 13:07 |
Dyrcona |
./config.log:gcc: error: unrecognized command-line option '-qversion'; did you mean '--version'? |
| 13:13 |
mantis |
just wondering if it's needed at all |
| 13:37 |
Dyrcona |
mantis: Our production version doesn't have that feature. |
| 13:43 |
Dyrcona |
The libdbi packages are installed, so it's a change in behavior in GCC. |
| 13:51 |
Dyrcona |
OK! I fixed the test for libdbi. However, since we're looking for a dbi package, we can probably remove the test from configure.ac. |
| 13:52 |
Dyrcona |
I think this should be a different bug from Lp 1325054. |
| 13:52 |
pinesol |
Launchpad bug 1325054 in Evergreen "libdbi deprecation warnings when building Evergreen" [High,Confirmed] https://launchpad.net/bugs/1325054 |
| 13:53 |
Dyrcona |
Now that I've fixed that a check libpcre fails. |
| 10:33 |
Dyrcona |
I added the filters in the implementation_config of the institution as shown in the example. I restarted SIPServer, but it's not redacting the field. |
| 10:33 |
Dyrcona |
OK. Maybe my SIPServer is too old on this system. |
| 10:34 |
Dyrcona |
Bingo. |
| 10:42 |
Dyrcona |
I was missing the one commit that I was trying to test. :) |
| 10:43 |
Dyrcona |
That also means this virtual machine is older than I thought. |
| 10:51 |
|
sandbergja joined #evergreen |
| 10:53 |
sandbergja |
eeevil: your fix for bug 2125510 has some ng lint issues, could you please fix them (see https://github.com/evergreen-library-system/Evergreen/actions/runs/18142067027/job/51635123330)? Thank you! |
| 15:52 |
Dyrcona |
Can't use an undefined value as an ARRAY reference at /usr/local/share/perl/5.34.0/OpenILS/Application/Vandelay.pm line 136. |
| 15:52 |
Dyrcona |
We really should check that there is a value, and it an array reference before trying to dereference it. |
| 15:53 |
Dyrcona |
Line 136: if ($e->search_vandelay_bib_queue( {name => $name, owner => $owner, queue_type => $type})->[0]) |
| 16:05 |
Dyrcona |
Did anyone test the background import manager? |
| 16:08 |
csharp_ |
Dyrcona: we're using the background import manager - haven't heard of problems lately |
| 16:09 |
csharp_ |
(3.14.3-ish) |
| 16:12 |
csharp_ |
looking at nvm with an eye on how we're installing nodejs: https://github.com/nvm-sh/nvm |
| 12:52 |
Dyrcona |
Interesting stuff: Looks like we've got some race conditions with patron updates and deletes, but those are rare. I've 1 setting and 2 "penalties" added to deleted patrons with timestamps right around the delete time. |
| 13:11 |
Dyrcona |
I might split this up into multiple bugs.... |
| 13:23 |
|
mantis joined #evergreen |
| 13:26 |
mantis |
had a question about the patron_loader.pl. I'm testing it out with a csv that has cardnumber, usrname, profile, home_library, family_name, first_given_name filled out. These are completely new patrons. When running the script, I get these kinds of errors: line 6 could not find valid profile, id: none, column: 2 for 55555264687 |
| 13:27 |
mantis |
the way I'm reading it is there's no id which I'm assuming is for the actor.usr table |
| 13:27 |
mantis |
btw the barcodes are just made up numbers |
| 13:28 |
mantis |
I also get this error that shows with the --debug: parameters: 1758561898,line 2 could not find valid home library, id: none, column: WDBURY for 55555264683,0,117 |
| 13:31 |
|
jvwoolf joined #evergreen |
| 13:35 |
jeffdavis |
looks to me like the missing id's in question are the profile (permission.grp_tree.id) and home_library (actor.org_unit.id) |
| 13:36 |
jeffdavis |
i.e. that either your data contains profile and home lib values that aren't valid for the EG system you're running this on, or they weren't mapped successfuly to valid values |
| 13:54 |
sandbergja |
I believe the profile should be the actual name of the profile (e.g. Patrons) |
| 13:54 |
sandbergja |
based on this sample in the code base: https://github.com/evergreen-library-system/Evergreen/blob/main/Open-ILS/src/perlmods/live_t/data/patrons-to-import.csv |
| 13:54 |
sandbergja |
(^ mantis) |
| 13:55 |
mantis |
ok so I was right about the shortcode |
| 13:55 |
mantis |
thank you! |
| 13:55 |
mantis |
I might update the current docs to reflect this if the test passes |
| 13:55 |
sandbergja |
that would be great! |
| 13:59 |
sandbergja |
full credit goes to Rogan for that sample CSV |
| 13:59 |
mantis |
the script did process, but I don't see the patrons in the actor.usr table |
| 13:28 |
mantis1 |
one question for those who use EDI - does anyone know how to reactiviate a PO? |
| 13:32 |
|
jihpringle joined #evergreen |
| 13:41 |
mantis1 |
we're also running into a problem where a file name is not producing, and based on the error message, this seems to be stemming from Evergreen and not the account setup or connection. Does anyone know how the filename is produced? That might give us a good start on where to look. |
| 14:12 |
Dyrcona |
Well, related to acquisitions, I want to ask if anyone is using the Angular acq and having trouble running out of acq drones? We've had 1 person doing some basic stuff in acq on our test system, and we've gotten no children available with 35 drones. |
| 14:13 |
Dyrcona |
mantis1: I can't answer your questions off the top of my head, but what does the error say? |
| 14:17 |
sleary |
Dyrcona bug 2003973 maybe? |
| 14:17 |
pinesol |
Launchpad bug 2003973 in Evergreen "Embedded copy attrs eats acq and actor drones" [High,New] https://launchpad.net/bugs/2003973 |
| 14:42 |
Bmagic |
mantis1: you can issue a command on the command line on your utility server to debug a certain message or resend a certain message. I'll get the incantations, just a minute |
| 14:42 |
Bmagic |
edi_order_pusher.pl --teset-mode --po-id <POID> |
| 14:43 |
Bmagic |
uhhg |
| 14:43 |
Bmagic |
edi_order_pusher.pl --test-mode --po-id <POID> |
| 14:43 |
csharp_ |
not teset mode! that's the worst mode! |
| 14:43 |
Bmagic |
:) |
| 14:43 |
Bmagic |
you can ask it to be more verbose to help diagnose: |
| 14:46 |
Bmagic |
then you can update the status like this: UPDATE acq.edi_message set status='retry' where id=<DISCOVERED ID FROM STEP ONE> ; |
| 14:47 |
Bmagic |
then you can run the order pusher again to resend just that one: edi_order_pusher.pl --po-id <POID> --verbose |
| 14:49 |
Bmagic |
it goes without saying: be careful with update queries on production. It's a good idea to use psql command line, and put the update inside of a transaction by using BEGIN; first |
| 14:50 |
mantis1 |
Bmagic: ran the test mode pusher and got back a crazy looking string |
| 14:50 |
Bmagic |
lol, I see that teset poisoned my paste a bunch. |
| 14:50 |
csharp_ |
mantis1: can you paste it somewhere like pastebin.com? |
| 14:51 |
Bmagic |
mantis1: that's the EDI message. If you were a computer it would make sense :) Suffice it to say:t that's expected and probably what the vendor needs in order to get the order started |
| 14:55 |
Bmagic |
try putting this at the beginning of your command: export FTP_PASSIVE=1 && |
| 14:56 |
mantis1 |
mmorgan: we were and confirmed it was what they need |
| 14:56 |
csharp_ |
the line is eval { $filename = $self->_ftp->put(@{$self->{put_args}}) }; |
| 14:56 |
mantis1 |
Bmagic: for the test mode again? |
| 14:56 |
csharp_ |
so at that point $self->_ftp is undefined |
| 14:57 |
Bmagic |
the whole thing would be "export FTP_PASSIVE=1 && edi_order_pusher.pl --po-id 67414" |
| 14:57 |
Bmagic |
It's not going to retry until you update the row in the DB as described above |
| 15:03 |
mantis1 |
and the date updated to today |
| 15:03 |
Bmagic |
It sounds like you need to edit your cron jobs and make sure export FTP_PASSIVE=1 && is prefixed on your fetcher/pusher command |
| 15:04 |
mantis1 |
we also don't have a filename producing in the GUI either |
| 15:04 |
Bmagic |
still seeing an error? In the logs? Was that error generated for your manual test? |
| 15:04 |
mantis1 |
I'm seeing the error within the GUI |
| 15:04 |
mantis1 |
under EDI Messages |
| 15:05 |
mantis1 |
it's updated with the retry status though |
| 15:02 |
terranm |
#info terranm = Terran McCanna, PINES |
| 15:02 |
shulabramble |
if so, it's going under New Business. |
| 15:02 |
abneiman |
I did add something to the agenda, but it was not my existential crisis |
| 15:02 |
shulabramble |
abneiman++ thanks for the heads up |
| 15:03 |
shulabramble |
latecomers can continue introductions |
| 15:03 |
shulabramble |
#topic Action Items from Last Meeting |
| 15:03 |
shulabramble |
#topic sleary and sandbergja will report further progress on test writing wiki pages next month |
| 15:04 |
sleary |
you may have noticed that we've been adding custom lint rules (and I have one more in the works) |
| 15:04 |
sleary |
info on lint: https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa#angular_lint |
| 15:04 |
sleary |
there's a link there to a commit that can be checked out to use as a template for writing your own rules |
| 15:04 |
sandbergja |
I also have a question for the group: we used to have a twice-daily update from the test-runner about whether tests were passing or failing. That came to this IRC channel. |
| 15:04 |
shulabramble |
sleary++ |
| 15:05 |
sandbergja |
would anybody find that (or something similar) useful? |
| 15:06 |
* mmorgan |
would say Yes. |
| 15:07 |
shulabramble |
sandbergja++ |
| 15:08 |
mmorgan |
sandbergja++ |
| 15:08 |
mmorgan |
sleary++ |
| 15:09 |
shulabramble |
do y'all want to report on this again next month, or do you feel like the test-writing wiki page is good as of now? |
| 15:09 |
sandbergja |
I could go either way |
| 15:09 |
sandbergja |
sleary? |
| 15:09 |
sleary |
I think we will have a discussion item later about using git hooks, but that can be a separate agenda item |
| 15:24 |
shulabramble |
sleary++ |
| 15:24 |
Bmagic |
signoff rather |
| 15:25 |
shulabramble |
#topic there are several high priority bugs with pull requests that need review; https://wiki.evergreen-ils.org/doku.php?id=dev:code_review has the roundup as well as some filtered Launchpad links. |
| 15:26 |
sleary |
I'm sure a bunch of those are OPAC accessibility bugs. I'll be happy to answer any questions about how to test those once bug 2122448 is behind us. |
| 15:26 |
pinesol |
Launchpad bug 2122448 in Evergreen "Clearing the shelving location in the holdings editor crashes the browser" [Critical,Confirmed] https://launchpad.net/bugs/2122448 - Assigned to Stephanie Leary (stephanieleary) |
| 15:26 |
shulabramble |
sleary++ |
| 15:27 |
shulabramble |
If there's no more new business, then -- |
| 09:36 |
* Dyrcona |
gives it a try with snakeoil.pem. |
| 10:30 |
pinesol |
News from commits: LP#2096672: Simple Reports template folder <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f8113a263db93843466d06e27c1b920d08817f30> |
| 11:01 |
|
sandbergja joined #evergreen |
| 11:05 |
Dyrcona |
Whee! Got postgres_openssl to work with rust at least for my test database. |
| 11:17 |
Dyrcona |
TLS doesn't work with ssh tunnels. I get a hostname mismatch with the certificate. That's good to know, but TLS should also not be needed with a ssh tunnel. :) |
| 11:23 |
Dyrcona |
Added an option to set sslmode and I can connect over a ssh tunnel by setting it to "disable." :) |
| 11:26 |
Dyrcona |
Rust is OK as far as languages go. :) |
| 15:23 |
Dyrcona |
ok, gonna be more "rustic" this time around. less perly. |
| 15:29 |
|
mantis1 left #evergreen |
| 15:31 |
pinesol |
News from commits: Docs: Resolves LP#2121614 <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4d508431a6b10c00c007af3ef09c3c6d45c9328e> |
| 16:11 |
Bmagic |
eeevil++ # I'll give that branch some testing |
| 16:16 |
eeevil |
Bmagic: cool, thanks. note: the way the message bus is set up has changed significantly. please take a look at the new stuff in osrf_control, and note too the new way that the redis default user password is set up in /etc/redis/redis.conf via the "requirepass" setting (see: `osrf_control --help|less` for info, along with the commit message and docs changes) |
| 16:45 |
Bmagic |
eeevil: thanks for pointing that out, will do! |
| 17:00 |
|
mmorgan left #evergreen |
| 12:06 |
* sleary |
points a sonic screwdriver at pinesol |
| 12:14 |
Dyrcona |
eeevil: Do you think authority_authority_linker.pl would work in parallel? |
| 12:16 |
eeevil |
Dyrcona: today, pre-THAT-patch, I assume you mean? hrm... it should be able to in theory, because it doesn't actually change any headings, it just adds $0s to variant term fields ... BUT, that doesn't mean we're not doing the naive thing and just letting it do an auth reingest that triggers (useless) browse entry updates |
| 12:27 |
Dyrcona |
Well, I got it down to 22 hours on my test system by doing batches of 10,000 records at a time. Doing the --all option took almost 72 hours. |
| 12:28 |
Dyrcona |
I've been asked about running both the authority to authority linker and authority control fields in production, so I'm trying to estimate how long it will take. |
| 12:29 |
Dyrcona |
I am going to test with the parallel browse ingest branch this time. |
| 13:32 |
|
mixo joined #evergreen |
| 13:38 |
|
jonadab joined #evergreen |
| 13:40 |
mixo |
Hello! I am trying to generate reports but when I click "View Report Output" I get an ERR_TOO_MANY_REDIRECTS error. |
| 15:39 |
|
redavis joined #evergreen |
| 15:40 |
eeevil |
so that both addresses the rebase conflict /and/ brings back the SUBSTRING() calls |
| 15:54 |
Dyrcona |
eeevil++ |
| 15:54 |
Dyrcona |
I'll update my test system. |
| 17:04 |
|
mmorgan1 left #evergreen |
| 07:28 |
|
Guest51 joined #evergreen |
| 08:39 |
|
mmorgan joined #evergreen |
| 09:58 |
|
sandbergja joined #evergreen |
| 10:27 |
sleary |
sandbergja I found this last night and I love how simple the custom tests are. https://biomejs.dev/blog/biome-v2 They're not quite done with the HTML piece, though -- https://github.com/biomejs/biome/pull/6907 |
| 10:29 |
eeevil |
sandbergja: I see you grabbed the might_have reporting patch. please do not commit that. it is incorrect. |
| 10:30 |
eeevil |
the fix is to use has_a instead of might_have. there is NEVER a case where an actual, extant column on a table should be described in an associated <link> entry with might_have. |
| 10:30 |
sandbergja |
sleary++ # that looks cool! |
| 10:32 |
eeevil |
"and there will only ever be exactly ONE remote object" |
| 10:32 |
sandbergja |
gotcha |
| 10:33 |
eeevil |
it's the 0-or-1 version of has_many, which is 0-or-more |
| 10:36 |
sandbergja |
eeevil: would you object to a perl test that parses the fm_IDL.xml and confirms that there are no non-virtual might_have links? It might be easier to remember *not* to do that if some automation helps us out. |
| 10:39 |
eeevil |
we should be able to do that with the xsd, and just call xmllint to test. that seems more correct since we're trying to enforce an xml schema. but I won't stand in the way of /any/ tests, if perl gets it done |
| 10:42 |
sandbergja |
ah that would work, I like that idea |
| 10:57 |
|
Dyrcona joined #evergreen |
| 11:06 |
Dyrcona |
It's too hot to think. |
| 14:45 |
sandbergja |
eeevil: I made a branch to get xmllint passing schema validation again, and put it into github actions so we can catch problems earlier. Would you mind taking a look if you have time? bug 2119034 |
| 14:45 |
pinesol |
Launchpad bug 2119034 in Evergreen "Get xmllint passing again and check it in github actions" [Undecided,New] https://launchpad.net/bugs/2119034 |
| 14:45 |
jeffdavis |
smayo++ # adding the explanation of might_have etc to the wiki |
| 14:47 |
sandbergja |
I came to the realization that I have No Idea At All how to add an assertion about the might_have must be virtual assertion to the schema, I'd be happy to write a Perl test, or just a ticket so somebody who knows how to do the xml schema approach can work their magic |
| 14:47 |
sandbergja |
smayo++ |
| 14:47 |
|
smayo joined #evergreen |
| 14:53 |
eeevil |
sandbergja: I'm not familiar with the GH bits, but the topmost commit looks great. we don't have any instances of unbounded, but that's the semantic default, so, +1 to that addition |
| 14:54 |
|
jihpringle joined #evergreen |
| 14:54 |
sandbergja |
eeevil: thanks for taking a look! |
| 14:55 |
eeevil |
I'll push a signoff for that commit now, unless you're planning to jump on a perl-ish test soon, in which case I'll commit to pushing the whole shebang (relatively) quickly! :) |
| 14:57 |
sandbergja |
I think the perl-ish will come later, I think I've spent all the XML time I can today haha |
| 14:58 |
eeevil |
FWIW, the reltype rules are in a comment at the top of fm_IDL.xml in the fix (and sandbergja's) branch. hopefully once that's in, it'll be a useful reminder |
| 14:58 |
eeevil |
but, wiki++ |
| 10:09 |
pinesol |
News from commits: Stamp baseline db version for LP#1648276 <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=02889b2bca033d4cc61664dd8b4a2181774faf18> |
| 12:01 |
|
jihpringle joined #evergreen |
| 13:32 |
|
jihpringle joined #evergreen |
| 13:38 |
csharp_ |
on Rocky9, Makefile.install is going to take a long time because of the many unpackaged Perl modules required |
| 13:40 |
csharp_ |
build mod from source, fail test because of missing dependency, build *that* module from source, rinse, repeat |
| 13:41 |
csharp_ |
some of the dependency modules may be available in the RPM repos, but that grows heads quickly |
| 14:35 |
|
Christineb joined #evergreen |
| 14:50 |
JBoyer |
No cpan? |
| 15:53 |
|
jihpringle joined #evergreen |
| 15:59 |
csharp_ |
JBoyer: yeah, CPAN is what's taking forever |
| 16:00 |
csharp_ |
also a lot of failures - I think I must be missing something SSL-ish on my server because all the HTTPS tests are failing |
| 16:00 |
JBoyer |
Oh, I was reading the "fail, install dep, retry" thing the wrong way. |
| 16:01 |
JBoyer |
You could pass the -T param to cpan to tell it to not even bother, that will speed things up. |
| 16:01 |
JBoyer |
though if a test should fail because *handwave* you wouldn't know, but it's fine for testing. |
| 16:01 |
JBoyer |
(so to speak) |
| 16:08 |
csharp_ |
:-) |
| 16:28 |
jeff |
depending on your reasoning for using Rocky, and the reason or reasons why you're installing packages from source, it might be worth it to go whole hog and install Perl with perlbrew, cpanm, and let cpanm chase all your deps. I'm not sure how old the packaged version of things is for Rocky 9, but ISTR RHEL (which isn't Rocky, I know) being a good place to not mess with the system Perl. |
| 16:36 |
mantis |
would running the marc stream importer during operating hours but with a small file cause issues with the system? We can't load records among a few other things |
| 16:38 |
csharp_ |
aha - looks like bug 2044197 |
| 16:38 |
pinesol |
Launchpad bug 2044197 in Evergreen "Evergreen can fail to connect to authorize.net" [Undecided,New] https://launchpad.net/bugs/2044197 |
| 16:39 |
csharp_ |
jeff: sorry I wasn't clear earlier - I am installing via CPAN and my complaints were that CPAN's builds would succeed but tests would fail |
| 16:39 |
csharp_ |
but it does look like this Net::SSLeay bug is the same thing I'm seeing here |
| 16:42 |
csharp_ |
so... yeah, not just Rocky 9, but looks like the same cause |
| 16:42 |
csharp_ |
jeff: also - installing on Rocky to hopefully branch us out from being an Ubuntu/Debian-only app |
| 16:44 |
csharp_ |
I guess since we use the Ubuntu-packaged versions of some of the OnlinePayment modules we don't see the tests fail |
| 16:45 |
csharp_ |
so basically, https://xkcd.com/2347/ |
| 16:46 |
csharp_ |
mantis: I don't use the stream importer for anything, but anything that potentially locks the table for an update could cause other updates to fail |
| 16:46 |
csharp_ |
mantis: PG logs should be helpful |
| 16:50 |
csharp_ |
mantis: also, stream-y bib updates are prone to deadlocks in my experience - there's a bug from eeevil about that somewhere |
| 16:50 |
csharp_ |
our bib/authority updates are slowed down on purpose - little turtles just making their way across the road, eventually getting there but not in a hurry |
| 17:02 |
mantis |
csharp: do you know which PG logs in particular? I'm just unfamiliar with vandelay. I was able to trace in our server logs that it is an issue trying to commit something to the database |
| 17:04 |
|
mmorgan left #evergreen |
| 17:05 |
|
jvwoolf joined #evergreen |
| 15:01 |
terranm |
#info terranm = Terran McCanna, PINES |
| 15:02 |
shulabramble |
We've got potentially lengthy discussions at the end of this so lets forge on, people can continue introductions as they filter in |
| 15:02 |
csharp_ |
#info csharp = Chris Sharp, GPLS |
| 15:02 |
shulabramble |
#topic Action Items from Last Meeting |
| 15:02 |
shulabramble |
#topic sleary and sandbergja will report progress on test writing wiki pages next month |
| 15:03 |
sleary |
updates! I added a couple links to the agenda |
| 15:03 |
shulabramble |
#info https://wiki.evergreen-ils.org/doku.php?id=dev:contributing:qa#common_things_that_break_angular_unit_tests |
| 15:03 |
shulabramble |
#info custom ESLint rules, e.g. #lp2019139 |
| 15:04 |
shulabramble |
#info custom ESLint rules, e.g. lp2019139 |
| 15:04 |
abneiman |
sleary++ sandbergja++ |
| 15:04 |
sleary |
sandbergja and I are working on adding some common "if you changed X in your code, you'll need to do Y in the unit tests" examples; if you've run across test-breaking things, we'd love your input |
| 15:04 |
shulabramble |
sleary++ sandbergja++ |
| 15:04 |
sleary |
we are also working on custom lint rules as described in that LP bug |
| 15:04 |
redavis |
sleary++ sandbergja++ |
| 15:04 |
terranm |
sleary++ sandbergja++ |
| 15:05 |
shulabramble |
y'all want to keep this as an action item still? provide updates every month on progress? |
| 15:05 |
sleary |
sure |
| 15:06 |
shulabramble |
#action sleary and sandbergja will report further progress on test writing wiki pages next month |
| 15:06 |
shulabramble |
#topic Bmagic will look into transferring POeditor account ownership to a generic EG account/moving this task to the nascent Infrastructure Committee |
| 15:06 |
sandbergja |
sounds good! |
| 15:06 |
jeff |
sleary++ sandbergja++ |
| 15:07 |
gmcharlt |
one note that the POEditor account is already under a generic evergreen-ils.org account |
| 15:22 |
shulabramble |
dig++ |
| 15:22 |
terranm |
dig++ |
| 15:22 |
sandbergja |
dig++ |
| 15:23 |
shulabramble |
if there's nothing more from updates, then we'll move on. |
| 15:23 |
shulabramble |
to everyone's favorite moment -- the wall of text |
| 15:23 |
shulabramble |
#topic Launchpad Status (as of noon Eastern) |
| 15:23 |
shulabramble |
#topic Snapshot |
| 15:23 |
shulabramble |
#info Open Bugs - 3324 |
| 15:23 |
shulabramble |
#info Pullrequests - 115 |
| 15:23 |
shulabramble |
#info Signedoff - 31 |
| 15:23 |
shulabramble |
#info Needswork - 95 |
| 15:23 |
shulabramble |
#info Needstestplan - 3 |
| 15:23 |
shulabramble |
#info Needsrebase - 24 |
| 15:23 |
shulabramble |
#topic Updates Since Last Meeting |
| 15:23 |
shulabramble |
#info Bugs Added - 92 |
| 15:23 |
shulabramble |
#info Pullrequest tag Added - 60 |
| 15:23 |
shulabramble |
#info Signedoff tag Added - 26 |
| 15:24 |
shulabramble |
#info Needswork tag Added - 1 |
| 15:24 |
shulabramble |
#info Needstestplan tag Added - 0 |
| 15:24 |
shulabramble |
#info Needsrebase tag Added - 1 |
| 15:24 |
shulabramble |
#info Fix Committed - 17 |
| 15:24 |
shulabramble |
#topic New Business |
| 15:24 |
shulabramble |
#topic Can we start accepting code pull requests via github as an option? |
| 15:25 |
shulabramble |
#info DIG's github procedure - https://wiki.evergreen-ils.org/doku.php?id=evergreen-docs:github-workflow |
| 15:25 |
shulabramble |
#info Pros: reviewers and contributors can see some test and lint results before committing, a nice UI for reviewers to see what has changed |
| 15:25 |
shulabramble |
#info Cons: yet another workflow to learn and deal with, github is not a FOSS platform |
| 15:26 |
sandbergja |
This was from me! As a reviewer, I find it much easier to review contributions to projects in Github or Gitlab. There has been various talk in the community about whether moving EVERYTHING to github or gitlab might be desirable. I wanted to propose this as an incremental step to test the waters a bit more |
| 15:26 |
shulabramble |
Anyone have input on this? opinions? |
| 15:26 |
shulabramble |
sandbergja++ |
| 15:27 |
sandbergja |
I am sure the pros and cons lists are woefully short, apologies |
| 15:32 |
abneiman |
that was a terrible joke gmcharlt. I cackled. |
| 15:32 |
sandbergja |
jeff: good questions. I definitely think we would need to make sure to keep the lp bug links, and would need to amend commits that did not refer to an lp. The DIG procedure does not currently involve pressing the Big Green Button in the github ui, but cherry-picking the relevant commits, so there is ample opportunity to check them while committing |
| 15:32 |
redavis |
gmcharlt, that was delightful. |
| 15:34 |
gmcharlt |
I think there may be an initial compromise formulation |
| 15:34 |
gmcharlt |
namely, for now, leaning into the review functionality in particular |
| 15:35 |
gmcharlt |
i.e., turning a normal pull request into a GH one specifically for the purpose of doing a Fisk-style review or running the tests |
| 15:35 |
gmcharlt |
as long as there are cross-references between GH and LP |
| 15:35 |
shulabramble |
question: is this something that might be best discussed in an email thread and revisited next month? |
| 15:35 |
gmcharlt |
and that sort of pull request could be done by anybody, not just the original submitter |
| 15:36 |
abneiman |
^^ ensuring cross refs to LP is my biggest concern |
| 15:55 |
gmcharlt |
likewise, but regardless, we'll nonetheless make 4.0 a release to remember :) |
| 15:55 |
shulabramble |
jeffdavis++ |
| 15:56 |
gmcharlt |
(nothing that I say this as somebody who has a very strong preference for keeping debates about version numbering as short as possible) |
| 15:56 |
shulabramble |
#action jeffdavis will email the dev list about launchpad hygiene for 4.0-beta etc |
| 15:56 |
shulabramble |
#topic Feedback requested: QA checklist for grids (with potential automated tests highlighted) - https://docs.google.com/document/d/1RDNU4d78wX9wfQjdFsY2PHjLQwjTXbSXLqZdHXrjBNk/edit?usp=sharing |
| 15:57 |
sleary |
ah, this is me. Based on gmcharlt's excellent checklist for database tables and columns, here is one for grids! |
| 15:57 |
sandbergja |
sleary++ |
| 15:57 |
sleary |
sandbergja and I have noted which ones seem like candidates for automated testing |
| 15:58 |
jeff |
"This checklist. I like it. ANOTHER!" |
| 15:58 |
jeff |
sleary++ |
| 15:58 |
sleary |
feel free to comment on the checklist and/or assign yourself to experiment with writing a test |
| 15:58 |
sleary |
I will migrate this to the wiki eventually |
| 15:58 |
shulabramble |
sleary++ |
| 15:59 |
terranm |
sleary++ |
| 15:59 |
shulabramble |
#info feel free to comment on the checklist and/or assign yourself to experiment with writing a test - https://docs.google.com/document/d/1RDNU4d78wX9wfQjdFsY2PHjLQwjTXbSXLqZdHXrjBNk/edit?usp=sharing |
| 15:59 |
shulabramble |
#topic Announcements |
| 15:59 |
shulabramble |
#topic Next Meeting is 12 August 2025 |
| 16:00 |
shulabramble |
We got anything more? |
| 16:00 |
shulabramble |
in that case, solidly on the hour - |
| 16:00 |
shulabramble |
#endmeeting |
| 09:07 |
Dyrcona |
It might have not had permission to write the error log. I can change where that goes, too. I think it was an oversight to put it in the "WORKDIR." Think I'll set a LOGDIR variable. |
| 09:08 |
Dyrcona |
Anyway, I'm uploading the zipped file and it seems to be working. |
| 09:14 |
|
dguarrac joined #evergreen |
| 09:22 |
Dyrcona |
Oh! I was also testing that checkin program that had issues with 3.15 on 3.7 again this morning, and it works. I'll have to check AssetCommon for a potential bug on 3.15. |
| 09:53 |
csharp_ |
bleh... looks like I didn't set up letsencrypt to autorenew |
| 09:53 |
csharp_ |
on list.evergreen-ils.org |
| 09:53 |
csharp_ |
*sigh* |
| 15:15 |
|
mmorgan1 joined #evergreen |
| 15:29 |
|
jihpringle joined #evergreen |
| 15:30 |
|
mmorgan joined #evergreen |
| 15:41 |
mmorgan |
Anyone on 3.15 that can check the patron search screen in the client? The org unit selector for the Home Library isn't opening on my test system. I suspect it's me, but it would be nice if someone could confirm that it works on 3.15. My test system is 3.15.2. |
| 15:49 |
Dyrcona |
mmorgan: It's working on my test system. Did you run autogen.sh? |
| 15:51 |
Dyrcona |
Working on both of my 3.15 test systems actually. |
| 15:51 |
mmorgan |
Dyrcona: Good to hear that! I didn't run autogen. It's a docker container just built. |
| 15:52 |
Dyrcona |
Do you see org units elsewhere? |
| 15:54 |
Dyrcona |
I'm signing out in a few minutes. |
| 12:46 |
Dyrcona |
Yeahp. Eleven thousand five hundred thirty-eight lost item events generated today. |
| 12:46 |
redavis |
Yeahp indeed |
| 12:46 |
Dyrcona |
Looks like it is almost done. |
| 12:48 |
Dyrcona |
Has about 2,569 left to process. I may not get to test what I actually wanted to test today, but I'm 99% confident it will work. (I added some lines to log when certain parts of a process run, and that process depends on some action triggers happening.) |
| 12:49 |
Dyrcona |
it might have finished by now if it had not been suspended for so long. |
| 12:56 |
jeff |
redavis++ thanks! |
| 12:56 |
redavis |
Sure thing :-) |
| 13:00 |
redavis |
It's a pretty info rich topic and I suspect it's going to become more so quickly. |
| 13:04 |
Dyrcona |
jeff: No. I mentioned earlier that I'm running this on a copy of production that hasn't been updated in almost a month (June 1). |
| 13:04 |
Dyrcona |
So, its way more than our usual. |
| 13:04 |
Dyrcona |
I'm not even testing that. I want to see if my log statements work as expected. |
| 13:05 |
Dyrcona |
i suppose I could just run that part without waiting on the rest. |
| 13:05 |
Dyrcona |
It should still work, even when there's nothing to do. |
| 13:43 |
|
jihpringle joined #evergreen |
| 14:07 |
jeff |
ah! thanks! |
| 14:09 |
redavis |
Sure thing :-) |
| 14:29 |
|
jihpringle joined #evergreen |
| 14:50 |
Dyrcona |
Guess my tech is working so far. I tested audio and video with Zoom. |
| 14:51 |
sleary |
I have not rescheduled UI group yet; I wanted to wait a bit for the other group schedules to shake out. And I've been out. It's on my list for this week! |
| 14:52 |
redavis |
The meeting is open. |
| 16:34 |
|
jihpringle joined #evergreen |
