| Time |
Nick |
Message |
| 01:49 |
|
bshum joined #evergreen |
| 08:08 |
|
BDorsey joined #evergreen |
| 08:08 |
|
cbrown joined #evergreen |
| 08:34 |
|
mmorgan joined #evergreen |
| 08:39 |
|
kmlussier joined #evergreen |
| 08:39 |
kmlussier |
Happy Friday #evergreen! |
| 08:39 |
kmlussier |
@coffee [someone] |
| 08:39 |
* pinesol |
brews and pours a cup of Kenya AA Kiaora Estate Full City Roast, and sends it sliding down the bar to denials |
| 08:40 |
kmlussier |
@tea [someone] |
| 08:40 |
* pinesol |
brews and pours a pot of Golden Orchid, and sends it sliding down the bar to phasefx (http://ratetea.com/tea/whispering-pines/golden-orchid/7244/) |
| 08:40 |
kmlussier |
@dessert [someone] |
| 08:40 |
* pinesol |
grabs some Non-Vanilla Ice Cream for abowling |
| 08:48 |
mmorgan |
Happy Friday! |
| 08:48 |
mmorgan |
@coffee kmlussier |
| 08:48 |
* pinesol |
brews and pours a cup of Colombia Finca Cerro Azul, and sends it sliding down the bar to kmlussier |
| 09:02 |
kmlussier |
mmorgan: Thanks! |
| 09:02 |
|
dguarrac joined #evergreen |
| 09:27 |
|
collum joined #evergreen |
| 10:23 |
|
BDorsey_ joined #evergreen |
| 10:40 |
|
Dyrcona joined #evergreen |
| 10:57 |
|
cbrown_ joined #evergreen |
| 11:45 |
|
JBoyer joined #evergreen |
| 11:48 |
|
JBoyer joined #evergreen |
| 11:53 |
|
JBoyer joined #evergreen |
| 11:54 |
pinesol |
News from commits: LP2077753 follow-up: silence [ngbDropdownMenu] console error <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c0c666496e6f2f11a411c85e9af5c9a70e7713c8> |
| 11:54 |
pinesol |
News from commits: LP2077753 Silence [ngbDropdown] console error <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3d965fc8df581b42b4b8f0a70af5c8fdc69c0ad1> |
| 12:08 |
|
jihpringle joined #evergreen |
| 12:24 |
pinesol |
News from commits: LP#2069062: Speed up hold ratio reports <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=17c137d833c47189e5b9fde7ca8e0e62345d0126> |
| 12:28 |
|
collum joined #evergreen |
| 12:37 |
|
BDorsey__ joined #evergreen |
| 12:40 |
Dyrcona |
Eureka! |
| 12:50 |
kmlussier |
Dyrcona: Did something good happen? |
| 12:51 |
Dyrcona |
Yes. I discovered the cause of a bug. |
| 12:51 |
Dyrcona |
https://bugs.launchpad.net/evergreen/+bug/2073561/comments/15 |
| 12:51 |
pinesol |
Launchpad bug 2073561 in Evergreen "Incorrect content in the config.coded_value_map with ctype audience after applying the upgrade script from 3.12.3 to 3.13.0" [Medium,Confirmed] - Assigned to Jason Stephenson (jstephenson) |
| 12:52 |
Dyrcona |
Well, it's a bug within that larger bug. |
| 12:53 |
Dyrcona |
It explains when 'No attempt to code' for the audience filter is always checked by default. |
| 12:54 |
kmlussier |
Dyrcona++ |
| 12:54 |
kmlussier |
A nice thing to happen on a Friday. |
| 12:54 |
pinesol |
News from commits: LP#2076350: Reporter trees start collpased <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a48a31fe0635c0618ef2715429614d0714796ea7> |
| 13:05 |
Dyrcona |
I think that makes it a good time to take a break and go find some lunch. I'll be back later. |
| 13:21 |
|
cbrown joined #evergreen |
| 13:25 |
pinesol |
News from commits: LP2034956: Check authtoken validity more frequently <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f45280de17d82f0477843fa981c134f752fa7b19> |
| 13:32 |
eeevil |
grabbing 1435 |
| 13:55 |
pinesol |
News from commits: Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=41dca36ef446eb5eafaa021750fea327be117b1e> |
| 13:55 |
pinesol |
News from commits: LP#1902120: Customizing the label for items with no parts (formerly "All Parts" or... <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6a5f943b3f9b8c4391856562af251cbb9fca10da> |
| 14:25 |
pinesol |
News from commits: LP2068934 Circulating Library vs Checkout Library Terminology <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=85924ab4c21c15a6908c5a907e980469592b8372> |
| 14:25 |
pinesol |
News from commits: LP#2044854: removing caching of Z39.50 target defs by open-ils.search - doc update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=88145bbe172005547922f3bd6b0875e98242906e> |
| 14:25 |
pinesol |
News from commits: LP#2044854: removing caching of Z39.50 target defs by open-ils.search <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1db6933b1589acc8c0c7ca11654e205576654967> |
| 14:29 |
|
Dyrcona joined #evergreen |
| 14:46 |
eeevil |
grabbing 1436 |
| 15:14 |
eeevil |
and, grabbing 1437 |
| 15:14 |
Dyrcona |
eeevil++ |
| 15:15 |
Dyrcona |
BTW, if you're trying to beat the 3.14 code freeze deadline, it was bumped to the 18th. |
| 15:16 |
eeevil |
Dyrcona: indeed, but /my/ deadlines remain! ;) (but thank you for noting that) |
| 15:16 |
Dyrcona |
I guess it's the feature slush deadline.... |
| 15:16 |
eeevil |
it's time to Make Pi Great Again! |
| 15:16 |
Dyrcona |
OK! |
| 15:16 |
Dyrcona |
It's hard to beat great pie. :) |
| 15:22 |
eeevil |
I'm going to merge the self checkout followup followup, and then I think I'm done merging for the day... whew |
| 15:23 |
Dyrcona |
:) |
| 15:24 |
Dyrcona |
Reminds me of a line from "Christmas in Connecticut:" Shortcut to the the shortcut. Said after Sam(?) bogs the car down in a pond. |
| 15:25 |
pinesol |
News from commits: LP1840773: Test followup for self-checkout <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d7b2194676e773dd014d93dc55a73688337a47d0> |
| 15:25 |
pinesol |
News from commits: Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c94c0cb1403cf8c36760ec8c4cec335e4f5db210> |
| 15:25 |
pinesol |
News from commits: LP#1903749: Add upgrade script and seed data <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6fb3a2a60282c7ed31cc339cab58713186d0b4e5> |
| 15:25 |
pinesol |
News from commits: LP#1903749: WIP - allow adjacent-copy capture during stalling <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=04a228ddcae3907c4682f18099027342577e722e> |
| 15:25 |
pinesol |
News from commits: Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=9dccf19cb03fc63b3f5ed33b380ea4383c10fbd1> |
| 15:25 |
pinesol |
News from commits: LP#2043142: Base IDL-configured report security <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=25e1fb282b4432aa97111419375c947d2027a600> |
| 15:26 |
Dyrcona |
Dang it! Wrong movie and wrong character. It's Gus from Holiday Inn..... I never should have gotten that gyro for lunch. :) |
| 15:30 |
Dyrcona |
I also wonder if this should be a bug all on its own? https://bugs.launchpad.net/evergreen/+bug/2073561/comments/16 |
| 15:30 |
pinesol |
Launchpad bug 2073561 in Evergreen "Incorrect content in the config.coded_value_map with ctype audience after applying the upgrade script from 3.12.3 to 3.13.0" [Medium,Confirmed] - Assigned to Jason Stephenson (jstephenson) |
| 15:37 |
eeevil |
Dyrcona: should the "|" issue be a bug all its own? well, I'd be inclined to commit that quickly aside from the ccvm content part, if that's what you mean. it's obvious and tractable, IMO |
| 15:39 |
eeevil |
(the bit about ' ' vs '#' ... yeah, I agree it should be one or the other, and also agree with ' ' instead of '#') |
| 16:18 |
Dyrcona |
eeevil: LC agrees it should be space instead of '#' too. |
| 16:19 |
Dyrcona |
eeevil: OK. I'll make a new bug on Lp for that issue and a new branch. I've noticed a typo in the commit message I'd like to fix. |
| 16:20 |
Dyrcona |
I want to see if anywhere else is affected, like staff search. |
| 16:21 |
Dyrcona |
Ugh.. What? TypeError: egCore.auth.provisional is not a function |
| 16:22 |
Dyrcona |
open-ils.auth_mfa is running. |
| 16:25 |
Dyrcona |
Now, it looks like the factors are missing again. I didn't mess with the database other than config.coded_value_map. |
| 16:25 |
Dyrcona |
Hm... I'll close dev tools to see if using the cache helps. |
| 16:26 |
Dyrcona |
OK, so I'm logged in already. There is some weirdness going on. |
| 16:30 |
Dyrcona |
The factors are there. |
| 16:31 |
Dyrcona |
Ah well. I have to go soon. |
| 16:39 |
Bmagic |
what's the magic trick to have evergreen recalculate visibility on a bib? |
| 16:45 |
eeevil |
Bmagic: for bib-level stuff or item level stuff? |
| 16:46 |
eeevil |
however, if you've disabled triggers to the point where that didn't happen ... um ... try not to do that |
| 16:46 |
Bmagic |
I'm troubleshooting a search result issue. Search does return results at the consortium level and you can see the item is clearly attached to a bib at a branch, but when I change the search to scope to that branch, no results. that's all I change, the branch |
| 16:46 |
Bmagic |
disable triggers? which triggers are you thinking are disabled? |
| 16:47 |
Bmagic |
how is it possible for earch to return just fine at the consortium level for a bib that contains exactly one item, attached at branch A, but searching in the scope of branch A doesn't return? |
| 16:48 |
eeevil |
triggers maintain the data used to test visibility, so ... those ones |
| 16:49 |
eeevil |
are there located URIs on the bib? |
| 16:49 |
|
jihpringle joined #evergreen |
| 16:49 |
Bmagic |
no |
| 16:51 |
jihpringle |
Bmagic: long shot but is there any chance the shelving location is deleted? |
| 16:51 |
Bmagic |
biblio record entry has {} for vis_attr_vector |
| 16:51 |
eeevil |
Bmagic: and, to be clear, modern EG tests visibility on demand, it does not use the old visibility caching. various stuff is collected statically into an int array, and then that is checked with an overlaps test against the currently-configured set of visible things |
| 16:51 |
Bmagic |
I checked that, non of the things are opac_visible='false |
| 16:52 |
jihpringle |
we ran into some really weird issues in search and display when a library accidentally deleted a shelving location they were still using |
| 16:52 |
Bmagic |
the status is "in Process" which is opac visible, the shelving location is visible, the org unit is visible |
| 16:52 |
eeevil |
bre.vis_attr_vector is for the source and located URI |
| 16:52 |
Bmagic |
ok, vis_attr_vector isn't it then |
| 16:52 |
Bmagic |
trying to generate ideas |
| 16:53 |
eeevil |
asset.copy_vis__attr_cache holds item-side values |
| 16:54 |
Bmagic |
looking |
| 16:55 |
Bmagic |
{1,536871014,805306373,1073741825,268435558} |
| 16:56 |
Bmagic |
are those suppose to be org units? |
| 16:56 |
eeevil |
not directly |
| 16:56 |
eeevil |
but, some of them are |
| 16:56 |
eeevil |
and some are other things |
| 16:56 |
Bmagic |
the number 1 sesems to track with consortium results |
| 16:57 |
eeevil |
no |
| 16:57 |
eeevil |
that's the copy's own opac_visible flag. if true, there'll be a 1 in the list |
| 16:58 |
Bmagic |
is there a db function I can call to re-create that for that copy? |
| 16:59 |
Bmagic |
maybe it will trigger if I just update asset.copy where id=x ? |
| 16:59 |
eeevil |
yes, asset.calculate_copy_visibility_attribute_set($copy_id) (that is a function to calculate, not update) |
| 16:59 |
Bmagic |
I'd be interested if it would come up with a different result |
| 17:00 |
eeevil |
run it, check against that copy's row in asset.copy_vis_attr_cache |
| 17:01 |
eeevil |
the triggers on asset.copy, btw, are z_opac_vis_mat_view_tgr and z_opac_vis_mat_view_del_tgr |
| 17:01 |
Bmagic |
ran it and now it's {1,536871014,805306373,1073741825,268435558} |
| 17:01 |
Bmagic |
so, no change |
| 17:02 |
Bmagic |
no change in search result behavior (though I forget how to break memcached db cache) |
| 17:02 |
eeevil |
I think you're going to want to look at the actual search query, not the just web page and the bib/copy rows |
| 17:02 |
eeevil |
just tack "-kljdjkldfkjlfdskjldfskjl" onto the end of the search (no quotes) |
| 17:03 |
Bmagic |
ok, no change |
| 17:04 |
Bmagic |
let me think about how to capture the search query... pretty sure it's not getting logged because it's not taking long enough |
| 17:04 |
eeevil |
lower min-duration loging to 0 ms, reload (NOT restart) pg, search to get some logs, change the setting back and reload again |
| 17:04 |
eeevil |
you can change pg logging at will with a reload |
| 17:05 |
Bmagic |
oh dang, I thought I'd need to restart PG after making a change like that to the config |
| 17:05 |
eeevil |
nope |
| 17:06 |
Bmagic |
this can't be it |
| 17:06 |
Bmagic |
SELECT * FROM search.highlight_display_fields( '38225', '"''beholder'' | ''behold''"=>"2,4,53,6,5,3"' ) AS "search.highlight_display_fields" ; |
| 17:07 |
eeevil |
it's not |
| 17:07 |
Bmagic |
but "beholder" is what I'm searching with |
| 17:07 |
eeevil |
it'll have the string "bib search" in an SQL comment in front of it |
| 17:07 |
eeevil |
it's a huge query with a bunch of CTEs (WITH clauses) at the top |
| 17:08 |
Bmagic |
ok, got it |
| 17:08 |
Bmagic |
https://pastebin.com/USyJE93Y |
| 17:09 |
eeevil |
however, that highlighting call's first param is a bib id, so if this was from the branch-level "failed" search then ... it succeeded, and it's higher up in the rendering code that is having a problem |
| 17:11 |
Bmagic |
running the query by hand on the db, I'm not getting the bib I expect |
| 17:11 |
Bmagic |
just the pasted search query I mean |
| 17:11 |
|
mmorgan left #evergreen |
| 17:12 |
Bmagic |
so now, I'm playing with that query to see if I can change it to where it does result the bib I expect |
| 17:19 |
Bmagic |
call number owning lib is 103, asset.copy circ lib is 103, bib is not deleted, call number is not deleted, copy is not deleted |
| 17:23 |
eeevil |
what's the output of `select (asset.patron_default_visibility_mask()).c_attrs;` |
| 17:27 |
Bmagic |
checking |
| 17:28 |
Bmagic |
((1)&!(805306370|805306371|805306372|805306378|805306379|805306381|805306382|805306383|805306384|805306385|805306469|805306470)) |
| 17:29 |
eeevil |
so that's just the opac_visible=f statuses |
| 17:30 |
eeevil |
they generally match stock, but there are to extras at the end. the details aren't important as long as the status of the copy is available (or definitely visible) |
| 17:31 |
eeevil |
bah... I have to run away for an evening out. |
| 17:32 |
Bmagic |
thanks for your time! |
| 18:08 |
|
jihpringle joined #evergreen |
