| Time |
Nick |
Message |
| 06:53 |
|
kworstell-isl joined #evergreen |
| 07:16 |
|
collum joined #evergreen |
| 08:05 |
|
cbrown joined #evergreen |
| 08:17 |
|
BDorsey joined #evergreen |
| 08:37 |
|
mmorgan joined #evergreen |
| 08:49 |
|
kmlussier joined #evergreen |
| 08:57 |
kmlussier |
Good morning #evergreen! |
| 08:57 |
kmlussier |
@coffee [someone] |
| 08:57 |
* pinesol |
brews and pours a cup of Natural Decaf Espresso, and sends it sliding down the bar to degraafk |
| 08:57 |
kmlussier |
Ew, decaf. Let's try that again. |
| 08:57 |
kmlussier |
@coffee [someone] |
| 08:57 |
* pinesol |
brews and pours a cup of Ethiopia Washed Yirgacheffe, Koke Grade 1, and sends it sliding down the bar to jeffdavis |
| 08:57 |
kmlussier |
@tea [someone] |
| 08:58 |
mmorgan |
Good morning kmlussier! |
| 08:58 |
pinesol |
An error has occurred and has been logged. Please contact this bot's administrator for more information. |
| 08:58 |
kmlussier |
pinesol: You're slow this morning. |
| 08:58 |
pinesol |
kmlussier: Beyond here be dragons. |
| 08:58 |
kmlussier |
pinesol is probably angry because I objected to their first coffee choice. |
| 08:58 |
pinesol |
kmlussier: The horror... The horror... |
| 09:00 |
|
Dyrcona joined #evergreen |
| 09:06 |
|
dguarrac joined #evergreen |
| 09:16 |
|
redavis joined #evergreen |
| 09:48 |
Dyrcona |
redavis: Are targeting bugs on Lp? If so, would you stop, please? |
| 09:48 |
redavis |
Yes and yes |
| 09:48 |
|
collum joined #evergreen |
| 09:49 |
Dyrcona |
I noticed some were targeted at 3.14.1, and I want to change it to 3.14.0 'cause they might make it before Tuesday. At least, I want to give them a chance. :) |
| 09:49 |
redavis |
Okay |
| 09:49 |
Dyrcona |
It looks like we've crossed paths at this point, so I'll stop. I started at the bottom of the list and worked my way up. |
| 09:51 |
redavis |
I can move the things in 3.14.1 back to 3.14.0 if that's the preference |
| 09:51 |
Dyrcona |
No, that's OK. We can alter the targets later. |
| 09:52 |
Dyrcona |
I've already got a list of 13 bugs to look at, and I won't get to them all. |
| 09:52 |
Dyrcona |
For the channel: It's not been officially announced yet, but Evergreen 3.14-rc is released and ready to download. |
| 09:52 |
redavis |
Okay. It's all "flexible." Also, my apologies. Your email from 28 minutes ago just came in. |
| 09:53 |
Dyrcona |
Yeah, that happens. |
| 09:53 |
csharp_ |
@band add Candy Cron |
| 09:53 |
pinesol |
csharp_: Band 'Candy Cron' added to list |
| 09:54 |
redavis |
At least you didn't swear at me ;-) |
| 09:54 |
csharp_ |
"that band is always on time!" |
| 09:54 |
Dyrcona |
As opposed to "Pixie Cron" [sic]?. |
| 09:55 |
Dyrcona |
Anacron: it'll run sometime around the time you want it to, but you'll never know for sure.--Yes, that's actually how anacron "works." |
| 09:55 |
Dyrcona |
Or maybe, it'll run at some apparently random time, but it makes senses when you understand that anacron doesn't give a damn. |
| 09:57 |
Dyrcona |
Merge hiatus is lifted. I'd like to some actual bugs for 3.12 through 3.14 get merged if possible. |
| 09:57 |
Dyrcona |
@bad add 'Omitted Words' |
| 09:57 |
pinesol |
Dyrcona: Yeah, well, you know, that's just, like, your opinion, man. |
| 09:57 |
Dyrcona |
Hah! |
| 09:57 |
Dyrcona |
@band add 'Omitted words' |
| 09:57 |
pinesol |
Dyrcona: Band ''Omitted words'' added to list |
| 09:58 |
Dyrcona |
@eightball Will Dyrcona ever really learn to type? |
| 09:59 |
pinesol |
Dyrcona: Of course. |
| 09:59 |
csharp_ |
pinesol: bad |
| 09:59 |
pinesol |
csharp_: You probably want hard-boiled eggs. |
| 09:59 |
Dyrcona |
I've only been typing since I was 10 years old or so. After 40+ years, you'd think I'd be perfect. |
| 10:00 |
csharp_ |
@decide attend meeting or listen to music |
| 10:00 |
pinesol |
csharp_: go with attend meeting |
| 10:00 |
csharp_ |
pinesol: bleh, I knew you'd say that |
| 10:00 |
pinesol |
csharp_: The {0} can also watch this recording if it’s stored in the cloud. |
| 10:00 |
mmorgan |
pinesol's no fun. |
| 10:00 |
csharp_ |
pinesol: be more fun! |
| 10:00 |
pinesol |
csharp_: where the hell did my db03 go? |
| 10:01 |
Dyrcona |
Gladwell, Simon, and Chase, I'm calling bs on the 10,000 hour rule. |
| 10:12 |
redavis |
Dyrcona++ |
| 10:18 |
|
kmlussier left #evergreen |
| 10:41 |
Dyrcona |
charp_ Can we have a sidebar the Hack-Away about you packages repo for Evergreen? I'm thinking we might want to look into that more as a community effort. |
| 10:41 |
redavis |
csharp_++ #please? |
| 10:57 |
|
sandbergja joined #evergreen |
| 10:57 |
sandbergja |
release_team++ |
| 10:58 |
* redavis |
curtsies to sandbergja on behalf of the release team. |
| 10:58 |
redavis |
(virtual curtsying doesn't include pulled muscles) |
| 10:58 |
mmorgan |
release_team++ |
| 10:59 |
|
collum joined #evergreen |
| 11:11 |
|
Christineb joined #evergreen |
| 11:20 |
sandbergja |
I was thinking of pushing the fix to bug 2084096 to rel_3_13 and main. Should I push it to rel_3_14 as well (i.e. is it okay if the 3.14.0 has changes from the rc -- I believe there are different schools of thought about that in the community)? |
| 11:20 |
pinesol |
Launchpad bug 2084096 in Evergreen "Line items cannot be canceled using a true cancel reason" [High,Confirmed] https://launchpad.net/bugs/2084096 - Assigned to Ian Skelskey (ianskelskey) |
| 11:25 |
|
kworstell_isl joined #evergreen |
| 11:26 |
JBoyer |
Does candy cron also have the texture of candle wax and taste like ennui and missed opportunities? |
| 11:27 |
berick |
with the added bonus that you get you enjoy them every morning at 6:05am, right after the hold targeter runs |
| 11:28 |
Dyrcona |
JBoyer++ and, it's filled with some kind of slimy goo that you hope is corn syrup but who knows. |
| 11:28 |
|
collum joined #evergreen |
| 11:29 |
mmorgan |
sandbergja: IMO, I would want the rc to have that patch. I don't think it would make sense for the next point releases to get the patch but not the rc. Especially given it's a high importance bug. |
| 11:29 |
Dyrcona |
sandbergja: Yes, it is OK to push to rel_3_14. I would prefer that you did. |
| 11:29 |
JBoyer |
berick++ Dyrcona++ |
| 11:30 |
Dyrcona |
It'll be in .0 at this point. I'm going to look at a few things before the .0 as well. |
| 11:32 |
sandbergja |
sounds good |
| 11:32 |
Dyrcona |
I'm planning to push Lp 1828114, Lp 1848398, and Lp 2084166 before tomorrow. |
| 11:32 |
pinesol |
Launchpad bug 1828114 in Evergreen 3.13 "Incorrect date of birth saved in certain timezones." [Undecided,Confirmed] https://launchpad.net/bugs/1828114 |
| 11:32 |
pinesol |
Launchpad bug 1848398 in Evergreen "Seed data doesn't indicate that the format.date and format.time library settings are deprecated" [Medium,Confirmed] https://launchpad.net/bugs/1848398 |
| 11:32 |
pinesol |
Launchpad bug 2084166 in Evergreen "Legacy OPAC templates not compatible with DOB field changes" [High,Confirmed] https://launchpad.net/bugs/2084166 |
| 11:32 |
Dyrcona |
I'll wait for your push. |
| 11:33 |
Dyrcona |
Y'know...it's close enough. I'll grab my lunch and eat at my desk. |
| 11:34 |
|
sandbergja joined #evergreen |
| 11:35 |
sandbergja |
Dyrcona it'll take me a bit to push, I want to run the live tests one last time, and am also getting distracted by a few other things simultaneously. |
| 11:39 |
* jeffdavis |
enjoys a cup of Ethiopia Washed Yirgacheffe, Koke Grade 1 |
| 11:46 |
* Dyrcona |
enjoys Sunday dinner leftovers: rib roast, potato and carrot. |
| 11:48 |
sandbergja |
One of the live tests is failing with "Method [open-ils.actor.user.penalty.remove] not found for OpenILS::Application::Actor" -- did that method get removed recently? |
| 11:48 |
sandbergja |
I am pretty confident that it's unrelated to this acq/cat patch |
| 11:48 |
|
collum joined #evergreen |
| 11:50 |
eeevil |
sandbergja: (mostly for the room and logs) as a general rule, if unrelated methods start failing it's often a perl syntax error earlier in a sub-module, and the methods aren't getting registered because of that |
| 11:50 |
Dyrcona |
Yeah. I'll take a look. |
| 11:51 |
sandbergja |
eeevil++ Dyrcona++ |
| 11:51 |
Dyrcona |
There have been some other places with syntax errors that slipped through lately. |
| 11:51 |
sandbergja |
For reference, live_t/36-lp1752334-badcontact.t had the failure |
| 11:51 |
Dyrcona |
sandbergja: I'm assuming this is main, or is it another branch? |
| 11:52 |
eeevil |
origin/main seems OK... |
| 11:52 |
sandbergja |
it was collab/sandbergja/lp2084096-lineitem-cancel-fix, I'll try again from main |
| 11:52 |
jeffdavis |
open-ils.actor.user.penalty.remove was changed to open-ils.actor.user.note.remove |
| 11:53 |
eeevil |
jeffdavis++ |
| 11:53 |
Dyrcona |
I was going to check on rel_3_14 on my release vm, but jeffdavis++ |
| 11:53 |
sandbergja |
jeffdavis++ |
| 11:53 |
sandbergja |
eeevil: main seems okay as in the test passes on main for you? |
| 11:53 |
Dyrcona |
That should probably go in an upgrade note. |
| 11:54 |
eeevil |
sandbergja: sorry, no, I didn't run the tests, I just checked the syntax with `perl -wc` |
| 11:54 |
sandbergja |
gotcha |
| 11:55 |
Dyrcona |
I'll make a Lp bug and post a fix if no one else wants to. |
| 11:57 |
Dyrcona |
eeevil: Do you have a strong opinion on Lp 2083873? Today would be a good time to hash it out. |
| 11:57 |
pinesol |
Launchpad bug 2083873 in Evergreen "Remove support for PostgreSQL 10, 11 and 12" [Undecided,New] https://launchpad.net/bugs/2083873 |
| 11:59 |
sandbergja |
Dyrcona++ |
| 11:59 |
eeevil |
Dyrcona: my preference would be, if testing proves it works for $not_me, to include the back-compat change, and drop fresh-install-support for 10-12... too much to ask? :) |
| 12:00 |
Dyrcona |
It's not too much to ask. I noticed anycompatible is also used in the reporter, probably the security or Angular update. That would need a fix, too. |
| 12:01 |
eeevil |
it's the reports security stuff that I offered a change to, IIRC |
| 12:01 |
Dyrcona |
Oh, OK!. I thought I saw it somewhere twice. I'll double check. I'm probably hallucinating things from looking at too much code over the past couple of weeks. |
| 12:02 |
|
jihpringle joined #evergreen |
| 12:02 |
eeevil |
yeah, it is. the patch as offered is meant to modify things in-place for any branch that contains the reports security stuff. no /new/ upgrade script, just pretend that didn't happen |
| 12:02 |
Dyrcona |
First verify the test failure for myself so I can write a Lp bug and post a fix. After that the anycompatible thing.... Got it! No one should have it in production, yet. |
| 12:03 |
eeevil |
right, that's my thinking. if they do, they know how to handle pre-release changes :) |
| 12:03 |
eeevil |
(I HOPE!) |
| 12:06 |
Dyrcona |
:) |
| 12:06 |
* Dyrcona |
has had fun with those in the past. |
| 12:08 |
pinesol |
News from commits: LP#2084096: Add a test for lineitem deletion <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=563d3604c39910d076774b191ff72163f5671b3b> |
| 12:08 |
pinesol |
News from commits: LP#2084096: Fix issue with line item cancellation and undefined volume <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=532d8be5391516a743c9ad84c23fa80e47049246> |
| 12:12 |
Dyrcona |
sandbergja++ eeevil++ |
| 12:31 |
Dyrcona |
Hmm.. Setting up a vm to test a few things and osrf_control is taking a long time to exit. |
| 12:32 |
|
collum joined #evergreen |
| 12:35 |
Dyrcona |
This is latest main on Ubuntu 24.04, and osrf_control -l --start-all seems hang after starting opensrf.slooooooow. |
| 12:37 |
Dyrcona |
Some listeners and drones won't go away with just a plain 'kill.' |
| 12:37 |
Dyrcona |
Smells like a bug? |
| 12:42 |
* Dyrcona |
switches to a vm that should have already had Evergreen installed. |
| 12:45 |
Dyrcona |
hmm. Looks like none of my local vms have been setup. I must have restarted them all recently. |
| 12:46 |
Dyrcona |
mabye jammy? |
| 13:25 |
|
kmlussier joined #evergreen |
| 13:49 |
|
redavis joined #evergreen |
| 13:50 |
Dyrcona |
There is another way to fix Lp 2084828. I could just add a signature for open-ils.actor.user.penalty.remove that points to the implementation of open-ils.actor.user.note.remove. |
| 13:50 |
pinesol |
Launchpad bug 2084828 in Evergreen "open-ils.actor.user.penalty.remove renamed to open-ils.actor.user.note.remove" [High,Confirmed] https://launchpad.net/bugs/2084828 - Assigned to Jason Stephenson (jstephenson) |
| 14:08 |
Dyrcona |
newdevs++ |
| 14:13 |
|
jihpringle joined #evergreen |
| 14:31 |
Dyrcona |
Claiming 1444. |
| 14:36 |
|
kmlussier left #evergreen |
| 14:36 |
jeffdavis |
Dyrcona: looking more closely at Actor.pm, it looks to me like there is supposed to be a signature for open-ils.actor.user.penalty.remove, but instead there are two signatures for open-ils.actor.user.note.remove. |
| 14:38 |
jeffdavis |
There are other open-ils.actor.user.note.* APIs that retain a corresponding open-ils.actor.user.penalty.* version. |
| 14:38 |
jeffdavis |
I'll make a branch, one sec |
| 14:39 |
pinesol |
News from commits: LP1848398: Stamp DB upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=04cdaf9ae4c7e432857e8fc3611dcbab0499b081> |
| 14:39 |
pinesol |
News from commits: LP1848398: Stop Using Deprecated Format Settings <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c541610b1c6281077bd62c4f17ea07a2bf6f3db4> |
| 14:39 |
pinesol |
News from commits: LP2084166 Follow-up: Place labels below form inputs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=0908bad78d96467665ed879b9accc34b7a6b29fc> |
| 14:39 |
pinesol |
News from commits: LP2084166 Patron self-reg inputs for old OPAC <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5a9330e40385146813f5360e1622269beeca6278> |
| 14:39 |
pinesol |
News from commits: LP#1828114 Incorrect date of birth saved in certain time zones <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f4c4630991775be7a91fd88cf79581991f8f3479> |
| 14:43 |
Dyrcona |
jeffdavis: OK. It's not too late. :) |
| 14:49 |
jeffdavis |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp2084828-penalty-note-remove |
| 14:50 |
jeffdavis |
Dyrcona: ^ see above, I also updated the bug with an explanation |
| 14:51 |
jeffdavis |
I'm not familiar with this code, just going by the duplication of the note.remove API and the analogy with similar APIs updated at the same time |
| 15:05 |
|
jihpringle joined #evergreen |
| 15:13 |
Dyrcona |
jeffdavis++ |
| 15:14 |
Dyrcona |
I didn't check for a duplicate entry. I just looked at git log -p real quick. |
| 15:22 |
Dyrcona |
The staff client thinks it is John Bonham: "the client attempted to play the bongo sound 300 times." |
| 15:22 |
Dyrcona |
@decide John Bonham or Keith Moon |
| 15:22 |
pinesol |
Dyrcona: go with John Bonham |
| 15:23 |
berick |
asking the real questions |
| 15:23 |
Dyrcona |
@decide John Bonham or Jim Keltner |
| 15:23 |
pinesol |
Dyrcona: go with Jim Keltner |
| 15:23 |
Dyrcona |
pinesol has refined tastes. |
| 15:23 |
pinesol |
Dyrcona: Zero to Web in 30 Seconds! |
| 15:24 |
Dyrcona |
Jim Keltner played drums on the Steely Dan song Josie. If you don't know it you should. It's a musical masterpiece. |
| 15:25 |
* berick |
plays it |
| 15:26 |
berick |
oh yeah.. i do know it |
| 15:26 |
Dyrcona |
Just listen to the musicianship... It's near perfection. |
| 15:27 |
berick |
yeah, they often are |
| 15:28 |
Dyrcona |
jeffdavis++ the tests pass. |
| 15:29 |
Dyrcona |
I'm tempted to just push your fix now, but maybe I'll add a signoff and wait a day or two if someone else wants to look. |
| 15:36 |
redavis |
Dyrcona++ jeffdavis++ |
| 15:39 |
Dyrcona |
Resist the urge to Push ALL THE THINGS!!!! |
| 15:39 |
redavis |
Why resist? :D (if they're tested and ready to go) |
| 15:42 |
Dyrcona |
Yes, some are signedoff. I still like to at least look at the code and run a few tests before. |
| 15:44 |
redavis |
lol, well, yes. But...once you do... |
| 15:44 |
redavis |
you get a commit and YOU get a commit |
| 15:45 |
Dyrcona |
\o/ |
| 15:45 |
Dyrcona |
| | |
| 15:46 |
redavis |
lol!! |
| 15:46 |
Dyrcona |
I was trying to add legs but the client thinks / is an attempt to run a command. |
| 15:48 |
redavis |
I typed up a reference to boxing helena and then decided against it |
| 16:06 |
csharp_ |
Dyrcona: sure - we can talk about packaging - our repo is defunct, but we're still building debs |
| 16:06 |
csharp_ |
also relevant to my long-running, low-intensity effort to support RHEL-ish things |
| 16:20 |
abneiman |
if I might prevail upon the relteam yet again: https://bugs.launchpad.net/evergreen/+bug/2084835 |
| 16:20 |
pinesol |
Launchpad bug 2084835 in Evergreen "permission check for sharing other people's buckets checks for the wrong permissions" [High,Confirmed] |
| 16:45 |
Dyrcona |
abneiman: I added a question about what versions of Evergreen beyond 3.14 might be affected. I can look at it tomorrow probably. Seems all that I'm doing is release engineering. :) |
| 16:46 |
Dyrcona |
Oh! Look at the time! 'Bout time to go. |
| 16:46 |
csharp_ |
@eightball is anything beyond 3.14? |
| 16:46 |
pinesol |
csharp_: It shall be. |
| 16:47 |
Dyrcona |
Maybe I should have said "before?" :) |
| 16:50 |
Dyrcona |
Been listening to all of my music on shuffle today. It just switched between Italians, but a great contrast. From "Il Ribelle" by Adriano Celentano to one of the allegro movements of Vivaldi's "Quatro Stagioni." I'm not sure which. I really ought to be able to say just from hearing it. |
| 16:50 |
Dyrcona |
And, with that, I poof out. |
| 16:51 |
csharp_ |
Dyrcona++ # exit music |
| 17:12 |
|
mmorgan left #evergreen |
