| 14:45 |
shulabramble |
15 minute warning to the dev meeting |
| 14:46 |
|
sandbergja joined #evergreen |
| 14:50 |
shulabramble |
10 minutes to dev meeting |
| 14:52 |
berick |
jeff++ # *sigh* i just noticed your Hatch test notes in LP. |
| 14:52 |
berick |
accidentally marked that email read |
| 14:55 |
shulabramble |
5 minutes to dev meeting! |
| 14:56 |
|
smayo joined #evergreen |
| 14:58 |
jeff |
berick++ glad you saw it! |
| 15:11 |
shulabramble |
and a belated eeevil++ |
| 15:11 |
shulabramble |
#action sleary and sandbergja will report progress on test writing wiki pages next month / at hackaway |
| 15:11 |
sandbergja |
very happy if people discuss tests at hackaway though :-D |
| 15:11 |
shulabramble |
#topic bug 2076921 expected to get more testing and merged, and beta uploaded to store |
| 15:11 |
pinesol |
Launchpad bug 2076921 in Evergreen "Hatch: Chrome Extension Requires Redevelopment" [High,Confirmed] https://launchpad.net/bugs/2076921 - Assigned to Jeff Godin (jgodin) |
| 15:12 |
berick |
jeff did some testing, many thanks |
| 15:12 |
shulabramble |
jeff++ |
| 15:34 |
shulabramble |
jeff++ abneiman++ jihpringle++ |
| 15:34 |
shulabramble |
phasefx++ |
| 15:35 |
abneiman |
jihpringle++ |
| 15:35 |
shulabramble |
#action revisit feasibility of automated testing for string changes |
| 15:36 |
shulabramble |
alrighty, moving on |
| 15:36 |
shulabramble |
#topic Updates |
| 15:36 |
shulabramble |
There's nothing on the agenda for these, but I know we had an Evergreen update since the last meeting. |
| 15:37 |
shulabramble |
so 3.14 release team++ |
| 15:37 |
Bmagic |
+1 |
| 15:37 |
phasefx |
release_team++ |
| 15:38 |
shulabramble |
is it time to assemble a 3.15 release team? |
| 16:12 |
shulabramble |
I own four cats. I have experience. |
| 16:12 |
scottangel |
shulabramble++ |
| 16:12 |
shulabramble |
#topic Okay to merge LP 2055796? berick mentioned "unclear if there's any additional decision processes re: adding github actions" |
| 16:12 |
pinesol |
Launchpad bug 2055796 in Evergreen "Have github actions run pgtap tests for us" [Undecided,Confirmed] https://launchpad.net/bugs/2055796 - Assigned to Bill Erickson (berick) |
| 16:12 |
smayo |
shulabramble++ |
| 16:12 |
shulabramble |
sandbergja? |
| 16:12 |
sandbergja |
yes, pasting some text |
| 16:13 |
sandbergja |
The back story: we used to have our tests automatically running regularly (2x/day?), and alerting IRC if there was a test failure. This has not worked for some time, so currently we don't find out about those bugs we've added to Evergreen until somebody runs the tests manually (which may be a while later). Github offers free infrastructure for running tests, so a year ago, we decided to explore |
| 16:13 |
sandbergja |
I have a pull request to get our pgtap (database) tests running automatically on github actions, berick has reviewed it but mentioned "unclear if there's any additional decision processes re: adding github actions". |
| 16:13 |
sandbergja |
I figured this was the place to ask. :-) |
| 16:13 |
phasefx |
testing would be easier with simpler installations... *runs away* |
| 16:13 |
sandbergja |
phasefx++ |
| 16:14 |
sandbergja |
100% agree |
| 16:15 |
berick |
any objections to running pgtap tests via github actions? going once? |
| 16:15 |
Bmagic |
berick says "strong +1 to merging" |
| 16:15 |
Bmagic |
no objections at all |
| 16:15 |
phasefx |
no objections to anyone maintaining testing infrastructure |
| 16:16 |
abneiman |
tests++ |
| 16:16 |
berick |
didn't think so, but it's kind of new, so.. |
| 16:16 |
berick |
sandbergja++ |
| 17:40 |
pinesol |
Launchpad bug 2032835 in OpenSRF "Discussion: Merge OpenSRF Into Evergreen?" [Wishlist,New] https://launchpad.net/bugs/2032835 |
| 17:41 |
sandbergja |
+1 |
| 17:42 |
Bmagic |
+1 |
| 17:48 |
pinesol |
News from commits: LP2055796: run pgtap tests on Github Actions <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7e83c5de8ca1e7530853878bc7562d961ce348c4> |
| 17:50 |
Bmagic |
sandbergja++ berick++ |
| 18:08 |
|
phasefx joined #evergreen |
| 18:08 |
|
abneiman joined #evergreen |
| 03:59 |
|
dashohoxha joined #evergreen |
| 04:05 |
dashohoxha |
Hello. I am trying to install Evergreen on docker container with Debian 12. Everything seems ok, but when I try to test the connection from 'srfsh', by giving 'login admin-user admin-pass', I get LOGIN_FAILED. |
| 04:06 |
dashohoxha |
srfsh# login admin TL2jEQrvp0aekJqh2Ww9 |
| 04:06 |
dashohoxha |
Received Data: "$2a$10$9qKCHyTrFu1NE30jX5LE3O" |
| 04:06 |
dashohoxha |
------------------------------------ |
| 04:06 |
dashohoxha |
Request Completed Successfully |
| 04:06 |
dashohoxha |
Request Time in seconds: 0.063436 |
| 04:06 |
dashohoxha |
------------------------------------ |
| 04:06 |
dashohoxha |
Received Data: { |
| 04:06 |
dashohoxha |
"ilsevent":1000, |
| 04:06 |
dashohoxha |
"textcode":"LOGIN_FAILED", |
| 04:06 |
dashohoxha |
"desc":"User login failed", |
| 04:06 |
dashohoxha |
"pid":594, |
| 04:06 |
dashohoxha |
"stacktrace":"oils_auth.c:794" |
| 04:06 |
dashohoxha |
} |
| 04:06 |
dashohoxha |
------------------------------------ |
| 04:06 |
dashohoxha |
Request Completed Successfully |
| 04:06 |
dashohoxha |
Request Time in seconds: 0.068730 |
| 04:06 |
dashohoxha |
------------------------------------ |
| 04:06 |
dashohoxha |
Login Session: (none). Session timeout: 0.000000 |
| 04:07 |
dashohoxha |
When I execute 'Open-ILS/src/support-scripts/settings-tester.pl', everything seems to be ok, except for this problem: |
| 04:08 |
dashohoxha |
Checking postgresql version |
| 04:08 |
dashohoxha |
psql (PostgreSQL) 16.4 (Debian 16.4-1.pgdg120+2) |
| 04:08 |
dashohoxha |
Checking libdbi and libdbi-drivers |
| 04:08 |
dashohoxha |
libdbi PostgreSQL driver not found in shared library path; |
| 04:08 |
dashohoxha |
you may need to edit /etc/ld.so.conf or add an entry to /etc/ld.so.conf.d/ |
| 04:08 |
dashohoxha |
and run 'ldconfig' as root |
| 04:09 |
dashohoxha |
Does anybody have any idea what this means and how to fix it? |
| 05:12 |
|
dashohoxha joined #evergreen |
| 06:53 |
|
JBoyer joined #evergreen |
| 07:03 |
|
collum joined #evergreen |
| 10:37 |
csharp_ |
dashohoxha: I would make sure ejabberd is functioning - also, look at the system logs at /openils/var/log/osrfsys.log (on a stock install) |
| 10:42 |
Bmagic |
csharp_: I'm not familiar with the nick, do you know if this is their first time installing? |
| 10:43 |
Bmagic |
I considered a response the the mailing list, but I wasn't sure where to begin :) |
| 10:45 |
dashohoxha |
I tried 'ldconfig' again, but this does not make 'settings-tester.pl' happy, it displays the same error message. Actually I looked at the code of 'settings-tester.pl', trying to find the part that outputs this error message, and it is something related to 'libdbpgsql': '/sbin/ldconfig --print | grep libdbdpgsql'. |
| 10:46 |
dashohoxha |
However I notice that the package 'libdbd-pgsql' (on Debian 12) is already installed. This is the closest that I could find to 'libdbpgsql'. |
| 10:49 |
dashohoxha |
About ejabberd, I have tested (as root) the commands that are suggested on the debug wiki page (which is a bit outdated by the way): 'ejabberdctl check_password opensrf public.localhost 445b8e76450077718e36effd3717a6486eae4208 ; echo $?' |
| 10:50 |
dashohoxha |
It gives 0 as a result, which means it is good. The same for the command: 'ejabberdctl check_password opensrf private.localhost 445b8e76450077718e36effd3717a6486eae4208 ; echo $?' |
| 10:53 |
|
Christineb joined #evergreen |
| 10:53 |
csharp_ |
dashohoxha: I think the pgdbd "problem" isn't worth investigating - it's more likely something within OpenSRF isn't running correctly - again, check the logfile I mentioned - look for things with "ERR" |
| 10:53 |
dashohoxha |
Checking '/openils/var/log/osrfsys.log', I see some error messages in it: |
| 10:54 |
csharp_ |
dashohoxha: use https://pastebin.com/ |
| 10:55 |
csharp_ |
dashohoxha: (also ensure nothing sensitive is in the logs before pasting) |
| 11:00 |
|
mmorgan1 joined #evergreen |
| 11:00 |
dashohoxha |
https://termbin.com/9tyr |
| 11:01 |
dashohoxha |
There is nothing sensitive in it because I am just trying to make a test installation. |
| 11:02 |
csharp_ |
sure |
| 11:03 |
csharp_ |
"Could not authenticate with Jabber server:" - the Jabber server will use whatever you have in username/password in the <opensrf> and <router> elements in /openils/conf/opensrf_core.xml, so first obvious step is to make sure that file is correct |
| 11:04 |
csharp_ |
does Debian use AppArmor? by default the apparmor profile for ejabberd is strict (on Ubuntu, anyway) |
| 10:06 |
|
BDorsey_ joined #evergreen |
| 10:18 |
|
Dyrcona joined #evergreen |
| 10:47 |
|
sandbergja joined #evergreen |
| 10:59 |
Dyrcona |
Has anyone gotten this with the 3.13.4 to 3.14.0 upgrade db script? "ERROR: ALTER TYPE ... ADD cannot run inside a transaction block". I'm only asking because I got it with another script that I wrote based on the 3.14 upgrade. However, I'm pretty sure that I didn't get it when I test the 3.14 upgrade after making it earlier this week. |
| 11:04 |
Dyrcona |
I am going to test the db upgrade again, this time on a Pg 10 database. It was Pg 10 where it failed on me. That behavior could have changed.... |
| 11:06 |
Dyrcona |
Yeah. It looks like it would fail with the same error... |
| 11:13 |
Dyrcona |
So, the 3.13.4-3.14.0 db upgrade works on Pg 16, which is where I think I tested it. I'll try Pg 10. |
| 11:18 |
redavis |
IIRC, we talked about stating that EG 3.14 required a minimum version of PG (I don't remember which) higher than 10 because it's out of support now. |
| 11:19 |
Dyrcona |
redavis: Yeah, but the release notes actually say it is compatible with Pg 10. We don't support less than Pg 13 for new installations. |
| 11:19 |
Dyrcona |
And, the upgrade fails on Pg 10. |
| 11:20 |
Dyrcona |
No, the release notes are correct. We changed it to be compatible. |
| 11:20 |
redavis |
Oh. okay |
| 11:20 |
redavis |
makes sense |
| 11:21 |
Dyrcona |
I swear I tested it on Pg 10, also, but I guess I didn't and thought that I had. |
| 11:21 |
Dyrcona |
I'll modify the db upgrade and put out a new tarball. |
| 11:21 |
Dyrcona |
We've had to do this before. |
| 11:21 |
redavis |
Dyrcona++ |
| 15:02 |
|
frank_g joined #evergreen |
| 15:05 |
|
Dyrcona joined #evergreen |
| 15:06 |
Dyrcona |
Hm.. wifi flaked out on me. |
| 15:11 |
frank_g |
Hi all, we are migrating from 3.4.2v to 3.12.0v in a new EG server, and a Library Staff is testing the Staff view, but he says that the records migrated dont show the complete information in the Staff view label, He created a new record and it shows the complete information, so I tested just saving the old record (without any change), and now the |
| 15:11 |
frank_g |
record shows the complete information, My question is, Is there a Script that I have to run to upadte all records to show the complete information in Staff view label? Or the library staff has to open-save each record to update them? I hope I explain it correctly, tks |
| 15:14 |
Dyrcona |
frank_g: You are pretty much guaranteed to have to run some kind of ingest jumping over that many versions. I recommend running pingest.pl. It's installed in /openils/bin. |
| 15:17 |
Dyrcona |
I bet the library kicked me off the wifi for going over a data cap. :) |
| 15:21 |
Dyrcona |
Good thing Verizon doesn't care, so long as I pay my bill. |
| 16:58 |
Bmagic |
I'm struggling to get Evergreen to install from scratch, and again, I think I've tracked it back to this perl issue |
| 16:58 |
dbriem |
mmorgan thanks |
| 16:58 |
Bmagic |
it's not just Email::Send that isn't getting installed |
| 16:58 |
dbriem |
yeah it has a dependency that's has failing tests |
| 16:59 |
Bmagic |
Email::Abstract isn't making it either |
| 17:01 |
Bmagic |
I'm checking to see if I can get a system up and running without having to install from cpan |
| 17:02 |
dbriem |
if i install Module::Pluggable directly, then Email::Send installs through cpan for me |
| 17:22 |
Bmagic |
Submitted a patch for it: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/blake/install_pluggable_dependency |
| 17:22 |
Bmagic |
how annoying |
| 17:24 |
Bmagic |
that patch is really just for me and anyone else who's intersted, there's no LP yet, and it's just for jammy. I've not explored any of the other supported OSes. And it might just be for docker installs. I'm holding out hope that it will be resolved on the cpan side and we won't have to do anything for real |
| 17:41 |
dbriem |
i used the ansible installer (by the way, thank you berick for that, it's awesome) and ran into the same issue, hopefully Module::Pluggable can address that test. in the meantime i have your patch, thanks. |
| 12:25 |
|
jihpringle joined #evergreen |
| 12:27 |
jeffdavis |
Only 79 more releases until that statement is valid, maybe we should just leave it in. |
| 12:27 |
Dyrcona |
Heh. |
| 12:28 |
* Dyrcona |
tests the 3.14.0 db upgrade script because it needed to be modified. |
| 12:29 |
Dyrcona |
Works for me! |
| 12:35 |
Bmagic |
are the branches ready for build (I'm mostly asking about "my" branch rel_3_13) ? |
| 12:35 |
Dyrcona |
Bmagic: I believe so. |
| 12:57 |
Dyrcona |
IDK. |
| 12:57 |
pinesol |
News from commits: Forward-port 3.12.7-3.12.8 upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=6bc0f2ade724e4e1e083465efc33526edc3d2e59> |
| 12:58 |
Dyrcona |
It should be the same as main at this point. |
| 12:58 |
sandbergja |
Bmagic (and anybody else who might wish to test it): 3.12.8 is done building, tarball and other build artifacts are available at https://drive.google.com/drive/folders/19pGPywtrTbohBre-EBpQcoQptHXb6Bgu?usp=sharing |
| 12:58 |
Dyrcona |
I don't really understand our translation process. I think it all needs to be simplified. |
| 12:58 |
Dyrcona |
sandbergja++ |
| 12:59 |
Dyrcona |
3.41.0 is also done. I just copied the files to lupin. |
| 13:06 |
Dyrcona |
I make mistakes sometimes. This multistep process invites error. |
| 13:07 |
Bmagic |
I think we all agree with you |
| 13:07 |
|
sandbergja joined #evergreen |
| 13:08 |
Dyrcona |
I tested this all yesterday, minus the tarball part, so I think I'm just going to get the files in place once you're ready. I'll put sandbergja's files on the server and put them in place at the same time. |
| 13:09 |
|
collum joined #evergreen |
| 13:12 |
Dyrcona |
That's going to take a couple of minutes over the cell network. |
| 13:17 |
Dyrcona |
Wonder if I've hit a cap on my unlimited plan. Seems like they're slowing me down. |
| 16:33 |
Dyrcona |
Cool. |
| 16:33 |
Bmagic |
https://evergreen-ils.org/downloads/Evergreen-ILS-3.13.5.tar.gz |
| 16:34 |
Dyrcona |
Can you upload it to Lupin, or do you ... |
| 16:34 |
Bmagic |
you have one for me to test? |
| 16:35 |
Dyrcona |
https://evergreen-ils.org/downloads/Evergreen-ILS-3.14.0.tar.gz |
| 16:36 |
Bmagic |
sweet, testing |
| 16:39 |
Dyrcona |
Hmm... I should see if I have a clean vm on my laptop. If not, I should probably start a new one. The one I was going to use is "contaminated" with the 3.14 prerequisites. |
| 16:40 |
Bmagic |
we do have the handy dandy docker tarball builder |
| 16:40 |
Dyrcona |
I'd have to install docker and learn it just enough. I've got a got a clean Debian 12 vm. |
| 17:01 |
|
mmorgan left #evergreen |
| 17:02 |
Dyrcona |
Had to force it off. |
| 17:07 |
|
sandbergja joined #evergreen |
| 17:08 |
sandbergja |
Bmagic: fyi, I wrote down the steps that I use to test a tarball using your docker magic on the wiki: https://wiki.evergreen-ils.org/doku.php?id=qa:testing_a_tarball&s[]=testing&s[]=tarball |
| 17:08 |
Bmagic |
sandbergja++ |
| 17:09 |
sandbergja |
I'm going to try it for the 3.13.5 tarball to see if I wrote them down correctly hahaha |
| 17:10 |
Bmagic |
heck yeah |
| 17:12 |
sandbergja |
found some of my typos already whooo! |
| 17:25 |
Dyrcona |
typos-- |
| 17:26 |
Dyrcona |
Dang. forgot autogen.sh before running the tests and the usual suspects are failing... |
| 17:31 |
Dyrcona |
Bmagic: The 3.13.5 tarball gets a thumbs up from me. |
| 17:31 |
Dyrcona |
I have to pick my daughter up and won't be home for a couple of hours, so I an update the downloads page then. |
| 17:31 |
Bmagic |
same for 3.14.0 from me, though, for fun, I'm running some of the automated test |
| 17:32 |
Dyrcona |
I always run the tests. |
| 17:32 |
Bmagic |
all of em? nightwatch, headless firefox, etc? |
| 17:32 |
Dyrcona |
Not always ALL of them. I often skip nightwatch. |
| 17:33 |
Dyrcona |
Anyway, I got to go. |
| 17:50 |
sandbergja |
the fewer assumptions they make, the better |
| 17:50 |
Bmagic |
yeah, it's bubbling higher and higher on my priority list. I'm going to take it on |
| 17:50 |
sandbergja |
Bmagic++ |
| 17:51 |
Bmagic |
that is to say: I want to make an LP report for our tests in general, with the notion of going over each one, one by one and making them work with any dataset, and maybe eliminating some test that don't make sense. With an end goal of clean and working test sets for each of the languages that we're testing |
| 17:52 |
sandbergja |
that would be sweet, Bmagic! |
| 17:53 |
Bmagic |
It's too soon for me to make report though. I don't know what I don't know |
| 17:54 |
sandbergja |
I opened bug 2053095 earlier -- I guess I should also add the pgtap live tests to this list |
| 17:54 |
pinesol |
Launchpad bug 2053095 in Evergreen "Make tests compatible with the enhanced concerto data set" [Undecided,New] https://launchpad.net/bugs/2053095 |
| 17:54 |
Bmagic |
maybe we use that one |
| 17:55 |
Bmagic |
I will say that the standard concerto set takes much less time to reload/install |
| 17:55 |
Bmagic |
so, resetting the database each time we run your ansible run_test.yml script, becomes a larger endevour |
| 17:57 |
sandbergja |
ah! I keep meaning to check that out. |
| 17:58 |
sandbergja |
I will say, I LOVED building the tarball today with the dev container. Having the repo mounted as a volume worked really nicely. |
| 17:59 |
Bmagic |
excellent |
| 17:59 |
sandbergja |
3.13.5 tarball looks good to me too! |
| 18:00 |
sandbergja |
Bmagic: in case you run the nightwatch tests, there is one failure I get that points to this regression: bug 2067160. |
| 18:00 |
pinesol |
Launchpad bug 2067160 in Evergreen "Holdings editor regression: Can no longer remove a default item alert type" [Medium,Confirmed] https://launchpad.net/bugs/2067160 - Assigned to Jane Sandberg (sandbergja) |
| 18:00 |
sandbergja |
I keep meaning to submit a patch for it -- Dan even left a comment saying exactly what needs to be done -- but I haven't gotten around to it yet. |
| 18:04 |
sandbergja |
heading out -- have a good night, Evergreen! |
| 11:32 |
Dyrcona |
I'll wait for your push. |
| 11:33 |
Dyrcona |
Y'know...it's close enough. I'll grab my lunch and eat at my desk. |
| 11:34 |
|
sandbergja joined #evergreen |
| 11:35 |
sandbergja |
Dyrcona it'll take me a bit to push, I want to run the live tests one last time, and am also getting distracted by a few other things simultaneously. |
| 11:39 |
* jeffdavis |
enjoys a cup of Ethiopia Washed Yirgacheffe, Koke Grade 1 |
| 11:46 |
* Dyrcona |
enjoys Sunday dinner leftovers: rib roast, potato and carrot. |
| 11:48 |
sandbergja |
One of the live tests is failing with "Method [open-ils.actor.user.penalty.remove] not found for OpenILS::Application::Actor" -- did that method get removed recently? |
| 11:48 |
sandbergja |
I am pretty confident that it's unrelated to this acq/cat patch |
| 11:48 |
|
collum joined #evergreen |
| 11:50 |
eeevil |
sandbergja: (mostly for the room and logs) as a general rule, if unrelated methods start failing it's often a perl syntax error earlier in a sub-module, and the methods aren't getting registered because of that |
| 11:50 |
Dyrcona |
Yeah. I'll take a look. |
| 11:52 |
jeffdavis |
open-ils.actor.user.penalty.remove was changed to open-ils.actor.user.note.remove |
| 11:53 |
eeevil |
jeffdavis++ |
| 11:53 |
Dyrcona |
I was going to check on rel_3_14 on my release vm, but jeffdavis++ |
| 11:53 |
sandbergja |
jeffdavis++ |
| 11:53 |
sandbergja |
eeevil: main seems okay as in the test passes on main for you? |
| 11:53 |
Dyrcona |
That should probably go in an upgrade note. |
| 11:54 |
eeevil |
sandbergja: sorry, no, I didn't run the tests, I just checked the syntax with `perl -wc` |
| 11:54 |
sandbergja |
gotcha |
| 11:55 |
Dyrcona |
I'll make a Lp bug and post a fix if no one else wants to. |
| 11:57 |
Dyrcona |
eeevil: Do you have a strong opinion on Lp 2083873? Today would be a good time to hash it out. |
| 11:57 |
pinesol |
Launchpad bug 2083873 in Evergreen "Remove support for PostgreSQL 10, 11 and 12" [Undecided,New] https://launchpad.net/bugs/2083873 |
| 11:59 |
sandbergja |
Dyrcona++ |
| 11:59 |
eeevil |
Dyrcona: my preference would be, if testing proves it works for $not_me, to include the back-compat change, and drop fresh-install-support for 10-12... too much to ask? :) |
| 12:00 |
Dyrcona |
It's not too much to ask. I noticed anycompatible is also used in the reporter, probably the security or Angular update. That would need a fix, too. |
| 12:01 |
eeevil |
it's the reports security stuff that I offered a change to, IIRC |
| 12:01 |
Dyrcona |
Oh, OK!. I thought I saw it somewhere twice. I'll double check. I'm probably hallucinating things from looking at too much code over the past couple of weeks. |
| 12:02 |
|
jihpringle joined #evergreen |
| 12:02 |
eeevil |
yeah, it is. the patch as offered is meant to modify things in-place for any branch that contains the reports security stuff. no /new/ upgrade script, just pretend that didn't happen |
| 12:02 |
Dyrcona |
First verify the test failure for myself so I can write a Lp bug and post a fix. After that the anycompatible thing.... Got it! No one should have it in production, yet. |
| 12:03 |
eeevil |
right, that's my thinking. if they do, they know how to handle pre-release changes :) |
| 12:03 |
eeevil |
(I HOPE!) |
| 12:06 |
Dyrcona |
:) |
| 12:06 |
* Dyrcona |
has had fun with those in the past. |
| 12:08 |
pinesol |
News from commits: LP#2084096: Add a test for lineitem deletion <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=563d3604c39910d076774b191ff72163f5671b3b> |
| 12:08 |
pinesol |
News from commits: LP#2084096: Fix issue with line item cancellation and undefined volume <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=532d8be5391516a743c9ad84c23fa80e47049246> |
| 12:12 |
Dyrcona |
sandbergja++ eeevil++ |
| 12:31 |
Dyrcona |
Hmm.. Setting up a vm to test a few things and osrf_control is taking a long time to exit. |
| 12:32 |
|
collum joined #evergreen |
| 12:35 |
Dyrcona |
This is latest main on Ubuntu 24.04, and osrf_control -l --start-all seems hang after starting opensrf.slooooooow. |
| 12:37 |
Dyrcona |
Some listeners and drones won't go away with just a plain 'kill.' |
| 15:26 |
berick |
oh yeah.. i do know it |
| 15:26 |
Dyrcona |
Just listen to the musicianship... It's near perfection. |
| 15:27 |
berick |
yeah, they often are |
| 15:28 |
Dyrcona |
jeffdavis++ the tests pass. |
| 15:29 |
Dyrcona |
I'm tempted to just push your fix now, but maybe I'll add a signoff and wait a day or two if someone else wants to look. |
| 15:36 |
redavis |
Dyrcona++ jeffdavis++ |
| 15:39 |
Dyrcona |
Resist the urge to Push ALL THE THINGS!!!! |
| 15:39 |
redavis |
Why resist? :D (if they're tested and ready to go) |
| 15:42 |
Dyrcona |
Yes, some are signedoff. I still like to at least look at the code and run a few tests before. |
| 15:44 |
redavis |
lol, well, yes. But...once you do... |
| 15:44 |
redavis |
you get a commit and YOU get a commit |
| 15:45 |
Dyrcona |
\o/ |
| 11:59 |
Dyrcona |
Yeah, this worked: ^=== \(.+?\)\( ===\)?$ |
| 11:59 |
Dyrcona |
That's 3 problems solved. :) |
| 11:59 |
redavis |
Dyrcona |
| 12:00 |
Dyrcona |
** is bold in asciidoc, too, right? I guess I'll find out when I generate a test html doc. |
| 12:00 |
redavis |
Just *[something]* |
| 12:00 |
Dyrcona |
I thought *something* is italics. |
| 12:00 |
Dyrcona |
I'll fix it if I botched it. should be easy enough. |
| 12:17 |
Dyrcona |
We could probably script this conversion from === to ** in the subsections. |
| 12:18 |
|
frank_g joined #evergreen |
| 12:20 |
redavis |
It looks like both * and ** work the same. I've updated the file if you don't have the whole thing done. |
| 12:24 |
frank_g |
Hi all, I am trying to migrate my EG server to a new production server, the librarian is testing on it, and she is trying to create a new marc record, but when she tries to save it it shows the error : "Failed to create new record: {{error}}", and checking on the osrfsys.log there appears this error " open-ils.cstore ERROR inserting |
| 12:24 |
frank_g |
biblio::record_entry object using query [...., ERROR: Can't locate MARC/Record.pm in @INC (you may need to install the MARC::Record module) (@INC entries checked: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.38 |
| 12:24 |
frank_g |
/usr/share/perl/5.38 /usr/local/lib/site_perl) at line 3" |
| 12:25 |
frank_g |
Do I have to install somenting else? or it is a kind of bug? |
| 12:25 |
Dyrcona |
frank_g: You need to install the database perl prerequisites on the database server. |
| 12:27 |
Dyrcona |
Evergreen uses Perl functions in the database. |
| 12:27 |
Dyrcona |
Or, you may need to install the prerequisites on your new server again. That might not be from the database now that I look again. |
| 15:25 |
|
mantis left #evergreen |
| 15:34 |
|
redavis joined #evergreen |
| 15:50 |
abneiman |
redavis: Dyrcona: re above, I can check the relnotes formatting etc. on Friday if it's still giving you trouble |
| 15:50 |
redavis |
It's taken care of. Bmagic is going to test the tarball and then we're good to go to next step. Thank you though. Will let you know if there are additional things. |
| 15:54 |
Bmagic |
will do |
| 15:54 |
|
jihpringle joined #evergreen |
| 15:54 |
abneiman |
++ |
| 10:05 |
jeff |
random friday morning musings. |
| 10:05 |
scottangel |
sleary++ |
| 10:05 |
scottangel |
sandbergja++ |
| 10:07 |
jeff |
And while I still like the overall idea of autogenerated translations to aid dev/test by persons who don't speak multiple languages fluently, in the longer term some of that can probably be covered by different forms of automation that don't have a human in the loop. |
| 10:08 |
scottangel |
Thanks! I didn't think it was using an older version than 15. Once I get my act together today I'll go down that rabbit hole and see if I get anywhere! lol Thanks! I started on this one. #1770289 |
| 10:12 |
sleary |
jeff++ |
| 10:13 |
sleary |
if anyone has time to review bug 2084166, we would love to fix that for old-school template people |
| 10:42 |
sleary |
day/month/year? they should be below the inputs |
| 10:43 |
sleary |
IIRC you can switch that around with CSS |
| 10:46 |
Dyrcona |
They are below on Bootstrap, but to the right of the fields on TTOPAC. Could be some of our customization/missing styles. |
| 10:47 |
Dyrcona |
I'll fire up the vm I was using yesterday to test vanilla Evergreen and see how it looks there. |
| 11:03 |
Dyrcona |
sleary: Yeah, on stock in ttopac the labels are to the right of the fields. It's OK with me, but not sure that's what you wanted. I'll add a screenshot to a bug comment. |
| 11:09 |
sleary |
thanks, I can add a quick style change |
| 11:24 |
|
Christineb joined #evergreen |
| 12:00 |
Dyrcona |
Well, how nice of them. |
| 12:00 |
Dyrcona |
jeff: Are you done checking the Hatch changes? |
| 12:04 |
|
jihpringle joined #evergreen |
| 12:17 |
jeff |
ready to start beta testing in chrome web store. who has credentials? :-) |
| 12:23 |
Dyrcona |
JBoyer, I think has credentials, maybe berick? |
| 12:23 |
Dyrcona |
I don't. |
| 12:23 |
* Dyrcona |
looks at some more dark mode patches. |
| 12:23 |
berick |
i should, yes, checking |
| 12:30 |
berick |
i'm in. |
| 12:31 |
berick |
poking around to find the beta options.. |
| 12:31 |
jeff |
take that hoodie off, and why are you wearing those ridiculous sunglasses? we're indoors! |
| 12:32 |
jeff |
you should be able to establish a beta program if there isn't one already, where users can be added or opted in. it's the easiest/best way to test the "new version from chrome web store rolls out to installed browsers, what happens?" bit. |
| 12:37 |
|
jihpringle joined #evergreen |
| 12:37 |
berick |
who wants to be added as a trusted Hatch extension tester? |
| 12:37 |
berick |
just need emails |
| 12:45 |
pinesol |
News from commits: lp2083088 Patron Registration Contrast in Light mode <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=21cadbda68032a3acdeb7f7a7832a0f4a38c1b11> |
| 12:45 |
pinesol |
News from commits: LP2080885 Dark mode followup: Offline Circ Ignores Setting <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1917d9c0582638beb92c5e6a3ca17f4f8286ee42> |
| 12:46 |
Dyrcona |
Lp seems to be a bit slow sending email today, or maybe it is just me. |
| 12:51 |
Dyrcona |
berick: I'll check with jamundson if he would like to test it. |
| 12:52 |
berick |
ugh it's really not obvious if I'm unlisting the extension entirely or just this build |
| 12:53 |
Dyrcona |
berick: I was just going to ask how do we get to the beta to test it. |
| 12:54 |
Dyrcona |
We've apparently had 1 library's IT remove Hatch because of the "errors." |
| 12:54 |
berick |
well i usually just install it locally. i've never done the beta setup through the chrome store |
| 12:54 |
berick |
but once i figure this out, i just share a link to it |
| 13:01 |
berick |
Dyrcona: you can manually install exntensions locally using the developer mode toggle on chrome://extensions/. you just "Load unpacked" the Hatch/extension/app directory |
| 13:01 |
* berick |
will have to come back to this later |
| 13:01 |
Dyrcona |
Ok. I can try building it myself. Never done that before. Always willing to learn something knew. |
| 13:06 |
jeff |
doing it as a beta extension won't help test much of what I'd actually wanted to test, because it'll have a different extension/app id, etc. |
| 13:07 |
jeff |
even with a limited rollout percentage, it looks like there's no real way to let a user force-acquire the latest version. |
| 13:13 |
|
kmlussier1 joined #evergreen |
| 13:21 |
Dyrcona |
Ugh. Maybe I should have just let fetch-deps.sh finish rather than trying to do with Ubuntu packages.... |
| 13:23 |
Dyrcona |
Looks like everything is linked in /usr/share/java, so that makes things easier. |
| 14:19 |
Dyrcona |
Looks like the "evil" license has been replaced with just "Public domain." |
| 14:20 |
Dyrcona |
Hey, Toto... Why did we go down this rabbit hole? |
| 14:27 |
Dyrcona |
En fin! |
| 14:32 |
Dyrcona |
Meh. The test fails.... |
| 14:32 |
Dyrcona |
It either can't find javafx.media or javafx.controls and I've added those modules. |
| 14:34 |
Dyrcona |
Oh. bad path. |
| 14:40 |
Dyrcona |
Oh. I think I've learned a lot about Hatch, though I've probably not got anything that I can give to someone else and say, "Install this." |
| 14:45 |
Dyrcona |
I don't know if it does that, but it could probably be added if not. |
| 14:45 |
Dyrcona |
I think it's time to take a break and find something to eat. |
| 14:50 |
|
mmorgan left #evergreen |
| 15:38 |
csharp_ |
still fighting with IDL2js - does anyone know where I can see the cached object/file/whatever? |
| 15:39 |
csharp_ |
the perlmod uses APR::Brigade/APR::Bucket, but they don't seem to be called explicitly so I don't know what happens to the file - I'm just trying to troubleshoot why the PINES-ified 3.14 beta is creating an invalid file |
| 15:39 |
csharp_ |
3.14 stock on top of an upgraded PINES DB works as expected |
| 15:39 |
csharp_ |
fm_IDL.xml passes xmllint tests |
| 15:40 |
csharp_ |
also, I switched in the stock fm_IDL.xml file with the same result, but since I don't know where the cache is or what it's doing or how to clear it, I'm just running in circles |
| 15:41 |
csharp_ |
it doesn't appear in memcdump from the memcached servers |
| 15:42 |
|
smayo joined #evergreen |
| 15:44 |
|
mmorgan joined #evergreen |
| 15:46 |
csharp_ |
@blues idl2js |
| 15:46 |
pinesol |
csharp_: I eat more coconut cream pie before breakfast than most people eat all day |
| 15:46 |
csharp_ |
pinesol: zoia was better |
| 15:46 |
pinesol |
csharp_: As great as you are man, you'll never be greater than yourself. |
| 09:23 |
sandbergja |
I'll confess to being a little tired of reading through long launchpad threads to try to understand which of 5 possible branches I'm actually supposed to review (and guessing wrong on multiple occassions). |
| 09:23 |
Dyrcona |
Running gitolite is easier than running gitlab in my experience. It has fewer features, but do we need those features? |
| 09:23 |
Dyrcona |
Yeah, same here, but we'd probably still have that problem with gitlab/github issues. |
| 09:23 |
sandbergja |
one of the features that gitlab provides (including in CE) is the ability to automatically run all our tests on each merge request |
| 09:24 |
Dyrcona |
We could do that with a post-receive hook in git. |
| 09:24 |
csharp_ |
adding insult to injury, APT tries to install the most recent release and then you get scolded for trying to skip versions :-/ |
| 09:25 |
csharp_ |
re: "long launchpad threads" that seems to be a process problem rather than a software problem, but I completely agree |
| 09:32 |
Dyrcona |
redavis: I added you sign off to the omnibus branch because you signed off on some of the fixes. Ditto for Christineb. |
| 09:33 |
redavis |
Dyrcona++ #it was def a collab (not branch) |
| 09:33 |
Dyrcona |
Well, if we hosted our Lp or Gitlab, git and the issues would be in the same place. Same thing with moving to Github. |
| 09:33 |
sandbergja |
I dunno, it's just... every other project I'm a committer for has already run the test so I can review the results as part of my review, gives me a nice UI to review changes rather than having to determine a base commit and then count multiple commits, gives me a cute green button to press rather than having to count commits again... I get some |
| 09:33 |
sandbergja |
of the reasons why we make it harder than other communities do, but that doesn't make it any more enjoyable/productive for me. |
| 09:33 |
csharp_ |
redavis: inertia is hard to break |
| 09:33 |
redavis |
Ahh, that makes sense. |
| 09:34 |
Dyrcona |
I suppose we could move our git to Launchpad as well. There's already a mirror there. We could make it the main repo. Our working repo is a bit unusual. Most projects don't have something like that. |
| 10:30 |
|
Dyrcona joined #evergreen |
| 10:41 |
|
berick joined #evergreen |
| 10:47 |
|
Christineb joined #evergreen |
| 11:26 |
Dyrcona |
Huh... My test system apparently doesn't have my logos, or they're in the wrong place.... |
| 11:32 |
Dyrcona |
So, I put them in /opac/images/ but looks like the template looks for them in /images/... Wonder if I missed a customization or something changed? |
| 11:33 |
* Dyrcona |
moves them for now and will worry about it later. :) |
| 11:55 |
|
redavis joined #evergreen |
| 15:26 |
Dyrcona |
No, not at all. |
| 15:26 |
sleary |
yeah, sounds like the library is missing |
| 15:27 |
Dyrcona |
It's working on the concerto vm, so I'll try it again on the upgraded one with production data in a bit. So far, things are looking good. |
| 15:27 |
sleary |
awesome. Dyrcona++ |
| 15:29 |
sleary |
oh, and on another note, I was going to say that color contrast is just about the easiest accessibility issue to check. Grab axe DevTools or use Lighthouse with the Accessibility option checked, and it'll tell you what to change. |
| 15:29 |
sleary |
(Lighthouse is slower because it runs *all* its tests no matter which options you check... argh) |
| 15:30 |
Dyrcona |
OK. I'll give it a look. |
| 15:32 |
redavis |
column added. That info was already included in the info about enhanced concerto |
| 15:39 |
Dyrcona |
OK. Date picker is working after npm install in opac/deps and a make install. |
| 16:18 |
sleary |
haven't really thought that far ahead though |
| 16:30 |
csharp_ |
<homer>mmmm fish to fry aggghghghghgh</homer> |
| 16:37 |
* abneiman |
looks up when the local AME has their next fish fry, because it's a culinary highlight 'round here |
| 16:45 |
* Dyrcona |
needs to adjust the OPAC timeout while testing. I keep getting logged out. I changed it to 5 minutes to test the new dialog. |
| 16:47 |
sleary |
I did that too, and regretted my choices |
| 16:49 |
sleary |
I guess it's a taste of how annoying that feature is for assistive device users |
| 16:52 |
Dyrcona |
Well, I had a search results page open that I was looking at to verify the accessibility changes, and it would get rest to the home page while I was reading one of the specific Launchpad bugs. |
| 17:10 |
abneiman |
but yeah, we have a list of names that I was also planning to add to release notes |
| 17:11 |
abneiman |
Dyrcona: this is on its way thru the tubes for you |
| 17:11 |
sleary |
abneiman++ |
| 17:12 |
abneiman |
BC Coop was the main sponsor, NNELS did two rounds of testing: first to ID the issues, second to confirm fixes. |
| 17:12 |
Dyrcona |
abneiman++ |
| 17:13 |
Dyrcona |
I think we already have BC Libraries Coop as a sponsor, but if not I'll add them when I add this. Probably tomorrow. |
| 17:13 |
sleary |
Dyrcona++ thanks for going over all of it! |
| 15:15 |
Bmagic |
abneiman++ |
| 15:15 |
redavis |
abneiman++ |
| 15:15 |
Dyrcona |
abneiman++ |
| 15:15 |
shulabramble |
#info waiting on gmcharlt for access to POEditor for git integration |
| 15:15 |
shulabramble |
#action waiting on gmcharlt for access to POEditor for git integration |
| 15:15 |
shulabramble |
#info sleary and sandbergja will create/consolidate the test writing wiki page(s) |
| 15:16 |
sleary |
#info in progress! We will have more to report next month / at hackaway |
| 15:16 |
Dyrcona |
sleary++ sandbergja++ |
| 15:17 |
shulabramble |
#action sleary and sandbergja will report progress on test writing wiki pages next month / at hackaway |
| 15:17 |
Bmagic |
sleary++ sandbergja++ |
| 15:17 |
shulabramble |
sleary++ sandbergja++ |
| 15:17 |
shulabramble |
#info bug 2076921 expected to get more testing and merged, and beta uploaded to store |
| 15:17 |
pinesol |
Launchpad bug 2076921 in Evergreen "Hatch: Chrome Extension Requires Redevelopment" [High,Confirmed] https://launchpad.net/bugs/2076921 - Assigned to Jeff Godin (jgodin) |
| 15:17 |
redavis |
sleary++ sandbergja++ |
| 15:17 |
jeff |
testing in progress, will coordinate with berick later this week |
| 15:18 |
redavis |
jeff++ berick++ |
| 15:18 |
shulabramble |
yay! jeff++ |
| 15:18 |
shulabramble |
berick++ |
| 15:18 |
Dyrcona |
jeff++ berick++ |
| 15:18 |
sleary |
jeff++ berick++ |
| 15:18 |
shulabramble |
#action bug 2076921 expected to get more testing and merged, and beta uploaded to store |
| 15:18 |
pinesol |
Launchpad bug 2076921 in Evergreen "Hatch: Chrome Extension Requires Redevelopment" [High,Confirmed] https://launchpad.net/bugs/2076921 - Assigned to Jeff Godin (jgodin) |
| 15:19 |
shulabramble |
#topic updates |
| 15:19 |
shulabramble |
#info OpenSRF |
| 15:23 |
redavis |
We're still on schedule for next Wednesday |
| 15:23 |
Dyrcona |
Well, it should be out next week pending results of the feedback fest. |
| 15:23 |
abneiman |
redavis++ jvwoolf++ |
| 15:23 |
sleary |
super extra kudos to everyone who's been learning new skills to help test the accessibility bugs! |
| 15:23 |
shulabramble |
#info 3.14rc on target for Wednesday Oct 16 |
| 15:23 |
terranm |
10 new bugs reported, but not all of them are related to 3.14 |
| 15:23 |
redavis |
I've updated the agenda with that. Also terranm++ for doing two rounds of feedback for this reason. |
| 15:41 |
shulabramble |
redavis++ |
| 15:43 |
abneiman |
and it looks like 3.12 and 3.13 only have a handful of things on them so hopefully not too onerous |
| 15:43 |
sleary |
I will have some keyboard shortcut fixes for 3.13 (MARC editor) hopefully |
| 15:43 |
redavis |
It'd be good to have some help building/testing tarballs at the least. |
| 15:45 |
|
mantis1 joined #evergreen |
| 15:45 |
shulabramble |
anyone want to volunteer to help the security team with tarball tests? |
| 15:46 |
redavis |
Oh, release team...sorry. |
| 15:46 |
shulabramble |
anyone want to volunteer to help the release team with tarball tests? :) |
| 15:46 |
redavis |
Just fill out that buildmaster sheet if you want to. |
| 15:47 |
redavis |
Think about it. Dream about it. |
| 15:47 |
shulabramble |
Meditate on it at second level. |
| 17:45 |
csharp_ |
hmm - noticing the lack of a 3.13.3-3.13.4 upgrade script |
| 17:51 |
csharp_ |
psql:3.13.4-3.14-beta-upgrade-db.sql:534: ERROR: unsafe use of new value "mfa" of enum type config.usr_activity_group -hmmm |
| 17:51 |
csharp_ |
HINT: New enum values must be committed before they can be used. |
| 17:54 |
csharp_ |
ah, the inline comments even say that needs to happen outside a transaction but the only COMMIT; is at the end of the file |
| 18:04 |
csharp_ |
fixed by adding COMMIT; before and BEGIN; after 1433 |
| 18:06 |
csharp_ |
...and, now I'm on 3.14.beta on my test server. huzzah! |
| 18:06 |
csharp_ |
seems like as good a time as any to call it a day :-) |
| 18:18 |
|
kmlussier left #evergreen |
| 19:19 |
|
jihpringle joined #evergreen |
| 09:12 |
|
Dyrcona joined #evergreen |
| 09:17 |
Dyrcona |
Bmagic++ |
| 10:14 |
|
mantis joined #evergreen |
| 10:15 |
terranm |
csharp++ for helping get my test server back on track |
| 10:15 |
terranm |
https://terran-main.gapines.org is up and running with the 3.14 beta - please test for Feedback Fest! |
| 10:15 |
mantis |
does anyone know what generates the 'hold expired' patron notes? I couldn't find anything about this in the docs. I wasn't sure if it was a specific library setting or if this happens automatically. I tried testing it with a hold that had a shorter shelf expire time, and when the hold was canceled and pulled, it didn't generate a note for my OPAC account. |
| 10:16 |
terranm |
mantis: I believe those are created by an action trigger |
| 10:16 |
mantis |
terranm++ |
| 10:17 |
terranm |
Hold Cancelled (Shelf-expired) User Message |
| 14:49 |
Dyrcona |
Take a few days off.... |
| 14:51 |
Dyrcona |
:) |
| 14:58 |
|
mantis1 left #evergreen |
| 15:01 |
Dyrcona |
Argh! I hit the type anycompatible does not exist while testing my upgrade on Pg 10..... |
| 15:01 |
Dyrcona |
That means another dump and restore to test it properly.... |
| 15:03 |
Dyrcona |
But! I can't restore the database as it exists on Pg 16, either.....It needs to be updated to at least Evergreen 3.10.x.... or something like that.... |
| 15:03 |
Dyrcona |
Sometimes, I hate how nitpicky this crap ends up being. |
| 15:03 |
* Dyrcona |
looks for a certain bug on Lp. |
| 15:41 |
sleary |
terranm Bmagic I found the issue with the AngularJS menus. Both branches for bug 2080438 have an additional commit to fix it. |
| 15:41 |
pinesol |
Launchpad bug 2080438 in Evergreen "Wishlist: Library setting to turn off menus for unused modules" [Wishlist,Confirmed] https://launchpad.net/bugs/2080438 |
| 15:42 |
Dyrcona |
So, maybe I have not backported it. It appears in my custom db upgrade that I made this morning. |
| 15:43 |
Dyrcona |
Think I'll apply to a test db, dump it, and restore it on Pg 16. |
| 15:48 |
Dyrcona |
It's the first Monday of the month, and I'm spending it as I usually do: messing with database stuff. |
| 15:48 |
Dyrcona |
Only more so than is typical. |
| 15:49 |
redavis |
lol, and you also are just back from being sick. DB as therapy and onramping |
