| Time |
Nick |
Message |
| 00:11 |
|
kworstell_isl joined #evergreen |
| 00:51 |
|
sleary joined #evergreen |
| 03:49 |
|
jonadab joined #evergreen |
| 07:05 |
|
redavis joined #evergreen |
| 07:31 |
|
BDorsey joined #evergreen |
| 07:47 |
|
bshum_ joined #evergreen |
| 08:43 |
|
kmlussier joined #evergreen |
| 08:45 |
kmlussier |
Good morning #evergreen! |
| 08:45 |
kmlussier |
@dessert 65 bug squashers |
| 08:45 |
* pinesol |
grabs some Yummy Tuit Cookies for bug squashers |
| 08:50 |
|
dguarrac joined #evergreen |
| 08:59 |
|
Dyrcona joined #evergreen |
| 09:16 |
Dyrcona |
Back to my autogen.sh issue from yesterday. I'm trying to reinstall OpenSRF and Evergreen after wiping out /openils. I've got everything reinstalled and reconfigured, but something is wrong. All services start, but if I run autogen.sh, it blows up connecting to the config drones, and if I try login with srfsh, that also fails. I think something is wrong with the configuration somewhere, but I'm not sure what. |
| 09:16 |
|
csharp_ joined #evergreen |
| 09:18 |
|
terranm joined #evergreen |
| 09:19 |
Dyrcona |
Ooh. Found it by checking the srfsh.log. memcached settings are wrong. |
| 09:24 |
Dyrcona |
Now, I get an internal server error accessing the staff client.... |
| 09:25 |
Dyrcona |
OK. That one's totally on me. I shut opensrf services off for "reason" and forgot to restart them. |
| 09:26 |
Dyrcona |
And, I can't login.... |
| 09:26 |
|
mmorgan joined #evergreen |
| 09:29 |
* mmorgan |
tries to grab any of kmlussier's tuit cookies that remain |
| 09:29 |
Dyrcona |
Huh.... websocketd-osrf.service got disabled somehow. I've seen systemd disable user services after an update, but not system services.... |
| 09:30 |
Dyrcona |
systemd-- |
| 09:35 |
Dyrcona |
Nooooo! All that work and the test system still looks different from production. I even remade a new test branch in exactly the same way as production. |
| 09:35 |
Dyrcona |
i wonder if there's a template change in production that doesn't appear in the override folders? That has to be it. |
| 09:39 |
Dyrcona |
Nope. I just copied the production templates to my custom branch and `git diff` does nothing. |
| 09:47 |
Dyrcona |
git status say everything up to date. |
| 09:49 |
Dyrcona |
I don't like this one bit..... |
| 09:50 |
|
collum joined #evergreen |
| 09:53 |
pinesol |
News from commits: LP#2028095: stamp DB update <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3c2c67026631120b95793cb2dc8eb9da7d8ef87c> |
| 09:53 |
pinesol |
News from commits: LP#2028095: (follow-up) update description only if it hasn't been customized <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=dade5e9fa85b3fd1aab358fe53c6b18324455eef> |
| 09:53 |
pinesol |
News from commits: LP#2028095: Fix typo in Library Setting Description for acq.default_owning_lib_for_au... <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8071da1c51a32a277abe8f780674ef810a3c0edb> |
| 09:54 |
|
sleary joined #evergreen |
| 10:10 |
|
jvwoolf joined #evergreen |
| 10:10 |
|
mmorgan joined #evergreen |
| 10:11 |
Dyrcona |
This sort of thing drives me nuts. |
| 10:29 |
Dyrcona |
OK, so it looks like the difference is that templates/bootstrap/opac/parts/cart_nav.tt2 is displaying on the test system but not in production, even though it looks like it ought to display on both given what the templates all look like..... |
| 10:32 |
|
Christineb joined #evergreen |
| 10:36 |
csharp_ |
templates-bootstrap, you mean? |
| 10:36 |
csharp_ |
(wondering if the path is wrong) |
| 10:37 |
Dyrcona |
csharp_: You're correct. I can't type in chat. |
| 10:38 |
csharp_ |
btw, I'll state for the record that I don't like having templates and templates-bootstrap - seems like the bootstrap versions could be an option to symlink to or something and just have "templates", but it's ok |
| 10:38 |
Dyrcona |
What it looks like is production is rendering templates-bootstrap/opac/parts/topnav_subnav.tt2 differently than the test machine. |
| 10:38 |
csharp_ |
gotcha |
| 10:39 |
csharp_ |
@who is in charge of writing things down in The Record? |
| 10:39 |
pinesol |
eeevil is in charge of writing things down in The Record. |
| 10:39 |
Dyrcona |
They are identical. I've compared them, so are cart_nav.tt2. It's the same Ubuntu release and should be the same versions of Template::Toolkit, etc. |
| 10:39 |
Dyrcona |
They even look different in the OPAC. |
| 10:39 |
csharp_ |
maybe add some sort of text to differentiate them? |
| 10:40 |
csharp_ |
(you may not actually be asking for advice, I realize :-) ) |
| 10:41 |
Dyrcona |
Well, ideas are good, but I want them to be the same. |
| 10:41 |
eeevil |
uh oh ... we're in trouble if that's the case |
| 10:41 |
eeevil |
(me writing things down in The Record) |
| 10:41 |
Dyrcona |
eeevil: Heh! |
| 10:42 |
JBoyer |
Dyrcona, any chance apache config stuff is an issue? |
| 10:43 |
Dyrcona |
JBoyer: The overrides are in different paths, but the Apache stuff is pretty much the same. |
| 10:44 |
Dyrcona |
I've eyeballed the eg_vhost.confs, but I'll diff them. |
| 10:47 |
Dyrcona |
OK. i difference: templates_cons (the override) comes before templates-bootstrap in production. On my test system both of the overrides come after the stock directories. I'll swap those and see what happens. |
| 10:47 |
Dyrcona |
s/i/1/ |
| 10:48 |
Dyrcona |
JBoyer++ That was it! |
| 10:49 |
Dyrcona |
csharp_++ too. |
| 10:49 |
JBoyer |
woo! |
| 10:49 |
Dyrcona |
Now, I have templates, templates_cons, templates-bootstrap, templates-bootstrap_cons like production. |
| 10:50 |
csharp_ |
eeevil: I think pinesol is probably the better candidate, but TMTOWTDI |
| 10:51 |
JBoyer |
But to csharp_'s earlier concern, I thought the intent was to (eventually...) just do a cp -r templates-bootstrap templates ; rm -rf templates-bootstrap someday |
| 10:51 |
csharp_ |
JBoyer: makes senst |
| 10:51 |
csharp_ |
or sense, even |
| 10:53 |
csharp_ |
maybe a non-destructive way to do it would be to go ahead and do that, but preserve a templates-legacy that we no longer maintain, but lives in the code somewhere and can be copied into place per install instructions? |
| 10:53 |
JBoyer |
I guess that would be the logical middle step, yeah. |
| 10:53 |
pinesol |
News from commits: LP2048798 Remove inaccurate count of Shelving Locations <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bc08077dd8d102fe0e6eef6211d210e0fc9dbc50> |
| 10:53 |
csharp_ |
I'll open a bug |
| 10:54 |
csharp_ |
"but no, csharp_ - we're trying to REDUCE the number of bugs this week!", you say |
| 10:55 |
|
sandbergja joined #evergreen |
| 10:57 |
Dyrcona |
This still feels wrong, like we're not getting a template to load because of the order of the overrides.... |
| 11:02 |
|
kenstir joined #evergreen |
| 11:02 |
Dyrcona |
Comparing the bootstrap override for topnav.tt2 and the default bootstrap file, I think this ordering of the override directories may be masking a bug in our customization. |
| 11:03 |
|
kenstir joined #evergreen |
| 11:04 |
terranm |
As long as we close more bugs than we open |
| 11:19 |
|
mantis joined #evergreen |
| 11:19 |
mantis |
getting a 500 internal error when signing into the OPAC on MOBIUS test server 1 |
| 11:24 |
pinesol |
News from commits: LP#2052567: allow Reports to load when BitWarden plugin is active <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d3c203d3a1875f74a0ffe2db4431b49eb4564d3c> |
| 11:27 |
|
jvwoolf1 joined #evergreen |
| 11:34 |
Bmagic |
mantis: I might have been restarting apache at that moment (updating it for Czech language) - it's working for me at the moment |
| 11:36 |
mantis |
got it! thanks! |
| 11:37 |
csharp_ |
working on testing bug 1525394 and I have verified that part-holds now work, but we don't use serials and I'm not sure how to test issuance holds :-/ |
| 11:37 |
pinesol |
Launchpad bug 1525394 in Evergreen "SIP patron part level holds respond blank" [Undecided,Confirmed] https://launchpad.net/bugs/1525394 - Assigned to Chris Sharp (chrissharp123) |
| 11:38 |
csharp_ |
Bmagic: do you know if issuance holds are possible on your testbox with that fix on it? |
| 11:39 |
Bmagic |
I'm fuzzy on "issuance holds" but I don't see why the system wouldn't be able to do it. It's mostly stock Evergreen main |
| 11:40 |
terranm |
abneiman: When we were looking at that serials patch the other day, were you able to confirm that these things are in the Enhanced Concerto data set? https://bugs.launchpad.net/evergreen/+bug/1730992 |
| 11:40 |
pinesol |
Launchpad bug 1730992 in Evergreen "Concerto dataset's serials data should be populated" [Wishlist,Confirmed] |
| 11:41 |
Bmagic |
maybe it's a oils_sip.xml feature that needs enabled? oils_sip.xml has this line under <supports> block: <item name='hold' value='false'/> |
| 11:44 |
Bmagic |
csharp_: it sounds like you've connected to it via SIP already, but reading the sip XML compels me to mention the "institution" is "sample" and there is only one account enabled: admin/demo123 |
| 11:46 |
Bmagic |
terranm: just searched bugsquah for serials and there are four bibs with that format: Catster magazine; Time; The publichers weekly; The New York times |
| 11:47 |
Bmagic |
I spelled a couple of those wrong, lol |
| 11:49 |
Bmagic |
terranm: https://bugsquash2.mobiusconsortium.org/eg2/en-US/staff/catalog/search?org=1&limit=10&query=a&fieldClass=keyword&joinOp=&matchOp=contains&format=serial&dateOp=is&ridx=0 |
| 11:56 |
jeffdavis |
I'm a little disappointed to learn that Cat Fancy magazine has rebranded as Catster |
| 11:58 |
csharp_ |
Bmagic: actually I've been testing on our own server, but thanks for the connection info - I'll give yours a shot |
| 11:59 |
csharp_ |
jeffdavis++ |
| 12:00 |
terranm |
Bmagic++ jeffdavis++ |
| 12:01 |
collum |
Bmagic: in the url change query=a to query=* |
| 12:01 |
collum |
There's a few more. |
| 12:02 |
sleary |
Catster sounds like a filesharing platform for cat photos |
| 12:03 |
sleary |
which, if you squint, is perhaps a not-inaccurate description of niche magazines |
| 12:03 |
|
jihpringle joined #evergreen |
| 12:03 |
terranm |
sleary++ |
| 12:12 |
csharp_ |
the level of detail in this is very amusing to me: https://www.catster.com/cat-fancy-is-now-part-of-catster/ |
| 12:16 |
|
sandbergja joined #evergreen |
| 12:18 |
sleary |
"Catster began in the early 2000s as a sister website to the popular Dogster." Well, that explains everything. |
| 12:21 |
sleary |
terranm++ # x1000 for cleaning out obsolete bugs |
| 12:24 |
jvwoolf1 |
Oh wow! Same thing happened with Dog Fancy: https://www.dogster.com/dog-fancy-is-now-dogster |
| 12:25 |
jvwoolf1 |
I had no idea. I used to be a subscriber (because of course I was LOL) |
| 12:25 |
csharp_ |
reminds me of the early 00s when Nap Fancy became Napster |
| 12:25 |
* sleary |
fancies a nap |
| 12:25 |
csharp_ |
might have some details wrong there, but I feel certain I'm right |
| 12:25 |
jvwoolf1 |
That's the magazine I would subscribe to these days |
| 12:26 |
terranm |
csharp lol |
| 12:26 |
csharp_ |
jvwoolf1: the articles in Nap Fancy were all truncated because the authors fell asleep writing them |
| 12:28 |
csharp_ |
all the pictures were cozy couches and daybeds with eyemasks and white noise machines |
| 12:28 |
jeffdavis |
csharp_++ |
| 12:28 |
* csharp_ |
yawns |
| 12:40 |
Bmagic |
collum++ # I stand corrected |
| 12:44 |
sandbergja |
sleary: I'm at a conference session that is pretty much an ng-bootstrap accessibility roast :-D |
| 12:45 |
sandbergja |
I think your ng-bootstrap roasts are better though |
| 12:46 |
sleary |
oooooh, where? Because I'm thinking of putting in a proposal to All Things Open to yell about framework accountability |
| 12:47 |
sandbergja |
CSUN assistive technology conference |
| 12:47 |
sleary |
Nice. I want to hear all about it later! |
| 12:47 |
sandbergja |
I think that would be great! |
| 12:48 |
sleary |
They fling ARIA attributes around with wild abandon, and I'm like... do y'all know that these things have meaning? |
| 12:49 |
sleary |
Fun fact: on popovers, aria-description is set to the entire contents of the popover. The only reason this doesn't result in all our grid cell contents being read twice is that aria-description is invalid on <span> |
| 12:50 |
sleary |
There is no way to opt out of the aria-description. -.- |
| 12:50 |
sandbergja |
lol |
| 12:51 |
sleary |
er, aria-describedby (I should be accurate in my criticism) |
| 12:51 |
sandbergja |
always a great sign when your accessibility issues are prevented from becoming actual accessibility issues by other accessibility issues |
| 13:13 |
jeffdavis |
looks like bug 1744341 has been languishing for a while, if anyone has capacity to think about frozen holds |
| 13:13 |
pinesol |
Launchpad bug 1744341 in Evergreen 3.11 "Long-frozen holds skew hold queue position calculation" [Medium,Confirmed] https://launchpad.net/bugs/1744341 |
| 13:31 |
|
jvwoolf joined #evergreen |
| 13:32 |
|
sandbergja joined #evergreen |
| 13:46 |
Dyrcona |
Related to that, I don't think that frozen or expired holds should be included in the hold counts per bib. I think they are currently. |
| 13:59 |
|
kmlussier1 joined #evergreen |
| 14:02 |
|
kworstell-isl joined #evergreen |
| 14:05 |
abneiman |
terranm: I did not confirm re Serials data, beyond that one record; but I can take a look this afternoon or tomorrow |
| 14:13 |
|
sandbergja joined #evergreen |
| 14:16 |
terranm |
abneiman: I added a follow up comment to the bug - looks like there are stubs, but the data could really be fleshed out further to be helpful |
| 14:17 |
abneiman |
ah, ok. I'm probably not the best person to flesh out Serials data, but I can take a look regardless |
| 14:23 |
|
sleary joined #evergreen |
| 14:46 |
|
kworstell_isl joined #evergreen |
| 14:47 |
|
kmlussier joined #evergreen |
| 14:50 |
sandbergja |
terranm: would you be able to check to make sure that the angularjs pieces for bug 1906859 were installed on terran-main? I expected to see a method called need_at_least_one_selected in https://terran-main.gapines.org/js/ui/default/staff/cat/item/app.js, but didn't see it there. |
| 14:50 |
pinesol |
Launchpad bug 1906859 in Evergreen "Wishlist: Create Carousel from Item Bucket and Item Status" [Wishlist,Confirmed] https://launchpad.net/bugs/1906859 |
| 15:07 |
|
kenstir joined #evergreen |
| 15:20 |
|
kmlussier joined #evergreen |
| 15:22 |
|
smayo joined #evergreen |
| 15:31 |
|
mantis left #evergreen |
| 15:45 |
csharp_ |
ok, next time anyone asks why the bugs aren't getting signed off on, please remember that it can take a lot of time and effort just to set up a test case! |
| 15:46 |
csharp_ |
I've spent 2+ hours today just trying to figure out enough serials to create an issuance hold to test the "no part holds showing up in SIP2" bug :-/ |
| 15:46 |
csharp_ |
(still not there) |
| 15:47 |
csharp_ |
and it might be sunk cost fallacy at this point, but I'll be damned if I don't figure this out and commit the fix |
| 15:48 |
|
kworstell-isl joined #evergreen |
| 15:50 |
Dyrcona |
csharp_++ |
| 15:51 |
Dyrcona |
I'm in a similar boat with the SFTP EDI stuff. I'm trying to figure out enough acq to set up test orders and pregenerated responses. |
| 15:56 |
csharp_ |
where is tlittle when we need her in this hour of need? |
| 15:57 |
csharp_ |
Bmagic: is all well with the bugsquash2 server? I'm suddenly stuck |
| 15:57 |
* csharp_ |
weeps |
| 15:57 |
Bmagic |
checking |
| 15:58 |
Bmagic |
hmm, on the surface it looks ok |
| 15:58 |
csharp_ |
ok - must be me |
| 15:58 |
Bmagic |
logs look healthy |
| 15:59 |
Bmagic |
try hitting it from another VM to confirm? |
| 16:04 |
csharp_ |
Bmagic: looks ok now - thanks for checking |
| 16:04 |
Bmagic |
ok great |
| 16:17 |
csharp_ |
Bmagic: on bugsquash2, when I try to place a hold on Catster magazine after creating a holdable copy, I'm getting an empty red error box and this in the console: "ERROR TypeError: t.lastRequest.result.evt is null" - can you confirm? |
| 16:17 |
csharp_ |
I'm able to place the hold on my own test server running main-ish |
| 16:17 |
Bmagic |
checking |
| 16:17 |
csharp_ |
placing the hold for Sarah Smith |
| 16:18 |
csharp_ |
holdable copy barcode is "chrisistesting" |
| 16:19 |
csharp_ |
(my own server doesn't have the SIP2 port open on the ITS-administered firewall, so I can't test there) |
| 16:20 |
csharp_ |
however, I guess I'm now wondering if the item I attached is in fact an "issuance" |
| 16:20 |
Bmagic |
hold rule matrix is in the way I think |
| 16:20 |
csharp_ |
ah |
| 16:20 |
Bmagic |
result: Object { success: false, evt: null } |
| 16:33 |
|
kmlussier joined #evergreen |
| 16:34 |
|
jihpringle joined #evergreen |
| 16:35 |
csharp_ |
ok, so *no* that's not an issuance-level hold - I wonder how one places one of those? |
| 16:35 |
csharp_ |
to the docs! |
| 16:36 |
Bmagic |
did the hold policy (or lack of) end up fixing that last issue? |
| 16:36 |
|
jvwoolf joined #evergreen |
| 16:37 |
csharp_ |
uh |
| 16:37 |
Bmagic |
:) |
| 16:38 |
csharp_ |
Bmagic: nope - this is what I see: https://drive.google.com/file/d/1mZiDQf2x-PPLnAJDggbQWKEb6IK3a3rb/view?usp=sharing |
| 16:39 |
Bmagic |
same for me |
| 16:39 |
csharp_ |
k |
| 16:39 |
Bmagic |
I'll make a hold policy real quick and try again |
| 16:39 |
csharp_ |
the docs do not appear to cover issuance-level holds |
| 16:40 |
csharp_ |
I mean, I guess if no one can place an issuance level hold and JBoyer's code looks ok and the branch fixes the originally reported problem of not showing parts holds it's probably ok to commit? |
| 16:40 |
csharp_ |
definitely trying to do due diligence |
| 16:43 |
Bmagic |
ok, yeah, something is wrong on bugsquash2 (most likely one of the patches) - because on bugsquash (not 2) the exact same hold process works for me |
| 16:44 |
Bmagic |
which patch... welp that's going to be more of a bisect process for me to figure out I think. Maybe we need a machine with only* this patch on it so we don't have other potiential variables to troubleshoot |
| 16:44 |
csharp_ |
Bmagic++ |
| 16:44 |
Bmagic |
I can make a third machine! |
| 16:45 |
Bmagic |
there's a slot for it in the spreadsheet |
| 16:45 |
csharp_ |
I will say that I do not see a way to create an issuance level hold at all - it's mentioned in the JS and in the Perl, but I don't see any entry point |
| 16:46 |
Bmagic |
hmmm, I can't say I've seen it either. I suppose action.hold_request.hold_type ='I' ? |
| 16:46 |
Bmagic |
bugsquash3 will end up being a tomorrow thing if you'll still be around? |
| 16:47 |
csharp_ |
yeah, I'll be here - no biggie |
| 16:47 |
Bmagic |
I'm excited about sqaushing this one! |
| 16:47 |
csharp_ |
and I have a PINES-ish server to test - but it probably needs even more serials setup than enhanced concerto since we've never used it |
| 17:09 |
|
mmorgan left #evergreen |
| 17:15 |
|
sleary joined #evergreen |
| 18:59 |
|
jihpringle joined #evergreen |
| 22:06 |
|
sleary joined #evergreen |
