| 02:17 |
|
mrisher joined #evergreen |
| 06:18 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:54 |
JBoyer |
Bmagic, thinking back on your ng-container issue, mixing ng-container and ng-repeat is like mixing Angular and AngularJS. You should probably use ng-container with ngfor (if that is an |
| 06:55 |
JBoyer |
Angular 8 interface) or ng-repeat-begin and ng-repeat-end if it's an AngularJS interface. |
| 06:55 |
JBoyer |
Though I guess if you're only repeating the contents of a single <tr> you could just put the ng-repeat in the tr. |
| 15:12 |
JBoyer |
terranm++ |
| 15:12 |
berick |
yeah, terranm++ big time |
| 15:12 |
JBoyer |
That was a good week |
| 15:13 |
csharp |
#info csharp will arrange testing for sandbergja's fix to https://launchpad.net/bugs/1821094 on a realistic test server |
| 15:13 |
pinesol |
Launchpad bug 1821094 in Evergreen 3.3 "Item status refresh after editing can get confusingly slow" [Medium,Confirmed] |
| 15:13 |
csharp |
I can tell you right now that we haven't done that yet :-/ |
| 15:13 |
csharp |
#action csharp will arrange testing for sandbergja's fix to https://launchpad.net/bugs/1821094 on a realistic test server :-) |
| 15:13 |
sandbergja |
thanks, csharp! |
| 15:13 |
csharp |
#info berick to open LP on showing link to ang staff cat by default in 3.5 |
| 15:14 |
berick |
i have not opened said LP, but I've given some additional thought to it.. |
| 15:14 |
berick |
testing the catalog without full integration is only going to tell us so much |
| 15:15 |
berick |
i'm going to open an LP for promoting the Ang cat to becoming the default for (presumably) 3.6 |
| 15:15 |
berick |
if that's too early, we can bump to 3.7 |
| 15:16 |
berick |
but in any event, whenever it's merged, i think it needs to be merged very early in the release cycle |
| 15:16 |
berick |
since it's a significant change |
| 15:17 |
berick |
given that, I probably won't open an LP for making it visible by default in 3.5, unless there's a push to do so |
| 15:17 |
* berick |
is open to suggestion as always |
| 15:18 |
csharp |
no push from my direction, though we have been testing it among GPLS/PINES staff and plan to switch on the 3.4 version in production soon |
| 15:18 |
berick |
csharp: good to hear. i look forward to the feedback |
| 15:19 |
csharp |
ok, any other residual items from the last meeting (or before) that needs discussion? |
| 15:20 |
csharp |
#topic Release info: OpenSRF |
| 06:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:56 |
|
agoben joined #evergreen |
| 07:09 |
|
rjackson_isl joined #evergreen |
| 07:32 |
|
rfrasur joined #evergreen |
| 11:27 |
jeff |
also there was at least one "default value for field is different if you've upgraded vs fresh-installed" |
| 11:28 |
mmorgan |
Bmagic: Are there discrepancies in the "joiner" field? |
| 11:29 |
Bmagic |
mmorgan: yes! There is one line where it's ' -- ' for one but not the other: "All Subjects" |
| 11:30 |
Bmagic |
updating row and reindexing a test record. here goes |
| 11:34 |
mmorgan |
Looks like we made that change at some point. |
| 11:35 |
Bmagic |
well, i got the dashes in the index in the db but not on the opac. |
| 11:35 |
Bmagic |
probably memcache? |
| 16:13 |
JBoyer |
'll have to put a [% PROCESS carousels %] in your template where they should appear, and the relevant chunk of misc_util.tt2 will need to be pulled from stock, |
| 16:13 |
nfBurton |
misc util |
| 16:13 |
nfBurton |
gotchya |
| 16:14 |
JBoyer |
If you've already done that and it still won't appear, double check the JS and CSS that it references, and also make sure that the bucket associated with the carousel has entries in it. (you can cheat on that just for testing). |
| 16:14 |
nfBurton |
Oh that does exist |
| 16:14 |
nfBurton |
And the Process does too |
| 16:15 |
nfBurton |
I actually don't think they are filling with bibs for some reason |
| 16:15 |
Stompro |
mmorgan, are you still seeing content cafe cover art issues? |
| 16:16 |
nfBurton |
I am getting the carousels div but then it wont display unless bibs exist in the carousel |
| 16:16 |
nfBurton |
So I think that is the issue |
| 16:17 |
JBoyer |
You can fake that in psql if you'd like, depending on what all you want to test. :) |
| 16:17 |
mmorgan |
Stompro: No, they seem to be working fine ATM. Are you seeing issues? |
| 16:20 |
Stompro |
mmorgan, I just noticed a batch of new titles didn't have cover art again, until I cleared memcache and cleared my cache. |
| 16:26 |
mmorgan |
Stompro: Are they titles in your carousel? |
| 17:03 |
Bmagic |
JBoyer: thanks - I will play with those ideas |
| 17:12 |
|
mmorgan left #evergreen |
| 17:26 |
|
sandbergja joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:09 |
|
cmalm_ joined #evergreen |
| 19:31 |
|
sandbergja joined #evergreen |
| 21:12 |
|
cmalm joined #evergreen |
| 00:30 |
|
jonadab joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:10 |
|
rjackson_isl joined #evergreen |
| 08:14 |
|
rfrasur joined #evergreen |
| 08:17 |
|
tlittle joined #evergreen |
| 08:30 |
|
Dyrcona joined #evergreen |
| 08:42 |
|
mmorgan joined #evergreen |
| 08:44 |
|
mantis1 joined #evergreen |
| 09:45 |
Bmagic |
I've got a test machine that I just cannot get the permission groups interface to work. I've traced down the error in the OpenSRF code |
| 09:45 |
Bmagic |
here is the error "Session cache for thread xxxxxxxxxxxx does not match request" |
| 09:46 |
Bmagic |
which coorisponds to an if statement if(!strcmp(ipAddr, trans->remoteHost) && !strcmp(recipient, trans->recipient)) |
| 09:46 |
Bmagic |
in the C code |
| 16:27 |
jeffdavis |
I don't feel confident enough to commit that "read more" feature myself, but it would be nice to get it released after all that work and with at least one consortium already using it. |
| 16:27 |
pinesol |
[evergreen|Jeff Davis] LP#1811132: add Debit Card payment type - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3d7a7c1> |
| 16:27 |
pinesol |
[evergreen|Chris Sharp] LP#1811132 - Stamping upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=975ef96> |
| 16:27 |
csharp |
yeah, it's pretty intimidating |
| 16:28 |
csharp |
just trying to follow the comment thread on the bug was making my eyes roll around last week |
| 16:29 |
* csharp |
checks out the branch to install on his test server anyway |
| 16:30 |
mmorgan |
Read more example: https://evergreen.noblenet.org/eg/opac/record/4433320?locg=1 |
| 16:31 |
* mmorgan |
suggests starting with comment #19 on the bug https://bugs.launchpad.net/evergreen/+bug/1424815/comments/19 |
| 16:31 |
pinesol |
Launchpad bug 1424815 in Evergreen "Wishlist: Add a “read more” feature to the OPAC bib record view for fields with lots of text" [Wishlist,Confirmed] |
| 16:34 |
csharp |
khuckins: would you mind rebasing your branch to master? I'm getting conflicts on nearly every file due to new features added since |
| 16:34 |
csharp |
I'd be happy to test the branch if you do :-) |
| 16:34 |
khuckins |
Will do :) |
| 16:35 |
csharp |
thanks |
| 16:37 |
dbwells |
khuckins: I would also suggest squashing as a way to make it a bit easier to review. |
| 16:45 |
pinesol |
Launchpad bug 1749475 in Evergreen "wishlist: Improved email and printing from the OPAC" [Wishlist,Confirmed] https://launchpad.net/bugs/1749475 |
| 16:51 |
|
jvwoolf left #evergreen |
| 16:58 |
khuckins |
Read More's been squashed and rebased |
| 16:59 |
jeffdavis |
gmcharlt/JBoyer: in testing bug 1853363 on a user with a PATRON_EXCEEDS_FINES penalty, patron_status_always_permit_loans sets charge/renewal privileges denied appropriately in the patron status fixed-length field, but the AF field will still read as "blocked" - I take it this is the desired behavior? |
| 16:59 |
pinesol |
Launchpad bug 1853363 in Evergreen "SIP2: add setting to specify overriding certain flag fields" [Wishlist,Confirmed] https://launchpad.net/bugs/1853363 - Assigned to Jeff Davis (jdavis-sitka) |
| 17:01 |
gmcharlt |
jeffdavis: it's at least not incompatible with what Hoopla is expecting to my knowledge |
| 17:01 |
gmcharlt |
... which is not intended as a strong defense of that behavior :) |
| 17:47 |
dbwells |
jeffdavis++ # looks good! |
| 17:47 |
jeffdavis |
Phew! Thanks for checking. :) |
| 17:51 |
csharp |
jeffdavis++ |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:07 |
|
sandbergja_ joined #evergreen |
| 18:18 |
|
RBecker joined #evergreen |
| 18:46 |
|
Christineb joined #evergreen |
| 00:43 |
|
StomproJ joined #evergreen |
| 01:23 |
|
sandbergja_ joined #evergreen |
| 01:35 |
|
sandbergja_ joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:00 |
|
rfrasur joined #evergreen |
| 07:10 |
|
rjackson_isl joined #evergreen |
| 07:41 |
|
Dyrcona joined #evergreen |
| 10:22 |
Bmagic |
reading the 3.4 release new feature notes - 5.2.1. Angular Grid Improvements - Says we can filter grids per column. How do I do that? |
| 10:23 |
pinesol |
[evergreen|Mike Rylander] LP#1778521: Reset field transform after adding fields - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bab3860> |
| 10:23 |
berick |
Bmagic: there's a sandbox example or 2, in master anyway |
| 10:24 |
Bmagic |
I'm running a test machine with 3.4.2... went to item status, put in a few barcodes... then clicked around the grid to see where I could specify a search string on a per-column basis. Couldn't find it |
| 10:24 |
berick |
ah, they are not enabled by default |
| 10:24 |
Bmagic |
oh |
| 10:24 |
Bmagic |
that would explain it. Where do I enable? |
| 10:34 |
Bmagic |
gmcharlt++ |
| 10:34 |
berick |
but just some light icing |
| 10:36 |
berick |
ok, gonna grab the catalog bugs for final review/merge |
| 10:43 |
terranm |
New fresh batch of patches available for testing: https://docs.google.com/spreadsheets/d/1nDXg83ZAZlDYBxb0z59-hKqEjjPxpEuUssI2qtANax4/edit?usp=sharing |
| 10:44 |
Bmagic |
terranm++ |
| 10:47 |
pinesol |
[evergreen|Jane Sandberg] LP1859728: Allow users to add notes when creating a booking reservation - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d96059d> |
| 10:49 |
pinesol |
[evergreen|Terran McCanna] LP#1839361 Login page tile is confusing to screen readers - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=fba0719> |
| 10:54 |
terranm |
And csharp++ for good measure :) |
| 10:55 |
pinesol |
[evergreen|Mike Risher] lp1792995 wrong row details shown on billing grid - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4489629> |
| 10:55 |
pinesol |
[evergreen|Dan Briem] LP1849370 Mark items as damaged - changing fee usability issues - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=950c615> |
| 10:56 |
terranm |
nfBurton: Did you say you have a test server up with the experimental OPAC? |
| 10:59 |
pinesol |
[evergreen|Josh Stompro] LP1777181 - Make backdating more visible in check in. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1912e59> |
| 10:59 |
berick |
rfrasur: OK if I use 'Ruth Frasur' as your sign-off name or do you want 'rfasur'? re: https://bugs.launchpad.net/evergreen/+bug/1859706/comments/3 |
| 11:00 |
pinesol |
Launchpad bug 1859706 in Evergreen "Angular staff catalog: setting Patron View as preferred tab does not work" [Undecided,Confirmed] - Assigned to Bill Erickson (berick) |
| 11:03 |
rfrasur |
berick - Ruth Frasur is cool. I wasn't sure of the norm. |
| 11:04 |
berick |
rfrasur: k, no prob, just checking |
| 11:04 |
terranm |
nfBurton: yes, please! Let me know the url and user and I'll add it to the feedback fest chart and let everyone know it's there |
| 11:06 |
nfBurton |
https://test.nflibrary.ca/ - User: demo123 Pass: 1234 |
| 11:09 |
rfrasur |
nfBurton++ |
| 11:19 |
|
jvwoolf joined #evergreen |
| 11:19 |
terranm |
nfBurton++ |
| 16:25 |
pinesol |
Launchpad bug 1570072 in Evergreen "Hold request update notification preferences on change" [Wishlist,Confirmed] |
| 16:32 |
miker |
mmorgan: it does, I just wanted to confirm with terranm that I wasn't missing something in the branch she posted -- usually a signoff branch has the whole commit set. |
| 16:32 |
* mmorgan |
nods |
| 16:38 |
pinesol |
[evergreen|Mike Risher] lp1840287 Edit Floating Group Members - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0c62ab0> |
| 16:38 |
pinesol |
[evergreen|Bill Erickson] LP1840287 Floating group IDL required fields - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1d4ba00> |
| 16:38 |
pinesol |
[evergreen|Bill Erickson] LP1840287 Floating group admin minor code tweaks - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=27c346a> |
| 16:38 |
pinesol |
[evergreen|Jane Sandberg] LP1840287: Add a return to list button for floating group edit page - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=abc50d3> |
| 16:42 |
|
jvwoolf left #evergreen |
| 16:55 |
|
mdriscoll left #evergreen |
| 17:03 |
|
mmorgan left #evergreen |
| 18:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:06 |
|
sandbergja_ joined #evergreen |
| 18:35 |
jeffdavis |
The feedback fest results have been impressive. |
| 19:04 |
|
sandbergja_ joined #evergreen |
| 01:09 |
|
yar joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:32 |
|
rfrasur joined #evergreen |
| 07:48 |
rfrasur |
bmagic: just noticing your stat cats in the patron edit screen in the bugsquash server. I dunno who set that up, but they rock to 11. |
| 08:19 |
|
rfrasur joined #evergreen |
| 09:00 |
|
rjackson_isl joined #evergreen |
| 09:07 |
Dyrcona |
csharp berick: Is there a plan for dealing with the signedoff branches from this week, or did I miss something in the emails? |
| 09:31 |
|
dbwells_ joined #evergreen |
| 09:37 |
mmorgan |
Is #evergreen not getting indexed? I can't seem to find anything recent: http://irc.evergreen-ils.org/evergreen/search/?nick=;q=testing;offset=0 |
| 09:38 |
mmorgan |
Not successful googling either. |
| 09:38 |
|
nfBurton joined #evergreen |
| 09:39 |
|
dbwells joined #evergreen |
| 09:42 |
Dyrcona |
mmorgan: This worked for me: http://irc.evergreen-ils.org/evergreen/search/?nick=&q=testing |
| 09:43 |
Dyrcona |
Ah, but it only finds things from 2013 to 2014. |
| 09:43 |
mmorgan |
Dyrcona: Ok, but the most recent result is from 2014 |
| 09:43 |
Dyrcona |
:) |
| 09:43 |
mmorgan |
:) |
| 09:43 |
mmorgan |
jinx! |
| 09:44 |
Dyrcona |
"site:irc.evergreen-ils.org testing" with google turned up something from 2017. |
| 09:51 |
Dyrcona |
The same thing with Duck-Duck-Go turns up more results. |
| 09:51 |
dbs |
mmorgan: yeah I reported that a month or so ago as well :/ |
| 09:51 |
Dyrcona |
Limiting to anything less than past year, turns up nothing. |
| 10:23 |
rfrasur |
I think the EIC should include a "joie de vivre" award. |
| 10:30 |
sandbergja |
jeff: We were on 3.1.2 before |
| 10:30 |
sandbergja |
mmorgan: We are batch loaded. I spot checked a few records for whitespace in the alert message field, and nothing yet |
| 10:39 |
nfBurton |
Good, just testing the changes and fixing a couple errors. |
| 10:40 |
nfBurton |
I do have a question for the brain trust here though. Is there a simple way to toggle just the OPAC template through library settings or something to go to another folder? |
| 10:41 |
nfBurton |
from the looks of it, it would be king of intensive with apache referencing OPAC lots, not sure how to make a toggle to the updated template |
| 10:41 |
nfBurton |
Right now i Just rename the OPAC to OPAC-old and rename OPAC-new to OPAC |
| 10:47 |
Dyrcona |
nfBurton: The best (only?) way to do it now would be a different folder structure and URLs in Apache. If you want to toggle it somehow, via setting or on the fly, that would be a lot more work. |
| 10:48 |
Dyrcona |
You could go way, way back to Evergreen's early code, 1.6- 2.0 era, and dig up something called craftsman to see how it has been done in the past. Also, the introduction of tpac required some dual sites being available for a while. |
| 10:49 |
Dyrcona |
I forget what release made the transition from jspac to tpac. |
| 10:49 |
terranm |
New batch of patches (bite-sized Group 6) loaded and ready to test! Thanks csharp++ https://docs.google.com/spreadsheets/d/1nDXg83ZAZlDYBxb0z59-hKqEjjPxpEuUssI2qtANax4/edit?usp=sharing |
| 10:51 |
mmorgan |
sandbergja: What do you have in Group Penalty Thresholds? |
| 10:52 |
csharp |
Dyrcona: +1 to berick re: signed-off patches |
| 10:53 |
* csharp |
rolls up sleeves, puts on core committer hat |
| 10:55 |
Dyrcona |
says.... Yeah, I can English gud. |
| 10:55 |
csharp |
good idea |
| 10:56 |
nfBurton |
Dyrcona I guess it'll be a folder name change for now then |
| 10:57 |
mantis1 |
Testing for this bug: https://bugs.launchpad.net/evergreen/+bug/1754387 |
| 10:57 |
pinesol |
Launchpad bug 1754387 in Evergreen "Web Client: Pending User Buckets for more than 100 users" [High,Confirmed] |
| 10:58 |
mantis1 |
terranm: You suggested in this ticket to upload a text file of over 100 users |
| 10:58 |
mantis1 |
What do you suggest for getting over 100 of these patron barcodes? |
| 10:58 |
csharp |
mantis1: one second, I'll generate a list |
| 10:59 |
mantis1 |
Thank you |
| 11:00 |
Dyrcona |
Are there 100 patrons in the test dataset? |
| 11:01 |
csharp |
Dyrcona: 243 users |
| 11:01 |
Dyrcona |
OK. Didn't know what you're using. |
| 11:01 |
csharp |
108 patrons |
| 12:36 |
dbs |
oh wait, lineitem descriptive attributes, filter by attribute name = title and display attribute value should work |
| 12:37 |
Dyrcona |
dbs++ |
| 12:38 |
Dyrcona |
So, a propos yesterday's settings control panel discussion, I came up with this: https://docs.google.com/presentation/d/e/2PACX-1vTUEkETAWmwhoXM7hcIhRo8Z493IUVJtck3_zCSXX3kFLVT4DDZGpyHl8Jq67ywOaFmTNcvHFtMnGfw/pub?start=false&loop=false&delayms=5000 |
| 12:39 |
mmorgan |
dbs: jeff: Our system has a lot of inheritance going on in staff permission groups, and it seems to be working in our production 3.3.5 and test 3.4.2 systems. |
| 12:39 |
jeff |
mmorgan: good to know! |
| 12:40 |
mmorgan |
Yes. Whew! |
| 12:40 |
csharp |
Dyrcona++ |
| 12:42 |
dbs |
mmorgan: good! |
| 12:43 |
mmorgan |
@hate permissions |
| 12:43 |
pinesol |
mmorgan: The operation succeeded. mmorgan hates permissions. |
| 12:43 |
Dyrcona |
We haven't had any permissions issues on our 3.4.2 test system that I'm aware of, either. |
| 12:43 |
Dyrcona |
And, things are working in production on 3.2. |
| 12:46 |
mantis1 |
Dyrcona++ |
| 12:47 |
mmorgan |
Dyrcona++ indeed |
| 16:20 |
mmorgan |
He's fussy, I use bug 1778972 |
| 16:20 |
mmorgan |
pinesol? |
| 16:21 |
nfBurton |
lol |
| 16:21 |
terranm |
nfBurton: did you say that this could be installed and tested alongside the regular opac? |
| 16:22 |
nfBurton |
yes. It just means the folders would have to be renamed |
| 16:22 |
terranm |
never mind, I see the path |
| 16:22 |
nfBurton |
There is no nice way to toggle the OPAC I could find |
| 16:22 |
jeff |
is the link in the original description still a good place to "See the progress at https://test.nflibrary.ca/eg/opac |
| 16:23 |
nfBurton |
In 2 minutes, yes. I was using that one to view some original template things |
| 16:24 |
bshum |
mmorgan: pinesol won't show a bug too fast after someone else linked to it, keeps it from spamming endlessly |
| 16:24 |
bshum |
There's a timer built in, forgot how long |
| 16:51 |
terranm |
thanks! |
| 16:52 |
mmorgan |
berick: Is it not recommended to target bug fixes to all the currently supported releases? |
| 16:54 |
Dyrcona |
We need to have a conversation about that and update the dokuwiki pages. I have my preferences for bug targeting. |
| 17:00 |
nfBurton |
AHA! Had to run autogen and restart the server but the https://bugs.launchpad.net/evergreen/+bug/1778972 is visible here https://test.nflibrary.ca/eg/opac/home |
| 17:00 |
pinesol |
Launchpad bug 1778972 in Evergreen "Wishlist - OPAC Redesign" [Wishlist,In progress] - Assigned to Christopher Burton (cburton) |
| 17:02 |
|
jvwoolf left #evergreen |
| 17:04 |
|
mmorgan left #evergreen |
| 17:17 |
berick |
terranm: assuming none of them should be merged to 3.3.x, that's just fine |
| 17:18 |
berick |
BTW, it doesn't hurt to target 3.5-alpha for bugs, it's just kind of like targeting 'master'. it's redundant (until it's not) |
| 18:01 |
csharp |
next set of patches applied to tiffany-master, FYI: https://docs.google.com/spreadsheets/d/1nDXg83ZAZlDYBxb0z59-hKqEjjPxpEuUssI2qtANax4/edit |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 20:13 |
|
ejk joined #evergreen |
| 23:28 |
|
sandbergja_ joined #evergreen |
| 03:34 |
|
laurie joined #evergreen |
| 03:36 |
|
troy__ joined #evergreen |
| 06:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:35 |
|
tlittle joined #evergreen |
| 06:36 |
|
sandbergja joined #evergreen |
| 07:02 |
|
agoben joined #evergreen |
| 09:37 |
|
terranm joined #evergreen |
| 09:39 |
|
yboston joined #evergreen |
| 09:50 |
|
jvwoolf joined #evergreen |
| 10:13 |
pinesol |
[evergreen|Terran McCanna] LP#1839372 Splash page needs headers - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=04d0ee7> |
| 10:47 |
csharp |
@decide git ad or git add? |
| 10:47 |
pinesol |
csharp: go with git ad |
| 10:47 |
csharp |
pinesol: "git ad" could be a way to drum up some sponsor dollars, no? |
| 11:12 |
csharp |
mmorgan: I think we can shove that into the next set of small fixes |
| 11:12 |
* csharp |
is about to get to those |
| 11:13 |
mmorgan |
csharp++ |
| 11:14 |
csharp |
in other news, I've now encountered "ng build --prod" filling up RAM and causing OOM deaths |
| 11:14 |
csharp |
4GB of RAM on these test boxes |
| 11:14 |
csharp |
when I increased swap from 1GB to 4GB on one of them the problem was resolved, but I was surprised it happened at all |
| 11:19 |
csharp |
looks like a widespread issue: https://github.com/angular/angular-cli/issues/1652 |
| 11:23 |
Dyrcona |
php-- |
| 11:27 |
Dyrcona |
money-- |
| 11:27 |
dbs |
csharp: wow |
| 13:56 |
terranm |
I'm so happy to get that new interface, I almost don't care if it's not all the way there :D |
| 13:59 |
jeffdavis |
mmorgan: looking at bug 1774268 ... I am finding that if the patron has opac.hold_notify = "" (empty string), when I open their account in the patron editor, both the phone and email hold notify checkboxes are checked. I think that is incorrect. Are you seeing something different? |
| 13:59 |
pinesol |
Launchpad bug 1774268 in Evergreen 3.3 "webstaff UX: default hold notification preferences for patrons confusingly presented" [High,Confirmed] https://launchpad.net/bugs/1774268 |
| 14:00 |
jeffdavis |
(tested on 3.3.4-ish) |
| 14:00 |
|
nfBurton joined #evergreen |
| 14:08 |
terranm |
1774268 is also currently loaded on https://tiffany-master.gapines.org/eg/staff/ |
| 14:30 |
jeffdavis |
Interesting, it does seem like the checkboxes work properly on that server (although I can't confirm what the setting value is in the database for that one). I wonder why we're seeing different behavior in other environments. |
| 16:59 |
|
jvwoolf left #evergreen |
| 17:07 |
|
sandbergja_ joined #evergreen |
| 17:12 |
|
mmorgan left #evergreen |
| 18:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:22 |
|
nfBurton joined #evergreen |
| 19:52 |
|
sandbergja joined #evergreen |
| 20:21 |
|
JBoyer joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:57 |
|
agoben joined #evergreen |
| 07:07 |
|
rjackson_isl joined #evergreen |
| 07:48 |
|
rfrasur joined #evergreen |
| 10:12 |
pinesol |
Launchpad bug 1778972 in Evergreen "Wishlist - OPAC Redesign" [Wishlist,In progress] - Assigned to Christopher Burton (cburton) |
| 10:13 |
Bmagic |
!!! I think that's it |
| 10:13 |
Bmagic |
berick++ |
| 10:18 |
terranm |
One of Feedback Fest sandboxes had all its patches tested, so Chris has rebuilt it with a fresh set of patches ready for testing (Bite-Sized Group 3): https://docs.google.com/spreadsheets/d/1nDXg83ZAZlDYBxb0z59-hKqEjjPxpEuUssI2qtANax4/edit?usp=sharing |
| 10:18 |
terranm |
csharp++ |
| 10:19 |
tlittle |
csharp++ |
| 10:45 |
|
mmorgan joined #evergreen |
| 10:45 |
|
sandbergja joined #evergreen |
| 14:35 |
|
jihpringle joined #evergreen |
| 14:47 |
|
dbwells joined #evergreen |
| 15:10 |
|
jihpringle joined #evergreen |
| 15:25 |
terranm |
Bmagic: I'm testing LP1849736 but I'm not seeing any emails come through. I set my email address on the org unit BR1 and as the sender email in the library settings editor for BR1. Is there an additional config piece I need? |
| 15:29 |
Bmagic |
terranm: looking |
| 15:30 |
Bmagic |
looks like it's AT not firing |
| 15:38 |
Bmagic |
terranm: did you setup the AT? |
| 15:44 |
terranm |
Bmagic: is params.recipient_email just a placeholder? |
| 15:49 |
Bmagic |
yep, if you provide the params for the AT, then it would kick in |
| 15:49 |
Dyrcona |
params.recipient_email is a variable that gets filled in by the a/t execution environment. |
| 15:49 |
Dyrcona |
If you're testing, you could hard code it, but its better to get the value in there however this event expects it to be filled in. |
| 15:50 |
|
jvwoolf joined #evergreen |
| 15:50 |
Dyrcona |
By hard code, I mean replace it with an actual, valid email address in the template. |
| 15:52 |
terranm |
So I tried it first by putting the email into the org unit email field, and into the library settings editor sender email field, and nothing came through. Then tried hardcoding it into the template and it didn't come through either. |
| 16:09 |
nfBurton |
Okay. Shoi;d have time to push tomorrow |
| 16:09 |
Bmagic |
nfBurton++ |
| 16:09 |
nfBurton |
It is big but gcharleton recommended that I add it as a secondary option like OPAC-New or something that can be switched to |
| 16:10 |
terranm |
Agree that something that big should require more extensive testing from the whole community, but I'm excited to poke at it |
| 16:10 |
Bmagic |
nfBurton++ # OPAC rewrite! Heck yes |
| 16:10 |
nfBurton |
So both would be available for a version or so |
| 16:10 |
terranm |
(Also a little terrified because it will probably conflict with the rbdigital work) |
| 16:24 |
terranm |
I got that one! |
| 16:24 |
Bmagic |
stat=Sent is a good thing right? |
| 16:24 |
Bmagic |
ok, thought so |
| 16:26 |
Bmagic |
terranm: now that this is working - test the bug again |
| 16:26 |
terranm |
thanks |
| 16:27 |
Bmagic |
cron runs every minute - you could expect to wait at least 1 minute or 2 or 3 for the server to fire the email and maybe another minute for your mail server to deliver it to the inbox and another 1 minute for your mail client to get the message (depending on a ton of variables) |
| 16:29 |
* Bmagic |
has watch command running for new rows to appear in ATE |
| 16:34 |
Bmagic |
terranm++ # hanging in there |
| 16:34 |
terranm |
Bmagic: was the auto-submitted line the problem, you think? Or was there something else? |
| 16:35 |
Bmagic |
not really sure - It's kind of assumed that libraries will customize the heck out of that and it won't look anything like the stock stub |
| 16:36 |
terranm |
Yeah, we've heavily customized all of ours. Hard to test when the stock doesn't work at all out of the box though. |
| 16:36 |
Bmagic |
looking to see what the differences are |
| 16:38 |
terranm |
I'm going to start plugging things back into the template |
| 16:38 |
Bmagic |
maybe something is required to appear in action_trigger.environment... this is mentioned target.0.home_ou.id which might throw a template error if the environment doesn't include home_ou |
| 17:07 |
terranm |
modifying the To to hardcode in my email |
| 17:07 |
Bmagic |
ok, now, I think we are good - the template is stock from patch |
| 17:08 |
Bmagic |
leave the template stock, and I've introduced a parameter recipient_email |
| 17:09 |
Bmagic |
that way we are testing the patch template exactly |
| 17:09 |
terranm |
k - testing now |
| 17:09 |
Bmagic |
(with the extra line return removed though) |
| 17:10 |
Bmagic |
also - no need to re-re-register new patrons - I'm resetting the AT's with each test, and it generates a new email from the old ones again |
| 17:10 |
terranm |
oh, ok |
| 17:11 |
|
mmorgan left #evergreen |
| 17:12 |
terranm |
Nothing coming through |
| 17:40 |
Bmagic |
alright - will probably do that tomorrow - I'll let you know when it's set |
| 17:40 |
terranm |
Thanks! Bmagic++ |
| 17:40 |
Bmagic |
terranm++ |
| 17:41 |
terranm |
There's only one other bite-sized patch on there that hasn't been tested yet - maybe I can get Elaine to test it tomorrow morning so you can start fresh with a new bite sized group too |
| 17:41 |
Bmagic |
ok, I'll hold off for your go-ahead then |
| 17:44 |
terranm |
Cool beans, have a good night! |
| 17:44 |
Bmagic |
you too :) |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:05 |
|
sandbergja joined #evergreen |
| 20:57 |
|
sandbergja joined #evergreen |
| 21:26 |
|
sandbergja joined #evergreen |
| 06:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:03 |
|
agoben joined #evergreen |
| 07:06 |
|
rjackson_isl joined #evergreen |
| 08:19 |
|
alynn26 joined #evergreen |
| 09:41 |
Bmagic |
in the face |
| 09:41 |
Bmagic |
Bugs are like monsters from The Mummy. They come out of the sand.... boxes |
| 09:42 |
terranm |
lol |
| 09:43 |
Bmagic |
If we could just get Brendan Fraser to test.... |
| 10:06 |
|
aabbee joined #evergreen |
| 10:07 |
rfrasur |
terranm++ |
| 11:11 |
|
sandbergja joined #evergreen |
| 12:35 |
terranm |
alynn26++ for already diving into pullrequest testing and signing off on four patches this morning! |
| 12:50 |
|
collum joined #evergreen |
| 13:03 |
|
dbwells_ joined #evergreen |
| 14:11 |
|
remingtron joined #evergreen |
| 14:12 |
bshum |
Well that's interesting... Chrome 80 doesn't let you bypass the self-signed certs anymore? :( |
| 14:15 |
bshum |
Oh, wait, I'm on v79. Let's update to 80 and see if it's better or worse... :D |
| 14:19 |
bshum |
Nope |
| 14:19 |
bshum |
Still doesn't work, blah |
| 14:27 |
bshum |
Well this'll be fun... |
| 14:30 |
bshum |
Bmagic: bugsquash.mobiusconsortium.org looks like the cert expired two days ago |
| 14:30 |
bshum |
But at least I can get past it since it used to be a legit cert and Google doesn't just completely kill the bypass options |
| 14:30 |
bshum |
But for self-signed on my own VMs locally with trying to get to it via IP, it bombs hard |
| 14:31 |
bshum |
Oh well, there's always Firefox, I guess? |
| 14:42 |
* bshum |
will need to ponder this and test some scenarios with the ssl cert generation and ansible installer |
| 14:55 |
jeff |
is there an issue documenting that change? |
| 14:56 |
jeff |
because i'm not able to reproduce based on your description. |
| 14:57 |
bshum |
Well I wonder if it's how ansible makes the cert during the installation |
| 14:58 |
bshum |
And Chrome is blocking it from getting further now |
| 14:58 |
bshum |
I tried changing the Chrome setting for chrome://flags/#allow-insecure-localhost |
| 14:58 |
bshum |
But that seems to have done nothing too |
| 14:58 |
jeff |
do you have an exposed instance with such a cert i can test? |
| 14:59 |
bshum |
Possibly because it's an IP address, not actually localhost |
| 14:59 |
bshum |
No, it's private networking within my Virtualbox |
| 14:59 |
jeff |
wait, did something generate a cert for an IP address? |
| 14:59 |
bshum |
I've got to expand my testing radius a bit, sorry jeff |
| 15:00 |
bshum |
jeff: No, the automatically generated cert doesn't include the IP address |
| 15:00 |
bshum |
Just a hostname of localhost and "XX" for most of the default values |
| 15:00 |
bshum |
https://github.com/berick/evergreen-ansible-installer/blob/ubuntu-18.04/evergreen/apache.yml#L37 |
| 15:01 |
bshum |
This is the part of berick's ansible script which generates the SSL cert |
| 15:01 |
bshum |
I'm tracking back from that to see what the generated SSL cert is |
| 15:01 |
bshum |
And how that's making everything unhappy |
| 15:02 |
bshum |
And yeah, web_domain is "localhost" in the variable settings |
| 15:03 |
bshum |
I was going to move that cert out of the way and then retry using a standard cert creation and maybe set a real hostname |
| 15:03 |
bshum |
That works within my private network |
| 15:03 |
bshum |
To see if it handles it differently |
| 15:03 |
bshum |
But of course, I also just blew away that VM, so I have to redo the whole install first |
| 15:08 |
bshum |
jeff: The most I can find is Google talking about trying to kill off mixed content stuff - https://security.googleblog.com/2019/10/no-more-mixed-messages-about-https_3.html |
| 15:08 |
bshum |
But nothing about self-signed certs specifically (yet) |
| 15:10 |
bshum |
Though some vendors noted issues with v79 and v80 for self-signed certs - https://support.google.com/chrome/thread/28404872?hl=en |
| 15:10 |
bshum |
So that's what got me thinking on the issue |
| 15:10 |
bshum |
But perhaps it is just the way the certs are done and there's still some lifelines to be grabbed |
| 15:12 |
jeff |
``As of 2/13/2020 Chrome has updated to version 80.0.3987.106 which no longer causes issues with firewall management.'' |
| 15:12 |
jeff |
from a sonicwall article linked from your URL above: https://www.sonicwall.com/support/product-notification/resolved-unable-to-access-firewall-management-using-chrome-v80/200211160032277/ |
| 15:12 |
jeff |
doesn't reference a chromium issue, though. |
| 16:42 |
bshum |
Besides getting a real SSL cert :D |
| 16:53 |
bshum |
jeff++ |
| 17:48 |
|
sandbergja joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:37 |
|
JBoyer joined #evergreen |
| 21:47 |
|
remingtron_ joined #evergreen |
| 22:16 |
|
sandbergja joined #evergreen |
| 02:45 |
|
cmalm joined #evergreen |
| 03:07 |
|
cmalm joined #evergreen |
| 04:40 |
|
StomproJ joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:57 |
|
rfrasur joined #evergreen |
| 06:59 |
|
collum joined #evergreen |
| 07:02 |
|
agoben joined #evergreen |
| 09:38 |
|
yboston joined #evergreen |
| 09:49 |
|
sandbergja joined #evergreen |
| 09:52 |
StomproJ |
I'm looking through the debian buster install makefile, to see what all needs to be changed to upgrade to PG 10... but it seems like the PG 9.6 client still gets installed. Is that an issue, to use an older client with a newer server? |
| 09:55 |
csharp |
StomproJ: PINES just upgraded to 9.6 after unwittingly going to 10 without the backported fixes on 3.2 - been running 3.4 on 10 on a test server problem-free for months |
| 09:55 |
csharp |
StomproJ: not a problem in most cases to have a client/server version mismatch |
| 09:55 |
|
cmalm joined #evergreen |
| 09:56 |
phasefx |
are we talking the psql client? I think, at worse, stuff like tab completion might not work |
| 09:56 |
csharp |
yeah |
| 16:14 |
jeff |
And yes, I think we have at least one class of item where it should always come "home" for inspection before going elsewhere to fill a hold. |
| 16:49 |
|
jvwoolf left #evergreen |
| 16:53 |
|
khuckins_ joined #evergreen |
| 18:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 20:01 |
|
sandbergja joined #evergreen |
| 20:16 |
|
sandbergja joined #evergreen |
| 23:11 |
|
serflog joined #evergreen |
| 15:19 |
csharp |
ok cool |
| 15:20 |
terranm |
What Bill said |
| 15:20 |
* berick |
notes 2/17 may be a holiday for some |
| 15:20 |
terranm |
If we can get a bunch of those pullrequests on some sandboxes, the New Developers Group should be able to test a good chunk of them |
| 15:20 |
csharp |
# feedback fest scheduled for the week of 2/17 - 2/22 - code reviewers and committers are expected to participate |
| 15:20 |
csharp |
#info feedback fest scheduled for the week of 2/17 - 2/22 - code reviewers and committers are expected to participate |
| 15:20 |
* csharp |
will get the hang of it |
| 15:51 |
pinesol |
Launchpad bug 1821094 in Evergreen 3.3 "Item status refresh after editing can get confusingly slow" [Medium,Confirmed] https://launchpad.net/bugs/1821094 |
| 15:51 |
sandbergja |
And also some discussion about whether we want to batch the promise resolving in other places in the AngularJS client |
| 15:51 |
sandbergja |
Here's the specific commit: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=75176bca0ce8051a6dd4ba56f5613bce75901f09 |
| 15:52 |
csharp |
sandbergja: we can test it on a PINES server with realistic data/specs |
| 15:52 |
sandbergja |
charp++ |
| 15:52 |
sandbergja |
That would be really helpful! |
| 15:52 |
csharp |
#action csharp will arrange testing for sandbergja's fix to https://launchpad.net/bugs/1821094 on a realistic test server |
| 16:05 |
sandbergja |
My vague sense is that it's not quite ready to be the default catalog, but definitely ready to be less hidden... |
| 16:06 |
berick |
re: what patrons see, there is a tab in the detail page that shows the patron view. you can also open a new tab to the tpac. i'm confused what the issue is on that. |
| 16:07 |
|
mmorgan joined #evergreen |
| 16:07 |
terranm |
I honestly haven't looked at it since Bill did a demo for the catalogers group a few months ago, but Chris enabled it on one of our test servers so I'll make a point to look further with real data |
| 16:07 |
jeffdavis |
We haven't enabled the Angular catalogue in production here, but I've proposed making it visible. We're seeing a lot of slowness in the staff catalogue and I wonder if the Angular version would be an improvement. |
| 16:07 |
berick |
sandbergja: same. until it gets more use in the wild, making it the default is a hard sell. |
| 16:08 |
berick |
and by the same token, if no staff know it exists, no one will use it |
| 16:11 |
terranm |
+1 to the patron view tab |
| 16:11 |
jeffdavis |
sandbergja: that's a surprising number of reference copies of that particular title |
| 16:11 |
berick |
jeff: maybe. but it gets complicated with routerLink's, target=_self, etc. depending on the context |
| 16:14 |
jeffdavis |
berick: sounds like more testing is wanted before we make it the default, but maybe we can at least make it more visible (or not call it "Experimental" anymore or whatever) in 3.5? |
| 16:14 |
terranm |
+1 |
| 16:14 |
remingtron |
berick: maybe during feedback fest we could invite EG users to test the staff catalog and give feedback |
| 16:14 |
remingtron |
(and/or during a bug squashing week) |
| 16:14 |
terranm |
+1 |
| 16:15 |
berick |
remingtron: on that note, I'll be posting all of the pending staff catalog pullreqs to a demo server for fests and squashes |
| 16:15 |
remingtron |
cool |
| 16:22 |
sandbergja |
csharp++ |
| 16:27 |
|
tlittle joined #evergreen |
| 16:31 |
dbwells |
csharp++ berick++ ui_specific_apis++ |
| 16:34 |
mdriscoll |
What is the recommended version of Postgres for 3.4 and beyond? The install instructions say that 9.6 is the minimum. I'm running 9.4 on production and test servers. Should I plan on 9.6 or jump to 10, 11? |
| 16:40 |
bshum |
Stick with 9.6 |
| 16:40 |
bshum |
10 was wonky for some people, I remember csharp having issues after their upgrade? |
| 16:41 |
bshum |
So we're still needing some DB refinements I think for some database function changes |
| 16:44 |
bshum |
But then again, we also didn't yet write pgtap tests for every core function |
| 16:44 |
bshum |
Just to be safe |
| 16:44 |
* bshum |
adds to his Hackfest ideas list |
| 16:44 |
Dyrcona |
Yeah, we need more pgtap tests. |
| 16:45 |
Dyrcona |
Not sure that we can really test all of the functions since they rely so heavily on side effects. |
| 16:45 |
bshum |
Right |
| 16:45 |
bshum |
But at least we can put some input and see what expected output ought to be |
| 16:46 |
Dyrcona |
I *think* we can do multistep tests, i.e. run the function and check table values after. |
| 16:46 |
bshum |
Right |
| 16:46 |
bshum |
I'm pretty sure we can |
| 16:47 |
mdriscoll |
bshum++ |
| 17:16 |
csharp |
berick++ # finishing the meeting |
| 17:16 |
csharp |
@band add Tab Crash |
| 17:16 |
pinesol |
csharp: Band 'Tab Crash' added to list |
| 17:17 |
Dyrcona |
Also for the logs, you can backport the Pg 10 fixes to earlier versions and things are OK. I've tested them on both 9.5 and 9.6. |
| 18:03 |
|
sandbergja_ joined #evergreen |
| 20:16 |
|
sandbergja joined #evergreen |
| 20:57 |
|
JBoyer joined #evergreen |
