Evergreen ILS Website

Search in #evergreen

Channels | #evergreen index




Results

Result pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143

Results for 2021-09-24

06:01 pinesol News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-24_04:00:03/test.42.html>
07:26 pinesol [evergreen|Jason Boyer] LP1928258: Correct Upgrade Script - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=bec5712>
07:27 rjackson_isl_hom joined #evergreen
07:30 JBoyer berick, Will you have time today to update the failling regression test for Vandelay? It's related to the update editor / update bib sources changes from LP 1928258.
07:30 pinesol Launchpad bug 1928258 in Evergreen "Add separate "update edit date / editor" fields for Vandelay merge profiles" [Wishlist,Fix committed] https://launchpad.net/bugs/1928258
07:31 mantis joined #evergreen
08:42 mmorgan joined #evergreen
09:47 jeff if there were something that tied payments to billings like that, I don't think we'd need mmpbbt. :-)
09:47 JBoyer "but they" = "but the billings they"
09:47 Bmagic yeah, agreed, if the billings that were originally aa'ed get voided, then the aa has to go somewhere*
09:48 JBoyer And that's the issue with the current mmpbt func, where they go isn't necessarily un-voided (and for the most part explicitly isn't in that example xact in the test)
09:51 jvwoolf joined #evergreen
09:52 Bmagic Well, wait a minute, it doesn't pay voided bills at all
09:53 JBoyer The steps in my comment at the bottom of the bug show how that happens. Billings were adjusted, later they were voided, now things are mis-applied in mmpbt.
09:54 jeff I'm going to try to make time to look at the tests. I appreciate that they're there now. :-)
09:54 JBoyer They're poorly named and too basic, but can help make sure it doesn't do something silly.
09:56 Bmagic if the payment is negative, then it pays voided billings as the last step. The issue is there somehow? (Because that's the only logic that deals with voided billings)
10:02 * mmorgan tries to wrap head around negative payments applying to voided billings:-/
10:22 Bmagic seperate/separate login/logic
10:49 jvwoolf joined #evergreen
10:51 pinesol [evergreen|Bill Erickson] LP1938729 Cache "cascade" setting values - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3887004>
10:57 csharp_ I must have missed a commit where chromium and firefox are no longer installed by the -developer Makefile.install targets?
10:58 csharp_ (testing the bullseye EG/OpenSRF branches and npm run test is failing
10:58 csharp_ )
10:59 JBoyer csharp_, That commit is the first one in the bullseye branch.
10:59 JBoyer it's from a branch for a different lp though I believe.
11:00 csharp_ ah - I didn't cherry-pick that one
11:00 csharp_ oh right - it's a working repo commit so pinesol doesn't know about it
11:03 csharp_ ok, I see now - it's in bug 1850156
11:03 pinesol Launchpad bug 1850156 in Evergreen "Need a -git make target" [Wishlist,Confirmed] https://launchpad.net/bugs/1850156
11:04 csharp_ I guess I'm testing a buncha muncha cruncha bugs at the same time :-)
11:09 mmorgan csharp_: Buncha Muncha Cruncha Bugs sounds like a nutritious breakfast cereal!
11:09 * berick hankers for a hunk o' cheese
11:11 rfrasur Amish cheese?
17:01 gmcharlt rhamby: it's not quite there yet, unless somebody else wants to spend time on it; e.g., atcol needs to be registered with prcrud for the edit enviornment modal to work
17:08 mmorgan left #evergreen
17:11 terranm corecommitters++ Y'all beat the record for most commits since we started doing bug squash weeks!
18:01 pinesol News from qatests: Failed Installing Angular web client <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-24_16:00:03/test.29.html>
18:04 terranm FYI, I'm logging out, but I'll finish up the statistics tomorrow morning to include anything else that happens today
18:20 rjackson_isl_hom joined #evergreen
18:53 jihpringle joined #evergreen

Results for 2021-09-23

06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:17 collum joined #evergreen
07:22 rjackson_isl_hom joined #evergreen
08:02 stephengwills left #evergreen
10:52 csharp_ ok, gimme some-a them bugs for me to squash
10:52 gmcharlt csharp_: if you're looking for suggestions, how about bug 1925028
10:52 pinesol Launchpad bug 1925028 in Evergreen "Holds Ratio Reports should more accurately report available copies and include a "By Home Library" source" [Wishlist,Confirmed] https://launchpad.net/bugs/1925028
10:54 terranm There are quite a few things will open pullrequests that need to be tested by a sysadmin, too, since they can't be tested by an end user
10:59 * gmcharlt claims 1297
11:00 csharp_ gmcharlt: thanks! I'll take a look
11:01 pinesol [evergreen|Chris Sharp] LP#1921057: fix release notes typo - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b17c543>
11:07 pinesol [evergreen|Galen Charlton] LP#1759382: stamp schema update - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3f82a71>
11:07 pinesol [evergreen|Galen Charlton] LP#1759382: add release notes entry - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=135d343>
11:19 csharp_ can we get to 1300 today?  I think we can
11:20 Dyrcona I was kind of hoping to do 1300, myself, but it doesn't look like I'm going to get to much actual testing this week.
11:21 * Dyrcona is off tomorrow.
11:54 csharp_ claiming 1298
12:05 pinesol [evergreen|Mike Rylander] LP#1864516: case-insensitive browse entry display value comparison - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fe23d26>
13:06 jihpringle joined #evergreen
13:15 csharp_ @quote add <jeffdavis> 'Tis better to have committed and reverted, than never to have committed at all.
13:15 pinesol csharp_: The operation succeeded.  Quote #218 added.
13:19 terranm lol
13:25 terranm FYI, I'm taking my test server down and refreshing it
13:36 mmorgan Another task, another rabbit hole ...
13:36 gmcharlt mmorgan: I suddenly really feel for the rabbitmq developers ;)
13:37 gmcharlt "it's nothing _but_ rabbit holes"
13:40 jeff gmcharlt: Just imagine the onboarding proces for new yakshaved devs!
13:40 mmorgan :)
13:41 gmcharlt ha!
13:45 JBoyer Quick Q, is anyone having problems exporting a record from Vandelay on a very fresh checkout? works on pattypan, but my personal test machine is giving me this gem in the gateway log: No authentication done but request not allowed without authentication for /exporter. Authentication not configured?, referer: (blahblah)/eg2/en-US/staff/cat/vandelay/export
13:46 JBoyer Just trying to export bib id 2 from concerto.
13:47 JBoyer And fresh checkout meaning just a couple hours old. Not sure if it's my test machine (I don't export much) but I can't imagine this being a config thing,
13:50 jeff I can't remember if exports use temporary files, but you might check on that -- especially your vandelay spool dir vs systemd private /tmp
13:51 Dyrcona It probably does, and IIRC there's some reason that recent Apache can't use /tmp.
13:52 jeff (Evergreen config defaults to /tmp for the vandelay spool dir, systemd defaults to private /tmp for apache, which means OpenSRF perl processes use /tmp and apache's /tmp is mapped elsewhere)
14:40 JBoyer Appears to not have been that, but I've given up since exporting wasn't what I was worried about.
14:40 JBoyer However! Any sysadmins interested in knocking out a basic bug, check out lp 1900005
14:40 pinesol Launchpad bug 1900005 in Evergreen 3.6 "oils_ctl.sh and autogen.sh should not require the opensrf account" [Undecided,New] https://launchpad.net/bugs/1900005
14:43 Bmagic JBoyer: sounds like "fun"  - would it be fair to assume that a good test would be on an installation that uses a different user other than opensrf?
14:45 JBoyer Bmagic, file ownership doesn't generally matter for services. It makes more of a difference if you run apache as a non-www-data user but I'm not down with that.
14:45 Dyrcona I'm not really down with running services as a different user, either.
14:45 Bmagic "homey don't play that"
14:53 Dyrcona JBoyer: So, if I understand correctly, I should be able to install this patch and then start OSRF services as a user other than opensrf so long as that user 1) isn't id 0, and 2) can write to the appropriate directories?
14:54 JBoyer oils_ctl.sh doesn't worry about writing, but yes, you should be able to run as whoever, and run autogen as anyone that can save the appropriate files.
14:55 Dyrcona OK. I'll have a look. I'm not sure I'd consider this a bug fix, so if it works for me, I may just add my signoff and let someone else decide what branches to push it to.
14:55 Dyrcona I suppose that I should test this somewhere that I've already setup SIP2.
14:56 JBoyer 3.8+ is probably fine, since it doesn't seem to be a pain point for anyone (or it's being worked around already)
14:57 JBoyer I need to make time to clean up / detangle my systemd units and make them an installable option. Not sure they'll make 3.8 though.
14:58 Dyrcona I've found myself using systemd more lately, particularly on my Pinebook. I added local/user systemd units to start ssh-agent and gpg-agent when I login.
15:00 pinesol [evergreen|Josh Stompro] LP#1924562 - pingest.pl help typo for --max-duration - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=17925e7>
15:01 Dyrcona JBoyer: Yes, I've learned what I've needed to know as I've gone along. Seems simpler than porting Evergreen to FreeBSD. :)
15:01 Dyrcona S'pose I could dust off the branches and switch to Devuan. :)
15:02 Dyrcona I think I have a SQL update to create a SIP user that works with stock master, so maybe I'll test oils_ctl.sh on a blank VM.
15:02 JBoyer Somewhere (possibly lost to the mists of time now...) I found a site that used dbus to somehow get systemd to give you proper error messages for units to help with debugging. It was annoying but a big help at one point.
15:02 csharp_ with the recent death of CentOS, I just started a rocky branch for OpenSRF based on my previous work
15:03 csharp_ one of these days we'll have production-ready installation on an RPM-based distro
15:38 Bmagic install_evergreen_server_x64.msi # that'll be the day
15:39 Dyrcona Evergreen_Server.dmg :)
15:40 Bmagic :)
15:41 Dyrcona So, I apparently have a CSV of users, including a SIP account, that I used for testing once, but nothing to indicate the script that I used to create the uses in the database.
15:45 Dyrcona OK. Found the SQL that I was looking for, but it predates the new auth/password set up.
16:09 csharp_ Windows + SQL Server + Java + ISS
16:09 csharp_ IIS, rather
16:17 Dyrcona Makes sense.
16:20 Dyrcona Time to go!
16:23 gmcharlt bug 1944765 now has a pull request
16:23 pinesol Launchpad bug 1944765 in Evergreen 3.6 "mod_headers is not enabled by default" [Medium,New] https://launchpad.net/bugs/1944765
17:25 mmorgan left #evergreen
17:34 terranm joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
20:17 jihpringle joined #evergreen

Results for 2021-09-22

06:00 pinesol News from qatests: Failed Create Evergreen Database <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-22_04:00:02/test.41.html>
06:58 collum joined #evergreen
07:22 rjackson_isl_hom joined #evergreen
07:53 mantis joined #evergreen
10:05 tlittle joined #evergreen
10:17 terranm joined #evergreen
10:18 JBoyer gmcharlt++
10:18 JBoyer Live test fix landing soon
10:20 pinesol [evergreen|Jason Boyer] LP1905028: Make live tests chill out - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=eea6e5f>
10:22 csharp_ Dyrcona: eby: same here - interesting article though and something to keep an eye on
10:23 csharp_ @bartender live tests
10:23 * pinesol fills a pint glass with New Belgium Porch Swing Single Ale, and sends it sliding down the bar to live tests (http://beeradvocate.com/beer/profile/192/1916/)
10:23 jeff perhaps neither of you have done an in-place upgrade that involves the glibc collation changes in question. :-)
10:24 jeff "The breaking change in glibc was introduced in Debian 10 (Stretch) , Ubuntu 18.10 (cosmic) and 20.04 LTS (focal), and RedHat 8."
10:24 berick noting our new event-grid.component.ts could use some 'ng lint' love
10:29 Dyrcona jeff: I've upgraded in place from 18.04 to 20.04 .
10:30 Dyrcona Of course, I've reloaded the databases from dumps multiple times since then.
10:30 Dyrcona I'm not using 20.04 in production, yet, just on a test database server.
10:33 Dyrcona JBoyer: There's a way to have Tests::More calculate the number of tests. I use it in my Emacs skeletons for Perl tests.
10:35 JBoyer Dyrcona++
10:35 JBoyer Wasn't entirely the issue with that test but good to know.
10:37 Dyrcona Well, I saw that you changed the number of tests to run. I suppose there are pros and cons of either approach.
10:38 Dyrcona To have Tests::More calculate the number of tests, just use Tests::More without specifying the number of tests. At the end of the script call the done_testing() subroutine.
10:39 Dyrcona It's useful when first writing the test script and you don't know yet how many tests you're going to run. One could always go back later and fill in the number of tests and remove the done_testing() line.
10:43 Dyrcona JBoyer: You remember that security audit that I mentioned last week? I'm debating with myself about opening bugs regarding some of the Apache configuration things.
10:45 JBoyer Might be worth bringing them up even if they're not especially urgent. If memory serves they had some pretty tame stuff but no harm in checking them out.
10:45 JBoyer Also, nothing stopping us from making a private security bug public for broader discussion if it's not that serious.
11:09 csharp_ @band add Private Bug
11:09 pinesol csharp_: Band 'Private Bug' added to list
11:10 csharp_ jeff: we did an in-place upgrade of Ubuntu 16.04 -> Ubuntu 18.04, but we're also using the PostgreSQL APT repo, which may make a difference
11:14 Stompro Bug #1862694 only seems to effect us, since it is triggered by how we name our servers... but I don't think I'm allowed to test and sign off on it.. right?
11:14 pinesol Launchpad bug 1862694 in Evergreen 3.6 "Record Buckets - Batch Edit redirect - Regex replace that fails for us" [Undecided,New] https://launchpad.net/bugs/1862694
11:15 Stompro Anyone willing to test that they can still get to the Batch Edit interface?  I'm willing to test another bug in trade!
11:15 gmcharlt Stompro: it probably won't be until next week, but I can test it
11:19 Stompro gmcharlt, thanks, anything I can test in return?
11:26 gmcharlt Stompro: thanks. maybe bug 1940962?
11:26 pinesol Launchpad bug 1940962 in Evergreen "Default carousel spacing is too small" [Wishlist,New] https://launchpad.net/bugs/1940962
11:28 Stompro gmcharlt, will do.
16:47 * Dyrcona decides to sleep on it.
17:05 mmorgan left #evergreen
17:57 Stompro joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:22 gsams joined #evergreen
18:54 stephengwills joined #evergreen
20:50 Stompro joined #evergreen

Results for 2021-09-21

00:19 Stompro joined #evergreen
06:02 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-21_04:00:02/test.49.html>
07:14 rjackson_isl_hom joined #evergreen
08:04 mantis joined #evergreen
08:42 mmorgan joined #evergreen
16:30 terranm I came of age in the Bartles & Jaymes era, what can I say
16:36 Dyrcona terranm++
16:38 Dyrcona @bartender
16:38 * pinesol fills a pint glass with Southampton Grand Cru, and sends it sliding down the bar to Dyrcona (http://beeradvocate.com/beer/profile/1628/10301)
17:17 mmorgan left #evergreen
18:00 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-21_16:00:02/test.49.html>

Results for 2021-09-20

00:30 eby joined #evergreen
00:41 degraafk joined #evergreen
06:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-20_04:00:03/test.49.html>
07:15 collum joined #evergreen
07:21 rjackson_isl_hom joined #evergreen
08:18 mantis joined #evergreen
09:08 csharp_ @someone [coffee]
09:08 * pinesol (someone [<channel>]) -- Returns a random nick from <channel>. <channel> is only necessary if the message isn't sent in the channel itself.
09:09 csharp_ @blame [someone] for [quote random]
09:09 pinesol csharp_: troy tests their code on the LIVE SERVERS, then blames the user. SAD! for Quote #114: "<Dyrcona> If TCP/IP were standardized like most library standards, we'd all be using AOL/CompuServe." (added by berick at 02:43 PM, May 04, 2015)
09:10 Bmagic Good ol' TCP/IP
09:10 csharp_ @ana Good ol' TCP/IP
09:10 pinesol csharp_: Good! Top clip
11:44 csharp_ huh - not sure why action.hold_retarget_permit_test is involved, but that's probably a clue...
11:46 pinesol [evergreen|Dan Briem] LP#1917338 Angular: Holdings view column picker missing OPAC visible? - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=8129903>
11:46 csharp_ trying again with the hold targeter dead (didn't realize it was also running)
11:46 phasefx it's funny, those assertions/tests aren't really needed, but were added because the spec said to, and somehow they're blocking things.. I think
11:46 phasefx maybe comment them out?
11:46 csharp_ it will take about 25 minutes to get to that point in the process - I'll let you know whether it works now
11:47 phasefx csharp_++
11:47 csharp_ then I'll try commenting those out if it's still borken
12:33 Dyrcona csharp_: Don't do that. Don't run db upgrades while any part of Evergreen or OpenSRF services are running.
12:33 JBoyer Context: I was looking at a couple angular patches he's worked on, didn't know if they were orhpaned.
12:37 terranm JBoyer: I'm pretty sure he was moved onto non-Evergreen projects
12:40 csharp_ Dyrcona: yeah - I didn't realize the crons were still enabled
12:41 csharp_ phasefx: success - PINES staff will test how it went
12:42 phasefx yay!
12:45 Dyrcona @karma csharp_
12:45 pinesol Dyrcona: Karma for "csharp_" has been increased 10 times and decreased 0 times for a total karma of 10.
12:45 Dyrcona csharp_++ phasefx++
12:45 Bmagic the ghost is more popular
12:45 Dyrcona :)
12:46 * Dyrcona had network issues where a test database server resides, so I'm waiting on a database reload to finish before I can do much today.
12:51 Stompro tlittle, are you the responsible party for Tiffany's Test server?  I was trying to test Bug #1919465, but I'm getting an error about the server side print template not existing.
12:51 pinesol Launchpad bug 1919465 in Evergreen "Port holds pull list to Angular / Wide Holds API" [Undecided,New] https://launchpad.net/bugs/1919465
12:54 Stompro No active template found 'hold_pull_list', but under server admin -> Print Templates, it does exist and is active.
12:56 jvwoolf joined #evergreen
13:12 collum joined #evergreen
13:16 jvwoolf I couldn't find this documented anywhere -if a hold is activated after being suspended, does the expiration date go back to what it was before it was suspended, or does the expiration interval start over?
13:17 mmorgan jvwoolf: When a hold is suspended, the expiration date is removed. Not positive what happens when it's activated.
13:18 jvwoolf mmorgan: I did see that is was removed when it's suspended. I guess I can do some testing around what happens when it'
13:18 jvwoolf s activated
13:19 jvwoolf Ichy enter finger :)
13:19 jvwoolf Itchy, even
13:20 collum joined #evergreen
13:22 mmorgan jvwoolf: Just tried it. The hold gets a new interval when it's activated.
13:22 jvwoolf mmorgan++
13:22 jvwoolf Thanks for testing!
13:22 mmorgan yw!
13:24 Dyrcona jvwoolf: The expiration date is not changed when the auto thaw happens, so it remains unset. See line 293 of Open-ILS/src/perlmods/lib/OpenILS/App​lication/Storage/Publisher/action.pm
13:25 jvwoolf Dyrcona: Interesting. When I thaw a hold in the client, the expiration date does set.
13:46 * mmorgan runs out for a bit.
13:48 Bmagic csharp_++ # reading
13:56 Dyrcona Yeahp. Confirmed. I counted 155,468 holds with null expire_time and frozen = 'f' before running the thaw frozen holds script. It reported thawing 842 holds. Afterward I counted 156,310 holds with null expire_time and frozen = 'f'.
13:59 tlittle Stompro Yep, that's my test server. I'll take a look
14:02 jvwoolf Dyrcona++
14:02 jvwoolf That's good to know
14:02 Stompro tlittle, thanks, I'm also not seeing the Discard/Weed option added in the last commit for that feature.
15:42 pinesol [evergreen|Bill Erickson] LP1928363 Item circ info for Holdings tab - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=b804ec5>
15:42 pinesol [evergreen|Bill Erickson] LP1928363 Fix PCRUD permission - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=ac57030>
15:42 pinesol [evergreen|Galen Charlton] LP#1928363: add release notes entry - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3234fe6>
15:43 berick tlittle: may need to confirm server print templates are configured on your test server...
15:44 berick /etc/apache2/eg_vhost.conf should have a <Location /print_template> section, plus another bit in eg_startup
15:45 tlittle berick Well, that absolutely sounds like it would be helpful for sure. Thank you so much!
15:45 Stompro tlittle, is there an entry in the eg_vhosts.conf for the /print_templates endpoint?
15:45 tlittle Going to look for it right now
17:22 Bmagic haha
17:23 * gmcharlt claims 1289
17:26 Stompro joined #evergreen
17:27 pinesol Showing latest 5 of 7 commits to Evergreen...
17:27 pinesol [evergreen|Rogan Hamby] LP#1929242: add missing comma - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=68157bc>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: (follow-up) add grid config WS setting - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=3a20a5b>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: (follow-up) additional tweaks - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=2c1c3b6>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: edit release notes - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a91097a>
17:27 pinesol [evergreen|Galen Charlton] LP#1929242: stamp DB update - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=a81071f>
18:02 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-20_16:00:03/test.49.html>

Results for 2021-09-19

06:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-19_04:00:02/test.49.html>
16:58 Stompro joined #evergreen
18:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-19_16:00:02/test.49.html>
21:31 Stompro joined #evergreen

Results for 2021-09-18

06:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-18_04:00:03/test.49.html>
18:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-18_16:00:02/test.49.html>
18:06 Stompro joined #evergreen

Results for 2021-09-17

02:17 gsams_ joined #evergreen
06:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-17_04:00:02/test.49.html>
07:21 rjackson_isl_hom joined #evergreen
07:52 mantis joined #evergreen
08:31 rfrasur joined #evergreen
12:32 jvwoolf Anybody using 3.5 on Ubuntu 18.04?
12:33 jvwoolf Or 3.6, same OS?
12:37 berick jvwoolf: yes, 3.5 + 18.04 here.  3.6 soon.
12:38 jvwoolf berick: Had any problems with acq? Specifically line items not completely loading or being slow to load in POs?
12:40 jvwoolf We just upgraded to 18.04 over the weekend. Not sure if this is related to that or is a different issue, but it's happening on all production and test systems, including those running 3.6.
12:41 berick jvwoolf: hm, no, nothing like that has come up
12:43 jvwoolf berick: Thanks. Seems like I have my Friday afternoon cut out for me :)
12:50 Dyrcona We've been on 18.04 since last year. I think we had some issues with acq loading performance when we test 3.6 on our training server. We had also tested Pg 12 for a bit, so the slowness may have been related. I've tried searching my email for "acquisitions slow" but that turns up too much to be useful.
12:52 jvwoolf Dyrcona: Thanks for checking
12:55 Dyrcona Well, I'm still checking. I found an email about line items sometimes being blank, and I thought we had opened a Lp bug, but of course I can't find it.
12:56 Dyrcona Ah ha. It was tlittle who opened bug 1917482
15:01 Dyrcona jvwoolf: OK.
17:09 mmorgan left #evergreen
17:38 Stompro joined #evergreen
18:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-17_16:00:03/test.49.html>

Results for 2021-09-16

04:27 gsams joined #evergreen
06:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-16_04:00:02/test.49.html>
07:11 rjackson_isl_hom joined #evergreen
07:40 mantis joined #evergreen
07:42 collum joined #evergreen
09:38 Dyrcona The fine generator does it, IIRC.
09:43 Dyrcona There's also a database function that you could run manually if you're really anxious to update patrons: CREATE OR REPLACE FUNCTION actor.calculate_system_penalties( match_user INT, context_org INT ) RETURNS SETOF actor.usr_standing_penalty
09:43 Dyrcona Or, you could use that to see if the penalties will actually apply to the patrons that you think they should.
09:45 mmorgan Dyrcona: Ok, thanks. I can see that my test patron got the penalty at 12:30am, and that's when the fine generator runs, so that works for me!
09:47 Dyrcona Glad to hear it worked.
09:47 mmorgan Good to know about the function, though. So that returns the set of penalties and you'd need to INSERT into actor.usr_standing_penalty? Or does that do the INSERT?
09:47 mmorgan Or the delete in some cases?
16:00 jihpringle joined #evergreen
16:17 jvwoolf left #evergreen
17:01 mmorgan left #evergreen
18:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-16_16:00:03/test.49.html>
18:07 Stompro joined #evergreen
18:49 alynn26 joined #evergreen
19:10 Stompro joined #evergreen

Results for 2021-09-15

06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:27 rjackson_isl_hom joined #evergreen
08:38 mmorgan joined #evergreen
08:39 rfrasur joined #evergreen
10:15 jihpringle joined #evergreen
10:19 Stompro joined #evergreen
10:29 miker grabbing 1285 for upgrade greatness
10:32 pinesol [evergreen|Jason Etheridge] lp1905028 lost items and price versus acq cost - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=aaad480>
10:32 pinesol [evergreen|Mike Rylander] Stamping upgrade script - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=789cbe0>
10:55 alynn26 joined #evergreen
12:19 Christineb joined #evergreen
16:27 jvwoolf left #evergreen
17:17 mmorgan left #evergreen
18:01 pinesol News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//arch​ive/2021-09/2021-09-15_16:00:03/test.49.html>
18:27 Stompro joined #evergreen
19:01 jihpringle joined #evergreen
19:26 Guest9 joined #evergreen

Results for 2021-09-14

06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:32 rjackson_isl_hom joined #evergreen
08:17 mantis joined #evergreen
08:22 collum joined #evergreen
13:16 mixo thank you for help
13:18 Dyrcona So, that opensrf.setting.host_config.get call seems to be coming from SettingsClient, but the subsequent opensrf.settings.default_config.get call does not appear to be logged, so I don't think getting the settings is the problem.
13:18 Dyrcona mixo: On behalf of those who helped you, "You're most welcome!"
13:22 Dyrcona berick: Can I just throw a binary marc file at the port to test it? (It looks like it, but thought I'd ask.)
13:33 Dyrcona Well, i tried lobbing  a MARC record at it using netcat and nothing happened.
13:36 Dyrcona Interesting, it actually got something in my case: Sep 14 13:27:23 training /openils/bin/marc_stream_importer.pl: [INFO:5664:marc_stream_impor​ter.pl:449:163163899556641] stream parser read 1603 bytes
13:37 Dyrcona Whatever happens after that, I don't see authentication nor vandelay calls in the logs, and yes, I'm using syslog for everything.
15:04 JBoyer Ok, anyone joining later feel free to throw an #info out.
15:05 JBoyer #topic Action Items from Last Meeting
15:05 JBoyer JBoyer will exercise the staff client in a current release of Edge, and JBoyer will look at adding Edge on Windows support to the Hatch installer
15:05 JBoyer Edge testing not being especially high on my list I have not made time to properly put it through its paces.
15:05 JBoyer berick has shown though that it can be done without much trouble, so hatch installer changes shouldn't be too bad.
15:05 JBoyer If anyone else would like to look into this please let me know, lest I action again.
15:06 JBoyer (or rather, #act yourself.)
15:10 gmcharlt Edit
15:10 gmcharlt Course materials
15:10 pinesol Launchpad bug 1904593 in Evergreen "yaous for my account url" [Wishlist,Confirmed] https://launchpad.net/bugs/1904593 - Assigned to Rogan Hamby (rogan-hamby)
15:10 csharp_ gmcharlt: we'll be testing bug 1207533 on a PINES-ish server next week if I can get it done
15:11 csharp_ also notes re-do
15:11 abneiman csharp_++
15:12 terranm I think the pullrequest had been removed from the notes consolidation - that would be nice if it is ready to test and we can test it next week though
15:12 JBoyer To give a minor teaser for those not looking at the agenda, the more of the 60 signed off bugs we can get committed the better. :)
15:12 terranm +1
15:12 mmorgan +1
15:12 shulabear +1
15:13 JBoyer Any other Evergreen release discussion before moving on?
15:13 abneiman I added Patron Notes to the agenda for later discussion since it's a little big & invasive. With the longer timeline we should be able to have that rebased & re-pullrequested though.
15:13 terranm A lot of the remaining open pullrequests are things that can't be easily tested and require sys admins and/or developers to look more deeply
15:14 abneiman yes, what terranm said :)
15:14 terranm abneiman++
15:15 JBoyer Yeah, there are a number of things that are likely not terribly difficult to test, but they are backend things. The "don't specifically require the opensrf user" is certainly one of those.
15:15 terranm Note also that Bill has been working on redoing the patron interfaces, so a number of things like notes consolidation will need to have updates done to his new branch at some point too
15:15 JBoyer (being quite difficult to test during a bug squashing week)
15:17 Guest8574 joined #evergreen
15:18 JBoyer SO, If you're able to put in some time next week with a local test server, please check out the SysAdmin and Developer Review sections of Terran's bug squashing week spreadsheet.
15:18 JBoyer moving on
15:18 JBoyer #topic Documentation Updates
15:18 JBoyer DIG is preparing to do a comprehensive docs review to catch out of date or missing docs and fill in the blanks.
15:22 abneiman oh! and two bugs that would help DIG & need dev eyes are bug 1930099 and bug 1903476
15:22 pinesol Launchpad bug 1930099 in Evergreen "generate_docs.pl should be able to run on Windows" [Medium,Confirmed] https://launchpad.net/bugs/1930099
15:22 pinesol Launchpad bug 1903476 in Evergreen "Generate previews of documentation when documenters open a pull request on Github" [Wishlist,Confirmed] https://launchpad.net/bugs/1903476
15:24 terranm Here's the link to the bug squashing week spreadsheet for next week: https://docs.google.com/spreadsheets/d/1SE5A​G1MgrXq2zHBY6qYcHNGVuIdzsihpfL2ZIIrE45s/edit - see the Open Pull Requests tab for things that need to be tested on local systems by sysadmins/developers
15:24 JBoyer terranm++
15:24 mmorgan terranm++
15:25 terranm "Test Group" categorizations are my own and some may involve additional groups
15:25 dluch terranm++
15:25 JBoyer Hopefully some time can be carved out for those two DIG bugs abneiman mentioned next week also, they look very helpful.
15:25 JBoyer ... Next up is
15:27 JBoyer #topic New Business
15:27 JBoyer Review / discussion of Consolidated Patron Notes (lp 1846354) from abneiman
15:27 pinesol Launchpad bug 1846354 in Evergreen "wishlist: Consolidate patron notes, alerts, and messages" [Wishlist,New] https://launchpad.net/bugs/1846354 - Assigned to Jason Etheridge (phasefx)
15:28 abneiman yes - phasefx can't be at this meeting, but I wanted to get a sense of where the community is on that one. It's a little big & hairy and I know berick is working in a similar space.
15:29 abneiman but it has also languished for a while, so, are there specific things that it needs? just more testing and review?
15:29 abneiman (gmcharlt please feel free to add anything I've forgotten)
15:30 terranm I think the last time we tested the conversion went well but there was some code cleanup needed
15:30 abneiman anyway, since it's a big staff-facing change, I just wanted to see what else we can do to get this one over the hump
15:31 gmcharlt yeah, echoing abneiman
15:31 terranm +1
15:32 berick abneiman: *nod*
15:32 terranm I would really love to get that one into 3.8
15:32 mmorgan +1
15:33 abneiman ok, if it's just the rebase and a few small wrinkles, I'm pretty confident that can be PR'd in time to test next week
15:33 terranm abneiman++\
15:34 abneiman because I, too, would love to get this into 3.8 :)
15:34 terranm oops abneiman++
15:34 JBoyer terranm, csharp_ do you think that's soon enough to also throw at a PINES-sized test system?
15:34 JBoyer Because it works *pretty* well on concerto. ;)
15:35 abneiman yes, scale testing is key here
15:35 JBoyer Anyone else with a large-ish test system that is able to try it out would also be extremely welcome.
15:35 mmorgan Are there concerns other than migration with a large data set?
15:36 terranm (I defer to csharp_ on that)
15:36 abneiman mmorgan: part of it is the way larger systems might leverage some of the features like notes-scoping in more complex ways
16:25 Dyrcona Yeah, I was thinking it might be a generated function in the Perl code.
17:01 mmorgan left #evergreen
17:45 Bmagic upteen hours later. It's an insert into  authority.control_set_bib_field_metabib_field_map that did the trick
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:04 nfBurton joined #evergreen
18:26 Stompro joined #evergreen

Results for 2021-09-13

00:06 troy joined #evergreen
00:06 ejk joined #evergreen
00:19 berick joined #evergreen
06:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:42 rjackson_isl_hom joined #evergreen
07:52 mantis joined #evergreen
07:59 collum joined #evergreen
15:53 jihpringle joined #evergreen
16:36 jvwoolf1 left #evergreen
17:10 mmorgan left #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:24 Stompro joined #evergreen

Results for 2021-09-12

06:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:04 mixo joined #evergreen
06:08 mixo Hello. I can't use web staff client. I get this is error: "WebSocket connection to 'wss://evergreen.tsu.ge/osrf-websocket-translator' failed:"
06:09 mixo I cann't find osrf-websocket-translator
17:54 Guest20 Sorry it was my mistake, I've  sank  I use apache as proxy and nginx is another solution
17:55 Guest20 I temporary decide don't use proxy
17:55 Guest20 thank you for response
18:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:18 Stompro joined #evergreen
18:35 Stompro joined #evergreen

Results for 2021-09-11

06:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
11:15 gsams_ joined #evergreen
18:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>

Results for 2021-09-10

06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:24 rjackson_isl_hom joined #evergreen
07:52 mantis joined #evergreen
08:38 mmorgan joined #evergreen
11:21 Dyrcona That's my understanding: SVF = Single Value Field and MVF = Multiple Value Field. I figured it was covered earlier, so didn't say anything then.
11:23 Dyrcona Also as rhamby suggests, if you can find a way to narrow the list of bib records to only those that have the new attribute, it will save you a lot of time on the reingest call. You could try joining to metabib.real_full_rec where the tag is 347 and subfield is b, etc.
11:24 rhamby yeah even if you can't target the exact subset (though you probably can) if you can at least narrow out the vast majority it'll save time and db activity
11:25 derekz For sure. To test, I'll just make a simple edit and save a record via the web client. If all is good, I'll collect the bib IDs that need reingest. I definitely don't want to hit the db with unnecessary activity.
12:53 jvwoolf joined #evergreen
16:39 Bmagic miker: let's say I wanted an authority "110" heading to apply to the "subject" axis. It seems* like all I need to do is insert the glue in authority.browse_axis_authority_field_map. Which I've done on a test machine. It's not working immediately, so I need to reingest?
16:49 jihpringle joined #evergreen
16:51 Dyrcona Bmagic: You'll most likely want to run the authority linking programs. Otherwise, you can wait for the changes to take effect as bibs and authorities are updated.
16:54 gsams joined #evergreen
17:07 Bmagic later!
17:09 mmorgan left #evergreen
17:30 jvwoolf joined #evergreen
18:02 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
21:15 jvwoolf joined #evergreen

Results for 2021-09-09

00:30 eady joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:52 mantis joined #evergreen
08:23 rfrasur joined #evergreen
08:31 Dyrcona joined #evergreen
15:43 mixo Ok. thank you
16:22 jvwoolf left #evergreen
17:16 mmorgan left #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:54 mantis joined #evergreen
21:48 JBoyer joined #evergreen
22:19 Stompro joined #evergreen

Results for 2021-09-08

06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:15 rjackson_isl_hom joined #evergreen
08:45 mmorgan joined #evergreen
09:00 stephengwills joined #evergreen
09:06 jvwoolf joined #evergreen
10:14 Dyrcona joined #evergreen
11:37 nfBurton joined #evergreen
11:42 pinesol [evergreen|Garry Collum] LP1809157 SMS Carriers display not in alphabetical order - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=dc243b4>
12:08 jihpringle joined #evergreen
12:29 rfrasur joined #evergreen
12:32 pinesol [evergreen|Mike Rylander] LP#1823983: repeat_delay check removes event definition id filter - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=36cc5ef>
13:20 akilsdonk joined #evergreen
13:20 miker joined #evergreen
13:20 phasefx joined #evergreen
14:58 berick yes, assuming the right perms
14:58 Dyrcona Here's the thing: We have 3 catalogers that are going to load records via the stream importer from OCLC, and we'll want them to all be able to process it, etc.
14:59 Dyrcona Also, I've never used Vandelay. Can you reuse a queue? That is, can you add some records, process them, then add more later and just process those?
14:59 Dyrcona Well, "never' means once or twice for one time tests.
15:00 berick yes you can reuse queues.
15:01 Dyrcona I thought so, but I've never done it.
15:01 Dyrcona Thanks, berick++
15:01 Dyrcona We're going to set up a test on our training server, and I think I know what I need to do to set it up, despite my seemingly ignorant questions. :)
15:02 berick Dyrcona: you can also tell the stream importer to import the records as they arrive so staff don't have to interract with vandelay
15:02 Dyrcona berick: Yeah. I think they want them in the queue and then they import/overlay later.
15:02 berick *nod*
17:38 Bmagic That table is not* receiving rows from the authority record's 550 field
17:50 Bmagic I'm mistaken on that, the 550 is in the authority.simple_heading, somewhere along the search, my 550 stuff is getting omitted
17:51 Bmagic I'm currently disecting FUNCTION metabib.browse
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:25 Bmagic I think it's this hardcoded string in the function: AND ahf.heading_purpose IN (' || $$'variant'$$ || ')
18:27 jihpringle joined #evergreen
21:20 stephengwills left #evergreen

Results for 2021-09-07

00:57 gmcharlt joined #evergreen
00:57 devted joined #evergreen
01:00 pinesol joined #evergreen
06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:22 rjackson_isl_hom joined #evergreen
07:48 collum joined #evergreen
07:55 mantis joined #evergreen
09:13 rfrasur joined #evergreen
09:20 jvwoolf joined #evergreen
09:30 alynn26 joined #evergreen
11:22 pinesol [evergreen|Chris Sharp] LP#1932051: Batch calls for add items to bucket - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=057c6ba>
11:22 pinesol [evergreen|Jeff Davis] LP#1932051: serialize adding items to bucket from Item Status - <http://git.evergreen-ils.org/?p=​Evergreen.git;a=commit;h=fc914bd>
11:22 csharp_ jeffdavis++ # bug 1932051 has solved our problems
11:22 pinesol Launchpad bug 1932051 in Evergreen "AngularJS Add to Item Bucket Generating too many simultaneous requests" [High,Fix committed] https://launchpad.net/bugs/1932051
11:46 jihpringle joined #evergreen
14:08 jihpringle joined #evergreen
14:11 JBoyer nfBurton, ldconfig is definitely installed, but if settings-tester.pl is complaining about it you may need to put your library dir (normally /openils/lib ) in a file such as /etc/ld.config.so.d/opensrf.conf
14:12 JBoyer Additionally if the file is there but is missing the .conf extension that may stop it from being used. I don't recall when that may have changed.
14:15 nfBurton Yeah, that's there too. I recently tried a test Ubuntu 16 -> 18 upgrade and accidentally trashed some system files. I've got everything mostly back but I get this 500 for opensrf services when I could sign in fine.
14:28 Dyrcona I have an AngularJS/translation question. I'm looking at Lp 194920, and it looks like the most localized place to make a change so that a year of -1 shows up as "Legacy/No Date" is  line 106 of t_pane_summary.tt2: {{circ_count.year}}: {{circ_count.count}}
14:28 pinesol Launchpad bug 194920 in Envy "Python error on Debian (64 Studio)" [Medium,Fix released] https://launchpad.net/bugs/194920 - Assigned to Alberto Milone (albertomilone)
14:29 Dyrcona bug 1942920
15:08 nfBurton Ah I think I just need to figure out how to change the psql port cause it required me to also upgrade to psql110 and the port is one number different
15:08 nfBurton But the current cluster is offline hence the 5
15:08 nfBurton 500
15:09 nfBurton Glad this was just the test server lol
15:19 Dyrcona nfBurton: You can remove the old Pg and reconfigure the new PostgreSQL to use the old port.
15:20 Dyrcona But, you'll need to run pg_upgrade, etc. before that, assuming that PostgreSQL server was actually upgraded.
15:22 nfBurton I did. And I can see some admin settings, but it seems to be having trouble with some opensrf services, getting a 500 error. I'm actually not finding that old port anywhere.
17:13 mmorgan left #evergreen
17:13 Stompro joined #evergreen
17:38 Bmagic bug 1851586
17:38 pinesol Launchpad bug 1851586 in Evergreen "Integrate Stripe point-of-sale terminal" [Undecided,New] https://launchpad.net/bugs/1851586
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
18:05 Stompro joined #evergreen
19:59 Stompro joined #evergreen
20:54 Stompro joined #evergreen

Results for 2021-09-06

06:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
07:05 alynn26 joined #evergreen
07:59 alynn26_away joined #evergreen
08:35 Stompro joined #evergreen
08:37 Stompro joined #evergreen
18:01 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>

Results for 2021-09-05

06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:15 tsadok joined #evergreen
12:45 Stompro joined #evergreen
13:44 Stompro joined #evergreen

Results for 2021-09-04

03:42 stompro__ joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
11:34 StomproJ joined #evergreen
18:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
22:03 Stompro joined #evergreen

Results for 2021-09-03

05:11 eby joined #evergreen
06:00 pinesol News from qatests: Testing Success <http://testing.evergreen-ils.org/~live>
06:25 jeffdavis joined #evergreen
07:10 rjackson_isl joined #evergreen
07:33 mantis joined #evergreen
10:44 pastebot "Bmagic" at 168.25.130.30 pasted "json filter" (11 lines) at http://paste.evergreen-ils.org/14426
10:46 pastebot "Dyrcona" at 168.25.130.30 pasted "This should also work" (11 lines) at http://paste.evergreen-ils.org/14427
10:46 Dyrcona Bmagic ^^
10:46 Bmagic can I get a sanity check? I've tried my hand at these JSON filters several times and it's tricky to say the least. And testing in dev is "fun"
10:46 Bmagic Dyrcona: I like that better. I was thinking that I could drop the redundant "and" - like you said, it was assumed
10:47 * mmorgan always has to carefully test before letting them loose.
10:47 Dyrcona "and" is useful when you're doing more complicated things, like nesting with "or" for example.

Result pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143