| 16:29 |
bshum |
@dessert Bmagic |
| 16:29 |
* pinesol |
grabs some pineapple chocolate things from New Zealand for Bmagic |
| 16:30 |
Bmagic |
The nightly pinesol compile summary? |
| 16:30 |
bshum |
http://testing.evergreen-ils.org/~live/ <-- only shows last 2022-04-25 |
| 16:31 |
bshum |
Which is the last time something went into the css feed I guess, for the bot to read and spit into the channel |
| 16:32 |
bshum |
I mean I'm pretty sure the live tests are still broken somehow, but I miss when it says "success" :P |
| 16:32 |
Bmagic |
I've never had the privelege of looking at how this works |
| 16:32 |
bshum |
It's probably something wrong with the testing server |
| 16:32 |
Dyrcona |
Bmagic: I didn't say antying about acq for electronic resources because I don't know. The people who would know don't hang out here. Try the general mailing list, or maybe the cataloging list. |
| 16:33 |
Bmagic |
good idea |
| 16:33 |
* Dyrcona |
grumbles..... |
| 16:34 |
Dyrcona |
bshum: I used to have access to the test server, but not sure if I still do. It may have moved.... I never looked at it more than once or twice anyway. |
| 16:39 |
mmorgan |
Also, it is National Lost Sock Memorial Day.... |
| 16:40 |
Bmagic |
mmorgan: lol |
| 16:49 |
Dyrcona |
Well, it's the observance of V-E Day in some countries that still observe these things. |
| 13:11 |
Dyrcona |
OK. I've definitively tracked it down to changes from erlang-p1-xmpp 1.4.4 to erlang-p1-xmpp 1.5.6. The older library included a numeric code in the errors, though I can't find anything about that in the RFCs. |
| 13:11 |
Dyrcona |
Should this be discussed at the next developers' meeting? |
| 13:25 |
Dyrcona |
https://github.com/processone/xmpp/commit/6fc29dce5ef566b9dd6245f0b3619913756a1739 |
| 13:51 |
jeff |
gmcharlt: we rarely use that interface, but I can try testing here to see if we run into the issue (we might not due to the s2s particular you mentioned) |
| 13:51 |
jeff |
amusingly, the "atomic works" is probably the exact opposite of what our 1.x holdshelf experience was. :-) |
| 14:00 |
dluch |
#startmeeting 2022-05-05 - Documentation Interest Group Meeting |
| 14:00 |
pinesol |
Meeting started Thu May 5 14:00:09 2022 US/Eastern. The chair is dluch. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 14:00 |
pinesol |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
| 14:28 |
dluch |
I'm thinking that perhaps this is a good topic for discussion during the Hackfest. Sound okay? |
| 14:29 |
jihpringle |
works for me |
| 14:30 |
dluch |
Is there any other new business we need to discuss? |
| 14:31 |
jihpringle |
is there anything we want to talk about with 3.9 being released? |
| 14:32 |
jihpringle |
we don't have a test server yet so I haven't had a chance to look at it, but based on the release notes there's at least a few changes that affect docs |
| 14:32 |
jihpringle |
like action triggers now being in angular |
| 14:32 |
dluch |
I also have not had a chance to look at it yet. Good point, though. Definitely some things that will require changes and new screenshots |
| 14:33 |
jihpringle |
might just be that we need to update the re-org spreadsheet with the doc needs from 3.9 |
| 14:33 |
jweston |
good stuff! until we've had a chance to test it post-release, should we delay this topic to June call? |
| 14:33 |
dluch |
jihpringle: That's probably the best way |
| 14:33 |
jihpringle |
do we want to plan to make this a discussion topic for the hackaway? |
| 14:33 |
jweston |
+1 to hackaway topic |
| 13:20 |
miker |
ah! libxml could be it, yes. we've run into other issues with it. I could see it changing from empty string to null... |
| 13:22 |
Dyrcona |
Here's the backtrace: https://pastebin.com/hwZ8z5T9 |
| 13:22 |
Dyrcona |
I configured with --enable-debug. |
| 13:24 |
Dyrcona |
miker: That's possibly the culprit. A little test program doesn't crash when I do x = atoi(""); |
| 13:30 |
Dyrcona |
Ok. If I change line 698 in transport_session.c (get_xml_attr()) to return "" instead of NULL, we don't crash. I'm not sure that's the best fix, however. |
| 13:32 |
miker |
probably better style to test for null. but ... then do we need to protect a free() later on? (not in a position to dig right now, unfortunately) |
| 13:33 |
miker |
Dyrcona++ |
| 13:35 |
miker |
and, entirely unrelated, I've finally uploaded the 3.9 release artifacts to lupin and (thanks to abneiman) the website is pointing at them! (the downloads page could use some love, but changes deserve some thought first) |
| 13:36 |
jonadab |
Dyrcona: Sure, or returning an object that evalutes to 0 in numeric context, false in boolean context, or "Error: empty string is not numeric" in string context :-) |
| 13:36 |
jonadab |
And throws an exception if called as code. |
| 13:38 |
Dyrcona |
No, That's not it, either. :) |
| 13:40 |
Dyrcona |
miker: Yeah, my change to return "" was just to verify a hunch. I'd really like to figure out why this blows up on Ubuntu 22.04 and not 20.04 or 18.04. I've confirmed with a little test program that passing NULL to atoi segfaults on all 3, which I suspected. |
| 13:42 |
Dyrcona |
For the logs, if I do "request math add 2,2" that crashes on 22.04 but says "Received no data from server" on earlier distros, and.... that may be a clue that I'm overlooking. We're getting "something" back on 22.04. |
| 14:01 |
Dyrcona |
Yeah, we're crashing before we get to the point of printing "Received no data from server." It just gets more puzzling the more I look. |
| 15:32 |
Dyrcona |
gdb is not very much fun... |
| 10:01 |
pinesol |
Launchpad bug 1832408 in OpenSRF "Cannot (or should not) use root to register ejabberd users" [Undecided,New] https://launchpad.net/bugs/1832408 |
| 10:02 |
Dyrcona |
jeff: bug 1934508 |
| 10:02 |
pinesol |
Launchpad bug 1934508 in ejabberd (Ubuntu) "Ejabberd fails with latest apparmor profile on Ubuntu 21.04" [Undecided,New] https://launchpad.net/bugs/1934508 |
| 10:02 |
jeff |
The Ansible issue with ejabberd was a bug in the community.general, ejabberd_user collection. My notes on that say: |
| 10:02 |
jeff |
> recent changes broke "exists" and "changed" detection, because it's no longer testing the return value of the ejabberdctl command, so it always thinks that things exist and always thinks that user passwords need to be set, even if they are already set to the chosen value. |
| 10:02 |
jeff |
(so, probably unrelated to your issue) |
| 10:03 |
Dyrcona |
I want to investigate a segfault from testing the other day. I made a typo when doing opensrf.math add and srfsh segfaulted. |
| 10:04 |
Dyrcona |
I'd rather not say, "Reboot the server." in the installation instructions, but if that is what it comes down to, then OK. :) |
| 10:08 |
Dyrcona |
`make check` still works on Debian 9, so I assume it will work everywhere else since I've tested it on all releases of Ubuntu and the other Debian releases are closely related. |
| 10:12 |
Dyrcona |
So, it looks like if you make a request to a non-existent service from srfsh on Ubuntu 22.04, srfsh segfaults. A bogus method called on a real service returns a 404. On Debian 9, the former doesn't crash and says 'No data received from server.' |
| 10:18 |
Dyrcona |
Ok. It looks like the router and some other services also crash. |
| 10:31 |
Dyrcona |
OK. The router, etc., are not crashing now that I'm trying to make them crash. |
| 14:04 |
Dyrcona |
Well, that's nice. Remote site Internet dropped while I was editing a file with vi. |
| 14:30 |
|
Dyrcona joined #evergreen |
| 14:51 |
|
collum joined #evergreen |
| 15:04 |
Dyrcona |
Well, 'make check' in OpenSRF fails with what looks like a compiler error on jammy. I wonder if anyone runs these tests and if they work on earlier releases. I'll have to try it on focal and bionic. |
| 15:05 |
Dyrcona |
make check succeeds in OpenSRF/src/perl/, but looks like make check higher up runs that, too. |
| 15:10 |
Dyrcona |
So, the tests pass on Ubuntu 18.04. I assume this is a compiler change in 22.04. Probably related to a newer C standard. |
| 15:14 |
Dyrcona |
check_osrf_message.c:20:14: error: expected ‘)’ before ‘==’ token |
| 15:14 |
Dyrcona |
20 | fail_if (o == NULL, "osrfMessage not created"); |
| 15:22 |
Dyrcona |
Well, now to figure out what changed in the standards/compiler. |
| 15:28 |
Dyrcona |
It might be changes in libcheck since version 0.10. Jammy has 0.15. |
| 15:40 |
Dyrcona |
Bmagic: Just install OpenSRF master on Ubuntu 20.04/Focal. |
| 15:52 |
|
collum joined #evergreen |
| 16:12 |
Dyrcona |
OK. The errors were about the test themselves. Now, to see if the changes still work on earlier version of the check library. |
| 16:15 |
Dyrcona |
Yeahp. Still work on Focal. |
| 16:25 |
|
jvwoolf left #evergreen |
| 16:32 |
Dyrcona |
bug 1970667 |
| 06:01 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-04/2022-04-22_04:00:02/test.49.html> |
| 06:48 |
* JBoyer |
shakes fist at test |
| 06:48 |
JBoyer |
My testing setup must be slightly different in some way. (IT |
| 06:48 |
JBoyer |
's not reset between builds, for one thing) |
| 06:51 |
JBoyer |
.... OR, I did not push the change, because it's not in there. :-/ |
| 06:53 |
JBoyer |
Done, and only 1 day late to make the RC... |
| 07:06 |
pinesol |
News from commits: Test Followup: Fix Jacket Dir in autogen.sh <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d436f5b4a409bdff0d597b596b07f71b63f398fc> |
| 07:15 |
|
rjackson_isl_hom joined #evergreen |
| 07:51 |
|
RFrasur joined #evergreen |
| 07:57 |
|
collum joined #evergreen |
| 10:00 |
terranm |
#badjokefriday |
| 10:01 |
Dyrcona |
terranm++ |
| 10:01 |
mmorgan |
terranm++ |
| 10:03 |
terranm |
mmorgan: When I tested the My Lists code it looked good. Ruth's comment about the workflow is a different usability problem than the formatting, IMO. |
| 10:04 |
mmorgan |
terranm: Thanks, I thought it looked good, too. I'm just wondering about the timing with the release schedule. |
| 10:04 |
terranm |
mmorgan++ |
| 10:16 |
|
terranm joined #evergreen |
| 12:19 |
Bmagic |
terrnam: yep, found that one |
| 12:19 |
terranm |
Could be hitting the same error if it's a large list? |
| 12:19 |
Bmagic |
There is something going on, but it might be local. Clicking on Download CSV results in an empty file. Then I decided to clck on the list to load the titles, that throws a 500 error. Tracking down the logs now |
| 12:19 |
Bmagic |
It's a small list of one bib that I just created on a test system |
| 12:26 |
|
collum joined #evergreen |
| 12:27 |
jvwoolf |
Bmagic: Getting the same results on a 3.8 test server |
| 12:27 |
jvwoolf |
It works on 3.8 |
| 12:27 |
jvwoolf |
I mean 3.6 |
| 12:27 |
Bmagic |
oh! Mine is 3.7, and on master it works |
| 12:27 |
Bmagic |
hmmmm |
| 12:31 |
Bmagic |
so maybe it's not me? |
| 15:38 |
|
mmorgan joined #evergreen |
| 16:37 |
pinesol |
News from commits: LP1907863 Bootstrap Opac: My Lists formatting <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4f1a4030660e52282722a2b22165535bf4af7c44> |
| 17:06 |
|
mmorgan left #evergreen |
| 18:02 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-04/2022-04-22_16:00:06/test.49.html> |
| 18:50 |
|
rjackson_isl_hom joined #evergreen |
| 19:00 |
|
rjackson_isl_hom joined #evergreen |
| 01:27 |
pinesol |
News from commits: LP1956626 Copy editor loads all needed copy locations <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=ab5478b879e9e34a6fe023c188c7a95c11c425ca> |
| 01:57 |
pinesol |
News from commits: LP#1965317 Barcode Completion on Traditional Cat Staff Holds <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=3663817ec8c975d09150fef4c578e1fbd7ae0312> |
| 04:36 |
|
gmcharlt joined #evergreen |
| 06:00 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-04/2022-04-20_04:00:04/test.49.html> |
| 06:53 |
|
Dyrcona joined #evergreen |
| 07:16 |
|
rjackson_isl_hom joined #evergreen |
| 07:47 |
|
RFrasur joined #evergreen |
| 12:39 |
JBoyer |
Dyrcona, that's pretty much what I mean; if we want to use GH but it can't handle our release processes then maybe we need to change the process to better use the tool. :) |
| 12:40 |
JBoyer |
berick, and since we'd want some kind of trigger anyway (since every commit need not be a release) that's a place that a few special instructions could be rather than a very large pile of instructions for the whole process. |
| 12:40 |
Dyrcona |
Well, we should make it more difficult for patches to alter the schema, i.e no schema changes in patch/bugfix releases. |
| 12:41 |
Dyrcona |
You pretty much only detect the conflicts with transactions by testing the db upgrade. I assume everyone does that, right? |
| 12:43 |
JBoyer |
Which brings to mind something I've thought about but had no time to really pursue: git hooks that run scripts to do things like run xlst to verify the IDL, try to alert you if you're pushing an upgrade script with an ALTER TABLE, etc. Having a hook automatically run a full (not live, I suppose) make check before pushing to origin, etc. Lots of ideas, not a lot of time. |
| 12:44 |
JBoyer |
Dyrcona, yeah, though there may be things you know you don't want in an xact (hello reingests) and some kind of barrier comment ( like a -- NOXACT -- in the sql file) could push those to the end of a generated point release file. |
| 12:48 |
Dyrcona |
I split the db upgrade code out of make_release some time ago because I find it useful CWMARS upgrades because we're always backporting things: https://gist.github.com/Dyrcona/00bd6b6290b6fbbb579c7f93b360ab0d |
| 13:05 |
JBoyer |
I do especially dislike that last one, since that means some files are owned by root and you can no longer run git clean without sudo. (Also, make clean could be more similar to git clean than it is today) |
| 13:07 |
Dyrcona |
Jobyer: I always do `sudo chown -R opensrf:opensrf /openils ./` after make install. |
| 13:09 |
JBoyer |
That's one way to do it too, yeah. |
| 13:12 |
Dyrcona |
Also, when testing Evergreen on Ubuntu 22.04, I get a whole new set of messages from autotools about deprecation, etc. I haven't had time to really bang on it, yet. |
| 13:30 |
|
rfrasur joined #evergreen |
| 13:30 |
|
RFrasur__ joined #evergreen |
| 14:16 |
|
rjackson_isl_hom joined #evergreen |
| 17:12 |
|
mmorgan left #evergreen |
| 17:46 |
* eeevil |
thinks he just read that he needn't create an RC tarball! (j/k, I will be doing that this evening) |
| 17:46 |
miker |
my nick swapped back to eeevil at an appropriate time, at least |
| 18:00 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-04/2022-04-20_16:00:03/test.49.html> |
