| Time |
Nick |
Message |
| 04:50 |
|
alynn26 joined #evergreen |
| 06:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:18 |
|
Christineb joined #evergreen |
| 07:54 |
|
collum joined #evergreen |
| 08:31 |
|
mantis joined #evergreen |
| 08:40 |
|
mmorgan joined #evergreen |
| 09:22 |
|
Dyrcona joined #evergreen |
| 09:23 |
Dyrcona |
So, I found out that a full ingest is pretty much required going from 3.5 to 3.7. Titles and authors were not showing the bootstrap OPAC on our training server until I ran pingest over the weekend. |
| 09:36 |
miker |
Dyrcona: that's ... strange. missing data in metabib.display_entry, somehow? |
| 09:38 |
|
jvwoolf joined #evergreen |
| 09:50 |
Dyrcona |
miker: Yes. The TTOPAC pulls titles and authors from the MARC, IIRC. BooPAC uses display fields. |
| 09:53 |
mmorgan |
JBoyer++ |
| 10:50 |
mantis |
We're on 3.6.5 using Angular for the staff but still using TPAC for the OPAC. When accessing the Patron View button on conjoined items, we get a server error. This however works when Boopac is enabled on our other test servers. Is this a known bug? |
| 11:06 |
Dyrcona |
mantis: IDK, but if it is not on Lp, then it's probably not widely known. |
| 11:41 |
|
jihpringle joined #evergreen |
| 12:15 |
collum |
mantis: We don't have any conjoined items, but I just tried it in our test database and it worked in the TPAC. We are on 3.7.2. |
| 12:17 |
mantis |
collum: Thanks for giving it a shot. With the community servers on Bootstrap, it's hard for us to tell if there is an issue on my end or an actual bug. |
| 12:43 |
|
jvwoolf1 joined #evergreen |
| 13:38 |
|
rfrasur joined #evergreen |
| 13:51 |
|
terranm joined #evergreen |
| 14:31 |
JBoyer |
For those that observe, dev meeting is in 30. |
| 14:38 |
terranm |
Blessed be |
| 14:53 |
csharp_ |
@praise dev meetings |
| 14:53 |
* pinesol |
Weee Belong. We Belong. We belong together, dev meetings |
| 14:54 |
alynn26 |
lol |
| 14:54 |
|
shulabear joined #evergreen |
| 14:55 |
|
sandbergja joined #evergreen |
| 14:58 |
berick |
heh |
| 14:58 |
berick |
@praise [band] |
| 14:58 |
* pinesol |
Failed Vegetarians LOVES the RESISTANCE! |
| 14:59 |
Dyrcona |
@blame [band] |
| 14:59 |
pinesol |
Dyrcona: Your failure is now complete, Leading Zeroes. |
| 14:59 |
csharp_ |
@quote random |
| 14:59 |
pinesol |
csharp_: Quote #206: "<tom_waits> The large print giveth and the small print taketh away" (added by berick at 03:24 PM, August 20, 2020) |
| 15:00 |
shulabear |
That's a mighty fine quote. |
| 15:02 |
JBoyer |
Right-o, let's have a shin-dig. |
| 15:02 |
JBoyer |
#startmeeting 2021-X-Y - Developer Meeting, Agenda Available at https://wiki.evergreen-ils.org/doku.php?id=dev:meetings:2022-01-11 |
| 15:02 |
pinesol |
Meeting started Tue Jan 11 15:02:33 2022 US/Eastern. The chair is JBoyer. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:02 |
pinesol |
Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. |
| 15:02 |
pinesol |
The meeting name has been set to '2021_x_y___developer_meeting__agenda_available_at_https___wiki_evergreen_ils_org_doku_php_id_dev_meetings_2022_01_11' |
| 15:02 |
JBoyer |
#topic Introductions |
| 15:02 |
abowling |
#info abowling = Adam Bowling, Emerald Data Networks |
| 15:02 |
csharp_ |
#info csharp = Chris Sharp, GPLS |
| 15:02 |
rhamby |
#info rhamby = Rogan, EOLI |
| 15:03 |
terranm |
#info terranm = Terran McCanna, GPLS |
| 15:03 |
mmorgan |
#info mmorgan = Michele Morgan, NOBLE |
| 15:03 |
alynn26 |
#info alynn26 = Lynn Floyd, Evergreen indiana |
| 15:03 |
JBoyer |
#info JBoyer = Jason, Boyer, EOLI |
| 15:03 |
shulabear |
#info shulabear = Shula Link, GCHRL in PINES |
| 15:03 |
gmcharlt |
#info gmcharlt = Galen Charlton, Equinox |
| 15:03 |
berick |
#info berick = Bill Erickson, KCLS |
| 15:03 |
collum |
#info collum = Garry Collum, Kenton County Public Library |
| 15:03 |
Dyrcona |
#info Dyrcona = Jason Stephenson, CW MARS |
| 15:04 |
phasefx |
#info phasefx = Jason Etheridge, Equinox |
| 15:04 |
JBoyer |
Oh, good. Just noticed the typo in the startmeeting command. |
| 15:05 |
terranm |
heh |
| 15:05 |
JBoyer |
New year, new script, maybe. |
| 15:05 |
jeff |
#info jeff = Jeff Godin, Traverse Area District Library (TADL) |
| 15:05 |
mmorgan |
You mean it's not X/Y/2021? |
| 15:05 |
abowling |
JBoyer: I rebuke any of your attempts to keep us in 2021 |
| 15:05 |
JBoyer |
Ok, folks joining later feel free to #info-rm us of who's who, as pertains to you. |
| 15:05 |
terranm |
It sure FEELS like it's X/Y/2021 |
| 15:06 |
JBoyer |
agreed! |
| 15:06 |
JBoyer |
Anyway |
| 15:06 |
JBoyer |
#topic Action Items from Last Meeting |
| 15:06 |
JBoyer |
#info Dyrcona will finish up the branch for newer PostgreSQL versions ( lp 1937294 ) |
| 15:06 |
pinesol |
Launchpad bug 1937294 in Evergreen "Updating Evergreen for Newer PostgreSQL Versions" [Undecided,In progress] https://launchpad.net/bugs/1937294 - Assigned to Jason Stephenson (jstephenson) |
| 15:06 |
Dyrcona |
#info Done! |
| 15:06 |
JBoyer |
:party_emoji: |
| 15:06 |
csharp_ |
"solve for X and Y" |
| 15:06 |
abowling |
Dyrcona++ |
| 15:06 |
JBoyer |
csharp_++ |
| 15:06 |
JBoyer |
Dyrcona ++ |
| 15:07 |
alynn26 |
Dyrcona ++ |
| 15:07 |
terranm |
Dyrcona++ |
| 15:07 |
shulabear |
Dyrcona++ |
| 15:07 |
gmcharlt |
Dyrcona++ |
| 15:07 |
mmorgan |
Dyrcona++ |
| 15:08 |
JBoyer |
Dyrcona, Is there a branch in another bug or am I missing something (i.e. is this the bug we should be looking at?) |
| 15:08 |
Dyrcona |
I guess I haven't updated the launchpad bug.. |
| 15:08 |
Dyrcona |
:) |
| 15:08 |
JBoyer |
Ah |
| 15:09 |
JBoyer |
In that case there should some good news in our email later I suppose. In short, you've got concerto and friends loading deterministically? |
| 15:09 |
JBoyer |
(again, that is) |
| 15:10 |
Dyrcona |
Yes. Test results are consistent. |
| 15:11 |
JBoyer |
Dyrcona++ |
| 15:11 |
Dyrcona |
And all pass, at least, the last few times that I tried. |
| 15:11 |
JBoyer |
Ok, I'm planning to skip release info updates for lack of non-placeholder-ness unless someone prefers that be changed. |
| 15:12 |
JBoyer |
So speak now or hold your peace a few weeks |
| 15:12 |
JBoyer |
#topic Launchpad Updates |
| 15:12 |
JBoyer |
#info Snapshot |
| 15:12 |
JBoyer |
#info Open Bugs - 2606 |
| 15:12 |
JBoyer |
#info Pullrequests - 97 |
| 15:12 |
JBoyer |
#info Signedoff - 43 |
| 15:12 |
JBoyer |
#info Updates since last meeting |
| 15:12 |
JBoyer |
#info Bugs Added - 42 |
| 15:12 |
JBoyer |
#info Pullrequest tag Added - 19 |
| 15:12 |
JBoyer |
#info Signedoff tag Added - 10 |
| 15:12 |
JBoyer |
#info Fix Committed - 2 |
| 15:15 |
JBoyer |
Hopefully there's time for committers to take a look at those 43 signed off bugs. And it looks like there are a little over 50 PRs with no signoffs that can be poked at. And don't be shy about removing the PR tag if there's an issue. |
| 15:15 |
JBoyer |
On we move |
| 15:15 |
JBoyer |
#topic New Business |
| 15:15 |
JBoyer |
#topic Github actions to build docs bug 1903476 |
| 15:15 |
pinesol |
Launchpad bug 1903476 in Evergreen "Generate previews of documentation when documenters open a pull request on Github" [Wishlist,Confirmed] https://launchpad.net/bugs/1903476 |
| 15:17 |
JBoyer |
Would sandbergja or anyone else like to comment? |
| 15:17 |
sandbergja |
Yes! I can comment |
| 15:17 |
sandbergja |
We have great docs people who are contributing docs, often from Windows machines |
| 15:17 |
sandbergja |
the current docs build process doesn't work on Windows |
| 15:18 |
sandbergja |
so this is a way to have Github build it for them, so they can check their work |
| 15:18 |
sandbergja |
and have a shared point of reference with docs reviewers |
| 15:18 |
sandbergja |
My main question for this group is: are we okay using Github Actions (which is free, only means adding a smol YAML file to the repo, no additional sign-up steps necessary) |
| 15:19 |
sandbergja |
Or would that be too much commitment to Github given our current conversation of where best to host our code? |
| 15:19 |
sandbergja |
And I'd of course be happy to have some reviewers for my PR if the general idea of using Github Actions is agreeable :-) |
| 15:21 |
gmcharlt |
I've no objection |
| 15:22 |
csharp_ |
same here |
| 15:22 |
JBoyer |
I don't really have a problem with the .github bit, but if the official source stays at git.evergreen-ils.org then we either have a confusing split situation where docs work is happening primarily on GH and code work primarily "elsewhere" |
| 15:22 |
gmcharlt |
JBoyer: that's the status qwuo |
| 15:23 |
JBoyer |
I suppose so. |
| 15:24 |
JBoyer |
No objection from me since it is so minor and does help docs. |
| 15:26 |
JBoyer |
Tangentially, I keep thinking this would be an easier conversation to have in person but the world says "lol, no." *Is* there still an active conversation about the canonical location of the repository? (Not looking to necessarily continue it today, but it may be worth setting up a working group or something if there's sufficient interest) |
| 15:27 |
|
stephengwills joined #evergreen |
| 15:27 |
berick |
i think the conversation is open, but maybe not so active at the moment |
| 15:27 |
csharp_ |
@who will convene the Git Synod of 2022? |
| 15:27 |
pinesol |
abneiman will convene the Git Synod of 2022. |
| 15:29 |
JBoyer |
Definitely not very active of late, it's true. Like I said, probably not something for today; should probably have more advanced notice. |
| 15:30 |
csharp_ |
even if we stay on gitolite, we're going to need to migrate to the newer server sometime soon, but yeah, it is not this day |
| 15:30 |
JBoyer |
Back to the topic though, sandbergja ++ great work getting this together. I'm hoping to also put together some how-to steps to get things working on Windows, but the more options the more submissions, hopefully. |
| 15:31 |
JBoyer |
#action JBoyer will check out sandbergja 's GH Actions branch |
| 15:31 |
JBoyer |
#topic Eyes on bug 1955079 (mmorgan) |
| 15:31 |
pinesol |
Launchpad bug 1955079 in Evergreen "Emailing Bib Records from the catalog (staff and OPAC) reports success, but fails to send email" [High,Confirmed] https://launchpad.net/bugs/1955079 |
| 15:31 |
sandbergja |
JBoyer++ |
| 15:32 |
mmorgan |
We recently became aware of this issue. Not sure when it broke. |
| 15:32 |
mmorgan |
Also not sure why it's not more widely reported. |
| 15:32 |
csharp_ |
we can confirm |
| 15:33 |
terranm |
I was flabbergasted that we've been on 3.6 for a year and nobody reported to us that it wasn't working |
| 15:33 |
JBoyer |
Sometimes the lack of signal is itself a signal. |
| 15:33 |
csharp_ |
it creates a preview A/T event, but I don't see where it actually enters the code to create a non-preview event |
| 15:33 |
mmorgan |
csharp_: I observed the same thing. |
| 15:33 |
abowling |
I dug around on it this afternoon. Per mmorgan's message in launchpad, the error seems to be occurring due to an improperly lengthed array relative to the offset and length values in splice |
| 15:33 |
miker |
I was looking at that this morning, but nothing stood out in a static analysis. does anyone have a log chunk of an attempt they could share? |
| 15:34 |
miker |
I'm going to gather some, but would like more to compare |
| 15:34 |
* mmorgan |
hasn't been successful finding log entries. |
| 15:35 |
mmorgan |
Also, not sure how this factors in, but as terranm noted on the bug, the enhanced email isn't in the angular catalog yet. |
| 15:36 |
miker |
ah! I hadn't seen that new comment, thanks for pointing it out abowling |
| 15:36 |
mmorgan |
The console errors came from the angular catalog. I've seen no such console errors from tpac |
| 15:36 |
abowling |
miker: sure thing. i was also going to attempt to create the error to see what logs might reveal |
| 15:37 |
mmorgan |
abowling++ |
| 15:37 |
JBoyer |
format_biblio_record_entry is doing a lot more with @_ and splice than seems preferable. |
| 15:38 |
miker |
looks like a new-perl issue... |
| 15:38 |
miker |
I'll poke more in a bit |
| 15:38 |
csharp_ |
@blame new perl |
| 15:38 |
pinesol |
csharp_: new perl was monkeying around too much on the prod servers! |
| 15:38 |
csharp_ |
@blame new anything |
| 15:38 |
pinesol |
csharp_: It really IS new anything's fault! |
| 15:38 |
JBoyer |
That would explain why it can be hard to notice, if it hits buster but not stretch and focal but not xenail. |
| 15:39 |
JBoyer |
mmorgan++ |
| 15:39 |
JBoyer |
I can safely say more eyes have been laid upon the bug. :) Sounds like it shouldn't be too far off now. |
| 15:40 |
JBoyer |
Anything more to say about these two bugs or any other new business to raise ? |
| 15:40 |
mmorgan |
Here's hoping! We want to avoid changing the catalog to say your email has NOT been queued for delivery! |
| 15:40 |
csharp_ |
bug 1956626 is causing us some trouble in PINES |
| 15:40 |
pinesol |
Launchpad bug 1956626 in Evergreen "Shelving locations in holdings editor only workstation library" [High,New] https://launchpad.net/bugs/1956626 |
| 15:40 |
JBoyer |
But a template change is so simple! ;p |
| 15:41 |
terranm |
mmorgan: Yeah, we are removing all of those email links in the OPAC for the time being. |
| 15:41 |
csharp_ |
we're upgrading to 3.8 this weekend and the fact that the new volcopy editor doesn't load system-level copy locations means we may need to revert that (or hack the routing back to AngJS) |
| 15:43 |
terranm |
This bug seems to be related to that one as well: https://bugs.launchpad.net/evergreen/+bug/1956627 |
| 15:43 |
pinesol |
Launchpad bug 1956627 in Evergreen "System level workstation displays only consortia owned shelving locations" [Undecided,New] |
| 15:45 |
berick |
csharp_: i'll look at 1956626 |
| 15:45 |
terranm |
berick++ |
| 15:45 |
JBoyer |
berick++ |
| 15:46 |
terranm |
This is another new holding template bug that is causing us grief: https://bugs.launchpad.net/evergreen/+bug/1956790 |
| 15:46 |
pinesol |
Launchpad bug 1956790 in Evergreen "Holding template with item alert breaks save" [High,New] |
| 15:46 |
* JBoyer |
was lost looking for the Angular item editor for a bit. |
| 15:46 |
csharp_ |
berick++ |
| 15:46 |
JBoyer |
And I couldn't find it because this repo had the wrong branch checked out... Works fine in 3.7.2! >_> |
| 15:47 |
terranm |
(Note that we had to install the fix at https://bugs.launchpad.net/evergreen/+bug/1951162 in order for the new holdings editor to work in 3.8 as well.) |
| 15:47 |
pinesol |
Launchpad bug 1951162 in Evergreen "Angular Holdings Maintenance does not successfully retrieve AngularJS item templates" [Critical,Confirmed] |
| 15:47 |
mmorgan |
Ouch! Folks are very attached to their templates. |
| 15:48 |
berick |
that one should prob. be merged. the last few comments are related to what will be a new bug |
| 15:48 |
csharp_ |
mmorgan: yes |
| 15:49 |
terranm |
berick: I wasn't sure if we should go ahead and sign off on it or not because of those other comments |
| 15:49 |
JBoyer |
I'll note that there's no need to stop discussing bugs just because the meeting has ended, anything anyone wants to bring up to get in the minutes and whatnot or should we look at turning meetbot off and whoever can having a short working session? |
| 15:49 |
berick |
terranm: the patch is good to go. i'll open a separate LP for the trailing comments. |
| 15:50 |
terranm |
Okay, I'll mark it signed off |
| 15:51 |
JBoyer |
ok, |
| 15:51 |
JBoyer |
#Announcements |
| 15:51 |
JBoyer |
#info Next meeting is February 8th, 2022 |
| 15:51 |
JBoyer |
#endmeeting |
| 15:51 |
pinesol |
Meeting ended Tue Jan 11 15:51:17 2022 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 15:51 |
pinesol |
Minutes: http://evergreen-ils.org/meetings/evergreen/2022/evergreen.2022-01-11-15.02.html |
| 15:51 |
pinesol |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2022/evergreen.2022-01-11-15.02.txt |
| 15:51 |
pinesol |
Log: http://evergreen-ils.org/meetings/evergreen/2022/evergreen.2022-01-11-15.02.log.html |
| 15:51 |
csharp_ |
JBoyer++ |
| 15:51 |
mmorgan |
JBoyer++ |
| 15:51 |
shulabear |
JBoyer++ |
| 15:51 |
mmorgan |
miker++ |
| 15:51 |
JBoyer |
You don't have to go home, buuut you can stay here, I guess. |
| 15:51 |
mmorgan |
berick++ |
| 15:51 |
collum |
JBoyer++ |
| 15:51 |
abowling |
JBoyer++ |
| 15:51 |
sandbergja |
JBoyer++ |
| 15:51 |
terranm |
JBoyer++ |
| 15:52 |
gmcharlt |
JBoyer++ |
| 15:53 |
mmorgan |
templates are messy :-( |
| 15:53 |
sandbergja |
JBoyer: in case it is helpful to you, bug 1930099 has my notes on an unsuccessful attempt to generate the docs on Windows |
| 15:53 |
pinesol |
Launchpad bug 1930099 in Evergreen "generate_docs.pl should be able to run on Windows" [Medium,Confirmed] https://launchpad.net/bugs/1930099 |
| 15:54 |
JBoyer |
That does sound helpful to at least get me started. sandbergja ++ |
| 16:02 |
JBoyer |
I almost wonder if it would be worth just putting together a PowerShell script or something so you don't even need perl. That would also easily paper over the OS differences, though it does allow for potential drift. |
| 16:02 |
Dyrcona |
mmorgan: Templates don't have to be messy. |
| 16:05 |
* Dyrcona |
gets strange error messages from CStoreEditor while running action triggers, looks like it is blowing up trying to log errors, so I can't tell what the actual error is. |
| 16:05 |
mmorgan |
Dyrcona: True, they don't have to be, but we have users who've dragged theirs from xul, and seems like stuff gets left in them. |
| 16:06 |
Dyrcona |
Only happening on as development vm, though, not in production. |
| 16:11 |
jeff |
(better than the reverse) |
| 16:11 |
jeff |
(but only by a little bit) |
| 16:12 |
abneiman |
oh man, miss one meeting and pinesol makes me convene a whole Synod |
| 16:16 |
mmorgan |
:) |
| 16:32 |
miker |
re print/email records, tl;dr: the angular error in the JS console is sort of a red herring, it's not passing all the params that the opac code does -- but it's easy enough to protect against that error by making sure there are actually enough params to splice like that first. that should fix the staff cat version. |
| 16:34 |
mmorgan |
miker: Fix it in that the email will actually be sent? And not just so that the error doesn't appear? :) |
| 16:39 |
Dyrcona |
jeff: When I switched to a different database where I had not messed with the a/t templates, it's working, so I guess I introduced a bug in the templates, but I don't see it. Also, the error persisted with the previous database even after I tried reverting the template change. |
| 16:48 |
miker |
mmorgan: no, actually. the call being made just creates the email content. there's a second call that /sends/ the email. the new print/email stuff doesn't use the SendEmail reactor, just ProcessTemplate. then a separate code path does $something with the output |
| 16:49 |
miker |
but the email content will at least be created for the staff catalog once that's fixed :) |
| 16:52 |
mmorgan |
miker: Ah. Ok. thanks. progress :) |
| 17:02 |
miker |
mmorgan: I may have lied ... it might just work (for angular) |
| 17:04 |
mmorgan |
miker: Since angular doesn't have enhanced email wired in yet, "just work" ing makes sense! |
| 17:09 |
|
stephengwills left #evergreen |
| 17:14 |
|
mmorgan left #evergreen |
| 17:16 |
* miker |
has mostly refreshed the memory of new email/print ... I can finish up a branch to fix the staff version re your comment on the bug, but the opac sending issue looks like it may be based on local config |
| 17:20 |
miker |
well, the SendEmail reactor uses Email::MIME, but the code backing the opac's email sending is using Email::Simple. I wonder if that's the issue... |
| 17:26 |
miker |
seems unlikely to have recently broken because of that, but I suppose it's possible. the opac email code lacks all the 2019/2020 updates that the reactor got. would be beneficial in any case to have them. I'll look at putting that in the branch as well |
| 17:26 |
miker |
but not tonight! |
| 17:26 |
terranm |
miker++ |
| 18:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
