| 01:05 |
|
Dyrcona joined #evergreen |
| 01:05 |
Dyrcona |
Insomnia is a many splintered thing. |
| 01:06 |
Dyrcona |
@later tell bshum It works. The missing 4 records had no copies. If I don't use the --items option I get the full 8,755 bibs in my test. |
| 01:06 |
pinesol_green |
Dyrcona: The operation succeeded. |
| 01:07 |
Dyrcona |
@later tell bshum It might work for immediate purposes, but I don't like it. I'm going to redesign it as a real module, probably under OpenILS::Utils. |
| 01:07 |
pinesol_green |
Dyrcona: The operation succeeded. |
| 08:37 |
Dyrcona |
kmlussier: Do you need my dev vm today? |
| 08:39 |
kmlussier |
Dyrcona: That's right. You're rebuilding the VM today. To be honest, I'm really busy today. Do you think it will be ready tomorrow? |
| 08:40 |
|
Shae joined #evergreen |
| 08:42 |
Dyrcona |
kmlussier: Not tomorrow. I want to load our production branch for a final migration test. |
| 08:45 |
kmlussier |
Dyrcona: OK, don't worry about it then. I'm good. :) |
| 08:46 |
Dyrcona |
All righty, then.... |
| 08:46 |
Dyrcona |
:) |
| 09:00 |
|
mrpeters joined #evergreen |
| 09:03 |
|
ericar joined #evergreen |
| 09:10 |
|
hopkinsju joined #evergreen |
| 09:14 |
kmlussier |
dbwells: Just as a point of information for bug 1211473. I tested it yesterday and it looked pretty good to me. I was going to add a sign-off to csharp's sign-off, but I ran out of time. |
| 09:14 |
pinesol_green |
Launchpad bug 1211473 in Evergreen "Setting to disable payment by patron credit" (affected: 1, heat: 6) [Wishlist,New] https://launchpad.net/bugs/1211473 - Assigned to Dan Wells (dbw2) |
| 09:15 |
dbwells |
kmlussier: thanks for the verbal sign-off, will push shortly |
| 09:15 |
dbwells |
kmlussier++ |
| 11:41 |
eeevil |
I'll push 2.4.1-2.4.2 into master asap |
| 11:43 |
eeevil |
sorry about that ... fall out of the lingering 2.4.2 release process. |
| 11:44 |
senator |
csharp: how goes it on 1214464 ? |
| 11:44 |
phasefx |
once we get bug 1206531 merged, I'd like to subscribe pinesol_green to http://testing.evergreen-ils.org/~live/ A run from yesterday is here: http://testing.evergreen-ils.org/~live/archive/2013-09-26_17:25:56/test.html |
| 11:44 |
pinesol_green |
Launchpad bug 1206531 in Evergreen "perl-based tests against stock test data on running system" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1206531 |
| 11:44 |
pinesol_green |
[evergreen|Mike Rylander] Push the 2.4.2 inter-version upgrade script forward - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2d7c6d4> |
| 11:45 |
senator |
csharp: just let me know if i can be helpful on that |
| 11:46 |
|
fparks joined #evergreen |
| 11:46 |
csharp |
senator: I got stuck in the weeds of creating a good example of "see also" data - mainly because I'm not actually familiar with the format of authorities data |
| 11:53 |
dbwells |
bug #1214464 already has two signoffs |
| 11:53 |
pinesol_green |
Launchpad bug 1214464 in Evergreen "Bi-directional authority enhanced bib browse" (affected: 1, heat: 8) [Undecided,New] https://launchpad.net/bugs/1214464 |
| 11:53 |
dbwells |
It's just way over my head. |
| 11:54 |
yboston |
concerning 1065378 (UPC added content) I am about to load some bibs to my test branch VM. I may need 30 more minutes tops |
| 11:55 |
dbwells |
I'll probably push it in even without another party giving it a thumbs up, but I'd rather not if someone is still looking at it. |
| 11:55 |
dbwells |
^^ authority enhancements that is |
| 11:55 |
csharp |
dbwells: I'm looking at it right now |
| 11:55 |
kmlussier |
csharp: I sent a sample authority record that may or may not help. It's one I used when testing the original bib browse work. |
| 11:55 |
kmlussier |
That is, I sent it via e-mail. |
| 11:56 |
dbwells |
csharp: ok, thanks, that's what I wanted to know. I know you were poking it earlier. |
| 11:56 |
csharp |
kmlussier: thanks! |
| 11:56 |
* Dyrcona |
goes to lunch, and yes, I'm actually going out of the office for a change. |
| 11:56 |
jeff |
Dyrcona: enjoy! |
| 11:57 |
dbwells |
remingtron is actively attempting to test #1071423, but it's a pretty complex. Anybody have any opinion on that, good or bad? |
| 11:57 |
bshum |
lp 1071423 |
| 11:57 |
pinesol_green |
Launchpad bug 1071423 in Evergreen "Floating should be more flexible than an on/off" (affected: 6, heat: 30) [Wishlist,Confirmed] https://launchpad.net/bugs/1071423 |
| 11:57 |
* bshum |
is lazy |
| 11:57 |
bshum |
Ah |
| 11:59 |
dbwells |
okay, as long as all three branches are being actively tested as we speak, they can go in after noon. Thanks, everybody! Are there any other lonely branches needing last minute attention? |
| 12:00 |
csharp |
posting here for later investigation: 'TypeError: obj.active_services is undefined' alert box appears when entering z39.50 |
| 12:00 |
bshum |
dbwells: Before I hit up ac-by-record-id I'm just sneaking in lp 1231523 for senator |
| 12:00 |
pinesol_green |
Launchpad bug 1231523 in Evergreen "Fix a small floating issue on the OPAC login page" (affected: 1, heat: 6) [Low,New] https://launchpad.net/bugs/1231523 |
| 12:01 |
|
smyers_ joined #evergreen |
| 12:01 |
dbwells |
bshum: bug fixes can always come later, no problem |
| 12:01 |
|
hopkinsju joined #evergreen |
| 12:01 |
phasefx |
dbwells: how about "tests", can they go in later? |
| 12:01 |
kmlussier |
dbwells: I did some limited testing of 1071423 a few weeks ago. What I saw look good, but have to admit my testing wasn't as thorough as I would have liked. |
| 12:02 |
kmlussier |
I agree. It is fairly complext. |
| 12:02 |
* kmlussier |
can't type. |
| 12:03 |
gmcharlt |
actually, that looks like a useful new word -- just need to set on its precise meaning |
| 12:03 |
graced |
heh, I was just about to say the same thing |
| 12:04 |
dbwells |
phasefx: I don't see why not, unless they require some kind of fundamental changes. |
| 12:04 |
phasefx |
dbwells: an extra make target is the riskiest change I can think of (not risky at all) |
| 12:05 |
dbwells |
phasefx: that is, new tests are fine, new test hooks or infrastructure, depends. That's probably just common sense. |
| 12:05 |
phasefx |
dbwells: oh, also maybe a pre-req addition |
| 12:06 |
dbwells |
phasefx: then forget it! ;) |
| 12:06 |
* phasefx |
is thinking about lp 1206531 durn :) |
| 12:06 |
pinesol_green |
Launchpad bug 1206531 in Evergreen "perl-based tests against stock test data on running system" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1206531 |
| 12:07 |
phasefx |
no pre-reqs |
| 12:07 |
phasefx |
an extra-sub in an existing perl module |
| 12:08 |
dbwells |
kmlussier: regarding 1071423, are you fairly confident it at least doesn't break anything? |
| 12:09 |
csharp |
ok |
| 12:09 |
eeevil |
that points at the cooking one |
| 12:10 |
csharp |
gotcha |
| 12:12 |
kmlussier |
dbwells: I was able to do checkouts and checkins. I tested checkins on non-floating items as well as floating ones, and they went to the branch that they were supposed to go. So, in that sense, it didn't break anything. |
| 12:12 |
dbwells |
kmlussier: thank you |
| 12:12 |
kmlussier |
I guess I would say where I lacked thoroughness was in testing more floating use cases. |
| 12:12 |
kmlussier |
I only tested one. |
| 12:13 |
pinesol_green |
[evergreen|Lebbeous Fogle-Weekley] OPAC: on the login page, Make "Questions?"/"FAQs" areas not float weird - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=42e8c33> |
| 12:13 |
kmlussier |
eeevil: What should happen if csharp searched for Cuisine? I just want to make sure I'm understanding the functionality correctly. |
| 12:15 |
eeevil |
kmlussier: sorry, I was digging into something else ... lemme look. |
| 13:21 |
bshum |
+1 to gmcharlt's suggestion to put the OpenSRF stuff up front. |
| 13:21 |
RoganH |
+1 |
| 13:21 |
graced |
+1 |
| 13:22 |
RoganH |
What we could do is do everything in black for all users and then put red or green blinking signs for those who aren't colorblind for "stable" and "test" |
| 13:22 |
RoganH |
Then we will wish we couldn't see them. |
| 13:23 |
* graced |
thinks Rogan misses Geocities |
| 13:23 |
kmlussier |
bshum: So what do you need from us? Direction on layout for the page or would you like somebody to dive in to try reformatting the page? |
| 13:28 |
* csharp |
is sorry to distract :-/ |
| 13:28 |
RoganH |
but he found a bug with the besting where it doesn't see the css added in the header |
| 13:28 |
graced |
csharp++ |
| 13:28 |
RoganH |
so if we make css changes that way (rather than changing the underlying css files) we will need to test manually so to speak |
| 13:28 |
gmcharlt |
csharp: my eyes! |
| 13:29 |
RoganH |
this is so that updates don't break changes we make |
| 13:29 |
RoganH |
that's all |
| 08:43 |
senator |
74035faa65dacc made more problems go away than maybe what bshum knew |
| 08:44 |
senator |
between that and c4e07520d85 i don't see any significant ie issues with the responsive-tpac branch anymore |
| 08:45 |
|
ericar joined #evergreen |
| 08:46 |
dbs |
senator: I think 74035faa65dacc actually fixed the logo / green screen thing on the IE home search too; I was testing my fix locally, pulled the branch, then pushed my fix, before I realized that theory was working just fine without the s/<strong><center>/margin:auto/ change |
| 08:47 |
senator |
ah i guess so |
| 08:47 |
senator |
bshum++ |
| 08:47 |
senator |
dbs++ |
| 08:52 |
senator |
yeah, that was my vague intention for what should happen with semiauto, but i probably never expressed it clearly or prominently |
| 08:53 |
bshum |
senator++ |
| 08:53 |
|
remingtron joined #evergreen |
| 08:55 |
remingtron |
edoceo: do you still host an EG test server? I'm wondering if it will be available during the upcoming DIG hackaway in Nov. |
| 08:56 |
bshum |
remingtron: I had some plans to setup a test server for DIG use as well. |
| 08:56 |
dbs |
bshum: if you check the git history, you'll see that I chipped away at it for a while |
| 08:56 |
dbs |
eventually a squirrel ran by and I got distracted... |
| 08:56 |
bshum |
But it'd be good to know what edoceo is doing with his server. |
| 08:59 |
bshum |
Heh, sure thing remingtron |
| 09:00 |
remingtron |
bshum++ |
| 09:00 |
remingtron |
gracias |
| 09:02 |
bshum |
remingtron: As a minor detail, what version should I aim to put on the test server? (would have normally put master, but just remembered that's not always appropriate) |
| 09:02 |
remingtron |
that's a good question for yboston, whenever he comes on |
| 09:02 |
bshum |
Sounds good, I'll make sure to ask. |
| 09:03 |
remingtron |
I imagine DIG will want something from 2.5 (master might be fine), and latest 2.4? |
| 10:07 |
Dyrcona |
Now, I have to spend an hour manipulating a spreadsheet that matches parts on incoming records with existing parts in our system. |
| 10:07 |
* Dyrcona |
poofs out. |
| 10:09 |
senator |
ubuntu's lts cycle... it helps keep me in a state of always wondering where the last two years have gone |
| 10:16 |
csharp |
Dyrcona: I'll be willing to test 14.04 too |
| 10:16 |
csharp |
senator: yep ;-) |
| 10:19 |
|
RoganH joined #evergreen |
| 10:32 |
|
mllewellyn joined #evergreen |
| 10:38 |
senator |
bshum: 6b1290c10ef3 for not showing the search bar on my acccount pages... |
| 10:59 |
|
ericar joined #evergreen |
| 11:01 |
csharp |
3eb616e56c82a5106e14f5a446f1d875015db7f0 |
| 11:01 |
pinesol_green |
[evergreen|Lebbeous Fogle-Weekley] Inter-authority linking - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3eb616e> |
| 11:09 |
csharp |
senator: dbwells: I've installed the code for bug 1214464 and have reingested auths and bibs... I'm wondering what the best way to proceed in testing is |
| 11:09 |
pinesol_green |
Launchpad bug 1214464 in Evergreen "Bi-directional authority enhanced bib browse" (affected: 1, heat: 8) [Undecided,New] https://launchpad.net/bugs/1214464 |
| 11:10 |
jcamins |
Ooh, that sounds really cool! |
| 11:11 |
dbwells |
jcamins: Any chance you could test and sign off? |
| 11:11 |
senator |
csharp: right, thanks for bringing that up again |
| 11:11 |
jcamins |
dbwells: sadly I can't even coerce my Evergreen VM into starting anymore. |
| 11:11 |
senator |
i need to better explain what it's supposed to do |
| 11:12 |
csharp |
just still trying to bust through the beta blockers (though if I'm not the best person to test/sign-off, I won't get my feelings hurt ;-)) |
| 11:12 |
dbwells |
jcamins: too bad! |
| 11:14 |
senator |
csharp: not at all, it's on me to explain what the expectations are for that |
| 11:14 |
eeevil |
csharp: I'll try to explain 1214464 ... I can be blamed for most of that |
| 11:29 |
csharp |
eeevil++ |
| 11:29 |
csharp |
senator++ |
| 11:29 |
eeevil |
(also, get inter-authority update, like authority change propagation for bib data today ... yet another project) |
| 11:32 |
csharp |
ok, well from the "I added the code and poked and nothing looks broken" perspective, I've tested |
| 11:32 |
csharp |
I guess the best way to test is to import some Bachman/King records and see that they work? |
| 11:32 |
csharp |
(or something similar) |
| 11:33 |
eeevil |
csharp: you'll have to add the appropriate $0 to each, and make bibs use them ... but yes, that would be a good test |
| 11:36 |
* csharp |
chuckles at his lack of hands on cataloging knowledge |
| 11:36 |
yboston |
csharp: let me know if you want some help with what to look in your testing, I have used authorities in EG before |
| 11:36 |
yboston |
csharp: I can dig up bibs with related auths, etc |
| 11:37 |
csharp |
yboston: that would be great, actually |
| 11:37 |
csharp |
I guess I can also just export from PINES prod and import too |
| 11:38 |
yboston |
csharp: I am at your service, by chat, email, or phone. BTW, I assume this test VM is not available on the outside |
| 11:38 |
csharp |
yboston: thank you! - yeah, it's behind a firewall atm |
| 11:38 |
csharp |
or NAT rather |
| 11:40 |
|
acoomes joined #evergreen |
| 11:44 |
|
kbutler joined #evergreen |
| 11:47 |
|
jbfink joined #evergreen |
| 11:49 |
yboston |
apropos of nothing, it might be too late for 2.5 but there is a branch that is a favorite of mine that was worked on during the dev hack-a-way that could a sign off. I will test it today and sign it off, but my sign off does not carry that much weight LP 1065378 |
| 11:49 |
pinesol_green |
Launchpad bug 1065378 in Evergreen "Added content by record ID" (affected: 2, heat: 16) [Wishlist,In progress] https://launchpad.net/bugs/1065378 - Assigned to Jeff Godin (jgodin) |
| 11:49 |
yboston |
4408bff9b3cb2740b60b69b1ec2c1bf61691f1dc |
| 11:53 |
remingtron |
yboston: since the 2.5 timeline has changed a little, I think you have time still to get it into beta |
| 11:53 |
senator |
yboston: i'm not sure your signoff is any lighter than anyone else's. you're an active participant in the community who can be counted on to test carefully |
| 11:53 |
yboston |
suckers |
| 11:53 |
jeff |
yboston++ |
| 11:53 |
kmlussier |
yboston++ |
| 11:56 |
csharp |
bshum++ |
| 11:56 |
bshum |
senator: And yeah, sorry about my slipshod commit messages. In retrospect I need to be better about writing more extensive commit messages even when I think I'll have time to clean them up later. |
| 11:56 |
bshum |
It's just bad habit on my part that I expect to do better in the future. |
| 11:57 |
yboston |
bshum: wow that is great to know, I had lost track of who had used his code. I will still set up a test Vm for the practice after lunch |
| 11:57 |
yboston |
bshum++ |
| 11:57 |
|
jdouma joined #evergreen |
| 11:57 |
dbwells |
yboston: at this point we are certainly to the "when in doubt, leave it out" stage of 2.5, but the fact that that branch is mature and in production at multiple sites certainly tips the scales toward including it if someone takes it up. |
| 11:58 |
yboston |
dbwells: good to know. |
| 12:01 |
bshum |
So I'll probably ask him to weigh in on those before we do anything |
| 12:01 |
senator |
bshum: ah no worries, i wouldn't have called it slipshod at all, i just missed a subtlety at fist |
| 12:01 |
senator |
*first |
| 12:01 |
bshum |
But for the rest of it, the ISSN thing was the only thing I still need to test for it. The rest is fine. |
| 12:01 |
* bshum |
pokes jeff :) |
| 12:02 |
|
smyers_ joined #evergreen |
| 12:44 |
|
stevenyvr2 joined #evergreen |
| 13:39 |
|
jbfink joined #evergreen |
| 14:07 |
pinesol_green |
rfrasur: The operation succeeded. |
| 14:17 |
csharp |
may have stumbled on a bug in vandelay when attempting import of authority records: http://pastebin.com/k5zcKMCN |
| 14:20 |
yboston |
csharp: are you running master? |
| 14:21 |
Dyrcona |
That's his test server, I'll bet. |
| 14:21 |
yboston |
edoceo: thanks for once again offering to help DIG with a test server. Last year you were ready to help us, but we were not. we ended up at reviewing old docs instead of writing new docs |
| 14:22 |
csharp |
yep - master as of today |
| 14:22 |
csharp |
plus eeevil's auth browse improvements |
| 14:22 |
Dyrcona |
csharp: That's not production, though, is it? |
| 14:22 |
csharp |
nope |
| 14:22 |
csharp |
test server |
| 14:23 |
Dyrcona |
Just looking at the error, but not at the source, it could probably be fixed in fm_IDL.xml. |
| 14:23 |
yboston |
csharp: I can try to build a master server tomorrow to see if I can reporuce the error |
| 14:24 |
Dyrcona |
Looks like the classes with ids vqar and vam should have a link but one or both of them lack the IDL entry. |
| 14:24 |
yboston |
or test any fixes |
| 14:26 |
Dyrcona |
vqar has link to vam, but nothing the other way 'round. |
| 14:27 |
yboston |
Note to remingtron , bshum , edoceo: Since the DIG hack-a-way will be in NOvember, I would wait for 2.5 to be released so that we can document off of that version. though that is only my opinion, I am open to other thoughts |
| 14:28 |
|
misilot joined #evergreen |
| 19:58 |
pinesol_green |
[evergreen|Dan Wells] TPAC: Consolidate and simplify button styles - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=798a4ff> |
| 19:59 |
* Dyrcona |
does a happy dance. |
| 20:09 |
* bshum |
wonders whether to join Dyrcona? |
| 20:19 |
pinesol_green |
[evergreen|Steven Callender] Added in warning message when placing hold with no email address. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6707d53> |
| 20:30 |
|
jbfink joined #evergreen |
| 20:35 |
|
stevenyvr2 left #evergreen |
| 20:39 |
pinesol_green |
[evergreen|Bill Erickson] Fiction records / copies test data - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=954bb31> |
| 20:41 |
pinesol_green |
[evergreen|Lebbeous Fogle-Weekley] Better handling of purchase_order being non-numeric - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3282cbb> |
| 20:43 |
pinesol_green |
[evergreen|Pasi Kallinen] Fix delete items confirmation typo. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=addfe15> |
| 20:49 |
pinesol_green |
[evergreen|Jason Stephenson] Add PhoneList.pm. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6785a4a> |
| 20:49 |
pinesol_green |
[evergreen|Jason Stephenson] Strip out spaces as well as - from phone numbers in PhoneList::Holds. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3448c22> |
| 20:49 |
pinesol_green |
[evergreen|Jason Stephenson] Fix PhoneList.pm child_init method. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e4e39e6> |
| 20:49 |
pinesol_green |
[evergreen|Jason Stephenson] Add phonelist.txt release notes. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=6566aa8> |
| 20:49 |
pinesol_green |
[evergreen|Lebbeous Fogle-Weekley] Add PhoneList.pm stuff to Apache 2.4 config - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=48a44af> |
| 21:24 |
* jeff |
attempts to rebase ac_by_record_id |
| 21:29 |
bshum |
jeff: Let me know if I can help with any of that. |
| 21:36 |
jeff |
bshum: summary.tt2 changed just a LITTLE bit. ;-) |
| 21:36 |
bshum |
Hehe |
| 21:49 |
pinesol_green |
[evergreen|Pasi Kallinen] In reports, show old label name as the default in the Alter Display Header -prompt - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1db3c91> |
| 21:56 |
|
shadowspar joined #evergreen |
| 21:56 |
jeff |
bshum: eyes appreciated on user/jeff/ac_by_record_id_2013_rebase |
| 21:57 |
jeff |
bshum: i'm about to test to ensure that all's still well with responsive stuff in play |
| 21:57 |
jeff |
bshum: then, release notes and perhaps you and/or yboston can sign off |
| 22:15 |
bshum |
jeff: Sounds like a plan. I have to get a nicer test server going for things as well. |
| 22:15 |
bshum |
I'll hit that up early tomorrow. |
| 22:16 |
jeff |
https://eg.dev.tadl.org/ has master + ac by record id. concerto plus some transcendant bibs from yboston |
| 22:16 |
jeff |
"disc" is a good query to get music jackets |
| 22:17 |
bshum |
Looks reasonable. |
| 09:50 |
dbs |
f6fbea5a4a1cab03e was the relevant commit, but need to fix initial tab too |
| 09:54 |
dbs |
bshum: pushed a commit to fix that |
| 09:54 |
bshum |
dbs++ |
| 09:55 |
* csharp |
will throw the mobile OPAC code on a 2.5-ish test server later this week for "production" testing |
| 09:55 |
Dyrcona |
It looks good on my Galaxy S4. |
| 09:55 |
csharp |
I'll test some today if I get a chance on a vanilla master server, but today is meeting-ful |
| 09:55 |
csharp |
theory looks great on my Note 2 |
| 09:56 |
bshum |
dbs: Works for theory |
| 09:56 |
csharp |
I got to brag on y'all to my bosses ;-) |
| 09:57 |
dbs |
There are some inconsistencies with Submit button ("Search") vs. Clear Form that we fought with before that raised their heads again last night. Still not pretty. |
| 11:43 |
senator |
well of course, and everyone's doing a great job, and this is an unusually strong, collaborative effort |
| 11:43 |
senator |
i'm not trying to put the brakes on anything here |
| 11:44 |
dbs |
I've got to go get lunch. With the possible exception of experimenting with <button> instead of <a> for .opac-buttons, I think I'm done for a while. |
| 11:44 |
* csharp |
refreshes his dev server to test the mobile OPAC |
| 11:45 |
dbs |
There's a lot more to be done, but it has come a long way. |
| 11:45 |
senator |
but i think our meaningful review/sign-off practices are worth maintaining |
| 11:45 |
dbs |
csharp: collab/dbs/responsive-tpac is the latest, rebased on current master |
| 11:51 |
csharp |
heh |
| 11:51 |
bshum |
senator: I don't really feel like we should review the mobile work in pieces. Lots of what happened was done with the entire experience in mind and I've been finding it hard to say this is exclusively only benefiting one or the other. |
| 11:52 |
csharp |
okay, as a tester, are there places I should poke especially hard? |
| 11:52 |
bshum |
Even with the font-size stuff, that helps in the main catalog, but it impacted significantly how the mobile view worked as well with regards to how much finnessing we needed to deal with. |
| 11:53 |
bshum |
csharp: The big thing I focused on with testing was ensuring that the original functionality was as close as possible. Especially with regards to the login page, my account areas, advanced search, and results view. |
| 11:53 |
bshum |
Those were the four big areas of change I think. |
| 11:53 |
csharp |
okey dokey |
| 11:53 |
bshum |
Oh, the searchbar. |
| 11:54 |
bshum |
The biggest difference visually is the login page I think |
| 12:58 |
ElliotFriend |
agreed. I'm thinking it is more a policy problem than evergreen problem. |
| 12:58 |
csharp |
definitely ;-) |
| 12:59 |
ElliotFriend |
i've not tried checking in non-checked-out items yet, what happens then? |
| 13:00 |
csharp |
ElliotFriend: from my quick test, it puts the item into Reshelving status |
| 13:00 |
dbs |
dbwells++ # overflow:auto does the trick |
| 13:01 |
* csharp |
has supported EG for 5+ years but has never used it day-to-day ;-) |
| 13:01 |
* rfrasur |
uses EG daily and loves it like a child. |
| 15:46 |
bshum |
senator: So dbs and I discovered with tsbere's help that the compatibility mode was screwing with the mobile branch horrifically |
| 15:46 |
bshum |
We added a meta tag to force it off |
| 15:47 |
bshum |
When we turned it off, it looked much better with IE10 for me at least |
| 15:47 |
senator |
and all looks pretty good now? i'm only in a position to test with 8, i think, right now |
| 15:47 |
bshum |
I think he tested IE8 and it was fine |
| 15:47 |
bshum |
senator: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=68d50f2678eb6c558623bfd2c764bc51ec789d5f |
| 15:47 |
bshum |
That's the commit dbs put for the meta tag |
| 15:48 |
senator |
thanks |
| 15:48 |
bshum |
If you toss that on your test system or use theory.biblio.org with IE8 to test; that'd be great. |
| 15:48 |
dbwells |
I am on IE9. It's functional, but with quite a few display regressions. |
| 15:48 |
bshum |
I only have IE10 to test with |
| 15:52 |
jeff |
free IE test VMs here: http://www.modern.ie/virtualization-tools |
| 15:53 |
dbwells |
I can verify that IE10 displays much better than IE9. |
| 15:53 |
jeff |
or http://www.modern.ie/en-us/virtualization-tools#downloads for a barely-more-direct link |
| 15:54 |
kmlussier |
Ugh! Git problems trying to push to dbs' branch. |
| 16:01 |
jeff |
Oh hey. I just realized. The concept of Standards Override Bodies already exists. We call them Vendors, right? |
| 16:02 |
jeff |
(I come to this realization as we are essentially negotiating a likely non-standard NCIP extension with someone else's vendor indirectly via IM and email) |
| 16:05 |
* bshum |
takes his hands off the repo (took a few moments to rebase on top of kmlussier's stuff) |
| 16:08 |
* senator |
tests ie, listens to that silly clicking sound a lot |
| 16:10 |
* dbwells |
imagines the bug report which started that "The instructions said to click the link. I kept pressing the mouse button, but never got any clicking..." |
| 16:10 |
senator |
generally looks good, only noticing two glitches myself so far: green swatch on the right side of the basic search page, and also on the search results page (but not the record detail page). on the search results page, the white background basically ends at the right edge of the initially visible area (the area visible without horizontal scrolling). to the right of that is only green, and long |
| 16:10 |
senator |
titlescut off there instead of wrapping |
| 12:48 |
dbs |
error was at auth_concerto.sql:76 |
| 12:48 |
senator |
jeff: hmm, i think setting pos in URLVerify.pm was just cargo cult |
| 12:49 |
jeff |
senator: your self-awareness and honesty are appreciated. thanks! :-) |
| 12:49 |
senator |
it looks to me, too, like nothing actually cares about the position of cbrebi rows. i guess they don't really have an intrinsic order |
| 12:49 |
senator |
no prob. i would want to test that the link checker still works after any patch that loses that field, just to be on the safe side, of course |
| 12:50 |
jeff |
i'm not proposing losing the field, just doing some recon as i consider adding a "sort by date added to bucket" feature somewhere |
| 12:51 |
senator |
ah |
| 12:56 |
dbs |
Fails on the second auth_concerto record, which is the first to contain unicode XML char entities |
| 16:35 |
Bmagic |
so, fine_generator knows not to create those rows.... my question is which table is it using to decide weather or not to generate inserts into money.billing |
| 16:35 |
jeff |
Bmagic: i think Dyrcona's advice is going to be most useful for you -- you may find that you need to clear the stop_fines and stop_fines_reason for the circulations in question. |
| 16:35 |
Dyrcona |
Bmagic: action.circulation |
| 16:35 |
jeff |
Bmagic: but please consider doing this on a test copy of the database -- it would make me feel much better. :-) |
| 16:36 |
Bmagic |
do you mean the action.circulation - stop_fines (text) stop_fines_time ? |
| 16:36 |
Dyrcona |
yep. |
| 16:37 |
jeff |
Bmagic: yes. sorry, i stated their names incorrectly. :-) |
| 16:42 |
jeff |
most/all of those are set at checkout time. changing the policy/matchpoints in the staff client will not affect existing checkouts. |
| 16:42 |
Bmagic |
I see, would it be cleaner to wipe the rows and import from csv again? |
| 16:43 |
Dyrcona |
Bmagic: maybe. how many rows are you talking about? |
| 16:43 |
jeff |
Bmagic: depends on how you originally imported things. possibly. experimentation on a test copy may be required to answer that question -- lots of variables involved that are only specific to your situation. |
| 16:43 |
Bmagic |
less than 1k |
| 16:44 |
Bmagic |
stop_fines needs to be blank for fine_generator to go again? |
| 16:44 |
Bmagic |
My test set shows "MAXFINES" |
| 16:44 |
jeff |
i'm torn between the trouble of disabling triggers and deleting the rows from action.circulation vs just fixing things in place. i'd almost lean toward fixing in place for that smaller number. |
| 16:44 |
Dyrcona |
both stop_fines and stop_fines_time should be null. |
| 16:45 |
Bmagic |
GOTCHA |
| 16:45 |
* Dyrcona |
leans toward agreeing with jeff. :) |
| 16:45 |
jeff |
ideally you'd have a test copy where this issue was discovered, and could just re-do everything from a pristine copy, but ideals are elusive. |
| 16:45 |
Bmagic |
yeah - the deal is, there have been 3 weeks of live updates to the db since the migration |
| 16:45 |
jeff |
we had lots of "not apparent until in production" post-migration cleanup. :-) |
| 16:46 |
jeff |
(and there are several present who may declare that a huge understatement) |
| 08:59 |
phasefx |
circ.holds.hold_has_copy_at.alert ? |
| 09:00 |
phasefx |
and circ.holds.hold_has_copy_at.block |
| 09:01 |
phasefx |
not quite the same |
| 09:02 |
mmorgan |
mrpeters: Just tested this on our 2.3.7 system. |
| 09:02 |
DPearl |
Is the hackaway in the same library room today? |
| 09:02 |
mmorgan |
Attempted to place a hold on a bib for a patron who had a copy checked out and it was unsuccessful. Problem HOLD_ITEM_ALREADY_CHECKED_OUT with the option to override. |
| 09:03 |
dbs |
bshum: yeesh, the 800px -> 850px has a very bad smell attached to it (the whole px-width thing); why not just put all of the select boxes on a single "line" and let them wrap to the appropriate width? |
| 10:43 |
dbs |
In which case we could add a label + a border to group them, no matter how they break |
| 10:44 |
paxed |
legend? |
| 10:44 |
dbs |
legend-ary! |
| 10:45 |
* rfrasur |
opens "Evergreen 2.4 Testing Documents" with fear and trepidation. |
| 10:45 |
dbs |
Sorry. What I said was, with the current approach, we can remove the special <600px MOPAC CSS |
| 10:45 |
paxed |
koha seems to use legends all over the place. |
| 10:46 |
dbs |
because it's truly responsive, to whatever size of screen you have. |
| 13:33 |
jeff |
and now it's up. |
| 13:33 |
jeff |
> key can be any one of ISBN, OCLC, LCCN, OLID and ID (case-insensitive) |
| 13:47 |
dbs |
Learning point: design for mobile first! |
| 13:51 |
phasefx |
design for testing first, too, but at least one test tool makes use of accessiblity libraries for working the UI, so you can do both |
| 13:52 |
jeff |
man. i thought isbns were messy. lccns and oclc nums are almost worse. |
| 13:54 |
eeevil |
how upgrade-safe are the changes that have been made thus far? |
| 13:54 |
rfrasur |
thanks bshum |
| 13:58 |
pinesol_green |
Launchpad bug 1221411 in Evergreen "Translating the basic search bar is troublesome" (affected: 1, heat: 6) [Undecided,New] https://launchpad.net/bugs/1221411 |
| 13:58 |
dbs |
That's kind of the whole point of a responsive design: it's one design. |
| 13:58 |
rfrasur |
is this referring to font size? sorry...audio is a little hit or miss |
| 13:59 |
dbs |
We were evaluating them on their own merits. And even tested with IE (up to this morning, anyway) |
| 13:59 |
dbs |
rfrasur: all of the changes |
| 13:59 |
rfrasur |
oh...sorry...I meant the 12/14 conversation |
| 13:59 |
|
bott_otr joined #evergreen |
| 14:00 |
dbs |
paxed: nope |
| 15:00 |
eeevil |
array in hand, use foreach; iterator pattern, use while |
| 15:01 |
eeevil |
Dyrcona: also, switching to while means you can use the variable directly, no need to deref and re-ref |
| 15:01 |
eeevil |
also, \@data will be faster (and less memory hungry) than [@data] ... though that may be a micro-optimization in your use case |
| 15:02 |
Dyrcona |
eevil: I'll give it a try, though testing with ten records it won't be noticeable. |
| 15:02 |
Dyrcona |
eeevil ^ |
| 15:02 |
eeevil |
indeed it wont |
| 15:02 |
eeevil |
but, while++ |
| 11:00 |
* dbs |
notes that AngularJS is a framework largely built by Google |
| 11:01 |
paxed |
i'm not convinced upgrading to newer xulrunner will help in the long run. |
| 11:01 |
eeevil |
dbs: and dojo is heavily supported by IBM ... /me attempts to tug at dbs' heartstrings |
| 11:01 |
dbs |
paxed: testing required for _any_ approach, obviously |
| 11:01 |
paxed |
dbs: yeap |
| 11:01 |
dbs |
eeevil: great reason to go angular :) |
| 11:02 |
jeff |
i think what's being discussed is abandoning xul, then xulrunner, but at some point along the way we may support newer xulrunner before exiting it completely. |
| 11:03 |
phasefx |
autohotkey |
| 11:03 |
paxed |
if i get the chance i'll try to pinpoint the xulrunner bug (as i think it is a xulrunner one) that causes the js not get the locale |
| 11:03 |
eeevil |
constrictor is coming back ... VM coming soon |
| 11:03 |
phasefx |
very difficult to use as a general testing framework, but possible |
| 11:04 |
jeff |
i'm inclined to forget testing the xulrunner staff client, and focus on testing and instrumenting the new web-based experiment. |
| 11:04 |
dbs |
jeff++ # thus selenium |
| 11:04 |
Dyrcona |
+elebenty!! |
| 11:05 |
bott_otr |
AngularJS example: function BeerCounter () on homepage. What more do you need? |
| 11:05 |
* phasefx |
thinks selenium would be great for testing web-based stuff.. horrified at the notion of putting selenium into xulrunner, if anyone is thinking of that |
| 11:06 |
|
Dyrcona1 joined #evergreen |
| 11:06 |
jeff |
phasefx: too bad. we're hacking on putting selenium into xulrunner RIGHT NOW. |
| 11:06 |
jeff |
(no, we're not) |
| 11:07 |
jeffdavis |
kmlussier++ |
| 11:08 |
eeevil |
(see: wai-aria in tpac) |
| 11:08 |
dbs |
eeevil: yep |
| 11:11 |
jeff |
i am amused at the idea of testing a receipt printer shim by printing a few hundred receipts to a bank of printers |
| 11:12 |
* dbs |
is torn between mobile catalogue and marc export |
| 11:13 |
dbs |
marque export, to be more canadian |
| 11:14 |
rfrasur |
nice |
| 11:18 |
|
acoomes joined #evergreen |
| 11:19 |
bshum |
maybe tomorrow, we can get phasefx on the big screen to do a rundown of QA stuff :) |
| 11:19 |
bshum |
(or others) |
| 11:19 |
dbs |
dojo and angular, fwiw, each have fairly well-integrated or closely associated test frameworks (Dojo = DOH, or at least used to be; Angular = Jasmine and Karma) |
| 11:20 |
* dbs |
half-raises a hand for mopac |
| 11:20 |
* dbs |
half-raises a hand for marc export |
| 11:21 |
jeffdavis |
Dyrcona: Sitka has some MARC export tools here - http://git.sitka.bclibraries.ca/gitweb/?p=sitka/sitka-tools.git;a=tree |
| 11:21 |
jeffdavis |
I didn't write that stuff and won't be in that hackaway session, but pointing it out in case it's of interest |
| 11:21 |
* rfrasur |
would like to hang out in the mopac |
| 11:28 |
dbs |
I'll poke Dyrcona later on today to hopefully kick export ideas around :) |
| 11:28 |
bott_otr |
mobile catalog thought, via dbs: http://bit.ly/18v26yf |
| 11:29 |
|
bott_otr1 joined #evergreen |
| 11:29 |
dbs |
I think my test server links are dead or at least no longer have that test CSS applied :/ |
| 11:30 |
dbs |
but I could probably get it back into shape |
| 11:31 |
bott_otr1 |
I'm pretty sure I burnt my VM with that work as well |
| 11:31 |
|
remingtron joined #evergreen |
| 11:31 |
eeevil |
bibtemplate! |
| 13:38 |
|
mrpeters joined #evergreen |
| 13:38 |
berick |
@quote add < Rogan_Ni> Star Wars |
| 13:38 |
pinesol_green |
berick: The operation succeeded. Quote #67 added. |
| 13:39 |
berick |
eeevil: ahh, no, i wish |
| 13:39 |
berick |
eeevil: just a slim set of fieldmapper stuff and some other test code |
| 13:40 |
eeevil |
ah. cool. so some custom module rewrapping |
| 13:40 |
tsbere |
Apparently hangouts doesn't like being logged in and active when the play store decides to auto-update it in the background. Go figure. |
| 13:42 |
eeevil |
senator: does your group have a hangout too? |
| 13:44 |
jboyer-home |
} |
| 13:44 |
senator |
eeevil: negative |
| 13:44 |
jboyer-home |
</style> |
| 13:45 |
senator |
we're working on serials, but are less focused than the other groups, participating also in mobile opac discussion and bug testing/merging for now |
| 13:45 |
berick |
eeevil: re, dojo, sort of. for the code I'm using, i had to do surprisingly little |
| 13:45 |
senator |
might lack enough cams |
| 13:45 |
berick |
i'm loading opensrf js directly (via script) and it all works find |
| 13:47 |
berick |
eeevil: i'd like to. my only concern is getting websockets running on the server side is non-trivial at this stage |
| 13:47 |
eeevil |
ah |
| 13:47 |
senator |
Dyrcona: your group seems real serious over there. can you ping me when you've got a second where you wouldn't mind an interruption? |
| 13:47 |
berick |
so it would limit who could test it.. |
| 13:48 |
rfrasur |
is the audio I'm hearing with regard to responsiveness the staff client discussion? or mopac? |
| 13:48 |
* dbs |
assumes Dyrcona is in a group of one :) |
| 13:48 |
phasefx |
rfrasur: I see you in the staff client one, fwiw |
| 11:13 |
pinesol_green |
Dyrcona: The operation succeeded. Dyrcona hates their/there. |
| 11:13 |
bshum |
For LDAP goodness |
| 11:13 |
Dyrcona |
@hate English orthography |
| 11:13 |
pinesol_green |
Dyrcona: The operation succeeded. Dyrcona hates English orthography. |
| 11:14 |
pinesol_green |
[opensrf|Galen Charlton] LP#1224647: remove two invalid tests - <http://git.evergreen-ils.org/?p=OpenSRF.git;a=commit;h=9028b02> |
| 11:14 |
dbs |
there there, dyrcona, it'll be okay |
| 11:15 |
dbs |
their they're, Dyrcona. |
| 11:15 |
Dyrcona |
yeah... |
| 12:03 |
gmcharlt |
... which reminds me of the ongoing discussions in Koha-land about the LiveDVD |
| 12:03 |
jbfink |
dbs: yeah, me too, and crouton solves the rest with lubuntu in a chroot. well, not the *rest*, but 98%, and that 2% is things I can't solve due to the chromebook kernel not supporting things. |
| 12:04 |
jbfink |
dbs: Yeah, zero idea about production, but since I'm wrapping *everything* in a container -- including the DB and all that -- I can see it getting too large to be usable. But this is all just me farting around. We're not even running EG here or anything. |
| 12:04 |
gmcharlt |
as it's challenging to communicate to folks who've set up a test system using one that it's not the ideal way to set up a production system |
| 12:04 |
dbs |
gmcharlt: GIVE US THE CREDIT FOR THE LIVEDVD K THX |
| 12:04 |
gmcharlt |
dbs: and yeah, there's that :) |
| 12:06 |
* rfrasur |
pops in and sees a pertinent discussion and now must scroll back. |
| 12:08 |
jcamins |
jbfink: if you need it to exit when the children exit so that docker can clean up, you could also just use wait, since everything has a pidfile. |
| 12:08 |
jcamins |
Kind of late to the party, though, sorry. |
| 12:11 |
jcamins |
gmcharlt: I feel like it's easier to explain with something like docker than with a livedvd because docker is explicitly developer-oriented, whereas the livedvd is more "this is how you install Koha on your computer." |
| 12:12 |
gmcharlt |
jcamins: really? From their home page... "The same container that a developer builds and tests on a laptop can run at scale, in production" |
| 12:13 |
gmcharlt |
of course, as I know nothing of docker, it may well be that it's perfectly plausible (with enough effort) to use it for a production setup |
| 12:13 |
jcamins |
gmcharlt: "Please note ... it should not be used in production." |
| 12:13 |
jcamins |
(from "Learn more") |
| 12:13 |
gmcharlt |
jcamins: mayhap they're trying to have their cake and eat it too? both statements are on their website, and are on the face of it contradictory |
| 13:00 |
* bshum |
sneaks in some lunch first. |
| 13:02 |
dbs |
bshum: direct database updates methinks :) |
| 13:02 |
bshum |
Could be lots of those too. We do like our direct SQL updates too :) |
| 13:04 |
dbs |
eeevil: I think the idea is that the dockerized version will be created from latest OpenSRF/Evergreen master + underlying distro packages on demand, so always up-to-date, vs static VMs |
| 13:05 |
dbs |
ergo good for testing perhaps |
| 13:07 |
eeevil |
dbs: ah ... I figured installation into a doc would still have to be done by hand ... if it can be automated, super! (see: wheezy installer wanting to be merged :) ) |
| 13:10 |
|
dMiller_ joined #evergreen |
| 13:13 |
dbs |
jbfink can correct me if I'm wrong, of course |
| 12:46 |
tony_ |
paxed_ "thru" |
| 12:46 |
dbs |
tony_: still need more of the failure log |
| 12:47 |
tony_ |
_dbs okay hang-on let me pull the logs |
| 12:47 |
dbs |
tony_: well, even just the last 10 lines that were printed to the screen |
| 12:47 |
dbs |
eeevil++ # that looks better. now to give it a shot on our test server... |
| 12:48 |
eeevil |
dbs: thanks, man! |
| 12:52 |
tony_ |
dbs_ Sep 11 18:10:22 finish-install: info: Running /usr/lib/finish-install.d/07brltty Sep 11 18:10:22 finish-install: cat: read error: Is a directory Sep 11 18:10:22 finish-install: sh: you need to specify whom to kill Sep 11 18:10:22 finish-install: info: Running /usr/lib/finish-install.d/07preseed Sep 11 18:10:22 finish-install: info: Running /usr/lib/finish-install.d/07speakup Sep 11 18:10:22 finish-install: info: Running /usr/l |
| 12:53 |
tony_ |
dbs_ Sep 11 18:10:22 finish-install: Disabling CD in sources.list Sep 11 18:10:22 finish-install: info: Running /usr/lib/finish-install.d/10clock-setup Sep 11 18:10:22 anna-install: Installing os-prober-udeb Sep 11 18:10:22 os-prober: File descriptor 3 (pipe:[1247]) leaked on lvs invocation. Parent PID 28714: log-output Sep 11 18:10:22 os-prober: File descriptor 4 (/dev/pts/0) leaked on lvs invocation. Parent PID 28714: log-output |
| 13:11 |
tony_ |
dbs what parts of this log do you want... |
| 13:11 |
tony_ |
dbs can't believe how many times I looked at this file and just couldn't see it |
| 13:13 |
eeevil |
dbs: wheeee.... I'll toss it on LP |
| 13:13 |
tony_ |
dbs here you go: ## ----------- ## ## Core tests. ## ## ----------- ## configure:2342: checking for a BSD-compatible install configure:2410: result: /usr/bin/install -c configure:2421: checking whether build environment is sane configure:2471: result: yes configure:2612: checking for a thread-safe mkdir -p configure:2651: result: /bin/mkdir -p configure:2664: checking for gawk configure:2694: result: no configure:2664: checking fo |
| 13:14 |
tony_ |
configure:2680: found /usr/bin/mawk configure:2691: result: mawk configure:2702: checking whether make sets $(MAKE) configure:2724: result: yes configure:2842: checking build system type configure:2853: error: /bin/bash ./config.sub ./configure failed |
| 13:14 |
dbs |
tony_: when you run ./configure --whatever, just the last screen or two of whatever gets printed to the screen. And ideally paste to http://pastebin.ca or the like |
| 13:18 |
tony_ |
dbs did that work for you |
| 13:21 |
eeevil |
dbs: separately, we should probably move the mrd join up to immediately after the core table |
| 16:14 |
|
AnoopGatewayChec left #evergreen |
| 16:35 |
pinesol_green |
[evergreen|Pasi Kallinen] Allow translation of acq.cancel_reason texts. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=777798d> |
| 16:43 |
pinesol_green |
[evergreen|Bill Erickson] LP#856688 OUS to disable org unit as hold pickup lib - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=33206c4> |
| 17:01 |
bshum |
dbwells++ # got the LDAP test script to authenticate with the right credentials. Very handy, thank you sir! |
| 17:10 |
|
mmorgan left #evergreen |
| 17:13 |
|
hopkinsju joined #evergreen |
| 17:18 |
|
mrpeters left #evergreen |
| 11:10 |
Dyrcona |
dbwells: I plan to work on NCIP at the hackaway, but maybe. |
| 11:10 |
kmlussier |
bshum++ |
| 11:10 |
Dyrcona |
bshum kmlussier Neither have I. |
| 11:12 |
eeevil |
kmlussier: re https://bugs.launchpad.net/evergreen/+bug/1174860 ... it applies without conflict to rel_2_3. I have not attemtped to test its efficacy in that situation, but I don't think it will hurt. if reordering the query so that user input is last and widget-derived input comes first makes your 2.3 tests work, then yes, it should be backported |
| 11:12 |
pinesol_green |
Launchpad bug 1174860 in Evergreen "tpac: search filter groups don't play nicely with facets" (affected: 3, heat: 20) [Undecided,Triaged] |
| 11:13 |
kmlussier |
eeevil: OK, thanks. I'll see if I can test it on a 2.3 system. |
| 11:17 |
|
csharp_mtg joined #evergreen |
| 11:17 |
csharp_mtg |
ssh_port_blocking_on_wifi-- |
| 11:20 |
dbs |
running_an_ssh_server_on_port_443++ |
| 11:58 |
bshum |
Sigh |
| 11:58 |
jeff_ |
do you mean that they fall back to the user's preferences, or something else? |
| 11:58 |
|
jdouma joined #evergreen |
| 11:59 |
bshum |
That's worth testing I guess |
| 12:00 |
bshum |
I think if they don't have preferences, it defaults to no notification |
| 12:00 |
bshum |
Which is confusing the library |
| 12:00 |
bshum |
And the patrons too I guess |
| 12:00 |
bshum |
Since they'll never find out they have holds ready for them |
| 12:02 |
|
acoomes joined #evergreen |
| 12:03 |
dbs |
kraftsman-pac |
| 12:03 |
bshum |
Pretty much :) |
| 12:37 |
bshum |
Hmm |
| 12:37 |
* tsbere |
assumes the backend code doesn't look that stuff up because if the frontend had, say, email deselected we don't want the fact it was the user's default to re-enable it |
| 12:38 |
tsbere |
perhaps one solution would be the load the user's prefs into hidden fields in the kpac? At least then any defaults will apply... |
| 12:41 |
jeff |
that would be the quickest short-term solution, assuming that the kpac handlers will do anything with it. a quick experiment would be to manually create the hidden fields with values in them hardcoded in the appropriate template file in a test environment. |
| 12:42 |
jeff |
you might even find that the defaults / user settings have already been looked up and are available to the template with no handler-side modifications. |
| 12:42 |
jeff |
but if they aren't already there, that would be your next step. :-) |
| 12:43 |
|
mrpeters joined #evergreen |
| 12:47 |
bshum |
Alright, I guess I'll start looking a little at that. |
| 12:48 |
bshum |
Thanks jeff and tsbere |
| 14:52 |
bshum |
Sigh |
| 14:53 |
bshum |
Sorry jboyer-isl, not you. That idea sounds worthy of being added to the list. |
| 14:53 |
bshum |
Sighing about other things :) |
| 14:53 |
jboyer-isl |
bshum: I was going to ask if the KPAC holds testing went poorly. :) |
| 14:53 |
bshum |
jboyer-isl: I haven't even had time to get back to that yet. |
| 14:54 |
jboyer-isl |
One of those days, then, eh? |
| 14:58 |
senator |
jboyer-isl: i owe serials some attention and plan to be dbwells' best friend for some of that time, but as a #2 thing to slot in, yeah i would work on that |
| 14:58 |
bshum |
General opinion... should we keep https://bugs.launchpad.net/evergreen/+bug/1086458 open? Now that someone filed https://bugs.launchpad.net/evergreen/+bug/1224042 ? |
| 14:58 |
pinesol_green |
Launchpad bug 1086458 in Evergreen "Staff client memory leaks in 2.3 and later" (affected: 8, heat: 56) [High,Fix committed] |
| 14:58 |
pinesol_green |
Launchpad bug 1224042 in Evergreen "Staff client memory leaks in 2.4" (affected: 1, heat: 6) [Undecided,New] |
| 14:59 |
bshum |
The 2.3 one has lots of things we've tested/tried |
| 14:59 |
bshum |
But the 2.4 one is most recent and does have additional test information attempted by SITKA I guess. |
| 14:59 |
* jeff |
frowns at 1224042 |
| 14:59 |
bshum |
jeff: That's kind of what I was thinking. |
| 14:59 |
jboyer-isl |
senator: I can work on css/html later if I have to, so if time becomes available just let me know. I don't think I've really got enough experience with eg's guts to get going alone. (i.e. none at all with most of EGCatLoader...) |
| 16:17 |
|
kbeswick joined #evergreen |
| 16:35 |
hopkinsju |
bshum: I'm just now getting to look at the new site. Great job dude! |
| 16:35 |
hopkinsju |
bshum++ |
| 16:35 |
bshum |
hopkinsju: Still a work in progress, but thank you :) |
| 16:36 |
bshum |
dbwells: Is there anything in the logs that indicates why an LDAP authentication might be failing? |
| 16:36 |
bshum |
I'm trying to set up a connection for one of our schools and now I'm not sure if it's the AD user creds I was given or improper test account credentials. |
| 16:37 |
dbwells |
bshum: there are a number of different error messages. One second... |
| 16:38 |
dbwells |
bshum: looks like they are all debug level, and all start with "User login failed:". |
| 16:39 |
bshum |
dbwells: Okay, so I need to bump up opensrf_core.xml to debug level (4?) and then try again |
| 16:45 |
bshum |
Now I just have to figure out why that is and what it means... heh |
| 16:45 |
senator |
no, thank you |
| 16:46 |
dbs |
bshum: port may not be open... credentials could be bad... lots of possibilities with LDAP :) |
| 16:46 |
bshum |
dbs: Yep, that's what I figured. |
| 16:47 |
bshum |
I wish there was an easier way to test this stuff. Stupid LDAP |
| 16:52 |
jeff |
Dyrcona++ for JSONPrefs -- interesting |
| 16:54 |
pastebot |
"dbwells" at 64.57.241.14 pasted "test LDAP bind credentials" (8 lines) at http://paste.evergreen-ils.org/12 |
| 16:55 |
dbwells |
bshum: your LDAP stuff is failing at the admin bind stage, so I would use something simple like the paste above to test the credentials. |
| 16:55 |
dbwells |
bshum: If you can bind, you will get a '0' to print out. |
| 16:55 |
bshum |
dbwells: Thank you sir, that will be mighty helpful indeed. |
| 16:56 |
dbwells |
bshum: obviously, you will need to change the hardcoded stuff in there to whatever your values are for hostname, authid, and password. |
| 16:57 |
bshum |
dbwells: Yep, just tried that and got 49 back. Which looks to be a basic bind error |
| 16:25 |
berick |
ok, yeah, that should pretty much never be empty |
| 16:25 |
berick |
if it's being used |
| 16:26 |
berick |
error logs must be going somewhere else |
| 16:26 |
jeff |
Unfortunately, testing with this implementation shows that the mandatory UniqueUserId/UserIdentifierValue is discarded and only the value of UserOptionalFields/VisibleUserId/VisibleUserIdentifier is stored, and used for subsequent requests (in the UniqueUserId/UserIdentifierValue field, of course) |
| 16:26 |
berick |
also, to confirm, the template source in the linux staff client shows the same lang/xml:lang of fi_fi ? |
| 16:27 |
paxed |
berick: yes |
| 16:27 |
berick |
crazy |
| 16:35 |
paxed |
phasefx: interesting though that FF shows the page in Finnish, but the login texts in english, and the page lang/xml:lang = en_us ... |
| 16:37 |
dbwells |
jeff: right, the second. We didn't want users getting a new account whenever they got a new barcode. If they would just "believe" the UniqueUserId we sent them, all would be fine. |
| 16:38 |
* tsbere |
has at least one vendor he wants to use unique IDs from evergreen but can never seem to get anyone willing to talk to him about it - They assume that barcodes never change or something. |
| 16:39 |
dbwells |
jeff: I think we even tested sending back nothing *but* the ID in the the lookupuser response, but it didn't matter; whatever the patron typed in to get looked up, that was their UniqueId for the rest of the interaction (based on my 5 months old memories, at least). |
| 16:41 |
paxed |
berick: |
| 16:41 |
paxed |
Sep 10 23:41:23 egdev apache2[31157]: [debug] EGWeb.pm(77): [client 62.240.71.4] egweb: messages locale = fi_fi |
| 16:41 |
paxed |
Sep 10 23:41:24 egdev apache2[31166]: [debug] IDL2js.pm(79): [client 62.240.71.4] Invalid IDL2js locale ''; using en-US |
| 16:42 |
jeff |
dbwells: yeah. i'm testing a little more, but i've seen nothing that would contradict that. |
| 16:43 |
berick |
paxed: which test does that match? |
| 16:43 |
berick |
which client/locale/etc, i mean |
| 16:44 |
paxed |
berick: windows client, finnish. and shows english, of course. |
| 16:44 |
berick |
paxed: hm, did you remove my working patch? |
| 16:47 |
phasefx |
if I change the URL for the frame containing the patron editor to /IDL2js, I get a decidedly English set of javascript back |
