Time |
Nick |
Message |
00:28 |
jeff |
hack hack hack |
00:28 |
kmlussier |
jeff: right hack at you |
00:43 |
paxed |
morning |
00:59 |
jeff |
morning! |
01:20 |
|
Mark__T joined #evergreen |
01:49 |
paxed |
is there any kind of summary/links what all was done/suggested/etc during the hackaway? |
04:58 |
|
dconnor joined #evergreen |
05:01 |
|
timf joined #evergreen |
06:39 |
|
fparks joined #evergreen |
07:08 |
|
DPearl joined #evergreen |
08:15 |
remingtron |
paxed: there are a few documents that may help you get a taste of the hacking done this week: |
08:17 |
remingtron |
roughly followed agenda: http://evergreen-ils.org/dokuwiki/doku.php?id=dev:hackfest:hackaway-2013 |
08:18 |
remingtron |
Discussion notes: Future of the staff client: http://goo.gl/I5fXrQ |
08:20 |
remingtron |
Discussion notes: Release Manager process: http://goo.gl/oGoSUI |
08:21 |
remingtron |
and of course, the irc logs for 9-17 thru 9-19: http://open-ils.org/irc_logs/evergreen/ |
08:32 |
|
Shae joined #evergreen |
08:39 |
* dbs |
will link those notes + the Mobile OPAC initial notes to the hackaway wiki doc |
08:43 |
DPearl |
remingtron++ for the fine notes! |
08:44 |
paxed |
remingtron: thanks. |
08:46 |
dbs |
Okay, wiki page updated |
08:46 |
remingtron |
dbs++! |
08:47 |
* remingtron |
loves updated wiki pages |
08:47 |
|
kbeswick joined #evergreen |
08:48 |
remingtron |
DPearl: I must acknowledge dbs for starting the note-taking trend. |
08:48 |
* dbs |
also changed the documents to "Anyone with the link can comment" from "can edit" to maintain historical (in)accuracy and to reflect that they're not really living documents |
08:48 |
remingtron |
dbs: good change |
08:51 |
dbs |
remingtron: I will admit that, as a remote participant, the note-taking was purely selfish; I was delighted when others joined in! |
08:51 |
paxed |
i think the note-taking was a very good idea |
08:52 |
remingtron |
dbs: isn't it great when our selfishness benefits the community? not sure how often that happens, but it did here! |
08:53 |
|
rfrasur joined #evergreen |
08:53 |
|
kmlussier joined #evergreen |
08:55 |
|
ericar joined #evergreen |
09:01 |
paxed |
maybe linking to the blog post bshum did? |
09:02 |
paxed |
with the images of the mobile opac improvements branch |
09:05 |
kmlussier |
paxed: Rogan also wrote some blog posts - http://www.roganhamby.com/ |
09:09 |
paxed |
kmlussier: thanks |
09:13 |
|
RoganH joined #evergreen |
09:14 |
paxed |
speaking of the devil himself. :P |
09:19 |
_bott_ |
bshum: just pushed my latest style changes with the myopac pieces |
09:21 |
paxed |
is Yamil's debian install doc available somewhere? |
09:21 |
bshum |
_bott_++ # I'll take a look and get it on theory next. |
09:24 |
kmlussier |
_bott_++ |
09:24 |
rfrasur |
kmlussier:looking at the post re the mopac. was there talk actually hiding the search-type-format-library at lower resolutions? since the "another search" button is there anyway? |
09:25 |
kmlussier |
rfrasur: On which screens? |
09:26 |
bshum |
On the results page? (I've voted yes) |
09:26 |
rfrasur |
no. 2 - The results page |
09:26 |
kmlussier |
Yes, I think several of us voted yes. And on the account pages too. |
09:27 |
_bott_ |
rfrasur: I don't think any of us liked the real estate taken up by the search box after a search or within myopac |
09:27 |
rfrasur |
other than that (and that's not a broken thing or anything), that looks pretty excellent |
09:27 |
dbs |
rfrasur: we're getting there, I think. right now "Refine these results" hides the results and shows facets in low-screen-width mode, we could also hide the search-type-format-library stuff by default at a lower resolution and only show it when someone hits "Refine these results" or "Another search" |
09:28 |
rfrasur |
mobile_catalog_hacking_team++ |
09:28 |
rfrasur |
bshum++ #for getting that all online |
09:29 |
* kmlussier |
returns to trying to figure out what she did wrong in prefs_base.tt2 |
09:29 |
kmlussier |
bshum++ indeed. Nice post! |
09:44 |
* rfrasur |
wishes the rest of everyone else (outside of EG) (specifically eGovernment) that deals with information thought about the end-user. |
10:00 |
jeffdavis |
*yawn* |
10:01 |
jeffdavis |
I've never used in-flight wifi before. This is pretty cool. |
10:01 |
kmlussier |
jeffdavis: What time did you have to wake up this morning? |
10:01 |
jeffdavis |
4am :( |
10:02 |
kmlussier |
jeffdavis: Plenty of time to take a nap on the flight. ;) |
10:04 |
jeffdavis |
yeah, this is the first time I've been awake since ... well, I'm not sure I was exactly *awake* when I went to the airport, come to think of it. :) |
10:21 |
|
gmcharlt joined #evergreen |
10:27 |
bshum |
_bott_: I tried the change on theory and while it does style the my account stuff as described, it seems to break the search results tables |
10:27 |
bshum |
I think something from that is bleeding through to those |
10:35 |
_bott_ |
really? ...hmm, I'll see what I find |
10:35 |
bshum |
Looks like it's coming from line 1963 or so |
10:36 |
|
dboyle joined #evergreen |
10:36 |
bshum |
If I qualify each of those things tbody, th, td, tr with the prefix table#acct_checked_main_header, then it doesn't break |
10:36 |
bshum |
I wonder if it's the commas |
10:36 |
dbs |
lemme take a look |
10:36 |
_bott_ |
It's the first line under " Force table to not be like tables anymore" |
10:37 |
_bott_ |
...in style.css.tt2, that is |
10:37 |
_bott_ |
It's not respecting, only applying that to the named table |
10:37 |
dbs |
bshum: if those are really comma delimited, then they will affect _every_ tbody, th, td, and tr |
10:37 |
_bott_ |
Ah! |
10:37 |
bshum |
Yeah that's what's happening |
10:38 |
dbs |
vs "#acct_checked_main_header tbody th td" which would affect only tds that are children of ths that are children of tbodys that are children of id = acct_checked_main_header :) |
10:43 |
kmlussier |
I'm working to replace the sub-tabs in my account with a select menu in the mobile view, similar to the way I did so with main account tabs. |
10:43 |
kmlussier |
In doing so, I discovered that prefs_base.tt2 uses hardcoded values for the links and labels, meaning we would have to maintain two different menus. I wanted to remove those hardcoded values so that we only need to maintain one set of links, but I'm having some trouble. |
10:43 |
kmlussier |
Just to make sure I'm working in the right direction, I was planning to use myopac/base.tt2 as a model. - http://pastebin.com/fJkNSnmJ |
10:44 |
kmlussier |
If I replace the varriable used at line 3 with some other unique variable name and then update other pieces of the code to reflect values used in prefs_base.tt2, would that be the best route to removing those hardcoded values? |
10:44 |
kmlussier |
I tried it with some success (the tabs display with the correct labels and links), but I've have not been able to get tpac to identify which tab is the active page and style it accordingly. |
10:50 |
_bott_ |
bshum: just pushed a "non-comma'd" version |
10:55 |
bshum |
_bott_: Looks much happier now. Yay! |
11:01 |
* bshum |
finishes packing to get checked out. Be back later. |
11:01 |
kmlussier |
For reference, this is my current attempt: http://pastebin.com/PZaEUDpJ |
11:12 |
|
zerick joined #evergreen |
11:46 |
|
jdouma joined #evergreen |
11:50 |
|
acoomes joined #evergreen |
11:54 |
DPearl |
kmlussier: Where is acct_prefs_page defined? |
11:56 |
dbs |
kmlussier: if you can post a working branch so we can diff the before/after changes, that would probably help a lot (at least it would help me a lot) |
11:59 |
|
dMiller joined #evergreen |
12:02 |
|
Shae joined #evergreen |
12:04 |
|
zerick left #evergreen |
12:14 |
|
smyers_ joined #evergreen |
12:50 |
|
acoomes_ joined #evergreen |
12:53 |
|
krvmga joined #evergreen |
12:54 |
krvmga |
where are the fields for facet searches defined/configured? |
13:08 |
krvmga |
i was just doing a facet search on Napoleon I, Emperor of the French, 1769-1821. in the OPAC, 1769-1821 is searched properly. in the staff client, though the hyphen is stripped out (resulting in 17691821) causing the search to fail. |
13:08 |
krvmga |
is there anything i might be able to do to fix this or have i found a bug? |
13:09 |
|
b_bonner joined #evergreen |
13:19 |
|
rfrasur joined #evergreen |
13:20 |
kmlussier |
krvmga: I think there was a fix for that. |
13:20 |
krvmga |
kmlussier: that would be nice :) |
13:21 |
kmlussier |
krvmga: Did you search Launchpad? |
13:21 |
krvmga |
kmlussier: i searched "facets" on launchpad |
13:21 |
kmlussier |
dbs: Thanks! I'll do that. Might be a few minutes. |
13:22 |
sseng |
hello. Is there any settings in evergreen to enforce a certain amount of time first before a renewal is allowed? so that the user doesn't use up all their renewals in day 1 for example. thanks! |
13:23 |
krvmga |
kmlussier: i found this https://bugs.launchpad.net/evergreen/+bug/1183418 it might be the same thing. |
13:23 |
pinesol_green |
Launchpad bug 1183418 in Evergreen "click on author with dates in search results fails" (affected: 2, heat: 10) [Medium,Fix committed] |
13:24 |
kmlussier |
krvmga: Yeah, that's the one I was thinking of. |
13:24 |
krvmga |
kmlussier: it says, though, that the fix was released for 2.3 |
13:24 |
|
dMiller__ joined #evergreen |
13:24 |
|
smyers__ joined #evergreen |
13:24 |
krvmga |
maybe the fix only fixed the opac and not the staff client |
13:24 |
|
acoomes joined #evergreen |
13:26 |
kmlussier |
krvmga: Did you check to see if the fix was applied locally? It may be a tt2 file where you have a local customization. |
13:27 |
krvmga |
kmlussier: actually, i see it was for 2.3.8. we're on 2.3.3. i'll see what i can dig up. |
13:32 |
krvmga |
kmlussier: yeah, it's fixed for our opac in /openils/var/templates/opac/parts/result/table.tt2. |
13:32 |
krvmga |
so i think what happened is that it was assumed that the fix to table.tt2 would work the same way in the staff client. |
13:32 |
krvmga |
except it doesn't |
13:34 |
kmlussier |
krvmga: I'm fairly sure it works in the staff client too. Are you sure you don't have a customized table.tt2 in your local template folder? |
13:35 |
krvmga |
kmlussier: i do but the fix code is the same in both places. |
13:35 |
kmlussier |
krvmga: On all bricks? |
13:37 |
krvmga |
kmlussier: it was put on all the bricks about six weeks ago. i could always recopy it just in case. |
13:43 |
|
dMiller joined #evergreen |
13:50 |
kmlussier |
dbs / DPearl: I think I see where I went wrong. I'll report back shortly. |
14:10 |
|
blongwel joined #evergreen |
14:28 |
|
ktomita joined #evergreen |
14:30 |
blongwel |
just enabled google preview in tpac config.tt2 and preview button appears but doesn't link out. Am I missing another step? |
14:32 |
|
stevenyvr2 joined #evergreen |
14:35 |
|
Rish joined #evergreen |
14:37 |
|
Rish joined #evergreen |
14:38 |
dbs |
blongwel: link? |
14:46 |
blongwel |
dbs: clicking on the Google Preview icon in the tpac doesn't do anything. Example: http://catalog.sage.eou.edu/eg/opac/record/1330412?query=Hyewon%20Yum;qtype=keyword;locg=1 |
14:49 |
|
j_scott joined #evergreen |
14:52 |
dbs |
blongwel: hmm. I don't actually see a Google Preview icon in my browser (Chrome/Linux). What are you using? |
14:53 |
|
RoganH joined #evergreen |
14:53 |
blongwel |
dbs: Firefox, but I got it to come up in Chrome as well. Curious |
14:54 |
dbs |
Of course, I'm in Canada, so different copyright regime |
14:54 |
dbs |
I'll tunnel it through my US proxy |
14:54 |
bshum |
I can see the icon |
14:55 |
bshum |
And also that it doesn't link to a new tab |
14:55 |
dbs |
Okay, I can see it |
14:55 |
bshum |
I wonder if there's something wrong with the template |
14:55 |
dbs |
And in the browser console, I see an error: "Uncaught ReferenceError: novSelect is not defined " |
14:55 |
bshum |
I saw that too |
14:55 |
dbs |
which stops the script from completing. |
14:58 |
blongwel |
dbs: where is novSelect supposed to be defined? |
14:59 |
* dbs |
is debugging |
15:00 |
dbs |
oh, gbp_extra_container is missing |
15:01 |
dbs |
Sounds like there are some local template customizations missing & breaking things |
15:02 |
dbs |
gbp_extra_container should be defined in /openils/var/templates/opac/parts/record/extras.tt2 (substitute "/templates/" for whatever your local override directory might be) |
15:03 |
blongwel |
dbs: thanks, I'll take a look at the custom extras.tt2 and compare it to default, |
15:04 |
dbs |
novSelect is a weird one, it's just hanging out there in /openils/var/templates/opac/parts/acjs.tt2 all by itself. Presumably it gets created by some included Novelist script or something? |
15:04 |
* dbs |
doesn't use or know Novelist |
15:04 |
blongwel |
dbs: we don't use Novelist either |
15:06 |
dbs |
blongwel: huh, that code should only be visible if ENV.OILS_NOVELIST_URL is set (in your Apache config I think) |
15:10 |
|
RoganH joined #evergreen |
15:11 |
remingtron |
Just found this, could help us recruit/be more friendly to new contribs: https://openhatch.org/ |
15:12 |
kmlussier |
Nice! I like the training missions. |
15:13 |
RoganH |
Interesting. |
15:14 |
rfrasur |
eeevil++ RoganH++ #Library Journal quotes for OS ILS |
15:14 |
RoganH |
I haven't seen it myself yet. |
15:15 |
RoganH |
What did I say? |
15:15 |
rfrasur |
Your quotes have a very distinguished chin. |
15:15 |
|
dboyle_ joined #evergreen |
15:15 |
* RoganH |
doesn't think that the Grand Rapids airport news stand carries Library Journal. |
15:16 |
rfrasur |
Operations manager Rogan Hamby, a 2011 LJ Mover & Shaker, praised the community aspect of Evergreen, nothing that it had engaged many SC LENDS members in unexpected ways." |
15:16 |
RoganH |
That's me. Distinguished. Or something. I probably should say that when I'm not wearing jeans and a hawaiian shirt. |
15:16 |
|
dboyle joined #evergreen |
15:17 |
eeevil |
rfrasur: oh dear ... available online yet? |
15:17 |
* dbs |
is sure that that was a typo, s/engaged/enraged/ |
15:17 |
rfrasur |
"We get together to talk about what we like about the system, what we don't, how we want to improve things," Hamby says. "the whole dynamichas been extremely beneficial......." There's more...and yes, typos are mine. |
15:18 |
rfrasur |
eeevil, I dunno. I'm reading the paper version. |
15:18 |
blongwel |
thanks again to dbs and bshum. I put default extras.tt2 in place and google preview is working. |
15:18 |
kmlussier |
dbs++ |
15:18 |
* rfrasur |
checks |
15:19 |
rfrasur |
I dunno. It's in the sept. 15 edition. |
15:20 |
rfrasur |
Good mentions of support vendors....it's a nice article. |
15:20 |
rfrasur |
Lots of upfront emphasis on KCLS |
15:22 |
RoganH |
I look forward to seeing it, especially since I don't actually remember what I said. |
15:23 |
kmlussier |
dbs / bshum: I pushed a new commit on the collab branch. However, I'm a little nervous about one change I made. It turned out that previous efforts to use the prefs_page variable to determine if the page was active or not were unsuccessful because the prefs_page value doesn't match the URL. |
15:23 |
rfrasur |
I don't mind to type the whole thing...but I didn't want to spam the channel. Both you and eeevil had really good input. I'll be bragging to people. |
15:25 |
kmlussier |
I did a grep, and, as far as I can tell, prefs_base.tt2 is the only page that looks for the value in the prefs_page attribute, so I approached it by changing the value. But I would appreciate more eyes on it just to make sure I didn't break something else that was depending on it. |
15:27 |
csharp |
whew - back home |
15:27 |
eeevil |
rfrasur: don't do it for me, I'll just ILL a copy ;) |
15:27 |
* kmlussier |
finds it difficult to work without a steady supply of coffee/soda/snacks nearby. |
15:28 |
csharp |
ESI++ #sponsoring snacks! |
15:28 |
kmlussier |
ESI++ indeed |
15:28 |
eeevil |
snacks++ |
15:28 |
kmlussier |
@karma ESI |
15:28 |
pinesol_green |
kmlussier: Karma for "ESI" has been increased 12 times and decreased 1 time for a total karma of 11. |
15:29 |
kmlussier |
Is that case sensitive? I'm pretty sure I used all lower case when giving karma the other day. |
15:29 |
rfrasur |
lol, I was just going to type your quotes...not the whole article. pretty sure they'll put me in librarian jail for that. It's a good article. Everybody read it. "Developing Partnerships" by Matt Enis - Sept. 15, 2013 issue of Library Journal |
15:29 |
rfrasur |
@karma esi |
15:29 |
pinesol_green |
rfrasur: Karma for "esi" has been increased 12 times and decreased 1 time for a total karma of 11. |
15:29 |
gmcharlt |
CaseInsensitive++ |
15:30 |
gmcharlt |
@karma CaSeInSeNsItIvE |
15:30 |
pinesol_green |
gmcharlt: Karma for "CaSeInSeNsItIvE" has been increased 1 time and decreased 0 times for a total karma of 1. |
15:30 |
kmlussier |
gmcharlt++ |
15:30 |
rfrasur |
gmcharlt++ |
15:30 |
csharp |
gmcharlt++ |
15:32 |
RoganH |
gmcharlt++ |
15:32 |
RoganH |
out of curiosity though, what is librarian jail like? do they not let you read and just make you watch as visitors mis-shelve things? |
15:32 |
RoganH |
actually that might be more like hell |
15:33 |
paxed |
i'm sure the berne convention prevents that kind of treament |
15:34 |
rfrasur |
RoganH: In my case, librarian jail includes trying to pull holds for materials that were deselected but never removed from the system...but stamped and disposed of. |
15:35 |
rfrasur |
It also involves spending more than a few days ONLY surrounded by other librarians and talking exclusively about library policies with regard to tax help, medical help, teens, and smelly patrons. |
15:37 |
rfrasur |
oh...and more than one patron a day telling me how much they'd love my job because they love to read...and how great it'd be to just read all day. |
15:37 |
atheos |
smelly patrons. always a hot topic |
15:39 |
rfrasur |
(and that's why I don't copy entire articles and post them on the interwebs) |
15:42 |
kmlussier |
_bott_++ #improvements to my account pages. |
15:44 |
* RoganH |
thinks that bshum is being very serious where he is sitting. |
15:44 |
kmlussier |
Hmmmm...I'm using one of the Concerto logins with an expired account. The message is scrolling off the screen. |
15:45 |
bshum |
RoganH: Apparently I'm already being dragged back into helpdesk work |
15:45 |
RoganH |
bsum: like nancy reagan taught us "just say no" |
15:45 |
kmlussier |
The "show only available holds" link could use some work too. |
15:49 |
|
acoomes joined #evergreen |
15:49 |
RoganH |
Reading the article. He took some good chunks from our chat in the "Free to go but here to stay" section which I'm pleased with. Though I can easily imagine eeevil may have said some of the same things. |
15:50 |
eeevil |
:) |
15:54 |
rfrasur |
RoganH++ |
15:54 |
rfrasur |
eeevil++ |
16:13 |
|
stevenyvr2 joined #evergreen |
16:15 |
remingtron |
I've been updating the main docs contribution page. Anyone willing to proofread it for me? |
16:15 |
remingtron |
http://evergreen-ils.org/dokuwiki/doku.php?id=evergreen-docs:how-to-contribute-documentation |
16:16 |
kmlussier |
remingtron: I'll take a look. |
16:16 |
remingtron |
kmlussier++ |
16:16 |
* rfrasur |
is also taking a look |
16:17 |
kmlussier |
dbs: I really like what you did with the facets. Just getting a chance to look at them now. |
16:20 |
rfrasur |
I think the "Clone the repository" and following things may want to go under an advanced header. |
16:21 |
rfrasur |
or something that says, after the intermediate, "now you're entering into developerish land...here there be giants." |
16:22 |
kmlussier |
remingtron: I think it looks good. My only thought was whether we should also encourage the use of Launchpad for reporting bugs and posting working branches. |
16:22 |
remingtron |
rfrasur++ #good thought, I forgot to address that |
16:23 |
kmlussier |
I'm trying to remember the last DIG meeting. Did we ultimately decide to start using Launchpad more for this purpose? |
16:23 |
rfrasur |
kmlussier++ #good point..yes, we did |
16:23 |
remingtron |
kmlussier: I was about to ask the same question |
16:24 |
remingtron |
kmlussier: I don't want to step on toes, but as an experiment I posted my serials docs to bug 1207519 |
16:25 |
pinesol_green |
Launchpad bug 1207519 in Evergreen "Serials 2.4 updated documentation needed" (affected: 1, heat: 6) [Undecided,Confirmed] https://launchpad.net/bugs/1207519 |
16:25 |
remingtron |
so if you want to test the workflow and push it in... :) |
16:25 |
kmlussier |
remingtron: Yes, that's right. Since I'm in git now, maybe I'll push it. :) |
16:25 |
rfrasur |
remingtron, from my understanding, that's exactly what we were hoping to have happen. |
16:26 |
kmlussier |
I was going to start adding new 2.5 features that need documentation to Launchpad. |
16:26 |
remingtron |
sounds like a good test run |
16:26 |
remingtron |
kmlussier++ |
16:27 |
kmlussier |
eeevil: FWIW, I didn't see your comments as negative. |
16:28 |
rfrasur |
okay...sorry I couldn't look it over more. Time to go do payroll. Staff don't look kindly on late paychecks. |
16:28 |
eeevil |
kmlussier: thanks, I struggle with tone in technical text discussions |
16:29 |
* eeevil |
out! |
16:37 |
kmlussier |
remingtron: We'll need to wait until tomorrow to verify that they updated to the docs page correctly. |
16:37 |
kmlussier |
remingtron++ #helping out with docs |
16:38 |
pinesol_green |
[evergreen|Remington Steed] Update serials docs for 2.4 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c371b08> |
16:45 |
remingtron |
hurray! kmlussier++ |
17:16 |
|
kmlussier joined #evergreen |
17:22 |
|
kbutler joined #evergreen |
17:44 |
bshum |
kmlussier++ # new menu for preferences looks reasonable so far. Going to test further. |
17:45 |
kmlussier |
DPearl++ for suggesting the approach. |
17:46 |
kmlussier |
We need to figure out what we want to do with the tabs in the account holds and checked-out items interfaces. |
17:46 |
kmlussier |
There are only two tabs, so the display isn't as terrible as the others. |
17:46 |
kmlussier |
On the other hand, I like consistency. |
17:53 |
bshum |
Pushed a quick ugly hack to hide the searchbar from the my account and few other places. |
17:53 |
bshum |
I'm going to ponder ways of refactoring searchbar.tt2 to handle that situation better. |
17:53 |
bshum |
Later |
17:53 |
kmlussier |
bshum++ |
17:53 |
bshum |
In the meantime, going to go see if my flight is going to board anytime soon. |
17:57 |
|
dboyle joined #evergreen |
19:34 |
|
ktomita_ joined #evergreen |
20:07 |
|
stevenyvr2 left #evergreen |
20:32 |
|
leofseige joined #evergreen |
22:04 |
|
mtcarlson_away joined #evergreen |
22:07 |
|
stevenyvr2 joined #evergreen |
22:07 |
|
stevenyvr2 left #evergreen |
22:08 |
|
b_bonner_ joined #evergreen |
22:10 |
|
mtcarlson_away joined #evergreen |