| 03:10 |
|
dpearl joined #evergreen |
| 04:24 |
|
matthiaskrgr27 joined #evergreen |
| 04:40 |
|
Xenthys0 joined #evergreen |
| 06:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:01 |
|
trqx10 joined #evergreen |
| 07:04 |
|
agoben joined #evergreen |
| 07:06 |
|
rjackson_isl joined #evergreen |
| 08:44 |
rhamby_ |
kmlussier: you don't happen to have notes about what failed for you on bug 1722827 do you? |
| 08:44 |
pinesol |
Launchpad bug 1722827 in Evergreen "Trailing spaces cause located URIs to be invalid" [Undecided,New] https://launchpad.net/bugs/1722827 |
| 08:46 |
|
pwillard26 joined #evergreen |
| 08:54 |
kmlussier |
rhamby_: It's what I put in the LP bug. After the first test where I finally got it to work, when I tried on a subsequent day, every attempt failed. I tried the space before the OU, after an OU, it didn't matter. |
| 08:54 |
kmlussier |
I can look at it again. |
| 08:55 |
|
bos20k joined #evergreen |
| 08:55 |
rhamby_ |
kmlussier: so weird, I tried over and over last night and I couldn't get it to not work with spaces before and after on different records. |
| 08:56 |
rhamby_ |
kmlussier: I did direct by db. Did you use the staff client for editing, wondering if that could somehow make a difference.... I can't see how though. |
| 08:58 |
kmlussier |
rhamby_: Yes, I used the client. The others testing that patch would have used the client too because they were on my VM, and they don't have db access. |
| 09:24 |
|
ChasedSpade joined #evergreen |
| 09:29 |
|
yboston joined #evergreen |
| 09:34 |
|
bos20k joined #evergreen |
| 09:42 |
|
jvwoolf joined #evergreen |
| 10:04 |
|
khuckins_ joined #evergreen |
| 10:12 |
|
idjit joined #evergreen |
| 10:15 |
kmlussier |
berick / khuckins_ : Just wanted to let you know that the problem I had with perm group tree entries was related to not applying the branch correctly. Working for me now. |
| 10:15 |
idjit |
kmlussier++ # friendly guidance RE 1775216 and upgrade script naming. i got you a cat https://i.imgur.com/oamgCcg.gif |
| 10:15 |
khuckins_ |
kmlussier: That's good to hear :) |
| 10:17 |
kmlussier |
idjit: So cute! I wish my dog and cat got along that well. |
| 14:02 |
berick |
kmlussier: for bug 1721575, can I assume "Sort cart items by:" should be "Sort basket items by:" ? if so, I can make that change before merging |
| 14:02 |
pinesol |
Launchpad bug 1721575 in Evergreen "Batch Actions from Search Results" [Wishlist,Confirmed] https://launchpad.net/bugs/1721575 - Assigned to Bill Erickson (berick) |
| 14:03 |
hbrennan |
It works! Thanks y'all! |
| 14:03 |
kmlussier |
berick: Yes. It was still a cart in initial testing. |
| 14:03 |
hbrennan |
idjit++ |
| 14:06 |
collum |
hbrennan++ |
| 14:06 |
collum |
Sorry. Someone came into the office right when you started typing. |
| 15:17 |
|
khuckins_ joined #evergreen |
| 15:33 |
JBoyer |
kmlussier, was example.reporter-extension.sql run on mlnc1.noblenet.org ? That's where reporter.classic_item_list (from the error text) is defined. |
| 15:34 |
JBoyer |
As long as they're in the default IDL they're not exactly "examples," but "missing" :/ |
| 15:35 |
kmlussier |
JBoyer: Nope. I just created another report that didn't use classic item list to complete my test rather than figure out how to add it. |
| 15:35 |
* kmlussier |
is lazy that way. |
| 15:35 |
JBoyer |
kmlussier++ |
| 15:35 |
JBoyer |
So long as you know. Maybe I'll toss the busted report so no one else makes the same mistake I did. :) |
| 15:36 |
kmlussier |
Reports is my weak spot, and any time I need to test something there, I end up floundering. |
| 15:36 |
kmlussier |
JBoyer: Oops. Sorry! |
| 15:47 |
csharp |
kmlussier: I'm curious - I'm missing what JBoyer is talking about in the scrollback - what's going on? |
| 15:49 |
JBoyer |
running reports on the inventory date test server. :) |
| 15:49 |
kmlussier |
csharp: Oh, I had just tried using Classic Item List for a report on a test system, but I hadn't first run example.reporter-extension.sql. |
| 15:50 |
csharp |
oh, I understand |
| 15:50 |
csharp |
yeah :-/ the age-old dilemma of whether we remove those from the UI or add them to the default DB |
| 15:51 |
csharp |
or remove stat_cats from the view |
| 17:09 |
|
mmorgan left #evergreen |
| 17:23 |
|
khuckins__ joined #evergreen |
| 18:06 |
kmlussier |
Calling 1119 |
| 18:15 |
pinesol |
[evergreen|a. bellenir] LP#1775216: inconsistent availability counts between staff client and opac - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9b4591e> |
| 18:15 |
pinesol |
[evergreen|a. bellenir] LP#1775216: adding a pgtap test for inconsistent availability counts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=fe47420> |
| 18:15 |
pinesol |
[evergreen|a. bellenir] LP#1775216: inconsistent copy counts between opac and staff client - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aa1d560> |
| 18:15 |
pinesol |
[evergreen|a. bellenir] LP#1587620: inconsistent copy counts between opac and staff client for peer bibs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=327daf4> |
| 18:15 |
pinesol |
[evergreen|Kathy Lussier] LP#1775216: Stamping upgrade script for inconsistent copy counts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d967aac> |
| 18:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:38 |
|
sulvone2 joined #evergreen |
| 21:20 |
|
Cronus20 joined #evergreen |
| 22:05 |
|
Guest43996 joined #evergreen |
| 05:04 |
|
Usurp21 joined #evergreen |
| 05:27 |
|
ZLSA24 joined #evergreen |
| 05:36 |
|
luisoliv joined #evergreen |
| 06:30 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
| 06:43 |
|
Dyrcona joined #evergreen |
| 06:46 |
csharp |
more data from 18.04 OpenSRF math/dbmath not starting: https://pastebin.com/bm3iNJNY |
| 06:49 |
Dyrcona |
This is a case where encryption is forced on us, but not necessary. |
| 09:59 |
berick |
fyi, there's a fix to last night's build errors in bug 1775719 |
| 09:59 |
pinesol |
Launchpad bug 1775719 in Evergreen 3.0 "Multiple IndexedDB connections (via tabs) can result in data inconsistency" [High,Confirmed] https://launchpad.net/bugs/1775719 - Assigned to Kathy Lussier (klussier) |
| 10:00 |
bos20k |
Regarding the voicing issue. I am finally registered and verified at Freenode (had to use different e-mail address). Once we are registered and verified are we supposed to automatically be voiced in #evergreen? |
| 10:00 |
bshum |
bos20k: No, it doesn't automatically voice you, but I think you'd just be able to speak without being voiced if you were registered, etc. |
| 10:00 |
|
Milos19 joined #evergreen |
| 10:00 |
bshum |
I could unvoice you to test that :) |
| 10:01 |
bos20k |
Sure |
| 10:02 |
bshum |
Try it :) |
| 10:02 |
bos20k |
Testing, testing, 123... |
| 10:02 |
bshum |
Huzzah |
| 10:02 |
kmlussier |
Woo hoo! |
| 10:02 |
bos20k |
My voice is my password, verify me. |
| 14:19 |
Dyrcona |
But, I have a log entry to prove it's possible from the client, 'cause there's a cstore call to actor.usr_merge with the same id for src and dest usr. |
| 14:19 |
Dyrcona |
The result isn't good. |
| 14:28 |
dbwells |
Dyrcona: but can we contain it? |
| 14:28 |
Dyrcona |
dbwells: Sure, the fix is relatively simple (at least in the database), I'm going to do a test before opening a Lp bug. |
| 14:29 |
Dyrcona |
The fix is to add a check at the top of actor.usr_merge to bail if the user ids are the same. |
| 14:29 |
dbwells |
Dyrcona: sorry, just a poor attempt at humor. Next time, more exclamations points, maybe. |
| 14:29 |
Dyrcona |
Ah ha! |
| 16:00 |
|
stephengwills left #evergreen |
| 16:20 |
|
jvwoolf left #evergreen |
| 16:34 |
kmlussier |
@quote random |
| 16:34 |
pinesol |
kmlussier: Quote #112: "<RoganH> My most remembered contributions to IRC will involve coffee and deep frying." (added by csharp at 12:43 PM, April 15, 2015) |
| 16:37 |
|
Xenthys8 joined #evergreen |
| 16:41 |
|
Mikaela28 joined #evergreen |
| 16:49 |
|
bdljohn joined #evergreen |
| 16:54 |
|
Fuchs14 joined #evergreen |
| 16:58 |
|
mmorgan left #evergreen |
| 17:11 |
pinesol |
[evergreen|Garry Collum] LP#1752891 Crowded text on Print Item Labels page fix. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=ecdcfb2> |
| 17:18 |
|
luisoliv joined #evergreen |
| 18:18 |
|
rorx21 joined #evergreen |
| 18:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:32 |
|
theaetetus joined #evergreen |
| 19:41 |
|
basic`26 joined #evergreen |
| 20:25 |
|
Sharker joined #evergreen |
| 03:15 |
|
majestic6 joined #evergreen |
| 05:48 |
|
infina4 joined #evergreen |
| 06:22 |
|
cncr04s20 joined #evergreen |
| 06:32 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
| 06:45 |
|
Numline123 joined #evergreen |
| 06:58 |
|
lorimer15 joined #evergreen |
| 07:07 |
|
agoben joined #evergreen |
| 07:38 |
|
dwgreen joined #evergreen |
| 07:38 |
|
bdljohn joined #evergreen |
| 08:06 |
|
collum joined #evergreen |
| 08:16 |
pinesol |
[evergreen|a. bellenir] LP#1785305: Item Status 'Edited By' shows id instead of username. - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aae6a29> |
| 08:36 |
|
dpearl joined #evergreen |
| 08:40 |
|
badpixel27 joined #evergreen |
| 08:41 |
|
mmorgan joined #evergreen |
| 10:01 |
csharp |
comcast-- |
| 10:05 |
* Dyrcona |
just asked if bug 1702978 should be backported and targeted at earlier series. |
| 10:05 |
pinesol |
Launchpad bug 1702978 in OpenSRF "memcache keys containing % fail" [High,Confirmed] https://launchpad.net/bugs/1702978 - Assigned to Jason Stephenson (jstephenson) |
| 10:09 |
kmlussier |
kmlussier-- # Not noticing test failures when testing bug 1775719. |
| 10:09 |
pinesol |
Launchpad bug 1775719 in Evergreen 3.0 "Multiple IndexedDB connections (via tabs) can result in data inconsistency" [High,Confirmed] https://launchpad.net/bugs/1775719 - Assigned to Kathy Lussier (klussier) |
| 10:09 |
* berick |
was just verifying |
| 10:09 |
berick |
waiting for npm |
| 10:13 |
pinesol |
Launchpad bug 1746566 in Evergreen 3.1 "wishlist: increase row limits available in specific grids" [Undecided,New] https://launchpad.net/bugs/1746566 |
| 10:14 |
kmlussier |
Dyrcona: Sounds reasonable. |
| 10:17 |
miker |
Dyrcona: re 1702978, the EG-only part can be backported, IIRC. I believe we're using that in production without the opensrf part |
| 10:18 |
Dyrcona |
Adding a % to my username would be a decent test, yes? |
| 10:18 |
berick |
kmlussier: fix en route |
| 10:18 |
berick |
bitten again by phantomjs lagging in support for features |
| 10:18 |
berick |
[].includes(..) in this case |
| 10:20 |
miker |
Dyrcona: yes |
| 10:21 |
Dyrcona |
miker: Thanks, that's what I thought. |
| 10:21 |
Dyrcona |
"Just makin' sure...." |
| 10:23 |
Dyrcona |
I'll test it with OpenSRF and Evergreen 3.0 first. |
| 10:24 |
|
yboston joined #evergreen |
| 10:40 |
|
yboston joined #evergreen |
| 10:41 |
jeff |
quick news: as of me setting +z on the channel the other day, unidentified users can now just send a @voice command to channel to have pinesol voice them. |
| 10:42 |
jeff |
(+z makes it so that channel operators like pinesol can see messages from users who wouldn't normally be able to send to channel (includig spammers). |
| 10:43 |
jeff |
this also conveniently works around the issue where such users can't message pinesol directly because of pinesol automatically getting the +R usermode |
| 10:43 |
berick |
can anyone else running rel_3_0 confirm 'grunt test' won't build? wondering if my node version (v8) is incompatible. |
| 10:44 |
berick |
s/won't build/exits immediately/ |
| 10:44 |
berick |
with: TypeError: Cannot read property 'prototype' of undefined |
| 10:44 |
Dyrcona |
with or without the fix for offline mode? |
| 10:44 |
bshum |
berick: From what I remember, node 8 didn't work for me when I was testing it awhile back, but I can try again later. |
| 10:45 |
berick |
Dyrcona: stock rel_3_0 |
| 10:45 |
Dyrcona |
I'm using node 6. |
| 10:46 |
Dyrcona |
Last time I tried node 8 nothing worked, but I got a botched Node upgrade because I didn't do it with the proper method of the week. |
| 10:47 |
Dyrcona |
FWIW, grunt test is working with Node 6.11.3. |
| 10:48 |
berick |
Dyrcona++ |
| 10:48 |
* berick |
continues his monologue on 1775719 |
| 10:51 |
Dyrcona |
yeah. |
| 10:51 |
Dyrcona |
bshum ^^ :) |
| 10:51 |
Dyrcona |
harmless wrong tab. :) |
| 10:52 |
Dyrcona |
And, since I just restarted apache on my test vm I have a question: |
| 10:53 |
Dyrcona |
Has anyone noticed that you have to restart/reload apache after restarting the opensrf.settings service lately? |
| 10:54 |
Dyrcona |
Since 3.0 or possibly the web client, if I restart opensrf.settings and open-ils.cat to pickup new MARC templates, for instance, neither the web client nor XUL will let me login until I restart apache2. |
| 10:54 |
Dyrcona |
That didn't used to happen, IIRC. |
| 13:06 |
|
bdljohn joined #evergreen |
| 13:07 |
Dyrcona |
Too late for the Monty Python reference.... |
| 13:11 |
rhamby_ |
Dyrcona: it's never too late for a monty python reference |
| 13:15 |
csharp |
berick: replying late to your request to comment on bug 1775466 - I'm happy to, but I broke something when assigning a public IP to my test server and workstation registration stopped working - reinstalling the ang6 stuff in hopes that it Just Works™ |
| 13:15 |
pinesol |
Launchpad bug 1775466 in Evergreen "Angular6 Base Application" [Undecided,New] https://launchpad.net/bugs/1775466 - Assigned to Bill Erickson (berick) |
| 13:16 |
csharp |
so I'd like to see it working again before I comment :-) |
| 13:19 |
|
rlefaive joined #evergreen |
| 14:12 |
csharp |
ok, whew :-) |
| 14:12 |
berick |
it should send you to the angjs version |
| 14:12 |
csharp |
ok |
| 14:12 |
berick |
the ang6 version works (or it did), but had limited testing |
| 14:13 |
|
khuckins_ joined #evergreen |
| 14:13 |
csharp |
I saw it working yesterday |
| 14:13 |
berick |
csharp: i suggest goign to the angjs version to registring there |
| 16:36 |
|
annieslmaos joined #evergreen |
| 16:38 |
|
Connection joined #evergreen |
| 16:42 |
|
mmorgan1 joined #evergreen |
| 16:56 |
csharp |
ok - progress on Ubuntu 18.04/newer ejabberd - the problem revealed after enabling debug logging in ejabberd showed "<<"<stream:error><policy-violation xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>Use of STARTTLS required</text></stream:error>">>" |
| 16:57 |
|
jvwoolf left #evergreen |
| 16:57 |
csharp |
so then as a test I set "starttls_required: false" in ejabberd.yml and it let opensrf start |
| 16:58 |
berick |
csharp: i assume you've seen bug # 1703411 |
| 16:58 |
berick |
er bug 1703411 |
| 16:58 |
pinesol |
Launchpad bug 1703411 in OpenSRF "OpenSRF: XMPP Non-SASL auth is being phased out" [Medium,Confirmed] https://launchpad.net/bugs/1703411 |
| 17:03 |
berick |
will take some coding to get the sasl stuff going |
| 17:04 |
berick |
the other Perl jabber libs have code we can steal |
| 17:04 |
berick |
i'm sure there's C stuff out there somewhere |
| 17:06 |
csharp |
I guess for a test server running on a laptop or just not exposed to the WWW it would probably be fine to disable starttls? |
| 17:07 |
csharp |
I don't want the install instructions to recommend anything foolhardy |
| 17:07 |
|
Guest95742 joined #evergreen |
| 17:08 |
berick |
csharp: well, it's the same as what we're doing now |
| 17:10 |
berick |
whether or not we want to do that is a question we have to decide, of course, but the 2 changes you made are identical to how ejabberd has always been used by EG. |
| 17:16 |
|
mmorgan1 left #evergreen |
| 17:27 |
|
nikow2 joined #evergreen |
| 17:40 |
bshum |
csharp: It let OpenSRF start with starttls_required: false ? Interesting... did you actually get math to start though? |
| 17:41 |
bshum |
I got as far as seeing most of OpenSRF start up, but math still failed to start |
| 17:41 |
bshum |
So I couldn't complete a proper test run |
| 17:41 |
bshum |
I'll retest it on my new 18.04 VM later |
| 17:42 |
|
DLange2 joined #evergreen |
| 17:44 |
|
abian0 joined #evergreen |
| 17:48 |
bshum |
Right, dbmath and math fail to start, even with the options set for me the way you describe. That matches my current experiences so far with 18.04 |
| 17:50 |
|
Tourist12 joined #evergreen |
| 17:52 |
berick |
bshum: what about perl services? |
| 17:53 |
bshum |
berick: Those seem to be alive. I haven't installed the rest of Evergreen cause there's some dependency issues I think |
| 18:06 |
bshum |
Maybe |
| 18:06 |
bshum |
But the osrfsys.log does give me a bunch of ejabberd error noise |
| 18:06 |
bshum |
So I don't know if it's really respecting the options we asked it to use when switching to legacy auth |
| 18:10 |
pastebot |
"bshum" at 64.57.241.14 pasted "startup logs from 18.04 test server" (321 lines) at http://paste.evergreen-ils.org/13899 |
| 18:11 |
* bshum |
wanders off to dinner, will compare notes with csharp and folks later |
| 18:32 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
| 18:56 |
|
lutoma11 joined #evergreen |
| 19:18 |
csharp |
bshum: yeah math and dbmath aren't running :-/ |
| 19:43 |
|
annieslmaos joined #evergreen |
| 00:06 |
|
foxcookie3 joined #evergreen |
| 04:45 |
|
orb joined #evergreen |
| 05:27 |
|
channels joined #evergreen |
| 06:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:02 |
|
agoben joined #evergreen |
| 07:03 |
|
bsanford joined #evergreen |
| 07:04 |
|
JBoyer joined #evergreen |
| 08:25 |
JBoyer |
kmlussier, I wouldn't think that should be an issue on initial registration though? I don't have one handy at work anymore but if someone can get one hooked up to a Mac and pull the console logs that should make the problem easy to spot. |
| 08:25 |
kmlussier |
JBoyer: No, actually, I think I'm confusing it with something else. |
| 08:25 |
JBoyer |
I can try to remember to use mine at home to see what's going on. |
| 08:26 |
kmlussier |
There was something I was testing recently where workstation registration was not working correctly. I thought it was that patch, but I misremembered. |
| 08:26 |
JBoyer |
Oh, was that the local -> server settings branch, maybe? |
| 08:26 |
JBoyer |
(Obviously not their problem, but I thought I'd heard something about it too) |
| 08:27 |
kmlussier |
JBoyer: Yes, that's the one. So it's totally unrelated. |
| 10:13 |
Dyrcona |
bshum++ |
| 10:13 |
bshum |
Yes what Dyrcona says, basically the non-SASL auth is not a choice |
| 10:13 |
bshum |
And setting the "legacy" auth options in ejabberd config did nothing for me too |
| 10:13 |
csharp |
bshum++ |
| 10:13 |
csharp |
thanks - I'll do some digging on that today |
| 10:14 |
csharp |
also planning to test Angular 6 stuff (finally) |
| 10:14 |
csharp |
JBoyer: I haven't forgotten about Firefox Hatch - just not getting to it :-/ |
| 10:15 |
csharp |
I made the mistake of waiting too long and now I'll need to relearn things I knew in April/May |
| 10:15 |
|
rlefaive joined #evergreen |
| 10:16 |
JBoyer |
csharp++ |
| 10:16 |
* Dyrcona |
suspects we'll have it working on Ubuntu 18.04 in time for Ubunut 20.04. :) |
| 10:44 |
berick |
excellent |
| 10:45 |
kmlussier |
berick: I just added a comment to the bug. There were conflicts when trying to backport it to 3.0, and I'm not comfortable with resolving them. Would you be able to take a look? |
| 10:45 |
berick |
kmlussier: yes, can do |
| 10:48 |
csharp |
berick: building angular6 branch - is it better for testing to build in dev or prod mode? (or does it matter?) |
| 10:48 |
berick |
csharp: dev mode is good for testing, especially if you want to experiment with code changes |
| 10:48 |
berick |
(in --watch mode) |
| 10:48 |
csharp |
ok - will do |
| 10:49 |
idjit |
i've been poking around in some of the angular6 stuff as well. i'm still trying to learn my way around, but is there anything useful i can be doing? |
| 10:50 |
berick |
idjit: the main goal for now is making sure the app in general can be used alongside the angularjs app. and that simple things like authentication, navigation, etc. generally work as expected. |
| 10:50 |
berick |
csharp: idjit: as a reminder, log out or clear cookies if you previously used the angularjs app on your test client. the cookie path changes for auth tokens. |
| 10:51 |
* berick |
should probably add a auto-migration step for that |
| 10:52 |
idjit |
noted, thank you. |
| 10:52 |
idjit |
berick++ |
| 11:02 |
JBoyer |
kmlussier++ |
| 13:02 |
|
dpearl joined #evergreen |
| 13:04 |
|
Carlos061113 joined #evergreen |
| 13:05 |
|
and0 joined #evergreen |
| 13:08 |
csharp |
berick: ok, finally in, but basically everywhere I go is pointing back to angularJS pages - is there something I should test? |
| 13:10 |
csharp |
nm - I see your response to idjit earlier... |
| 13:12 |
|
nfburton joined #evergreen |
| 13:12 |
csharp |
so far so goo |
| 13:12 |
csharp |
d |
| 13:12 |
berick |
csharp: awesome. the ang6 stuff is the experimental catalog and admin -> server admin |
| 13:13 |
berick |
and change operator |
| 13:13 |
csharp |
berick: so how do I get to those? (might be missing something obvious) |
| 13:19 |
berick |
huh, that's not an error I recall seeing |
| 13:20 |
pastebot |
"idjit" at 64.57.241.14 pasted "ERROR TypeError: Cannot read p" (11 lines) at http://paste.evergreen-ils.org/13885 |
| 13:22 |
berick |
thanks idjit |
| 13:22 |
idjit |
if it only happens on my test install, i'm willing to bet i goofed it up, rather than anything actually being broken. |
| 13:22 |
berick |
related to newest code... idjit what's your URL path? |
| 13:22 |
idjit |
https://egdev1.grpl.org/eg2/staff/splash |
| 13:23 |
berick |
idjit: try https://egdev1.grpl.org/eg2/en-US/staff/splash |
| 14:04 |
|
collum joined #evergreen |
| 14:04 |
* Dyrcona |
shrugs. |
| 14:05 |
|
collum joined #evergreen |
| 14:06 |
csharp |
berick: I'm really keen on this making it into 3.2... what sort of testing rigor do you think is needed for that? So far, everything I'm doing works without trouble - not testing super deeply, but UIs are loading fine, etc. |
| 14:08 |
berick |
csharp: great, i've been giving it a good workout too, so I'm also pretty confident merge-safe. I probably need to roll back a few changes to be absolutely safe, though. |
| 14:08 |
csharp |
legacy angular UIs work fine too |
| 14:08 |
csharp |
ok |
| 14:08 |
berick |
e.g. the server admin page needs a ton of testing if we're going to use it now. I turned it on for testing/review, but we probably don't want to replace that UI wholesale |
| 14:08 |
csharp |
right, I think having it available with a fallback is ideal |
| 14:09 |
berick |
i could roll that switch back, then re-deploy to master after 3.2 |
| 14:09 |
berick |
I suspect we'll want to hide the experimental catalog for 3.2 as well |
| 14:14 |
berick |
Dyrcona: you read my mind |
| 14:14 |
csharp |
ugh - I'm gonna miss most of the dev meeting - my daughter's school pickup collides with that timeslot |
| 14:14 |
berick |
heh, found a bug I just created in the admin UI's. /me fixes |
| 14:15 |
Dyrcona |
Speaking of finding bugs...Tests I wrote for a new feature actually found a bug in my code. |
| 14:15 |
Dyrcona |
I thought about signing into IRC on Sunday just to say, "Yay, tests!" |
| 14:16 |
kmlussier |
tests++ |
| 14:28 |
* JBoyer |
won't be here for the meeting either. |
| 14:29 |
JBoyer |
Though I'm +1 for including ang6 in 3.2. The more dojo admin interfaces removed, the better. |
| 14:30 |
|
collum joined #evergreen |
| 14:32 |
|
nfburton joined #evergreen |
| 14:33 |
nfburton |
Quick Q - Trying to find the setting for default OPAC OU. It defaults to Consortium instead of System right now. I changed it on my test server but can't seem to find the setting again |
| 14:35 |
Dyrcona |
nfburton: Do you mean for a user or for a domain? |
| 14:36 |
nfburton |
When not signed in, the default for the opac. |
| 14:38 |
csharp |
nfburton: do you mean having the OPAC default to a particular library? |
| 14:41 |
Dyrcona |
yeah, locg should get passed around once set. If you find a page where it gets dropped, that's likely a bug. |
| 14:42 |
nfburton |
SetEnv physical_loc 127 - Thats what I am looking for! |
| 14:43 |
nfburton |
Which file is that in? |
| 14:43 |
berick |
csharp: mind adding a simple comment to bug 1775466 re: your testing? |
| 14:43 |
pinesol |
Launchpad bug 1775466 in Evergreen "Angular6 Base Application" [Undecided,New] https://launchpad.net/bugs/1775466 - Assigned to Bill Erickson (berick) |
| 14:43 |
Bmagic |
if you just have one domain, then probably eg.conf |
| 14:44 |
* Dyrcona |
switches to the laptop for the remainder of the day. BRB. |
| 15:04 |
gmcharlt |
csharp: did that happen? |
| 15:05 |
Dyrcona |
csharp may not be here. He said earlier he has a schedule conflict. |
| 15:05 |
berick |
i think csharp said he'd be missing the meeting |
| 15:05 |
gmcharlt |
ah, OK |
| 15:05 |
gmcharlt |
so, next was in regards to OpenSRF 3.0.2 |
| 15:05 |
gmcharlt |
and since testing for bug 1774703 in production has not been promising, and it looks like we'll likely be changing websocket servers, no bugfix release |
| 15:05 |
pinesol |
Launchpad bug 1774703 in OpenSRF "Websockets processes locked at 100% CPU" [Undecided,Confirmed] https://launchpad.net/bugs/1774703 |
| 15:06 |
gmcharlt |
but I have issued a call for roadmap entries for OpenSRF 3.1 today |
| 15:06 |
berick |
gmcharlt++ |
| 15:14 |
Dyrcona |
:) |
| 15:14 |
berick |
that may mean pushing back the feature freeze, but I was going to see how things go |
| 15:14 |
kmlussier |
I'm always in favor of later feature freeze deadlines. :) |
| 15:15 |
berick |
:) one in the plus column there |
| 15:16 |
berick |
and finally, csharp had some good luck testing the ang6 code today |
| 15:16 |
gmcharlt |
cool |
| 15:16 |
berick |
there's some momentum toward including it in 3.2 |
| 15:16 |
berick |
if we do, we need to decide soon what in the 3.2 code should be available to staff |
| 15:16 |
berick |
so we can test those bits specifically |
| 15:16 |
berick |
we're limited to some admin UI's at this point |
| 15:17 |
Dyrcona |
Is it all of the admin uis or just some of them? |
| 15:17 |
berick |
also, good everyone understands that means adding a new build step when installing from source. |
| 15:17 |
miker |
I'd prefer just dojo-replacing code ATM (and infrastructure and static-ish pages) |
| 15:18 |
kmlussier |
+1 |
| 15:18 |
berick |
it's about 2/3 of the server->admin pages and acq admin pages |
| 15:18 |
berick |
i can propose a list of pages to thumbs up/down if that helps |
| 15:18 |
Dyrcona |
I can probably arrange some testing of those soon, even though I'll be out most of next week. |
| 15:18 |
berick |
then we can test them |
| 15:19 |
berick |
ok, so I'll get the ang6 branch into final merge-able state and.. |
| 15:20 |
berick |
put together a list of admin UI's that should be suitable for using in 3.2 as replacements for the dojo versions. |
| 15:20 |
berick |
that will also mean modifying the links in the angjs app to point to the same new UI's |
| 15:21 |
berick |
otherwise, re: 3.2, we've closed a few more blockers in the past ~week |
| 15:21 |
Dyrcona |
berick++ |
| 15:22 |
berick |
and of course, those are not bound by the feature slush, but sooner the better, obviously |
| 15:22 |
berick |
any questions for me? |
| 15:29 |
Dyrcona |
It also does no good to keep XUL if much of it is broken. |
| 15:30 |
miker |
the biggest "breakage" AFAIK is copy alert msg vs alert matrix |
| 15:30 |
miker |
but that's a known quantity |
| 15:30 |
kmlussier |
In any case, I would be willing to take an action item to test any webstaffblockers with a pullrequest. |
| 15:31 |
kmlussier |
There are a couple of bugs there without pullrequest tags that I know are big concerns for our libraries. |
| 15:32 |
berick |
if anyone can describe a way to reproduce bug 1724029, i'll happily fix that one. |
| 15:32 |
pinesol |
Launchpad bug 1724029 in Evergreen "Web Client: Patron Search sorted by last name not working as expected" [High,Confirmed] https://launchpad.net/bugs/1724029 |
| 15:32 |
berick |
or give me SSH access to their prod servers! |
| 15:38 |
kmlussier |
berick: Of course! :) |
| 15:40 |
gmcharlt |
so... I think it's fair to say that we have an open question - but one that maybe we can punt until closer to release? |
| 15:40 |
|
rlefaive joined #evergreen |
| 15:41 |
berick |
my only request is the XUL removal code be merged by beta cutting day (1 month from today) so it can get some real testing |
| 15:41 |
berick |
so ideally decide then-ish |
| 15:41 |
gmcharlt |
sounds like a plan, or a guideline, anyway |
| 15:42 |
gmcharlt |
any other questions regarding 3.2? |
| 15:42 |
gmcharlt |
or any questions or updates regarding maintenance releases? |
| 15:46 |
gmcharlt |
#info Dyrcona would like eyes on the patch for bug 1780660 |
| 15:46 |
pinesol |
Launchpad bug 1780660 in Evergreen "Add More Workstation Functions to OpenILS::Utils::TestUtils" [Wishlist,Confirmed] https://launchpad.net/bugs/1780660 |
| 15:46 |
gmcharlt |
Dyrcona: any comments to add? |
| 15:46 |
Dyrcona |
Just a bit of me being selfish and cleaning up some test code. |
| 15:47 |
Dyrcona |
When writing Perl tests recently, I noticed we had at least 3 different implementations of code to add workstations for testing. |
| 15:47 |
Dyrcona |
So, thought I'd come up with a single version of the necessary functions and add them to TestUtils. |
| 15:47 |
gmcharlt |
Dyrcona++ |
| 15:48 |
miker |
+1 |
| 15:48 |
Dyrcona |
I'm also using the changes in the tests in my working branch, so I'd like the changes to go in before I rebase. |
| 15:48 |
Dyrcona |
Should be simple to test. Just check out the branch cd to perlmods and run make livecheck |
| 15:49 |
Dyrcona |
I rebased the branch after someone updated a test this week, too. |
| 15:49 |
kmlussier |
Dyrcona++ |
| 15:50 |
* miker |
is willling to simply push it having read the commit |
| 15:50 |
Dyrcona |
So, that's my shameless plug. :) |
| 15:57 |
miker |
it would keep someone from accidentally implementing a similar bug |
| 15:57 |
gmcharlt |
but that part can be reserved for OpenSRF 3.1 IMO |
| 15:57 |
miker |
but requires tighter coordination between EG and OSRF |
| 15:58 |
abneiman |
regarding things in need of testing, several cataloging bugs have PRs -- bug 1732761 bug 1675882 bug 1739460 bug 1739286 -- a couple of which are flagged as blockers |
| 15:58 |
Dyrcona |
OK. I'll see about having a look at it. |
| 15:58 |
pinesol |
Launchpad bug 1732761 in Evergreen "Web Client - When adding vols/copies to multiple branches, circ library does not populate" [High,Confirmed] https://launchpad.net/bugs/1732761 |
| 15:58 |
pinesol |
Launchpad bug 1675882 in Evergreen "webclient: adding individual copies defaults circ OU to workstation OU" [Medium,Confirmed] https://launchpad.net/bugs/1675882 |
| 16:01 |
berick |
awesome |
| 16:01 |
kmlussier |
miker++ |
| 16:01 |
Dyrcona |
Speaking of the omnibus, should that be backported to 3.0? |
| 16:01 |
Dyrcona |
We've tested it here with 3.0.10 and it works. There's a conflict, but I know how to resolve it. |
| 16:02 |
miker |
berick: checking the other ... Dyrcona: I'm for it |
| 16:02 |
abneiman |
+1 to backporting omnibus |
| 16:02 |
berick |
miker: bug 1739460 too please, unclear what to merge |
| 16:05 |
miker |
so... maybe it doesn't hurt to merge? |
| 16:06 |
berick |
that would be user/miker/lp-1739460-all-relevant-locations ? |
| 16:06 |
miker |
berick: yessir |
| 16:06 |
berick |
OK, i can merge that, I've already tested it once |
| 16:06 |
* berick |
grabs |
| 16:07 |
gmcharlt |
and.. that takes us past the hour |
| 16:07 |
gmcharlt |
thanks, folks! |
| 16:07 |
gmcharlt |
#endmeeting |
| 17:46 |
berick |
yeah, all renewals were used up. possibly staff didin't have perm to extend renewal count, but did have perm to change due date. *shrug*. |
| 17:47 |
berick |
in any event, i think it's reasonable to assume max fines is a hard limit on a circ |
| 18:03 |
miker |
seems fair |
| 18:31 |
pinesol |
News from qatests: Failed Running Evergreen browser client build/test - Expected 6 errors but encountered 7. <http://testing.evergreen-ils.org/~live> |
| 18:37 |
|
Levex joined #evergreen |
| 18:56 |
|
BigRig joined #evergreen |
| 18:56 |
|
foobarrel joined #evergreen |
| 05:25 |
|
berndj8 joined #evergreen |
| 05:37 |
|
mquin6 joined #evergreen |
| 05:52 |
|
mdroid joined #evergreen |
| 06:30 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 06:42 |
|
Dyrcona joined #evergreen |
| 06:54 |
|
Dyrcona joined #evergreen |
| 07:02 |
|
yar joined #evergreen |
| 09:11 |
|
rlefaive joined #evergreen |
| 09:12 |
collum |
Dyrcona: In my case I was updating my nick registration at freenode. |
| 09:13 |
Dyrcona |
:) |
| 09:14 |
Dyrcona |
And, I'm getting an Internal Server Error when viewing individual records on my test vm.... |
| 09:14 |
Dyrcona |
I should check training, 'cause they're almost the same code. |
| 09:14 |
Dyrcona |
Guess I know what I'm doing this morning. |
| 09:16 |
|
rlefaive joined #evergreen |
| 13:34 |
kipd |
Fair enough. I'll go back and figure out what I skipped. Thanks. |
| 13:35 |
csharp |
kipd: we're happy to help here if you get stuck |
| 13:37 |
berick |
kipd: i don't have oils_header.pl in my bin dir. manually copying it there, if that's where you run the scripts, is reasonable. |
| 13:38 |
kipd |
It's related to AADL getting back into MeLcat, we're using iNCIPit.cgi and some of their tests are bombing on our system and after stepping through with their POST data in the Perl debugger, it turned out it eventually wanted to call.... |
| 13:38 |
kipd |
https://www.irccloud.com/pastebin/AiTrqY1K/ |
| 13:39 |
berick |
yeah, copy the file wherever you need it |
| 13:39 |
kipd |
So that's why I copied from the tarball. |
| 13:39 |
berick |
looks like the install doesn't touch it |
| 15:34 |
csharp |
interesting problem - as the admin user, I can see all the EDI messages generated for a PO, but as a local Acq administrative user, I can only see ORDRSP, not ORDERS messages |
| 15:34 |
csharp |
acq admin users have ADMIN_PROVIDER MANAGE_PROVIDER VIEW_PROVIDER perms (which are referenced in fm_IDL.xml) |
| 15:35 |
|
KobrAs4 joined #evergreen |
| 15:35 |
berick |
csharp: you confirmed testing the same PO? |
| 15:35 |
csharp |
I see <context link="account" jump="provider" field="owner"/> |
| 15:35 |
kmlussier |
berick: Sigh.../standalone/list.txt does not exist, probably because I just built the VM today and none of the Concerto users are blocked yet? |
| 15:36 |
csharp |
berick: I've tested the PO that was reported to me, both in the client and via srfsh |
| 15:36 |
* kmlussier |
has a sudden feeling of deja vu stemming from the original offline testing she did last year. |
| 15:37 |
berick |
kmlussier: yeah, that's likely it. plus the default cron job (assuming it's installed) usually runs once over night. |
| 15:37 |
csharp |
kmlussier: you can copy a list.txt from a production server if that helps |
| 15:37 |
berick |
kmlussier: it's trivial to create one, though, if you want to test |
| 15:37 |
kmlussier |
berick: Yes, I think that's it. The cron job hasn't run yet. |
| 15:37 |
berick |
or what csharp said |
| 15:37 |
csharp |
and truncate it down to a manageable size |
| 15:37 |
kmlussier |
OK, will do. I can copy the ones from my other test servers. There are only a few barcodes there. |
| 15:38 |
csharp |
in the <context> above, what are "link", "jump", and "field"? I can intuit link and field a little, but "jump"? |
| 15:39 |
berick |
csharp: jump means there's an intermediate object |
| 15:39 |
csharp |
ah |
| 17:45 |
|
sjohnson7 joined #evergreen |
| 17:46 |
|
khuckins joined #evergreen |
| 17:53 |
csharp |
berick++ |
| 18:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 19:19 |
|
barbietoss joined #evergreen |
| 19:45 |
|
Dworf joined #evergreen |
| 21:24 |
|
MuffinMedic24 joined #evergreen |
| 03:34 |
|
Miklo19 joined #evergreen |
| 03:41 |
|
Smeef6 joined #evergreen |
| 03:42 |
|
Michail1 joined #evergreen |
| 06:30 |
pinesol_green |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 07:14 |
|
rjackson_isl joined #evergreen |
| 07:16 |
|
rlefaive joined #evergreen |
| 07:19 |
|
agoben joined #evergreen |
| 10:18 |
berick |
kmlussier: there was also a dupe setting. fixes pushed. confirmed base schema / data installs OK now. |
| 10:18 |
kmlussier |
berick: Great, thanks! |
| 10:18 |
kmlussier |
berick++ |
| 10:20 |
* berick |
should test both versions of the sql |
| 10:20 |
berick |
i did re-run the pgtap test and it's still happy |
| 10:21 |
Dyrcona |
Crazy.... |
| 10:21 |
Dyrcona |
My crazy is a propos something else... :) |
| 10:22 |
kmlussier |
berick: I'm reinstalling the VM, but I realize why you had that dupe setting. I have mentioned that the checkout strict barcode setting hadn't been added. It looks like you added checkin strict barcode instead of checkout. |
| 10:23 |
kmlussier |
s/have/had |
| 10:24 |
berick |
kmlussier: dang. adding checkout version now |
| 10:25 |
* berick |
rebuilds DB |
| 10:27 |
berick |
fix pushed |
| 10:27 |
berick |
build completed |
| 10:28 |
berick |
we now have 4 strict barcode settings |
| 10:28 |
berick |
kmlussier: i'm happy to squash those, but I don't know if it will mess up your testing |
| 10:28 |
kmlussier |
berick++ |
| 10:29 |
kmlussier |
berick: No, it won't mess it up. |
| 10:29 |
JBoyer |
It will be nice to be able to disable all of those at once. The only time we hear about those settings here is when someone accidentally turns one one. (we don't have CODABAR everywhere) |
| 11:30 |
Dyrcona |
@who granted half-op to pinesol_green |
| 11:30 |
pinesol_green |
drigney granted half-op to pinesol_green. |
| 11:31 |
jeff |
Dyrcona: agreed. |
| 11:32 |
csharp |
berick: running 'npm run test' after pulling in your changes on the DB ws settings branches is failing for me |
| 11:32 |
berick |
wee, thanks csharp, looking |
| 11:32 |
csharp |
berick: https://pastebin.com/Y704FHdV |
| 11:33 |
berick |
the hunt is on.. |
| 11:43 |
* berick |
will be porting 1750894 to ang6 soon |
| 11:44 |
kmlussier |
bug 1750894 |
| 11:44 |
pinesol_green |
Launchpad bug 1750894 in Evergreen "Wishlist: Store web staff workstation settings on the server" [Wishlist,New] https://launchpad.net/bugs/1750894 - Assigned to Kathy Lussier (klussier) |
| 11:44 |
berick |
kmlussier: in case you're not following closely, just pushed a unit test fix to the settings branch |
| 11:45 |
kmlussier |
berick: Saw it. I was briefly distracted by alternate name testing, but I'm returning to that branch now. |
| 11:45 |
kmlussier |
So many things to test. |
| 11:46 |
Dyrcona |
kmlussier++ |
| 11:46 |
berick |
kmlussier++ # indeed |
| 11:56 |
csharp |
heh - I've wanted to do that for a long time |
| 12:29 |
kmlussier |
bug 1750894 looks good to me. I can sign off after I get some lunch. |
| 12:29 |
pinesol |
Launchpad bug 1750894 in Evergreen "Wishlist: Store web staff workstation settings on the server" [Wishlist,New] https://launchpad.net/bugs/1750894 - Assigned to Kathy Lussier (klussier) |
| 12:44 |
|
sandbergja joined #evergreen |
| 13:08 |
csharp |
kmlussier: agreed |
| 13:08 |
csharp |
kmlussier++ |
| 13:09 |
csharp |
I didn't really test migration though |
| 13:09 |
csharp |
but if you're good, I'm good :-) |
| 13:09 |
|
jvwoolf1 joined #evergreen |
| 13:11 |
kmlussier |
csharp: Do you want to add a signoff too or should I just merge it? |
| 13:11 |
csharp |
kmlussier: go for it! |
| 15:03 |
pinesol |
csharp: The operation succeeded. Dunno #59 added. |
| 15:04 |
berick |
jeff: sup? |
| 15:04 |
|
sandbergja joined #evergreen |
| 15:05 |
jeff |
berick: see my comment. looking for a concise test case for what you encountered that disqualified mod_remoteip as an option. mod_rpaf upstream seems defunct. |
| 15:05 |
jeff |
(it's still packaged, but it's starting to smell) |
| 15:06 |
berick |
jeff: ugh, well, remoteip didn't update the value in request_rec->connection->client_ip when I tested it. |
| 15:06 |
berick |
used by the translator C code |
| 15:06 |
miker |
berick: to clarify from your email, when you say "org setting" in the "Admins" section, are you referring to YAOUSen? and the fallthrough is in the direction of "look up a missing user setting, get the YAOUS", but not the other way (ever), right? |
| 15:06 |
berick |
miker: yes to YAOUSen (heh) |
| 15:07 |
berick |
and yes, if a user/ws setting type does not exist, see if an org setting type does and use its value instead |
| 16:39 |
|
khuckins joined #evergreen |
| 17:20 |
|
khuckins_ joined #evergreen |
| 17:43 |
|
khuckins joined #evergreen |
| 18:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 18:40 |
|
balrog27 joined #evergreen |
| 18:54 |
|
Freejack19 joined #evergreen |
| 19:05 |
bshum |
Well, that's not a good sign jeff |
