01:02 |
|
yar joined #evergreen |
01:14 |
|
yar joined #evergreen |
01:21 |
|
sandbergja joined #evergreen |
05:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:02 |
|
agoben joined #evergreen |
07:37 |
|
JBoyer joined #evergreen |
07:38 |
|
bdljohn left #evergreen |
09:24 |
Dyrcona |
So, I'm being asked to make an Opac Icon Format and Search Format from a RDA field value. Can that even be done? The only examples I've seen so far come from MARC fixed fields. |
09:28 |
Dyrcona |
I guess that is possible.... |
09:28 |
JBoyer |
You can do it, I've added a bunch here based on the 753 (for gaming systems) |
09:29 |
Dyrcona |
JBoyer: Yeah, I just found it in the documentation, which tells me how to do it in the client. I would rather something that I can do in the database, but I can always set it up on a test server and extract the new table entries. |
09:30 |
JBoyer |
Yeah, those tables are not things you want to be messing with by hand. Your plan should be fine though. |
09:31 |
JBoyer |
Getting them to actually show up will pretty much require tearing down and rebooting all of your memcache servers though, so that's a lot of fun. |
09:31 |
nfBurton |
Yup mine have sometimes taken 2 weeks to show |
09:43 |
JBoyer |
Yeah, I think the nls stuff returning a 404 is expected. |
09:43 |
Dyrcona |
Those links won't work for anyone but me, btw. The host name is set in my hosts files to point to a 10. non-routeable IP address. |
09:57 |
Dyrcona |
So, before I try this on a different server. I'm going to try fixing my broken one. |
09:57 |
Dyrcona |
After all, this was meant to be a test of the upgrade and if the Admin interface is broken in this branch, well, that's no good. |
10:14 |
|
nfBurton joined #evergreen |
10:18 |
Dyrcona |
Nope. Still getting the 400 bad request. Is there a patch I missed? |
10:22 |
Dyrcona |
Don't see anything in Evergreen and I'm using the latest OpenSRF rel_3_1..... |
10:44 |
Dyrcona |
Thanks, again.... That would have taken me another hour before I realized that setting was the problem. |
11:05 |
|
jihpringle joined #evergreen |
11:24 |
Dyrcona |
Can you export cataloging copy templates from the web staff client? Can you import cataloging copy templates into the web staff client? |
11:26 |
mmorgan |
Dyrcona: The import and export buttons are on the screen in the web client, so yes. I haven't personally tested it to see what happens, though. |
11:26 |
jihpringle |
Drycona: yes, to both |
11:26 |
Dyrcona |
Thanks, mmorgan and jihpringle |
11:27 |
jihpringle |
last time we tested with importing though (which was a while ago) we ran into weirdness caused by copy template bugs |
11:27 |
jihpringle |
I haven't tested since a bunch of those bugs were fixed |
11:27 |
jeff |
unlike in the xul client, where you can import/export from the item attribute editor, you need to select the "Copy Templates" tab in the volcopy editor to see the import/export options. |
11:32 |
Dyrcona |
Switching topics back to search filters, because it is that kind of morning. |
11:32 |
Dyrcona |
So, before I can add a "4K Ultra HD" filter with a composite definition, I need to add something to make "4K Ultra HD" show up as something that the composite definition will understand? |
16:14 |
Bmagic |
and look, it's in the upgrade script |
16:24 |
Bmagic |
I have to say, I'm digging it |
17:00 |
jeffdavis |
There is an open question on bug 1822875 about whether MARC 245 subfields are intentionally suppressed when using display fields. Is anyone who was involved in that development able to address that? |
17:00 |
pinesol |
Launchpad bug 1822875 in Evergreen "OPAC titles are truncated when query string present" [Undecided,Confirmed] https://launchpad.net/bugs/1822875 |
17:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:02 |
jeffdavis |
I have the impression that display fields intentionally don't include 245 $c, $h etc. which is creating some confusion. |
17:06 |
mmorgan |
Just a parting thought on that - it caused confusion that the 245 $c appeared when following a permalink to a record, but not when the record was retrieved as a result of a search. |
17:07 |
* mmorgan |
disappears but will check IRC logs later :) |
00:20 |
|
sandbergja joined #evergreen |
05:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:01 |
|
agoben joined #evergreen |
07:11 |
|
Dyrcona joined #evergreen |
07:15 |
|
rjackson_isl joined #evergreen |
07:16 |
Dyrcona |
@later tell mmorgan Closer examination reveals that I misspoke yesterday. The user's web staff templates were actually the XUL fromat, except for the "JUVINILE" one, which she says she didn't create. When I look at a test database with data that's a couple of weeks old, the web staff copy templates look OK for this user, but the "JUVINILE" template is there, too. |
07:16 |
pinesol |
Dyrcona: The operation succeeded. |
08:10 |
|
littlet joined #evergreen |
08:18 |
|
collum joined #evergreen |
08:40 |
|
bos20k joined #evergreen |
08:43 |
|
mmorgan joined #evergreen |
08:52 |
Dyrcona |
So, thanks to multiple copies of production data on a test db server, I have a rough timeline for when the copy templates got borked: between March 30 and April 7. |
08:52 |
Dyrcona |
So, I have a date range for checking server logs. |
08:56 |
|
remingtron joined #evergreen |
08:57 |
|
dkyle joined #evergreen |
13:01 |
Dyrcona |
gitolite++ # For rejecting an errant push to origin |
13:01 |
Dyrcona |
git++ |
13:32 |
|
yboston joined #evergreen |
13:49 |
stephengwills |
whats the fastest way to verify that evergreen is sending emails…. I tested the underlying ssmtp and it’s working fine. |
13:50 |
stephengwills |
can I fire off a test via srfsh, for instance? |
13:53 |
Dyrcona |
stephengwills: Not really, there's no test email method. You'd have to run the action trigger runner for something that will send an email. |
13:53 |
stephengwills |
ok thanks |
13:54 |
Dyrcona |
If the server can send email, the chances are that Evergreen can, too. |
13:54 |
stephengwills |
nod. I made a little test script and it worked find using php mail(); |
13:55 |
stephengwills |
I assumed if that worked PERL would too |
13:55 |
Dyrcona |
Yes, it should. |
13:59 |
sandbergja |
DIG meeting coming up in one minute |
14:02 |
sandbergja |
remingtron: would you mind handling the meetbot piece of this meeting? I've misplaced my meetbot cheat sheet. |
15:03 |
remingtron |
dluch++ |
15:04 |
|
mmorgan1 joined #evergreen |
15:31 |
|
sandbergja_ joined #evergreen |
15:54 |
dbwells |
phasefx++ # bib merge test fix |
15:58 |
pinesol |
[evergreen|Dan Wells] Forward port 3.3.0 upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=4e73848> |
15:58 |
Bmagic |
dbwells++ # git 3.3.0 |
16:03 |
|
khuckins joined #evergreen |
17:08 |
pinesol |
Launchpad bug 1821196 in Evergreen "De-arrow-ify item status js" [Undecided,New] https://launchpad.net/bugs/1821196 |
17:11 |
berick |
oh, good, sandbergja++ |
17:15 |
|
jamesrf joined #evergreen |
17:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:38 |
pinesol |
[evergreen|Jane Sandberg] LP1821196: Remove arrow function from item status - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0f95053> |
17:55 |
|
aabbee left #evergreen |
17:55 |
|
aabbee joined #evergreen |
18:11 |
|
stephengwills joined #evergreen |
20:53 |
|
jamesrf joined #evergreen |
21:16 |
|
sandbergja joined #evergreen |
22:36 |
|
Dyrcona joined #evergreen |
23:25 |
pinesol |
[evergreen|Dan Scott] Docs: fix uneven lengths of code delimiter blocks - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a992137> |
05:01 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-10T04:57:30,421235597-0400 -0> |
07:08 |
|
rjackson_isl joined #evergreen |
07:41 |
|
stephengwills joined #evergreen |
08:18 |
|
bos20k joined #evergreen |
11:13 |
sandbergja |
I'll see what I can find out! |
11:14 |
Bmagic |
Each has it's own hurdles, but I suspect it will work just fine |
11:15 |
sandbergja |
BMagic: I've been looking at your Google Containers slides -- do you have any documentation about the AWS version that you could share? |
11:16 |
bshum |
Bmagic: sandbergja: Fwiw, I used Azure to setup my VMs two Hack-A-Ways ago for test servers |
11:16 |
bshum |
Err, bug squashing weeks |
11:16 |
bshum |
Not Hackaways |
11:17 |
bshum |
But it's basically like any other cloud hosting option |
11:17 |
sandbergja |
bshum++ |
11:17 |
bshum |
I was using it cause I had some free credits from my Visual Studio subscription |
11:17 |
bshum |
And also to learn their platform |
12:41 |
pinesol |
Launchpad bug 1824184 in OpenSRF "Change potentially slow log statements to subroutines" [Undecided,New] https://launchpad.net/bugs/1824184 |
12:41 |
bos20k |
Dyrcona++ |
12:41 |
bos20k |
phasefx++ |
12:46 |
pinesol |
[evergreen|Jason Etheridge] lp1145213 avoid race condition in bib merge test - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bbe8a92> |
12:52 |
|
yboston joined #evergreen |
12:58 |
* mmorgan |
is wondering if a Best-Hold selection sort order can help with this situation: |
12:58 |
mmorgan |
Library A's book is popular at Library B and always has holds for pickup there. |
13:15 |
|
sandbergja_ joined #evergreen |
13:29 |
|
remingtron joined #evergreen |
14:08 |
phasefx |
bos20k++ |
14:11 |
bos20k |
phasefx: Thanks :) My change to the logger is extremely simple but gets the job done. It is very possible that there is some other really cool way to do it that would be better but this is what I found in my research and testing. |
14:20 |
miker |
mmorgan: that's the tension between "reduce transits" and "fill in order" when there are few copies of a popular title (obviously). there's no way today to say "ok, push holds older than X in front of really new holds", but I /think/ that's what you want, approximately? |
14:21 |
jeff |
"favor prox unless hold being considered is older than X" or something similar? |
14:21 |
miker |
(and, of course, "practice fair collection development" :) ) |
15:46 |
mmorgan |
Dyrcona: Just one template that looked unconverted? Other templates in the usr setting look to have been converted? |
15:46 |
Dyrcona |
Yes, and the unconverted one does not exist in the XUL templates for this user. |
15:51 |
* mmorgan |
wonders what happens if you export templates from the xul client and import them into the web client. Do they get converted when imported into the web client? |
15:54 |
Dyrcona |
Interesting... I see something similar but different on a test database that was updated a few weeks ago. |
15:54 |
Dyrcona |
None of this user's webstaff copy template were properly converted, and the JUVINILE template does not exist in the XUL templates. |
15:55 |
Dyrcona |
I'll have to do more digging to see if they are even this user's templates... |
15:59 |
Dyrcona |
Did web staff copy templates have to be converted prior to 3.0? Could be this person used the web client on 2.12. |
16:04 |
mmorgan |
Dyrcona: bug 1691269 enabled converting xul to web templates, released in 3.0.2 |
16:04 |
pinesol |
Launchpad bug 1691269 in Evergreen "web client: copy templates created on XUL not displayed" [Medium,Fix released] https://launchpad.net/bugs/1691269 |
16:05 |
|
yboston joined #evergreen |
16:30 |
|
sandbergja joined #evergreen |
17:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:04 |
|
mmorgan left #evergreen |
17:36 |
|
sandbergja joined #evergreen |
18:04 |
|
stephengwills joined #evergreen |
05:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
06:57 |
|
agoben joined #evergreen |
07:12 |
|
rjackson_isl joined #evergreen |
07:19 |
|
JBoyer joined #evergreen |
09:33 |
|
finnx left #evergreen |
09:48 |
|
sandbergja joined #evergreen |
10:17 |
|
Christineb joined #evergreen |
10:25 |
Bmagic |
berick: I tested the installer. It installs. It gracefully removes the previous version. It enables the browser extension. I set my printer to Dymo. And I printed a spine label without a margin error! (I don't have the printer anymore because it was on loan but I printed to the printer through Windows's driver) |
10:26 |
Bmagic |
At the very least: this version of Hatch can't be worse. |
10:27 |
Bmagic |
(Other than it's 214MB) |
10:27 |
berick |
:) |
16:20 |
mmorgan |
That is, can the "best hold" ever be "no hold"? |
16:22 |
mmorgan |
I've tried setting up a sort order with shtime - "Copy Has Been Home At All Lately", but it didn't send the item home. |
16:29 |
miker |
mmorgan: I don't believe there's a "skip all holds and send home even if there's no current home-hold" option. that logic is just about sorting extant holds that are eyeballing a copy, not transiting generally |
16:32 |
mmorgan |
miker: :-( Thanks. There was also a suggestion that setting a soft stalling interval might serve to get the item home rather than filling the next hold, but I tested that too, and the item wasn't sent home. |
16:33 |
mmorgan |
Is there any combination of settings in Evergreen that can accomplish getting the item back home short of placing a hold for pickup there? |
16:33 |
miker |
mmorgan: yeah, that's really just about stopping opportunistic capture. at-pickup-lib and currently-targetted holds will still capture |
16:34 |
mmorgan |
We are using holds always go home |
16:35 |
miker |
mmorgan: not that I can think of OTTOMH. I think it would be new logic that would check /before/ sorting holds to see if a copy hasn't been home "recently" (probably based on a setting, maybe the same as shtime uses now) and skips hold capture altogether (which would cause a transit home, or sticking "here" if float allows) |
16:41 |
jeff |
Dyrcona: I was wrong. I had set the setting in a way that an upgrade overwrote it, but I just hadn't noticed yet. I came to the same conclusion as you: setting in /etc/gitlab/gitlab.rb is the way to go. |
16:42 |
jeff |
Dyrcona: and the syntax is awkward mostly because of the format of the git config file... ;-) |
16:53 |
|
yboston joined #evergreen |
17:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-09T16:57:41,930899029-0400 -0> |
17:05 |
Bmagic |
Weird problem I've not ran into before. Setting up a new machine from scratch. 16.04. This file doesn't exist: "/usr/share/doc/apache2/examples/setup-instance" for the websockets step |
17:06 |
Bmagic |
I've apt-get remove --purge apache2* and reinstalled with "make -f src/extras/Makefile.install ubuntu-xenial" from the OpenSRF repo. Still doesn't create that file |
17:06 |
|
mmorgan left #evergreen |
17:50 |
Bmagic |
right? |
17:56 |
Dyrcona |
Yeah, I think you can even use 3.1 with Evergreen 3.0. |
17:57 |
Dyrcona |
The only thing you can't do is use OpenSRF 3.0+ with Evergreen 2.12 or lower. |
17:58 |
Dyrcona |
I've run relatively recent OpenSRF master with Evergreen 3.0 on a test virtual machine, and I didn't notice any problems. |
18:13 |
Dyrcona |
Bmagic: I rebased and force-pushed that rel_3_0-websocketd branch. |
18:13 |
Dyrcona |
There was a conflict in the README, but I think I resolved it so that things make sense. |
20:22 |
|
stephengwills joined #evergreen |
05:02 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
05:15 |
|
RBecker joined #evergreen |
07:05 |
|
JBoyer joined #evergreen |
07:11 |
|
agoben joined #evergreen |
14:02 |
|
yboston joined #evergreen |
14:02 |
Bmagic |
oh man, I just heard that news this morning |
14:02 |
Bmagic |
MS Edge is going to be using Chrome on the backend? Wow. |
14:03 |
bshum |
Yeah so far in my testing, it's basically Chromium with Win10 styling for the settings, etc. |
14:03 |
bshum |
And you log into your Microsoft account, rather than your Google account, etc. |
14:04 |
bshum |
Maybe my corporate overlords will be OK with letting me have this browser to replace my IE11 |
14:04 |
Dyrcona |
Google continues to eat the world. |
14:08 |
Bmagic |
Sort of blows my mind. I guess everyone agrees that Google did it right. If you can't fight em, join em. |
14:09 |
bshum |
Everyone except for those Mozilla guys ;) |
15:07 |
JBoyer |
bshum, most likely patches that make it less of a pig re: battery and ram. ;) |
15:07 |
bshum |
JBoyer: That would be nice :) |
15:08 |
JBoyer |
I didn't have especially strong feelings for Trident, but it was nice to have 3 viable engines. If Google ever stops paying Moz to be the default engine we're basically down to just one now. :/ |
16:15 |
pinesol |
[evergreen|Jane Sandberg] LP1744386: Alphabetize stat cats in volcopy attr editor - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e8f247f> |
16:46 |
|
gsams joined #evergreen |
16:50 |
|
yboston joined #evergreen |
17:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-08T16:58:19,010653406-0400 -0> |
17:09 |
|
mmorgan left #evergreen |
19:39 |
|
sandbergja joined #evergreen |
21:29 |
|
sandbergja joined #evergreen |
02:14 |
|
sandbergja joined #evergreen |
03:22 |
|
yar joined #evergreen |
05:01 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-05T04:57:49,268509913-0400 -0> |
07:04 |
|
rjackson_isl joined #evergreen |
08:17 |
|
bos20k joined #evergreen |
08:29 |
|
Dyrcona joined #evergreen |
10:21 |
Dyrcona |
miker and I agree on something! :P |
10:21 |
miker |
Dyrcona: hey, it's not /that/ uncommon ;) |
10:21 |
Dyrcona |
mker++ # For confirming my suspicion about that particular line. |
10:22 |
* miker |
suspects we could probably just sed out all lines that contain INTERNAL in opensrf... anyone needing that verbosity can probably just add targetted INFO level calls for testing... |
10:22 |
Dyrcona |
Actually, the log function could be written to take a plain string, a sub, a bare code block, well, just about anything. |
10:23 |
Dyrcona |
Setting the log level to INTERNAL is a good way to fill your hard drive. :) |
10:23 |
phasefx |
let it do Data::Dumper on anything not a string or code :) |
10:47 |
berick |
Bmagic: in your copious free time, i'd love to know if the Hatch installer linked from bug 1817932 allows you to print to your Dymos |
10:47 |
pinesol |
Launchpad bug 1817932 in Evergreen "Update Hatch Java / Javafx versions" [Undecided,Confirmed] https://launchpad.net/bugs/1817932 |
10:48 |
Bmagic |
TY!! I'm excited to try it (although I no longer have the printer physically) I do have the drivers on my Windows box though |
11:00 |
gsams |
berick: I'm about to give it a test run. |
11:04 |
berick |
gsams++ |
11:22 |
|
sandbergja joined #evergreen |
11:23 |
sandbergja |
berick: I'm trying to wrap my head around the flesher method in the Angular 7 GridColumn class |
11:35 |
berick |
cool |
11:35 |
sandbergja |
So thanks for talking it out with me! I'd been really hung up on thinking about the flesher, when there was a better way. :-) |
11:35 |
sandbergja |
berick++ |
11:51 |
gsams |
berick: Okay, so we get printing, but it won't print correctly for us. |
11:52 |
gsams |
It tries to print the spine and pocket label no matter how we set it up and we only need the spine. |
11:53 |
gsams |
Also, don't test print with it. It literally prints one character on each label from that, which was amusing. |
11:53 |
Bmagic |
It's printing though! |
11:53 |
gsams |
It is! |
11:53 |
Bmagic |
that's great |
11:53 |
gsams |
I'm very excited about that factor for sure |
11:54 |
Bmagic |
and presumabely it's printing with javafx |
11:54 |
berick |
gsams: i wonder if you should test printing "with dialog" and confirm java is using the right paper size |
11:54 |
berick |
Bmagic: yes, using javafx |
11:55 |
berick |
gsams: the spine label issue.. that sounds like a staff client problem |
11:55 |
Bmagic |
mana from heaven. Let there be Dymo printing with javafx baby! |
12:00 |
gsams |
berick: It is probably a staff client problem, but it was worth checking the label print size as it was technically incorrect for us. |
12:01 |
gsams |
The label template ignores any changes I make to it on printing. |
13:24 |
pinesol |
** <A HREF="https://cve.mitre.org/about/faqs.html#reserved_signify_in_cve_entry">RESERVED</A> ** This candidate has been reserved by an organization or individual that will use it when announcing a new security problem. When the candidate has been publicized, the details for this candidate will be provided. (http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-0220) |
13:25 |
jeff |
I can't guarantee that's it, but if you suspect the Apache update is what broke it, those changes seem worth looking at first. |
13:26 |
jeffdavis |
ah, the "multiple consecutive slashes" thing |
13:26 |
jeff |
Are you in any position to test with the previous Apache and then upgrade to this version? Be a shame to chase this down if it ends up not being Apache... I'd feel bad for encouraging you down this path, then. :-) |
13:35 |
jeffdavis |
jeff: yep, booking works again after downgrading Apache with `aptitude install apache2=2.4.18-2ubuntu3` |
13:38 |
jeff |
the iframe source on a system here shows a double slash: it contains /eg//eg/booking/reservation |
13:38 |
* jeff |
looks to see why |
13:40 |
jeffdavis |
(...and re-upgrading to 2.4.18-2ubuntu3.10 re-breaks things on the test system) |
13:41 |
jeff |
Open-ILS/web/js/ui/default/staff/booking/app.js has: var booking_path = '/eg//eg/' + ... |
13:42 |
jeff |
(in EmbedBookingCtl) |
13:42 |
jeffdavis |
well, that would do it. :( |
16:14 |
berick |
in home directory, in .evergreen directory |
16:24 |
|
yboston joined #evergreen |
16:49 |
|
yboston joined #evergreen |
17:01 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-05T16:58:13,393702099-0400 -0> |
17:11 |
gsams |
berick: It looks like it's sending the correct information. |
17:12 |
|
mmorgan left #evergreen |
17:14 |
pastebot |
"gsams" at 64.57.241.14 pasted "Log of last print attempt" (8 lines) at http://paste.evergreen-ils.org/10842 |
17:18 |
gsams |
actually, now that I'm looking more carefully I think it may have been leaving out the style. |
17:18 |
gsams |
will test further. |
17:31 |
berick |
i'd also try copying the stock template out for safe keeping and trying a very simple template |
17:32 |
berick |
just a bit of style and some hard-coded text |
17:32 |
berick |
to rule out template issues |
17:41 |
gsams |
er class. |
17:41 |
berick |
k |
17:42 |
gsams |
I think it may be the DYMO, and maybe I'm missing something. |
17:48 |
berick |
certainly worth trying one of the test templates against another printer or print-to-file |
17:49 |
berick |
of course the dymo doesn't see css, just the final (headless) browser view |
17:49 |
berick |
but it could be some limitation of font types / sizes in the dymo? |
17:57 |
|
gsams_ joined #evergreen |
17:58 |
|
abneiman_ joined #evergreen |
17:59 |
|
book`_ joined #evergreen |
03:17 |
|
yar joined #evergreen |
05:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-04T04:59:06,000630798-0400 -0> |
07:12 |
|
rjackson_isl joined #evergreen |
08:05 |
|
bdljohn joined #evergreen |
08:26 |
|
Dyrcona joined #evergreen |
12:46 |
Dyrcona |
Group permissions editor seems to just be broken. I tried adding a mapping and I don't even see an attempt to create a grp_perm_map entry in the logs. |
12:48 |
Dyrcona |
Only thing in the logs matching grp are related to opening conify/global/permission/grp_tree.hml |
12:50 |
mmorgan |
Dyrcona: I noticed that on a 3.3 system just this morning. Seems to be working ok on our 3.2.4 training system. |
12:51 |
Dyrcona |
I haven't been told its not working on our 3.2.5 training system. This machine where it's not working is a 3.2.4 test VM. We decided not to go to 3.2.5 after some performance issues with a couple of the fixes. |
12:53 |
Dyrcona |
So, wonder if it's "one of those things" or something that we backported, but I don't recall backporting any permissions-related things. |
13:00 |
Dyrcona |
Well, this explains it: POST https://jasontest.cwmars.org/osrf-http-translator 400 (Bad Request) |
13:02 |
Dyrcona |
I get a number of 404s for dojo.js and openils_dojo.js just opening the page. |
13:56 |
bshum |
Was the penalty set at org unit 1 for the whole consortium or just one place? |
13:56 |
Bmagic |
at the system level |
13:56 |
bshum |
Okay, and the workstation used to look up the patron was from that system? |
13:56 |
Bmagic |
on the web client in my testing, I was logged in at the branch under the system where the penalty is defined |
13:56 |
bshum |
Hmm |
13:57 |
bshum |
that sounds suspicious then |
13:58 |
* bshum |
doesn't know enough about the web client to comment further :D |
16:54 |
pinesol |
Launchpad bug 1758975 in Evergreen "Item status can be set to Lost and Paid inappropriately when closing a transaction for a Long Overdue or Lost returned item" [Medium,Confirmed] https://launchpad.net/bugs/1758975 |
16:54 |
Bmagic |
I was thinking that the system did the right thing by not billing the patron, because the circulation was closed |
16:58 |
pastebot |
"gmcharlt" at 64.57.241.14 pasted "for jeff: the Evergreen side of the experiment" (22 lines) at http://paste.evergreen-ils.org/10840 |
17:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:03 |
|
mmorgan left #evergreen |
17:08 |
jeff |
gmcharlt++ i'll keep my eyes out for the Mousetrap side, or let me know if there isn't one. Thanks! |
17:37 |
jeffdavis |
Are we going to have a proper dev meeting this month? I know there was an informal quasi-meeting on Tuesday... |
00:50 |
|
eady joined #evergreen |
02:15 |
|
eady joined #evergreen |
02:50 |
|
eady joined #evergreen |
05:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:12 |
|
rjackson_isl joined #evergreen |
07:33 |
|
agoben joined #evergreen |
07:58 |
|
_bott_ joined #evergreen |
14:50 |
berick |
The "The The" |
14:51 |
Dyrcona |
berick++ |
14:51 |
JBoyer |
berick++ |
14:51 |
Dyrcona |
The The has been a go to search for testing stop words. :) |
14:51 |
Dyrcona |
Or would that be a Go-Gos search? :P |
14:51 |
jeff |
mmorgan: thinking of using a database trigger to keep asset.copy.alert_message in sync with asset.copy_alert, and having staff only use one alert type for now. |
14:51 |
* Dyrcona |
runs and hides from the inevitable beatings. |
15:48 |
|
nfBurton joined #evergreen |
15:49 |
jeff |
and regarding bug 1814799, is there a scenario where you'd ever want to manually apply a copy alert that has been configured with a state value other than NORMAL? |
15:49 |
pinesol |
Launchpad bug 1814799 in Evergreen "State-Specific Copy Alerts Ignore State of Item" [Undecided,New] https://launchpad.net/bugs/1814799 |
15:53 |
jeff |
while we're on the subject, I'm also wondering about the comment in the upgrade script where the stock state <> 'NORMAL' copy alert types are enabled: |
15:53 |
jeff |
> Making the following copy alert types active by default; if you are not using the web staff client yet, you may want to disable them. |
15:55 |
jeff |
I think it might be based on the "upstream" comment: copy alerts upon checkin or renewal of exceptional copy statuses are not active by default; they're meant to be turned once a site is ready to fully commit to using the webstaff client for circulation |
15:55 |
jeff |
but neither is clear on the anticipated impact or reasons why you wouldn't enable them if you are not "ready to fully commit" |
16:02 |
|
yboston joined #evergreen |
16:08 |
|
sandbergja_ joined #evergreen |
16:22 |
|
khuckins joined #evergreen |
16:30 |
jeff |
in practice, turning on the stock event id 7 for alerting on checkin of DAMAGED items does not seem to impact the xul client in any observable adverse way. |
16:31 |
jeff |
(tested that a while ago, but just re-tested with a little more double-checking) |
16:33 |
mmorgan |
jeff: We seem to be accumulating rows in asset.copy_alert for checkins/checkouts in the xul client of exceptional status items. That's probably a good enough reason to disable the alerts. |
16:33 |
jeff |
In my observation, those rows are generated no matter if you're using the web or xul client. |
16:34 |
mmorgan |
Interesting. |
16:54 |
mmorgan |
:) |
16:56 |
jeff |
ack_time is set when clearing an alert from Manage Copy Alerts, but ack_staff isn't. Looks like ack_staff is only set when an alert is "temporary" and it's cleared from the alert dialog itself. |
16:58 |
mmorgan |
jeff++ # sharing observables |
17:02 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-03T16:58:26,496333537-0400 -0> |
17:06 |
|
mmorgan left #evergreen |
17:15 |
|
sandbergja_ joined #evergreen |
17:37 |
Bmagic |
I forget: is there a setting to keep a hold targeted on the first copy targeted for a certain amount of time before retargeting? But just for the first copy targeted? |
01:18 |
|
jamesrf joined #evergreen |
05:01 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-04-02T04:57:24,725729014-0400 -0> |
06:41 |
|
yar joined #evergreen |
06:59 |
|
agoben joined #evergreen |
07:12 |
|
rjackson_isl joined #evergreen |
13:57 |
medlibrarian |
But do I need a server to use evergreen? |
13:58 |
berick |
medlibrarian: yes, Evergreen runs as a server |
13:58 |
medlibrarian |
ok, thank you so much. I am new to this and appreciate your reply. |
13:59 |
Dyrcona |
I can't seem to find the list of public test servers at the moment. |
13:59 |
Dyrcona |
And, too late..... |
14:00 |
terran |
Dyrcona: https://wiki.evergreen-ils.org/doku.php?id=community_servers |
14:02 |
Dyrcona |
terran: Thanks. |
15:08 |
dbwells |
We had two RC builds, one of which was posted only to IRC, some issues were further ironed out, and a second RC was posted to the downloads page. |
15:08 |
berick |
dbwells++ |
15:08 |
JBoyer |
dbwells++ |
15:09 |
dbwells |
That RC tested well internally, and I didn't get any negative feedback, so that has now been rebranded as 3.3.0. |
15:09 |
gmcharlt |
dbwells++ |
15:09 |
dbwells |
And as berick noted, I pushed the rel_3_3 branch moments ago, so please be aware of that for future pushes. |
15:12 |
dbwells |
There are a lot of mostly smaller improvements, but probably the biggest shift is in a number of interfaces moving to eg2/Angular 7. Some of that is still optional/experimental, but some is also frontline now. |
16:57 |
nfBurton |
I figured |
16:57 |
nfBurton |
Dyrcona++ |
16:57 |
nfBurton |
Hopefully it comes back after a restart |
17:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:17 |
|
mmorgan left #evergreen |
17:31 |
Bmagic |
dbwells++ # 3.3.0 baby! |
17:32 |
dbwells |
:) |
00:04 |
|
sandbergja joined #evergreen |
00:18 |
|
jamesrf joined #evergreen |
01:27 |
|
jamesrf joined #evergreen |
05:01 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-03-28T04:58:20,153401959-0400 -0> |
07:01 |
|
agoben joined #evergreen |
07:16 |
|
rjackson_isl joined #evergreen |
08:03 |
|
littlet joined #evergreen |
12:48 |
jeff |
picking a Z39.50 source that supports Keyword and one that does not, and then submitting a search with only a keyword specified... leads to a failure along the lines of "Can't call method "option" on an undefined value at /usr/local/share/perl/5.24.1/OpenILS/Application/Search/Z3950.pm line 437." |
12:50 |
jeff |
Interestingly enough, perhaps due to a local logging quirk, I'm only seeing the error appear in Apache logs. |
13:08 |
|
wsmoak joined #evergreen |
13:55 |
bshum |
berick: Some feedback on the remoteip commit for the ansible installer |
13:55 |
bshum |
It looks like we need to add a step to do a2enmod remoteip as well |
13:56 |
bshum |
Otherwise, just editing the config file leads to a failed ansible run due to not being able to start apache due to the config change |
13:56 |
bshum |
This is from a test run I'm doing on 18.04, not sure if the same issue presents in 16.04 but the commit didn't seem too different |
13:57 |
bshum |
I'll file a bug and put up a pullrequest later if you don't get to fixing it quicker :) |
14:13 |
berick |
bshum: oh, hm |
14:14 |
berick |
good catch, thanks bshum |
14:15 |
|
stephengwills joined #evergreen |
15:51 |
bshum |
But uh... yeah, my info knowledge is many years out of date now |
15:51 |
jeff |
mmorgan: i believe that they do, yes. |
15:51 |
bshum |
So I'll be quiet :) |
15:52 |
jeff |
mmorgan: increasing the timeout on the SIP client means in theory that it will take longer to give up on the SIP server in cases of actual outage. depends on your AMH, and how patrons interact with it (if at all), but in this scenario increasing the timeout is likely a good option for a workaround. |
15:53 |
jeff |
mmorgan: empirical testing may give most accurate results. :-) |
15:54 |
* jeff |
breaks user editor changes into logical commits and bugs |
15:55 |
mmorgan |
jeff: We can request an increase in the timeout to see if that helps. I'd prefer to fix the bug, though ;-) |
15:57 |
mmorgan |
So if nonholdable items weren't in the hold_copy_map, would that prevent evergreen from polling through 100 holds that the item can't fill? Or would it still do that? |
15:59 |
jeff |
i believe the ahcm table is what is consulted at checkin time for opportunistic hold capture |
16:28 |
mmorgan |
Yes, exactly. |
16:29 |
jeff |
i'm wondering what would happen if you did something that caused that row to no longer be present in action.hold_copy_map. say, deleting it manually, or attempting to force retarget the hold (or maybe thawing then freezing the hold) |
16:30 |
mmorgan |
Hold that thought. I'm going to check the copy auditor table to make sure. |
16:30 |
jeff |
oh, to test the theory that the frozen hold was placed (or last targeted) before the copy was made non-holdable? |
16:31 |
mmorgan |
Well, to make sure that the item was actually nonholdable when these transactions happened. |
16:31 |
jeff |
ah. |
16:31 |
mmorgan |
Interestingly, the frozen hold was placed before the copy was made active. Can't say when the hold was frozen, though. |
16:35 |
jeff |
are you in a position to be able to do something that causes that copy to no longer appear in action.hold_copy_map, and then check the item in again to see if it's still checked against a bunch of holds? |
16:35 |
mmorgan |
Yes, prev_check_time is null for the hold. |
16:36 |
mmorgan |
jeff: not with that particular item. |
16:38 |
jeff |
are you able to create a fake copy on a title with many holds, make the fake copy holdable=false, and check that item in? |
16:39 |
jeff |
bonus points if you want to test it with and without a single frozen hold that has that copy in its copy map... bit of work to set up, i know. |
16:40 |
jeff |
i could probably test this theory here. |
16:40 |
mmorgan |
Item was created as a holdable on order item. Item was changed to not holdable at 12:53, and checked in at 14:17 the same day. So it likely appeared in the hold_copy_map for many holds at that point. |
16:40 |
mmorgan |
So, that kind of blows the theory :) |
16:42 |
* mmorgan |
can check more recent logs for the same item to see how many holds get tested. |
16:44 |
jeff |
ah, okay. i think i originally thought the logs in question were a bit more contemporary. i think i understand now. |
16:49 |
mmorgan |
jeff: TBH, I wasn't as mindful as I should have been of the age of the logs. A checkin of that item from yesterday does not show multiple holds being checked, not even the frozen one in the hold copy map. |
16:50 |
mmorgan |
jeff++ |
16:51 |
mmorgan |
Lots of entries in the hold_copy_map that are no longer relevant. Maybe we can work that angle. |
16:52 |
mmorgan |
Sorry to take up your time! |
16:52 |
mmorgan |
jeff++ |
17:01 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:03 |
jeff |
well, i'm glad to have the theory regarding non-holdable copies disproven. |
17:04 |
mmorgan |
Me too! |
17:04 |
jeff |
the age hold protected copies are still a bit of an issue. will have to revisit. |
01:24 |
|
jamesrf joined #evergreen |
03:14 |
|
sandbergja joined #evergreen |
05:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
07:16 |
JBoyer |
jeff++ # That's a good idea. |
07:37 |
|
littlet joined #evergreen |
07:49 |
|
agoben joined #evergreen |
09:59 |
jeff |
We probably shouldn't allow a password reset request to be initiated using the barcode of an inactive card. |
10:00 |
* mmorgan |
would agree with that. |
10:08 |
|
StomproJ joined #evergreen |
10:38 |
dbwells |
berick: Testing the RC, and not seeing any search results in the experimental staff catalog. The search completes, the facets and counts load, I see the holdings fetches happening, but nothing gets drawn in the main area. Any thoughts on troubleshooting this? |
10:47 |
berick |
dbwells: that's different... |
10:47 |
berick |
console errors? |
10:47 |
dbwells |
not seeing any... |
11:07 |
berick |
can you freely navigate other eg2 interfaces? |
11:07 |
dbwells |
It all feels pretty free |
11:08 |
dbwells |
It seems likely to be something wrong with our local install and not the code, but I'd love to figure out what. |
11:09 |
berick |
hm, so the pager works, which means the search call is returning... |
11:10 |
berick |
but then it never even tries to grab the bibs |
11:11 |
berick |
it uses the /opac/extras/unapi... stuff to grab the initial bib and holdings data |
11:11 |
berick |
i wonder if you see those calls hitting the apache/nginx access logs? |
11:12 |
berick |
e.g. GET /opac/extras/unapi?id=tag::U2bre/30{holdings_xml}/CONS/0&format=holdings_xml ... |
11:15 |
berick |
also good to know if that URL produces results on your test machine |
11:25 |
|
sandbergja joined #evergreen |
11:27 |
dbwells |
berick: sorry, got pulled away. Yes I see those in the Network tab in chrome, and they appear to be working. |
11:31 |
berick |
k |
12:05 |
dbwells |
biblio.multiclass.query.staff, then facet_cache.retrieve, then pcrud.search.bre |
12:05 |
dbwells |
That's the end, I think for real this time. |
12:06 |
berick |
ok, good, that at least makes mores sense. |
12:07 |
dbwells |
It feels like a timing/promise resolution issue, but I can't easily see where. |
12:08 |
dbwells |
Or, again, maybe just something not right with our setup. |
12:09 |
dbwells |
berick: One other odd symptom, possibly unrelated. Occasionally, the facets do not load, or it appears that they load, then disappear. |
12:09 |
dbwells |
I can't reproduce it, but it has happened 3-4 times in testing this morning. |
12:09 |
berick |
dbwells: i have actually seen that one. |
12:10 |
berick |
same here, difficult to reproduce |
12:10 |
berick |
as far as the records go, all I can suggest at this point is adding console logs :( |
17:24 |
nfBurton |
That's really odd |
17:24 |
Bmagic |
no doubt |
17:28 |
Bmagic |
If you mark something lost after* it was checked in, will the system first move the item into checked out, then mark it lost in order to facilitate the billing properly? |
17:31 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:32 |
jeff |
Bmagic: any clues in the auditor tables with regard to the audit user or audit workstation? |
17:32 |
Bmagic |
those are blank, however, the editor column is populated with a staff account |
17:32 |
Bmagic |
my theory is that someone marked it lost (somehow) after it was checked in |
01:04 |
|
dbwells joined #evergreen |
01:15 |
|
bshum joined #evergreen |
01:37 |
|
yar joined #evergreen |
05:00 |
pinesol |
News from qatests: Failed Installing Evergreen pre-requisites <http://testing.evergreen-ils.org/~live/test.26.html#2019-03-26T04:40:24,364130820-0400 -0> |
05:00 |
pinesol |
News from qatests: Failed Building Evergreen <http://testing.evergreen-ils.org/~live/test.30.html#2019-03-26T04:40:24,390696480-0400 -2> |
05:00 |
pinesol |
News from qatests: Failed Running Evergreen tests <http://testing.evergreen-ils.org/~live/test.31.html#2019-03-26T04:40:24,418037892-0400 -4> |
05:00 |
pinesol |
News from qatests: Failed Installing Evergreen <http://testing.evergreen-ils.org/~live/test.32.html#2019-03-26T04:40:24,444235953-0400 -6> |
05:00 |
pinesol |
News from qatests: Failed Installing Dojo <http://testing.evergreen-ils.org/~live/test.35.html#2019-03-26T04:40:24,471526623-0400 -8> |
05:00 |
pinesol |
News from qatests: Failed configure apache <http://testing.evergreen-ils.org/~live/test.36.html#2019-03-26T04:40:24,498755526-0400 -10> |
05:00 |
pinesol |
News from qatests: Failed configure EG Action/Trigger <http://testing.evergreen-ils.org/~live/test.38.html#2019-03-26T04:40:24,524966532-0400 -12> |
05:00 |
pinesol |
News from qatests: Failed Create Evergreen Database <http://testing.evergreen-ils.org/~live/test.41.html#2019-03-26T04:40:24,553494577-0400 -14> |
05:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-03-26T04:40:24,579855051-0400 -16> |
05:00 |
pinesol |
News from qatests: Failed Running autogen.sh <http://testing.evergreen-ils.org/~live/test.44.html#2019-03-26T04:40:24,606282934-0400 -18> |
05:00 |
pinesol |
News from qatests: Failed Running pgTAP live tests <http://testing.evergreen-ils.org/~live/test.47.html#2019-03-26T04:40:24,632750868-0400 -20> |
05:00 |
pinesol |
News from qatests: Failed Running settings-tester.pl <http://testing.evergreen-ils.org/~live/test.48.html#2019-03-26T04:40:24,659089678-0400 -22> |
05:00 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live/test.49.html#2019-03-26T04:40:24,685532524-0400 -24> |
05:00 |
pinesol |
News from qatests: Failed Log Output: srfsh.log <http://testing.evergreen-ils.org/~live/test.58.html#2019-03-26T04:40:24,830537784-0400 -26> |
06:56 |
|
agoben joined #evergreen |
07:11 |
|
rjackson_isl joined #evergreen |
07:30 |
|
bdljohn joined #evergreen |
08:34 |
pinesol |
csharp: It really IS itself's fault! for bringin' csharp down |
08:44 |
JBoyer |
oh, that reminds me! Turns out that it's super easy to swap headless chrom(e|ium) for PhantomJS, especially in eg2 since karma-chrome-launcher is already installed. |
08:45 |
JBoyer |
The only problem is that while you can *run* chrome headless, you're probably still going to be stuck installing a lot of X libs. |
08:50 |
JBoyer |
So it's a little less ideal to run tests as just part of a regular install, but moving over would mean that when tests are run the version of JS would be current, so we could (obj) => { obj.cool_stuff; } all day long. |
08:52 |
|
mmorgan joined #evergreen |
09:15 |
|
tlittle joined #evergreen |
09:22 |
bos20k |
Hello. We are seeing an issue when library staff tries to catalog an item (not in acq). I think my analysis of the issue may be correct and I assume it is an issue with what the staff is doing somehow but I am not a cataloger so I'm not sure what may be going on. I will try to paste the information using paste.evergreen-ils.org. Any ideas would be greatly appreciated. |
11:19 |
pinesol |
Launchpad bug 1750894 in Evergreen "Wishlist: Store web staff workstation settings on the server" [Wishlist,Fix released] https://launchpad.net/bugs/1750894 |
11:20 |
mmorgan |
jeff: Yes, 3.2+ |
11:25 |
jeff |
mmorgan++ |
11:28 |
mmorgan |
I am looking at a 3.2.4 test server and the reporter interface won't load. I just get You are logged in as with no username, and Loading... Any ideas? |
11:56 |
pinesol |
[evergreen|Bill Erickson] LP1821067 Angular Czech translation bundle - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=17ddeaf> |
11:56 |
pinesol |
[evergreen|Bill Erickson] LP1821067 Angular i18n uses XMB; cs-CZ examples - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0dbc36d> |
12:02 |
|
wsmoak joined #evergreen |
12:09 |
* mmorgan |
believes both copies of the idl are the same, but will double check. |
12:10 |
mmorgan |
I see this in the console: GET https://egtraining.noblenet.org/reports/oils_rpt.xhtml?ses=75116f04bf85600a2162def63a294d78 net::ERR_INCOMPLETE_CHUNKED_ENCODING 200 (OK) |
12:11 |
JBoyer |
Oh, that would be caused by something else, haven't seen that one. |
12:11 |
JBoyer |
Where you testing anything specific? |
12:12 |
JBoyer |
Oh, and what version of OSRF? I wouldn't be too surprised about that if Eg wanted a newer version than was installed, perhaps. |
12:18 |
|
jihpringle joined #evergreen |
12:19 |
mmorgan |
JBoyer: You mean testing any specific code? Not in terms of reports. I'll try copying the idl. |
12:21 |
JBoyer |
I was confused that I couldn't find that error anywhere, looks like it's probably related to node/chrome interactions. |
12:22 |
JBoyer |
Also, because I almost clicked on that link not realizing what was in there, you may want to log out and start over. :) |
12:25 |
mmorgan |
Oops. Killed that session :) |
15:06 |
JBoyer |
Yeah, you could use the originally fetched user as the data for a plain template replacement on the page rather than as a model in an editable control. |
15:15 |
|
sandbergja joined #evergreen |
16:02 |
jeff |
okay, yep. that works. |
17:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:07 |
|
mmorgan left #evergreen |
17:23 |
jeff |
berick, JBoyer: this is what i was trying to do: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=39800262d06dfac14e80fcd10ff5e0dd0c01b52a for bug 1264746 |
17:23 |
pinesol |
Launchpad bug 1264746 in Evergreen "Add "email password reset" button to user editor" [Wishlist,In progress] https://launchpad.net/bugs/1264746 - Assigned to Jeff Godin (jgodin) |
17:32 |
jeff |
Hrm. I should handle the case where the barcode's been changed also, since we don't have a "request password reset link email via userid" option. |
18:08 |
pinesol |
[evergreen|Dan Wells] Fix Asciidoc levels in 3.3 release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c09ef9a> |
18:17 |
|
sandbergja joined #evergreen |
18:29 |
dbwells |
After a few brief rounds of fixes/enhancements, the 3.3.0 RC is now available in the previews area: https://evergreen-ils.org/downloads/previews/Evergreen-ILS-3.3.0.tar.gz As named, this will be 3.3.0 barring any meltdowns discoverd in testing tomorrow. More testing would be much appreciated! |
18:31 |
rhamby |
dbwells++ |
19:00 |
|
sandbergja joined #evergreen |
19:25 |
jeff |
While you can request and complete a password reset with an inactive barcode, you can't actually then log in with said barcode... so I guess we'll warn about that also. |
00:25 |
|
jamesrf joined #evergreen |
00:42 |
|
sandbergja joined #evergreen |
05:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-03-25T04:57:33,988624201-0400 -0> |
05:53 |
|
jamesrf joined #evergreen |
06:43 |
|
JBoyer joined #evergreen |
06:56 |
|
jamesrf joined #evergreen |
10:17 |
krvmga |
the key text element in the error refers to where the ISBN typically is and the UPC should be if no ISBN |
10:30 |
bshum |
krvmga: That sounds similar to https://bugs.launchpad.net/evergreen/+bug/1549393 |
10:30 |
pinesol |
Launchpad bug 1549393 in Evergreen 2.9 "AddedContent: Invalid ISBN's are sent to Content Cafe as blank string" [Medium,Fix released] |
10:30 |
bshum |
Which is an ancient and closed bug |
10:31 |
bshum |
Are you sure it's a valid UPC and no ISBN on the bib record you're checking? |
10:31 |
|
Christineb joined #evergreen |
10:32 |
bshum |
Interesting |
10:32 |
bshum |
That fix that Stompro provided in that bug only applied to ISBN/ISSN |
10:33 |
bshum |
So maybe it's an undef UPC value |
10:33 |
bshum |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=15890219867ea44524a36b8becfaa12594984927 |
10:34 |
bshum |
See around line 184 of AddedContent.pm where it yanks out bad isbn/issn, maybe we need to add upc there |
10:37 |
bshum |
Yeah that seems logical. I don't have ContentCafe to test, but the symptoms and code seem to read out the way |
10:38 |
bshum |
So maybe try adding @upcs = grep {defined} @upcs; |
10:39 |
bshum |
Like the other ones there |
10:39 |
bshum |
Stompro++ |
10:40 |
bshum |
krvmga++ |
11:33 |
dbs |
bshum++ |
12:02 |
|
khuckins joined #evergreen |
12:09 |
|
jihpringle joined #evergreen |
14:44 |
csharp |
looks like this is some corner case with metarecord hold cancellation that I'm going to have to dig into in a week where I'm not under this much pressure |
14:44 |
csharp |
(migrating PINES to new colo in 2 weeks and I'm off next week) |
14:45 |
JBoyer |
csharp++ # good vibes! |
14:55 |
jeff |
Good reason to test "unusual" reingest methods. Passing a list of display fields to metabib.reingest_metabib_field_entries() means that only those display fields will be present after it completes. |
14:56 |
jeff |
i.e., if there were other display fields present for that record before, they will be removed if they are not in the supplied list of fields to reingest. |
14:56 |
jeff |
(at least in 3.1) |
14:56 |
jeff |
(mild surprise, not outright shock) |
15:09 |
csharp |
JBoyer: thanks! |
15:21 |
|
khuckins joined #evergreen |
16:19 |
pastebot |
"phasefx" at 64.57.241.14 pasted "user/berick/lp1811288-fm-editor-combobox" (78 lines) at http://paste.evergreen-ils.org/10823 |
16:30 |
berick |
bit of an edge case, where we pass in hard-coded values |
16:31 |
phasefx |
edge case is my name.. or maybe that was head case |
16:32 |
berick |
chaos-powers++ |
16:33 |
phasefx |
testing. I can probably streamline my build process.. it's a sledgehammer |
16:34 |
phasefx |
berick: all good, new and chaos resistant |
16:35 |
pinesol |
[evergreen|Jane Sandberg] LP1797934: follow-up: make the reservations tab in MyOpac optional - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=5046ced> |
16:36 |
berick |
phasefx++ |
16:39 |
phasefx |
berick: minor one, tanget. got an ERROR Error: Uncaught (in promise): Object: {"dismissed":true,"message":"cross_click"} clicking the X to close the fm editor dialog |
16:49 |
berick |
may as well make the sandbox examples as useful as possible... |
16:53 |
phasefx |
berick: looks good! |
16:54 |
phasefx |
berick: though I must confess, I didn't expec to really create an entry in config.marc_field just now :D |
16:56 |
berick |
oh yeah, it's testing the actual plumbing |
16:57 |
pinesol |
[evergreen|Bill Erickson] LP1821409 Ang admin editor clears fields on new - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=29b100c> |
17:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:03 |
pinesol |
Showing latest 5 of 6 commits to Evergreen... |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Angular fm-editor uses combobox - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d63c7c3> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Basic admin page readonlyFields repair - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=00de314> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Admin grids preload combobox values - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9e69671> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Allow Combobox to default to field id - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a3731c9> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Sandbox editor handles dismissals - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=fc8bd35> |
17:05 |
Bmagic |
When something is a direct charge - it doesn't seem to have any rows in acq.lineitem_detail. Is there any way to connect those fund_debit's to anything? The invoice_entry is null |
17:07 |
|
mmorgan left #evergreen |
17:15 |
berick |
Bmagic: acq.po_item |
05:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
08:02 |
|
collum joined #evergreen |
08:07 |
|
troy____ joined #evergreen |
08:08 |
|
bshum_ joined #evergreen |
15:13 |
berick |
ok it's fixed in the branch for bug 1811288 |
15:13 |
pinesol |
Launchpad bug 1811288 in Evergreen "Angular Fieldmapper Editor should use combobox for linked fields" [Medium,New] https://launchpad.net/bugs/1811288 |
15:13 |
berick |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=e9d2882b79816ba52e1db55a6cc96990b3526b68 |
15:13 |
sandbergja |
Oh, great! |
15:13 |
sandbergja |
berick++ |
15:17 |
sandbergja |
dbwells: what are the chances that bug 1811288 could get into the release candidate, if I could test it and sign off on it within the next few hours? |
15:17 |
pinesol |
Launchpad bug 1811288 in Evergreen "Angular Fieldmapper Editor should use combobox for linked fields" [Medium,New] https://launchpad.net/bugs/1811288 |
15:17 |
sandbergja |
it would be really nice to save users and servers from dropdown menus that are populated with every single bib record in the catalog! |
15:24 |
dbwells |
It's a pretty big change at this late hour, and the diffs are a little hard for me to read. |
15:33 |
berick |
ok, so I rebased user/berick/lp1811288-fm-editor-combobox to master |
15:33 |
berick |
retested and confirmed it fixes the booking issue |
15:34 |
berick |
and that it behaves as expected for creating booking resources, etc. |
15:47 |
dbwells |
sandbergja: My brain is getting a little leaky with all the various eg2 branches, so I am starting to test a few to hopefully push in as well. Just a heads up in case some merge conflicts result. |
15:48 |
berick |
dbwells: holler if I can be of assistance |
15:48 |
dbwells |
will do |
16:07 |
dbwells |
berick: Testing #1807461, I see a bug, but I think it is unrelated. If you edit a row, you can no longer create new rows. The old edit data is still there, so I am guessing it might be an ID collision, as the old ID is there, and you can't delete it. Does that sound familiar? |
16:08 |
dbwells |
"old edit data is still there" meaning the editor form is still populated with all data from the edit, even when creating new. |
16:11 |
* berick |
looks |
16:12 |
dbwells |
This was in the "Claim Type" editor, since that is what was referenced on the bug, but it probably manifests elsewhere as well. |
16:14 |
pinesol |
[evergreen|Bill Erickson] LP#1807458 Angular admin grid Edit Selected option - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=89948f5> |
16:47 |
sandbergja |
in case of really big lists? |
16:51 |
berick |
sandbergja: exactly. that's how the dojo widget handled it, so i tried to keep it consisten |
16:55 |
sandbergja |
berick: thanks! |
17:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1812670 Angular grid shows selector labels - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8480ca2> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP#1819179: Angular value formatter gets link smarts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2fe4212> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1819179 IDL2js includes 'map' attribute data - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d26ece2> |
17:03 |
pinesol |
[evergreen|Bill Erickson] LP1819179 PCRUD selector fleshing handles maps - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1db81cf> |
17:08 |
|
mmorgan left #evergreen |
17:12 |
berick |
dbwells++ |
17:16 |
sandbergja |
berick: I like all the comboboxes, but I'm a little hesitant about how many interfaces that used to preload those values (both in dojo, and of course under the current ng client) now would not. I suspect that -- in some of those cases -- users rely on being able to see a complete list of possible values. |
11:45 |
Dyrcona |
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions#Browser_compatibility |
11:45 |
berick |
Dyrcona: neat |
11:45 |
|
khuckins joined #evergreen |
11:45 |
phasefx |
fwiw, the live tester behaves the same (reports a syntax error) but doesn't flag a warning/error with the QA tests |
11:46 |
Dyrcona |
phasefx: You're getting the syntax from npm run test ? |
11:46 |
phasefx |
Dyrcona: yeap |
11:47 |
phasefx |
http://testing.evergreen-ils.org/~live/cronoutput.txt |
11:48 |
berick |
probably best to de-arrow-ify for now |
11:48 |
|
sandbergja_ joined #evergreen |
11:49 |
Dyrcona |
So, PhantomJS doesn't like it. |
11:49 |
phasefx |
Dyrcona: I tried to make the installer match the instructions on the website as closely as possible; we call for npm run test there |
11:49 |
Dyrcona |
phasefx: Yeah, it definitely makes sense to run the test on the QA testing server. :) |
11:49 |
phasefx |
:D |
11:50 |
Dyrcona |
I usually skip it on my own installations because it usually passes and I'm lazy. :) |
11:50 |
Dyrcona |
I do run it for new stuff that I'm doing, though. |
11:51 |
phasefx |
so the actual shell level return value from npm run test is 0, which is why the tests didn't sound an alarm |
11:51 |
phasefx |
though I could start looking for it explicitly |
11:51 |
phasefx |
http://testing.evergreen-ils.org/~live/test.28.html |
11:53 |
* Dyrcona |
agrees with berick that it is probably best to de-arrowify it for now. |
11:53 |
Dyrcona |
Shame to miss out on language features from the 1950s, though. :) |
11:54 |
JBoyer |
Oh, and as for the arrow func, it's probably complaining because what that really says is "return return item.id;" -- The only contents of an arrow function are "return (your text here)" |
11:57 |
jeff |
so that's unlikely to happen anytime soon. |
11:58 |
sandbergja |
JBoyer: hahaha, that's what I thought. :-) |
11:58 |
JBoyer |
Is it still used by node, or only the version of node that builds the AngularJS parts of the client? |
11:59 |
berick |
JBoyer: it's used for headless unit tests |
11:59 |
berick |
node doesn't use it |
11:59 |
JBoyer |
Ah, that's where I was getting confused. |
11:59 |
JBoyer |
berick++ |
12:02 |
|
jeff_ joined #evergreen |
15:29 |
JBoyer |
collum++ |
15:30 |
agoben |
collum++ |
15:35 |
|
afterl left #evergreen |
17:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
17:04 |
|
mmorgan left #evergreen |
17:25 |
|
yboston joined #evergreen |
18:04 |
|
dbwells_ joined #evergreen |