| Time |
Nick |
Message |
| 05:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 08:02 |
|
collum joined #evergreen |
| 08:07 |
|
troy____ joined #evergreen |
| 08:08 |
|
bshum_ joined #evergreen |
| 08:39 |
|
mmorgan joined #evergreen |
| 09:08 |
|
aabbee joined #evergreen |
| 09:17 |
|
remingtron joined #evergreen |
| 09:19 |
|
yboston joined #evergreen |
| 09:27 |
|
Dyrcona joined #evergreen |
| 09:29 |
Bmagic |
Anyone coming to the conference with games in tow? |
| 09:42 |
Dyrcona |
I might bring a couple. |
| 09:50 |
rhamby |
maybe. Packing will be tight with bringing some stuff for outreach so if I do it'll be something small like exploding cows (always fun and easy to learn) |
| 10:00 |
Bmagic |
ok great. I'm good for Resistance, One night revolution, Hanabi, Sherrif of Nottingham, and one large size game to be determined |
| 10:09 |
|
yboston joined #evergreen |
| 10:10 |
csharp |
Bmagic++ |
| 10:13 |
Bmagic |
csharp is a spy (every day) |
| 10:23 |
pinesol |
[evergreen|Remington Steed] Docs: Add bugfix release notes for 3.1.11 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=b7f4592> |
| 10:23 |
pinesol |
[evergreen|Remington Steed] Docs: Add bugfix release notes for 3.2.5 - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8d7eeb8> |
| 10:55 |
Dyrcona |
I think the fine generator would benefit not only from caching org unit settings as mentioned in Lp 1705728, but it would also benefit from adding a last fine check time on the circulations. |
| 10:55 |
pinesol |
Launchpad bug 1705728 in Evergreen "Batch fine generator benefits from low-hanging optimization" [Wishlist,New] https://launchpad.net/bugs/1705728 |
| 10:56 |
Dyrcona |
I seem to recall adding such a field having come up before, but I couldn't find a bug on Lp. |
| 11:06 |
Dyrcona |
Two cent per day fines.....Just...don't...even..... |
| 11:07 |
* Dyrcona |
exited... Signal SEGV....Core dumpe. |
| 11:11 |
mmorgan |
The only thing worse than two cent per day fines is account adjustments for two cent per day fines. |
| 11:12 |
JBoyer |
mmorgan++ |
| 11:13 |
Dyrcona |
mmorgan++ |
| 11:14 |
pinesol |
[evergreen|abneiman] docs: Statcat updates - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=67ab852> |
| 11:29 |
gsams |
Bmagic: I could probably bring a few smaller games |
| 11:29 |
Bmagic |
gsams++ |
| 11:30 |
gsams |
I'll look over what I have, we just reorganized things at home, but I also have library games I can look over. |
| 11:31 |
|
Christineb joined #evergreen |
| 11:41 |
gsams |
Alright, I've run into a problem with serials predictions that I'm trying to wrap my head around. The error log is showing two separate errors when trying to predict issues. |
| 11:42 |
gsams |
Both are unanitialized values in string ne, one is line 160, the other line 185 in Serial.pm |
| 11:50 |
pinesol |
[evergreen|Jane Sandberg] Docs: Revising 3.3 release notes and related docs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a2c35d8> |
| 12:16 |
|
yboston joined #evergreen |
| 12:22 |
|
jihpringle joined #evergreen |
| 12:23 |
gsams |
Ah, MFHD record wasn't attached. still can't predict issues anyway, but at least I learned to read that section of code. |
| 12:31 |
|
sandbergja joined #evergreen |
| 12:32 |
|
yboston joined #evergreen |
| 12:55 |
|
sandbergja_ joined #evergreen |
| 14:07 |
|
yboston joined #evergreen |
| 14:40 |
pinesol |
[evergreen|Jane Sandberg] Docs: more improvements to 3.3 release notes and related docs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e685683> |
| 14:51 |
|
Testing joined #evergreen |
| 15:07 |
sandbergja |
berick: it looks like the code for bug 1811156 introduced a small regression into the booking admin screens |
| 15:07 |
pinesol |
Launchpad bug 1811156 in Evergreen "Port server admin page to Angular" [Wishlist,Fix released] https://launchpad.net/bugs/1811156 |
| 15:08 |
berick |
sandbergja: do tell |
| 15:08 |
sandbergja |
The booking resource types fmeditor is now ignoring the readonlyFields list, and so it is back to creating a dropdown with every single bib record ever in it |
| 15:08 |
sandbergja |
I am pretty sure the problem is this check: https://github.com/evergreen-library-system/Evergreen/blob/master/Open-ILS/src/eg2/src/app/staff/admin/basic-admin-page.component.ts#L62 |
| 15:09 |
sandbergja |
because it is trying to check the length of an object, rather than an array |
| 15:09 |
berick |
hm, I think I may have fixed that in one of my working branches |
| 15:09 |
* berick |
looks |
| 15:10 |
sandbergja |
excellent! |
| 15:10 |
berick |
yes, looks familiar, finding it.. |
| 15:13 |
berick |
ok it's fixed in the branch for bug 1811288 |
| 15:13 |
pinesol |
Launchpad bug 1811288 in Evergreen "Angular Fieldmapper Editor should use combobox for linked fields" [Medium,New] https://launchpad.net/bugs/1811288 |
| 15:13 |
berick |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=e9d2882b79816ba52e1db55a6cc96990b3526b68 |
| 15:13 |
sandbergja |
Oh, great! |
| 15:13 |
sandbergja |
berick++ |
| 15:17 |
sandbergja |
dbwells: what are the chances that bug 1811288 could get into the release candidate, if I could test it and sign off on it within the next few hours? |
| 15:17 |
pinesol |
Launchpad bug 1811288 in Evergreen "Angular Fieldmapper Editor should use combobox for linked fields" [Medium,New] https://launchpad.net/bugs/1811288 |
| 15:17 |
sandbergja |
it would be really nice to save users and servers from dropdown menus that are populated with every single bib record in the catalog! |
| 15:24 |
dbwells |
It's a pretty big change at this late hour, and the diffs are a little hard for me to read. |
| 15:24 |
berick |
i'd really like to see 1811288 get merged, of course, but ... |
| 15:24 |
berick |
heh |
| 15:24 |
berick |
we could also just merge the fix commit |
| 15:24 |
berick |
w/ a sign off of course |
| 15:25 |
dbwells |
berick, on a scale of 1 to 10, what is your confidence level that the branch doesn't break anything? And also, it only affects eg2 stuff, is that right? |
| 15:25 |
* dbwells |
is ready to play the odds |
| 15:26 |
berick |
it only affects eg2 stuff. and it affects the editor pane, so admin page create/modify actions for linked fields |
| 15:27 |
berick |
i have high confidence it won't break anything |
| 15:27 |
berick |
assuming one more person kicks the tires |
| 15:27 |
berick |
i can rebase it to master now if needed too |
| 15:28 |
* dbwells |
puts his money down on berick |
| 15:28 |
dbwells |
sandbergja: Alright, I say go for it. |
| 15:28 |
miker |
berick: does that branch contain the result of what you folded together from our separate work the other week? |
| 15:28 |
* miker |
should just go look |
| 15:29 |
dbwells |
The more eyes, the merrier, just let me know if things get done or get stuck. |
| 15:29 |
dbwells |
thanks, all |
| 15:30 |
berick |
miker: no, i think that was a different branch |
| 15:30 |
miker |
indeed... I hope that gets in, too :) |
| 15:31 |
miker |
https://bugs.launchpad.net/evergreen/+bug/1819179 |
| 15:31 |
pinesol |
Launchpad bug 1819179 in Evergreen "Improve Angular admin grids with friendlier linked object display" [Wishlist,In progress] |
| 15:31 |
miker |
related, in that it's displaying linked data where reasonable |
| 15:33 |
berick |
yeah, that would be cool.. |
| 15:33 |
berick |
ok, so I rebased user/berick/lp1811288-fm-editor-combobox to master |
| 15:33 |
berick |
retested and confirmed it fixes the booking issue |
| 15:34 |
berick |
and that it behaves as expected for creating booking resources, etc. |
| 15:47 |
dbwells |
sandbergja: My brain is getting a little leaky with all the various eg2 branches, so I am starting to test a few to hopefully push in as well. Just a heads up in case some merge conflicts result. |
| 15:48 |
berick |
dbwells: holler if I can be of assistance |
| 15:48 |
dbwells |
will do |
| 16:07 |
dbwells |
berick: Testing #1807461, I see a bug, but I think it is unrelated. If you edit a row, you can no longer create new rows. The old edit data is still there, so I am guessing it might be an ID collision, as the old ID is there, and you can't delete it. Does that sound familiar? |
| 16:08 |
dbwells |
"old edit data is still there" meaning the editor form is still populated with all data from the edit, even when creating new. |
| 16:11 |
* berick |
looks |
| 16:12 |
dbwells |
This was in the "Claim Type" editor, since that is what was referenced on the bug, but it probably manifests elsewhere as well. |
| 16:14 |
pinesol |
[evergreen|Bill Erickson] LP#1807458 Angular admin grid Edit Selected option - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=89948f5> |
| 16:14 |
pinesol |
[evergreen|Bill Erickson] LP#1807461 FM-editor show danger toasts when create/update fails - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=aa0b577> |
| 16:15 |
pinesol |
[evergreen|Bill Erickson] LP1807458 Eg2 grid Edit option lint repairs - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=84d627c> |
| 16:15 |
pinesol |
[evergreen|Bill Erickson] LP1807461 Admin page avoid errors on dialog dismissal - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=0e18c2f> |
| 16:15 |
berick |
dbwells: hm, yeah, i just confirmed that's happening w/o the patch for that bug applied |
| 16:15 |
berick |
so def a bug in it's own right |
| 16:15 |
dbwells |
berick: okay, I think remingtron has it half written up already |
| 16:16 |
berick |
remingtron++ |
| 16:30 |
remingtron |
Bmagic++ #sharing a 3.3 beta server |
| 16:30 |
Bmagic |
awwww yeah. Make it rain beta servers in the land |
| 16:31 |
remingtron |
berick: here's that new angular bug: LP 1821409 |
| 16:31 |
pinesol |
Launchpad bug 1821409 in Evergreen "Angular fieldmapper editor "new" dialog displays values of recently edited object" [Undecided,Confirmed] https://launchpad.net/bugs/1821409 |
| 16:31 |
berick |
thanks remingtron |
| 16:33 |
Bmagic |
remingtron: I learned through that process that FF has taken away the ability to ignore self signed certificates |
| 16:35 |
remingtron |
Bmagic: good to know. it was a useful feature while it lasted. |
| 16:35 |
Bmagic |
without a doubt. There are a bunch of articles online that complain about it (for the developer context) |
| 16:37 |
berick |
chrome is having similar issues, won't load shared worker scripts w/ dummy certs |
| 16:40 |
berick |
you can still make the browser trust dummy certs, it's just more involved |
| 16:46 |
sandbergja |
berick: I'm curious why preloadLinkedValues is off by default for the fmeditor combobox in bug 1811288 |
| 16:46 |
pinesol |
Launchpad bug 1811288 in Evergreen "Angular Fieldmapper Editor should use combobox for linked fields" [Medium,New] https://launchpad.net/bugs/1811288 |
| 16:47 |
sandbergja |
in case of really big lists? |
| 16:51 |
berick |
sandbergja: exactly. that's how the dojo widget handled it, so i tried to keep it consisten |
| 16:55 |
sandbergja |
berick: thanks! |
| 17:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1812670 Angular grid shows selector labels - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8480ca2> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP#1819179: Angular value formatter gets link smarts - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2fe4212> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1819179 IDL2js includes 'map' attribute data - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d26ece2> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1819179 PCRUD selector fleshing handles maps - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=1db81cf> |
| 17:08 |
|
mmorgan left #evergreen |
| 17:12 |
berick |
dbwells++ |
| 17:16 |
sandbergja |
berick: I like all the comboboxes, but I'm a little hesitant about how many interfaces that used to preload those values (both in dojo, and of course under the current ng client) now would not. I suspect that -- in some of those cases -- users rely on being able to see a complete list of possible values. |
| 17:17 |
sandbergja |
For example, the claim policy action admin interface: it does not make much sense if you don't know which values are possible. Both dojo and current master help out by preloading. |
| 17:20 |
sandbergja |
What do you think? |
| 17:20 |
berick |
sandbergja: i hear ya. i mean we could turn it on for all of the admin interfaces as a simple way to get over the hump |
| 17:21 |
sandbergja |
berick: I'd feel pretty good about that |
| 17:22 |
dbwells |
berick: Also, as somewhat expected, getting merge conflicts now on bug #1811288 (if you want to do another quick rebase). |
| 17:22 |
pinesol |
Launchpad bug 1811288 in Evergreen "Angular Fieldmapper Editor should use combobox for linked fields" [Medium,New] https://launchpad.net/bugs/1811288 |
| 17:22 |
berick |
dbwells: ok, thanks, i'll fix that first |
| 17:43 |
sandbergja |
remingtron++ # adding 3.3 doc needs to the wiki |
| 17:44 |
berick |
sandbergja: dbwells: rebased the branch and aded a commit on th end to make the admin pages pre-load the combobox data |
| 17:45 |
sandbergja |
berick++ |
| 17:49 |
dbwells |
berick++ |
| 17:54 |
sandbergja |
It's looking good to me! Signoff branch forthcoming |
| 18:01 |
berick |
sandbergja++ |
| 18:01 |
* berick |
stepping away for a bit |
| 18:07 |
sandbergja |
Signoff branch here: user/sandbergja/lp1811288-fm-editor-combobox-signoff |
| 18:40 |
sandbergja |
dbwells: if you're still around, I'm feeling pretty good about the 3.3 release notes |
| 18:41 |
pinesol |
[evergreen|Jane Sandberg] Docs: finalizing 3.3 release notes and related documentation - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=759512d> |
| 20:18 |
|
khaun joined #evergreen |
| 22:10 |
|
sandbergja joined #evergreen |
| 22:30 |
bshum |
sandbergja++ #afterhours support :) |
| 22:31 |
|
sandbergja_ joined #evergreen |
| 22:32 |
sandbergja_ |
bshum++ #afterhours support party! |
| 22:47 |
|
jamesrf joined #evergreen |
