| Time |
Nick |
Message |
| 00:25 |
|
jamesrf joined #evergreen |
| 00:42 |
|
sandbergja joined #evergreen |
| 05:00 |
pinesol |
News from qatests: Failed Running pgTAP tests <http://testing.evergreen-ils.org/~live/test.42.html#2019-03-25T04:57:33,988624201-0400 -0> |
| 05:53 |
|
jamesrf joined #evergreen |
| 06:43 |
|
JBoyer joined #evergreen |
| 06:56 |
|
jamesrf joined #evergreen |
| 07:08 |
|
agoben joined #evergreen |
| 07:21 |
|
rjackson_isl joined #evergreen |
| 07:28 |
|
sandbergja joined #evergreen |
| 08:24 |
|
bos20k joined #evergreen |
| 08:36 |
|
RBecker joined #evergreen |
| 08:44 |
|
mmorgan joined #evergreen |
| 08:50 |
|
RBecker joined #evergreen |
| 08:58 |
|
RBecker joined #evergreen |
| 09:33 |
|
krvmga joined #evergreen |
| 09:33 |
krvmga |
does anyone else here use content cafe to for reviews & more in the catalog? |
| 09:44 |
mmorgan |
krvmga: NOBLE uses Content Cafe |
| 09:48 |
rhamby |
fairly confidant a few others too though their names aren't jumping to mind |
| 09:51 |
krvmga |
where in the code do i see what evergreen is sending to content cafe? |
| 09:52 |
krvmga |
which code sends the ISBNs, ISSNs, and UPCs? |
| 09:56 |
berick |
krvmga: there's a Perl file called ContentCafe.pm |
| 09:56 |
berick |
it in combiation with AddedContent.pm do the data fetching |
| 09:57 |
krvmga |
thanks! i'll check it out. |
| 09:57 |
krvmga |
++berick |
| 10:09 |
Stompro |
krvmga, we (LARL) also use Content Cafe for cover art and added content. |
| 10:11 |
krvmga |
I'm trying to resolve an issue where Reviews & More is throwing an error "Invalid key text element: Invalid length (0)" for titles that only have a UPC and not an ISBN or ISSN. |
| 10:11 |
krvmga |
has anyone seen this error before? |
| 10:12 |
krvmga |
i think evergreen is sending the UPC but B&T's receiving config is not working correctly |
| 10:12 |
krvmga |
and so it doesn't recognize a UPC has been received |
| 10:15 |
krvmga |
ContentCafe.pm is providing an order ['isbn','upc'] to B&T but I think B&T may not be getting past the isbn |
| 10:16 |
krvmga |
and, when it doesn't seen an isbn, their config just chokes and says "nope, nothin' there." |
| 10:17 |
krvmga |
the key text element in the error refers to where the ISBN typically is and the UPC should be if no ISBN |
| 10:30 |
bshum |
krvmga: That sounds similar to https://bugs.launchpad.net/evergreen/+bug/1549393 |
| 10:30 |
pinesol |
Launchpad bug 1549393 in Evergreen 2.9 "AddedContent: Invalid ISBN's are sent to Content Cafe as blank string" [Medium,Fix released] |
| 10:30 |
bshum |
Which is an ancient and closed bug |
| 10:31 |
bshum |
Are you sure it's a valid UPC and no ISBN on the bib record you're checking? |
| 10:31 |
|
Christineb joined #evergreen |
| 10:32 |
bshum |
Interesting |
| 10:32 |
bshum |
That fix that Stompro provided in that bug only applied to ISBN/ISSN |
| 10:33 |
bshum |
So maybe it's an undef UPC value |
| 10:33 |
bshum |
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=15890219867ea44524a36b8becfaa12594984927 |
| 10:34 |
bshum |
See around line 184 of AddedContent.pm where it yanks out bad isbn/issn, maybe we need to add upc there |
| 10:37 |
bshum |
Yeah that seems logical. I don't have ContentCafe to test, but the symptoms and code seem to read out the way |
| 10:38 |
bshum |
So maybe try adding @upcs = grep {defined} @upcs; |
| 10:39 |
bshum |
Like the other ones there |
| 10:39 |
bshum |
Stompro++ |
| 10:40 |
bshum |
krvmga++ |
| 11:33 |
dbs |
bshum++ |
| 12:02 |
|
khuckins joined #evergreen |
| 12:09 |
|
jihpringle joined #evergreen |
| 12:43 |
|
aabbee joined #evergreen |
| 13:46 |
csharp |
I'm completely stumped on a current PINES problem |
| 13:47 |
csharp |
error is Can't call method "id" on an undefined value at /usr/local/share/perl/5.22.1/OpenILS/Application/Circ/Holds.pm line 3472. |
| 13:47 |
csharp |
call is request open-ils.circ open-ils.circ.hold.details.batch.retrieve.authoritative "<authtoken>", [18974658,19688392,19688395,19688434,19688444], {"include_current_copy":true,"include_usr":true,"include_cancel_cause":true,"include_requestor":true} |
| 13:47 |
csharp |
it fails every time |
| 13:49 |
JBoyer |
csharp, if you run that same request through srfsh without the cancel_cause part does that make a difference? |
| 13:49 |
* JBoyer |
is reminded of a bug re: holds cancel causes and the reporter. |
| 13:50 |
csharp |
I'll try that next. I just played around with removing some of the hold IDs and it finally worked, though when it did it took a *very* long time to return results |
| 13:50 |
csharp |
so gonna look at this hold, then I guess I'll be troubleshooting the bad query next |
| 13:51 |
csharp |
Request Time in seconds: 62.372912 |
| 13:51 |
pinesol |
csharp: [evergreen|Ben Shum] LP#1681943: Use variables for CSS colors - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=372912d> |
| 13:51 |
csharp |
pinesol: um - irrelevant |
| 13:51 |
pinesol |
csharp: Try restarting apache. |
| 13:51 |
JBoyer |
Ah, then can cause is probably not it, but that's a pretty wild query time. |
| 13:51 |
bshum |
Haha |
| 13:51 |
csharp |
and this is all of a sudden an issue :-/ |
| 13:53 |
JBoyer |
Oh, if that line in your Holds.pm is bre_id => $bre->id; I suppose it could be a non-(T/V/C) hold that has had the last bre deleted out from under it. Parts holds get grumpy about things like that if memory serves. |
| 13:54 |
bshum |
parts-- # pre-emptively applying |
| 13:54 |
csharp |
hmm - the "bad" hold is a metarecord hold |
| 13:54 |
JBoyer |
bshum, that was an example. :p |
| 13:55 |
csharp |
the line it's failing on is: ($args->{suppress_mvr} ? () : (mvr => $mvr)), |
| 13:56 |
berick |
csharp: sure about that? can't call method "id" |
| 13:57 |
berick |
$bre->id does seem to be the closest to that line number |
| 13:57 |
csharp |
berick: I'm surprised as well, but that's line 3472 |
| 13:57 |
JBoyer |
my 3472 is the one looking at include_bre but neither makes sense for that error. |
| 13:57 |
* csharp |
kept double-checking over and over :-/ |
| 13:58 |
berick |
in any event, a 60+ second call should be easy to track down in the logs |
| 13:58 |
JBoyer |
csharp, not doubting, just extra confused. |
| 13:58 |
csharp |
yeah, that's next (checking for the bad query) - looks like possibly 2 issues |
| 14:00 |
csharp |
the file we're running (pointing to the line) https://git.evergreen-ils.org/?p=evergreen/pines.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm;h=dcbe7dda4fcef5c834d17ed31755d00715928eb2;hb=refs/heads/rel_3_2_3#l3472 |
| 14:14 |
jeff |
Yeah, my money is on $bre being undefined at that point. |
| 14:14 |
jeff |
meaning find_hold_mvr failed to return a value for $bre |
| 14:17 |
jeff |
if it's hold_type M and you look at the value of target, does that metarecord's master_record exist? |
| 14:19 |
jeff |
and/or is that metarecord's master_record column null? |
| 14:26 |
rjackson_isl |
csharp found a ticket from past where hold was placed on a metarecord and item was targeted. Shortly afterwards item (and bib) were deleted leaving a bad hold |
| 14:27 |
rjackson_isl |
ended up setting a cancel date on the related hold |
| 14:27 |
rjackson_isl |
ymmv of course! |
| 14:33 |
csharp |
rjackson_isl: thanks! |
| 14:44 |
csharp |
looks like this is some corner case with metarecord hold cancellation that I'm going to have to dig into in a week where I'm not under this much pressure |
| 14:44 |
csharp |
(migrating PINES to new colo in 2 weeks and I'm off next week) |
| 14:45 |
JBoyer |
csharp++ # good vibes! |
| 14:55 |
jeff |
Good reason to test "unusual" reingest methods. Passing a list of display fields to metabib.reingest_metabib_field_entries() means that only those display fields will be present after it completes. |
| 14:56 |
jeff |
i.e., if there were other display fields present for that record before, they will be removed if they are not in the supplied list of fields to reingest. |
| 14:56 |
jeff |
(at least in 3.1) |
| 14:56 |
jeff |
(mild surprise, not outright shock) |
| 15:09 |
csharp |
JBoyer: thanks! |
| 15:21 |
|
khuckins joined #evergreen |
| 16:19 |
pastebot |
"phasefx" at 64.57.241.14 pasted "user/berick/lp1811288-fm-editor-combobox" (78 lines) at http://paste.evergreen-ils.org/10823 |
| 16:20 |
phasefx |
berick: I get ^ when I invoke Fm Record Editor from /eg2/en-US/staff/sandbox, click into MARC Record Type, and then click on serial |
| 16:20 |
* berick |
looks |
| 16:22 |
phasefx |
I wonder if my environment is busted. The MARC Format box is also behaving weirdly.. no drop down when I click into it, but if I start to type M I'll see MARC 21 show up |
| 16:24 |
berick |
phasefx: confirmed. and in the sandbox, the editor is not set to pre-load linked values, so it's not suprise you have to start typing |
| 16:24 |
phasefx |
berick: roger that |
| 16:27 |
berick |
phasefx: fix en route |
| 16:28 |
phasefx |
berick++ |
| 16:30 |
berick |
phasefx: fix pushed |
| 16:30 |
berick |
bit of an edge case, where we pass in hard-coded values |
| 16:31 |
phasefx |
edge case is my name.. or maybe that was head case |
| 16:32 |
berick |
chaos-powers++ |
| 16:33 |
phasefx |
testing. I can probably streamline my build process.. it's a sledgehammer |
| 16:34 |
phasefx |
berick: all good, new and chaos resistant |
| 16:35 |
pinesol |
[evergreen|Jane Sandberg] LP1797934: follow-up: make the reservations tab in MyOpac optional - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=5046ced> |
| 16:36 |
berick |
phasefx++ |
| 16:39 |
phasefx |
berick: minor one, tanget. got an ERROR Error: Uncaught (in promise): Object: {"dismissed":true,"message":"cross_click"} clicking the X to close the fm editor dialog |
| 16:39 |
phasefx |
tangent, even |
| 16:39 |
berick |
ah, right, that needs to be taught to better handle dismissals |
| 16:40 |
berick |
i can push a fix for that too if you want to wait a sec |
| 16:40 |
phasefx |
sure :D |
| 16:40 |
phasefx |
zero tolerance for console errors, w00t! |
| 16:41 |
berick |
++ |
| 16:49 |
berick |
phasefx: pushed. |
| 16:49 |
berick |
may as well make the sandbox examples as useful as possible... |
| 16:53 |
phasefx |
berick: looks good! |
| 16:54 |
phasefx |
berick: though I must confess, I didn't expec to really create an entry in config.marc_field just now :D |
| 16:56 |
berick |
oh yeah, it's testing the actual plumbing |
| 16:57 |
pinesol |
[evergreen|Bill Erickson] LP1821409 Ang admin editor clears fields on new - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=29b100c> |
| 17:00 |
pinesol |
News from qatests: Testing Success <http://testing.evergreen-ils.org/~live> |
| 17:03 |
pinesol |
Showing latest 5 of 6 commits to Evergreen... |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Angular fm-editor uses combobox - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=d63c7c3> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Basic admin page readonlyFields repair - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=00de314> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Admin grids preload combobox values - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=9e69671> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Allow Combobox to default to field id - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=a3731c9> |
| 17:03 |
pinesol |
[evergreen|Bill Erickson] LP1811288 Sandbox editor handles dismissals - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=fc8bd35> |
| 17:05 |
Bmagic |
When something is a direct charge - it doesn't seem to have any rows in acq.lineitem_detail. Is there any way to connect those fund_debit's to anything? The invoice_entry is null |
| 17:07 |
|
mmorgan left #evergreen |
| 17:15 |
berick |
Bmagic: acq.po_item |
| 17:15 |
Bmagic |
ah - thanks! |
| 17:16 |
Bmagic |
hmm, still empty |
| 17:16 |
berick |
Bmagic: if it's a direct charge made directly on the invoice, acq.invoice_item |
| 17:17 |
berick |
if it's made from the PO pre-invoicing, it starts on acq.po_item |
| 17:17 |
Bmagic |
I see, that's probably it |
| 17:20 |
Bmagic |
funny, there isn't a PO on these invoices |
| 17:20 |
Bmagic |
probably normal |
| 17:21 |
berick |
yeah, it's not required |
| 18:13 |
|
jamesrf joined #evergreen |
| 20:59 |
|
wsmoak_ joined #evergreen |
| 20:59 |
|
wsmoak joined #evergreen |
