| 06:01 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-06/2022-06-03_04:00:04/test.49.html> |
| 07:16 |
|
rjackson_isl_hom joined #evergreen |
| 07:42 |
|
collum joined #evergreen |
| 08:05 |
|
RFrasur joined #evergreen |
| 12:34 |
* pinesol |
brews and pours a cup of Colombia Huila Supremo, and sends it sliding down the bar to Character Set |
| 14:14 |
jeffdavis |
unapi.metabib_virtual_record_feed is incredibly slow in our production database: ~30 seconds to return results for 10 records, ~2s for a single record. In a Concerto db I get results for 10 records in less than 1s. |
| 14:27 |
Dyrcona |
Probably needs an index on something. |
| 15:22 |
jeffdavis |
No, it's weirder than that I think. |
| 15:22 |
jeffdavis |
It's actually the call to unapi.mmr_holdings_xml from within unapi.metabib_virtual_record_feed that's slow. |
| 15:23 |
jeffdavis |
unapi.mmr_holdings_xml takes ~23s for my test query ... but an SQL query that ought to be equivalent to that function takes <1s |
| 15:25 |
Dyrcona |
You say the query is "equivalent." Is it identical to the one used in the function? |
| 15:29 |
jeffdavis |
looks like our version of unapi.mmr_holdings_xml uses evergreen.array_remove_item_by_value in a few places instead of array_remove |
| 15:30 |
jeffdavis |
I'll see if I can make things more exact |
| 16:24 |
Dyrcona |
I think you alter the function to change the owner. |
| 16:25 |
Dyrcona |
Yeah, ALTER FUNCTION name [ ( [ [ argmode ] [ argname ] argtype [, ...] ] ) ] OWNER TO { new_owner | CURRENT_USER | SESSION_USER } |
| 16:27 |
|
jvwoolf left #evergreen |
| 16:28 |
jeffdavis |
unfortunately it doesn't help - changed the owner to evergreen in a test env and the function is still slow |
| 16:32 |
jeffdavis |
modifying it to use array_remove doesn't help either |
| 16:36 |
Dyrcona |
That's puzzling. It seems like a crazy hit to take for calling a function. |
| 16:40 |
jeffdavis |
yeah seems to be 2.5s per item in the array |
| 16:43 |
Dyrcona |
jeffdavis: You could try asking in #postgresql. Somebody there might have some idea what's going on. |
| 16:44 |
jeffdavis |
Good idea. Thanks for the help! |
| 16:59 |
|
mmorgan left #evergreen |
| 18:00 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-06/2022-06-03_16:00:02/test.49.html> |
| 06:02 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-06/2022-06-02_04:00:04/test.49.html> |
| 07:17 |
|
rjackson_isl_hom joined #evergreen |
| 08:07 |
|
rfrasur joined #evergreen |
| 08:29 |
|
mantis1 joined #evergreen |
| 12:22 |
|
collum joined #evergreen |
| 12:37 |
Dyrcona |
We started getting reports of bug 1976403 yesterday: one yesterday and one today so far. |
| 12:37 |
pinesol |
Launchpad bug 1976403 in Evergreen "Advanced search checkboxes missing / incorrectly positioned in Bootstrap OPAC" [High,Confirmed] https://launchpad.net/bugs/1976403 |
| 13:05 |
Dyrcona |
jeff's workaround of removing form-check-input works on my test vm. I think I'll throw this in production later. |
| 13:13 |
jeffdavis |
We've got a local customization that shows global "news" updates on the splash page. The implementation isn't right for general use (the content is pulled from an external source and displayed in an iframe) but it's a feature we'd like to see in stock EG. Not sure if it serves precisely the same function as a maintenance message would. |
| 13:14 |
Dyrcona |
jeffdavis: My mind was moving toward something more generic than just a message thing. I was heading toward a message of the day feature with expiration dates, etc. |
| 13:15 |
Dyrcona |
With the possibility of having multiple messages display based on org unit hierarchy as well and some way to provide the messages in multiple/appropriate languages. |
| 15:04 |
|
jonadab joined #evergreen |
| 16:05 |
|
jvwoolf1 left #evergreen |
| 17:21 |
|
mmorgan left #evergreen |
| 18:01 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-06/2022-06-02_16:00:01/test.49.html> |
| 18:18 |
jeffdavis |
last couple of comments on bug 1820381 are interesting to see |
| 18:18 |
pinesol |
Launchpad bug 1820381 in Evergreen "Staff login, Admin menu shows but. Login windows reamain" [Undecided,Invalid] https://launchpad.net/bugs/1820381 |
| 06:02 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-05/2022-05-31_04:00:04/test.49.html> |
| 07:12 |
|
rjackson_isl_hom joined #evergreen |
| 07:48 |
|
RFrasur joined #evergreen |
| 08:30 |
|
mmorgan joined #evergreen |
| 11:55 |
Dyrcona |
Isn't web development fun? |
| 11:56 |
pinesol |
News from commits: Docs: Cover Image Upload documentation <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=0b911310ae9bf42554d880c074bac1c7e68a4925> |
| 12:00 |
phasefx |
berick: I'm thinking I'm just going to insert some special case handling at the top of dispatch_sip2_request for the few things that might happen prior to an actual login |
| 12:01 |
jeff |
I wonder on the ul/li/div/label/input nesting. |
| 12:06 |
|
jihpringle joined #evergreen |
| 12:08 |
jeff |
mmorgan: what OS did you test on? when you load https://demo.evergreencatalog.com/eg/opac/advanced and expant the Item Type search filter, are there checkboxes next to each item for a total of 14 checkboxes? |
| 12:09 |
berick |
phasefx: hm, is resending the last response supported by the current SIP server? |
| 12:11 |
mmorgan |
jeff: Windows 10 - and I DO see the problem under the expanded search filters where I hadn't looked before. |
| 12:11 |
jeff |
mmorgan: ah, ok. good to know. thanks! :-) |
| 12:12 |
berick |
phasefx: huh, i guess it does. can't say I've ever encountered that in the wild. curious if you have. |
| 12:13 |
phasefx |
berick: it did pass the existing tests, at least, though I think there were was a regression when I last checked |
| 12:15 |
phasefx |
berick: I'll ask about in the wild; my experience here is limited |
| 12:15 |
phasefx |
I was going to fake it for the pre-login case, because the only possible message we coudl repeat is ACS status |
| 12:15 |
phasefx |
haven't thought about stateful vs stateless yet |
| 12:19 |
berick |
phasefx: is this coming from the sip tests? just wondering if we really need this |
| 12:20 |
phasefx |
berick: as far as I know that's the only impetus, that, and it was explicitly requested to be tested, but those requests may be have been derived from the existing tests.. circular :) |
| 12:20 |
* phasefx |
is all for punting |
| 12:23 |
berick |
k. if we need it, i'd prefer to fully implement it instead of just handling the test case, but this seems like one of those features (like checksums) that are unnecessary on modern networks. |
| 12:23 |
berick |
i could be wrong |
| 12:24 |
phasefx |
berick: roger that; I'll just have the tests bail early with a Not Implemented for now and we can revisit |
| 12:25 |
berick |
cool, thanks phasefx |
| 12:25 |
phasefx |
berick++ |
| 12:30 |
|
jihpringle joined #evergreen |
| 13:08 |
pinesol |
Dyrcona: Mr. Spock: Something fascinating just happened. |
| 13:12 |
Dyrcona |
The workaround from the latter bug doesn't work for me on CW MARS catalog, but that could be because Chrome is still running even thought I shut it down. |
| 13:14 |
Dyrcona |
Nope. Still doesn't work after stopping all chrome processes. I even got a message when I started Chrome saying that I was using an "unsupported feature" so maybe that's not exactly our bug, but possibly related. |
| 13:27 |
jeff |
Dyrcona: the suggested workaround does not appear to fix the test case in the original bug I linked, either. |
| 13:27 |
jeff |
they might be two different issues. |
| 13:27 |
jeff |
this test case: https://bugs.chromium.org/p/chromium/issues/detail?id=1329877#c6 |
| 13:28 |
jeff |
the "good" version of that test is "small red square below larger green square". the "bad" is "small red square on top of larger green square" (roughly) |
| 13:28 |
Dyrcona |
Yeahp. I was going by the comment on the bug you shared and the screenshot on the second that shows icons behaving like our checkboxes. |
| 14:33 |
|
mantis2 joined #evergreen |
| 14:40 |
|
abowling joined #evergreen |
| 16:59 |
|
jvwoolf left #evergreen |
| 17:10 |
|
mmorgan left #evergreen |
| 17:47 |
|
rjackson_isl_hom joined #evergreen |
| 18:01 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-05/2022-05-31_16:00:02/test.49.html> |
