| Time |
Nick |
Message |
| 06:02 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-05/2022-05-31_04:00:04/test.49.html> |
| 07:12 |
|
rjackson_isl_hom joined #evergreen |
| 07:48 |
|
RFrasur joined #evergreen |
| 08:30 |
|
mmorgan joined #evergreen |
| 08:31 |
|
mantis1 joined #evergreen |
| 09:00 |
|
jvwoolf joined #evergreen |
| 09:03 |
|
Dyrcona joined #evergreen |
| 09:31 |
|
rjackson_isl_hom joined #evergreen |
| 10:26 |
pinesol |
News from commits: Docs: correction to Staff Portal Page docs <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=60e1bd4602d449f5bfd35a6108c5cccd69c04127> |
| 10:55 |
Dyrcona |
pinesol: Are you awake? |
| 10:55 |
pinesol |
Dyrcona: pretty sure there's already a bug report about that. |
| 10:56 |
pinesol |
News from commits: LP#1974195: fix memory leak when performing fleshed Fieldmapper search <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f79400864188583bf0a98ebc961ae04ba33595fa> |
| 11:31 |
jeff |
neat. Chrome 102 appears to break checkboxes in the "traditional" catalog search / boopac. compare Chrome 101 vs 102 on the Item Type options of Advanced Search for a quick repro. https://demo.evergreencatalog.com/eg/opac/advanced exhibits the issue for me. |
| 11:37 |
jeff |
Part of the symptom appears to be that the checkboxes all stack on top of each other next to the first item in the column. |
| 11:38 |
jeff |
removing the form-check-input class from each causes them to no longer be stacked. i suspect it's related to the absolute positioning that the form-check-input class has. |
| 11:38 |
mmorgan |
jeff: Hmm. I'm not seeing an issue with the checkboxes on demo.evergreencatalog.com, chrome 102.0.5005.61 |
| 11:39 |
jeff |
and indeed, disabling the "position: absolute;" rule on that class seems to remove the stacking also. |
| 11:41 |
jeff |
mmorgan: interesting. i have reproduced it on 103.0.5060.24 beta on macOS/arm64 and the original report came in on 102.0.5005.62. |
| 11:42 |
jeff |
(on Windows) |
| 11:43 |
Dyrcona |
I take it form-check-input comes from bootstrap. |
| 11:44 |
Dyrcona |
I also don |
| 11:44 |
|
rjackson_isl_hom joined #evergreen |
| 11:45 |
Dyrcona |
I'm not seeing it with Chrome 102.0.5005.61 on Linux with Evergreen 3.7.3 on the server. |
| 11:46 |
Dyrcona |
Oh, wait a minute. I am seeing it. |
| 11:47 |
phasefx |
berick: just a heads up in case you have any advice/tuits that I'm trying to get SIP2Mediator to work with ACS Resend Request and am bumping into SIP2_SESSION_REQUIRED |
| 11:47 |
Dyrcona |
jeff: It seems a bit inconsistent, though. Some are stacked, but not all are. |
| 11:50 |
jeff |
Yes, form-check-input does come from bootstrap, and the position: absolute seems to have gone away between bootstrap 4 and 5. |
| 11:55 |
Dyrcona |
Isn't web development fun? |
| 11:56 |
pinesol |
News from commits: Docs: Cover Image Upload documentation <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=0b911310ae9bf42554d880c074bac1c7e68a4925> |
| 12:00 |
phasefx |
berick: I'm thinking I'm just going to insert some special case handling at the top of dispatch_sip2_request for the few things that might happen prior to an actual login |
| 12:01 |
jeff |
I wonder on the ul/li/div/label/input nesting. |
| 12:06 |
|
jihpringle joined #evergreen |
| 12:08 |
jeff |
mmorgan: what OS did you test on? when you load https://demo.evergreencatalog.com/eg/opac/advanced and expant the Item Type search filter, are there checkboxes next to each item for a total of 14 checkboxes? |
| 12:09 |
berick |
phasefx: hm, is resending the last response supported by the current SIP server? |
| 12:11 |
mmorgan |
jeff: Windows 10 - and I DO see the problem under the expanded search filters where I hadn't looked before. |
| 12:11 |
jeff |
mmorgan: ah, ok. good to know. thanks! :-) |
| 12:12 |
berick |
phasefx: huh, i guess it does. can't say I've ever encountered that in the wild. curious if you have. |
| 12:13 |
phasefx |
berick: it did pass the existing tests, at least, though I think there were was a regression when I last checked |
| 12:15 |
phasefx |
berick: I'll ask about in the wild; my experience here is limited |
| 12:15 |
phasefx |
I was going to fake it for the pre-login case, because the only possible message we coudl repeat is ACS status |
| 12:15 |
phasefx |
haven't thought about stateful vs stateless yet |
| 12:19 |
berick |
phasefx: is this coming from the sip tests? just wondering if we really need this |
| 12:20 |
phasefx |
berick: as far as I know that's the only impetus, that, and it was explicitly requested to be tested, but those requests may be have been derived from the existing tests.. circular :) |
| 12:20 |
* phasefx |
is all for punting |
| 12:23 |
berick |
k. if we need it, i'd prefer to fully implement it instead of just handling the test case, but this seems like one of those features (like checksums) that are unnecessary on modern networks. |
| 12:23 |
berick |
i could be wrong |
| 12:24 |
phasefx |
berick: roger that; I'll just have the tests bail early with a Not Implemented for now and we can revisit |
| 12:25 |
berick |
cool, thanks phasefx |
| 12:25 |
phasefx |
berick++ |
| 12:30 |
|
jihpringle joined #evergreen |
| 12:36 |
jeff |
this looks like it might be the same as or similar to our checkbox input issue: https://crbug.com/1329877 |
| 13:02 |
Dyrcona |
Looks like it. The linked Atlassian bug also seems to be the same thing and looks more like what we see: https://bugs.chromium.org/p/chromium/issues/detail?id=1329424 |
| 13:03 |
Dyrcona |
@blame NGFlexLayout |
| 13:03 |
pinesol |
Dyrcona: NGFlexLayout is NOT CONNECTED TO THE NETWORK!!! |
| 13:03 |
Dyrcona |
@blame NGFLexlFragmentation |
| 13:03 |
pinesol |
Dyrcona: NGFLexlFragmentation is NOT CONNECTED TO THE NETWORK!!! |
| 13:04 |
Dyrcona |
pinesol: Are you connected to the network? |
| 13:04 |
pinesol |
Dyrcona: <shaggy>We're, like, doomed.</shaggy> |
| 13:08 |
Dyrcona |
@dunno |
| 13:08 |
pinesol |
Dyrcona: Mr. Spock: Something fascinating just happened. |
| 13:12 |
Dyrcona |
The workaround from the latter bug doesn't work for me on CW MARS catalog, but that could be because Chrome is still running even thought I shut it down. |
| 13:14 |
Dyrcona |
Nope. Still doesn't work after stopping all chrome processes. I even got a message when I started Chrome saying that I was using an "unsupported feature" so maybe that's not exactly our bug, but possibly related. |
| 13:27 |
jeff |
Dyrcona: the suggested workaround does not appear to fix the test case in the original bug I linked, either. |
| 13:27 |
jeff |
they might be two different issues. |
| 13:27 |
jeff |
this test case: https://bugs.chromium.org/p/chromium/issues/detail?id=1329877#c6 |
| 13:28 |
jeff |
the "good" version of that test is "small red square below larger green square". the "bad" is "small red square on top of larger green square" (roughly) |
| 13:28 |
Dyrcona |
Yeahp. I was going by the comment on the bug you shared and the screenshot on the second that shows icons behaving like our checkboxes. |
| 14:33 |
|
mantis2 joined #evergreen |
| 14:40 |
|
abowling joined #evergreen |
| 14:42 |
mmorgan |
jeff: Are you opening an lp bug? |
| 15:01 |
|
RFrasur joined #evergreen |
| 15:26 |
jeff |
I will, yes. |
| 15:26 |
mmorgan |
jeff++ |
| 15:26 |
jeff |
(even if the eventual resolution is WONTFIX) |
| 15:27 |
Dyrcona |
Well, it's not our bug, but I know that it will look like it is. |
| 15:28 |
Dyrcona |
jeff++ |
| 15:28 |
mmorgan |
Yes, at least folks can find the bug report when they encounter the issue. |
| 15:52 |
jeff |
bug 1976403 |
| 15:52 |
pinesol |
Launchpad bug 1976403 in Evergreen "Advanced search checkboxes missing / incorrectly positioned in Bootstrap OPAC" [Undecided,New] https://launchpad.net/bugs/1976403 |
| 16:05 |
Dyrcona |
jeff: I confirmed it. |
| 16:09 |
jeff |
mmorgan++ Dyrcona++ |
| 16:57 |
pinesol |
News from commits: Docs: Alternate Notice Templates documentation <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=22e45195f2274e3ef7e23df5d0211c5f2d9dba40> |
| 16:59 |
|
jvwoolf left #evergreen |
| 17:10 |
|
mmorgan left #evergreen |
| 17:47 |
|
rjackson_isl_hom joined #evergreen |
| 18:01 |
pinesol |
News from qatests: Failed Running perl live tests <http://testing.evergreen-ils.org/~live//archive/2022-05/2022-05-31_16:00:02/test.49.html> |
