| 11:34 |
* csharp |
finds http://wiki.evergreen-ils.org/doku.php?id=dev:browser_staff:dev_notes |
| 11:34 |
Dyrcona |
Actually, we're using less these days. |
| 11:35 |
Dyrcona |
Yeah, I remember reading that there was a reason. |
| 11:35 |
berick |
Dyrcona: i was wondering about real-world data. most of my tests were on develpment servers. |
| 11:35 |
Dyrcona |
I can take a peek later. |
| 11:37 |
csharp |
ah - there it is: https://esilibrary.com/exploring-websockets-and-evergreen-iii-proof-of-concept/#sthash.XUhhjAT7.dpbs |
| 11:39 |
* berick |
keeps meaning to try https://www.nginx.com/blog/websocket-nginx/ |
| 11:41 |
pinesol_green |
kitteh_ wrote The Great Big Book of Evergreen. |
| 11:43 |
|
bmills joined #evergreen |
| 11:43 |
|
mllewellyn joined #evergreen |
| 11:45 |
jeff |
I'm thinking of scripting up a SIP smoke test to retrieve all patrons and all items via SIP with the intent of uncovering ways that SIPServer and/or the Evergreen SIP implementation fall over. I might later expand it a bit. Would anyone here be interested in running something like that against live data in a test system? |
| 11:45 |
jeff |
I suppose I'll just try and make it vaguely non-specific and share and go from there. |
| 11:45 |
csharp |
jeff: yes, but after our upgrade over next weekend |
| 11:46 |
jeff |
csharp: what, not during!? |
| 11:47 |
berick |
wimp |
| 12:47 |
pinesol_green |
Launchpad bug 1470957 in Evergreen 2.9 "Items are incorrectly sorting when using the Sort By Publication date feature" [Medium,New] |
| 12:47 |
bshum |
So weird stuff happens with pubdate sorting |
| 12:47 |
kmlussier |
krvmga: Yeah, looking at bug 1470957, I see it refers to date1, which is a fixed field thing. |
| 12:47 |
berick |
speaking of acq, looking for takers to test bug #1333254. (No EDI required). |
| 12:47 |
pinesol_green |
Launchpad bug 1333254 in Evergreen "EDI invoices automatically expend debits" [Wishlist,Confirmed] https://launchpad.net/bugs/1333254 |
| 12:48 |
kmlussier |
huh, pinesol_green must like berick more than me. |
| 12:48 |
kmlussier |
bug 1470957 |
| 13:56 |
csharp |
since bug 1207533 renders Triggered Events effectively useless, we're thinking of greying it out instead |
| 13:56 |
pinesol_green |
Launchpad bug 1207533 in Evergreen 2.9 "Triggered event log times out for large-data sites" [Medium,Confirmed] https://launchpad.net/bugs/1207533 |
| 14:02 |
|
Stompro joined #evergreen |
| 14:18 |
tsbere |
csharp: I bet it is because they share a URL |
| 14:23 |
tsbere |
csharp: More specifically, I believe the issue is related to the deck.js file and the fact they both use the "browser" URL as their target. |
| 14:25 |
* tsbere |
has an idea to fix it, but wants to test it quick first....which means waiting for his dev machine to reload |
| 14:29 |
|
jihpringle_ joined #evergreen |
| 14:29 |
|
jboyer_isl joined #evergreen |
| 14:29 |
|
collum joined #evergreen |
| 14:29 |
|
gsams joined #evergreen |
| 14:32 |
csharp |
tsbere: I'm heading home, but I'll check back in when I get there (FYI, in case you get to a point where I can assist with testing) |
| 14:33 |
tsbere |
csharp: My test says my idea works. I'll make a working branch for you to poke at. |
| 14:33 |
csharp |
rock on |
| 14:36 |
|
rangi` joined #evergreen |
| 14:36 |
tsbere |
@later tell csharp http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/differentiate_patron_urls |
| 16:03 |
Bmagic |
agreed - in fact that is our plan |
| 16:03 |
Bmagic |
but in order to do that, it seems, we have to change the code to "not mess with our headers" |
| 16:05 |
tsbere |
Bmagic: Should be trivial to make such changes, from what I can see. |
| 16:05 |
Bmagic |
tsbere: we have it working on a test server by commenting out the three lines there in SendEmail.pm |
| 16:05 |
Bmagic |
But I thought I would ask if anyone else accomplished this |
| 16:07 |
tsbere |
Bmagic: I would change them to have "unless $email->header('???')" on the end. |
| 16:07 |
tsbere |
Then if the A/T sets the headers they stay as what the A/T set, otherwise they get the (hopefully sane) defaults |
| 17:08 |
TheMadGunt |
Hello out there |
| 17:08 |
hopkinsju |
The problem is that a search from their system to ours will turn up results one time, then subsequent searches for the same thign turn up 0 results. It'll do that for a while before it starts working again. Seems to me that their system is dropping the connection. |
| 17:08 |
hopkinsju |
Hi there TheMadGunt |
| 17:10 |
TheMadGunt |
I was hoping someone could help me out. Stuck on a step doing a test server install |
| 17:11 |
TheMadGunt |
Step 10.2 - Creating the Database |
| 17:11 |
bshum |
hopkinsju: It wouldn't surprise me if there was something funky going on. Any log data to support your theory? For us, I always smirked at their SUPER old version of yaz that they were using. |
| 17:11 |
hopkinsju |
Cool, well hopefully we can help you :-) |
| 13:56 |
bshum |
We got something like <xsl:variable name="locname" select="$lid" /> in our .xsl file that draws from |
| 13:56 |
bshum |
So I assume that's how we get the full name of the library for lid |
| 13:57 |
jboyer_isl |
I think ours was an xsl change. That’s what I was referring to with the contains comment. Something in the xslt processing was using it instead of =. |
| 13:57 |
bshum |
Maybe I'll make a new variable |
| 13:57 |
bshum |
And test it by changing one of them to use shortname |
| 13:57 |
bshum |
And then convert everything over |
| 14:22 |
bshum |
In any case, tsbere++ rjackson_isl++ jboyer_isl++ |
| 14:22 |
bshum |
Thanks for feedback guys! Appreciate it :) |
| 15:05 |
|
graced joined #evergreen |
| 15:16 |
|
Ivran joined #evergreen |
| 15:19 |
Ivran |
Would someone be able to tell me what I am doing wrong in trying to run this Evergreen report...? All I am trying to do is run a report that counts the number of patrons assigned a particular stat category. |
| 15:29 |
bshum |
I think I've heard of what jboyer_isl is describing, but unfortunately have not used it before |
| 15:32 |
jboyer_isl |
It lets you choose between left, inner, and sometimes right joins on the tables in the reporter. Default means “whatever the system thinks is best” which is usually left, I think. |
| 15:34 |
|
Ivran_ joined #evergreen |
| 15:34 |
Ivran_ |
I don't think the web client likes me very much. -- I will give the nullability a test and see what I can learn, though! |
| 15:37 |
jboyer_isl |
Ivran: you’ll probably want to choose links that have None in the Nullable column when you’re selecting the stat cat fields. That way you can inner join the user and SC tables to only look at users with SC entries, then you have to display the entry value (not sure of the field names off hand) and a count distinct on entry id to get the totals for each value. |
| 15:38 |
Ivran_ |
jboyer_isl: Thank you! I think I can attempt that well enough. I'll see what I can do. |
| 15:41 |
Bmagic |
Ivran_: I have had similar difficulties with stat cats - nullable is the answer |
| 15:41 |
Bmagic |
because not all patrons have a row in the stat cat tables |
| 15:43 |
Ivran_ |
I'm brand new to this, so I just keep trying until I get it. |
| 15:49 |
Ivran_ |
Ciao for now. I'll come back if I can't figure it out. Thank you! |
| 15:58 |
bshum |
dbwells: https://bugs.launchpad.net/evergreen/+bug/1526543 didn't have a pullrequest on it, but it looked fine for testing, I'm going to go ahead and push it through, though for note, the default is that reset_password = 'true' so the test approach as described confused me initially :\ |
| 15:58 |
pinesol_green |
Launchpad bug 1526543 in Evergreen 2.9 "Cannot disable password reset in TPAC" [Low,New] |
| 15:59 |
bshum |
I may update the test instruction in the git commit message to reflect the actual default and the need to alter the config.tt2 to set that to false. |
| 16:01 |
dbwells |
bshum: heh, sorry about that. I guess I assumed it was false, since optional things are often off by default. It does make more sense now that nobody else notice it :) And, thank you! |
| 16:02 |
bshum |
dbwells: Cool, cool |
| 16:02 |
bshum |
dbwells++ remingtron++ |
| 05:09 |
|
rlefaive joined #evergreen |
| 07:32 |
jboyer-isl |
miker: Yeah, just venting. I'm probably going to try a couple of OS tests today. (never got around to it yesterday.) The only difference between our G8 server that's working perfectly and these G9's that aren't are their G's. (Same NICs, etc.) I may try 12.04 to see if it makes any difference. |
| 07:33 |
jboyer-isl |
I would be equal parts relieved / disappointed if that works. |
| 07:43 |
|
graced joined #evergreen |
| 07:49 |
|
mrpeters joined #evergreen |
| 07:54 |
|
rlefaive joined #evergreen |
| 07:55 |
|
rjackson_isl joined #evergreen |
| 07:57 |
|
ericar joined #evergreen |
| 08:08 |
miker |
kmlussier: from yesterday afternoon, I've updated the bugs. tl;dr: mod_perl code is not feasibly testable in the way that opensrf app code (via live tests) or db changes (via pgTAP) are -- and, the changes are covered by syntax checks to the same degree as the rest of the mod_perl code, already. |
| 08:08 |
* miker |
runs away for an appointment |
| 08:32 |
|
mrpeters1 joined #evergreen |
| 08:45 |
|
jboyer-isl joined #evergreen |
| 08:46 |
|
Dyrcona joined #evergreen |
| 09:58 |
|
jwoodard joined #evergreen |
| 10:04 |
Dyrcona |
"He's running the scripts....He's checkin' 'em twice." |
| 10:04 |
Dyrcona |
"He's gonna find out which are naughty or nice." |
| 10:05 |
Dyrcona |
"Santa Dev is testing a branch." |
| 10:05 |
Dyrcona |
Don't mind me.... |
| 10:06 |
miker |
Dyrcona: when I'd just seen the first line I heard it to the tune of going the distance by cake... |
| 10:06 |
Dyrcona |
heh. |
| 10:06 |
Dyrcona |
That could make a good base for a development parody song, too. |
| 10:07 |
Dyrcona |
He's runnin' the perl tests....He's timin' for speed.... |
| 10:15 |
jeff |
I wonder if metacpan has a "rhymes with" search option for modules... |
| 10:26 |
|
rlefaive joined #evergreen |
| 10:54 |
|
ericar_ joined #evergreen |
| 11:06 |
Dyrcona |
4518 files changed, 1017556 insertions(+), 300704 deletions(-) |
| 11:10 |
tsbere |
Was a bit behind master. ;) |
| 11:10 |
Dyrcona |
6,882 commits behind you said. |
| 11:11 |
csharp |
@quote add 10:04 < Dyrcona> "He's running the scripts....He's checkin' 'em twice. He's gonna find out which are naughty or nice. Santa Dev is testing a branch." |
| 11:11 |
pinesol_green |
csharp: The operation succeeded. Quote #134 added. |
| 11:12 |
tsbere |
Not that the rebase changed much beyond "stop merge from throwing a minor fit", I believe |
| 11:12 |
Dyrcona |
Yeah, warnings about inexact rename detection and setting a limit to at least 2,977. ;) |
| 09:35 |
miker |
jboyer-isl: I'm sure you've already investigated this, but we've seen auto-sensing duplex settings fail with HP NICs and some switches ...have to force port speeds and duplex settings. the symptoms are what you describe |
| 09:36 |
* Dyrcona |
has seen auto-sensing fail with a number of different NICs. |
| 09:39 |
|
jlundgren joined #evergreen |
| 09:44 |
kmlussier |
A question about our QA guidelines. A good percentage of the fixes I loaded for Bug Squashing Day have changes made to a .pm file, but I don't think any had a regression test. |
| 09:45 |
kmlussier |
I just want to make sure I'm clear on the guidelines before I start adding needstest tags. Any change made to perl code since May of this year, no matter how large or how small, should have a test? Is that right? |
| 09:46 |
|
ericar_ joined #evergreen |
| 09:51 |
Dyrcona |
kmlussier: I don't think we have been quite that strict, although "should" is a recommendation, not a commandment. |
| 09:51 |
Dyrcona |
My understanding is if the commit messages provide adequate test instructions, the live test can be waived. |
| 09:53 |
kmlussier |
I thought the waiver was only given when there is a statement from the patch author explaining why a test is infeasible without significant refactoring |
| 09:53 |
* csharp |
gets indecisive about which bugs to focus on. Candidates today are bug 1175293 (highest "heat" of acq bugs), bug 1413352, and bug 924952 |
| 09:53 |
pinesol_green |
Launchpad bug 1175293 in Evergreen "ACQ: Allocate to Fund drop down menu (in Funding Source) Not Following Precedents Set by Other Fund Menus" [Medium,Confirmed] https://launchpad.net/bugs/1175293 |
| 09:54 |
pinesol_green |
Launchpad bug 1413352 in Evergreen "New Brief Record estimated price does not populate" [High,Confirmed] https://launchpad.net/bugs/1413352 |
| 09:54 |
pinesol_green |
Launchpad bug 924952 in Evergreen "Acquisitions: Order record loads fail when there is a null value in a holdings subfield" [High,Confirmed] https://launchpad.net/bugs/924952 |
| 09:54 |
Dyrcona |
csharp: Those look like good ones to work on to me. |
| 09:54 |
jeff |
I'm not sure what's more realistic: working toward a point where we aren't considering waiving tests like that, or expecting that regression testing is accomplished by reading commit messages and manually testing things as directed there. |
| 09:54 |
jeff |
(on all future commits) |
| 09:55 |
|
yboston joined #evergreen |
| 09:55 |
Dyrcona |
jeff: I agree. I think we want tests on all things in the future. It's a matter of taking the time to get there. |
| 09:55 |
kmlussier |
I didn't think the commit messages / manual instructions were related to whether a test was provided or not. It was just something that is a best practice to include in any bug fix. |
| 09:56 |
jeff |
@decide kick the can down the road[map] or test paralysis |
| 09:56 |
pinesol_green |
jeff: go with kick the can down the road http://www.firstpersontetris.com/ |
| 09:56 |
Dyrcona |
Well, that was my understanding. I could be mistaken. |
| 09:56 |
* jeff |
gives pinesol_green a look |
| 09:56 |
|
genpaku joined #evergreen |
| 09:57 |
csharp |
@decide [someone] or [someone |
| 09:57 |
pinesol_green |
csharp: Error: Missing "]". You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands. |
| 09:57 |
Dyrcona |
I know some bug fixes have been written and pushed since May that have not had live tests. |
| 09:57 |
csharp |
@decide [someone] or [someone] |
| 09:57 |
pinesol_green |
go with ericar |
| 09:57 |
jeff |
here i was hoping that pinesol_green would give us the kobayashi maru style solution when presented with those two equally undesirable options. :P |
| 09:58 |
kmlussier |
OK, but in re-reading that, if it is waived, an additional signoff is required. So, for the bug I'm looking at now, I guess I shouldn't be merging it because it either requires a test or requires an additional signoff. |
| 09:59 |
Dyrcona |
What we really need it a complete regression suite. Basically what we have are a strange hybrid of unit tests and some regression tests of some features. |
| 10:00 |
kmlussier |
But we will have more regression tests of more features if we continue to strongly encourage people to follow the guidelines. |
| 10:01 |
kmlussier |
Unless there is someone out there who has time to write a complete regression suite. :) |
| 10:02 |
Dyrcona |
Someone would have to make that a priority, yes, and devote resources to it. |
| 10:05 |
dbwells |
kmlussier: My understanding of the new test recommendations are the same as yours, though I'm also pretty sure that Dyrcona is right, and others have pushed stuff in without tests (which has generally confused me, and also made me wonder if others felt the descriptive tests were adequate) |
| 10:07 |
Dyrcona |
It was acknowledged that somethings are difficult to test, but I'll go along with requiring tests if that is what others understood. |
| 10:07 |
kmlussier |
Yeah, I don't doubt that some things have been merged without the tests. |
| 10:07 |
Dyrcona |
It could just be a minority (me) who misunderstood. :) |
| 10:14 |
dbwells |
It also isn't explicit in the 2.9 section of the document, but in my understanding we are still only requiring at least one new relevant test with each patch, not a complete and extensive suite (though it would be welcomed :) ). |
| 10:16 |
kmlussier |
Ok, so it looks like the guidelines were formalized at the August dev meeting. What I'm going to do then, for the patches I loaded on Sandboxes, is if the patch was created since August and makes any change to perl or database code, I'll add the needstest tag. |
| 10:16 |
kmlussier |
If it seems excessive for the code being changed, there is always that waiver that a dev can request if it seems excessive. |
| 10:16 |
kmlussier |
Bleh. Just a bit of redundancy in that sentence. |
| 10:19 |
|
rlefaive joined #evergreen |
| 10:24 |
Dyrcona |
I wonder if both pgtap and perl tests are required when the perl tests sufficiently exercise the database changes, but that could be a different discussion. |
| 10:24 |
* Dyrcona |
has a specific branch in mind where he added perl tests but not a pgtap test for the database changes, because function changes can be tricky in pgtap. |
| 10:24 |
kmlussier |
My gut reaction is that if the perl test sufficiently exercises the database changes, the perl test should be adequate. |
| 10:25 |
dbwells |
I agree. |
| 10:27 |
Dyrcona |
Sounds good to me. :) |
| 10:27 |
* Dyrcona |
returns to modifying a library's circ parameters. |
| 10:28 |
kmlussier |
For the discussion we just had, those tests are just for patches that fix bugs, right? In the case of jeff's code for bug 1013786, then, they wouldn't be required since it really is a new feature. |
| 10:28 |
pinesol_green |
Launchpad bug 1013786 in Evergreen "tpac: Check for password strength at login" [Medium,Confirmed] https://launchpad.net/bugs/1013786 - Assigned to Christine Burns (christine-burns) |
| 10:28 |
kmlussier |
I know it' says Medium importance, but, at this point, it feels like new feature to me. |
| 10:30 |
kmlussier |
Heh, I suppose we can remove the jspacremovalblocker tag from that one. :) |
| 10:31 |
* jeff |
looks at that bug |
| 10:31 |
berick |
no, we have to merge jspac back in until all of those bugs are closed. |
| 10:32 |
jeff |
Oh, forgot I added pullrequest-worthy code to that bug. |
| 10:35 |
dbwells |
I think the test standards, whatever they may be, should apply more or less equally to bugs and new features. The document refers to "new code contributions", so I think it covers everything. |
| 10:36 |
dbwells |
(Of course, later parts reference "fixes a bug", so who knows :P) |
| 10:37 |
* kmlussier |
nods |
| 10:40 |
Dyrcona |
Right, I thought the standard for bug fixes was deliberately lower than for new features, and that may be 1 source of any misunderstanding. |
| 10:42 |
* Dyrcona |
awaits angularpac.... ;) |
| 10:52 |
* Dyrcona |
isn't surprised. |
| 10:53 |
Dyrcona |
i might be surprised when you figure out the why, however. ;) |
| 10:54 |
* Dyrcona |
should revisit the circ history download bug with a new solution. |
| 10:55 |
kmlussier |
Once I focused just on patches added since August, the number requiring tests wasn't so high. |
| 10:55 |
* kmlussier |
returns to actual testing now. :) |
| 10:55 |
tsbere |
jeff: Do you have metarecord or part holds on no longer existing metarecords/parts? |
| 10:55 |
Dyrcona |
That would not surprise me. |
| 10:56 |
Dyrcona |
And I was think parts holds on part that have since disappeared. |
| 12:51 |
kmlussier |
But I know it doesn't reflect all of the work that has been happening |
| 12:53 |
|
mrpeters1 joined #evergreen |
| 13:14 |
|
mrpeters joined #evergreen |
| 13:19 |
mmorgan |
Bmagic: I'm testing lp 1331174. and am curious what your intervals for LONGOVERDUE and LOST are in production. |
| 13:19 |
pinesol_green |
Launchpad bug 1331174 in Evergreen "Long Overdue processing needs org unit settings separate from Lost Processing" [Wishlist,Confirmed] https://launchpad.net/bugs/1331174 - Assigned to Michele Morgan (mmorgan) |
| 13:20 |
mmorgan |
The seed mark Long Overdue trigger worked fine to mark items long overdue at 6 months. |
| 13:22 |
mmorgan |
Then I changed the mark Lost trigger to mark the items Lost at 7 months. But the Lost trigger didn't find anything to mark Lost. It's looking for transactions with stop_fines NULL or MAXFINES, so my LONGOVERDUE transactions didn't get picked up to be marked Lost. |
| 13:22 |
mmorgan |
Are you using a custom filter for this? |
| 13:24 |
|
mrpeters joined #evergreen |
| 13:31 |
* mmorgan |
run out for a bit |
| 13:38 |
jihpringle |
kmlussier: Am I correct in assuming that the mlnc2 test server isn't generating and sending email? |
| 13:39 |
jihpringle |
I've tested lp 1197636 up to the point where the email should be sent |
| 13:39 |
pinesol_green |
Launchpad bug 1197636 in Evergreen "Email record detail does not check for email" [Medium,Triaged] https://launchpad.net/bugs/1197636 - Assigned to Jennifer Pringle (jpringle-u) |
| 13:40 |
tsbere |
jihpringle: I do not believe any of those mlnc servers were set up for actually sending email. In general. |
| 13:45 |
kmlussier |
jihpringle: Sorry! You're correct. It's not configured to send email. I totally overlooked that need when I was setting it up. |
| 14:26 |
|
DPearl joined #evergreen |
| 14:28 |
pinesol_green |
[evergreen|Kathy Lussier] LP#1319998 Stamping upgrade script - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3e831ac> |
| 14:28 |
pinesol_green |
[evergreen|blake] LP1319998_materialized_summary_billing_del_ADDS_to_balance_owed - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=574cab2> |
| 14:41 |
jboyer-isl |
miker, Dyrcona: Just getting back from a meeting and reading scrollback. I had not come across suggestions to check that (my google-fu was weak) and it never occurred to me because 2015, but I'm absolutely testing that now. I was about to go install another OS to test, this is much faster. |
| 14:42 |
jboyer-isl |
If it works, you each get a meal/drink on me in NC. |
| 14:43 |
* mmorgan |
returns and catches up. |
| 14:45 |
jeff |
ahh, the fond days when 3com switches could lock up Cisco ethernet interfaces hard enough that Cisco would RMA them, but they really just needed to be power cycled. |
| 14:47 |
jlundgren |
I think I just confirmed my first (new) bug - https://bugs.launchpad.net/evergreen/+bug/1513231 |
| 14:54 |
jboyer-isl |
Oops, sad trombone. |
| 14:58 |
kmlussier |
mmorgan: Are you thinking that you would be setting a transaction to Longoverdue without a bill after, say, 3 months, and then setting it to Lost, with a bill after something like 6 months? |
| 14:59 |
|
jlundgren1 joined #evergreen |
| 14:59 |
mmorgan |
kmlussier: That's the scenario I'm testing, yes. |
| 15:00 |
kmlussier |
Bmagic / mmorgan: Would it be reasonable, then, to add a separate "Lost from Long Overdue" trigger that has the necessary json for those sites that want to use that workflow? |
| 15:01 |
kmlussier |
I can see why you wouldn't want to add it to the typical Lost trigger since there are sites that want to set it and leave it at Long Overdue. |
| 15:02 |
Bmagic |
kmlussier: it's probably not a bad idea to throw a stock AT idea in the branch - but there are a few possibilities |
| 15:15 |
mmorgan |
Would clear documentation on how to accomplish the longoverdue to lost be generally accepted? Or is it better to have the examples? |
| 15:19 |
jboyer-isl |
Network? More like Notwork. |
| 15:19 |
mmorgan |
jlundgren++ |
| 15:21 |
kmlussier |
Christineb: Would it be helpful to try the same workflow (if you have time) on another masslnc VM to see if the issue you encountered was caused by the new code? |
| 15:21 |
kmlussier |
Christineb: The VM's are nearly identical with the exception of the branches that were added for testing. |
| 15:21 |
Christineb |
kmlussier - Oh great idea, I will try that |
| 15:23 |
kmlussier |
mmorgan: I think it's generally preferable to have examples, but I don't think the lack of them is a showstopper. But I want to take a closer look at it too. |
| 15:24 |
kmlussier |
Christineb: You could probably hop on the one jihpringle is using. The access info is on the same spreadsheet. |
| 16:44 |
kmlussier |
dbwells: I had hoped to look at bug 1422379 today, but it looks like it wasn't meant to be. I hope to put some eyes on it soon, though. |
| 16:44 |
pinesol_green |
Launchpad bug 1422379 in Evergreen "Move money.billing timestamps back to moment of fine" [Medium,Triaged] https://launchpad.net/bugs/1422379 - Assigned to Kathy Lussier (klussier) |
| 16:45 |
dbwells |
kmlussier: Hey, thanks for trying. I've been looking at bugs for the last hour or so, and also generally getting stuck in one way or another. |
| 16:45 |
jlundgren1 |
stompro++ for testing in master build - https://bugs.launchpad.net/evergreen/+bug/1312699 |
| 16:45 |
pinesol_green |
Launchpad bug 1312699 in Evergreen "Editable Checkout History" [Wishlist,Triaged] - Assigned to Josh Stompro (u-launchpad-stompro-org) |
| 16:45 |
kmlussier |
Stompro: I'll need to check, but I think the sorting is something that is present in master already. It was a new 2.9 feature |
| 16:46 |
dbwells |
I think I'll report some "new" bugs instead (stuff we've had in production for a while, in some cases :( ). |
| 17:18 |
kmlussier |
Good night mmorgan! |
| 17:18 |
kmlussier |
Ah well, a bit too late |
| 17:19 |
miker |
jboyer-isl: based on "network? more like notwork" I'm guessing duplex and speed autosense was not the issue? |
| 17:23 |
kmlussier |
Just took a look at the signedoff bugs that also has a needstest bug. Other than the bug gmcharlt already commented on, there are two from miker http://bit.ly/1UvXOvc |
| 17:24 |
kmlussier |
miker: If those are examples of bugs where tests would be infeasible, could you note that on the bugs? I don't have a clear sense of what's infeasible and what's doable. |
| 17:37 |
kmlussier |
"101 bugs reported by me" Looks like I missed an opportunity to celebrate when I hit the 100 mark. |
| 17:40 |
berick |
bummed I could not participate today. |
| 17:40 |
berick |
bug_squashers++ |
| 17:42 |
kmlussier |
berick: Well, you do a lot of fixing between Bug Squashing Days. :) |
| 10:14 |
* Dyrcona |
wonders how that happened. |
| 10:14 |
jeff |
mrpeters: i wouldn't want to hazard a guess. if you're building debs, you can probably just patch it locally in the meantime as part of the usual build process on your end. |
| 10:14 |
Dyrcona |
I could try building a new 2.9.1 tarball, or anyone else could for that matter. |
| 10:15 |
Dyrcona |
I didn't test the fresh install from the tarball. |
| 10:15 |
mrpeters |
no, i certainly can patch it on our end that is no worries |
| 10:15 |
mrpeters |
but, maybe we should pull the tarball from the site until fixed? |
| 10:17 |
Dyrcona |
And, everyone just ignores me.... |
| 10:20 |
Dyrcona |
mrpeters jeff: I or anyone else can build a new 2.9.1 tarball and test it. I do not have time at this very moment to do that. |
| 10:21 |
mrpeters |
Dyrcona: I'm not suggesting you should have to. I am happy to fix it and test it -- I just don't know where the bug is |
| 10:21 |
Dyrcona |
mrpeters: Probably just one of those things that happens at the last minute. |
| 10:22 |
mrpeters |
no im not trying to assess blame or figure out what caused it -- i'm saying i dont know where the duplicated insert into the upgrade log occurs to fix the tarball and give you a new one |
| 10:22 |
Dyrcona |
Like you said, it works fine from git. |
| 10:23 |
jeff |
mrpeters: it should contain only one instance of that line. |
| 10:23 |
mrpeters |
jeff: perfect, thats exactly what i needed to know |
| 10:23 |
Dyrcona |
Yeah, probably because make_release was run more than once. |
| 10:23 |
mrpeters |
lets just pull it from git, don't you think? |
| 10:24 |
mrpeters |
and put the 002.schema.config.sql from git in the tarball and then i can test it and confirm its fixed and we can release it on the site |
| 10:24 |
jeff |
I don't know if there are other likely places where there will be issues that share the same underlying cause as that duplication. |
| 10:25 |
Dyrcona |
As much fun as this is, and as much as this is my fault, I have work to do for my employer, now. I'll catch up later if I can. |
| 10:25 |
mrpeters |
good point |
| 16:16 |
|
maryj joined #evergreen |
| 16:20 |
Dyrcona |
@eightball Will Francis lighten up? |
| 16:20 |
pinesol_green |
Dyrcona: It is so. |
| 16:37 |
phasefx |
re: qa tests, I'm changing the ultimate pass/fail logic for the "Installing Evergreen pre-requisites" section, so that it just considers the final return value from the pre-req Makefile. There are 3 "Result: FAIL"'s currently from 3rd party tests in that section, one for Business-PayPal-API, one for Business-OnlinePayment-PayPal, and an expected one for Class-DBI-Frozen-301 |
| 16:45 |
|
rlefaive joined #evergreen |
| 16:58 |
|
bmills joined #evergreen |
| 17:00 |
|
jlitrell joined #evergreen |
| 08:53 |
pgardella |
jboyer-isl++ |
| 08:53 |
pgardella |
jeff++ |
| 08:53 |
jboyer-isl |
Definitely. Now the simple fix is "is shared actually set to true" everywhere it needs to be? Hopefully that will be a simple fix. |
| 08:57 |
pgardella |
jboyer-isl: I think the issue is that the report templates are now owned by other users, which are not parent/child of one of the others. Most of the parents are null in template_folder |
| 08:58 |
pgardella |
All the folders except a few testing ones are shared, the templates just aren't where people expect them to be. |
| 08:58 |
jboyer-isl |
That's fine if they're not sub-folders. ("Templates", "Reports", and "Outputs" don't count as parent folders, even though that's how they're displayed.) |
| 09:00 |
* tsbere |
usually avoids sub-folders for a number of reasons |
| 09:21 |
|
jwoodard joined #evergreen |
| 13:43 |
jeff |
you can also \copy temp_staging FROM pstdin WITH CSV HEADER |
| 13:44 |
* csharp |
dives back into his "acq vandelay no longer creates copies" issue :-/ |
| 13:44 |
jeff |
which can be handy for something where you are using a psql variable like :somevar |
| 13:44 |
csharp |
I was hoping that upgrading the acq test server to 2.9.0 would Just Fix™ it |
| 13:45 |
jeff |
then you call psql -v somevar=3 -f script.sql dbname < $CSV_FILE |
| 13:46 |
csharp |
so hmm... what is supposed to happen if subfields are defined for a vendor/provider but not used in the file being uploaded? |
| 13:47 |
csharp |
$u barcode and $j call number are set up but they are not in the file being imported |
| 13:57 |
pinesol_green |
csharp: The operation succeeded. csharp hates acq way more than before. |
| 13:58 |
csharp |
well, they don't match in that barcode and call number are defined as holdings subfields but are not present in the uploaded file |
| 13:58 |
csharp |
but everything else lines up |
| 13:58 |
kmlussier |
csharp: I will confirm that mapping call number and barcode and then not including them in the upload shouldn't be a problem. I do it all the time in testing. |
| 13:58 |
csharp |
okay good |
| 13:59 |
csharp |
I *think* what I'm looking for is in the DB |
| 13:59 |
kmlussier |
csharp: They have values for quantity and owning library? |
| 14:01 |
csharp |
yep - that's where I'm spending a lot of my time lately |
| 14:02 |
csharp |
my coworkers love it! |
| 14:06 |
csharp |
huh acq.extract_provider_holding_data() returns no rows for one of the lineitems I just imported - maybe whatever is causing that not to work is the issue |
| 14:21 |
kmlussier |
csharp: I'm going to take back what I said earlier. I'm just retested, and I'm having trouble with the automatic barcode generation. I don't know if it's related to what's in the provider record or not. |
| 14:21 |
kmlussier |
I'm going to test a little further. |
| 14:21 |
kmlussier |
In my case, the acq.copies were generated, but I was getting a message saying that the barcode already exists. It was generating the same barcode for each lineitem. |
| 14:23 |
Dyrcona |
So, there isn't a good way to reprocess EDI messages, eh? |
| 14:23 |
Dyrcona |
IOW, it looks like it would be more hassle than it is worth. |
| 14:24 |
kmlussier |
@dunno |
| 14:24 |
pinesol_green |
kmlussier: Down time is a fact of business when you're a poor 501c3 corporation. |
| 14:25 |
Dyrcona |
But, to follow up on the conversation from hours ago, it does look like the problem with processing the invoic message was the space in the PO name. |
| 14:30 |
kmlussier |
csharp: After further testing, I can confirm that there is a problem with automatically generating barcodes if the provider record includes a subfield for barcodes but the incoming record doesn't include that subfield. |
| 14:31 |
csharp |
holy shiznit - I recreated the acq.extract_holding_attr_table function that was returning no rows with some RAISE NOTICE statements and after that it works |
| 14:31 |
csharp |
I have no idea why that would have work |
| 14:31 |
csharp |
ed |
| 14:31 |
csharp |
@eightball do we need to start reingesting acq functions now? |
| 14:31 |
pinesol_green |
csharp: Maybe... |
| 14:31 |
kmlussier |
csharp: Call numbers seem to generate fine in the same situation. Apparently, my comment above - "I do it all the time in testing" - was a big lie. |
| 14:31 |
csharp |
heh |
| 14:31 |
miker |
csharp: sounds like maybe you had an old version? |
| 14:32 |
csharp |
no idea |
| 15:29 |
dbwells |
csharp: Just read the backlog including the conclusion to your recent acq saga. Classic. :) Definitely been there once or twice. |
| 15:31 |
* dbwells |
feels better after thinking somehow, someway, he's the one who broke it |
| 15:39 |
csharp |
dbwells: I knew it was either something I did and didn't remember or something an end user did and wasn't saying ;-) |
| 15:41 |
phasefx |
out of sight, out of mind. QA tests have been failing for a while. Suspect it's the environment and not EG code. Need to resubscribe pinesol to the RSS feed |
| 15:43 |
kmlussier |
yikes |
| 16:14 |
berick |
dbwells: i'm done w/ bug 1468422 for now. i left the authproxy for you if you want it. |
| 16:14 |
pinesol_green |
Launchpad bug 1468422 in Evergreen "Improve Password Management and Authentication" [Undecided,New] https://launchpad.net/bugs/1468422 |
| 16:20 |
dbwells |
berick: Thanks. You're right, it should be very simple (and remove some of the ugliness from AuthProxy to boot). I appreciate your efforts to handle the hard bits, and I'll definitely make it a priority. |
| 16:20 |
berick |
dbwells++ |
| 16:38 |
mmorgan |
Lovely moonrise tonight! Though I hate that it happens at 4:30 :-( |
| 17:06 |
phasefx |
a lot better this time: http://testing.evergreen-ils.org/~live/ |
| 17:10 |
|
mmorgan left #evergreen |
| 17:11 |
kmlussier |
phasefx++ |
| 17:42 |
Bmagic |
anyone played with running more than one instance of Evergreen on the same postgres cluster? divided by database and dbuser? |
| 14:14 |
kmlussier |
miker then suggested that we try removing uniqueWords in addition to documentLength. And we did. |
| 14:14 |
kmlussier |
krvmga: That's what you went live with. |
| 14:14 |
* krvmga |
adds opensrf.xml file to watch list |
| 14:15 |
kmlussier |
It didn't work out very well. Coverage density didn't come into play at all. So we restored them. |
| 14:15 |
kmlussier |
krvmga: I think the lesson is, don't touch those settings unless you do a lot of testing ahead of time. I personally have been scared away from touching them ever again. |
| 14:15 |
krvmga |
lol |
| 14:16 |
kmlussier |
krvmga: If you think back to the phrase search bug we discovered this week, search relevance in your early days were very similar to those results. |
| 14:16 |
miker |
kmlussier: removing all is effectively the phrase bug I just fixed, BTW. |
| 14:16 |
krvmga |
heh |
| 14:16 |
kmlussier |
miker: Not sure why removing documentLength on its own didn't do anything for us, because it is a question that has come up time and time again at all of our sites. |
| 14:18 |
miker |
kmlussier: part of it is that "document" really means "each individual field indexed, on its own" in evergreen |
| 14:19 |
kmlussier |
Yeah, but IIRC, we were testing it on keyword searches at the time. And it's back before we had added additional indexes before the blob. |
| 14:20 |
miker |
which, for titles especially, is a pretty narrow range of lengths |
| 14:21 |
miker |
tuits, but it wouldn't hurt to analyze in detail |
| 14:21 |
kmlussier |
We've generally found that the preference for shorter documents also leads to older records coming up high, because apparently we didn't catalog as much detail decades ago. |
| 14:22 |
krvmga |
yes, we have seen that is so. |
| 14:22 |
kmlussier |
Yeah, it might be worth taking another look at again since I don't have the pressure of two upcoming migrations as I did the last time we looked at it. |
| 14:23 |
krvmga |
i'm up for it. what i'm trying to do is document and test and document... |
| 14:23 |
* krvmga |
has to run to another meeting. back in a while. |
| 14:24 |
kmlussier |
Yes. One thing I want to do is put some of the search configuration for C/W MARS and NOBLE on the Evergreen wiki as examples of what they have done for adding indexes and improving relevancy. Maybe putting failed experiments there would be worthwhile too. |
| 14:36 |
gmcharlt |
dbs: looking at bug 1516867, and a quick question: any objection if sortable were moved to under Open-ILS/web/js/ ? |
| 14:36 |
pinesol_green |
Launchpad bug 1516867 in Evergreen "HTML reports should be dynamically sortable" [Wishlist,Confirmed] https://launchpad.net/bugs/1516867 - Assigned to Galen Charlton (gmc) |
| 14:37 |
* berick |
bites the bullet and updates to 15.10 on the laptop |
| 14:39 |
dbs |
gmcharlt: no particular objections; I had avoided it largely because everything under web/js/ appeared to be dojo, but there's always a first :) |
| 14:40 |
dbs |
gmcharlt: would you like me to refactor and push a revised branch? |
| 14:41 |
gmcharlt |
dbs: that would be great; meanwhile I'll finish testing its functionality |
| 15:23 |
* dbs |
suspects a Google Form might help the "CC gmcharlt" barrage (then either working with a google sheet backend to generate the JSON, and/or store the JSON in git for pull request delight) |
| 15:24 |
gmcharlt |
yeah, we'll certainly want something of the sort by the time it goes from beta to production |
| 15:27 |
dbs |
Oh right, it was the disturbing nature of having a CSS file located under a /js/ directory that gave me pause :) |
| 15:29 |
gmcharlt |
but not unprecented; lots of CSS files accompanying the Dojo stuff under /js/ |
| 15:30 |
dbs |
gmcharlt: I've pushed the branch with a second commit; you can squash it if you like |
| 15:31 |
gmcharlt |
thanks |
| 15:31 |
dbs |
thanks for testing! |
| 15:31 |
gmcharlt |
speaking of which, my substantive feedback from said testing |
| 15:31 |
gmcharlt |
1. looks nice and necessary |
| 15:32 |
gmcharlt |
2. the time it takes to render the table and sort it can really bog down after a certain point. with some emperical testing I've done in the XUL client and Chrome, up to 10,000 rows or so is fine |
| 15:33 |
gmcharlt |
but 100,000 can be a browser-killer |
| 15:33 |
dbs |
I think 100,000 rows is a killer without any javascript, isn't it? |
| 15:33 |
gmcharlt |
since the average # of rows in report output I've measured for a large consortium today is 4,300, on average things are fine as is |
| 15:34 |
gmcharlt |
but I'm thinking that perhaps picking a magic row count number, after which the JS isn't loaded, might be good |
| 16:36 |
Dyrcona |
Well, the IDL is valid XML. |
| 16:36 |
Dyrcona |
All the services are running. |
| 16:39 |
Dyrcona |
Lots of warnings about subroutines being redefined, but no syntax errors in AppUtils or CStoreEditor. |
| 16:45 |
Dyrcona |
Hmm... AppUtils.pm has undergone some changes in the past few weeks, including some from a test branch of my own, so guess I did modify AppUtils. :) |
| 16:47 |
Dyrcona |
So, I added a new subroutine that looks good and self-contained. |
| 16:48 |
Dyrcona |
I would almost think if this failed that the staff client would be unusuable. |
| 16:54 |
|
vlewis joined #evergreen |
| 10:29 |
Bmagic |
it could* work |
| 10:30 |
Bmagic |
lol |
| 10:30 |
* bshum |
doesn't think he's ever played Doom. |
| 10:30 |
gmcharlt |
Dyrcona: indeed, better ways for staff to visualize and/or test circ policies would be great |
| 10:30 |
Dyrcona |
The idea behind the solver is to show you how your rules actually work. |
| 10:30 |
phasefx |
Dyrcona: one useful entrypoint might be from the item editor, but you'd need a lot of context options |
| 10:30 |
Dyrcona |
You put in barcodes and locations and it tells you what happens. |
| 10:30 |
Dyrcona |
phasefx: I have been considering something standalone that only talks to the database. |
| 10:31 |
phasefx |
probably the safest option as far as clutter goes |
| 10:31 |
Dyrcona |
Another option is to add an open-ils.circ-solver service and make calls against that. |
| 10:31 |
phasefx |
there is a circ test api call, IIRC |
| 10:32 |
gsams |
Dyrcona: As someone more or less on the outside of things, I think this is a great idea. |
| 10:32 |
miker |
you know, I thought there was a UI in the xul client for supplying a patron and item barcode to "fake" a circ... maybe just a wishlist thing from long ago |
| 10:32 |
Dyrcona |
phasefx: yeah, but it either does too much or doesn't do enough depending on what I want to know. :) |
| 10:33 |
Dyrcona |
Most of the db functions that I use are not exposed directly in the open-ils api. |
| 10:33 |
miker |
ah, well, nevermind me ... phasefx++ |
| 10:34 |
gmcharlt |
it's a start though - and I think it would be good if the code that test circ policies were essentially accessing exactly the same pathways that real loan and hold transactions do... just with additional instrumentation as needed for Dyrcona's purposes |
| 10:34 |
phasefx |
miker: there's a Test Circulation option for some A/T stuff; you may be thinking of that. I never played with it |
| 10:36 |
kmlussier |
gmcharlt: I was just reviewing your RM proposal on supporting the web client for production use. When you mention holds, are you thinking of all holds functions, including pull list and managing the holds shelf, or were you just thinking of things you would most commonly do while working with a patron, (i.e. placing, viewing, updating holds)? |
| 10:36 |
Dyrcona |
Lovely: ERROR: column "ccvm.ctype" must appear in the GROUP BY clause or be used in an aggregate function |
| 10:37 |
Dyrcona |
Guess string_agg( ccvm.ctype || 'something else') doesn't count..... |
| 16:05 |
Dyrcona |
Well, I suspect something is slightly off on the input, but I don't read EDI. |
| 16:06 |
berick |
Dyrcona: not even enough to be fun at parties? |
| 16:06 |
Dyrcona |
What I think should happen is the id: for the line items should come from the RFF+LI after the / or whatever. |
| 16:07 |
berick |
useful tool: cd Open-ILS/src/support-scripts/test-scripts/; perl edi_reader.pl <edi_file> |
| 16:07 |
Dyrcona |
What happens on this one is they all get the same number from somewhere else in the INVOIC. |
| 16:08 |
Dyrcona |
And that seems to be happening with all of the invoices from this vendor for this library, so I'm tempted to say, just stop using that vendor. ;) |
| 16:08 |
csharp |
@quote add < Dyrcona> Acquisitions: It's all EDI to me. |
