| Time |
Nick |
Message |
| 06:55 |
|
collum joined #evergreen |
| 08:34 |
|
mmorgan joined #evergreen |
| 08:43 |
|
mantis joined #evergreen |
| 09:03 |
|
Dyrcona joined #evergreen |
| 09:05 |
|
Dyrcona joined #evergreen |
| 09:26 |
Rogan |
love to see all those commits in the morning |
| 09:33 |
Dyrcona |
Perl and unicode.... |
| 09:34 |
Dyrcona |
So looks like there's a bug in MARC export with item fields that contain UTF-8 characters, like "ê" |
| 09:35 |
Dyrcona |
I think Perl needs to be told that the fields from the database are UTF-8. |
| 09:35 |
Dyrcona |
Also, who puts things like in a call number? Several of our members, that's who. |
| 09:40 |
Dyrcona |
And, we've had a ticket open with our Aspen host about it for over a month, and I only just checked the Evergreen output this morning because....busy, and not realizing what the issue was until I read an email in the chain this morning. Sometimes it takes a specific bit of information for the light bulb to turn on. |
| 10:00 |
Dyrcona |
Encode::decode_utf8 is being called on the fields. |
| 10:01 |
Dyrcona |
Twice! |
| 10:02 |
Dyrcona |
Wait. Maybe not twice... I'm going to remove it and see what happens. |
| 10:02 |
Dyrcona |
And, it's actually too tricky for regex search and replace because of all the ().... |
| 10:08 |
Dyrcona |
Removing the decode_utf8() fixes it for me. |
| 10:08 |
Dyrcona |
perl-- unicode-- |
| 10:16 |
Dyrcona |
Are there concerto records with diacritics in the call numbers? |
| 10:25 |
Dyrcona |
Of course there aren't any. Because... who would put a diacritic in the call number? |
| 10:28 |
berick |
https://github.com/paradedb/paradedb -- postgres/elasticsearch/rust *ears perk up* |
| 10:34 |
Dyrcona |
Oh! I'm going to push Lp 2073561 this afternoon unless someone else objects or takes the bug. |
| 10:34 |
pinesol |
Launchpad bug 2073561 in Evergreen 3.14 "Incorrect content in the config.coded_value_map after applying the upgrade script from 3.12.3 to 3.13.0" [High,Confirmed] https://launchpad.net/bugs/2073561 |
| 10:37 |
Bmagic |
berick++ # that is super interesting |
| 10:38 |
Bmagic |
Dyrcona++ # you know you have my vote |
| 10:38 |
Dyrcona |
And, the bug is fixed. I probably introduced it. |
| 10:38 |
Dyrcona |
Bmagic++ |
| 10:47 |
Dyrcona |
Lp 2103714 for those of us with diacritics in their call numbers. |
| 10:47 |
pinesol |
Launchpad bug 2103714 in Evergreen 3.14 "marc_export does not handle UTF-8 in item fields correctly" [Undecided,New] https://launchpad.net/bugs/2103714 |
| 10:48 |
Bmagic |
Dyrcona++ |
| 11:12 |
|
sandbergja joined #evergreen |
| 11:31 |
|
sandbergja joined #evergreen |
| 11:38 |
sandbergja |
Heya, a few things have been pushed to main that don't pass the angular linter (cd Open-ILS/src/eg2 && npx ng lint). Friendly reminder to devs and committers to check this (or watch for the green checkmark/red X at https://github.com/evergreen-library-system/Evergreen/), it helps keep the code consistent, readable, and free of certain gotchas |
| 11:43 |
Bmagic |
sandbergja++ |
| 11:43 |
Bmagic |
# keeping us in check |
| 12:11 |
sleary |
I just noticed that last night, sandbergja! |
| 12:11 |
sleary |
we did lint those branches, so I'm not sure what happened, but we can clean it up after freeze |
| 12:14 |
|
jihpringle joined #evergreen |
| 12:20 |
|
redavis joined #evergreen |
| 12:24 |
jeffdavis |
I added mention of ng lint to https://wiki.evergreen-ils.org/doku.php?id=contributing#submitting_code_to_the_project and https://wiki.evergreen-ils.org/doku.php?id=contributing:core_committer_process |
| 12:27 |
sandbergja |
Bmagic++ sleary++ jeffdavis++ |
| 12:28 |
|
collum joined #evergreen |
| 12:40 |
jeffdavis |
We need to do a better job of consolidating the various QA ideas and practices we've discussed over the past few years, I think. |
| 12:43 |
eeevil |
pre-push git hooks on origin, and maybe even on working, could probably be used to force some of that? as long as we can always override the linter with a metacommand, and those metacommands are pointed to in an obvious way... |
| 12:48 |
eeevil |
berick: re paradedb, I was wondering why they didn't just distribute the extensions on pgx, but then I saw that it's licensed GPL3+Affero. which is kinda annoying in that it separates them from ... all of the rest of PG, and makes building on it tough. or we can pay them for a less-copyleft license... :P |
| 12:56 |
berick |
eeevil: hm, wasn't familiar with Affero. seems more open, though, at least from the end user perspective (issues with differing from PG norms notwithstanding) |
| 12:57 |
Dyrcona |
Affero is basically GPL 3, but says you have to share the code with your users if you run a hosted service. Hosted code was considered a loophole in the GPL. |
| 12:58 |
eeevil |
right |
| 13:00 |
eeevil |
(theoretically) one could not use it in a hosted EG SaaS without releasing ALL the SaaS infrastructure code, or paying retake, inc for a special license |
| 13:02 |
eeevil |
IANAL, etc etc |
| 13:06 |
Dyrcona |
I don't understand people who get so butthurt about others using their code. That's why you wrote it isn't it? Oh... They're making money off of it... Oh, they're using it in a way I don't like..... Freedom 0.... |
| 13:08 |
Dyrcona |
Freedom Zero is also the title of my near future dystopian novel about real hackers that will never get written, so feel free to steal the title if you do write something. |
| 13:09 |
redavis |
"their" code. |
| 13:10 |
redavis |
Either share or don't. But don't pretend to be part of the sharing economy if it only goes one way. |
| 13:11 |
* redavis |
is REAL grumpy. |
| 13:11 |
Dyrcona |
Well, there's that side of it, too. The free rider problem. |
| 13:12 |
Dyrcona |
I just don't get fussed about it. Like when someone ripped off my code for an ILL interface. It seemed to bother others more than it bothered me. |
| 13:14 |
* Dyrcona |
mumbles something about a ridiculous "don't use if for it evil" clause.... |
| 13:15 |
Dyrcona |
ugh... must be past noon. my fingers have decided to stop cooperating with the brain. |
| 13:15 |
* redavis |
mumbles something about providing safehaven for revolutionaries. |
| 13:16 |
Dyrcona |
"You say you want a revolution....." "you better free your mind instead." |
| 13:19 |
|
collum joined #evergreen |
| 13:19 |
redavis |
all I want is human centered infrastructure, peace, and to be left alone most of the time. In the absense of that...some other things will suffice temporarily. |
| 13:20 |
Dyrcona |
same |
| 13:46 |
sleary |
jeffdavis: yes. sandbergja and I are working on that. (I'm the slow one.) |
| 13:46 |
eeevil |
berick: however, I will say, if the license isn't actually an issue for our community (IMO, not certain either way) then building a QP driver for this would not be Hard(tm) and could be a selectable drop-in option. with some work on how we store randomly extracted chunks of data (record attrs aren't "typed" at the storage level, all just text, but that's likely solvable in a couple ways) I think this could be something really big. everything we do |
| 13:46 |
eeevil |
now in search directly can be covered by an analog in paradedb (I think... at first reading). maybe not the int[] copy_attr stuff, but that's fast as-is. but, maybe that too in another way with its vector type support |
| 13:48 |
jeffdavis |
sleary++ sandbergja++ |
| 13:49 |
Bmagic |
eeevil: I'm escited by your words to say the least |
| 13:49 |
Bmagic |
excited, lol |
| 13:57 |
pinesol |
News from commits: LP#2073561: Update release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=42b93884386f01540f1e3c172187d6a02c03c5fd> |
| 13:57 |
pinesol |
News from commits: LP#2073561 - fix config.coded_value_map <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f0d37d9e844353211f1f9b60b64c362b5d5556e6> |
| 13:59 |
Dyrcona |
"I'm so escited and I just can't hide it!" |
| 14:03 |
eeevil |
I'm so excised, and I'm now hidden. |
| 14:03 |
eeevil |
sandbergja: copy counts for lassos is on the way in, jfyi |
| 14:04 |
redavis |
eeevil++ |
| 14:04 |
Bmagic |
eeevil++ |
| 14:04 |
eeevil |
I'll take the karma for the joke, or for the merge ... I don't care which! :) |
| 14:06 |
eeevil |
grabbing db upgrade id 1464 |
| 14:06 |
redavis |
you'll get additional karma for the merge. |
| 14:06 |
redavis |
The joke was delightful. |
| 14:10 |
sandbergja |
eeevil++ |
| 14:27 |
pinesol |
News from commits: LP2103646 Improve OPAC Alert library setting functionality <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c1d85e778bcec8a99dd085ab8f7946ff5faae747> |
| 14:27 |
pinesol |
News from commits: Stamping upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7d48946e9136cdd9d41c5c6a985ca5fe40fa0f9e> |
| 14:27 |
pinesol |
News from commits: LP2019439: Fix copy counts for records when user searches via Library Group <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=c51e15d942d130be66368abdcd3410952905d3fe> |
| 14:27 |
pinesol |
News from commits: LP2019430: Release notes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e5bf0d5cf03a937d07a2aa655ed1b94a0b19af9c> |
| 14:27 |
pinesol |
News from commits: LP2019430: Template Toolkit changes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a5782c3799f35e2c293f0fc918e04e9e2892754a> |
| 14:27 |
pinesol |
News from commits: LP2019430: Angular changes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=d2ba29fb316af3b95b540fcf1eb2a2580e48ec3e> |
| 14:27 |
pinesol |
News from commits: LP2019430: SQL changes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=bc7b40bf7499ad7ffc66b936ed482726077b6a55> |
| 14:27 |
pinesol |
News from commits: LP2019430: Perl changes <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=09063e7029a89b6baf624d77a5f2836c7a189efb> |
| 14:52 |
|
jihpringle joined #evergreen |
| 14:56 |
|
sandbergja joined #evergreen |
| 15:29 |
Dyrcona |
I thought the template toolkit helpers.get_org_setting function was aware of the tree.... |
| 15:33 |
Dyrcona |
And, it should be. It's using ou_ancestor_setting_value() from OpenILS::Application::AppUtils. Maybe I just needed to restart services.... We'll see. |
| 15:44 |
|
mantis left #evergreen |
| 16:27 |
pinesol |
News from commits: LP2084929 Follow-up: silence additional blur error <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=e8489059c76aab4b2de8880fb5a9736aed090af8> |
| 17:11 |
|
mmorgan left #evergreen |
| 17:13 |
|
jihpringle joined #evergreen |
| 17:28 |
pinesol |
News from commits: LP#2100807: (follow-up) fix lint <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f67fe8e6997c9c5a4602c852c7deaabad764d186> |
| 17:28 |
pinesol |
News from commits: lp2100807 Angular_Login_Bad_RouteTo <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=4fad5beefbed083a31a91b389bf9f2f80eef4b77> |
| 19:19 |
|
jihpringle joined #evergreen |
