| Time |
Nick |
Message |
| 07:24 |
|
collum joined #evergreen |
| 08:30 |
|
mmorgan joined #evergreen |
| 08:36 |
|
jonadab joined #evergreen |
| 08:41 |
|
JBoyer joined #evergreen |
| 08:51 |
|
dguarrac joined #evergreen |
| 09:16 |
|
mantis joined #evergreen |
| 10:02 |
|
redavis joined #evergreen |
| 10:08 |
|
Dyrcona joined #evergreen |
| 10:10 |
|
sandbergja joined #evergreen |
| 10:59 |
|
Christineb joined #evergreen |
| 11:31 |
|
jihpringle joined #evergreen |
| 13:19 |
jeffdavis |
csharp_: how is your branch for bug 2099920 holding up in production? |
| 13:19 |
pinesol |
Launchpad bug 2099920 in Evergreen "Hold Targeter fails with undefined value errors" [High,Confirmed] https://launchpad.net/bugs/2099920 - Assigned to Bill Erickson (berick) |
| 13:23 |
Dyrcona |
Having to support Pg10 is a real pain.... |
| 13:24 |
Dyrcona |
Ex: 'create or replace trigger' appears in PG 14.... |
| 13:24 |
Dyrcona |
It's simpler than dropping the trigger and recreating it. |
| 13:26 |
Dyrcona |
I guess it is only 1 place in the script, so all right drop/create it is. |
| 13:28 |
Dyrcona |
Ugh. Now, Pg10 is complaining about something else.... |
| 13:29 |
berick |
hm, I'll detach myself from that ticket. it got complicated. |
| 13:29 |
Dyrcona |
really..... FUNCTION vs. PROCEDURE..... |
| 13:30 |
berick |
@decide FUNCTION or [band] |
| 13:30 |
pinesol |
berick: go with Table Bloat |
| 13:30 |
berick |
i mean... |
| 13:30 |
csharp_ |
jeffdavis: it's working fine for us |
| 13:32 |
csharp_ |
I would probably try to clean up the if defined block - I was working in a hurry and just needed something working |
| 13:32 |
Dyrcona |
I guess if we only support Pg 13 or higher we're OK. |
| 13:34 |
Dyrcona |
We should set the Evergreen version from autotools and then we can subst it in the files that need it. I'm thinking this script that I'm working on would be one such place. |
| 13:35 |
jeffdavis |
csharp_++ # thanks! |
| 13:36 |
csharp_ |
jeffdavis: happy to help - maybe just some clarifying comments would suffice for the clunky code |
| 13:36 |
* csharp_ |
shrugs |
| 13:36 |
Dyrcona |
Hmm... I can probably do that already. |
| 13:41 |
Dyrcona |
Yeah, PACKAGE_VERSION or AC_PACKAGE_VERSION. |
| 13:41 |
Dyrcona |
I'll try it. |
| 13:53 |
Dyrcona |
Apparently PACKAGE_VERSION doesn't work if it's quoted. |
| 14:01 |
Dyrcona |
Oh well. lunch break. |
| 14:57 |
|
Dyrcona joined #evergreen |
| 15:02 |
Dyrcona |
Well, it was easy: @PACKAGE_VERSION@ |
| 15:17 |
Dyrcona |
Love it when I "clean" my glasses and it's worse than before I cleaned them. |
| 15:22 |
pinesol |
News from commits: LP#2073896 - Angular Catalog Place Holds Ignore Empty User Setting <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7e70a43c3a65fdc783c0f7045427ab8fbf2ee91d> |
| 16:03 |
|
mantis left #evergreen |
| 16:08 |
JBoyer |
Claiming 1461 so someone can look up Phils's phone number for Billy more quickly |
| 16:08 |
Bmagic |
JBoyer++ |
| 16:09 |
Bmagic |
time is money friend |
| 16:16 |
|
jihpringle joined #evergreen |
| 16:22 |
pinesol |
News from commits: LP2086106: Stamping Upgrade Script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5b796601dad9bc8f7b5ab7de141a147a5bf59a40> |
| 16:22 |
pinesol |
News from commits: LP2086106 SMS/Default phone search performance improvements <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=5b90c95f19b83bebc266ab44918ccc62bb9ae5ef> |
| 17:05 |
|
mmorgan left #evergreen |
| 18:03 |
csharp_ |
JBoyer++ # deep cut - I had forgotten about Phil not wanting Billy to lose his number |