| Time |
Nick |
Message |
| 07:20 |
|
collum joined #evergreen |
| 08:42 |
|
Dyrcona joined #evergreen |
| 08:56 |
|
mmorgan joined #evergreen |
| 09:02 |
|
mmorgan1 joined #evergreen |
| 09:38 |
|
dguarrac joined #evergreen |
| 10:42 |
|
mantis joined #evergreen |
| 10:49 |
abneiman |
good morning Evergreen ... just a friendly poke to our core committers hanging out in channel to take a look at wishlist items for 3.15 in advance of tomorrow's freeze (hideous link incoming) |
| 10:49 |
abneiman |
https://bugs.launchpad.net/evergreen/+bugs?field.searchtext=&orderby=-importance&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.importance%3Alist=WISHLIST&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_commenter=&field.subscriber=&field.structural_subscriber=&field. |
| 10:49 |
abneiman |
milestone%3Alist=99028&field.tag=&field.tags_combinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on&search=Search |
| 10:51 |
Dyrcona |
Too many things dropped at the last minute for proper review. |
| 10:55 |
abneiman |
sorry to hear you think that - I'd appreciate it if you could take the time to review even a couple of them! |
| 10:56 |
Dyrcona |
I'm reviewing the Quipu branch and that's probably all that I'll have time to do. |
| 10:56 |
Bmagic |
abneiman++ |
| 10:57 |
abneiman |
Dyrcona++ # much appreciated! |
| 10:57 |
|
sandbergja joined #evergreen |
| 11:43 |
|
jihpringle joined #evergreen |
| 12:03 |
sandbergja |
I have the capacity to review things that have automated test coverage and/or are small in scope/unlikely to cause side effects. Any suggestions? |
| 12:24 |
sleary |
@later tell sandbergja the localStorage cache buster https://bugs.launchpad.net/evergreen/+bug/2084181 |
| 12:24 |
pinesol |
sleary: The operation succeeded. |
| 12:24 |
pinesol |
Launchpad bug 2084181 in Evergreen "Wishlist: Cache buster for Staff Client LocalStorage" [Wishlist,New] |
| 12:49 |
pinesol |
News from commits: LP2090958 Can't select charges for credit card payment <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=7ddcbb35f0f373ad161282b40252e68f6b1ed046> |
| 13:42 |
|
Christineb joined #evergreen |
| 13:48 |
|
jihpringle joined #evergreen |
| 13:56 |
csharp_ |
abneiman: any particular ones you see as more desirable than others? |
| 13:58 |
|
jihpringle joined #evergreen |
| 14:12 |
abneiman |
csharp_: thanks for asking - let me toss a couple in here |
| 14:16 |
|
jihpringle joined #evergreen |
| 14:17 |
abneiman |
obviously I consider restful api to be really important: https://bugs.launchpad.net/evergreen/+bug/2067414. Others that are signed off and smaller include lp2089564, lp2080572, lp2019430, lp2015351 |
| 14:17 |
pinesol |
Launchpad bug 2067414 in Evergreen "wishlist: RESTful API for Patron Tools" [Wishlist,Confirmed] |
| 14:18 |
abneiman |
sigh, pinesol. bug 2089564, bug 2080572, bug 2019430, bug 2015351 |
| 14:18 |
pinesol |
Launchpad bug 2089564 in Evergreen "Ability to Create Staff-Only Library Groups" [Wishlist,Confirmed] https://launchpad.net/bugs/2089564 |
| 14:18 |
pinesol |
Launchpad bug 2080572 in Evergreen "Multi- Factor Authentication does not support Secondary Permission Groups" [Wishlist,Confirmed] https://launchpad.net/bugs/2080572 |
| 14:18 |
pinesol |
Launchpad bug 2019430 in Evergreen "Wishlist: Holdings Statement in Library Groups" [Wishlist,Confirmed] https://launchpad.net/bugs/2019430 |
| 14:18 |
pinesol |
Launchpad bug 2015351 in Evergreen "Staff Portal Page - Open in New Tab" [Wishlist,Confirmed] https://launchpad.net/bugs/2015351 |
| 14:18 |
csharp_ |
abneiman++ |
| 14:18 |
abneiman |
pullrequested but not signed off, https://bugs.launchpad.net/evergreen/+bug/2091748 is smallish and likely beneficial to large data sites |
| 14:18 |
csharp_ |
I'll poke around and see if there's something I feel able to do today |
| 14:18 |
pinesol |
Launchpad bug 2091748 in Evergreen "Concurrent browse entry update/insert" [Wishlist,New] |
| 14:18 |
abneiman |
csharp_++ |
| 14:19 |
abneiman |
thank you so much! |
| 14:20 |
csharp_ |
I think we may have tested bug 2091748 during our upgrade testing - I'll verify |
| 14:20 |
pinesol |
Launchpad bug 2091748 in Evergreen "Concurrent browse entry update/insert" [Wishlist,New] https://launchpad.net/bugs/2091748 |
| 14:20 |
abneiman |
that would be awesome, thanks |
| 14:22 |
csharp_ |
hmm - yes, we did - we backed it out and I don't remember why... |
| 14:26 |
csharp_ |
we backed it out the night we upgraded - I guess that's probably not good :-/ |
| 14:26 |
abneiman |
:( well, I'd appreciate any constructive feedback that you could give! |
| 14:27 |
csharp_ |
yeah, still looking |
| 14:27 |
csharp_ |
we get deadlocks sometimes on acq imports and I was hoping it would help us |
| 14:34 |
jeffdavis |
Would it make sense to push back the feature freeze date if there are a bunch of potential features pending review? |
| 14:35 |
jeffdavis |
(I don't have an opinion either way, I won't have much more time for review in the next few weeks anyhow) |
| 14:36 |
csharp_ |
abneiman: I think it was unrelated to that bug, but we saw search.symspell_dictionary_updates grow to >1TB when doing a reingest |
| 14:37 |
csharp_ |
and I decided we would have to wait to get that done |
| 14:37 |
csharp_ |
all in the heat of battle, so I kind of dropped it after thata |
| 14:37 |
csharp_ |
that* |
| 14:38 |
csharp_ |
also, search.symspell_dictionary_updates can grow unreasonably big, which is a bug I've meant to try and track down before reporting |
| 14:38 |
csharp_ |
@eightball is there too much to do? |
| 14:38 |
pinesol |
csharp_: It shall be. |
| 14:42 |
abneiman |
csharp_: thanks! I thought the bloating of symspell was resolved with bug 1998355 but I'll let Mike know |
| 14:42 |
pinesol |
Launchpad bug 1998355 in Evergreen main "Did You Mean's search.symspell_dictionary can get significantly bloated" [Medium,Fix released] https://launchpad.net/bugs/1998355 |
| 14:43 |
csharp_ |
abneiman: well, this wasn't table bloat, it was inserting data to the point where it grew to the point where disk space was nearly depleted |
| 14:44 |
abneiman |
hmm ok |
| 14:44 |
csharp_ |
too many "to the point"s but hopefully comprehensible |
| 14:44 |
abneiman |
thanks for the feedback |
| 14:56 |
Dyrcona |
csharp_: temp db space filled up. |
| 14:57 |
csharp_ |
Dyrcona: it was the unlogged updates table that was showing usage of 1TB |
| 14:58 |
Dyrcona |
OK. |
| 14:58 |
Dyrcona |
We have symspell turned off. |
| 15:05 |
|
jihpringle joined #evergreen |
| 15:06 |
Bmagic |
has anyone edited Evergreen's User-Agent string when asking OpenLibrary for book metadata (images) as per their preference: https://openlibrary.org/developers/api |
| 15:17 |
csharp_ |
Bmagic: I haven't ever done that, but I got curious and found |
| 15:17 |
csharp_ |
https://metacpan.org/release/RSE/lcwa-1.0.0/view/lib/lwp/lib/LWP.pm#The-User-Agent |
| 15:17 |
Dyrcona |
csharp_++ |
| 15:17 |
Dyrcona |
I was about to suggest checking the LWP documnentation. |
| 15:20 |
Dyrcona |
Oh! I'm missing the code review meeting.... |
| 15:20 |
Dyrcona |
Oh well... |
| 15:21 |
csharp_ |
I missed it too but was fully aware I was doing so :-) |
| 15:21 |
csharp_ |
take THAT, optional meeting! |
| 15:21 |
Bmagic |
I'm thinking Evergreen should be configurable in this regard |
| 15:21 |
Dyrcona |
Well, I thought of it earlier today, then got busy. |
| 15:21 |
Dyrcona |
Bmagic: That sounds fine to me. An ou setting or something else? |
| 15:21 |
csharp_ |
Bmagic: I was just thinking it would be easy to add a YAOUS or global flag somwhere |
| 15:21 |
Bmagic |
yeah, YAOUS |
| 15:21 |
csharp_ |
somewhere |
| 15:22 |
Dyrcona |
Just what we need... More knobs..... :) |
| 15:22 |
csharp_ |
ervrahwer, as my Mississippi grandmother used to say |
| 15:22 |
Bmagic |
or! in the opensrf.xml block accompanied by the Module that you're configuring |
| 15:23 |
Bmagic |
it's going to be module dependent, though, I don't think contentcafe would care what our user-agent string was, so if you configured it to meet openlibrary's standards, and forget to change it after you switch to contentcafe, it's probably OK |
| 15:24 |
Dyrcona |
Bmagic: It could be built with the name of the application: "Evergreen," the current Evergreen version and the server admin email or something like that. |
| 15:24 |
Bmagic |
Evergreen could just be hardcoded to grab the phone number from one of the org_unit's and make it look like: "User-Agent: Evergreen; 123-456-7890" |
| 15:24 |
Dyrcona |
We might not need a new setting. |
| 15:25 |
csharp_ |
you could construct the setting so it could read the name of the service as it builds the string |
| 15:25 |
csharp_ |
addedcontent.$service.user.agent or whatever |
| 15:26 |
Dyrcona |
"please add a HEADER that specifies a User-Agent string with (a) the name of your application and (b) your contact email or phone number," |
| 15:26 |
Dyrcona |
We don't need new settings for that if Apache/opensrf.xml are properly configured. |
| 15:26 |
csharp_ |
"Evergreen 867-5309 |
| 15:26 |
csharp_ |
" |
| 15:26 |
Bmagic |
yep, I agree, maybe we just decide for you |
| 15:26 |
Dyrcona |
csharp_++ I got your number.... |
| 15:27 |
Bmagic |
it's the email/phone number bit that would need to be worked out |
| 15:27 |
Dyrcona |
Well, you're supposed to configure a server admin email for Apache, and there are emails in the opensrf.xml if people set them up, so we could pick one of those. |
| 15:28 |
Dyrcona |
Or, we could add a setting for the email. |
| 15:28 |
Dyrcona |
I image the user-agent header could look like "Evergreen/X.Y.Z (<email>)" |
| 15:29 |
Bmagic |
sure, I think it's doable, and we probably should identify ourselves to all of the content providers as a courtesy |
| 15:30 |
Bmagic |
I'll write up a LP |
| 15:30 |
Dyrcona |
There's admin_email in opensrf.xml, which is commented out by default. |
| 15:31 |
Dyrcona |
At a minimum, we could identify with Evergreen and the version. |
| 15:39 |
Bmagic |
bug 2103461 |
| 15:39 |
pinesol |
Launchpad bug 2103461 in Evergreen "Evergreen should identify itself when scraping AddedContent" [Undecided,New] https://launchpad.net/bugs/2103461 |
| 16:02 |
Dyrcona |
Bmagic++ |
| 16:40 |
|
kmlussier joined #evergreen |
| 16:59 |
|
kmlussier left #evergreen |
| 17:06 |
|
mmorgan1 left #evergreen |
| 17:14 |
|
mantis left #evergreen |
| 22:50 |
pinesol |
News from commits: LP2084181: stamp upgrade script <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=04edf032309e454d191183a49f7b9f1502be6de0> |
| 22:50 |
pinesol |
News from commits: LP2084181: two small follow-ups <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=deb02bb9d813c4c220712a8ffd1ab5c6867c7197> |
| 22:50 |
pinesol |
News from commits: LP2084181: Add Release Note <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=667c5b89d7e9001b3c4c9a14319416c9df021acc> |
| 22:50 |
pinesol |
News from commits: LP2084181: Long-Lived-Cache Clearing for Staff Client <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=f05a370e05fbf8209a0d4ed5b967bb890d70777c> |
| 22:50 |
pinesol |
News from commits: LP2084181: Add StoreService calls for multiple items <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=8ee457a4a04b8cf5557d8587075014ea11b71e1c> |
