| Time |
Nick |
Message |
| 08:12 |
|
dguarrac joined #evergreen |
| 08:35 |
|
mmorgan joined #evergreen |
| 09:26 |
|
kworstell-isl joined #evergreen |
| 10:23 |
|
smayo joined #evergreen |
| 10:30 |
|
Dyrcona joined #evergreen |
| 10:41 |
|
berick joined #evergreen |
| 10:47 |
|
Christineb joined #evergreen |
| 11:26 |
Dyrcona |
Huh... My test system apparently doesn't have my logos, or they're in the wrong place.... |
| 11:32 |
Dyrcona |
So, I put them in /opac/images/ but looks like the template looks for them in /images/... Wonder if I missed a customization or something changed? |
| 11:33 |
* Dyrcona |
moves them for now and will worry about it later. :) |
| 11:55 |
|
redavis joined #evergreen |
| 12:04 |
|
jihpringle joined #evergreen |
| 12:06 |
pinesol |
News from commits: LP1894900 Move OPAC user timeout to JS; add prompt <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=80855abfb8929c05eb3bc0e6aa084a3aa6061709> |
| 12:07 |
Dyrcona |
Hrm, after a git rebase on main: Your branch and 'working/user/sleary/opac-a11y-omnibus-stack' have diverged, |
| 12:07 |
Dyrcona |
and have 21 and 9 different commits each, respectively.Your branch and 'working/user/sleary/opac-a11y-omnibus-stack' have diverged, |
| 12:07 |
Dyrcona |
and have 21 and 9 different commits each, respectively. |
| 12:07 |
Dyrcona |
|
| 12:07 |
Dyrcona |
|
| 12:09 |
Dyrcona |
Meh, they both have 9 commits over their base. |
| 12:10 |
sleary |
Dyrcona I'm about to walk out the door for lunch, but I can rebase it when I get back if you need |
| 12:11 |
Dyrcona |
sleary: It's OK. I rebased it. I was just going to say that the working branch and my rebase have different bases, so the commits from the working branch base have different hashes, though they show up in main. |
| 12:12 |
Dyrcona |
I'm going to make sure that I didn't lose the timeout patch that I pushed earlier. |
| 12:12 |
sleary |
Cool. Feel free to squash the omnibus if that's easier; I only broke it up to make it less heinous to review. |
| 12:13 |
Dyrcona |
It's tough to judge when to squash. Sometimes more commits are easier to deal with than fewer, and sometimes it's the other way 'round. |
| 12:16 |
Dyrcona |
Heh. The js code got added twice.... |
| 12:18 |
Dyrcona |
Should the jquery code still be in there? |
| 12:19 |
sleary |
Yes, we haven't pulled out jQuery entirely yet |
| 12:20 |
Dyrcona |
Yeah. I was just going to say, looks like custom_jquery should stay. |
| 12:20 |
sleary |
Yeah. Getting rid of it is on the long-term roadmap but not for this branch |
| 12:21 |
sleary |
back in ~1hr or so! |
| 12:25 |
Dyrcona |
sleary++ |
| 12:26 |
Dyrcona |
Looks like I got the duplicate code out. I'll rebase -i and make it look like it was never there. |
| 12:38 |
Dyrcona |
Ok. Helps to use the correct base when cherry-picking to another branch. |
| 12:41 |
Dyrcona |
Whee! More conflicts with our customization...... |
| 12:41 |
Dyrcona |
I'll fix most of that later. |
| 12:44 |
Dyrcona |
We should probably have our custom color scheme audited for accessibility. |
| 12:56 |
|
jihpringle joined #evergreen |
| 13:16 |
Dyrcona |
Add/Remove search terms in Advanced Search isn't working for me with a11y omnibus branch, but I might have broken something resolving conflicts with our customization, so I'll try again on stock Evergreen. |
| 13:23 |
|
jihpringle joined #evergreen |
| 13:25 |
Dyrcona |
sleary: I think the logout timer could use some more work. I logged out manually and was looking at the login screen when the dialog popped up saying I would be logged out in a few minutes. |
| 13:32 |
* Dyrcona |
decides it is time for some lunch. Be back later. |
| 13:42 |
|
kworstell-isl joined #evergreen |
| 14:17 |
csharp_ |
I've never hit this before - apparently IDL2js doesn't have a closing } and it's preventing login |
| 14:17 |
csharp_ |
Uncaught SyntaxError: missing } after property list |
| 14:17 |
csharp_ |
any ideas? |
| 14:18 |
csharp_ |
looks like that's generated on the fly each time? I'm having trouble tracking it down |
| 14:24 |
csharp_ |
holy crap that's a huge file |
| 14:30 |
berick |
csharp_: IDL2js.pm |
| 14:30 |
berick |
it's cached per apache process + locale |
| 14:31 |
|
jihpringle joined #evergreen |
| 14:34 |
csharp_ |
berick: thanks for the tip - I may have to add some debugging |
| 14:38 |
berick |
IDL in current main working OK for me |
| 14:59 |
|
Dyrcona joined #evergreen |
| 15:00 |
sleary |
Dyrcona I have a commit for you on the timer / home page issue. Want a separate bug or a follow-up on the original branch? |
| 15:04 |
Dyrcona |
sleary: I was going to open a separate bug, and one of your comments mentions making a new bug for the stay logged in checkbox, so I guess a new bug. |
| 15:05 |
sleary |
on it |
| 15:05 |
Dyrcona |
None of the datepickers were working for me, so I'm setting up a clean VM with stock Evergreen and concerto data. Our customization may be interfering with some of the things. |
| 15:17 |
Dyrcona |
Huh. Can't login as a patron after --load-all-sample. |
| 15:17 |
sleary |
passwords all changed to demo123 |
| 15:18 |
redavis |
yes |
| 15:18 |
redavis |
sleary |
| 15:19 |
Dyrcona |
All? Someone should update the wiki: https://wiki.evergreen-ils.org/doku.php?id=qa:concerto_logins |
| 15:20 |
sleary |
All. there is a small note above the table |
| 15:20 |
sleary |
I overlooked it a few times >.< |
| 15:20 |
Dyrcona |
sleary++ |
| 15:20 |
redavis |
It's 3.14+ I wasn't sure about if it was for basic concerto as well, but appears to be. |
| 15:20 |
redavis |
def for enhanced concerto |
| 15:21 |
redavis |
++ to whoever added the note on the wiki |
| 15:21 |
sleary |
we should either move that table or add a column for post-3.14 |
| 15:21 |
redavis |
agreed. I don't mind to add the column. |
| 15:21 |
sleary |
redavis++ |
| 15:22 |
redavis |
For all of them. lol. On it. |
| 15:22 |
sleary |
revised timer is on bug 2084092 |
| 15:22 |
pinesol |
Launchpad bug 2084092 in Evergreen "Logout timer should not apply to OPAC home or login pages" [Undecided,New] https://launchpad.net/bugs/2084092 |
| 15:22 |
sleary |
(please tell me we don't give admins a way to change those paths) |
| 15:24 |
Dyrcona |
sleary: Thanks! I just got my rebased branch loaded with concerto, and I want to see if the date pickers are working. It could be my browser. |
| 15:25 |
Dyrcona |
Or, I could have botched the rebase. |
| 15:25 |
sleary |
the datepickers do involve a new dependency |
| 15:25 |
Dyrcona |
Ah... Maybe that's missing on my other vm. I didn't install dependencies there. |
| 15:25 |
sleary |
Bootstrap-datepicker-- |
| 15:25 |
Dyrcona |
I did the makefile.install on this one, though. |
| 15:25 |
Dyrcona |
And, npm install, etc. I'll bet that's it. |
| 15:26 |
sleary |
did the fields just not appear at all? |
| 15:26 |
Dyrcona |
No, not at all. |
| 15:26 |
sleary |
yeah, sounds like the library is missing |
| 15:27 |
Dyrcona |
It's working on the concerto vm, so I'll try it again on the upgraded one with production data in a bit. So far, things are looking good. |
| 15:27 |
sleary |
awesome. Dyrcona++ |
| 15:29 |
sleary |
oh, and on another note, I was going to say that color contrast is just about the easiest accessibility issue to check. Grab axe DevTools or use Lighthouse with the Accessibility option checked, and it'll tell you what to change. |
| 15:29 |
sleary |
(Lighthouse is slower because it runs *all* its tests no matter which options you check... argh) |
| 15:30 |
Dyrcona |
OK. I'll give it a look. |
| 15:32 |
redavis |
column added. That info was already included in the info about enhanced concerto |
| 15:39 |
Dyrcona |
OK. Date picker is working after npm install in opac/deps and a make install. |
| 15:41 |
sleary |
hooray! |
| 15:42 |
redavis |
++ |
| 15:42 |
Dyrcona |
So, I do think our customization in advanced search break the Add/Remove search terms. It's working on concerto. |
| 15:44 |
Dyrcona |
Except I'm not sure advanced search is working. |
| 15:45 |
sleary |
the add/remove logic is in simple.js and it relies on <fieldset> being present in the search form, which was not the case before these changes. |
| 15:45 |
sleary |
I'm digging into keyboard issues in the MARC editor, but LMK if I need to look at something in advanced search |
| 15:48 |
Dyrcona |
Well, I click "Submit" on Advanced Search and nothing seems to happen. |
| 15:48 |
Dyrcona |
This is on stock/concerto. Nothing in the javascript console. |
| 15:50 |
sleary |
the Submit button just below the keyword fields or the one at the very bottom of the page? |
| 15:50 |
Dyrcona |
The one at the bottom of the page works. |
| 15:51 |
Dyrcona |
The other doesn't. I didn't see the one at the bottom at first. |
| 15:52 |
sleary |
there is a rule that there can't be any more form fields after a <button type="submit"> so the first one is <button type="button"> with a JS handler to submit the form |
| 15:53 |
Dyrcona |
Can we just drop that button, or is it recommended to be up there for accessibility? |
| 15:54 |
sleary |
we really should keep it, since the second one is so far away |
| 15:54 |
sleary |
should be a simple fix as soon as I remember where I put that... |
| 16:00 |
Dyrcona |
OK. |
| 16:02 |
|
jihpringle61 joined #evergreen |
| 16:04 |
sleary |
got it. One new commit on user/sleary/opac-a11y-omnibus-stack |
| 16:04 |
Dyrcona |
sleary++ I'll cherry-pick it and the patch for the OPAC timer. |
| 16:05 |
sleary |
Dyrcona++ thanks for catching that! Apparently the code that was there only served to update the class names >.< |
| 16:05 |
sleary |
buttons gotta... do stuff |
| 16:05 |
Dyrcona |
Generally, yes. |
| 16:06 |
sleary |
sometimes I try a little too hard to preserve what was there before |
| 16:08 |
Dyrcona |
Yeah. Along similar lines, we'll probably drop some of our customization, particularly in Advanced Search. |
| 16:10 |
sleary |
I will be adding documentation for replicating these changes in custom templates, but I'm not going to get there for several days. In the meantime, you could leave notes here on anything in particular you want me to make sure to cover. https://wiki.evergreen-ils.org/doku.php?id=opac:accessibility |
| 16:11 |
sleary |
I will make a note that advanced search has changed significantly. |
| 16:11 |
Dyrcona |
Cool. |
| 16:12 |
Dyrcona |
The top Search button works for me, now! |
| 16:12 |
Dyrcona |
Well, technically "Submit" on Advanced Search. |
| 16:14 |
sleary |
ha, yes, we should probably make our search / submit wording consistent... later |
| 16:15 |
* sleary |
has too many fish to fry |
| 16:15 |
Dyrcona |
Yeahp. |
| 16:15 |
Dyrcona |
I also added accessibility to the agenda for the Hack-Away. My boss asked about it today without know that I was looking at this branch. |
| 16:17 |
sleary |
I will probably do another workshop at the conference |
| 16:18 |
sleary |
haven't really thought that far ahead though |
| 16:30 |
csharp_ |
<homer>mmmm fish to fry aggghghghghgh</homer> |
| 16:37 |
* abneiman |
looks up when the local AME has their next fish fry, because it's a culinary highlight 'round here |
| 16:45 |
* Dyrcona |
needs to adjust the OPAC timeout while testing. I keep getting logged out. I changed it to 5 minutes to test the new dialog. |
| 16:47 |
sleary |
I did that too, and regretted my choices |
| 16:49 |
sleary |
I guess it's a taste of how annoying that feature is for assistive device users |
| 16:52 |
Dyrcona |
Well, I had a search results page open that I was looking at to verify the accessibility changes, and it would get rest to the home page while I was reading one of the specific Launchpad bugs. |
| 16:52 |
Dyrcona |
I suppose that I don't have to be logged in to do that. |
| 16:53 |
sleary |
nope, sadly it affects everything. I really want to have a big conversation about that feature and how libraries have their public computers set up. This patch is *definitely* just intended to be a band-aid on the current functionality... which I think is awful. |
| 17:03 |
redavis |
The timeout? Yes. It needs more work, but this is better than it was. There is also considerable difference between using the OPAC in a kiosk in the library and using it at home. It would be nice to differentiate between the two or give users more options somehow. |
| 17:05 |
sleary |
Yes. My starting point for that conversation is going to be, "Give me one good reason we should keep doing this in Evergreen instead of the browser's kiosk features." It is a horrible user experience for everyone who's not sitting at a public computer. |
| 17:06 |
sleary |
I believe this feature predates the existence of browser kiosk modes. |
| 17:08 |
Dyrcona |
abneiman | sleary: Was this accessibility work sponsored by Canada's National Network for Equitable Library Service? Do they need to be mentioned in release notes? |
| 17:08 |
sleary |
BC Co-op, and yes they would like the NNELS testers to be credited, along with Christine Burns |
| 17:09 |
sleary |
abneiman can send you the list |
| 17:09 |
Dyrcona |
Awesome. |
| 17:09 |
sleary |
or, whoops, she just left. I'll grab it |
| 17:10 |
abneiman |
I didn't actually leave yet |
| 17:10 |
abneiman |
but yeah, we have a list of names that I was also planning to add to release notes |
| 17:11 |
abneiman |
Dyrcona: this is on its way thru the tubes for you |
| 17:11 |
sleary |
abneiman++ |
| 17:12 |
abneiman |
BC Coop was the main sponsor, NNELS did two rounds of testing: first to ID the issues, second to confirm fixes. |
| 17:12 |
Dyrcona |
abneiman++ |
| 17:13 |
Dyrcona |
I think we already have BC Libraries Coop as a sponsor, but if not I'll add them when I add this. Probably tomorrow. |
| 17:13 |
sleary |
Dyrcona++ thanks for going over all of it! |
| 17:14 |
abneiman |
Dyrcona++ |
| 17:22 |
|
jihpringle joined #evergreen |
| 19:55 |
|
mmorgan left #evergreen |
