| Time |
Nick |
Message |
| 06:40 |
|
rlefaive joined #evergreen |
| 07:20 |
|
ericar joined #evergreen |
| 07:27 |
|
collum joined #evergreen |
| 07:27 |
|
mrpeters joined #evergreen |
| 07:27 |
|
collum joined #evergreen |
| 07:45 |
|
jboyer-isl joined #evergreen |
| 07:50 |
|
graced joined #evergreen |
| 08:10 |
|
ericar_ joined #evergreen |
| 08:22 |
|
Shae joined #evergreen |
| 08:46 |
|
maryj joined #evergreen |
| 08:48 |
csharp |
e2f6cca0 |
| 08:48 |
pinesol_green |
[evergreen|Mike Rylander] webstaff: Copy note bug fixing - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e2f6cca> |
| 08:48 |
|
mmorgan joined #evergreen |
| 08:49 |
|
Dyrcona joined #evergreen |
| 08:50 |
csharp |
miker or gmcharlt or Dyrcona: I'm noticing in AssetCommon.pm in commit e2f6cca0 that there are two sets of duplicated lines "my $sc_entries = $copy->stat_cat_entries;...", and I'm getting a warning in the logs about it - that's a mistake, right? |
| 08:50 |
pinesol_green |
[evergreen|Mike Rylander] webstaff: Copy note bug fixing - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e2f6cca> |
| 08:51 |
csharp |
warning is ""my" variable $sc_entries masks earlier declaration in same scope at /usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm line 371." |
| 08:53 |
Dyrcona |
csharp: You're barking at the wrong commit. |
| 08:53 |
|
jwoodard joined #evergreen |
| 08:54 |
Dyrcona |
And, I think you're missing something, 'cause IIRC we fixed that error. |
| 08:55 |
csharp |
this is in stock(-ish) 2.9.0 |
| 08:55 |
Dyrcona |
csharp: I'll have to find the commit, but I recall writing the code to correct it. |
| 08:55 |
csharp |
http://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm;h=8d642b3ee25e92fdd881b8faefd27b3ef586c639;hp=7b0ea444b7b520eb78e0114bc6a40fef3e1ddd01;hb=e2f6cca;hpb=3b89ef139e2d98783493b9a7e134fd34a3ea5fed |
| 08:55 |
pinesol_green |
[evergreen|Mike Rylander] webstaff: Copy note bug fixing - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=e2f6cca> |
| 08:55 |
pinesol_green |
[evergreen|Mike Rylander] webstaff: Add copy note creation/editing - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=3b89ef1> |
| 08:56 |
csharp |
second chunk of code |
| 08:57 |
Dyrcona |
csharp: If you look at the blob for AssetCommon.pm and scroll down to line 371, it doesn't match what you're reporting. |
| 08:57 |
Dyrcona |
Give me a couple of minutes. I'm still eating what passes for breakfast. |
| 08:59 |
csharp |
Dyrcona: on that blob it's lines 365 through 369 (I found the commit with 'git blame') |
| 08:59 |
dbwells |
csharp: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=dbb9c8198169cf5af16c094d32b06040b09d9f8d |
| 08:59 |
pinesol_green |
[evergreen|Jason Stephenson] LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=dbb9c81> |
| 08:59 |
csharp |
dbwells: ah - hmm |
| 08:59 |
Dyrcona |
Yeah, but I'm pretty sure that was fixed at a later time. |
| 08:59 |
Dyrcona |
dbwells++ |
| 09:00 |
csharp |
oh - I see - it's in 2.9.1 and I'm on 2.9.0 |
| 09:00 |
csharp |
dbwells++ |
| 09:01 |
csharp |
welp, time to upgrade to that, methinks ;-) |
| 09:03 |
|
rlefaive joined #evergreen |
| 09:17 |
bshum |
Pfft csharp should know better than to use a .0 release. |
| 09:18 |
bshum |
Kidding, kidding... :P |
| 09:18 |
csharp |
:-D |
| 09:19 |
|
rlefaive joined #evergreen |
| 09:37 |
mrpeters |
apologize if i have missed a discussion on this, but does there happen to be a bug with the 2.9.1 eg-db-config that causes the db setup to die at psql:002.schema.config.sql:96: ERROR: duplicate key value violates unique constraint "upgrade_log_pkey" DETAIL: Key (version)=(2.9.1) already exists. even when no previous evergreen (or any other) database exists? |
| 09:52 |
|
Callender joined #evergreen |
| 09:52 |
jeff |
mrpeters: the issue seems to be with the tarball itself. i don't see the error in git, but it's pretty clearly in the release. |
| 09:52 |
mrpeters |
jeff: thanks for confirming! |
| 09:53 |
mrpeters |
we use the tarball to build our debs, so that makes sense |
| 09:53 |
mrpeters |
i hadn't had time yet to do a full install from scratch using the tarball |
| 09:54 |
mrpeters |
I can file a bug on launchpad for it...will this have to wait for a new point release to get fixed though? |
| 10:14 |
* Dyrcona |
wonders how that happened. |
| 10:14 |
jeff |
mrpeters: i wouldn't want to hazard a guess. if you're building debs, you can probably just patch it locally in the meantime as part of the usual build process on your end. |
| 10:14 |
Dyrcona |
I could try building a new 2.9.1 tarball, or anyone else could for that matter. |
| 10:15 |
Dyrcona |
I didn't test the fresh install from the tarball. |
| 10:15 |
mrpeters |
no, i certainly can patch it on our end that is no worries |
| 10:15 |
mrpeters |
but, maybe we should pull the tarball from the site until fixed? |
| 10:17 |
Dyrcona |
And, everyone just ignores me.... |
| 10:20 |
Dyrcona |
mrpeters jeff: I or anyone else can build a new 2.9.1 tarball and test it. I do not have time at this very moment to do that. |
| 10:21 |
mrpeters |
Dyrcona: I'm not suggesting you should have to. I am happy to fix it and test it -- I just don't know where the bug is |
| 10:21 |
Dyrcona |
mrpeters: Probably just one of those things that happens at the last minute. |
| 10:22 |
mrpeters |
no im not trying to assess blame or figure out what caused it -- i'm saying i dont know where the duplicated insert into the upgrade log occurs to fix the tarball and give you a new one |
| 10:22 |
Dyrcona |
Like you said, it works fine from git. |
| 10:23 |
Dyrcona |
mrpeters: I'm not saying you are. I'm saying it's probably just one of those things that happens and building a new tarball is all it may take. |
| 10:23 |
mrpeters |
i think jeff spotted where it might be, but i hadn't looked yet |
| 10:23 |
jeff |
mrpeters: Evergreen-ILS-2.9.1/Open-ILS/src/sql/Pg/002.schema.config.sql contains three instances of the following line: INSERT INTO config.upgrade_log (version, applied_to) VALUES ('2.9.1', :eg_version); |
| 10:23 |
jeff |
mrpeters: it should contain only one instance of that line. |
| 10:23 |
mrpeters |
jeff: perfect, thats exactly what i needed to know |
| 10:23 |
Dyrcona |
Yeah, probably because make_release was run more than once. |
| 10:23 |
mrpeters |
lets just pull it from git, don't you think? |
| 10:24 |
mrpeters |
and put the 002.schema.config.sql from git in the tarball and then i can test it and confirm its fixed and we can release it on the site |
| 10:24 |
jeff |
I don't know if there are other likely places where there will be issues that share the same underlying cause as that duplication. |
| 10:25 |
Dyrcona |
As much fun as this is, and as much as this is my fault, I have work to do for my employer, now. I'll catch up later if I can. |
| 10:25 |
mrpeters |
good point |
| 10:25 |
mrpeters |
Dyrcona: don't stress my friend, its not a big deal! we all make mistakes. |
| 10:26 |
Dyrcona |
I'd check the code in the rel_2_9_1 branch. It's probably borked. |
| 10:50 |
|
phasefx joined #evergreen |
| 10:55 |
phasefx |
could some supybot admin do @rss announce add qatests ? |
| 11:04 |
jeff |
phasefx: done |
| 11:04 |
phasefx |
jeff++ |
| 11:04 |
phasefx |
jeff: could you hit #openils-evergreen as well? |
| 11:05 |
jeff |
done also. |
| 11:05 |
jeff |
@rss announce list |
| 11:05 |
pinesol_green |
jeff: qatests |
| 11:06 |
phasefx |
jeff: there should also be one for bugs.. don't know if we want them in here, but I like #openils-evergreen for bot dumps |
| 11:07 |
phasefx |
@list rss |
| 11:07 |
pinesol_green |
phasefx: add, announce add, announce list, announce remove, info, qatests, remove, and rss |
| 11:07 |
phasefx |
or maybe not |
| 11:08 |
|
mmorgan1 joined #evergreen |
| 11:09 |
|
mmorgan2 joined #evergreen |
| 11:11 |
|
mmorgan2 left #evergreen |
| 11:13 |
phasefx |
@rss add latestbugs http://feeds.launchpad.net/evergreen/latest-bugs.atom |
| 11:13 |
pinesol_green |
phasefx: The operation succeeded. |
| 11:14 |
|
mmorgan joined #evergreen |
| 11:14 |
jeff |
phasefx: added latestbugs to announce in #openils-evergreen -- do we want to try it in here also, or not right away? |
| 11:15 |
|
vlewis joined #evergreen |
| 11:15 |
phasefx |
jeff: let's see how it behaves; I'm not sure how noisy it is |
| 11:15 |
phasefx |
@rss add commits http://git.evergreen-ils.org/?p=Evergreen.git;a=atom |
| 11:15 |
pinesol_green |
phasefx: The operation succeeded. |
| 11:15 |
phasefx |
and that one too :D |
| 11:17 |
* dbs |
wondering if the virtual amount_encumbered should be listed on acq.purchase_order in fm_IDL.xml |
| 11:25 |
|
jihpringle joined #evergreen |
| 11:26 |
Dyrcona |
Vendor: There's an error in your XML response. |
| 11:26 |
Dyrcona |
Me: Um, no, it looks like a valid Problem response. |
| 11:26 |
Dyrcona |
Vendor: Yeah, that's the problem. |
| 11:32 |
jeff |
Ah, I see you're using the DCB-Kafka NCIP application profile. |
| 11:33 |
Dyrcona |
Well, I'm not sure what they expect when they send a RequestItem and the item is not available. |
| 11:33 |
Dyrcona |
But yeah, it has been rather Kafka-esque. |
| 11:34 |
Dyrcona |
NCIP is like that. ;) |
| 11:49 |
|
rlefaive joined #evergreen |
| 11:53 |
dbs |
It seems way harder than it should be to create a report that mimics the staff client acq search for "Show me line items that have a Line Item Detail - Fund Code of <x>" |
| 11:55 |
|
bmills joined #evergreen |
| 12:02 |
dbs |
I guess lots of logic for gathering the details is in OpenILS::Application::Acq::LineItem and the rendering gets sorted out in the corresponding thousand-line javascript |
| 12:02 |
dbs |
I'm going to try (and probably fail, heh) to put together a database view for my sanity |
| 12:06 |
|
rlefaive joined #evergreen |
| 12:06 |
kmlussier |
dbs: I don't know if it's what you're looking for, but here is a screenshot of a templated used at NOBLE http://www.screencast.com/t/uxxycIr9Faa5 |
| 12:07 |
* kmlussier |
wanders off to lunch |
| 12:09 |
|
Christineb joined #evergreen |
| 12:11 |
dbs |
thanks kmlussier - that's a start, but it looks like I'm going to need to extract the title from the acq.lineitem MARC, and try to roll up all of the debits into encumbered vs. spent totals per lineitem |
| 12:42 |
dbs |
so http://pastebin.ca/3278228 is what I'm starting with, missing direct charges but it's in the ballpark |
| 12:43 |
Dyrcona |
jeff mrpeters: Looking at my local copy of rel_2_9_1 INSERT INTO config.upgrade_log (version, applied_to) VALUES ('2.9.1', :eg_version); appears three times in 002.schema.config.sql. |
| 12:44 |
* Dyrcona |
is not having what he would qualify as a "good" day, but not necessarily a "bad" day, but certainly less good than average. |
| 12:44 |
dbs |
Need to pull in acq.invoice_item as well I guess |
| 12:46 |
mrpeters |
sorry Dyrcona :( hope it gets better! don't stress about this right now it took quite a while for anyone to notice, so no rush to fix |
| 12:47 |
Dyrcona |
bshum mentioned in a private chat that he once thought of modifying make release to not add the line if it already existed in 002.schema.config.sql. It seems to have happened to him once before. |
| 12:47 |
bshum |
Yeah I screwed up one of my first 2.7's that way |
| 12:47 |
bshum |
Or maybe it was an alpha or beta file |
| 12:47 |
bshum |
Either way, one of my tarballs got borked by not noticing that. |
| 12:48 |
bshum |
It's definitely a new RM gotcha for those of us with less practice using make_release. |
| 12:49 |
mrpeters |
yeah, stuff happens guys no worries |
| 12:49 |
Dyrcona |
I'll see if I can fix it. I think I can spare some time right now. |
| 12:50 |
Dyrcona |
Three of these in the branch: Bumping version numbers, adding Upgrade Script and Changelog |
| 12:50 |
Dyrcona |
So, if I revert those, and run make_release again that will fix it. |
| 12:51 |
Dyrcona |
That's what happens when stuff gets added after the fact, I guess.... |
| 12:52 |
Dyrcona |
Think it would be a problem to force push to rel_2_9_1? |
| 12:52 |
Dyrcona |
Or if I revert, I won't have to force push. Never mind. |
| 12:59 |
bshum |
If it was me, I would just fix the tarball's file and then push a git change up. |
| 12:59 |
bshum |
But I'm super lazy. |
| 12:59 |
bshum |
:D |
| 13:00 |
jeff |
Dyrcona: i don't see a branch containing the duplicate INSERT statements. |
| 13:01 |
jeff |
Dyrcona: perhaps it's just a local branch for you, or i'm missing it. |
| 13:01 |
Dyrcona |
jeff: rel_2_9_1? My local branch has it 3 times. |
| 13:01 |
jeff |
i'm looking at the branch tags/rel_2_9_1 -- i have no remote branch named simply rel_2_9_1 |
| 13:02 |
jeff |
and in tags/rel_2_9_1, Open-ILS/src/sql/Pg/002.schema.config.sql contains only one instance of the line INSERT INTO config.upgrade_log (version, applied_to) VALUES ('2.9.1', :eg_version); |
| 13:02 |
Dyrcona |
jeff: OK. my local 2_9_1 was used to make the tarball. |
| 13:02 |
* Dyrcona |
checks a few more things before getting too far in. |
| 13:14 |
Dyrcona |
jeff: Not sure how I managed this, but the only differences between the official rel_2_9_1 and mine are the two extra commits for bumping the version that appear in between and after the doc commits. |
| 13:14 |
mrpeters |
see, your day is getting better :) |
| 13:15 |
Dyrcona |
So, I'll just replace mine with the official one, revert the version bump, and then do make_release again. |
| 13:15 |
mrpeters |
Dyrcona++ |
| 13:15 |
Dyrcona |
Like bshum, I'm lazy, but in a different way. |
| 13:15 |
Dyrcona |
:) |
| 13:16 |
Dyrcona |
Eh, you know what....I'll just fix the tarball file. |
| 13:25 |
|
mmorgan left #evergreen |
| 13:29 |
|
yboston joined #evergreen |
| 13:29 |
|
rlefaive joined #evergreen |
| 13:30 |
|
vlewis_ joined #evergreen |
| 13:52 |
Dyrcona |
Ok. The 2.9.1 tarball and md5 have been updated on the downloads page. Hopefully they work for fresh installs, now. |
| 13:52 |
bshum |
Dyrcona++ |
| 14:13 |
bshum |
SIP-- |
| 14:14 |
bshum |
Just 'cause |
| 14:16 |
mrpeters |
thanks Dyrcona++ |
| 14:24 |
|
vlewis joined #evergreen |
| 14:36 |
|
mmorgan joined #evergreen |
| 14:45 |
|
rlefaive joined #evergreen |
| 14:50 |
|
rlefaive_ joined #evergreen |
| 14:54 |
|
linuxhiker joined #evergreen |
| 14:54 |
linuxhiker |
are there any perl modules that need to be installed on a standalone postgresql server? |
| 14:59 |
jboyer-isl |
linuxhiker: Yes, but they're not spelled out in the instructions anymore. |
| 14:59 |
jboyer-isl |
See here: http://evergreen-ils.org/documentation/install/README_2_9.html#_creating_the_evergreen_database |
| 15:00 |
jboyer-isl |
If you drop the source on your db server you can run the proper Makefile.install for your OS, or you can dig around in the makefiles to see what packages it installs. |
| 15:02 |
|
mtcarlson joined #evergreen |
| 15:03 |
|
ericar_ joined #evergreen |
| 15:04 |
|
maryj joined #evergreen |
| 15:28 |
|
rlefaive_ joined #evergreen |
| 16:07 |
|
rlefaive joined #evergreen |
| 16:15 |
|
rlefaive joined #evergreen |
| 16:16 |
|
maryj joined #evergreen |
| 16:20 |
Dyrcona |
@eightball Will Francis lighten up? |
| 16:20 |
pinesol_green |
Dyrcona: It is so. |
| 16:37 |
phasefx |
re: qa tests, I'm changing the ultimate pass/fail logic for the "Installing Evergreen pre-requisites" section, so that it just considers the final return value from the pre-req Makefile. There are 3 "Result: FAIL"'s currently from 3rd party tests in that section, one for Business-PayPal-API, one for Business-OnlinePayment-PayPal, and an expected one for Class-DBI-Frozen-301 |
| 16:45 |
|
rlefaive joined #evergreen |
| 16:58 |
|
bmills joined #evergreen |
| 17:00 |
|
jlitrell joined #evergreen |
| 17:06 |
|
mmorgan left #evergreen |
| 17:09 |
|
sylvar joined #evergreen |
| 17:11 |
sylvar |
Hey y'all, are any EG libraries publishing interesting statistics that could be consumed by an app (number of items currently checked out, etc.)? |
| 17:11 |
sylvar |
I'm specifically thinking about using Numerous (numerousapp.com), but open public data is a Good Thing anyway |
| 17:14 |
rangi |
sylvar: have you seen http://hea.koha-community.org/ ? the cron job that feeds it could be modified for evergreen im sure |
| 17:14 |
rangi |
https://github.com/biblibre/hea-app |
| 17:15 |
sylvar |
rangi++ nice! |
| 17:15 |
jeff |
sylvar: our dashboard makes CSV data available, but I'm not aware of anyone else consuming it. We'll also likely redesign it soon. |
| 17:15 |
jeff |
I've interest in this area. |
| 17:16 |
|
jihpringle joined #evergreen |
| 17:31 |
|
mrpeters joined #evergreen |
| 17:31 |
mrpeters |
Dyrcona: confirming new 2.9.1 tarball works great! |
| 18:31 |
|
mtcarlson left #evergreen |
| 19:26 |
|
sandbergja2 joined #evergreen |
| 20:52 |
|
sarabee joined #evergreen |
| 23:54 |
|
dcook joined #evergreen |
| 23:55 |
|
dcook joined #evergreen |
