| Time |
Nick |
Message |
| 01:27 |
|
Mark__T joined #evergreen |
| 03:05 |
|
TaraC joined #evergreen |
| 05:14 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 06:40 |
|
rlefaive joined #evergreen |
| 08:19 |
|
rjackson_isl joined #evergreen |
| 08:34 |
|
mmorgan joined #evergreen |
| 08:35 |
|
mrpeters joined #evergreen |
| 08:39 |
|
sarabee joined #evergreen |
| 08:46 |
|
Stompro_home joined #evergreen |
| 08:48 |
Stompro_home |
Is it safe to skip running eg_db_config on an upgrade if eg_db_config hasn't been changed and the opensrf*.xml config files haven't been reset? |
| 08:49 |
miker |
Stompro_home: yep, it's safe to skip when your DB settings are the same as before |
| 08:52 |
|
ericar joined #evergreen |
| 08:52 |
Stompro_home |
Thanks miker |
| 08:52 |
miker |
np |
| 09:03 |
|
Dyrcona joined #evergreen |
| 09:09 |
|
Dyrcona joined #evergreen |
| 09:28 |
csharp |
miker: referring to the last comment on bug 1469758... the default_statistics_target is 100 by default - if I were to ALTER TABLE SET STATISTICS ... on action.hold_request, would you have any advice on a sane target? without knowing anything else, I'd probably bump it to 1000 and see what happens, but thought it was worth asking |
| 09:28 |
pinesol_green |
Launchpad bug 1469758 in Evergreen "Simplified Pull List Interface query is very slow" (affected: 1, heat: 6) [Undecided,Triaged] https://launchpad.net/bugs/1469758 |
| 09:30 |
miker |
csharp: yep, I'd start with 1000. you can do per-column stats, too, and bump current_copy to 10000 (10k) |
| 09:30 |
miker |
but I'd start with the former |
| 09:31 |
csharp |
good - thanks |
| 09:31 |
miker |
np |
| 09:32 |
|
RoganH joined #evergreen |
| 09:38 |
|
yboston joined #evergreen |
| 09:48 |
csharp |
ugh - those stats are still off |
| 09:48 |
csharp |
I'll try the per-column stats |
| 09:52 |
|
ericar_ joined #evergreen |
| 09:56 |
miker |
csharp: what version of PG are you using? |
| 10:10 |
Dyrcona |
ping bshum |
| 10:11 |
bshum |
pong Dyrcona |
| 10:12 |
|
jwoodard joined #evergreen |
| 10:12 |
csharp |
miker: sorry - 9.3.9 |
| 10:19 |
bshum |
Oh that's fun. Our default stats is set to 500. |
| 10:19 |
Dyrcona |
We're on 9.3 now, too. |
| 10:19 |
Dyrcona |
I haven't just checked our stats, but things seem good. |
| 10:30 |
csharp |
yeah - turns out ours was at 500 (pg_tune) |
| 10:30 |
csharp |
now at 1000 |
| 10:36 |
|
yboston_ joined #evergreen |
| 10:38 |
|
Callender_ joined #evergreen |
| 10:38 |
bshum |
Well in my config anyways, there's a note next to it that says "bumped up" so pg_tune probably made ours something stupid to start. |
| 10:38 |
bshum |
Good odds that we changed it when we were working out oddities in the DB last Hackaway. |
| 10:40 |
bshum |
I should comment things better or track this stuff...hmm. |
| 10:43 |
|
ericar_ joined #evergreen |
| 10:44 |
|
krvmga joined #evergreen |
| 10:53 |
|
mtj_ joined #evergreen |
| 10:53 |
|
egbuilder joined #evergreen |
| 10:59 |
Dyrcona |
berick++ # wait for it. |
| 11:00 |
pinesol_green |
[evergreen|Bill Erickson] LP#1312308 script circ and deps removal - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2d8af35> |
| 11:00 |
pinesol_green |
[evergreen|Bill Erickson] LP#1312308 remove deprecated open-ils.penalty service - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=432a106> |
| 11:00 |
pinesol_green |
[evergreen|Bill Erickson] LP#1312308 circ scripts, penalty removal release notes - <http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=07e5797> |
| 11:00 |
bshum |
berick++ Dyrcona++ |
| 11:00 |
jeff |
berick++ Dyrcona++ |
| 11:00 |
jeff |
yay \o/ |
| 11:05 |
csharp |
@celebrate |
| 11:05 |
pinesol_green |
csharp: We're going to need a bigger boat. |
| 11:06 |
csharp |
berick++ Dyrcona++ |
| 11:19 |
krvmga |
lol. a couple of weeks ago, i met the actress who played Jaws first victim. |
| 11:20 |
Dyrcona |
Well, earlier this morning in private chat with bshum, I said (10:33:31 AM) Dyrcona: To paraphrase: "You're gonna need a bigger server." |
| 11:21 |
bshum |
:) |
| 11:21 |
bshum |
That should get added as a dunno too |
| 11:21 |
Dyrcona |
What's funny is our "bigger" servers are physically smaller these days. |
| 11:27 |
bshum |
Technology is amazing. |
| 11:33 |
Dyrcona |
There's a developers' meeting here in three and a half hours. |
| 11:35 |
|
bmills joined #evergreen |
| 11:47 |
Dyrcona |
I have started a draft agenda: http://evergreen-ils.org/dokuwiki/doku.php?id=dev:meetings:2015-07-01 |
| 11:54 |
|
bmills joined #evergreen |
| 12:02 |
jwoodard |
My computer keeps getting smaller but my phone keeps getting bigger. Technology is confusing. |
| 12:02 |
jwoodard |
I saw a phone yesterday that might as well been a tablet. |
| 12:24 |
|
buzzy joined #evergreen |
| 12:32 |
|
bmills joined #evergreen |
| 12:53 |
kmlussier |
Is http://wiki.evergreen-ils.org/doku.php?id=code_formatting_standards fairly accurate? It says that it's still a work in progress. |
| 12:53 |
bshum |
kmlussier: Since that was last edited in 2011 |
| 12:53 |
bshum |
I'm going to go with "it needs work" |
| 12:53 |
|
kitteh_ joined #evergreen |
| 12:54 |
bshum |
That said |
| 12:54 |
bshum |
Hmm |
| 12:58 |
bshum |
The indents with spaces vs. tabs is good. |
| 12:58 |
bshum |
And the braces thing looks right. |
| 12:59 |
bshum |
I wonder if those exceptions need revisiting though. We have become much more consistent with the tabs vs. space thing, but it's not all done yet. |
| 13:02 |
|
Samurai joined #evergreen |
| 13:11 |
Dyrcona |
OpenSRF is full of tabs. |
| 13:11 |
bshum |
Indeed. |
| 13:12 |
Dyrcona |
BTW, if you use Emacs: https://gist.github.com/Dyrcona/4216639 |
| 13:14 |
Dyrcona |
When you work on different projects, you learn to configure your editor appropriately. :) |
| 13:19 |
berick |
cperl-electric-boogaloo |
| 13:26 |
kmlussier |
Dyrcona: You use Emacs? |
| 13:26 |
Dyrcona |
Yes. |
| 13:26 |
jboyer-isl |
Ugh, I thought we were friends. |
| 13:26 |
jboyer-isl |
;) |
| 13:26 |
Dyrcona |
Have used it for 23 years. |
| 13:26 |
Dyrcona |
heh. |
| 13:27 |
Dyrcona |
jboyer-isl: It used to be my login process on vt connections. ;) |
| 13:27 |
jboyer-isl |
I knew there was a shell in there! |
| 13:27 |
Dyrcona |
berick++ |
| 13:27 |
Dyrcona |
Alt-X shell |
| 13:28 |
Dyrcona |
Or Alt-! to run a command. |
| 13:28 |
* Dyrcona |
uses Alt-! git push |
| 13:28 |
jboyer-isl |
I figured, though I imagine a whole shell isn't usually necessary |
| 13:29 |
jboyer-isl |
I think I've used vim's ! maybe once. psql |
| 13:29 |
Dyrcona |
Both fork a process to run a shell and/or the commands. |
| 13:29 |
jboyer-isl |
's I use a lot. |
| 13:29 |
Dyrcona |
Alt-X shell runs the shell process in an Emacs buffer. |
| 13:30 |
Dyrcona |
Ctrl-u Alt-! command is a great way to insert the output of a shell command into a buffer. |
| 13:30 |
Dyrcona |
;) |
| 13:32 |
Dyrcona |
Someone (probably more than one) have gone so far to make Emacs their controlling process for X sessions, and I've even seen a mod that makes the unused Emacs buffers take over the desktop background image. |
| 13:32 |
Dyrcona |
I can vi(m) when I have to, but would rather not. |
| 13:33 |
bshum |
nano for life! |
| 13:33 |
kmlussier |
bshum: In my travels today, I stumbled across bug 1197636. Mind if I remove you from the assigned to column? |
| 13:33 |
pinesol_green |
Launchpad bug 1197636 in Evergreen "Email record detail does not check for email" (affected: 1, heat: 8) [Medium,Triaged] https://launchpad.net/bugs/1197636 - Assigned to Ben Shum (bshum) |
| 13:34 |
bshum |
kmlussier: I'm not moving quickly on that, so no. I do not mind. |
| 13:36 |
kmlussier |
Done. :) |
| 13:46 |
|
mtcarlson joined #evergreen |
| 13:49 |
csharp |
argh - so can someone provide me with a hint as to where the code is that generates the total under the "Bills" button in the patron account view? |
| 13:49 |
csharp |
we have an account showing a balance in the Bills screen, but it's not showing the balance under the Bills button |
| 13:54 |
bshum |
csharp: I might have expected that to be a part of one of those summary views |
| 13:54 |
bshum |
like money.materialized_billable_xact_summary |
| 13:54 |
bshum |
Or similar. |
| 13:54 |
jboyer-isl |
csharp: You might see if that user has any transactions with xact_finish set and positive balances. |
| 13:55 |
jboyer-isl |
In some places the code pays attention to xact_finish, some places it doesn't. |
| 13:55 |
csharp |
ooh - that's probably it |
| 13:57 |
bshum |
jboyer-isl++ #expert knowledge of being in the trenches |
| 13:58 |
jboyer-isl |
That and scratching a bald spot in our heads at seeing the same issue several times in the past. ;) |
| 14:18 |
csharp |
huh - that's not it |
| 14:19 |
csharp |
oh wait - that *is* it |
| 14:19 |
csharp |
positive balance and xact_finish is set |
| 14:21 |
Dyrcona |
Stompro: Will you be at the developers' meeting this afternoon? |
| 14:21 |
Dyrcona |
Ditto dbwells. |
| 14:22 |
Dyrcona |
I have questions for you both. |
| 14:22 |
dbwells |
Dyrcona: I'll be around. |
| 14:23 |
csharp |
jboyer-isl++ |
| 14:23 |
Dyrcona |
dbwells: Great! I've put your name in the agenda. :) |
| 14:23 |
Stompro |
I'll be there, because now I'm very curious. |
| 14:23 |
Dyrcona |
Nothing bad. |
| 14:28 |
csharp |
@blame [someone] for something bad |
| 14:28 |
pinesol_green |
dbs HAXORED csharp's SERVERZ!!!! for something bad |
| 14:28 |
|
dMiller_ joined #evergreen |
| 14:29 |
csharp |
@dunno add Ba ba ba dook Dook DOOK! |
| 14:29 |
pinesol_green |
csharp: The operation succeeded. Dunno #40 added. |
| 14:34 |
jboyer-isl |
Quick Q for those with some Composite Coded Value Maps experience: Can a record attribute be the root of the tree, or does the root have to be a boolean operator? I've got some definitions that only allow a single value, but they don't display an expression in the editor. |
| 14:35 |
Stompro |
Dyrcona, I just assigned myself to LP:1312297 so I would put in my next bug fixing branch, if it is higher priority then maybe someone else should grab it. I'm not sure when I'll have time to test again. |
| 14:35 |
jboyer-isl |
If that's just a display quirk I don't care, but now is the time to go back and make them all children of an OR or something like that if need be. |
| 14:36 |
Dyrcona |
Stompro: That is basically what I planned to ask you about. |
| 14:40 |
Stompro |
Drycona, I'll unassign myself, so someone else can grab if they have a chance. I'll still try and test it when I have a chance, if someone doesn't beat me too it. |
| 14:41 |
Dyrcona |
Stompro: OK with me. |
| 14:41 |
Stompro |
And one agenda item done, <check> :-) |
| 14:42 |
Dyrcona |
Mostly. I changed it, but they're really up for discussion. |
| 14:44 |
Dyrcona |
Meeting starts in about 15 minutes. |
| 14:46 |
dbwells |
jboyer-isl: I just created a quick test case, and it seemed to work alright, so I think it is just a display quick. |
| 14:47 |
jboyer-isl |
dbwells: Thanks! |
| 14:47 |
jboyer-isl |
dbwells++ |
| 14:48 |
dbwells |
s/quick/quirk/ |
| 14:48 |
Dyrcona |
heh |
| 14:51 |
dbwells |
jboyer-isl: There looks to be some of that in stock, too, such as 'blu-ray' in Search Formats. |
| 14:52 |
jboyer-isl |
Oops, I looked at a few stock defs to see if there were some like that; guess I didn't look hard enough. |
| 15:00 |
Dyrcona |
Well, it is meeting time if everyone is ready? |
| 15:01 |
* kmlussier |
is always ready |
| 15:01 |
bshum |
Today is Canada Day isn't it? |
| 15:01 |
kmlussier |
bshum: You might be right. |
| 15:01 |
Dyrcona |
Should that stop us from having the meeting? |
| 15:01 |
Samurai |
Sure is. :) The library used to have free cake in Edmonton. |
| 15:02 |
bshum |
Eh, maybe it'll just be a short meeting. |
| 15:02 |
Dyrcona |
Ok, then. :) |
| 15:02 |
kmlussier |
Yeah, a short meeting works. I suspect we will be missing a few people. |
| 15:02 |
Dyrcona |
#startmeeting 2015-07-01 Developers' Meeting |
| 15:02 |
pinesol_green |
Meeting started Wed Jul 1 15:02:41 2015 US/Eastern. The chair is Dyrcona. Information about MeetBot at http://wiki.debian.org/MeetBot. |
| 15:02 |
pinesol_green |
Useful Commands: #action #agreed #help #info #idea #link #topic. |
| 15:02 |
pinesol_green |
The meeting name has been set to '2015_07_01_developers__meeting' |
| 15:02 |
Dyrcona |
#topic Introductions |
| 15:03 |
csharp |
#info csharp = Chris Sharp, GPLS |
| 15:03 |
kmlussier |
#info kmlussier is Kathy Lussier, MassLNC |
| 15:03 |
bshum |
#info bshum = Ben Shum, Bibliomation |
| 15:03 |
yboston |
#info yboston = Yamil Suarez: Berklee College of Music |
| 15:03 |
dbwells |
#info dbwells = Dan Wells, Hekman Library (Calvin College) |
| 15:03 |
Stompro |
#info Stompro = Josh Stompro, Lake Agassiz Regional Library, MN |
| 15:03 |
Dyrcona |
So to introduce yourself, just type #info nick = Name, Affiliation |
| 15:03 |
remingtron |
#info remingtron = Remington Steed, Hekman Library (Calvin College) |
| 15:03 |
miker |
#info miker = Mike Rylander, ESI |
| 15:03 |
Dyrcona |
#info Dyrcona = Jason Stephenson, MVLC |
| 15:03 |
jeff |
#info jeff = Jeff Godin, Traverse Area District Library (TADL) |
| 15:03 |
jboyer-isl |
#info jboyer-isl = Jason Boyer, Evergreen Indiana |
| 15:04 |
Dyrcona |
Anyone else? |
| 15:05 |
Dyrcona |
Ok, then moving on. |
| 15:05 |
Dyrcona |
#topic Action Items from Last Meeting |
| 15:05 |
Dyrcona |
Do we usually do topic or info for the items? |
| 15:06 |
bshum |
I usuallly just info the items |
| 15:06 |
bshum |
And re-action them if they get deferred |
| 15:06 |
Dyrcona |
#info Dyrcona to add series and milestone(s) for 2.9 in Launchpad. Done. |
| 15:06 |
jeff |
Dyrcona++ |
| 15:06 |
csharp |
Dyrcona++ |
| 15:06 |
Dyrcona |
The milestones and series are there, though we haven't used the series, yet. |
| 15:07 |
Dyrcona |
#info Dyrcona to create 2.9 road map and add it to DokuWiki at http://wiki.evergreen-ils.org/doku.php?id=faqs:evergreen_roadmap is also done. |
| 15:07 |
Dyrcona |
#link http://evergreen-ils.org/dokuwiki/doku.php?id=faqs:evergreen_roadmap:2.9 is the Evergreen 2.9 roadmap. |
| 15:08 |
Dyrcona |
#info gmcharlt and eeevil to organize a webstaff client hacking day in July |
| 15:08 |
Dyrcona |
And I leave to gmcharlt or miker to update us on the status of this one. |
| 15:09 |
miker |
organizing still underway. gmcharlt is unavailable today, though |
| 15:09 |
Dyrcona |
Ok, so this is deferred to the next meeting. |
| 15:09 |
miker |
we'll coordinate on the general and dev lists |
| 15:10 |
jeff |
We might have a recap by the next meeting. :-) |
| 15:10 |
Dyrcona |
True, we probably will. |
| 15:10 |
Dyrcona |
But for the sake of form... |
| 15:11 |
Dyrcona |
#action gmcharlt and eeevil to organize a webstaff client hacking day in July |
| 15:11 |
Dyrcona |
So any missing action items? |
| 15:12 |
bshum |
Looked accurate based on the last meeting. |
| 15:12 |
Dyrcona |
Yes, kmlussier++ for moving them to today's agenda. |
| 15:12 |
Dyrcona |
So, do we have any updates for OpenSRF? |
| 15:12 |
bshum |
Though we may need to go back further and grab some of the in-person meeting ones forward next time. |
| 15:12 |
jeff |
I'm still on the hook for posting some ideas regarding (at least considering) moving toward more merge commits. |
| 15:12 |
bshum |
Yeah, i was thinking of the merge commit stuff |
| 15:13 |
bshum |
And some RM reshuffling |
| 15:13 |
miker |
a new opensrf was tagged 7 days ago |
| 15:13 |
Dyrcona |
#topic OpenSRF |
| 15:13 |
Dyrcona |
miker that was 2.4.1? |
| 15:13 |
bshum |
#info OpenSRF 2.4.1 was tagged and released by gmcharlt last week |
| 15:14 |
bshum |
The website was updated with the new stuff and blog release too |
| 15:14 |
Dyrcona |
bshum: thanks. |
| 15:14 |
jeff |
gmcharlt++ miker++ |
| 15:14 |
bshum |
Oh maybe not blog |
| 15:14 |
kmlussier |
Should we add those as action items now so that we remember them for next month's meeting? |
| 15:14 |
Dyrcona |
gmcharlt++ miker++ |
| 15:14 |
miker |
gmcharlt++ |
| 15:14 |
Dyrcona |
kmlussier: Let's add them under new business at the end, even thought they're old business? |
| 15:14 |
kmlussier |
Dyrcona: Sounds good to me. |
| 15:15 |
bshum |
I think the key thing is that there's a tiny important fix for websockets in OpenSRF 2.4.1 |
| 15:15 |
Dyrcona |
Ok, so anything else for OpenSRF? |
| 15:15 |
miker |
sorry, boinc client making my machine too slow... suspending you, seti! |
| 15:15 |
bshum |
That's important for web client users/testers |
| 15:16 |
miker |
Dyrcona: nope, that's it for this month re opensrf. 'cept for bshum's note |
| 15:16 |
Dyrcona |
Yep and thanks. |
| 15:16 |
Dyrcona |
Next topic |
| 15:16 |
Dyrcona |
#Evergreen |
| 15:16 |
Dyrcona |
oops. |
| 15:16 |
Dyrcona |
#topic Evergreen |
| 15:16 |
kmlussier |
heh |
| 15:17 |
Dyrcona |
This is my first time actually running a meeting, so if I'm going too fast, let me know. ;) |
| 15:17 |
Dyrcona |
#info JavaScript circ and hold rules removed as of July 1, 2015. |
| 15:17 |
jeff |
No complaints here. |
| 15:17 |
jeff |
Dyrcona++ berick++ |
| 15:18 |
jboyer-isl |
Agreed, Dyrcona++ berick++ ! |
| 15:18 |
Dyrcona |
Thanks to berick for doing the work. I'm sure it was fun deleting all that code! |
| 15:18 |
* miker |
shed a single tear for the backend js |
| 15:19 |
Dyrcona |
I recall occasionally having problems getting SpiderMonkey to install, so I won't cry. :) |
| 15:19 |
jeff |
berick++ also for bug 1312297 which I suspect is close to next. I'm reviewing/testing -- any comments on need for tests and/or release notes? Release notes seems like a "for certain". |
| 15:19 |
pinesol_green |
Launchpad bug 1312297 in Evergreen "time to remove the old web-based selfcheck interface" (affected: 4, heat: 18) [Wishlist,Confirmed] https://launchpad.net/bugs/1312297 |
| 15:19 |
Dyrcona |
jeff: Yes, that's the next "topic" |
| 15:19 |
jeff |
Ah. I would probably know that if I had the agenda up. Sorry! |
| 15:20 |
Dyrcona |
I'm going to do this one as an info before making an action item. |
| 15:20 |
Dyrcona |
#info RM will look into removing old self check interface. |
| 15:20 |
Dyrcona |
So, I put that I, as RM, would do this in the info, but I really wanted to find out if anyone else wanted to look at it. |
| 15:20 |
yboston |
http://evergreen-ils.org/dokuwiki/doku.php?id=dev:meetings:2015-07-01 |
| 15:20 |
jeff |
I'm game, and can make time. |
| 15:21 |
Dyrcona |
jeff: Cool, I was just about to ask if you already had looked at it some. |
| 15:21 |
Dyrcona |
So, does the self check have to go before the remaining JSPAC code goes? |
| 15:22 |
jeff |
After the fun of seek-and-destroy on jspac/craftsman at the conference, I was pulled back to reality for a bit but expect bug 1312309 to be ready for more eyes by mid next week. |
| 15:22 |
pinesol_green |
Launchpad bug 1312309 in Evergreen "to remove last remnants of JSPAC" (affected: 3, heat: 14) [Wishlist,Confirmed] https://launchpad.net/bugs/1312309 - Assigned to Jeff Godin (jgodin) |
| 15:22 |
bshum |
jeff++ # seek and destroy :) |
| 15:22 |
Dyrcona |
Ok that segues into the next item on the agenda. |
| 15:22 |
jeff |
Dyrcona: "have to" depends on how clean you want things, but i think selfcheck should go next, yes. It's also a smaller set of changes than jspac/craftsman. |
| 15:22 |
Dyrcona |
jeff: Do you want action items for those? |
| 15:23 |
jeff |
I will take them, yes. |
| 15:23 |
jeff |
Anyone want to pre-volunteer to review? |
| 15:23 |
Dyrcona |
#action jeff will look into removing old self check interface. |
| 15:23 |
Dyrcona |
I'll review. |
| 15:24 |
Dyrcona |
Though, I think some of it now is just review, isn't it? |
| 15:24 |
jeff |
And, does anyone have input on tests/QA for these mostly web/js removals? |
| 15:24 |
jeff |
selfcheck is review and release notes (which i can craft). i think berick's done the work already. |
| 15:24 |
Dyrcona |
#action jeff will look at removing old JSPAC code. |
| 15:24 |
Dyrcona |
yep. berick++ again. |
| 15:25 |
Dyrcona |
As for tests, I'm not sure what one could except make sure basic functionality of other parts of Evergreen still works. |
| 15:26 |
Dyrcona |
jeff++ for taking those two on. |
| 15:26 |
jeff |
That's good enough for me. If something makes sense to test, I'll do it, but won't stress about the RM not accepting removal of jspac due to lack of tests. :-) |
| 15:27 |
Dyrcona |
The old self check should be fairly simple, 'cause I don't think anything else really touches it. |
| 15:27 |
Dyrcona |
heh |
| 15:27 |
jeff |
I have at least one other question that I might hit the general/dev list with -- removing lots (and LOTS) of images that have been in the web dir for a while that have only ever been used in "stock" by things like jspac/craftsman. |
| 15:28 |
Dyrcona |
Right. Someone might actually have template modifications to use them, but I doubt it. |
| 15:28 |
jeff |
Do we consider the possibility that sites have used those images ("because they were there") in local templates/etc worth not actually removing them from the repo? My thought is that they should go. |
| 15:28 |
bshum |
If their original use was for jspac, etc. I think it's good to kill those off |
| 15:29 |
bshum |
If someone needs the originals, there's still code history to draw from and earlier packages. |
| 15:29 |
bshum |
It's not like they're actually gone forever.. |
| 15:29 |
miker |
and we're note removing them from the internet :) |
| 15:29 |
jboyer-isl |
If they're not referenced in the current skin they can go, it's not as if it's difficult for those using them locally to pull a copy out of git. :) |
| 15:29 |
jboyer-isl |
Too slow! |
| 15:29 |
bshum |
And technically, with upgrades, the file will still live on locally |
| 15:29 |
berick |
and they'll still be in the installed web dir |
| 15:29 |
Dyrcona |
And, they'll be warned, if they read release notes. |
| 15:29 |
bshum |
Unless we add something to actually remove them |
| 15:30 |
Dyrcona |
We don't usually do that. |
| 15:30 |
jeff |
My thought on THAT was to address the removal in the release notes. |
| 15:30 |
Dyrcona |
Still good to ask ahead of time as a sort of pre-warning. :) |
| 15:31 |
miker |
+1 to release notes |
| 15:31 |
yboston |
Would a quick warning email to the general list complement the mention in the release notes? |
| 15:31 |
jeff |
"hey, this still is no longer installed -- if you have it kicking around and you don't want to do a clean install of your web dir you might want to clean things up" |
| 15:31 |
kmlussier |
+1 to removing them and addressing it through release notes |
| 15:32 |
jeff |
yboston: possibly a heads-up after the work is tested and merged and the release notes are crafted. less uncertainty that way. |
| 15:32 |
jeff |
yboston++ i'll make a mental note |
| 15:32 |
Dyrcona |
#agreed release notes are a good idea. |
| 15:32 |
Dyrcona |
:) |
| 15:32 |
bshum |
Dyrcona++ :) |
| 15:33 |
Dyrcona |
Anything else on remove jspac and/or the old self check interface? |
| 15:34 |
jeff |
yes. |
| 15:35 |
jeff |
There are other things (like "old bbags interface" and "dtree.js" and "found a few sprintf implementations that we no longer use") that can be pruned. As RM, do you have preference for those having bugs for each logical "thing" ripped out? |
| 15:36 |
Dyrcona |
I think the old bbags interface should possibly be its own bug. |
| 15:36 |
Dyrcona |
The others could maybe be all together on a single, remove old stuff bug, unless they were mostly just around for jspac, in which case I'd say lump them into the jspac bug. |
| 15:37 |
jeff |
I don't want to go crazy scrubbing unused code, but there have been a few obvious targets that I've come across. Okay, I'll do some smaller bugs (which probably will have fewer/no dependencies / pre-reqs for merging). |
| 15:37 |
bshum |
jeff++ |
| 15:37 |
Dyrcona |
OK with me. |
| 15:38 |
jeff |
Ah. Nevermind, scratch that, I'll consider a medium "remove some small things" bug unless I come across other things. I'll try and use my judgement based on the guidance here. :-) |
| 15:39 |
Dyrcona |
Anything else before we move on? |
| 15:39 |
jeff |
Does anyone think we should give consideration to removing old unused strings? There are likely to be many with the removal of so many old UIs. |
| 15:39 |
jboyer-isl |
jeff++ # code we don't have doesn't have bugs. :) |
| 15:40 |
bshum |
jeff: that's a good thought |
| 15:40 |
jeff |
Worth it? Not worth it? Something for another time? |
| 15:40 |
* bshum |
wonders if less strings means faster i18n dance |
| 15:40 |
Dyrcona |
Definitely worth it, if it isn't too time consuming. |
| 15:40 |
bshum |
Even slightly faster is faster.... |
| 15:40 |
jboyer-isl |
Cleaning up old strings may be a good idea since there are so many things being cleaned up. I don't think it matters if it's 3-4, but for the remainder of JSPAC and all of the old selfcheck does make it worth looking into. |
| 15:41 |
jeff |
Got it. |
| 15:41 |
jeff |
Okay. I don't have anything else on that. :-) |
| 15:41 |
jboyer-isl |
bshum: I don't imagine it would be noticeable in use, but if we have something like 20% fewer strings that makes it easier for devs to get around (and keeps new translations small) |
| 15:41 |
yboston |
jeff: I want to learn more about i18n, I could help with deleting osme strings |
| 15:42 |
kmlussier |
jeff++ |
| 15:42 |
jeff |
yboston++ thanks! |
| 15:43 |
yboston |
jeff: lets talk about it later |
| 15:43 |
miker |
jeff: heh ... just ran across this in a CVS (yes, CVS) log entry: 2007-01-18 14:42 miker * Open-ILS/xul/staff_client/server/cat/marcedit.xul: removing unused sprintf lib |
| 15:43 |
miker |
apparently we've churned through a few of those... |
| 15:43 |
Dyrcona |
Ok. moving on. |
| 15:43 |
jeff |
miker: i think i found at least three sprintf javascript implementations, one of which was added, then the code using it was removed, then LATER code re-used the sprintf implementation that had been left behind... :-) |
| 15:44 |
Dyrcona |
#info Query dbwells on the conditional negative balances work. |
| 15:44 |
Dyrcona |
So my questions for dbwells are do you think this could get polished up before the alpha? |
| 15:44 |
Dyrcona |
And, would you like some help writing tests, etc.? |
| 15:45 |
kmlussier |
I have put a deadline in my calendar to complete another round of negative balance testing by Wednesday. It's looking promising at the moment. |
| 15:45 |
jeff |
I'd like to volunteer to assist where possible/useful on testing and/or tests. |
| 15:45 |
Dyrcona |
I am also volunteering to help with whatever needs done at this point. |
| 15:46 |
Dyrcona |
I started the mess and feel the least I can do is help to get it done. |
| 15:46 |
dbwells |
the bug is pretty much as stated on the branch, i.e. ready for eyeballs, and still needing tests. We've done the work of getting at least one interesting test to load, so we're still hoping the others will flow from that more easily, but haven't gotten back to it yet. |
| 15:46 |
dbwells |
When is the alpha, again? |
| 15:46 |
Dyrcona |
The alpha is the 29th of July, so exactly 4 weeks from today. |
| 15:47 |
Dyrcona |
We've traditionally accepted new features up to the beta cut-off. |
| 15:47 |
dbwells |
I think it can make alpha, barring some major setback. |
| 15:48 |
jeff |
Dyrcona++ dbwells++ kmlussier++ |
| 15:48 |
kmlussier |
I think it would be nice to shoot for alpha. If the timeline slips a bit, then, it isn't pushed off to another release. And it gives more people to play with scenarios that may have been missed in earlier testing. |
| 15:48 |
dbwells |
I'll plan to push whatever tests I have on next Friday (even if it's still just the one), then others can more easily add to it at that point. |
| 15:48 |
Dyrcona |
dbwells++ kmlussier++ |
| 15:48 |
Dyrcona |
For the logs, the beta is planned for August 19. |
| 15:48 |
dbwells |
Of course, if people just want to jump in with tests from scratch, I don't oppose that in any way, either :) |
| 15:49 |
kmlussier |
When it gets in, we can have a nice IRC party where I will gladly hand out desserts to everyone involved in the project. Virtual desserts, of course. |
| 15:49 |
bshum |
Hehe |
| 15:49 |
kmlussier |
See how I said 'when' and not 'if.' :) |
| 15:50 |
Dyrcona |
I think an action or info should come out of this. |
| 15:50 |
dbwells |
I'll action myself for the test stuff. |
| 15:50 |
kmlussier |
Dyrcona: You can give me an action item to finish my testing by next Wednesday. |
| 15:50 |
kmlussier |
Or I guess I can action myself. |
| 15:50 |
Dyrcona |
Ok. |
| 15:50 |
Dyrcona |
you can add the actions yourselves. |
| 15:51 |
dbwells |
#action dbwells will hopefully write more neg balances tests and push whatever he has ready on July 10 |
| 15:51 |
kmlussier |
#action kmlussier to complete her testing on the negative balance branch by July 8 |
| 15:51 |
* kmlussier |
works best under deadline pressure. |
| 15:51 |
Dyrcona |
deadlines++ |
| 15:52 |
Dyrcona |
#action Dyrcona will follow up with negative balance branch after July 10. |
| 15:52 |
* dbwells |
works only under deadline pressure ;) |
| 15:52 |
|
buzzy joined #evergreen |
| 15:53 |
Dyrcona |
Ok. Anything else for negative balances? |
| 15:53 |
dbwells |
nothing here |
| 15:53 |
Dyrcona |
Other than this is going to be huge for so many users. |
| 15:54 |
kmlussier |
negative-balances-- |
| 15:54 |
kmlussier |
no-more-negative-balances++ |
| 15:54 |
kmlussier |
That's it from me. |
| 15:54 |
Dyrcona |
OK. |
| 15:54 |
Dyrcona |
#topic New and Old Business |
| 15:54 |
Dyrcona |
So earlier we said there were some action items from the face to face meeting that needed to be added. |
| 15:55 |
Dyrcona |
Now's the time to do that. |
| 15:56 |
yboston |
At the meeting we spoke about a test day, and Liam started the planning on that |
| 15:56 |
yboston |
he sent out one email about it |
| 15:56 |
jeff |
#action jeff will articulate ideas on merge vs cherry-pick and start discussion/proposal on dev list |
| 15:58 |
Dyrcona |
yboston: I feel iffy giving a vague action to someone who isn't here. |
| 15:58 |
jeff |
with Liam not here to take an action, perhaps an info pointing out that planning is under way? |
| 15:58 |
yboston |
I can follow up with him, I already followed up with him last week |
| 15:58 |
jeff |
now THAT sounds like an action item with your name on it. ;-) |
| 15:59 |
Dyrcona |
#action yboston to followup with ldw about a testing day. |
| 15:59 |
Dyrcona |
:) |
| 15:59 |
Dyrcona |
should probably be a space between follow and up, but English.... |
| 15:59 |
miker |
jeff: do your ideas boil down to merg-- ? ;) |
| 16:00 |
* yboston |
runs off to another meeting |
| 16:00 |
Dyrcona |
So, we're right on the hour, is there any additional new business? |
| 16:01 |
kmlussier |
Was there something about the release schedule too? And maybe selecting an RM earlier? |
| 16:01 |
kmlussier |
I don't recall whose action item it was, but I thought there was some discussion on it. |
| 16:01 |
bshum |
Yeah I think that's mine. |
| 16:02 |
bshum |
#action bshum to work with berick and others on crafting more information about release maintaining and schedules |
| 16:02 |
jeff |
miker: i'm back on the fence, mostly. :-) |
| 16:02 |
bshum |
That's all I can think of today. |
| 16:03 |
Dyrcona |
Ok. Anything else? |
| 16:04 |
Dyrcona |
Hearing nothing else. I'll call the meeting adjourned. |
| 16:04 |
Dyrcona |
#endmeeting |
| 16:04 |
pinesol_green |
Meeting ended Wed Jul 1 16:04:54 2015 US/Eastern. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) |
| 16:04 |
pinesol_green |
Minutes: http://evergreen-ils.org/meetings/evergreen/2015/evergreen.2015-07-01-15.02.html |
| 16:04 |
pinesol_green |
Minutes (text): http://evergreen-ils.org/meetings/evergreen/2015/evergreen.2015-07-01-15.02.txt |
| 16:04 |
pinesol_green |
Log: http://evergreen-ils.org/meetings/evergreen/2015/evergreen.2015-07-01-15.02.log.html |
| 16:05 |
jeff |
Dyrcona++ |
| 16:05 |
jboyer-isl |
Dyrcona++ |
| 16:05 |
Dyrcona |
Thanks, everyone. |
| 16:05 |
jboyer-isl |
@bartender miker |
| 16:05 |
* pinesol_green |
fills a pint glass with Stone 04.04.04 Vertical Epic Ale, and sends it sliding down the bar to miker (http://beeradvocate.com/beer/profile/147/16441) |
| 16:05 |
kmlussier |
Dyrcona++ |
| 16:05 |
* jeff |
scrolls back to see who first said something about it being a "short" meeting today |
| 16:05 |
Dyrcona |
jeff: The fence can be a tricky place to walk. :) |
| 16:05 |
jboyer-isl |
That's for missing the JS backend, seemed out of place mid-meeting. ;) |
| 16:05 |
miker |
jboyer-isl: thanks, I needed that! |
| 16:05 |
kmlussier |
@bartender [someone] |
| 16:05 |
* pinesol_green |
fills a pint glass with Lindeman's Gueuze Lambic, and sends it sliding down the bar to Bmagic (http://beeradvocate.com/beer/profile/187/3566/) |
| 16:05 |
* miker |
pours some out for backend js |
| 16:06 |
jeff |
bshum! it was you! |
| 16:06 |
Dyrcona |
@coffee [someone] |
| 16:06 |
bshum |
jeff: I know, I jinxed it. |
| 16:06 |
* pinesol_green |
brews and pours a cup of Guatemala Pandora Pacamara Medium-Light Roast, and sends it sliding down the bar to egbuilder |
| 16:06 |
Dyrcona |
Heh. |
| 16:06 |
kmlussier |
Do we have a Launchpad tag for code that needs tests? |
| 16:06 |
Dyrcona |
No, we don't. |
| 16:06 |
bshum |
kmlussier: We can add one, simple enough for "needstests" |
| 16:07 |
jboyer-isl |
"unproven" |
| 16:07 |
jboyer-isl |
Maybe a little too harsh |
| 16:07 |
bshum |
hehe |
| 16:07 |
Dyrcona |
Just a bit... ;) |
| 16:07 |
jeff |
"worksintheory" :-) |
| 16:07 |
kmlussier |
heh, i like worksintheory |
| 16:07 |
Dyrcona |
Although there's a famous line from Knuth: Beware of bugs in the following code. I have only proven it correct and not tested it. |
| 16:08 |
jboyer-isl |
In the interest of not waffling too much, +1 to needstests |
| 16:08 |
Dyrcona |
Well, that could be something to discuss at the next dev meeting or on the list. |
| 16:09 |
* bshum |
already added it, but yes, probably |
| 16:09 |
Dyrcona |
'Cause it raises the question of whether or not that tag stops code from going into master. |
| 16:09 |
Dyrcona |
etc. |
| 16:09 |
jeff |
kmlussier: despite having suggested it (kinda' joking -- obscure reference) i think worksintheory might be a bad choice. needstests works for me. :-) |
| 16:09 |
kmlussier |
jeff: Yeah, I wouldn't actually use that on somebody else's code. Maybe my own. :) |
| 16:10 |
Dyrcona |
worksforme |
| 16:12 |
miker |
Dyrcona++ # for meeting |
| 16:12 |
* miker |
's favorite bugzilla status: WORKSFORME |
| 16:14 |
jeff |
``If you close a JIRA ticket for a bug in a WatchKit app that you can’t reproduce the resolution status should be “Not on my watch.”'' https://twitter.com/_Jordan/status/593231842339201026 |
| 16:17 |
kmlussier |
Is bug 1174498 something that would need a test before going in? |
| 16:17 |
Bmagic |
did someone pass me a beer? |
| 16:17 |
pinesol_green |
Launchpad bug 1174498 in Evergreen "Payment by billing type breakdown" (affected: 7, heat: 38) [Wishlist,Triaged] https://launchpad.net/bugs/1174498 |
| 16:17 |
kmlussier |
Bmagic: Yeah, that was me. You're welcome. :) |
| 16:17 |
jeff |
kmlussier: yes, IMO |
| 16:17 |
Bmagic |
kmlussier: awesome! |
| 16:19 |
Bmagic |
jeff: Did you and I speak about that bug? |
| 16:20 |
jeff |
Bmagic: i think at least briefly. iirc, the code that we each have in use currently is different, and i've some remaining concerns about future-dated bills that dbwells and i were talking about a few weeks back. |
| 16:21 |
Bmagic |
I forget where we are on it, we have it in production as I mention on LP. So far it's been working well. Right, futured dated bills, I looked at the function with that in mind and I didn't see any reason it wouldn't handle it |
| 16:23 |
jeff |
it trusts the billing timestamp on the bill, which means that things get mis-attributed under pretty common scenarios, especially if a a patron declares "i lost it" or you have items marked lost/longoverdue before they hit maxfines due to having a low per-day fine resulting in maxfines not being hit first. |
| 16:23 |
jeff |
ideally it could trust the billing timestamp, but the billing timestamp lies. :-) |
| 16:29 |
|
bmills joined #evergreen |
| 16:33 |
* mmorgan |
hates it when data lies ;-) |
| 16:33 |
Bmagic |
jeff: The oldest bill gets matched with the oldest payment. Then again with the next oldest, etc. How does it being in the future matter? |
| 16:34 |
Dyrcona |
"I'll gladly pay you next Tuesday for a hambuger today." |
| 16:40 |
Dyrcona |
No, I don't think I'll step into that hornet's nest. |
| 16:45 |
Bmagic |
ha! |
| 16:45 |
Bmagic |
oh by the way |
| 16:45 |
Bmagic |
Dyrcona++ # meeting handling |
| 16:53 |
Dyrcona |
@bartender |
| 16:53 |
* pinesol_green |
fills a pint glass with Spaten Oktoberfestbier, and sends it sliding down the bar to Dyrcona (http://beeradvocate.com/beer/profile/142/582/) |
| 16:54 |
kmlussier |
Stompro++ #release announcements on the list |
| 16:55 |
kmlussier |
@karma |
| 16:55 |
pinesol_green |
kmlussier: Highest karma: "Dyrcona" (63), "kmlussier" (43), and "bshum" (41). Lowest karma: "ie" (-4), "typos" (-4), and "marc" (-3). You (kmlussier) are ranked 2 out of 113. |
| 16:55 |
Dyrcona |
Not sure I've had that particular flavor from Spaten. |
| 16:56 |
Dyrcona |
Stompro++ |
| 16:56 |
Dyrcona |
I meant to copy/paste my blog post about scripted circ going away and sending it to the general list, but time got away from me. |
| 16:56 |
Dyrcona |
Perhaps tomorrow. |
| 16:56 |
pinesol_green |
Incoming from qatests: Test Success - http://testing.evergreen-ils.org/~live/test.html <http://testing.evergreen-ils.org/~live/test.html> |
| 16:57 |
kmlussier |
I still need to write a blog post on Bug Squashing Day. And on our ALA Exhibit. |
| 16:58 |
Dyrcona |
We have a pile of action items from today's meeting. |
| 17:00 |
Dyrcona |
Well, time for me to go. |
| 17:06 |
jeff |
Bmagic: the misattribution arises when the future dated overdue fine billing exists on the same transaction as a non-future dated billing which is forgiven. likely also an issue when voided. i have not enough recent experience with the current CNB branch to know if it remains an issue there. |
| 17:08 |
jeff |
bills and payments and voiding should be linear, and when a bill from last night comes "after" the forgive and the cash payment i just accepted from you, things get confused. |
| 17:08 |
jeff |
Bmagic: does that answer your question, or would more examples / detail help? |
| 17:09 |
jeff |
s/last night/early this morning/ etc |
| 17:12 |
kmlussier |
dbwells / remingtron: Did you have a chance to look into the org scoping issue I came across with bug 1379815? |
| 17:12 |
pinesol_green |
Launchpad bug 1379815 in Evergreen "Assign stat cats during Vandelay import/overlay of items" (affected: 1, heat: 8) [Wishlist,New] https://launchpad.net/bugs/1379815 |
| 17:12 |
kmlussier |
It would be nice to get that feature into 2.9. :) |
| 17:13 |
* kmlussier |
wraps up bug wrangling for now and wishes everyone a good night. |
| 17:14 |
mmorgan |
Good Night! |
| 17:14 |
dbwells |
kmlussier: It hasn't been revisited. Do you think it's a critical piece to getting it in? |
| 17:16 |
|
bmills joined #evergreen |
| 17:16 |
* dbwells |
thinks it probably wouldn't be too hard to do, but maybe not a likely problem |
| 17:17 |
miker |
jeff: I think dbwells' (proposed?) change to overdue billings getting a timestamp of the start (rather than the end) of the billing period will help address that |
| 17:18 |
kmlussier |
dbwells: Let me take a look at it again to refresh my memory on it. Overall, I think it's a good thing to stop the system from applying a stat cat that it shouldn't be applying. |
| 17:19 |
kmlussier |
Now I really say good night. |
| 17:19 |
dbwells |
kmlussier: I don't disagree, just a matter of tuits. |
| 17:19 |
dbwells |
kmlussier: and good night :) |
| 17:21 |
|
mmorgan left #evergreen |
| 17:25 |
jeff |
miker: agreed. he and i talked about it earlier last month (or possibly the month before) |
| 17:26 |
|
dMiller_ joined #evergreen |
| 17:31 |
Bmagic |
jeff: I think I am getting the idea |
| 17:32 |
Bmagic |
posting some examples on the LP bug would be nice |
| 17:33 |
dbwells |
miker: code exists (and we're using it in production). The biggest remaining issue (in my view) is in how to do an upgrade script which keeps the historical data as truthful as possible. See bug #1422379. If we truly have old fines produced with different timing logic, then we're already in a tough spot as far as historical truthiness goes. |
| 17:33 |
pinesol_green |
Launchpad bug 1422379 in Evergreen "Move money.billing timestamps back to moment of fine" (affected: 1, heat: 6) [Medium,New] https://launchpad.net/bugs/1422379 |
| 17:34 |
dbwells |
Under that thinking, moving everything back doesn't really hurt us, since we don't know the cutoff either way, and at least fines produced in roughly the last 4 years or so will be accurate. |
| 17:36 |
dbwells |
Or cutoffs, if we fiddled with the timing more than once back in the day. |
| 17:41 |
|
bmills joined #evergreen |
| 17:42 |
|
dMiller_ joined #evergreen |
| 18:50 |
|
jwoodard joined #evergreen |
| 18:50 |
jwoodard |
So the day now ends, with books put away in bins, A meeting awaits :( |
| 18:51 |
jwoodard |
day 2 in a haiku |
| 18:52 |
gsams |
jwoodard++ |
| 20:29 |
|
buzzy joined #evergreen |
| 22:22 |
|
maryj joined #evergreen |
