| Time |
Nick |
Message |
| 08:39 |
|
mmorgan joined #evergreen |
| 09:24 |
|
terranm joined #evergreen |
| 09:51 |
terranm |
phasefx: I'm trying to test the new Quipu code and having trouble getting a survey response to register. This is what Quipu is currently passing to us - is the format correct? https://drive.google.com/file/d/1Lgu4FAJvf6ExxakugpIgfnzid9aCIb9x/view |
| 09:53 |
terranm |
(I'm not seeing any errors in the logs) |
| 09:58 |
gmcharlt |
terranm: it looks like what the new code is expecting is that form parameter (which can be repeatable) is named 'asvr' and that it's value is a string of the form "$surveyid:$questionid:$answerid" |
| 10:05 |
terranm |
Aaah, okay! So that means the voter_registration lines 58 and 103 can be removed, right? |
| 10:05 |
gmcharlt |
yeah, I think so |
| 10:06 |
terranm |
Thank you!! gmcharlt++ |
| 10:09 |
terranm |
Just to make sure I understand correctly, what they would now pass to us for this same scenario would be (?): [asvr] => 1:1:4 |
| 10:09 |
gmcharlt |
yep |
| 10:10 |
terranm |
cool beans |
| 10:10 |
gmcharlt |
also, the responses will be additive during erenew |
| 10:11 |
terranm |
Perfect, thanks! |
| 10:38 |
|
Dyrcona joined #evergreen |
| 10:38 |
|
Christineb joined #evergreen |
| 13:07 |
Dyrcona |
Well, nice. Set a break point in the component code and the parts drop down shows up empty... |
| 13:17 |
|
jihpringle joined #evergreen |
| 13:17 |
Dyrcona |
Ok. looks like ngb-typeahead is sorting the dropdown components. |
| 13:21 |
Dyrcona |
Npt sure why it doesn't do that in 3.16 with Angular 18 unless there were changes since Angular 15. |
| 13:24 |
Dyrcona |
And, no. It doesn't look like typeahead sorts without help. |
| 13:30 |
Bmagic |
Dyrcona++ # keep up the good work |
| 13:47 |
Dyrcona |
I think it might be the grid component. |
| 14:01 |
Dyrcona |
Put a breakpoint at lin3 256 in template-grid.component.ts 'cause that's where there is a sort, and it didn't pause execution.... |
| 14:01 |
Dyrcona |
s/lin3/line/ |
| 14:03 |
Dyrcona |
git_worktree++ |
| 14:05 |
Dyrcona |
Ok, that was a red herring. template-grid.component is not used in vol-edit. |
| 14:13 |
Dyrcona |
Still stumped.... |
| 14:29 |
|
Lorne joined #evergreen |
| 14:30 |
Dyrcona |
Well, volEditPartDedupe is not responsible. I removed that and the parts are still sorted after a hard reload. |
| 14:32 |
Dyrcona |
Well, sorted by label, I mean. They're not sorted by label sort key, which they are until they go into the component. Whatever is doing the sort must be at a layer I'm not looking at. |
| 14:48 |
Dyrcona |
Anyone know how to set breakpoints in an Angular template? All I find with Google search and AI assistance is the standard steps to set breakpoints in JavaScript code. |
| 14:50 |
Dyrcona |
Chrome debugger doesn't show the html files. |
| 14:56 |
Dyrcona |
Oof. The Firefox debugger doesn't show the webpack files... |
| 14:58 |
Dyrcona |
ooh. But I might be able to put the breakpoint in the template with the Angular dev tools add-on. Here goes.... |
| 14:59 |
Dyrcona |
Nope. didn't work. Back to Chrome, I guess. |
| 15:12 |
Dyrcona |
Interesting: The Angular dev tools men on the right does not show the same things in Chrome as it does in Firefox, probably because Chrome shows most of it under webpack://. |
| 15:14 |
Dyrcona |
Well, breakpoints in templates don't work in Chrome, either... |
| 15:16 |
Dyrcona |
I can say we have a lot of work to do to catch up with the latest Angular releases. |
| 15:19 |
Dyrcona |
I'm also not sure that volEditPartDedupe is necessary. At least, with my sample records the results were the same with and without it. |
| 15:32 |
Bmagic |
Are you running Evergreen eg2 without having compiled it with --config=production? |
| 15:33 |
Dyrcona |
Bmagic: Of course. I never use production config on my test systems: I do `npx ng build` |
| 15:36 |
Dyrcona |
I also rm -rf web/eg2/* and rsync -av --delete to put the changes in place. Suppose I could use ng --watch or whatever but I'm usually not changing the code that frequently. |
| 15:38 |
Dyrcona |
"Empty Cache and Hard Reload" also comes in handy. |
| 16:03 |
Bmagic |
I was thinking that the JS breakpoints would be easier to read, and it sounds like you're already doing that. I've not tried to breakpoint Angular code |
| 16:09 |
Dyrcona |
So, I put breakpoints in the init code and they fire. I can inspect volcopy.bibParts in the console, and it is sorted the way that I expect. Then, I let the script resume and the interface comes up. I hit the parts drop down, and the parts are sorted in label order. |
| 16:10 |
Dyrcona |
I suspect it's the widget sorting them, but it doesn't happen on 3.16. I can't find any other code doing a sort between the time that the parts are retrieved and when they're loaded into the drop down via the template. |
| 16:11 |
Dyrcona |
If I uses the Inspector on the page, I can see the order of the entries in the component, and they are sorted in label order, but nothing had a directive on it to explicitly sort the entries. The interface in 3.16.3 does not sort the entries. They show up in the order that the are retrieved, i.e. with the "correct" sort order. |
| 16:12 |
Dyrcona |
Since nothing on our sided seems to explicitly sort the code or retrieve the entries again, I assume it's a change from Angular 15 to Angular 18, but what do I know? |
| 16:13 |
Dyrcona |
Uff.. It's late in the day, and I've been staring at a debugger all afternoon. Please forgive my fractured typing. |
| 16:18 |
Dyrcona |
I've tried putting breakpoints in the template itself, but they don't fire. I've tried breakpoints in the combobox code, and they also do not fire. |
| 16:19 |
Dyrcona |
Well, I did manage to get a combobox breakpoint to fire, but I had to step through alot of code and I never did get to the point where the combox is loaded. It seems like what did fire came after the template is created. |
| 16:20 |
Dyrcona |
I got a break point in the dedupe code to work, but it's not doing much and things look like they're in the correct order there still. Plus, I removed that pipe from the template entirely and tried it without the dedupe. I get the same results. |
| 16:29 |
Dyrcona |
Guess I'll give it another try on Monday. |
| 16:30 |
Dyrcona |
I might see if the eg-combobox code from 3.16 will work on 3.15. It could be a difference there that looks innocuous. |
| 16:32 |
|
Lorne joined #evergreen |
| 16:32 |
Dyrcona |
The only change there that looks significant is this: |
| 16:32 |
Dyrcona |
- this.controller = this.instance['_elementRef'].nativeElement as HTMLInputElement; |
| 16:32 |
Dyrcona |
+ this.controller = this.instance['_nativeElement'] as HTMLInputElement; |
| 16:34 |
Dyrcona |
Bet that makes no difference or doesn't work on 3.15. |
| 16:36 |
Dyrcona |
Think I'll go ahead and patch it with that so I can test it Monday. |
| 16:40 |
Dyrcona |
Well, ng build works, so that's something. |
| 16:41 |
Lorne |
I just installed fresh latest Evergreen and it will not load the site. Ansible reported no failed packages. Restarted Apache, opensrf, oils_ctl, websocketd, made sure opensrf owns /openils recursively, strace says "No routers defined in config file /openils/conf/opensrf_core.xml" - looked there and it seems some stuff might be missing. This has not |
| 16:41 |
Lorne |
happened before with same script, what could have gone wrong? |
| 16:42 |
Dyrcona |
Lorne: What does `osrf_control -l --diagnostic` say? |
| 16:43 |
Dyrcona |
As for my issue, it makes no difference with the backported eg-comobox code. Still not sorted correctly on 3.15.4. |
| 16:44 |
Lorne |
osrf_control is missing altogether apparently "command not found". Weird, will try a re-install and see if that's it |
| 16:45 |
Dyrcona |
Lorne: After installing Evergreen, you have to configure opensrf_core.xml and opensrf.xml again, i.e. it's done once for OpenSRF and once for Evergreen. I'm guessing the ansible script failed to set up the configruation. |
| 16:45 |
Dyrcona |
Lorne: make sure that /openils/bin is in your user's path. |
| 16:45 |
Lorne |
Aha, ok, yes those pieces were all automated before |
| 16:46 |
Lorne |
Prob just a bad install but will try your suggestion if still not working. ++ |
| 16:46 |
Dyrcona |
For adding the PATH, I usually do the following in .bash_aliases: |
| 16:46 |
Dyrcona |
# Add /openils/bin to PATH |
| 16:46 |
Dyrcona |
if [ -z "$(echo $PATH | grep /openils/bin)" ]; then |
| 16:46 |
Dyrcona |
PATH="${PATH}:/openils/bin" |
| 16:46 |
Dyrcona |
fi |
| 17:07 |
|
mmorgan left #evergreen |
| 18:12 |
|
jihpringle joined #evergreen |
| 19:08 |
|
jihpringle joined #evergreen |