| Time |
Nick |
Message |
| 08:31 |
|
mmorgan joined #evergreen |
| 11:55 |
csharp_ |
after chewing on this issue for several days, I've learned that we need to be updating the ISBN data for Business::ISBN more often |
| 11:56 |
csharp_ |
we weren't seeing added content images loading that should, and I was able to track it down to the Business::ISBN validation, which "succeeds" in that there's no runtime error or anything, but we only check that the Business::ISBN object was created, not actually for any errors it returns |
| 11:57 |
csharp_ |
when I installed the Business::ISBN::Data package from CPAN, apparently containing newer data, the covers now load |
| 11:58 |
csharp_ |
not sure if keeping that updated requires a cron job or what |
| 11:58 |
csharp_ |
Business::ISBN::Data documentation includes caveats about the data sometimes being bad :-( |
| 11:59 |
csharp_ |
(either that or we skip data validation and just use the ISBN-looking number pulled from the 020$a? |
| 11:59 |
csharp_ |
) |
| 11:59 |
csharp_ |
kind of feels like overkill given the stakes |
| 12:00 |
csharp_ |
also not sure where all the ISBN module gets called in the perl code |
| 12:01 |
|
jihpringle joined #evergreen |
| 12:03 |
csharp_ |
"Check that that data aren't weird: sometimes the group names have errors or oddities." |
| 12:36 |
|
jihpringle joined #evergreen |
| 12:40 |
csharp_ |
hmm, looks like Stompro went down a similar road: bug 2061568 |
| 12:40 |
pinesol |
Launchpad bug 2061568 in Evergreen "Added Content: B&T Fake ISBNs no longer working" [Undecided,New] https://launchpad.net/bugs/2061568 |
| 12:41 |
csharp_ |
hey, a lot more than Fake ISBNs not working at B&T, though, huh? eh? eh? too soon I guess |
| 12:41 |
* csharp_ |
pulls collar |
| 12:42 |
csharp_ |
kind of thinking that Business::ISBN::Data issues might be kind of tangential to our project, though - maybe something we need to document? |
| 12:43 |
csharp_ |
I did just open bug 2130356 - which I think is a valid EG-side issue |
| 12:43 |
pinesol |
Launchpad bug 2130356 in Evergreen "Business::ISBN silently errors in added content lookups" [Low,New] https://launchpad.net/bugs/2130356 |
| 12:44 |
|
jihpringle joined #evergreen |
| 13:02 |
csharp_ |
attempting to copy the RangeMessage.xml file into the Debian/Ubuntu-created perl5 directory - we'll see how that goes... |
| 13:13 |
|
jihpringle joined #evergreen |
| 13:19 |
|
jihpringle joined #evergreen |
| 13:54 |
|
jihpringle24 joined #evergreen |
| 14:52 |
csharp_ |
confirming: downloading the RangeMessage.xml file to /usr/share/perl5/Business/ISBN/ improved our success rate with added content lookups |
| 14:53 |
csharp_ |
https://www.isbn-international.org/range_file_generation - where that's located |
| 14:54 |
csharp_ |
still pondering ways to automate that - probably a documentation bug |
| 14:55 |
csharp_ |
it looks like the CPAN package may periodically update their file, perhaps doing updates via that would work? I don't know |
| 14:55 |
csharp_ |
it's a wonder any of this works at all :-) |
| 14:56 |
csharp_ |
*this = the innernet + software, not EG specifically |
| 15:08 |
csharp_ |
bleh - I hate references: ISBN 9786318308045 is invalid: Business::ISBN13=HASH(0x558185c67458)->error_text |
| 15:15 |
csharp_ |
@monologue |
| 15:15 |
pinesol |
csharp_: Your current monologue is at least 24 lines long. |
| 15:15 |
csharp_ |
yes! |
| 15:23 |
|
jihpringle joined #evergreen |
| 15:44 |
|
jihpringle81 joined #evergreen |
| 17:03 |
|
mmorgan left #evergreen |
| 17:23 |
pinesol |
News from commits: LP#2125601: Complete copy_location hold matrix implementation <http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=713104b1e75513fe5d16f7383b6822f6c5f9d3a3> |
| 17:30 |
|
jihpringle joined #evergreen |
