| Time |
Nick |
Message |
| 07:13 |
|
collum joined #evergreen |
| 08:31 |
|
mmorgan joined #evergreen |
| 08:44 |
|
Dyrcona joined #evergreen |
| 08:51 |
|
dguarrac joined #evergreen |
| 09:02 |
pinesol |
News from commits: Docs: LP2109746 - Update librarysettings.adoc <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=fd25769caa46430a6ac78eff033940caa77ffa2d> |
| 09:38 |
|
redavis joined #evergreen |
| 10:53 |
|
sandbergja joined #evergreen |
| 10:59 |
|
mantis1 joined #evergreen |
| 11:27 |
|
Christineb joined #evergreen |
| 11:30 |
Dyrcona |
jeff: Going back to this conversation from Thursday http://irc.evergreen-ils.org/evergreen/2025-05-22#i_578526 is there a Launchpad bug for that? |
| 11:32 |
|
jihpringle joined #evergreen |
| 12:03 |
pinesol |
News from commits: LP#2106667: Remove Fedora Makefile.install target <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=1279b152400d29c1eec4bac38f437242a1c05779> |
| 12:05 |
Dyrcona |
Grr. I wonder if this is another case of PostgreSQL versions changing results. I'm getting test failures with make livecheck: live_t/03-overdue_circ.t, live_t/04-overdue_with_closed_dates.t, and live_t/05-pay_bills.t. |
| 12:20 |
Dyrcona |
Has anything changed in billing since last week? |
| 12:38 |
csharp_ |
sandbergja++ |
| 12:42 |
Dyrcona |
Those 3 tests consistently fail for me on a test vm communicating with a Pg 17 database, but I don't recall them failing last week. |
| 12:54 |
sandbergja |
Dyrcona: those tests are passing for me with pg 17 |
| 12:55 |
Dyrcona |
Well, I guess I'll push the Lp 2111716 branch. I don't think the test failures that I'm seeing have anything to do with it. |
| 12:55 |
pinesol |
Launchpad bug 2111716 in Evergreen "Move t/lp2110251-circ-renewal-field.t to live tests" [Low,Confirmed] https://launchpad.net/bugs/2111716 - Assigned to Jason Stephenson (jstephenson) |
| 12:55 |
sandbergja |
with make livecheck at least, I can reload the db and retry with prove |
| 12:55 |
sandbergja |
Dyrcona++ |
| 12:56 |
Dyrcona |
Well, they're failing for me, unless I'm not looking at the correct database for some reason, but I even did eg_db_config with the options to set the values in opensrf.xml. |
| 12:57 |
Dyrcona |
I don't recall them failing last week, so I don't know what's up. |
| 12:58 |
sandbergja |
yeah, it's interesting that it's just those 3 |
| 12:58 |
csharp_ |
@who moved Dyrcona's server's cheese? |
| 12:58 |
pinesol |
sleary moved Dyrcona's server's cheese. |
| 13:03 |
pinesol |
News from commits: LP2111716: move t/lp2110251-circ-renewal-field.t to live tests <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=b3785515caede05b6286148ea28c88d4f54820ff> |
| 13:11 |
Dyrcona |
Man, it is hard causing a race condition. |
| 14:04 |
|
jihpringle joined #evergreen |
| 14:25 |
mantis1 |
when using the marc stream importer, if one record fails, do the rest fail? |
| 14:44 |
Dyrcona |
mantis1: I have no idea. It uses vandelay. That's all I can say. |
| 15:06 |
mmorgan |
mantis1: Just checked with a colleague more familiar with loading records than I am, hoping for a quick answer. Not an answer, but a suspicion that if one record fails, the rest will not load. Hoping someone else has a better answer. |
| 15:10 |
Dyrcona |
So, I can reproduce the race condition that causes the ACTION_CIRCULATION_NOT_FOUND response to patrons. I got it for 154 autorenewals in my test. Once I adjusted my script a little it became really easy to force it. |
| 15:13 |
mantis1 |
mmorgan: ah that's too bad if that's the case |
| 15:18 |
* Dyrcona |
has to wait for 4:30 to do another test run with the patch applied. |
| 15:19 |
Dyrcona |
I suppose I could run the a/t runner manually.... |
| 15:35 |
Dyrcona |
I also can't seem to get those tests to pass on my other test system today. |
| 15:47 |
sandbergja |
what specific failures do you get Dyrcona? |
| 15:49 |
Dyrcona |
# Failed test 'Thirteen bills associated with circulation' |
| 15:49 |
Dyrcona |
# at live_t/03-overdue_circ.t line 201. |
| 15:49 |
Dyrcona |
# got: '12' |
| 15:49 |
Dyrcona |
# expected: '13' |
| 15:50 |
Dyrcona |
# Failed test 'Twelve bills associated with circulation (instead of 13, thanks to closed date)' |
| 15:50 |
Dyrcona |
# at live_t/04-overdue_with_closed_dates.t line 253. |
| 15:50 |
Dyrcona |
# got: '11' |
| 15:50 |
Dyrcona |
# expected: '12' |
| 15:50 |
Dyrcona |
# Failed test 'Both transactions combined have a balance owed of 1.25' |
| 15:50 |
Dyrcona |
# at live_t/05-pay_bills.t line 102. |
| 15:50 |
Dyrcona |
# got: '1.15' |
| 15:50 |
Dyrcona |
# expected: '1.25' |
| 15:51 |
Dyrcona |
That last one seems familiar. I think I've seen that before. |
| 15:56 |
Dyrcona |
i wonder if it's because the timezone is set to UTC? |
| 16:01 |
Dyrcona |
I'll bet that's it. I've changed the timezone and I'll runt the tests again. I bet it is happening because the db server and test vm don't agree on the time, which is probably a bug of some kind. |
| 16:01 |
Dyrcona |
s/runt/run/ |
| 16:01 |
csharp_ |
rurnt |
| 16:03 |
Dyrcona |
Bingo. |
| 16:04 |
Dyrcona |
My test vm was on UTC and db server is on EDT. Once I changed the timezone on my test vm, the tests started succeeding. |
| 16:05 |
Dyrcona |
I guess the tests are typically run on all on one vm. |
| 16:06 |
Dyrcona |
Why is time so hard? |
| 16:12 |
|
mmorgan1 joined #evergreen |
| 16:17 |
sandbergja |
Dyrcona++ |
| 16:29 |
Rogan |
Dyrcona - because time zones are a human construct so we constructed them about as logically as we do most things of human invention |
| 16:36 |
|
jihpringle joined #evergreen |
| 16:45 |
Dyrcona |
Well, I think we invented time, too. I don't think it's real. |
| 16:46 |
Dyrcona |
Anyway, my patch seems to be working. I'll have to look more closely tomorrow, but I'm getting a bunch of "error" states on the autorenew events this time instead of all of them getting a "complete" state. |
| 16:46 |
Dyrcona |
I have about 77 that should get the state and so far 51 of them have. |
| 16:47 |
* Dyrcona |
clocks out for the day. |
| 16:47 |
berick |
heh |
| 16:47 |
berick |
time isn't real. better clock out! |
| 16:57 |
|
mantis1 left #evergreen |
| 17:07 |
|
mmorgan1 left #evergreen |
| 17:38 |
sandbergja |
haha |
