| Time |
Nick |
Message |
| 07:16 |
|
collum joined #evergreen |
| 08:01 |
|
stephengwills joined #evergreen |
| 08:37 |
|
Dyrcona joined #evergreen |
| 08:38 |
|
mantis1 joined #evergreen |
| 08:47 |
csharp_ |
@band add Beanie Legume |
| 08:47 |
pinesol |
csharp_: Band 'Beanie Legume' added to list |
| 09:13 |
|
mmorgan joined #evergreen |
| 09:31 |
|
dguarrac joined #evergreen |
| 10:26 |
|
mantis1 left #evergreen |
| 10:43 |
berick |
Buh-Buh-Buh-Beanie! |
| 10:49 |
berick |
... Buh-Buh-Buh-Beanie and the Peas |
| 10:54 |
|
smayo joined #evergreen |
| 11:10 |
csharp_ |
berick++ |
| 11:11 |
csharp_ |
<falsetto>Beanieeee</falsetto> |
| 11:13 |
pinesol |
News from commits: LP 2110251: Add renewal field to orc object <https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=56f757de7e5ab3dfa67a18f8e37bbca209def35f> |
| 11:28 |
|
redavis joined #evergreen |
| 12:03 |
|
jihpringle joined #evergreen |
| 12:15 |
Dyrcona |
oof.. typo-- |
| 12:15 |
Dyrcona |
eeevil++ |
| 12:17 |
eeevil |
Dyrcona: oop! I should have caught that typo :) |
| 12:18 |
Dyrcona |
Well, I should have caught it before I submitted the branch. |
| 12:18 |
Dyrcona |
It's not the first, and I'm sure it won't be the last, typo in a commit message. |
| 12:19 |
Dyrcona |
As long as we don't add an "orc" class, I think we're OK. :) |
| 12:19 |
|
collum joined #evergreen |
| 12:28 |
Dyrcona |
hm.. looks like that test should go in live_t/ and not t/. It fails unless services are running. |
| 12:29 |
Dyrcona |
I should have double checked that. I guess I had services running when I thought I didn't. |
| 12:33 |
Dyrcona |
So this is unlrelated to the above, but it's a new one for an autorenewal failure. We had one that apparently failed to retrieve the circulation, and it got set to complete. |
| 12:55 |
Dyrcona |
Also open-ils.trigger appears be logging messages with UTC timestamps... |
| 13:03 |
|
jihpringle joined #evergreen |
| 13:07 |
jihpringle |
Dyrcona: would the open-ils.trigger logging with UTC timestamps potentially be the cause/part of https://bugs.launchpad.net/evergreen/+bug/1838455 ? |
| 13:07 |
pinesol |
Launchpad bug 1838455 in Evergreen "Due time in email checkout receipt is not adjusted to workstation time zone" [Undecided,New] |
| 13:08 |
Dyrcona |
jihpringle: I have no idea if they're related. I just see trigger lines in my logs that are offset 4 hours into the future, which happens to be our offset from UTC. |
| 13:08 |
Dyrcona |
I have likely noticed/mentioned this before. |
| 13:09 |
jihpringle |
it's always fun when Evergreen says things have happened in the future :) |
| 13:11 |
Dyrcona |
:/ |
| 13:13 |
Dyrcona |
It is also fun when an error clearly happened, but the logs don't mention it, and everything else acts as if that's normal. |
| 13:15 |
Dyrcona |
The autorenew and autorenewnotify events both are complete and the patron got a notice saying the renewal failed because "Someone attempted to retrieve a circulation object from the system and the object was not found." |
| 13:15 |
Dyrcona |
When I search the database for that, I find 45 other times it has happened since February 9. |
| 13:16 |
jihpringle |
well that's not a very patron friendly error message |
| 13:18 |
Dyrcona |
It shouldn't even reach the patron, IMHO. The event should get an error state. |
| 13:19 |
jihpringle |
ya, an error state would make a lot more sense |
| 13:21 |
Dyrcona |
I think the problem is that the autorenew reactor isn't differentiating between renewal responses. A failure to renew is returned as an error, so the code treats all errors as a failure to renew. A failure to retrieve the circulation (particularly when it actually exists) is different. |
| 13:21 |
|
jihpringle joined #evergreen |
| 13:50 |
Dyrcona |
Further investigation reveals that the items may have been returned while the autorenew process was running on those circulations. I'll have to check the other events. |
| 14:01 |
|
stephengwills left #evergreen |
| 14:01 |
jeff |
that was the usual reason for "Someone attempted to retrieve a circulation object from the system and the object was not found" during renewals, in our experience. |
| 14:02 |
jeff |
(because the renewal takes a barcode instead of a circ ID as an argument, and if the item's returned, the attempt to map barcode to "open circ on this item" fails to get a circ) |
| 14:02 |
jeff |
I've probably talked here about that before. |
| 14:20 |
Dyrcona |
jeff++ |
| 14:21 |
Dyrcona |
I still see retrieve calls for the circulation (open-ils.cstore.direct.action.circulation.retrieve) event though the search appears to fail. |
| 14:21 |
Dyrcona |
s/event/even/ |
| 14:22 |
Dyrcona |
I'm not certain of the order just yet. I might stop looking at this point since the question is answered. I would like to fix this though so that patrons don't get bizarre notices. |
| 14:24 |
|
Christineb joined #evergreen |
| 14:43 |
Dyrcona |
So... the checkin happens after the validator runs but before the reactor finishes reacting, and a failure to renew is not considered an error, so it's reported to the patron. I wonder how hard it would be to change that for this one case, that happens often enough to get reported? |
| 14:47 |
Dyrcona |
I suppose it is too late to set an invalid state, but maybe I could give it an error state.... That's better than sending the patron a bogus notification. |
| 14:49 |
Dyrcona |
Looking at this, I'm a little mystified how the error stat gets set if the AutorenewNotify fails, since the reactor always returns 1. The caller must be checking for an error object somewhere. |
| 14:56 |
Dyrcona |
Looks like I can probably add a line to check the textcode and throw the event. That should set an error state. |
| 14:58 |
Dyrcona |
This would be difficult to test.... |
| 15:00 |
berick |
grr, Zoom |
| 15:00 |
berick |
for anyone on the Rust session, cannot install Zoom at the moment. dependency funkiness |
| 15:00 |
berick |
i'll be on in a sec |
| 15:40 |
csharp_ |
oh - I wanted to be on that but had it down as 4pm |
| 15:40 |
csharp_ |
oh well |
| 15:41 |
redavis |
csharp_ pop in. It's ongoing. But it is recording if you want to watch. Let me know, and I'll send the link. Not making it public yet(maybe never). |
| 15:41 |
Dyrcona |
zoom-- |
| 15:42 |
redavis |
There will also be some notes and an email that goes out probably tomorrow or Tuesday about ongoing meetings. |
| 15:42 |
csharp_ |
I hate zoom |
| 15:42 |
csharp_ |
redavis: thanks |
| 15:43 |
redavis |
np |
| 15:43 |
* Dyrcona |
had technical difficulties with sound and this stupid usb dock thing, etc. When I had volume it was low, when I finally "fixed" it, it just stopped after a while and no fiddling with settings would bring it back. |
| 15:43 |
csharp_ |
Dyrcona: happens to me all the time on Fedora |
| 15:43 |
redavis |
Dyrcona, ugh. |
| 15:43 |
csharp_ |
I usually just use my phone app |
| 15:43 |
csharp_ |
which is useless for screen sharing obviously |
| 15:43 |
Dyrcona |
It works with the headset that I left in my other bag at home.... |
| 15:44 |
Dyrcona |
I would have used the phone, but I needed the meeting id. Didn't have it. I just gave up. |
| 15:44 |
csharp_ |
:-( |
| 15:46 |
redavis |
Dyrcona, I'll make sure that the full zoom invitation is included in the upcoming events that includes the meeting ID without hiding it in the URL |
| 15:46 |
Dyrcona |
At a certain level we shouldn't be using Zoom. |
| 15:47 |
redavis |
What level is that? |
| 15:47 |
Dyrcona |
the philosophical level. |
| 15:48 |
csharp_ |
F/LOSS projects & closed source platforms are not great |
| 15:48 |
redavis |
well, that doesn't really do much for coordinating community collaboration. |
| 15:48 |
csharp_ |
but I'm pragmatic enough to use tools people are familiar with and meet them where they are |
| 15:48 |
redavis |
very open to other options |
| 15:49 |
csharp_ |
we looked into https://jitsi.org/ some years back |
| 15:52 |
Dyrcona |
Well, my change to AutoRenew.pm hasn't broken anything. I don't know if it actually works. I'll have to figure out how to exercise it tomorrow. |
| 15:56 |
Dyrcona |
Guess, I'll find some circulations on my test system that would renew tomorrow, and then set something up to checkin a bunch of them while I also run the Autorenew process. That's about the best that I can do. I wonder if I could peek on the process to see where it's at and force a checkin at the right moment? |
| 15:58 |
|
mmorgan left #evergreen |
| 15:59 |
|
jihpringle joined #evergreen |
| 16:00 |
eeevil |
Dyrcona: re make a reactor fail, just die(), the caller will catch it |
| 16:02 |
Dyrcona |
eeevil: That might work. I'll give that a shot if the throw doesn't work well enough. |
| 16:04 |
Dyrcona |
I suspect, but have not verified, that throw ends up calling die anyway. |
| 16:04 |
eeevil |
oh, throw should work. that die()s too |
| 16:04 |
eeevil |
yeah |
| 16:09 |
sleary |
one of my favorite commit messages from WordPress was "customizable death" (passing a message to the die() wrapper) |
| 16:10 |
csharp_ |
sleary++ |
| 16:12 |
JBoyer |
Fellow Zoom haters, assuming you use Chrome, does the regular "launch in browser" mode work ok or do you *have* to have the client installed? |
| 16:12 |
csharp_ |
JBoyer: I've never tried the in-browser option |
| 16:13 |
JBoyer |
I was thinking I went browser-only for that and maybe Teams and was much happier as a result. (I may also just be forgetting how long it's been since having to zoom about.) |
| 16:13 |
JBoyer |
That relies on the browser's access to your camera and mic, and I bet Google has that working on whatever you're running, even if Zoom can't figure it out. |
| 16:13 |
eeevil |
I have to use the full-on client (linux, here. may be different on winders or mac?) |
| 16:14 |
JBoyer |
I thought it did work in Linux (same here) so maybe it has just been a long time since I've had to use it. :/ |
| 16:15 |
csharp_ |
JBoyer++ # just tested the in browser link (meekly placed below the other options) and it appears to work ok |
| 16:15 |
Dyrcona |
I haven't tried zoom in the browser on Linux, and when I click a zoom link, it opens the full-on client. |
| 16:15 |
csharp_ |
I'll try that next time |
| 16:15 |
Dyrcona |
I'll give it a try, too. |
| 16:15 |
eeevil |
chrome seems fully capable in all other vid-conf/screen-share apps, so I think it's a zoom thing... but, I'm an admitted member of the zoom haters club |
| 16:15 |
csharp_ |
"Having issues with the Zoom Workplace app? Join from your browser" |
| 16:16 |
csharp_ |
@band add The Zoom Haters |
| 16:16 |
pinesol |
csharp_: Band 'The Zoom Haters' added to list |
| 16:16 |
Dyrcona |
Well, every time I start Zoom Workplace, it pops up multiple windows telling me it had a problem and I should report it to Zoom. |
| 16:16 |
csharp_ |
@decide The Zoom Haters or The Queen Haters? |
| 16:16 |
pinesol |
csharp_: That's a tough one... |
| 16:16 |
eeevil |
csharp_: I will try that next time. if it mostly works, I will do a little dance as I apt purge the client |
| 16:16 |
csharp_ |
eeevil: make sure to post video of your dance so we can all enjoy |
| 16:17 |
eeevil |
oh, I will, sir |
| 16:17 |
eeevil |
I'll learn how to floss for that dance |
| 16:18 |
Dyrcona |
Anyway, I think I have a solution to triggering my bug: I'll write something that grabs validated events and then checks in the copies associated with the events. That should let me know if my code works or not. |
| 16:20 |
Dyrcona |
I can limit the number and the org unit to simplify things and not checkin everything. |
| 16:21 |
redavis |
fwiw, i only use teams in the browser. otherwise it crashes everything |
| 16:22 |
eeevil |
Dyrcona: oh, you can return undef from the reactor sub if you don't want to die() (directly or indirectly). it will still attempt to create a user message, if usr_messge.usr and .template exist for the event def, but it will record the event as an error. |
| 16:23 |
Dyrcona |
eeevil: In this case, there's no template. The reactor creates another event that handles the message. I have it die just before that. |
| 16:24 |
eeevil |
(see OpenILS/Application/Trigger/Event.pm:194-233) |
| 16:24 |
Dyrcona |
i will see those lines tomorrow. |
| 16:24 |
* Dyrcona |
prepares to shutdown for the day. |
| 16:25 |
Dyrcona |
Chat with ya'll tomorrow! |
